Hello Morimoto-san
Thanks for testing and fixing this driver, but I think there's one slight
issue with your patch:
On Tue, 11 May 2010, Kuninori Morimoto wrote:
These function are needed to use camera.
This patch was tested with sh_mobile_ceu_camera
Signed-off-by: Kuninori Morimoto
On Mon, 10 May 2010, Guennadi Liakhovetski wrote:
(added Laurent to CC as he once asked me about these on IRC too)
On Sun, 9 May 2010, Hans Verkuil wrote:
Hi Guennadi,
I'm preparing a patch series that replaces enum/g/try/s_fmt with
enum/g/try/s/_mbus_fmt in all subdevs. While
Dear Guennadi
Thank you for checking patch
+static int soc_camera_platform_s_fmt(struct v4l2_subdev *sd,
+struct v4l2_mbus_framefmt *mf)
+{
+ return 0;
This function needs not only return 0, but also fill fmt with the current
pixel format.
sorry.
On Tue, 11 May 2010, Kuninori Morimoto wrote:
Dear Guennadi
Thank you for checking patch
+static int soc_camera_platform_s_fmt(struct v4l2_subdev *sd,
+ struct v4l2_mbus_framefmt *mf)
+{
+ return 0;
This function needs not only return 0, but
These function are needed to use camera.
This patch was tested with sh_mobile_ceu_camera
Signed-off-by: Kuninori Morimoto kuninori.morimoto...@renesas.com
---
v1 - v2
o rename soc_camera_platform_try_fmt = soc_camera_platform_fill_fmt
o .try_mbus_fmt / .g_mbus_fmt / .s_mbus_fmt use
Dear Guennadi
@@ -65,6 +65,7 @@ static int soc_camera_platform_try_fmt(struct v4l2_subdev
*sd,
mf-height = p-format.height;
mf-code= p-format.code;
mf-colorspace = p-format.colorspace;
+ mf-field = V4L2_FIELD_NONE;
I added this in v2.
But I
These function are needed to use camera.
This patch was tested with sh_mobile_ceu_camera
Signed-off-by: Kuninori Morimoto kuninori.morimoto...@renesas.com
---
v2 - v3
o use p-format.field instead of V4L2_FIELD_NONE
drivers/media/video/soc_camera_platform.c | 42 ++--
-Original Message-
From: Hans Verkuil [mailto:hverk...@xs4all.nl]
Sent: Sunday, May 09, 2010 7:27 PM
To: linux-media@vger.kernel.org
Cc: Hiremath, Vaibhav
Subject: [PATCH 1/6] [RFC] tvp514x: do NOT change the std as a side effect
Several calls (try_fmt, g_parm among others)
-Original Message-
From: Hans Verkuil [mailto:hverk...@xs4all.nl]
Sent: Sunday, May 09, 2010 7:27 PM
To: linux-media@vger.kernel.org
Cc: Hiremath, Vaibhav
Subject: [PATCH 2/6] [RFC] tvp514x: make std_list const
Signed-off-by: Hans Verkuil hverk...@xs4all.nl
---
-Original Message-
From: Hans Verkuil [mailto:hverk...@xs4all.nl]
Sent: Sunday, May 09, 2010 7:27 PM
To: linux-media@vger.kernel.org
Cc: Hiremath, Vaibhav
Subject: [PATCH 3/6] [RFC] tvp514x: there is only one supported format, so
simplify the code
Get rid of unnecessary code
-Original Message-
From: Hans Verkuil [mailto:hverk...@xs4all.nl]
Sent: Sunday, May 09, 2010 7:27 PM
To: linux-media@vger.kernel.org
Cc: Hiremath, Vaibhav
Subject: [PATCH 5/6] [RFC] tvp514x: remove obsolete fmt_list
Signed-off-by: Hans Verkuil hverk...@xs4all.nl
---
-Original Message-
From: Hans Verkuil [mailto:hverk...@xs4all.nl]
Sent: Sunday, May 09, 2010 7:27 PM
To: linux-media@vger.kernel.org
Cc: Hiremath, Vaibhav
Subject: [PATCH 4/6] [RFC] tvp514x: add missing newlines
Signed-off-by: Hans Verkuil hverk...@xs4all.nl
---
-Original Message-
From: Hans Verkuil [mailto:hverk...@xs4all.nl]
Sent: Sunday, May 09, 2010 7:27 PM
To: linux-media@vger.kernel.org
Cc: Hiremath, Vaibhav
Subject: [PATCH 6/6] [RFC] tvp514x: simplify try/g/s_fmt handling
Since there is only one possible format just have all three
Hi everybody,
Here are 7 videobuf patches that cleanup the internal API and the
videobuf_dma_sg public API. They remove unneeded functions, avoid exporting
internal ones, rename some of them to less confusing names and try to stop some
API abuse from drivers.
One of my goals was to remove
From: Pawel Osciak p.osc...@samsung.com
These functions allocate videobuf_buffer structures only. Renaming in order
to prevent confusion with functions allocating actual video buffer memory.
Signed-off-by: Pawel Osciak p.osc...@samsung.com
Rename the functions in videobuf-core.h
From: Pawel Osciak p.osc...@samsung.com
This function is not specific to mmap, hence the rename.
Add a check whether we are not streaming or reading (for read mode that
uses the stream queue) before freeing anything.
Signed-off-by: Pawel Osciak p.osc...@samsung.com
---
The cx88 and cx25821 drivers abuse videobuf_buffer to handle audio data.
Remove the abuse by creating private audio buffer structures with a
videobuf_dmabuf field.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/media/video/cx88/cx88-alsa.c | 29
The fields are assigned but never used, remove them.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/media/video/videobuf-dma-contig.c |2 --
drivers/media/video/videobuf-dma-sg.c |2 --
drivers/media/video/videobuf-vmalloc.c|2 --
The videobuf_dmabuf and videobuf_vmalloc_memory fields have a vmalloc
field to store the kernel virtual address of vmalloc'ed buffers. Rename
the field to vaddr.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/media/video/cx88/cx88-alsa.c |2 +-
Those functions are only called inside videobuf-dma-sg.c, make them
static.
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/media/video/videobuf-dma-sg.c | 18 ++
include/media/videobuf-dma-sg.h | 17 -
2 files changed, 14
Instead of creating dirty wrappers around videobuf_dma_map/unmap that
create a dummy videobuf_queue structure, modify videobuf_dma_map/unmap
to take a device pointer argument and use it directly. The
videobuf_sg_dma_map/unmap then become unused and can be removed.
Signed-off-by: Laurent Pinchart
I finally gave up using this card. I replaced it with an old
Hauppauge WinTV Nova-S in the same PCI slot and the same transponder
is received fine. No discontinuity is observed. Using the Nova-HD-S2
in the same PCI slot, on the same transponder, gave a lot of
discontinuities, correlated with the
This message is generated daily by a cron job that builds v4l-dvb for
the kernels and architectures in the list below.
Results of the daily build of v4l-dvb:
date:Tue May 11 19:00:25 CEST 2010
path:http://www.linuxtv.org/hg/v4l-dvb
changeset: 14743:8023f45dd06e
git master:
Am Mittwoch 05 Mai 2010 17:20:21 schrieb Peter Hüwe:
From: Peter Huewe peterhu...@gmx.de
This patch adds a missing include linux/delay.h to prevent
build failures[1-5]
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
Any updates on this patch?
Issue still exists with today's linux-next
Hi Thierry,
Am Dienstag, den 11.05.2010, 16:50 +0200 schrieb Thierry LELEGARD:
I finally gave up using this card. I replaced it with an old
Hauppauge WinTV Nova-S in the same PCI slot and the same transponder
is received fine. No discontinuity is observed. Using the Nova-HD-S2
in the same PCI
HI
I tried to fix unreliable IR remote keys (cca 10% lost key presses),
the similar problem has been reported on the same card with
windows driver too and I had other saa7134 analog tv card also
loosing IR keys
I have tried modifying saa7134-input.c to use gpio polling with interval
of 15ms and
26 matches
Mail list logo
