Re: V4L hg tree fails to compile against kernel 2.6.28
Thanks for your help. I pulled the code Actually, now the function definition in compat.h causes a compilation error: see first text below. I fixed that by inserting #include at line 38 in compat.h in my local branch After that, compilation succeeds. Now, the device will not install, as dvb_usb cannot install anymore. see second text below. Therefore, I have replaced the __kmalloc_track_caller with kmalloc (as it was in dvb_demux.c before the change 2ceef3d75547 at line 49 can you make both changes in the hg branch ? - make[2]: Entering directory `/usr/src/linux-headers-2.6.28-19-generic' CC [M] tuner-xc2028.o In file included from tuner-xc2028.c:19: compat.h: In function 'memdup_user': compat.h:50: error: implicit declaration of function 'ERR_PTR' compat.h:50: warning: return makes pointer from integer without a cast compat.h:54: warning: return makes pointer from integer without a cast In file included from include/linux/fs.h:1891, from include/linux/poll.h:11, from dvbdev.h:27, from dvb_frontend.h:43, from tuner-xc2028.h:10, from tuner-xc2028.c:22: include/linux/err.h: At top level: include/linux/err.h:22: error: conflicting types for 'ERR_PTR' sudo modprobe dvb-usb-rtl2831u ir_protocol=2 WARNING: Error inserting dvb_usb (/lib/modules/2.6.28-19-generic/kernel/drivers/media/dvb/dvb-usb/dvb-usb.ko): Unknown symbol in module, or unknown parameter (see dmesg) WARNING: Error inserting dvb_usb_dibusb_common (/lib/modules/2.6.28-19-generic/kernel/drivers/media/dvb/dvb-usb/dvb-usb-dibusb-common.ko): Unknown symbol in module, or unknown parameter (see dmesg) FATAL: Error inserting dvb_usb_rtl2831u (/lib/modules/2.6.28-19-generic/kernel/drivers/media/dvb/rtl2831/dvb-usb-rtl2831u.ko): Unknown symbol in module, or unknown parameter (see dmesg) in the system log, I find: dvb_core: Unknown symbol __kmalloc_track_caller dvb_core: Unknown symbol __kmalloc_track_caller Douglas Schilling Landgraf wrote: Hello Jan, On Tue, Aug 24, 2010 at 5:04 PM, Jan Hoogenraad wrote: Douglas: On compiling with Linux 2.6.28-19-generic #62-Ubuntu I now get: dvb_demux.c: In function 'dvbdmx_write': dvb_demux.c:1137: error: implicit declaration of function 'memdup_user' dvb_demux.c:1137: warning: assignment makes pointer from integer without a cast This is probably due to changeset 2ceef3d75547 which introduced the use of this function: http://linuxtv.org/hg/v4l-dvb/diff/2ceef3d75547/linux/drivers/media/dvb/dvb-core/dvb_demux.c This function is not available in linux/string.h in kernel 2.6.29 and lower. http://lxr.free-electrons.com/source/include/linux/string.h?v=2.6.28 Could you please advise me on what to do ? For this issue, I have fixed right now, please try again with a updated repository. But since I have commited several patches yesterday, we have another one that probably will reach your compilantion (the kfifo one). I will work to fix this one too. Thanks for the report. Cheers Douglas -- Jan Hoogenraad Hoogenraad Interface Services Postbus 2717 3500 GS Utrecht -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: V4L hg tree fails to compile against kernel 2.6.28
Hi, On Tue, Aug 24, 2010 at 11:45 PM, Douglas Schilling Landgraf wrote: > Hello Jan, > > On Tue, Aug 24, 2010 at 5:04 PM, Jan Hoogenraad > wrote: >> Douglas: >> >> On compiling with Linux 2.6.28-19-generic #62-Ubuntu >> >> I now get: >> >> dvb_demux.c: In function 'dvbdmx_write': >> dvb_demux.c:1137: error: implicit declaration of function 'memdup_user' >> dvb_demux.c:1137: warning: assignment makes pointer from integer without a >> cast >> >> This is probably due to changeset 2ceef3d75547 >> >> which introduced the use of this function: >> http://linuxtv.org/hg/v4l-dvb/diff/2ceef3d75547/linux/drivers/media/dvb/dvb-core/dvb_demux.c >> >> This function is not available in linux/string.h in kernel 2.6.29 and lower. >> >> http://lxr.free-electrons.com/source/include/linux/string.h?v=2.6.28 >> >> Could you please advise me on what to do ? > > For this issue, I have fixed right now, please try again with a > updated repository. But since I have commited several patches > yesterday, > we have another one that probably will reach your compilantion (the > kfifo one). I will work to fix this one too. > > Thanks for the report. Ok, should be working right now, I have made the backports needed/adjusts to compile agains 2.6.29. Let me know if you have any problem. Tomorrow I will continue commiting patches to get hg synced with git. Thanks Douglas -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: V4L hg tree fails to compile against kernel 2.6.28
Hello Jan, On Tue, Aug 24, 2010 at 5:04 PM, Jan Hoogenraad wrote: > Douglas: > > On compiling with Linux 2.6.28-19-generic #62-Ubuntu > > I now get: > > dvb_demux.c: In function 'dvbdmx_write': > dvb_demux.c:1137: error: implicit declaration of function 'memdup_user' > dvb_demux.c:1137: warning: assignment makes pointer from integer without a > cast > > This is probably due to changeset 2ceef3d75547 > > which introduced the use of this function: > http://linuxtv.org/hg/v4l-dvb/diff/2ceef3d75547/linux/drivers/media/dvb/dvb-core/dvb_demux.c > > This function is not available in linux/string.h in kernel 2.6.29 and lower. > > http://lxr.free-electrons.com/source/include/linux/string.h?v=2.6.28 > > Could you please advise me on what to do ? For this issue, I have fixed right now, please try again with a updated repository. But since I have commited several patches yesterday, we have another one that probably will reach your compilantion (the kfifo one). I will work to fix this one too. Thanks for the report. Cheers Douglas -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 2/3] remove remaining users of the ir-functions keyhandlers
This patch removes the remaining usages of the ir_input_nokey() and
ir_input_keydown() functions provided by drivers/media/IR/ir-functions.c
by using the corresponding functionality in rc-core directly instead.
---
drivers/media/IR/ir-functions.c | 96 ++-
drivers/media/IR/rc-core.c | 114 +--
drivers/media/video/bt8xx/bttv-input.c | 26 ++
drivers/media/video/bt8xx/bttvp.h |1
drivers/media/video/cx18/cx18-i2c.c |1
drivers/media/video/cx23885/cx23885-input.c | 59 +-
drivers/media/video/cx88/cx88-input.c | 24 ++
drivers/media/video/ir-kbd-i2c.c| 14 ---
drivers/media/video/ivtv/ivtv-i2c.c |3 -
drivers/media/video/saa7134/saa7134-input.c | 50 ++--
include/media/ir-common.h | 29 +--
include/media/ir-core.h |2
include/media/ir-kbd-i2c.h |3 -
13 files changed, 131 insertions(+), 291 deletions(-)
diff --git a/drivers/media/IR/ir-functions.c b/drivers/media/IR/ir-functions.c
index db591e4..77faf7a 100644
--- a/drivers/media/IR/ir-functions.c
+++ b/drivers/media/IR/ir-functions.c
@@ -1,7 +1,8 @@
/*
*
- * some common structs and functions to handle infrared remotes via
- * input layer ...
+ * some common functions to handle infrared remote protocol decoding for
+ * drivers which have not yet been (or can't be) converted to use the
+ * regular protocol decoders...
*
* (c) 2003 Gerd Knorr [SuSE Labs]
*
@@ -31,67 +32,6 @@
MODULE_AUTHOR("Gerd Knorr [SuSE Labs]");
MODULE_LICENSE("GPL");
-static int repeat = 1;
-module_param(repeat, int, 0444);
-MODULE_PARM_DESC(repeat,"auto-repeat for IR keys (default: on)");
-
-/* --
*/
-
-static void ir_input_key_event(struct input_dev *dev, struct ir_input_state
*ir)
-{
- if (KEY_RESERVED == ir->keycode) {
- printk(KERN_INFO "%s: unknown key: key=0x%02x down=%d\n",
- dev->name, ir->ir_key, ir->keypressed);
- return;
- }
- IR_dprintk(1,"%s: key event code=%d down=%d\n",
- dev->name,ir->keycode,ir->keypressed);
- input_report_key(dev,ir->keycode,ir->keypressed);
- input_sync(dev);
-}
-
-/* --
*/
-
-int ir_input_init(struct input_dev *dev, struct ir_input_state *ir,
- const u64 ir_type)
-{
- ir->ir_type = ir_type;
-
- if (repeat)
- set_bit(EV_REP, dev->evbit);
-
- return 0;
-}
-EXPORT_SYMBOL_GPL(ir_input_init);
-
-
-void ir_input_nokey(struct input_dev *dev, struct ir_input_state *ir)
-{
- if (ir->keypressed) {
- ir->keypressed = 0;
- ir_input_key_event(dev,ir);
- }
-}
-EXPORT_SYMBOL_GPL(ir_input_nokey);
-
-void ir_input_keydown(struct input_dev *dev, struct ir_input_state *ir,
- u32 ir_key)
-{
- u32 keycode = ir_g_keycode_from_table(dev, ir_key);
-
- if (ir->keypressed && ir->keycode != keycode) {
- ir->keypressed = 0;
- ir_input_key_event(dev,ir);
- }
- if (!ir->keypressed) {
- ir->ir_key = ir_key;
- ir->keycode = keycode;
- ir->keypressed = 1;
- ir_input_key_event(dev,ir);
- }
-}
-EXPORT_SYMBOL_GPL(ir_input_keydown);
-
/* --
*/
/* extract mask bits out of data and pack them into the result */
u32 ir_extract_bits(u32 data, u32 mask)
@@ -284,7 +224,7 @@ void ir_rc5_timer_end(unsigned long data)
{
struct card_ir *ir = (struct card_ir *)data;
struct timeval tv;
- unsigned long current_jiffies, timeout;
+ unsigned long current_jiffies;
u32 gap;
u32 rc5 = 0;
@@ -325,32 +265,12 @@ void ir_rc5_timer_end(unsigned long data)
u32 toggle = RC5_TOGGLE(rc5);
u32 instr = RC5_INSTR(rc5);
- /* Good code, decide if repeat/repress */
- if (toggle != RC5_TOGGLE(ir->last_rc5) ||
- instr != RC5_INSTR(ir->last_rc5)) {
- IR_dprintk(1, "ir-common: instruction %x,
toggle %x\n", instr,
- toggle);
- ir_input_nokey(ir->dev, &ir->ir);
- ir_input_keydown(ir->dev, &ir->ir, instr);
- }
-
- /* Set/reset key-up timer */
- timeout = current_jiffies +
- msecs_to_jiffies(ir->rc5_key_timeout);
- mod_timer(&ir->timer_keyup, timeout);
-
- /* Save code for repeat test */
- ir->
[PATCH 0/3] Proposed ir-core (rc-core) changes
The following series merges the different files that currently make up the ir-core module into a single-file rc-core module. In addition, the ir_input_dev and ir_dev_props structs are replaced by a single rc_dev struct with an API similar to that of the input subsystem. This allows the removal of all knowledge of any input devices from the rc drivers and paves the way for allowing multiple input devices per rc device in the future. The namespace conversion from ir_* to rc_* should mostly be done for the drivers with this patchset. I have intentionally not signed off on the patches yet since they haven't been tested. I'd like your feedback on the general approach before I spend the time to properly test the result. Also, the imon driver is not converted (and will thus break with this patchset). The reason is that the imon driver wants to generate mouse events on the input dev under the control of rc-core. I was hoping that Jarod would be willing to convert the imon driver to create a separate input device for sending mouse events to userspace :) Comments please... --- David Härdeman (3): merge rc-core remove remaining users of the ir-functions keyhandlers make rc_dev the primary interface for remote control drivers drivers/media/IR/Makefile |3 drivers/media/IR/ir-core-priv.h | 26 - drivers/media/IR/ir-functions.c | 96 -- drivers/media/IR/ir-jvc-decoder.c | 13 drivers/media/IR/ir-keytable.c | 552 drivers/media/IR/ir-lirc-codec.c| 75 +- drivers/media/IR/ir-nec-decoder.c | 13 drivers/media/IR/ir-raw-event.c | 270 -- drivers/media/IR/ir-rc5-decoder.c | 13 drivers/media/IR/ir-rc6-decoder.c | 17 drivers/media/IR/ir-sony-decoder.c | 11 drivers/media/IR/ir-sysfs.c | 354 drivers/media/IR/mceusb.c | 99 +- drivers/media/IR/rc-core.c | 1206 +++ drivers/media/IR/rc-map.c | 84 -- drivers/media/dvb/dm1105/dm1105.c | 45 + drivers/media/dvb/mantis/mantis_common.h|4 drivers/media/dvb/mantis/mantis_input.c | 61 + drivers/media/dvb/ttpci/budget-ci.c | 49 - drivers/media/video/bt8xx/bttv-input.c | 67 +- drivers/media/video/bt8xx/bttvp.h |1 drivers/media/video/cx18/cx18-i2c.c |1 drivers/media/video/cx23885/cx23885-input.c | 93 -- drivers/media/video/cx88/cx88-input.c | 86 +- drivers/media/video/em28xx/em28xx-input.c | 71 +- drivers/media/video/ir-kbd-i2c.c| 41 - drivers/media/video/ivtv/ivtv-i2c.c |3 drivers/media/video/saa7134/saa7134-input.c | 121 +-- include/media/ir-common.h | 32 - include/media/ir-core.h | 155 ++- include/media/ir-kbd-i2c.h |5 31 files changed, 1655 insertions(+), 2012 deletions(-) delete mode 100644 drivers/media/IR/ir-keytable.c delete mode 100644 drivers/media/IR/ir-raw-event.c delete mode 100644 drivers/media/IR/ir-sysfs.c create mode 100644 drivers/media/IR/rc-core.c delete mode 100644 drivers/media/IR/rc-map.c -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] mt9t031: Fixes field names that changed
On Thu, 19 Aug 2010, Henrique Camargo wrote:
> If CONFIG_VIDEO_ADV_DEBUG was set, the driver failed to compile
> because the fields get_register and set_register changed names to
> g_register and s_register in the struct v4l2_subdev_core_ops.
>
> Signed-off-by: Henrique Camargo
> ---
> drivers/media/video/mt9t031.c |4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/video/mt9t031.c b/drivers/media/video/mt9t031.c
> index 716fea6..f3d1995 100644
> --- a/drivers/media/video/mt9t031.c
> +++ b/drivers/media/video/mt9t031.c
> @@ -499,8 +499,8 @@ static const struct v4l2_subdev_core_ops mt9t031_core_ops
> = {
> .g_ctrl = mt9t031_get_control,
> .s_ctrl = mt9t031_set_control,
> #ifdef CONFIG_VIDEO_ADV_DEBUG
> - .get_register = mt9t031_get_register,
> - .set_register = mt9t031_set_register,
> + .g_register = mt9t031_get_register,
> + .s_register = mt9t031_set_register,
> #endif
> };
>
> --
> 1.7.0.4
I might be missing something obvious, but I do not understand against
which tree / version is this patch? I don't see this problem in the
mainline.
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] V4L/DVB: mantis: Fix IR_CORE dependency
Em 24-08-2010 16:30, Ingo Molnar escreveu: > > * Randy Dunlap wrote: > >> On 08/24/10 01:45, Ingo Molnar wrote: >>> >>> * Mauro Carvalho Chehab wrote: >>> Linus, Please pull from: ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git v4l_for_linus For 3 build fixes. Cheers, Mauro. The following changes since commit ad41a1e0cab07c5125456e8d38e5b1ab148d04aa: Merge branch 'io_remap_pfn_range' of git://www.jni.nu/cris (2010-08-12 10:17:19 -0700) are available in the git repository at: ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git v4l_for_linus Mauro Carvalho Chehab (2): V4L/DVB: Fix IR_CORE dependencies V4L/DVB: fix Kconfig to depends on VIDEO_IR Randy Dunlap (1): V4L/DVB: v4l2-ctrls.c: needs to include slab.h >>> >>> FYI, there's one more IR_CORE related build bug which triggers >>> frequently in randconfig tests - see the fix below. >>> >>> Thanks, >>> >>> Ingo >>> >>> ---> >>> From c56aef270d7ec01564c632c1f7ebab6b8f9f032c Mon Sep 17 00:00:00 2001 >>> From: Ingo Molnar >>> Date: Tue, 24 Aug 2010 10:41:33 +0200 >>> Subject: [PATCH] V4L/DVB: mantis: Fix IR_CORE dependency >>> >>> This build bug triggers: >>> >>> drivers/built-in.o: In function `mantis_exit': >>> (.text+0x377413): undefined reference to `ir_input_unregister' >>> drivers/built-in.o: In function `mantis_input_init': >>> (.text+0x3774ff): undefined reference to `__ir_input_register' >>> >>> If MANTIS_CORE is enabled but IR_CORE is not. Add the correct >>> dependency. >>> >>> Signed-off-by: Ingo Molnar >>> --- >>> drivers/media/dvb/mantis/Kconfig |2 +- >>> 1 files changed, 1 insertions(+), 1 deletions(-) >>> >>> diff --git a/drivers/media/dvb/mantis/Kconfig >>> b/drivers/media/dvb/mantis/Kconfig >>> index decdeda..fd0830e 100644 >>> --- a/drivers/media/dvb/mantis/Kconfig >>> +++ b/drivers/media/dvb/mantis/Kconfig >>> @@ -1,6 +1,6 @@ >>> config MANTIS_CORE >>> tristate "Mantis/Hopper PCI bridge based devices" >>> - depends on PCI && I2C && INPUT >>> + depends on PCI && I2C && INPUT && IR_CORE >>> >>> help >>> Support for PCI cards based on the Mantis and Hopper PCi bridge. >> >> >> Acked-by: Randy Dunlap >> http://lkml.org/lkml/2010/8/17/341 > > Your patch came first :-) > > Btw., the reason i missed your patch is that i grepped lkml for the > static build failure - while your changelog contained the modular one. > Oh well :) I've added this patch earlier today on my tree: http://git.linuxtv.org/media_tree.git?a=commit;h=3a057c36346f60bd0fb4fe7d7a68c4d931d8768f and the other IR_CORE fixup at staging/tm6000: http://git.linuxtv.org/media_tree.git?a=commit;h=926a2496438f44268130f72f5e102dcac484573d I'll be sending them today to my linux-next tree and likely tomorrow to upstream, together with a few other fixes. > > Thanks, > > Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
V4L hg tree fails to compile against kernel 2.6.28
Douglas: On compiling with Linux 2.6.28-19-generic #62-Ubuntu I now get: dvb_demux.c: In function 'dvbdmx_write': dvb_demux.c:1137: error: implicit declaration of function 'memdup_user' dvb_demux.c:1137: warning: assignment makes pointer from integer without a cast This is probably due to changeset 2ceef3d75547 which introduced the use of this function: http://linuxtv.org/hg/v4l-dvb/diff/2ceef3d75547/linux/drivers/media/dvb/dvb-core/dvb_demux.c This function is not available in linux/string.h in kernel 2.6.29 and lower. http://lxr.free-electrons.com/source/include/linux/string.h?v=2.6.28 Could you please advise me on what to do ? Douglas Schilling Landgraf wrote: Hello Derek, On Sun, Aug 15, 2010 at 2:22 AM, Douglas Schilling Landgraf wrote: Hello Derek, On Sat, Aug 14, 2010 at 12:46 PM, VDR User wrote: On Wed, Aug 4, 2010 at 10:19 PM, Douglas Schilling Landgraf wrote: I am already working to give a full update to hg tree. Sorry this problem. Hi Douglas. Any estimate when this will be fixed? Was hoping it was already since new stable kernel 2.6.35.2 is out now but still the same problem when I tried just now. I am already working on it this weekend. I will reply this thread when finished. 2.6.35 should be working, let me know if not. Now, I need to backport the changes to old kernels and commit other patches in my pending list. Cheers Douglas -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Jan Hoogenraad Hoogenraad Interface Services Postbus 2717 3500 GS Utrecht -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 2/2] tm6000: bugfix data handling
From: Stefan Ringel
Signed-off-by: Stefan Ringel
---
drivers/staging/tm6000/tm6000-input.c | 59 +
1 files changed, 38 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/tm6000/tm6000-input.c
b/drivers/staging/tm6000/tm6000-input.c
index 7b07096..4fcd5ff 100644
--- a/drivers/staging/tm6000/tm6000-input.c
+++ b/drivers/staging/tm6000/tm6000-input.c
@@ -46,7 +46,7 @@ MODULE_PARM_DESC(enable_ir, "enable ir (default is enable)");
}
struct tm6000_ir_poll_result {
- u8 rc_data[4];
+ u16 rc_data;
};
struct tm6000_IR {
@@ -60,9 +60,9 @@ struct tm6000_IR {
int polling;
struct delayed_work work;
u8 wait:1;
+ u8 key:1;
struct urb *int_urb;
u8 *urb_data;
- u8 key:1;
int (*get_key) (struct tm6000_IR *, struct tm6000_ir_poll_result *);
@@ -122,13 +122,14 @@ static void tm6000_ir_urb_received(struct urb *urb)
if (urb->status != 0)
printk(KERN_INFO "not ready\n");
- else if (urb->actual_length > 0)
+ else if (urb->actual_length > 0) {
memcpy(ir->urb_data, urb->transfer_buffer, urb->actual_length);
- dprintk("data %02x %02x %02x %02x\n", ir->urb_data[0],
- ir->urb_data[1], ir->urb_data[2], ir->urb_data[3]);
+ dprintk("data %02x %02x %02x %02x\n", ir->urb_data[0],
+ ir->urb_data[1], ir->urb_data[2], ir->urb_data[3]);
- ir->key = 1;
+ ir->key = 1;
+ }
rc = usb_submit_urb(urb, GFP_ATOMIC);
}
@@ -140,30 +141,47 @@ static int default_polling_getkey(struct tm6000_IR *ir,
int rc;
u8 buf[2];
- if (ir->wait && !&dev->int_in) {
- poll_result->rc_data[0] = 0xff;
+ if (ir->wait && !&dev->int_in)
return 0;
- }
if (&dev->int_in) {
- poll_result->rc_data[0] = ir->urb_data[0];
- poll_result->rc_data[1] = ir->urb_data[1];
+ if (ir->ir.ir_type == IR_TYPE_RC5)
+ poll_result->rc_data = ir->urb_data[0];
+ else
+ poll_result->rc_data = ir->urb_data[0] |
ir->urb_data[1] << 8;
} else {
tm6000_set_reg(dev, REQ_04_EN_DISABLE_MCU_INT, 2, 0);
msleep(10);
tm6000_set_reg(dev, REQ_04_EN_DISABLE_MCU_INT, 2, 1);
msleep(10);
- rc = tm6000_read_write_usb(dev, USB_DIR_IN | USB_TYPE_VENDOR |
-USB_RECIP_DEVICE, REQ_02_GET_IR_CODE, 0, 0, buf, 1);
+ if (ir->ir.ir_type == IR_TYPE_RC5) {
+ rc = tm6000_read_write_usb(dev, USB_DIR_IN |
+ USB_TYPE_VENDOR | USB_RECIP_DEVICE,
+ REQ_02_GET_IR_CODE, 0, 0, buf, 1);
- msleep(10);
+ msleep(10);
- dprintk("read data=%02x\n", buf[0]);
- if (rc < 0)
- return rc;
+ dprintk("read data=%02x\n", buf[0]);
+ if (rc < 0)
+ return rc;
- poll_result->rc_data[0] = buf[0];
+ poll_result->rc_data = buf[0];
+ } else {
+ rc = tm6000_read_write_usb(dev, USB_DIR_IN |
+ USB_TYPE_VENDOR | USB_RECIP_DEVICE,
+ REQ_02_GET_IR_CODE, 0, 0, buf, 2);
+
+ msleep(10);
+
+ dprintk("read data=%04x\n", buf[0] | buf[1] << 8);
+ if (rc < 0)
+ return rc;
+
+ poll_result->rc_data = buf[0] | buf[1] << 8;
+ }
+ if ((poll_result->rc_data & 0x00ff) != 0xff)
+ ir->key = 1;
}
return 0;
}
@@ -180,12 +198,11 @@ static void tm6000_ir_handle_key(struct tm6000_IR *ir)
return;
}
- dprintk("ir->get_key result data=%02x %02x\n",
- poll_result.rc_data[0], poll_result.rc_data[1]);
+ dprintk("ir->get_key result data=%02x %04x\n", poll_result.rc_data);
if (poll_result.rc_data[0] != 0xff && ir->key == 1) {
ir_input_keydown(ir->input->input_dev, &ir->ir,
- poll_result.rc_data[0] | poll_result.rc_data[1] << 8);
+ (u32)poll_result.rc_data);
ir_input_nokey(ir->input->input_dev, &ir->ir);
ir->key = 0;
--
1.7.1
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 1/2] tm6000: bugfix param string
From: Stefan Ringel Signed-off-by: Stefan Ringel --- drivers/staging/tm6000/tm6000-input.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/tm6000/tm6000-input.c b/drivers/staging/tm6000/tm6000-input.c index 32f7a0a..7b07096 100644 --- a/drivers/staging/tm6000/tm6000-input.c +++ b/drivers/staging/tm6000/tm6000-input.c @@ -36,7 +36,7 @@ MODULE_PARM_DESC(ir_debug, "enable debug message [IR]"); static unsigned int enable_ir = 1; module_param(enable_ir, int, 0644); -MODULE_PARM_DESC(enable_ir, "enable ir (default is enable"); +MODULE_PARM_DESC(enable_ir, "enable ir (default is enable)"); #undef dprintk -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] V4L/DVB: mantis: Fix IR_CORE dependency
* Randy Dunlap wrote: > On 08/24/10 01:45, Ingo Molnar wrote: > > > > * Mauro Carvalho Chehab wrote: > > > >> Linus, > >> > >> Please pull from: > >> ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git > >> v4l_for_linus > >> > >> For 3 build fixes. > >> > >> Cheers, > >> Mauro. > >> > >> The following changes since commit > >> ad41a1e0cab07c5125456e8d38e5b1ab148d04aa: > >> > >> Merge branch 'io_remap_pfn_range' of git://www.jni.nu/cris (2010-08-12 > >> 10:17:19 -0700) > >> > >> are available in the git repository at: > >> > >> ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git > >> v4l_for_linus > >> > >> Mauro Carvalho Chehab (2): > >> V4L/DVB: Fix IR_CORE dependencies > >> V4L/DVB: fix Kconfig to depends on VIDEO_IR > >> > >> Randy Dunlap (1): > >> V4L/DVB: v4l2-ctrls.c: needs to include slab.h > > > > FYI, there's one more IR_CORE related build bug which triggers > > frequently in randconfig tests - see the fix below. > > > > Thanks, > > > > Ingo > > > > ---> > > From c56aef270d7ec01564c632c1f7ebab6b8f9f032c Mon Sep 17 00:00:00 2001 > > From: Ingo Molnar > > Date: Tue, 24 Aug 2010 10:41:33 +0200 > > Subject: [PATCH] V4L/DVB: mantis: Fix IR_CORE dependency > > > > This build bug triggers: > > > > drivers/built-in.o: In function `mantis_exit': > > (.text+0x377413): undefined reference to `ir_input_unregister' > > drivers/built-in.o: In function `mantis_input_init': > > (.text+0x3774ff): undefined reference to `__ir_input_register' > > > > If MANTIS_CORE is enabled but IR_CORE is not. Add the correct > > dependency. > > > > Signed-off-by: Ingo Molnar > > --- > > drivers/media/dvb/mantis/Kconfig |2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/media/dvb/mantis/Kconfig > > b/drivers/media/dvb/mantis/Kconfig > > index decdeda..fd0830e 100644 > > --- a/drivers/media/dvb/mantis/Kconfig > > +++ b/drivers/media/dvb/mantis/Kconfig > > @@ -1,6 +1,6 @@ > > config MANTIS_CORE > > tristate "Mantis/Hopper PCI bridge based devices" > > - depends on PCI && I2C && INPUT > > + depends on PCI && I2C && INPUT && IR_CORE > > > > help > > Support for PCI cards based on the Mantis and Hopper PCi bridge. > > > Acked-by: Randy Dunlap > http://lkml.org/lkml/2010/8/17/341 Your patch came first :-) Btw., the reason i missed your patch is that i grepped lkml for the static build failure - while your changelog contained the modular one. Oh well :) Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: ERRORS
This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below. Results of the daily build of v4l-dvb: date:Tue Aug 24 19:00:24 CEST 2010 path:http://www.linuxtv.org/hg/v4l-dvb changeset: 15131:2ceef3d75547 git master: f6760aa024199cfbce564311dc4bc4d47b6fb349 git media-master: 1c1371c2fe53ded8ede3a0404c9415fbf3321328 gcc version: i686-linux-gcc (GCC) 4.4.3 host hardware:x86_64 host os: 2.6.32.5 linux-2.6.32.6-armv5: ERRORS linux-2.6.33-armv5: WARNINGS linux-2.6.34-armv5: WARNINGS linux-2.6.35-rc1-armv5: WARNINGS linux-2.6.32.6-armv5-davinci: ERRORS linux-2.6.33-armv5-davinci: ERRORS linux-2.6.34-armv5-davinci: ERRORS linux-2.6.35-rc1-armv5-davinci: ERRORS linux-2.6.32.6-armv5-ixp: ERRORS linux-2.6.33-armv5-ixp: ERRORS linux-2.6.34-armv5-ixp: ERRORS linux-2.6.35-rc1-armv5-ixp: ERRORS linux-2.6.32.6-armv5-omap2: ERRORS linux-2.6.33-armv5-omap2: ERRORS linux-2.6.34-armv5-omap2: ERRORS linux-2.6.35-rc1-armv5-omap2: ERRORS linux-2.6.22.19-i686: ERRORS linux-2.6.23.17-i686: ERRORS linux-2.6.24.7-i686: ERRORS linux-2.6.25.20-i686: ERRORS linux-2.6.26.8-i686: ERRORS linux-2.6.27.44-i686: ERRORS linux-2.6.28.10-i686: ERRORS linux-2.6.29.1-i686: ERRORS linux-2.6.30.10-i686: ERRORS linux-2.6.31.12-i686: ERRORS linux-2.6.32.6-i686: ERRORS linux-2.6.33-i686: ERRORS linux-2.6.34-i686: ERRORS linux-2.6.35-rc1-i686: ERRORS linux-2.6.32.6-m32r: ERRORS linux-2.6.33-m32r: WARNINGS linux-2.6.34-m32r: WARNINGS linux-2.6.35-rc1-m32r: WARNINGS linux-2.6.32.6-mips: ERRORS linux-2.6.33-mips: WARNINGS linux-2.6.34-mips: WARNINGS linux-2.6.35-rc1-mips: WARNINGS linux-2.6.32.6-powerpc64: ERRORS linux-2.6.33-powerpc64: ERRORS linux-2.6.34-powerpc64: ERRORS linux-2.6.35-rc1-powerpc64: ERRORS linux-2.6.22.19-x86_64: ERRORS linux-2.6.23.17-x86_64: ERRORS linux-2.6.24.7-x86_64: ERRORS linux-2.6.25.20-x86_64: ERRORS linux-2.6.26.8-x86_64: ERRORS linux-2.6.27.44-x86_64: ERRORS linux-2.6.28.10-x86_64: ERRORS linux-2.6.29.1-x86_64: ERRORS linux-2.6.30.10-x86_64: ERRORS linux-2.6.31.12-x86_64: ERRORS linux-2.6.32.6-x86_64: ERRORS linux-2.6.33-x86_64: WARNINGS linux-2.6.34-x86_64: WARNINGS linux-2.6.35-rc1-x86_64: WARNINGS linux-git-armv5: WARNINGS linux-git-armv5-davinci: WARNINGS linux-git-armv5-ixp: WARNINGS linux-git-armv5-omap2: WARNINGS linux-git-i686: WARNINGS linux-git-m32r: OK linux-git-mips: OK linux-git-powerpc64: OK linux-git-x86_64: WARNINGS spec: ERRORS spec-git: OK sparse: ERRORS linux-2.6.16.62-i686: ERRORS linux-2.6.17.14-i686: ERRORS linux-2.6.18.8-i686: ERRORS linux-2.6.19.7-i686: ERRORS linux-2.6.20.21-i686: ERRORS linux-2.6.21.7-i686: ERRORS linux-2.6.16.62-x86_64: ERRORS linux-2.6.17.14-x86_64: ERRORS linux-2.6.18.8-x86_64: ERRORS linux-2.6.19.7-x86_64: ERRORS linux-2.6.20.21-x86_64: ERRORS linux-2.6.21.7-x86_64: ERRORS Detailed results are available here: http://www.xs4all.nl/~hverkuil/logs/Tuesday.log Full logs are available here: http://www.xs4all.nl/~hverkuil/logs/Tuesday.tar.bz2 The V4L-DVB specification from this daily build is here: http://www.xs4all.nl/~hverkuil/spec/media.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: SkyStar S2 on an embedded Linux
> Sorry, my bad! > You were right. The channels on FEC 3/4 and 8PSK modulation can't be > locked. Is there any solution to this problem? > I noticed you've quoted my email on a forum: > http://linuxdvb.org.ru/wbb/index.php?page=Thread&postID=16173#post16173 yes, we discussed such issue, but solution still doesn't exist Custler is very busy to fix it :( > > On Wed, Aug 18, 2010 at 11:21 PM, Nima Mohammadi wrote: > > On Wed, Aug 18, 2010 at 7:23 PM, Goga777 wrote: > >> > >> would you re-check please again - have you luck with 8PSK-FEC 3/4 dvb-s2 > >> channels ? > >> > >> Goga > > > > Yes, except MTVNHD and Suisse HD (which use QPSK modulation), almost > > all other HD channels on Hotbird are on 8PSK and I can watch them > > without any problem. > > > > Actually, I managed to solve my problem. I was using a lightweight > > implementation of udev called mdev. Today I tried installing udev on > > my embedded system. And although it works fine now, I prefer to use > > mdev and I'd be more than happy if anyone could point out what the > > problem with mdev is. As the documentation of busybox states, mdev can > > load firmwares from the /lib/firmware/ directory. > > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: SkyStar S2 on an embedded Linux
Sorry, my bad! You were right. The channels on FEC 3/4 and 8PSK modulation can't be locked. Is there any solution to this problem? I noticed you've quoted my email on a forum: http://linuxdvb.org.ru/wbb/index.php?page=Thread&postID=16173#post16173 On Wed, Aug 18, 2010 at 11:21 PM, Nima Mohammadi wrote: > On Wed, Aug 18, 2010 at 7:23 PM, Goga777 wrote: >> >> would you re-check please again - have you luck with 8PSK-FEC 3/4 dvb-s2 >> channels ? >> >> Goga > > Yes, except MTVNHD and Suisse HD (which use QPSK modulation), almost > all other HD channels on Hotbird are on 8PSK and I can watch them > without any problem. > > Actually, I managed to solve my problem. I was using a lightweight > implementation of udev called mdev. Today I tried installing udev on > my embedded system. And although it works fine now, I prefer to use > mdev and I'd be more than happy if anyone could point out what the > problem with mdev is. As the documentation of busybox states, mdev can > load firmwares from the /lib/firmware/ directory. > > -- Nima Mohammadi > -- Nima Mohammadi -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] dvb: siano: free spinlock before schedule()
On Tue, Aug 24, 2010 at 09:52:36AM -0300, Mauro Carvalho Chehab wrote:
> Em 08-08-2010 13:10, Richard Zidlicky escreveu:
> > On Wed, Jul 28, 2010 at 12:24:39AM +0200, Jiri Slaby wrote:
> >
> > sorry for seeing this so late, was flooded with email lately.
> >
> >> There is a better fix (which fixes the potential NULL dereference):
> >> http://lkml.org/lkml/2010/6/7/175
> >
> >> Richard, could you address the comments there and resend?
> >
> > I am running this patch since many weeks (after fixing the compile error
> > obviously).
> > Did not implement your beautification suggestion yet, was doing all kinds
> > of experiments
> > with IR and had plenty of unrelated issues.
>
> This patch seems a way better than the previous patch. I've rebased it against
> the current tree (and fixed the identation).
thanks for looking at it.
> The only missing issue on it is the lack of your Signed-off-by. Richard,
> could you
> please send it to us?
Signed-off-by: Richard Zidlicky
PS: I will be away for a while.
>
> ---
> drivers/media/dvb/siano/smscoreapi.c | 31 +--
> 1 file changed, 13 insertions(+), 18 deletions(-)
>
> --- patchwork.orig/drivers/media/dvb/siano/smscoreapi.c
> +++ patchwork/drivers/media/dvb/siano/smscoreapi.c
> @@ -1098,31 +1098,26 @@ EXPORT_SYMBOL_GPL(smscore_onresponse);
> *
> * @return pointer to descriptor on success, NULL on error.
> */
> -struct smscore_buffer_t *smscore_getbuffer(struct smscore_device_t *coredev)
> +
> +struct smscore_buffer_t *get_entry(struct smscore_device_t *coredev)
> {
> struct smscore_buffer_t *cb = NULL;
> unsigned long flags;
>
> - DEFINE_WAIT(wait);
> -
> spin_lock_irqsave(&coredev->bufferslock, flags);
> + if (!list_empty(&coredev->buffers)) {
> + cb = (struct smscore_buffer_t *) coredev->buffers.next;
> + list_del(&cb->entry);
> + }
> + spin_unlock_irqrestore(&coredev->bufferslock, flags);
> + return cb;
> +}
>
> - /* This function must return a valid buffer, since the buffer list is
> - * finite, we check that there is an available buffer, if not, we wait
> - * until such buffer become available.
> - */
> -
> - prepare_to_wait(&coredev->buffer_mng_waitq, &wait, TASK_INTERRUPTIBLE);
> -
> - if (list_empty(&coredev->buffers))
> - schedule();
> -
> - finish_wait(&coredev->buffer_mng_waitq, &wait);
> -
> - cb = (struct smscore_buffer_t *) coredev->buffers.next;
> - list_del(&cb->entry);
> +struct smscore_buffer_t *smscore_getbuffer(struct smscore_device_t *coredev)
> +{
> + struct smscore_buffer_t *cb = NULL;
>
> - spin_unlock_irqrestore(&coredev->bufferslock, flags);
> + wait_event(coredev->buffer_mng_waitq, (cb = get_entry(coredev)));
>
> return cb;
> }
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] V4L/DVB: mantis: Fix IR_CORE dependency
On 08/24/10 01:45, Ingo Molnar wrote: > > * Mauro Carvalho Chehab wrote: > >> Linus, >> >> Please pull from: >> ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git >> v4l_for_linus >> >> For 3 build fixes. >> >> Cheers, >> Mauro. >> >> The following changes since commit ad41a1e0cab07c5125456e8d38e5b1ab148d04aa: >> >> Merge branch 'io_remap_pfn_range' of git://www.jni.nu/cris (2010-08-12 >> 10:17:19 -0700) >> >> are available in the git repository at: >> >> ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git >> v4l_for_linus >> >> Mauro Carvalho Chehab (2): >> V4L/DVB: Fix IR_CORE dependencies >> V4L/DVB: fix Kconfig to depends on VIDEO_IR >> >> Randy Dunlap (1): >> V4L/DVB: v4l2-ctrls.c: needs to include slab.h > > FYI, there's one more IR_CORE related build bug which triggers > frequently in randconfig tests - see the fix below. > > Thanks, > > Ingo > > ---> > From c56aef270d7ec01564c632c1f7ebab6b8f9f032c Mon Sep 17 00:00:00 2001 > From: Ingo Molnar > Date: Tue, 24 Aug 2010 10:41:33 +0200 > Subject: [PATCH] V4L/DVB: mantis: Fix IR_CORE dependency > > This build bug triggers: > > drivers/built-in.o: In function `mantis_exit': > (.text+0x377413): undefined reference to `ir_input_unregister' > drivers/built-in.o: In function `mantis_input_init': > (.text+0x3774ff): undefined reference to `__ir_input_register' > > If MANTIS_CORE is enabled but IR_CORE is not. Add the correct > dependency. > > Signed-off-by: Ingo Molnar > --- > drivers/media/dvb/mantis/Kconfig |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/media/dvb/mantis/Kconfig > b/drivers/media/dvb/mantis/Kconfig > index decdeda..fd0830e 100644 > --- a/drivers/media/dvb/mantis/Kconfig > +++ b/drivers/media/dvb/mantis/Kconfig > @@ -1,6 +1,6 @@ > config MANTIS_CORE > tristate "Mantis/Hopper PCI bridge based devices" > - depends on PCI && I2C && INPUT > + depends on PCI && I2C && INPUT && IR_CORE > > help > Support for PCI cards based on the Mantis and Hopper PCi bridge. Acked-by: Randy Dunlap http://lkml.org/lkml/2010/8/17/341 thanks, -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Hauppauge PCTV DVB-S2 STICK 460E USB 2.0
On Tue, Aug 24, 2010 at 9:42 PM, Goga777 wrote: >> > does somebody work under Linux drivers for this dvb-s2 stick ? >> > >> >> Although we are not working on that one, we are about to release >> another DVB-S/S2 USB Stick with full >> Linux support at around the end of september. >> >> http://www.sundtek.de/images/kaffeine-dvbs2.png >> >> Including, MIPS (eg. Dreambox, Netgear WNDR3700, etc), ARM (various >> NAS and Linux Router systems), PPC, X86/32/64 support and network >> streaming capability plus official Linux support. > > which tuner and demodulator using ? > have you any photos ? > only, http://sundtek.de/images/sundtek-dvbs2.png Best Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
OMAP ISP and Overlay
Laurent, So far I have the everything working with the OMAP ISP to where I can stream video on our custom board. On a previous generation of hardware with a completely different processor and sensor, we used the V4L2 overlay feature to stream directly to our LCD for preview. I am wondering what the plans are for overlay support in the omap ISP? How does the overlay feature fit into the new media bus feature? Thanks, Lane -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Hauppauge PCTV DVB-S2 STICK 460E USB 2.0
> > does somebody work under Linux drivers for this dvb-s2 stick ? > > > > Although we are not working on that one, we are about to release > another DVB-S/S2 USB Stick with full > Linux support at around the end of september. > > http://www.sundtek.de/images/kaffeine-dvbs2.png > > Including, MIPS (eg. Dreambox, Netgear WNDR3700, etc), ARM (various > NAS and Linux Router systems), PPC, X86/32/64 support and network > streaming capability plus official Linux support. which tuner and demodulator using ? have you any photos ? Goga -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] dvb: siano: free spinlock before schedule()
Em 08-08-2010 13:10, Richard Zidlicky escreveu:
> On Wed, Jul 28, 2010 at 12:24:39AM +0200, Jiri Slaby wrote:
>
> sorry for seeing this so late, was flooded with email lately.
>
>> There is a better fix (which fixes the potential NULL dereference):
>> http://lkml.org/lkml/2010/6/7/175
>
>> Richard, could you address the comments there and resend?
>
> I am running this patch since many weeks (after fixing the compile error
> obviously).
> Did not implement your beautification suggestion yet, was doing all kinds of
> experiments
> with IR and had plenty of unrelated issues.
This patch seems a way better than the previous patch. I've rebased it against
the current tree (and fixed the identation).
The only missing issue on it is the lack of your Signed-off-by. Richard, could
you
please send it to us?
---
drivers/media/dvb/siano/smscoreapi.c | 31 +--
1 file changed, 13 insertions(+), 18 deletions(-)
--- patchwork.orig/drivers/media/dvb/siano/smscoreapi.c
+++ patchwork/drivers/media/dvb/siano/smscoreapi.c
@@ -1098,31 +1098,26 @@ EXPORT_SYMBOL_GPL(smscore_onresponse);
*
* @return pointer to descriptor on success, NULL on error.
*/
-struct smscore_buffer_t *smscore_getbuffer(struct smscore_device_t *coredev)
+
+struct smscore_buffer_t *get_entry(struct smscore_device_t *coredev)
{
struct smscore_buffer_t *cb = NULL;
unsigned long flags;
- DEFINE_WAIT(wait);
-
spin_lock_irqsave(&coredev->bufferslock, flags);
+ if (!list_empty(&coredev->buffers)) {
+ cb = (struct smscore_buffer_t *) coredev->buffers.next;
+ list_del(&cb->entry);
+ }
+ spin_unlock_irqrestore(&coredev->bufferslock, flags);
+ return cb;
+}
- /* This function must return a valid buffer, since the buffer list is
-* finite, we check that there is an available buffer, if not, we wait
-* until such buffer become available.
-*/
-
- prepare_to_wait(&coredev->buffer_mng_waitq, &wait, TASK_INTERRUPTIBLE);
-
- if (list_empty(&coredev->buffers))
- schedule();
-
- finish_wait(&coredev->buffer_mng_waitq, &wait);
-
- cb = (struct smscore_buffer_t *) coredev->buffers.next;
- list_del(&cb->entry);
+struct smscore_buffer_t *smscore_getbuffer(struct smscore_device_t *coredev)
+{
+ struct smscore_buffer_t *cb = NULL;
- spin_unlock_irqrestore(&coredev->bufferslock, flags);
+ wait_event(coredev->buffer_mng_waitq, (cb = get_entry(coredev)));
return cb;
}
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] cx88: Kconfig: Remove EXPERIMENTAL dependency from VIDEO_CX88_ALSA
The cx88-alsa module has been around since January 2006 and has seen no significant changes since September 2007. It is stable in operation and so I believe that the 'experimental' tag is no longer warranted. --- drivers/media/video/cx88/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/cx88/Kconfig b/drivers/media/video/cx88/Kconfig index c7e5851..f5e64f1 100644 --- a/drivers/media/video/cx88/Kconfig +++ b/drivers/media/video/cx88/Kconfig @@ -17,7 +17,7 @@ config VIDEO_CX88 config VIDEO_CX88_ALSA tristate "Conexant 2388x DMA audio support" - depends on VIDEO_CX88 && SND && EXPERIMENTAL + depends on VIDEO_CX88 && SND select SND_PCM ---help--- This is a video4linux driver for direct (DMA) audio on -- 1.7.0.4 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: MSI DigiVox Trio (Analog, DVB-C, DVB-T)
Matthias Larisch writes: > Hello! > > I recently bought a DigiVox Trio by MSI. This card contains the > following chips: > > nxp tda18271hdc2 (tuner) > micronas drx 3926ka3 (demodulator, 3in1) > em2884 > atmlh946 64c (eeprom) > micronas avf 4910ba1 > > so it is comparable to the Terratec Cinergy HTC USB XS HD and the > TerraTec H5. > > There is basically everything missing: > -EM2884 Support > -DRX 3926 Support > -AVF 4910 Support > > Is anyone working on any of them? I would really like to help to get > some of this stuff working! I know how to code and have much interest in > hardware/technology but no know how in linux-driver programming or > tv-card programming. If there is anything I could do just tell me. I believe Terratec's comment regarding the TerraTec H5 applies: http://linux.terratec.de/tv_en.html Sorry. It's like this: If you see "Micronas", then don't buy. Bjørn -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] V4L/DVB: mantis: Fix IR_CORE dependency
* Mauro Carvalho Chehab wrote: > Linus, > > Please pull from: > ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git > v4l_for_linus > > For 3 build fixes. > > Cheers, > Mauro. > > The following changes since commit ad41a1e0cab07c5125456e8d38e5b1ab148d04aa: > > Merge branch 'io_remap_pfn_range' of git://www.jni.nu/cris (2010-08-12 > 10:17:19 -0700) > > are available in the git repository at: > > ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git > v4l_for_linus > > Mauro Carvalho Chehab (2): > V4L/DVB: Fix IR_CORE dependencies > V4L/DVB: fix Kconfig to depends on VIDEO_IR > > Randy Dunlap (1): > V4L/DVB: v4l2-ctrls.c: needs to include slab.h FYI, there's one more IR_CORE related build bug which triggers frequently in randconfig tests - see the fix below. Thanks, Ingo ---> >From c56aef270d7ec01564c632c1f7ebab6b8f9f032c Mon Sep 17 00:00:00 2001 From: Ingo Molnar Date: Tue, 24 Aug 2010 10:41:33 +0200 Subject: [PATCH] V4L/DVB: mantis: Fix IR_CORE dependency This build bug triggers: drivers/built-in.o: In function `mantis_exit': (.text+0x377413): undefined reference to `ir_input_unregister' drivers/built-in.o: In function `mantis_input_init': (.text+0x3774ff): undefined reference to `__ir_input_register' If MANTIS_CORE is enabled but IR_CORE is not. Add the correct dependency. Signed-off-by: Ingo Molnar --- drivers/media/dvb/mantis/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/dvb/mantis/Kconfig b/drivers/media/dvb/mantis/Kconfig index decdeda..fd0830e 100644 --- a/drivers/media/dvb/mantis/Kconfig +++ b/drivers/media/dvb/mantis/Kconfig @@ -1,6 +1,6 @@ config MANTIS_CORE tristate "Mantis/Hopper PCI bridge based devices" - depends on PCI && I2C && INPUT + depends on PCI && I2C && INPUT && IR_CORE help Support for PCI cards based on the Mantis and Hopper PCi bridge. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
bugreport: strange issues in tda8261 frontend (missing symbols etc).
Hi List, 1. The module adds MODULE_PARM_DESC(verbose, "Set verbosity level"); but doesn't declare the needed variables or uses this parameter somewhere. This ends in missing symbol when trying to specify that parameter when loading the frontend. 2. The module logs many lines when tuning to a new channel. This results in fast growing big logs in /var/log (several mb's ad a day). Here some lines of the log: Aug 24 07:23:57 vdr kernel: [44045.944177] tda8261_get_frequency: Frequency=188 Aug 24 07:23:57 vdr kernel: [44045.952037] tda8261_get_bandwidth: Bandwidth=4000 Aug 24 07:24:04 vdr kernel: [44052.132637] tda8261_get_bandwidth: Bandwidth=4000 Aug 24 07:24:04 vdr kernel: [44052.136747] tda8261_get_bandwidth: Bandwidth=4000 Aug 24 07:24:04 vdr kernel: [44052.138596] tda8261_set_state: Step size=1, Divider=1000, PG=0x798 (1944) Aug 24 07:24:04 vdr kernel: [44052.138883] tda8261_set_state: Waiting to Phase LOCK Aug 24 07:24:04 vdr kernel: [44052.160156] tda8261_get_status: Tuner Phase Locked Aug 24 07:24:04 vdr kernel: [44052.160163] tda8261_set_state: Tuner Phase locked: status=1 Aug 24 07:24:04 vdr kernel: [44052.160168] tda8261_set_frequency: Frequency=1944000 Aug 24 07:24:04 vdr kernel: [44052.160173] tda8261_get_frequency: Frequency=1944000 Aug 24 07:24:04 vdr kernel: [44052.168031] tda8261_get_bandwidth: Bandwidth=4000 Aug 24 07:24:09 vdr kernel: [44057.016717] tda8261_get_bandwidth: Bandwidth=4000 Aug 24 07:24:09 vdr kernel: [44057.021165] tda8261_get_bandwidth: Bandwidth=4000 Aug 24 07:24:09 vdr kernel: [44057.023052] tda8261_set_state: Step size=1, Divider=1000, PG=0x60c (1548) Aug 24 07:24:09 vdr kernel: [44057.023305] tda8261_set_state: Waiting to Phase LOCK Aug 24 07:24:09 vdr kernel: [44057.044169] tda8261_get_status: Tuner Phase Locked Aug 24 07:24:09 vdr kernel: [44057.044177] tda8261_set_state: Tuner Phase locked: status=1 Aug 24 07:24:09 vdr kernel: [44057.044182] tda8261_set_frequency: Frequency=1548000 Aug 24 07:24:09 vdr kernel: [44057.044187] tda8261_get_frequency: Frequency=1548000 Aug 24 07:24:09 vdr kernel: [44057.053034] tda8261_get_bandwidth: Bandwidth=4000 Kernel 2.6.34 was used on that system. Thx. Halim -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Hauppauge PCTV DVB-S2 STICK 460E USB 2.0
On Tue, Aug 24, 2010 at 4:20 PM, Halim Sahin wrote: > Hi, > On Di, Aug 24, 2010 at 10:46:19 +0800, Markus Rechberger wrote: >> Although we are not working on that one, we are about to release >> another DVB-S/S2 USB Stick with full >> Linux support at around the end of september. > > What about usb ci? > At least in germany a dvb-c stick without ci is useless. Do some research about Dream Multimedia / Dreambox (I'm not writing more about this topic, google can shed some more light on this). Best Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] mx3fb and ipu_idmac cleanups
From: Juergen Beisert
Signed-off-by: Juergen Beisert
Signed-off-by: Michael Grzeschik
---
drivers/dma/ipu/ipu_idmac.c |2 +-
drivers/video/mx3fb.c |6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/dma/ipu/ipu_idmac.c b/drivers/dma/ipu/ipu_idmac.c
index cb26ee9..e065703 100644
--- a/drivers/dma/ipu/ipu_idmac.c
+++ b/drivers/dma/ipu/ipu_idmac.c
@@ -321,7 +321,7 @@ static void ipu_ch_param_set_size(union chan_param_mem
*params,
params->ip.wid2 = 4;/* Blue bit width - 1 */
break;
case IPU_PIX_FMT_BGR24:
- params->ip.bpp = 1;/* 24 BPP & RGB PFS */
+ params->ip.bpp = 1;/* 24 BPP & BGR PFS */
params->ip.pfs = 4;
params->ip.npb = 7;
params->ip.sat = 2;/* SAT = 32-bit access */
diff --git a/drivers/video/mx3fb.c b/drivers/video/mx3fb.c
index 7cfc170..658f10a 100644
--- a/drivers/video/mx3fb.c
+++ b/drivers/video/mx3fb.c
@@ -660,12 +660,12 @@ static uint32_t bpp_to_pixfmt(int bpp)
{
uint32_t pixfmt = 0;
switch (bpp) {
- case 24:
- pixfmt = IPU_PIX_FMT_BGR24;
- break;
case 32:
pixfmt = IPU_PIX_FMT_BGR32;
break;
+ case 24:
+ pixfmt = IPU_PIX_FMT_BGR24;
+ break;
case 16:
pixfmt = IPU_PIX_FMT_RGB565;
break;
--
1.7.1
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [linux-dvb] "Update es-Sevilla (attached)"
2010/8/15 x...@ya.com : > Hi, attached update es-Sevilla. Updated, thanks. > Greetings. Christoph -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
MSI DigiVox Trio (Analog, DVB-C, DVB-T)
Hello! I recently bought a DigiVox Trio by MSI. This card contains the following chips: nxp tda18271hdc2 (tuner) micronas drx 3926ka3 (demodulator, 3in1) em2884 atmlh946 64c (eeprom) micronas avf 4910ba1 so it is comparable to the Terratec Cinergy HTC USB XS HD and the TerraTec H5. There is basically everything missing: -EM2884 Support -DRX 3926 Support -AVF 4910 Support Is anyone working on any of them? I would really like to help to get some of this stuff working! I know how to code and have much interest in hardware/technology but no know how in linux-driver programming or tv-card programming. If there is anything I could do just tell me. So far I'm using this card in a Windows VM and it works (more or less good...) Best regards, Matthias -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
