Re: Memory sharing issue by application on V4L2 based device driver with system mmu.

2011-01-07 Thread Michel Dänzer
On Fre, 2011-01-07 at 11:17 +0900, InKi Dae wrote: thank you for your comments. your second comment has no any problem as I said before, user virtual addess could be translated in page unit. but the problem, as you said, is that when cpu access to the memory in user mode, the memory

Re: [GIT PATCHES FOR 2.6.38] Use the control framework in various subdevs

2011-01-07 Thread Hans Verkuil
Hi Mauro, On Friday, December 31, 2010 14:36:59 Hans Verkuil wrote: This is a pull request for a subset of the RFC patch series I posted almost three weeks ago. Please don't merge this yet. While testing the ov7670 driver I came across some issues that may affect some drivers in this patch

Re: Memory sharing issue by application on V4L2 based device driver with system mmu.

2011-01-07 Thread daeinki
Michel Dänzer 쓴 글: On Fre, 2011-01-07 at 11:17 +0900, InKi Dae wrote: thank you for your comments. your second comment has no any problem as I said before, user virtual addess could be translated in page unit. but the problem, as you said, is that when cpu access to the memory in user mode,

Re: [GIT PATCHES FOR 2.6.38] Use the control framework in various subdevs

2011-01-07 Thread Hans Verkuil
On Friday, January 07, 2011 10:49:30 Hans Verkuil wrote: Hi Mauro, On Friday, December 31, 2010 14:36:59 Hans Verkuil wrote: This is a pull request for a subset of the RFC patch series I posted almost three weeks ago. Please don't merge this yet. While testing the ov7670 driver I came

pctv452e driver status

2011-01-07 Thread Davide Cavalca
Hi, I've managed to make my TechnoTrend TT-connect S2-3650 CI work using the pctv452e driver from s2-lipianin on 2.6.35.10. It runs fine (both regular and HD channels), but there are some minor issues: - vdr-femon always reports a very low signal strenght (between 0 and 2%), I guess the driver is

[patch] new_build.git - avoid failing on 'rm' of nonexistent file

2011-01-07 Thread Vincent McIntyre
While attempting to build recently I have found the 'make distclean' target fails if 'rm' tries to remove a file that is not there. The attached patch fixes the issue for me (by using rm -f). I converted all the other 'rm' calls to 'rm -f' along the way. Please consider applying this. Cheers

[patch] new_build.git - drop videodev.h

2011-01-07 Thread Vincent McIntyre
'make tar' fails for me (building against ubuntu 2.6.32) unless I remove videodev.h from TARFILES. Is this the correct thing to do here? diff --git a/linux/Makefile b/linux/Makefile index 695dcf2..8bbeee8 100644 --- a/linux/Makefile +++ b/linux/Makefile @@ -20,7 +20,6 @@ TARDIR += include/media/

Re: [PATCH] Corrections to dvb-apps util/scan/dvb-c/de-neftv

2011-01-07 Thread Christoph Pfister
2011/1/6 Michael Meier poempel...@mulder.franken.de: The scan config for de-neftv seems to be outdated: It is missing some channels, and (more importantly) has incorrect settings for some other channels, as their settings differ a little from the rest [*]. The following patch fixes that (and,

Re: [patch] [media] av7110: make array offset unsigned

2011-01-07 Thread Andreas Oberritter
On 01/06/2011 08:41 PM, Dan Carpenter wrote: In the CA_GET_SLOT_INFO ioctl, we only check whether num is too large, but we don't check if it's negative. drivers/media/dvb/ttpci/av7110_ca.c 278ca_slot_info_t *info=(ca_slot_info_t *)parg; 279 280if

[RFC PATCH 0/5] Use control framework in cafe_ccic and s_config removal

2011-01-07 Thread Hans Verkuil
Hi Jon, Laurent, This patch series converts the OLPC cafe_ccic driver to the new control framework. It turned out that this depended on the removal of the legacy s_config subdev operation. I originally created the ov7670 controls in s_config, but it turned out that s_config is called after

[RFC PATCH 3/5] v4l2-ctrls: v4l2_ctrl_handler_setup must set has_new to 1

2011-01-07 Thread Hans Verkuil
Drivers can use the has_new field to determine if a new value was specified for a control. The v4l2_ctrl_handler_setup() must always set this to 1 since the setup has to force a full update of all controls. Signed-off-by: Hans Verkuil hverk...@xs4all.nl --- drivers/media/video/v4l2-ctrls.c |

[RFC PATCH 1/5] v4l2-subdev: remove core.s_config and v4l2_i2c_new_subdev_cfg()

2011-01-07 Thread Hans Verkuil
The core.s_config op was meant for legacy drivers that needed to work with old pre-2.6.26 kernels. This is no longer relevant. Unfortunately, this op was incorrectly called from several drivers. Replace those occurences with proper i2c_board_info structs and call v4l2_i2c_new_subdev_board. After

[RFC PATCH 2/5] v4l2-subdev: add (un)register internal ops

2011-01-07 Thread Hans Verkuil
Some subdevs need to call into the board code after they are registered and have a valid struct v4l2_device pointer. The s_config op was abused for this, but now that it is removed we need a cleaner way of solving this. So this patch adds a struct with internal ops that the v4l2 core can call.

[RFC PATCH 5/5] cafe_ccic: implement the control framework.

2011-01-07 Thread Hans Verkuil
And also swapped the out_free and out_unreg labels as they were in the wrong order. Tested with the OLPC laptop. Signed-off-by: Hans Verkuil hverk...@xs4all.nl --- drivers/media/video/cafe_ccic.c | 59 +++--- 1 files changed, 11 insertions(+), 48 deletions(-)

[RFC PATCH 4/5] ov7670: use the control framework

2011-01-07 Thread Hans Verkuil
Signed-off-by: Hans Verkuil hverk...@xs4all.nl --- drivers/media/video/ov7670.c | 296 - 1 files changed, 116 insertions(+), 180 deletions(-) diff --git a/drivers/media/video/ov7670.c b/drivers/media/video/ov7670.c index d4e7c11..4da8b62 100644 ---

Re: [RFC PATCH 3/5] v4l2-ctrls: v4l2_ctrl_handler_setup must set has_new to 1

2011-01-07 Thread Laurent Pinchart
Hi Hans, On Friday 07 January 2011 13:47:33 Hans Verkuil wrote: Drivers can use the has_new field to determine if a new value was specified for a control. The v4l2_ctrl_handler_setup() must always set this to 1 since the setup has to force a full update of all controls. According to

Re: [RFC PATCH 2/5] v4l2-subdev: add (un)register internal ops

2011-01-07 Thread Laurent Pinchart
Hi Hans, Thanks for the patch. On Friday 07 January 2011 13:47:32 Hans Verkuil wrote: Some subdevs need to call into the board code after they are registered and have a valid struct v4l2_device pointer. The s_config op was abused for this, but now that it is removed we need a cleaner way of

[PATCH v12 3/8] davinci vpbe: OSD(On Screen Display) block

2011-01-07 Thread Manjunath Hadli
This patch implements the functionality of the OSD block of the VPBE. The OSD in total supports 4 planes or Video sources - 2 mainly RGB and 2 Video. The patch implements general handling of all the planes, with specific emphasis on the Video plane capabilities as the Video planes are supported

[PATCH v12 4/8] davinci vpbe: VENC( Video Encoder) implementation

2011-01-07 Thread Manjunath Hadli
This patch adds the VENC or the Video encoder, which is responsible for the blending of all source planes and timing generation for Video modes like NTSC, PAL and other digital outputs. the VENC implementation currently supports COMPOSITE and COMPONENT outputs and NTSC and PAL resolutions through

[PATCH v12 2/8] davinci vpbe: VPBE display driver

2011-01-07 Thread Manjunath Hadli
This patch implements the core functionality of the dislay driver, mainly controlling the VENC and other encoders, and acting as the one point interface for the main V4L2 driver. This implements the core of each of the V4L2 IOCTLs. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Acked-by:

[PATCH v12 2/8] davinci vpbe: VPBE display driver

2011-01-07 Thread Manjunath Hadli
This patch implements the core functionality of the dislay driver, mainly controlling the VENC and other encoders, and acting as the one point interface for the main V4L2 driver. This implements the core of each of the V4L2 IOCTLs. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Acked-by:

[PATCH v12 6/8] davinci vpbe: board specific additions

2011-01-07 Thread Manjunath Hadli
This patch implements tables for display timings,outputs and other board related functionalities. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Acked-by: Muralidharan Karicheri m-kariche...@ti.com Acked-by: Hans Verkuil hverk...@xs4all.nl --- arch/arm/mach-davinci/board-dm644x-evm.c |

[PATCH v12 7/8] davinci vpbe: Build infrastructure for VPBE driver

2011-01-07 Thread Manjunath Hadli
This patch adds the build infra-structure for Davinci VPBE dislay driver. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Acked-by: Muralidharan Karicheri m-kariche...@ti.com Acked-by: Hans Verkuil hverk...@xs4all.nl --- drivers/media/video/davinci/Kconfig | 22 ++

[PATCH v12 8/8] davinci vpbe: Readme text for Dm6446 vpbe

2011-01-07 Thread Manjunath Hadli
Please refer to this file for detailed documentation of davinci vpbe v4l2 driver. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Acked-by: Muralidharan Karicheri m-kariche...@ti.com Acked-by: Hans Verkuil hverk...@xs4all.nl --- Documentation/video4linux/README.davinci-vpbe | 93

[PATCH v12 5/8] davinci vpbe: platform specific additions

2011-01-07 Thread Manjunath Hadli
This patch implements the overall device creation for the Video display driver. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Acked-by: Muralidharan Karicheri m-kariche...@ti.com Acked-by: Hans Verkuil hverk...@xs4all.nl --- arch/arm/mach-davinci/dm644x.c | 168

[patch v2] [media] av7110: check for negative array offset

2011-01-07 Thread Dan Carpenter
info-num comes from the user. It's type int. If the user passes in a negative value that would cause memory corruption. Signed-off-by: Dan Carpenter erro...@gmail.com --- V2: change the check instead of making num and unsigned int diff --git a/drivers/media/dvb/ttpci/av7110_ca.c

Re: [patch] [media] av7110: make array offset unsigned

2011-01-07 Thread Dan Carpenter
On Fri, Jan 07, 2011 at 01:44:15PM +0100, Andreas Oberritter wrote: Nack. You're changing an interface to userspace. Please add a check to av7110_ca.c instead. Ok. I've done that and resent the patch. But just for my own understanding, why is it wrong to change an int to an unsigned int in

Re: [RFC PATCH 1/5] v4l2-subdev: remove core.s_config and v4l2_i2c_new_subdev_cfg()

2011-01-07 Thread Laurent Pinchart
Hi Hans, On Friday 07 January 2011 13:47:31 Hans Verkuil wrote: [snip] diff --git a/drivers/media/video/cx25840/cx25840-core.c b/drivers/media/video/cx25840/cx25840-core.c index dfb198d..9b384ac 100644 --- a/drivers/media/video/cx25840/cx25840-core.c +++

Re: [PATCH v12 5/8] davinci vpbe: platform specific additions

2011-01-07 Thread Sergei Shtylyov
Hello. On 07-01-2011 16:40, Manjunath Hadli wrote: This patch implements the overall device creation for the Video display driver. Signed-off-by: Manjunath Hadlimanjunath.ha...@ti.com Acked-by: Muralidharan Karicherim-kariche...@ti.com Acked-by: Hans Verkuilhverk...@xs4all.nl [...] diff

Re: [patch] [media] av7110: make array offset unsigned

2011-01-07 Thread Vasiliy Kulikov
On Fri, Jan 07, 2011 at 16:51 +0300, Dan Carpenter wrote: But just for my own understanding, why is it wrong to change an int to an unsigned int in the userspace API? Who would notice? E.g. the same check in userspace (var 0). If var has changed the sign then the result would differ. --

Re: [patch] [media] av7110: make array offset unsigned

2011-01-07 Thread Andreas Oberritter
On 01/07/2011 02:51 PM, Dan Carpenter wrote: On Fri, Jan 07, 2011 at 01:44:15PM +0100, Andreas Oberritter wrote: Nack. You're changing an interface to userspace. Please add a check to av7110_ca.c instead. Ok. I've done that and resent the patch. Thanks. I'm OK with the patch, but I'll

RE: [PATCH v12 5/8] davinci vpbe: platform specific additions

2011-01-07 Thread Hadli, Manjunath
On Fri, Jan 07, 2011 at 19:27:37, Sergei Shtylyov wrote: Hello. On 07-01-2011 16:40, Manjunath Hadli wrote: This patch implements the overall device creation for the Video display driver. Signed-off-by: Manjunath Hadlimanjunath.ha...@ti.com Acked-by: Muralidharan

Re: [RFC] Cropping and scaling with subdev pad-level operations

2011-01-07 Thread Laurent Pinchart
Hi Andy, On Thursday 06 January 2011 19:28:56 Andy Walls wrote: On Thu, 2011-01-06 at 16:33 +0100, Laurent Pinchart wrote: Hi everybody, I ran into an issue when implementing cropping and scaling on the OMAP3 ISP resizer sub-device using the pad-level operations. As nobody seems to be

Re: [PATCH v12 5/8] davinci vpbe: platform specific additions

2011-01-07 Thread Sergei Shtylyov
On 07-01-2011 17:13, Hadli, Manjunath wrote: This patch implements the overall device creation for the Video display driver. Signed-off-by: Manjunath Hadlimanjunath.ha...@ti.com Acked-by: Muralidharan Karicherim-kariche...@ti.com Acked-by: Hans Verkuilhverk...@xs4all.nl [...] diff --git

RE: [Query][videobuf-dma-sg] Pages in Highmem handling

2011-01-07 Thread Aguirre, Sergio
Hi Mauro, -Original Message- From: Mauro Carvalho Chehab [mailto:mche...@redhat.com] Sent: Monday, December 20, 2010 5:23 AM To: Aguirre, Sergio Cc: linux-media@vger.kernel.org; Warren, Christina; Boateng, Akwasi; Russell King Subject: Re: [Query][videobuf-dma-sg] Pages in Highmem

Re: RFC: V4L2 driver for Qualcomm MSM camera.

2011-01-07 Thread Laurent Pinchart
Hi, On Friday 07 January 2011 01:03:58 Yupeng Yan wrote: Thanks for the comments - certainly good arguments to our lawyers :-)... actually the information of how to config the ISP HW is requested to be protected for now, we are working on certain degree of openness. The HW config code is

Re: [PATCH] [media] v4l: soc-camera: add enum-frame-size ioctl

2011-01-07 Thread Laurent Pinchart
Hi Guennadi, On Friday 07 January 2011 15:37:35 Guennadi Liakhovetski wrote: On Fri, 7 Jan 2011, Qing Xu wrote: pass VIDIOC_ENUM_FRAMESIZES down to sub device drivers. So far no special handling in soc-camera core. Hm, no, guess what? I don't think this can work. The parameter, that this

[PATCH 0/5] Make the UVC API public

2011-01-07 Thread Laurent Pinchart
Hi everybody, This patch set moves the uvcvideo.h header file from drivers/media/video/uvc to include/linux, making the UVC API public. One last API cleanup is needed before making the API public. The UVCIOC_CTRL_{ADD,MAP_OLD,GET,SET} are now deprecated and scheduled for removal. I'll work with

[PATCH 1/5] uvcvideo: Add UVCIOC_CTRL_QUERY ioctl

2011-01-07 Thread Laurent Pinchart
From: Martin Rubli martin_ru...@logitech.com This ioctl extends UVCIOC_CTRL_GET/SET by not only allowing to get/set XU controls but to also send arbitrary UVC commands to XU controls, namely GET_CUR, SET_CUR, GET_MIN, GET_MAX, GET_RES, GET_LEN, GET_INFO and GET_DEF. This is required for

[PATCH 5/5] uvcvideo: Move uvcvideo.h to include/linux

2011-01-07 Thread Laurent Pinchart
The header file is used by userspace applications, make it public. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- Documentation/ioctl/ioctl-number.txt |2 +- drivers/media/video/uvc/uvc_ctrl.c |2 +- drivers/media/video/uvc/uvc_driver.c |3 +-

[PATCH 2/5] uvcvideo: Deprecate UVCIOC_CTRL_{ADD,MAP_OLD,GET,SET}

2011-01-07 Thread Laurent Pinchart
Those ioctls are deprecated, list them in the features removal schedule for 2.6.39. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- Documentation/feature-removal-schedule.txt | 23 +++ drivers/media/video/uvc/uvc_v4l2.c | 14 ++ 2

Re: [patch] new_build.git - avoid failing on 'rm' of nonexistent file

2011-01-07 Thread Jarod Wilson
On Jan 7, 2011, at 6:53 AM, Vincent McIntyre wrote: While attempting to build recently I have found the 'make distclean' target fails if 'rm' tries to remove a file that is not there. The attached patch fixes the issue for me (by using rm -f). I converted all the other 'rm' calls to 'rm -f'

Re: [patch] new_build.git - drop videodev.h

2011-01-07 Thread Jarod Wilson
On Jan 7, 2011, at 7:04 AM, Vincent McIntyre wrote: 'make tar' fails for me (building against ubuntu 2.6.32) unless I remove videodev.h from TARFILES. Is this the correct thing to do here? Yep, videodev.h goes away in 2.6.38. Will apply and push this too. -- Jarod Wilson

[RFC/PATCH v6 0/4] Multi Format Codec 5.1 driver for S5PC110 SoC

2011-01-07 Thread Kamil Debski
Hello, This is the sixth version of the MFC 5.1 driver, decoding part. The suggestions and comments from the group members have been very helpful. I would be grateful for your comments. Original cover letter ant detailed change log has been attached below. Best regards, Kamil Debski *

[RFC/PATCH v6 4/4] s5pv210: Enable MFC on Goni

2011-01-07 Thread Kamil Debski
This patch enables MFC 5.1 on Goni board. Multi Format Codec 5.1 is capable of handling a range of video codecs. Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/mach-s5pv210/Kconfig |1 +

[PATCH 1/1] Add plugin support to libv4l

2011-01-07 Thread Yordan Kamenov
A libv4l2 plugin will sit in between libv4l2 itself and the actual /dev/video device node a fd refers to. It will be called each time libv4l2 wants to do an operation (read/write/ioctl/mmap/munmap) on the actual /dev/video node in question. Signed-off-by: Yordan Kamenov ykame...@mm-sol.com ---

[patch v3] [media] av7110: check for negative array offset

2011-01-07 Thread Dan Carpenter
info-num comes from the user. It's type int. If the user passes in a negative value that would cause memory corruption. Signed-off-by: Dan Carpenter erro...@gmail.com --- V2: change the check instead of making num and unsigned int V3: white space changes diff --git

Re: Debug code in HG repositories

2011-01-07 Thread Devin Heitmueller
On Fri, Jan 7, 2011 at 2:53 PM, Oliver Endriss o.endr...@gmx.de wrote: Hi guys, are you aware that there is a lot of '#if 0' code in the HG repositories which is not in GIT? When drivers were submitted to the kernel from HG, the '#if 0' stuff was stripped, unless it was marked as 'keep'...

Re: Debug code in HG repositories

2011-01-07 Thread Theodore Kilgore
On Fri, 7 Jan 2011, Hans Verkuil wrote: On Friday, January 07, 2011 21:13:31 Devin Heitmueller wrote: On Fri, Jan 7, 2011 at 2:53 PM, Oliver Endriss o.endr...@gmx.de wrote: Hi guys, are you aware that there is a lot of '#if 0' code in the HG repositories which is not in GIT?

Re: Debug code in HG repositories

2011-01-07 Thread Oliver Endriss
On Friday 07 January 2011 22:06:30 Hans Verkuil wrote: On Friday, January 07, 2011 21:13:31 Devin Heitmueller wrote: On Fri, Jan 7, 2011 at 2:53 PM, Oliver Endriss o.endr...@gmx.de wrote: Hi guys, are you aware that there is a lot of '#if 0' code in the HG repositories which is not

Re: Debug code in HG repositories

2011-01-07 Thread Vincent McIntyre
On 1/8/11, Hans Verkuil hverk...@xs4all.nl wrote: Have you tried Mauro's media_build tree? I had to use it today to test a driver from git on a 2.6.35 kernel. Works quite nicely. Perhaps we should promote this more. I could add backwards compatibility builds to my daily build script that uses

[GIT PULL FOR 2.6.38] af9013 IF config fix

2011-01-07 Thread Antti Palosaari
Moi Mauro, PULL that bug fix to the 2.6.38 t. Antti The following changes since commit 0a97a683049d83deaf636d18316358065417d87b: [media] cpia2: convert .ioctl to .unlocked_ioctl (2011-01-06 11:34:41 -0200) are available in the git repository at: git://linuxtv.org/anttip/media_tree.git

Re: Debug code in HG repositories

2011-01-07 Thread VDR User
On Fri, Jan 7, 2011 at 1:06 PM, Hans Verkuil hverk...@xs4all.nl wrote: Have you tried Mauro's media_build tree? I had to use it today to test a driver from git on a 2.6.35 kernel. Works quite nicely. Perhaps we should promote this more. I could add backwards compatibility builds to my daily

Re: Debug code in HG repositories

2011-01-07 Thread Jarod Wilson
On Jan 7, 2011, at 3:13 PM, Devin Heitmueller wrote: On Fri, Jan 7, 2011 at 2:53 PM, Oliver Endriss o.endr...@gmx.de wrote: Hi guys, are you aware that there is a lot of '#if 0' code in the HG repositories which is not in GIT? When drivers were submitted to the kernel from HG, the '#if