Re: [PATCH v2] [media] at91: add code to initialize and manage the ISI_MCK for Atmel ISI driver.

2011-09-05 Thread Guennadi Liakhovetski
On Tue, 6 Sep 2011, Josh Wu wrote: > This patch enable the configuration for ISI_MCK, which is provided by > programmable clock. > > Signed-off-by: Josh Wu > --- > drivers/media/video/atmel-isi.c | 60 > ++- > include/media/atmel-isi.h |4 ++ >

Re: [PATCH] media: Add camera controls for the ov5642 driver

2011-09-05 Thread Sakari Ailus
Hi Bastian, On Mon, Sep 05, 2011 at 09:32:55AM +, Bastian Hecht wrote: > 2011/9/1 Sakari Ailus : > > On Thu, Sep 01, 2011 at 11:14:08AM +0200, Sylwester Nawrocki wrote: > >> Hi Sakari, > >> > >> On 09/01/2011 10:47 AM, Sakari Ailus wrote: > >> > On Thu, Sep 01, 2011 at 09:15:20AM +0200, Guenna

[PATCH v2] [media] at91: add code to initialize and manage the ISI_MCK for Atmel ISI driver.

2011-09-05 Thread Josh Wu
This patch enable the configuration for ISI_MCK, which is provided by programmable clock. Signed-off-by: Josh Wu --- drivers/media/video/atmel-isi.c | 60 ++- include/media/atmel-isi.h |4 ++ 2 files changed, 63 insertions(+), 1 deletions(-) diff

RE: [PATCH] [media] at91: add code to initialize and manage theISI_MCK for Atmel ISI driver.

2011-09-05 Thread Wu, Josh
Hi, Russell On 09/05/2011 6:34 PM Russell King wrote: > On Mon, Sep 05, 2011 at 06:29:53PM +0800, Josh Wu wrote: >> +static int initialize_mck(struct atmel_isi *isi, >> +struct isi_platform_data *pdata) >> +{ >> +int ret; >> +struct clk *pck_parent; >> + >> +if (!s

checkpatch.pl WARNING: Do not use whitespace before Signed-off-by:

2011-09-05 Thread Antti Palosaari
I am almost sure this have been working earlier, but now it seems like nothing is acceptable for checkpatch.pl! I did surely about 20 --amend and tried to remove everything, without luck. Could someone point out whats new acceptable logging format for checkpatch.pl ? [crope@localhost linux]$ g

Re: BUG: unable to handle kernel paging request at 6b6b6bcb (v4l2_device_disconnect+0x11/0x30)

2011-09-05 Thread Sitsofe Wheeler
On Mon, Sep 05, 2011 at 12:16:42PM +0200, Hans Verkuil wrote: > On Monday, September 05, 2011 12:13:26 Hans Verkuil wrote: > > > > The original order is correct, but what I missed is that for drivers > > that release (free) everything in the videodev release callback the > > v4l2_device struct is

Re: [PATCH v4] s5p-fimc: Add runtime PM support in the mem-to-mem driver

2011-09-05 Thread Sakari Ailus
On Mon, Sep 05, 2011 at 09:01:35PM +0200, Sylwester Nawrocki wrote: > Hi Sakari, > > thanks for the comments. You're welcome! > On 09/05/2011 08:06 AM, Sakari Ailus wrote: > > Hi Sylwester, > > > > On Tue, Aug 30, 2011 at 05:00:39PM +0200, Sylwester Nawrocki wrote: > >> Add runtime PM and syste

Re: spca1528 device (Device 015: ID 04fc:1528 Sunplus Technology)..libv4l2: error turning on stream: Timer expired issue

2011-09-05 Thread Mauricio Henriquez
On 09/05/2011 01:15 PM, Jean-Francois Moine wrote: On Mon, 05 Sep 2011 11:33:49 -0400 Mauricio Henriquez wrote: Thanks Jean, yeap I apply the patch, but still the same kind of messages about timeout sing xawtv or svv: OK Mauricio. So, I need more information. May you set the gspca d

Re: [PATCH v4] s5p-fimc: Add runtime PM support in the mem-to-mem driver

2011-09-05 Thread Sylwester Nawrocki
Hi Sakari, thanks for the comments. On 09/05/2011 08:06 AM, Sakari Ailus wrote: > Hi Sylwester, > > On Tue, Aug 30, 2011 at 05:00:39PM +0200, Sylwester Nawrocki wrote: >> Add runtime PM and system sleep support in the memory-to-memory driver. >> This is required to enable the device operation on

cron job: media_tree daily build: ERRORS

2011-09-05 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Mon Sep 5 19:00:29 CEST 2011 git hash:1b19e42952963ae2a09a655f487de15b7c81c5b7 gcc version: i686-linux-gcc (GC

[PATCH] cx18: Fix videobuf capture

2011-09-05 Thread Simon Farnsworth
When we moved to 3.0, we found that the cx18 driver was oopsing on close with: NULL pointer deref at: EIP: [] __list_add+0x3e/0x81 SS:ESP 0068:f461be7c [ 2290.461009] Call Trace: [ 2290.461009] [] ? pm_qos_add_request+0xc/0x6e [ 2290.461009] [] __mutex_lock_common+0x87/0x125 [ 2290.461009] []

Re: spca1528 device (Device 015: ID 04fc:1528 Sunplus Technology)..libv4l2: error turning on stream: Timer expired issue

2011-09-05 Thread Jean-Francois Moine
On Mon, 05 Sep 2011 11:33:49 -0400 Mauricio Henriquez wrote: > Thanks Jean, yeap I apply the patch, but still the same kind of messages > about timeout sing xawtv or svv: OK Mauricio. So, I need more information. May you set the gspca debug level to 0x0f echo 0x0f > /sys/module/gspca_m

Re: Getting started with OMAP3 ISP

2011-09-05 Thread Enrico
On Fri, Sep 2, 2011 at 1:27 PM, Laurent Pinchart wrote: > On Friday 02 September 2011 11:02:23 Enrico wrote: >> Right now my problem is that i can't get the isp to generate >> interrupts, i think there is some isp configuration error. > > If your device generates interlaced images that's not surpr

[RFC] Reserved fields in v4l2_mbus_framefmt, v4l2_subdev_format alignment

2011-09-05 Thread Sakari Ailus
Hi all, I recently came across a few issues in the definitions of v4l2_subdev_format and v4l2_mbus_framefmt when I was working on sensor control that I wanted to bring up here. The appropriate structure right now look like this: include/linux/v4l2-subdev.h: ---8<--- /** * struct v4l2_subdev_form

[media-ctl][PATCHv5 5/5] libmediactl: get rid of memset via using calloc

2011-09-05 Thread Andy Shevchenko
The code snippet x = malloc(sizeof(*x)); memset(x, 0, sizeof(*x)); could be easily changed to x = calloc(1, sizeof(*x)); Signed-off-by: Andy Shevchenko --- src/media.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/media.c b/src/media.c

[media-ctl][PATCHv5 4/5] libmediactl: simplify code by introducing close_and_free inliner

2011-09-05 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko --- src/media.c | 15 +-- 1 files changed, 9 insertions(+), 6 deletions(-) diff --git a/src/media.c b/src/media.c index 657b6c4..6c03369 100644 --- a/src/media.c +++ b/src/media.c @@ -403,6 +403,12 @@ static int media_enum_entities(struct media_privat

[media-ctl][PATCHv5 3/5] libmediactl: get the device name via udev

2011-09-05 Thread Andy Shevchenko
If configured with --with-libudev, the libmediactl is built with libudev support. It allows to get the device name in right way in the modern linux systems. Signed-off-by: Andy Shevchenko --- configure.in| 22 +++ src/Makefile.am |2 + src/media.c | 105 +++

[media-ctl][PATCHv5 2/5] libmediactl: split media_get_devname_sysfs from media_enum_entities

2011-09-05 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko --- src/media.c | 61 +- 1 files changed, 35 insertions(+), 26 deletions(-) diff --git a/src/media.c b/src/media.c index 050289e..5d3ff7c 100644 --- a/src/media.c +++ b/src/media.c @@ -245,15 +245,46 @@ stat

[media-ctl][PATCHv5 1/5] libmediactl: restruct error path

2011-09-05 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko --- src/media.c | 16 +--- 1 files changed, 9 insertions(+), 7 deletions(-) diff --git a/src/media.c b/src/media.c index e3cab86..050289e 100644 --- a/src/media.c +++ b/src/media.c @@ -255,7 +255,7 @@ static int media_enum_entities(struct media_device

Re: [media-ctl][PATCHv4 3/3] libmediactl: get the device name via udev

2011-09-05 Thread Laurent Pinchart
Hi Andy, On Monday 05 September 2011 16:48:34 Andy Shevchenko wrote: > On Mon, 2011-09-05 at 12:31 +0200, Laurent Pinchart wrote: > > Hi Andy, > > > > On Friday 02 September 2011 15:09:28 Andy Shevchenko wrote: > > > If configured with --with-libudev, the libmediactl is built with > > > libudev s

Re: [media-ctl][PATCHv4 3/3] libmediactl: get the device name via udev

2011-09-05 Thread Andy Shevchenko
On Mon, 2011-09-05 at 12:31 +0200, Laurent Pinchart wrote: > Hi Andy, > > On Friday 02 September 2011 15:09:28 Andy Shevchenko wrote: > > If configured with --with-libudev, the libmediactl is built with libudev > > support. It allows to get the device name in right way in the modern linux > > sys

Re: spca1528 device (Device 015: ID 04fc:1528 Sunplus Technology)..libv4l2: error turning on stream: Timer expired issue

2011-09-05 Thread Mauricio Henriquez
On 09/05/2011 03:19 AM, Jean-Francois Moine wrote: On Sun, 04 Sep 2011 15:39:30 -0400 Mauricio Henriquez wrote: Recently I'm trying to make work a Sunplus crappy mini HD USB camera, lsusb list this info related to the device: Picture Transfer Protocol (PIMA 15470) Bus 001 Device 015: ID 0

Re: [PATCH 1/2] misc: remove CONFIG_MISC_DEVICES

2011-09-05 Thread Jean Delvare
On Mon, 5 Sep 2011 16:19:35 +0200, Arnd Bergmann wrote: > On Monday 05 September 2011, Jean Delvare wrote: > > As said before, I'm not sure. Yes, it makes it easier to select misc > > device drivers from Kconfig files. But it also makes it impossible to > > deselect all misc device drivers at once.

Re: ERROR: "em28xx_add_into_devlist" [drivers/media/video/em28xx/em28xx.ko] undefined!

2011-09-05 Thread Chris Rankin
On 05/09/11 14:57, Mauro Carvalho Chehab wrote: Could you please provide me a patch for it? I'll merge with your original one when submitting it upstream. Here you go. Did you also pick up the other merge fix and the (separate) memory leak fix, please? Cheers, Chris Signed-off-by: Chris Ran

Re: [PATCH 1/2] misc: remove CONFIG_MISC_DEVICES

2011-09-05 Thread Arnd Bergmann
On Monday 05 September 2011, Jean Delvare wrote: > As said before, I'm not sure. Yes, it makes it easier to select misc > device drivers from Kconfig files. But it also makes it impossible to > deselect all misc device drivers at once. > > I think that what we really need is the implementation in

Re: spca1528 device (Device 015: ID 04fc:1528 Sunplus Technology)..libv4l2: error turning on stream: Timer expired issue

2011-09-05 Thread Mauricio Henriquez
On 09/04/2011 10:07 PM, Theodore Kilgore wrote: On Sun, 4 Sep 2011, Mauricio Henriquez wrote: Hi guys, Not sure if is the right place to ask since this device use a gspca driver and not sure if that driver is related to uvc or not, if not please point me to the right place... Looks

Re: ERROR: "em28xx_add_into_devlist" [drivers/media/video/em28xx/em28xx.ko] undefined!

2011-09-05 Thread Mauro Carvalho Chehab
Em 04-09-2011 21:34, Chris Rankin escreveu: > On 05/09/11 01:24, Antti Palosaari wrote: >> If you select em28xx-cards.c blob link you give you can see it is there still >> for some reason. > > It's a merge issue. This lingering reference must have been added after I > posted my original patch. Fo

Re: BUG: unable to handle kernel paging request at 6b6b6bcb (v4l2_device_disconnect+0x11/0x30)

2011-09-05 Thread Yang Ruirui
- Original message - > On Monday, September 05, 2011 11:59:03 Laurent Pinchart wrote: > > Hi Hans, > > > > On Friday 02 September 2011 09:29:08 Sitsofe Wheeler wrote: > > > On Fri, Sep 02, 2011 at 01:35:49PM +0800, Dave Young wrote: > > > > On Fri, Sep 2, 2011 at 12:59 PM, Dave Young wrot

Re: DiBxxxx: fixes for 3.1/3.0

2011-09-05 Thread Patrick Boettcher
On Mon, 5 Sep 2011, Mauro Carvalho Chehab wrote: Em 05-09-2011 05:11, Olivier Grenie escreveu: Hello Mauro, I agree with you but when I wrote this patch, my concern was that the read register function (dib0070_read_reg) returns a u16 and so I could not propagate the error. That's why I decide

Re: DiBxxxx: fixes for 3.1/3.0

2011-09-05 Thread Mauro Carvalho Chehab
Em 05-09-2011 05:11, Olivier Grenie escreveu: > Hello Mauro, > I agree with you but when I wrote this patch, my concern was that the read > register function (dib0070_read_reg) > returns a u16 and so I could not propagate the error. That's why I decided to > return 0 and not change the API. >

Re: [PATCH 2/2] mfd: remove CONFIG_MFD_SUPPORT

2011-09-05 Thread Jean Delvare
On Fri, 2 Sep 2011 16:43:36 +0200, Arnd Bergmann wrote: > We currently have two symbols to control compilation the MFD subsystem, > MFD_SUPPORT and MFD_CORE. The MFD_SUPPORT is actually not required > at all, it only hides the submenu when not set, with the effect that > Kconfig warns about missing

Re: [PATCH 1/4] v4l: add support for selection api

2011-09-05 Thread Sakari Ailus
On Mon, Sep 05, 2011 at 02:52:03PM +0200, Laurent Pinchart wrote: > Hi Sakari, > > On Monday 05 September 2011 12:25:08 Sakari Ailus wrote: > > On Wed, Aug 31, 2011 at 02:28:20PM +0200, Tomasz Stanislawski wrote: > > > This patch introduces new api for a precise control of cropping and > > > compo

Re: [PATCH 1/4] v4l: add support for selection api

2011-09-05 Thread Laurent Pinchart
Hi Sakari, On Monday 05 September 2011 12:25:08 Sakari Ailus wrote: > On Wed, Aug 31, 2011 at 02:28:20PM +0200, Tomasz Stanislawski wrote: > > This patch introduces new api for a precise control of cropping and > > composing features for video devices. The new ioctls are > > VIDIOC_S_SELECTION and

Re: [PATCHv2] ISP:BUILD:FIX: Move media_entity_init() and

2011-09-05 Thread Laurent Pinchart
Hi Mauro, On Sunday 04 September 2011 15:32:28 Mauro Carvalho Chehab wrote: > Em 04-09-2011 06:01, Laurent Pinchart escreveu: > > On Sunday 04 September 2011 00:21:38 Mauro Carvalho Chehab wrote: > >> Em 24-08-2011 10:25, Laurent Pinchart escreveu: > >>> On Wednesday 24 August 2011 14:19:01 Hirema

Re: [PATCH 1/2] misc: remove CONFIG_MISC_DEVICES

2011-09-05 Thread Jean Delvare
Hi Arnd, On Fri, 2 Sep 2011 16:43:14 +0200, Arnd Bergmann wrote: > Since misc devices have nothing in common besides fitting in no > other category, there is no need to group them in one Kconfig > symbol. Simply removing the symbol gets rid of all sorts of > Kconfig warnings about missing dependen

Re: [PATCH 1/2 v2] media: Add support for arbitrary resolution for the ov5642 camera driver

2011-09-05 Thread Bastian Hecht
2011/9/5 Laurent Pinchart : > Hi Guennadi, > > On Monday 05 September 2011 11:51:57 Guennadi Liakhovetski wrote: >> On Mon, 5 Sep 2011, Laurent Pinchart wrote: >> > On Monday 05 September 2011 11:10:48 Bastian Hecht wrote: >> > > 2011/8/31 Laurent Pinchart: >> > > > On Wednesday 31 August 2011 19:0

Re: [PATCH] media: Add camera controls for the ov5642 driver

2011-09-05 Thread Bastian Hecht
2011/8/31 Guennadi Liakhovetski : > On Wed, 31 Aug 2011, Bastian Hecht wrote: > >> 2011/8/28 Laurent Pinchart : >> > Hi Bastian, >> > >> > Thanks for the patch. >> > >> > On Wednesday 17 August 2011 18:02:07 Bastian Hecht wrote: >> >> The driver now supports automatic/manual gain, automatic/manual

Re: [PATCH] [media] at91: add code to initialize and manage the ISI_MCK for Atmel ISI driver.

2011-09-05 Thread Russell King - ARM Linux
On Mon, Sep 05, 2011 at 06:29:53PM +0800, Josh Wu wrote: > +static int initialize_mck(struct atmel_isi *isi, > + struct isi_platform_data *pdata) > +{ > + int ret; > + struct clk *pck_parent; > + > + if (!strlen(pdata->pck_name) || !strlen(pdata->pck_parent_name)) >

Re: [media-ctl][PATCHv4 3/3] libmediactl: get the device name via udev

2011-09-05 Thread Laurent Pinchart
Hi Andy, On Friday 02 September 2011 15:09:28 Andy Shevchenko wrote: > If configured with --with-libudev, the libmediactl is built with libudev > support. It allows to get the device name in right way in the modern linux > systems. Thanks for the patch. We're nearly there :-) > Signed-off-by: An

[PATCH] [media] at91: add code to initialize and manage the ISI_MCK for Atmel ISI driver.

2011-09-05 Thread Josh Wu
This patch enable the configuration for ISI_MCK, which is provided by programmable clock. Signed-off-by: Josh Wu --- drivers/media/video/atmel-isi.c | 56 ++- include/media/atmel-isi.h |4 +++ 2 files changed, 59 insertions(+), 1 deletions(-) dif

Re: [PATCH 1/4] v4l: add support for selection api

2011-09-05 Thread Sakari Ailus
Hi Tomasz, Thanks for the patch! On Wed, Aug 31, 2011 at 02:28:20PM +0200, Tomasz Stanislawski wrote: > This patch introduces new api for a precise control of cropping and composing > features for video devices. The new ioctls are VIDIOC_S_SELECTION and > VIDIOC_G_SELECTION. > > Signed-off-by: T

Re: BUG: unable to handle kernel paging request at 6b6b6bcb (v4l2_device_disconnect+0x11/0x30)

2011-09-05 Thread Hans Verkuil
On Monday, September 05, 2011 12:13:26 Hans Verkuil wrote: > On Monday, September 05, 2011 11:59:03 Laurent Pinchart wrote: > > Hi Hans, > > > > On Friday 02 September 2011 09:29:08 Sitsofe Wheeler wrote: > > > On Fri, Sep 02, 2011 at 01:35:49PM +0800, Dave Young wrote: > > > > On Fri, Sep 2, 2011

Re: BUG: unable to handle kernel paging request at 6b6b6bcb (v4l2_device_disconnect+0x11/0x30)

2011-09-05 Thread Hans Verkuil
On Monday, September 05, 2011 11:59:03 Laurent Pinchart wrote: > Hi Hans, > > On Friday 02 September 2011 09:29:08 Sitsofe Wheeler wrote: > > On Fri, Sep 02, 2011 at 01:35:49PM +0800, Dave Young wrote: > > > On Fri, Sep 2, 2011 at 12:59 PM, Dave Young wrote: > > > > On Fri, Sep 2, 2011 at 3:10 AM,

Re: Questions regarding Devices/Subdevices/MediaController usage in case of a SoC

2011-09-05 Thread Laurent Pinchart
Hi, On Friday 02 September 2011 23:30:11 Sakari Ailus wrote: > On Fri, Sep 02, 2011 at 11:38:06AM +0200, Alain VOLMAT wrote: > > I'm writing you in order to have some advices in the design of the V4L2 > > driver for a rather complex device. It is mainly related to > > device/subdev/media controlle

Re: [PATCH 1/2 v2] media: Add support for arbitrary resolution for the ov5642 camera driver

2011-09-05 Thread Laurent Pinchart
Hi Guennadi, On Monday 05 September 2011 11:51:57 Guennadi Liakhovetski wrote: > On Mon, 5 Sep 2011, Laurent Pinchart wrote: > > On Monday 05 September 2011 11:10:48 Bastian Hecht wrote: > > > 2011/8/31 Laurent Pinchart: > > > > On Wednesday 31 August 2011 19:06:25 Laurent Pinchart wrote: > > > >>

Re: [PATCH 1/2 v2] media: Add support for arbitrary resolution for the ov5642 camera driver

2011-09-05 Thread Laurent Pinchart
Hi Bastian, On Monday 05 September 2011 11:51:52 Bastian Hecht wrote: > 2011/9/5 Laurent Pinchart: > > On Monday 05 September 2011 11:41:28 Bastian Hecht wrote: > >> 2011/9/5 Laurent Pinchart: > >> > On Monday 05 September 2011 11:10:48 Bastian Hecht wrote: > >> >> 2011/8/31 Laurent Pinchart: > >>

Re: [PATCH 1/2 v2] media: Add support for arbitrary resolution for the ov5642 camera driver

2011-09-05 Thread Guennadi Liakhovetski
On Mon, 5 Sep 2011, Bastian Hecht wrote: [snip] > And these ioctl calls go straight through to my driver? Or is there > some intermediate work by the subdev architecture? I'm asking because > I don't check the buffer type in g_fmt as well. If so, I have to > change that too. With soc-camera all

Re: BUG: unable to handle kernel paging request at 6b6b6bcb (v4l2_device_disconnect+0x11/0x30)

2011-09-05 Thread Laurent Pinchart
Hi Hans, On Friday 02 September 2011 09:29:08 Sitsofe Wheeler wrote: > On Fri, Sep 02, 2011 at 01:35:49PM +0800, Dave Young wrote: > > On Fri, Sep 2, 2011 at 12:59 PM, Dave Young wrote: > > > On Fri, Sep 2, 2011 at 3:10 AM, Sitsofe Wheeler wrote: > > >> On Thu, Sep 01, 2011 at 05:02:51PM +0800, Da

Re: [PATCH 1/2 v2] media: Add support for arbitrary resolution for the ov5642 camera driver

2011-09-05 Thread Guennadi Liakhovetski
On Mon, 5 Sep 2011, Laurent Pinchart wrote: > Hi Bastian, > > On Monday 05 September 2011 11:10:48 Bastian Hecht wrote: > > 2011/8/31 Laurent Pinchart: > > > Hi Bastian, > > > > > > Guennadi pointed out that "should" can sound a bit harsh, so please read > > > my reviews as if > > > > > > #defi

Re: [PATCH 1/2 v2] media: Add support for arbitrary resolution for the ov5642 camera driver

2011-09-05 Thread Bastian Hecht
Hello Laurent, 2011/9/5 Laurent Pinchart : > Hi Bastian, > > On Monday 05 September 2011 11:41:28 Bastian Hecht wrote: >> 2011/9/5 Laurent Pinchart: >> > On Monday 05 September 2011 11:10:48 Bastian Hecht wrote: >> >> 2011/8/31 Laurent Pinchart: >> >> >> >  static int ov5642_g_crop(struct v4l2_sub

Re: [PATCH 1/2 v2] media: Add support for arbitrary resolution for the ov5642 camera driver

2011-09-05 Thread Laurent Pinchart
Hi Bastian, On Monday 05 September 2011 11:41:28 Bastian Hecht wrote: > 2011/9/5 Laurent Pinchart: > > On Monday 05 September 2011 11:10:48 Bastian Hecht wrote: > >> 2011/8/31 Laurent Pinchart: > >> >> > static int ov5642_g_crop(struct v4l2_subdev *sd, struct v4l2_crop > >> >> > *a) { > >> >> >

Re: [PATCH 1/2 v2] media: Add support for arbitrary resolution for the ov5642 camera driver

2011-09-05 Thread Bastian Hecht
2011/9/5 Laurent Pinchart : > Hi Bastian, > > On Monday 05 September 2011 11:10:48 Bastian Hecht wrote: >> 2011/8/31 Laurent Pinchart: >> > Hi Bastian, >> > >> > Guennadi pointed out that "should" can sound a bit harsh, so please read >> > my reviews as if >> > >> > #define "you should" "I think yo

Re: [PATCH] media: Add camera controls for the ov5642 driver

2011-09-05 Thread Bastian Hecht
2011/9/1 Sakari Ailus : > On Thu, Sep 01, 2011 at 11:14:08AM +0200, Sylwester Nawrocki wrote: >> Hi Sakari, >> >> On 09/01/2011 10:47 AM, Sakari Ailus wrote: >> > On Thu, Sep 01, 2011 at 09:15:20AM +0200, Guennadi Liakhovetski wrote: >> >> On Thu, 1 Sep 2011, Sakari Ailus wrote: >> >> >> >>> On Wed

Re: [PATCH 1/2 v2] media: Add support for arbitrary resolution for the ov5642 camera driver

2011-09-05 Thread Laurent Pinchart
Hi Bastian, On Monday 05 September 2011 11:10:48 Bastian Hecht wrote: > 2011/8/31 Laurent Pinchart: > > Hi Bastian, > > > > Guennadi pointed out that "should" can sound a bit harsh, so please read > > my reviews as if > > > > #define "you should" "I think you should" > > I think that you think

[PATCH 1/2 v3] media: Add support for arbitrary resolution for the ov5642 camera driver

2011-09-05 Thread Bastian Hecht
This patch adds the ability to get arbitrary resolutions with a width up to 2592 and a height up to 720 pixels instead of the standard 1280x720 only. --- diff --git a/drivers/media/video/ov5642.c b/drivers/media/video/ov5642.c index 6410bda..54c822c 100644 --- a/drivers/media/video/ov5642.c +++ b/

Re: [PATCH 1/2 v2] media: Add support for arbitrary resolution for the ov5642 camera driver

2011-09-05 Thread Bastian Hecht
Hello Laurent, 2011/8/31 Laurent Pinchart : > Hi Bastian, > > Guennadi pointed out that "should" can sound a bit harsh, so please read my > reviews as if > > #define "you should" "I think you should" I think that you think I should do the right thing. I removed out_sizes and repost v3 in a moment

RE: [PATCH] at91: add Atmel ISI and ov2640 support on m10/g45 board.

2011-09-05 Thread Wu, Josh
On 09/03/2011 2:22 AM Jean-Christophe PLAGNIOL-VILLARD wrote: >> >> #include >> #include >> @@ -194,6 +197,95 @@ static void __init ek_add_device_nand(void) >> at91_add_device_nand(&ek_nand_data); >> } >> >> +/* >> + * ISI >> + */ >> +#if defined(CONFIG_VIDEO_ATMEL_ISI) || >> de

RE: DiBxxxx: fixes for 3.1/3.0

2011-09-05 Thread Olivier Grenie
Hello Mauro, I agree with you but when I wrote this patch, my concern was that the read register function (dib0070_read_reg) returns a u16 and so I could not propagate the error. That's why I decided to return 0 and not change the API. But if you have a better idea, I will have no problem to im

Re: spca1528 device (Device 015: ID 04fc:1528 Sunplus Technology)..libv4l2: error turning on stream: Timer expired issue

2011-09-05 Thread Jean-Francois Moine
On Sun, 04 Sep 2011 15:39:30 -0400 Mauricio Henriquez wrote: > Recently I'm trying to make work a Sunplus crappy mini HD USB camera, lsusb > list this info related to the device: > > Picture Transfer Protocol (PIMA 15470) > Bus 001 Device 015: ID 04fc:1528 Sunplus Technology Co., Ltd > > idVe