[Q] vb2 userptr: struct vb2_ops::buf_cleanup() is called without buf_init()

2012-05-21 Thread Guennadi Liakhovetski
Hi A recent report http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/47594 has revealed the following asymmetry in how videobuf2 functions: as is also documented in videobuf2-core.h, the user's struct vb2_ops::buf_init() method in the MMAP case is called after allocating

Re: [PATCH 06/10] video/uvc: use memweight()

2012-05-21 Thread Akinobu Mita
2012/5/21 Laurent Pinchart laurent.pinch...@ideasonboard.com: Hi Akinobu, Thank you for the patch. On Sunday 20 May 2012 22:23:19 Akinobu Mita wrote: Use memweight() to count the total number of bits set in memory area. Signed-off-by: Akinobu Mita akinobu.m...@gmail.com Cc: Laurent

Re: [PATCH 06/10] video/uvc: use memweight()

2012-05-21 Thread Laurent Pinchart
Hi Akinobu, On Monday 21 May 2012 21:03:10 Akinobu Mita wrote: 2012/5/21 Laurent Pinchart laurent.pinch...@ideasonboard.com: Hi Akinobu, Thank you for the patch. On Sunday 20 May 2012 22:23:19 Akinobu Mita wrote: Use memweight() to count the total number of bits set in memory area.

[PATCH] media_build: disable VIDEO_SMIAPP_PLL, VIDEO_MT9M032 and VIDEO_MT9P031 on old kernels

2012-05-21 Thread Gianluca Gennari
VIDEO_SMIAPP_PLL can't build on vanilla kernels older than 2.6.34 as it requires linux/lcm.h; this is not a problem with the Ubuntu 10.04 2.6.32 kernel as it includes the new lcm.* lib/header files, so the issue was not detected before. This fixes the error: media_build/v4l/smiapp-pll.c:26:23:

Firmware blob in vs6624 driver

2012-05-21 Thread Ben Hutchings
The array vs6624_p1 is a list of bytes to write to the VS6624's microcontroller registers/memory, written before it starts running code: vs6624_writeregs(sd, vs6624_p1); vs6624_write(sd, VS6624_MICRO_EN, 0x2); vs6624_write(sd, VS6624_DIO_EN, 0x1); mdelay(10); This

re: [media] DVB: add support for the LG2160 ATSC-MH demodulator

2012-05-21 Thread Dan Carpenter
Hi Michael, I have a question about e26f2ae4527b: [media] DVB: add support for the LG2160 ATSC-MH demodulator from Jan 29, 2012. 122 static int lg216x_write_regs(struct lg216x_state *state, 123 struct lg216x_reg *regs, int len) 124 { 125 int

Re: [PATCH v3] scatterlist: add sg_alloc_table_from_pages function

2012-05-21 Thread Tomasz Stanislawski
Hi Andrew, Thank you for your review, Please refer to the comments below. On 05/18/2012 01:56 AM, Andrew Morton wrote: On Tue, 08 May 2012 11:50:33 +0200 Tomasz Stanislawski t.stanisl...@samsung.com wrote: This patch adds a new constructor for an sg table. The table is constructed from an

re: [media] v4l/dvb: fix compiler warnings

2012-05-21 Thread Dan Carpenter
Hello Hans Verkuil, The patch fdf07b027b2d: [media] v4l/dvb: fix compiler warnings from Apr 20, 2012, leads to the following GCC warning: warning: value computed is not used [-Wunused-value] The point of the patch was to get rid of a set but not used warning which is turned off by

Re: [PATCH 2/3] fc001x: tuner driver for FC0012, version 0.5

2012-05-21 Thread Mauro Carvalho Chehab
Em 21-05-2012 00:16, Antti Palosaari escreveu: ma 21.5.2012 5:25 Mauro Carvalho Chehab kirjoitti: Em 20-05-2012 13:56, Antti Palosaari escreveu: Hmm, Mauro just merged those FC0012 and FC0013 drivers via my RTL2831U tree... It was not my meaning to do that like this. This was due to a pull

[RFC Patch] omap3isp : support CFA pattern when not GRBG

2012-05-21 Thread jean-philippe francois
Hi, omap3 ISP previewer block can convert a raw bayer image into a UYVY image. Debayering coefficient are stored in an undocumented table. In the current form, only GRBG format are converted correctly. However, the other CFA arrangement can be transformed in GRBG arrangement by shifting the

Re: [media] DVB: add support for the LG2160 ATSC-MH demodulator

2012-05-21 Thread Michael Krufky
On Mon, May 21, 2012 at 9:58 AM, Dan Carpenter dan.carpen...@oracle.com wrote: Hi Michael, I have a question about e26f2ae4527b: [media] DVB: add support for the LG2160 ATSC-MH demodulator from Jan 29, 2012.   122  static int lg216x_write_regs(struct lg216x_state *state,   123              

[PATCH] lg2160: fix off-by-one error in lg216x_write_regs

2012-05-21 Thread Michael Krufky
Fix an off-by-one error in lg216x_write_regs, causing the last element of the lg216x init block to be ignored. Spotted by Dan Carpenteter. Thanks-to: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Michael Krufky mkru...@linuxtv.org --- drivers/media/dvb/frontends/lg2160.c |2 +- 1

Re: [PATCH] lg2160: fix off-by-one error in lg216x_write_regs

2012-05-21 Thread Michael Krufky
eeek! spelling error in dan's name! my apologies. I will correct this in my tree before I ask Mauro to merge it. -Mike On Mon, May 21, 2012 at 11:34 AM, Michael Krufky mkru...@kernellabs.com wrote: Fix an off-by-one error in lg216x_write_regs, causing the last element of the lg216x init

Re: [PATCH] lg2160: fix off-by-one error in lg216x_write_regs

2012-05-21 Thread Dan Carpenter
On Mon, May 21, 2012 at 11:58:06AM -0400, Michael Krufky wrote: eeek! spelling error in dan's name! my apologies. I will correct this in my tree before I ask Mauro to merge it. Hehe. Also since you're redoing it, could you change the Thanks-to: to Reported-by:? regards, dan carpenter --

[PATCH] lg2160: fix off-by-one error in lg216x_write_regs

2012-05-21 Thread Michael Krufky
Fix an off-by-one error in lg216x_write_regs, causing the last element of the lg216x init block to be ignored. Spotted by Dan Carpenter. Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Michael Krufky mkru...@linuxtv.org --- drivers/media/dvb/frontends/lg2160.c |2 +- 1

Re: [PATCH 2/3] fc001x: tuner driver for FC0012, version 0.5

2012-05-21 Thread Antti Palosaari
ma 21.5.2012 17:29 Mauro Carvalho Chehab kirjoitti: Em 21-05-2012 00:16, Antti Palosaari escreveu: ma 21.5.2012 5:25 Mauro Carvalho Chehab kirjoitti: Em 20-05-2012 13:56, Antti Palosaari escreveu: Hmm, Mauro just merged those FC0012 and FC0013 drivers via my RTL2831U tree... It was not my

Re: [PATCH 2/3] fc001x: tuner driver for FC0012, version 0.5

2012-05-21 Thread Mauro Carvalho Chehab
Em 21-05-2012 13:14, Antti Palosaari escreveu: With regard to the merged patches, if they are really broken, please submit me a patch removing them. They are not broken mean of broken. Let those be as it is now and apply fixes top of that. OK. regards Antti -- To unsubscribe from

[PATCH V7 0/5] [Media] Radio: Fixes and New features for FM

2012-05-21 Thread manjunatha_halli
From: Manjunatha Halli x0130...@ti.com Mauro and the list, This version 7 of patchset resolves the comments received from Han's on patchset v6. Also removed the frequency band handling from this patch set. This patchset creates new control class 'V4L2_CTRL_CLASS_FM_RX' for FM RX, introduces 2

[PATCH V7 1/5] WL128x: Add support for FM TX RDS

2012-05-21 Thread manjunatha_halli
From: Manjunatha Halli x0130...@ti.com This patch adds support for following FM TX RDS features, 1. Radio Text 2. PS Name 3. PI Code 4. PTY Code. Along with above this patch fixes few other minor issues(like fm tx get frequency, unnecessary error messages etc). Acked-by:

[PATCH V7 4/5] Media: Update docs for V4L2 FM new features

2012-05-21 Thread manjunatha_halli
From: Manjunatha Halli x0130...@ti.com The list of new features - 1) New control class for FM RX 2) New FM RX CID's - De-Emphasis filter mode and RDS AF switch 3) New FM TX CID - RDS Alternate frequency set. Acked-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by:

[PATCH V7 5/5] WL12xx: Add support for FM new features

2012-05-21 Thread manjunatha_halli
From: Manjunatha Halli x0130...@ti.com This patch adds below features to TI's V4l2 FM driver for Wilink chipsets, 1) FM RX RDS AF turn ON/OFF 2) FM RX De-Emphasis mode set/get 3) FM TX Alternate Frequency set/get Also this patch fixes below issues 1) FM audio

[PATCH V7 2/5] New control class and features for FM RX

2012-05-21 Thread manjunatha_halli
From: Manjunatha Halli x0130...@ti.com This patch creates new ctrl class for FM RX and adds new CID's for below FM features, 1) De-Emphasis filter mode 2) RDS Alternate Frequency switch Acked-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Manjunatha Halli x0130...@ti.com ---

[PATCH V7 3/5] Add new CID for FM TX RDS Alternate Frequency

2012-05-21 Thread manjunatha_halli
From: Manjunatha Halli x0130...@ti.com Acked-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Manjunatha Halli x0130...@ti.com --- drivers/media/video/v4l2-ctrls.c |1 + include/linux/videodev2.h|1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git

Re: [PATCH V6 2/5] New control class and features for FM RX

2012-05-21 Thread halli manjunatha
On Sun, May 20, 2012 at 4:52 AM, Hans Verkuil hverk...@xs4all.nl wrote: On Tue May 15 2012 00:01:50 manjunatha_ha...@ti.com wrote: From: Manjunatha Halli x0130...@ti.com This patch creates new ctrl class for FM RX and adds new CID's for below FM features,       1) De-Emphasis filter mode    

[PULL BUG-FIX] git://git.linuxtv.org/mkrufky/mxl111sf lg2160

2012-05-21 Thread Michael Krufky
Mauro, Please merge: The following changes since commit abed623ca59a7d1abed6c4e7459be03e25a90a1e: [media] radio-sf16fmi: add support for SF16-FMD (2012-05-20 16:10:05 -0300) are available in the git repository at: git://git.linuxtv.org/mkrufky/mxl111sf lg2160 for you to fetch changes up

cron job: media_tree daily build: ERRORS

2012-05-21 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Mon May 21 19:00:21 CEST 2012 git hash:abed623ca59a7d1abed6c4e7459be03e25a90a1e gcc version: i686-linux-gcc

Re: [PATCH 3/3] fc001x: tuner driver for FC0013

2012-05-21 Thread Hans-Frieder Vogt
Antti, Am Sonntag, 20. Mai 2012 schrieb Antti Palosaari: On 06.05.2012 23:57, Hans-Frieder Vogt wrote: Support for tuner Fitipower FC0013 Signed-off-by: Hans-Frieder Vogthfv...@gmx.net drivers/media/common/tuners/Kconfig |7 drivers/media/common/tuners/Makefile |

[PATCH] DVB: improve handling of TS packets containing a raised TEI bit

2012-05-21 Thread Michael Krufky
When the TEI bit is raised, we should not trust any of the contents of the packet in question, including but not limited to its PID number. Considering that we don't trust the PID number of this packet, we should not proceed to check the packet counter (if dvb_demux_tscheck is set). We should

[PATCH] video: mx2_camera: Fix build error due to the lack of 'pixfmt' definition

2012-05-21 Thread Fabio Estevam
commit d509835 ([media] media: mx2_camera: Fix mbus format handling) caused the following build error: drivers/media/video/mx2_camera.c:1032:42: error: 'pixfmt' undeclared (first use in this function) make[4]: *** [drivers/media/video/mx2_camera.o] Error 1 Fix this build error by providing a