Re: [PATCH v2 01/01] media: gscaler: Add new driver for generic scaler

2012-07-23 Thread Shaik Ameer Basha
Hi Sylwester, thanks for your review comments... I will update the Gscaler driver code with the other two set of review comments you posted earlier... however, i have some doubts in this set of review comments. please find my comments inline... On Fri, Jul 13, 2012 at 12:39 AM, Sylwester

RE: [PATCH v6 1/2] media: add new mediabus format enums for dm365

2012-07-23 Thread Lad, Prabhakar
Hi Laurent, On Fri, Jul 20, 2012 at 23:02:23, Laurent Pinchart wrote: Hi Prabhakar, Just one small comment below. On Friday 20 July 2012 20:28:09 Prabhakar Lad wrote: From: Manjunath Hadli manjunath.ha...@ti.com add new enum entries for supporting the media-bus formats on dm365.

RE: [PATCH v6 2/2] v4l2: add new pixel formats supported on dm365

2012-07-23 Thread Lad, Prabhakar
Hi Sakari, On Sat, Jul 21, 2012 at 13:26:27, Sakari Ailus wrote: Hi Prabhakar, Thanks for the patch. On Fri, Jul 20, 2012 at 08:28:10PM +0530, Prabhakar Lad wrote: From: Manjunath Hadli manjunath.ha...@ti.com add new macro V4L2_PIX_FMT_SGRBG10ALAW8 and associated formats to

Re: [PATCH v6] media: coda: Add driver for Coda video codec.

2012-07-23 Thread javier Martin
Hi Hans, On 21 July 2012 11:50, Hans Verkuil hverk...@xs4all.nl wrote: On Fri July 20 2012 13:08:35 Javier Martin wrote: Coda is a range of video codecs from ChipsMedia that support H.264, H.263, MPEG4 and other video standards. Currently only support for the codadx6 included in the i.MX27

Re: [PATCH] [v3] i.MX27: Fix emma-prp clocks in mx2_camera.c

2012-07-23 Thread javier Martin
On 20 July 2012 15:43, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Fri, 20 Jul 2012, javier Martin wrote: On 20 July 2012 13:19, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: Hi Javier Thanks for the patch On Mon, 9 Jul 2012, javier Martin wrote: On 9 July 2012

Re: [PATCH v6] media: coda: Add driver for Coda video codec.

2012-07-23 Thread Hans Verkuil
On Mon July 23 2012 10:02:04 javier Martin wrote: Hi Hans, On 21 July 2012 11:50, Hans Verkuil hverk...@xs4all.nl wrote: On Fri July 20 2012 13:08:35 Javier Martin wrote: Coda is a range of video codecs from ChipsMedia that support H.264, H.263, MPEG4 and other video standards.

Re: [PATCH v6] media: coda: Add driver for Coda video codec.

2012-07-23 Thread javier Martin
On 23 July 2012 10:20, Hans Verkuil hverk...@xs4all.nl wrote: On Mon July 23 2012 10:02:04 javier Martin wrote: Hi Hans, On 21 July 2012 11:50, Hans Verkuil hverk...@xs4all.nl wrote: On Fri July 20 2012 13:08:35 Javier Martin wrote: Coda is a range of video codecs from ChipsMedia that

Re: [PATCH v6] media: coda: Add driver for Coda video codec.

2012-07-23 Thread Hans Verkuil
On Mon July 23 2012 10:27:13 javier Martin wrote: On 23 July 2012 10:20, Hans Verkuil hverk...@xs4all.nl wrote: On Mon July 23 2012 10:02:04 javier Martin wrote: Hi Hans, On 21 July 2012 11:50, Hans Verkuil hverk...@xs4all.nl wrote: On Fri July 20 2012 13:08:35 Javier Martin wrote:

Fwd: [PATCH v6] media: coda: Add driver for Coda video codec.

2012-07-23 Thread javier Martin
-- Forwarded message -- From: javier Martin javier.mar...@vista-silicon.com Date: 23 July 2012 10:39 Subject: Re: [PATCH v6] media: coda: Add driver for Coda video codec. To: Hans Verkuil hverk...@xs4all.nl On 23 July 2012 10:36, Hans Verkuil hverk...@xs4all.nl wrote: On Mon

Re: [PATCH v6] media: coda: Add driver for Coda video codec.

2012-07-23 Thread javier Martin
Sorry, I had a problem with my buildroot environment. This is the v4l2-compliance output with the most recent version: # v4l2-compliance -d /dev/video2 Driver Info: Driver name : coda Card type : coda Bus info : coda Driver version: 0.0.0

Re: [PATCH v6] media: coda: Add driver for Coda video codec.

2012-07-23 Thread javier Martin
On 23 July 2012 11:45, javier Martin javier.mar...@vista-silicon.com wrote: Sorry, I had a problem with my buildroot environment. This is the v4l2-compliance output with the most recent version: # v4l2-compliance -d /dev/video2 Driver Info: Driver name : coda Card type

Re: [PATCH v6] media: coda: Add driver for Coda video codec.

2012-07-23 Thread Hans Verkuil
On Mon July 23 2012 12:00:30 javier Martin wrote: On 23 July 2012 11:45, javier Martin javier.mar...@vista-silicon.com wrote: Sorry, I had a problem with my buildroot environment. This is the v4l2-compliance output with the most recent version: # v4l2-compliance -d /dev/video2 Driver

Re: [PATCH v6] media: coda: Add driver for Coda video codec.

2012-07-23 Thread Sylwester Nawrocki
On 07/23/2012 12:14 PM, Hans Verkuil wrote: On Mon July 23 2012 12:00:30 javier Martin wrote: On 23 July 2012 11:45, javier Martin javier.mar...@vista-silicon.com wrote: Sorry, I had a problem with my buildroot environment. This is the v4l2-compliance output with the most recent version: #

Re: [PATCH v6] media: coda: Add driver for Coda video codec.

2012-07-23 Thread Hans Verkuil
On Mon July 23 2012 12:21:09 Sylwester Nawrocki wrote: On 07/23/2012 12:14 PM, Hans Verkuil wrote: On Mon July 23 2012 12:00:30 javier Martin wrote: On 23 July 2012 11:45, javier Martin javier.mar...@vista-silicon.com wrote: Sorry, I had a problem with my buildroot environment. This is

Re: [PATCH v6] media: coda: Add driver for Coda video codec.

2012-07-23 Thread javier Martin
On 23 July 2012 12:14, Hans Verkuil hverk...@xs4all.nl wrote: On Mon July 23 2012 12:00:30 javier Martin wrote: On 23 July 2012 11:45, javier Martin javier.mar...@vista-silicon.com wrote: Sorry, I had a problem with my buildroot environment. This is the v4l2-compliance output with the most

Re: [PATCH v6] media: coda: Add driver for Coda video codec.

2012-07-23 Thread Hans Verkuil
On Mon July 23 2012 12:43:59 javier Martin wrote: On 23 July 2012 12:14, Hans Verkuil hverk...@xs4all.nl wrote: On Mon July 23 2012 12:00:30 javier Martin wrote: On 23 July 2012 11:45, javier Martin javier.mar...@vista-silicon.com wrote: Sorry, I had a problem with my buildroot

[GIT PULL FOR v3.6] mem2mem_testdev: fix v4l2-compliance errors

2012-07-23 Thread Hans Verkuil
Hi all! These patches fix v4l2-compliance errors in mem2mem_testdev. Two core fixes (v4l2-dev.c and v4l2-mem2mem.c) and the other fixes are all in the driver itself. Regards, Hans The following changes since commit 931efdf58bd83af8d0578a6cc53421675daf6d41: Merge branch

[GIT PULL FOR v3.6] Add adv7604/ad9389b drivers

2012-07-23 Thread Hans Verkuil
Hi all! There haven't been any comments since either RFCv1 or RFCv2. (http://www.spinics.net/lists/linux-media/msg48529.html and http://www.spinics.net/lists/linux-media/msg50413.html) So I'm making this pull request now. The only changes since RFCv2 are some documentation fixes: - Add a note

Re: [PATCH v7] media: coda: Add driver for Coda video codec.

2012-07-23 Thread Hans Verkuil
On Mon July 23 2012 13:31:01 Javier Martin wrote: Coda is a range of video codecs from ChipsMedia that support H.264, H.263, MPEG4 and other video standards. Currently only support for the codadx6 included in the i.MX27 SoC is added. H.264 and MPEG4 video encoding are the only supported

Re: [PATCH v7] media: coda: Add driver for Coda video codec.

2012-07-23 Thread javier Martin
On 23 July 2012 13:38, Hans Verkuil hverk...@xs4all.nl wrote: On Mon July 23 2012 13:31:01 Javier Martin wrote: Coda is a range of video codecs from ChipsMedia that support H.264, H.263, MPEG4 and other video standards. Currently only support for the codadx6 included in the i.MX27 SoC is

Re: [PATCH v7] media: coda: Add driver for Coda video codec.

2012-07-23 Thread Hans Verkuil
On Mon July 23 2012 13:56:49 javier Martin wrote: On 23 July 2012 13:38, Hans Verkuil hverk...@xs4all.nl wrote: On Mon July 23 2012 13:31:01 Javier Martin wrote: Coda is a range of video codecs from ChipsMedia that support H.264, H.263, MPEG4 and other video standards. Currently only

[PATCH v3 0/4] update MFC v4l2 driver to support MFC6.x

2012-07-23 Thread Arun Kumar K
The patchset adds support for MFCv6 firmware in s5p-mfc driver. The original patch is split into 4 patches for easy review. This patchset have to be applied on patches [1] and [2] posted earlier which adds the required v4l2 controls. Changelog - Supports MFCv5 and v6 co-existence. - Tested for

Re: [RFC] media DT bindings

2012-07-23 Thread Mark Brown
On Wed, Jul 18, 2012 at 07:00:15PM +0200, Sylwester Nawrocki wrote: One possible solution would be to have host/bridge drivers to register a clkdev entry for I2C client device, so it can acquire the clock through just clk_get(). We would have to ensure the clock is not tried to be accessed

[PATCH v3 2/4] [media] s5p-mfc: Decoder and encoder common files

2012-07-23 Thread Arun Kumar K
From: Jeongtae Park jtp.p...@samsung.com New v4l controls for the MFCv6 firmware are implemented. Also modifies the files for v5 and v6 coexistence. Signed-off-by: Jeongtae Park jtp.p...@samsung.com Singed-off-by: Janghyuck Kim janghyuck@samsung.com Singed-off-by: Jaeryul Oh

Re: CX25821 driver in kernel 3.4.4 problem

2012-07-23 Thread Devin Heitmueller
On Mon, Jul 23, 2012 at 3:40 AM, Radek Mašín ra...@masin.eu wrote: Hello, may be one more problem. I use Zoneminder software for capturing pictures from card and occasionally I get corrupted picture. Please take a look for attached files. Looks like the IRQ handler wasn't servicing fast

Re: [GIT PULL FOR v3.6] Add adv7604/ad9389b drivers

2012-07-23 Thread Laurent Pinchart
Hi Hans, On Monday 23 July 2012 13:36:15 Hans Verkuil wrote: Hi all! There haven't been any comments since either RFCv1 or RFCv2. (http://www.spinics.net/lists/linux-media/msg48529.html and http://www.spinics.net/lists/linux-media/msg50413.html) So I'm making this pull request now.

Re: [PATCH v7] media: coda: Add driver for Coda video codec.

2012-07-23 Thread Sylwester Nawrocki
On 07/23/2012 01:31 PM, Javier Martin wrote: Coda is a range of video codecs from ChipsMedia that support H.264, H.263, MPEG4 and other video standards. Currently only support for the codadx6 included in the i.MX27 SoC is added. H.264 and MPEG4 video encoding are the only supported

Re: Supporting 3D formats in V4L2

2012-07-23 Thread Soby Mathew
Hi Hans, Thanks for the reply and I was going through the HDMI1.4 spec again. The 'active space' is part of the Vactive and Vactive is sum of active video and active space. No, as I understand it active_space is just part of the active video. So the timings struct is fine, it's just that the

Re: [PATCH v7] media: coda: Add driver for Coda video codec.

2012-07-23 Thread Sylwester Nawrocki
On 07/23/2012 01:56 PM, javier Martin wrote: Sakari, Sylwester could I get an ack from you too? Sure, I just replied in the patch thread. -- Thanks, Sylwester -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More

Re: [GIT PULL FOR v3.6] Add adv7604/ad9389b drivers

2012-07-23 Thread Hans Verkuil
On Mon July 23 2012 14:25:38 Laurent Pinchart wrote: Hi Hans, On Monday 23 July 2012 13:36:15 Hans Verkuil wrote: Hi all! There haven't been any comments since either RFCv1 or RFCv2. (http://www.spinics.net/lists/linux-media/msg48529.html and

Re: [GIT PULL FOR v3.6] Add adv7604/ad9389b drivers

2012-07-23 Thread Laurent Pinchart
Hi Hans, On Monday 23 July 2012 14:36:35 Hans Verkuil wrote: On Mon July 23 2012 14:25:38 Laurent Pinchart wrote: On Monday 23 July 2012 13:36:15 Hans Verkuil wrote: Hi all! There haven't been any comments since either RFCv1 or RFCv2.

[PATCH] v4l2-ctrls: Add v4l2_ctrl_s_ctrl_int64()

2012-07-23 Thread Laurent Pinchart
This helper function sets a 64-bit control's value from within a driver. It's similar to v4l2_ctrl_s_ctrl() but operates on 64-bit integer controls instead of 32-bit controls. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/v4l2-ctrls.c | 37

Re: Supporting 3D formats in V4L2

2012-07-23 Thread Hans Verkuil
On Mon July 23 2012 14:35:14 Soby Mathew wrote: Hi Hans, Thanks for the reply and I was going through the HDMI1.4 spec again. The 'active space' is part of the Vactive and Vactive is sum of active video and active space. No, as I understand it active_space is just part of the active

Re: [PATCH] v4l2-ctrls: Add v4l2_ctrl_s_ctrl_int64()

2012-07-23 Thread Hans Verkuil
On Mon July 23 2012 14:38:14 Laurent Pinchart wrote: This helper function sets a 64-bit control's value from within a driver. It's similar to v4l2_ctrl_s_ctrl() but operates on 64-bit integer controls instead of 32-bit controls. Signed-off-by: Laurent Pinchart

Re: CX25821 driver in kernel 3.4.4 problem

2012-07-23 Thread Radek Mašín
Hello, thank you for answer. Problems occurs on all channels and don't depend on number of channels used. I have tried to run only one channel, but it didn't help. I bought this card from dx.com for 65$. May be, I'll be able to provide access to my testing system with this card, if it is

[PATCH v2] v4l2-ctrls: Add v4l2_ctrl_[gs]_ctrl_int64()

2012-07-23 Thread Laurent Pinchart
These helper functions get and set a 64-bit control's value from within a driver. They are similar to v4l2_ctrl_[gs]_ctrl() but operate on 64-bit integer controls instead of 32-bit controls. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/v4l2-ctrls.c |

Re: [PATCH v2] v4l2-ctrls: Add v4l2_ctrl_[gs]_ctrl_int64()

2012-07-23 Thread Hans Verkuil
On Mon July 23 2012 16:02:40 Laurent Pinchart wrote: These helper functions get and set a 64-bit control's value from within a driver. They are similar to v4l2_ctrl_[gs]_ctrl() but operate on 64-bit integer controls instead of 32-bit controls. Signed-off-by: Laurent Pinchart

Re: [PATCH] Documentation: DocBook DRM framework documentation

2012-07-23 Thread Michael Jones
Hi Laurent, At a quick glance I noticed a couple of things: On 07/13/2012 02:00 AM, Laurent Pinchart wrote: [snip] +para + The structnamedrm_driver/structname structure contains static + information that describe the driver and features it supports, and s/describe/describes/

Re: ATI theatre 750 HD tuner USB stick

2012-07-23 Thread Joshua Roys
Fisher Grubb fisher.grubb at gmail.com writes: Hi all, My name is Fisher Grubb, I have an ATI (now AMD) theatre 750 HD based TV tuner USB stick. I don't think this ATI chipset is supported by linuxTV and have had no joy search google as others also hit a dead end. Hello, I'm working on

Re: [PATCH 2/2] kthread_worker: reimplement flush_kthread_work() to allow freeing the work item being executed

2012-07-23 Thread Tejun Heo
Hello, On Sun, Jul 22, 2012 at 04:46:54PM -0400, Andy Walls wrote: Hmmm, I didn't know about the constraint about 'known to be alive' in the other email I just sent. That might make calling flush_kthread_work() hard for a user to use, if the user lets the work get freed by another thread

Re: [PATCH] Documentation: DocBook DRM framework documentation

2012-07-23 Thread Laurent Pinchart
Hi Michael, Thank you for the review. On Monday 23 July 2012 17:12:43 Michael Jones wrote: Hi Laurent, At a quick glance I noticed a couple of things: On 07/13/2012 02:00 AM, Laurent Pinchart wrote: [snip] +para + The structnamedrm_driver/structname structure contains

Re: [PATCH v2] v4l2-ctrls: Add v4l2_ctrl_[gs]_ctrl_int64()

2012-07-23 Thread Laurent Pinchart
Hi Hans, On Monday 23 July 2012 17:05:35 Hans Verkuil wrote: On Mon July 23 2012 16:02:40 Laurent Pinchart wrote: These helper functions get and set a 64-bit control's value from within a driver. They are similar to v4l2_ctrl_[gs]_ctrl() but operate on 64-bit integer controls instead of

Re: [PATCH v2] v4l2-ctrls: Add v4l2_ctrl_[gs]_ctrl_int64()

2012-07-23 Thread Hans Verkuil
On Mon July 23 2012 19:16:03 Laurent Pinchart wrote: Hi Hans, On Monday 23 July 2012 17:05:35 Hans Verkuil wrote: On Mon July 23 2012 16:02:40 Laurent Pinchart wrote: These helper functions get and set a 64-bit control's value from within a driver. They are similar to

Re: [PATCH] davinci: vpss: enable vpss clocks

2012-07-23 Thread Sekhar Nori
Hi Prabhakar, On 7/20/2012 7:41 PM, Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar@ti.com By default the VPSS clocks are only enabled in capture driver. and display wont work if the capture is not enabled. This patch adds support to enable the VPSS clocks in VPSS driver. This way

[PATCH 0/4] Aptinate sensors patches

2012-07-23 Thread Laurent Pinchart
Hi everybody, Here are three fixes/patches for the MT9P031 and MT9V032 sensor drivers. The second patch (mt9v032 pixel rate control) requires a control framework modification (1/4) that has already been reviewed. Sakari, I've rebased your patch on top of the latest media tree, could you please

[PATCH 1/4] v4l2-ctrls: Add v4l2_ctrl_[gs]_ctrl_int64()

2012-07-23 Thread Laurent Pinchart
These helper functions get and set a 64-bit control's value from within a driver. They are similar to v4l2_ctrl_[gs]_ctrl() but operate on 64-bit integer controls instead of 32-bit controls. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Hans Verkuil

[PATCH 3/4] mt9v032: Export horizontal and vertical blanking as V4L2 controls

2012-07-23 Thread Laurent Pinchart
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/mt9v032.c | 34 +++--- 1 files changed, 31 insertions(+), 3 deletions(-) diff --git a/drivers/media/video/mt9v032.c b/drivers/media/video/mt9v032.c index 2203a6f..df55044

[PATCH 2/4] mt9v032: Provide pixel rate control

2012-07-23 Thread Laurent Pinchart
From: Sakari Ailus sakari.ai...@iki.fi Provide pixel rate control calculated from external clock and horizontal binning factor. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/mt9v032.c | 27

[PATCH 4/4] mt9p031: Fix horizontal and vertical blanking configuration

2012-07-23 Thread Laurent Pinchart
Compute the horizontal blanking value according to the datasheet. The value written to the hblank and vblank registers must be equal to the number of blank columns and rows minus one. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/mt9p031.c | 12

Re: [PATCH v2 01/01] media: gscaler: Add new driver for generic scaler

2012-07-23 Thread Sylwester Nawrocki
Hi Shaik, On 07/23/2012 08:18 AM, Shaik Ameer Basha wrote: +struct gsc_fmt *find_fmt(u32 *pixelformat, u32 *mbus_code, int index) +{ + struct gsc_fmt *fmt, *def_fmt = NULL; + unsigned int i; + + if (index= ARRAY_SIZE(gsc_formats)) if (index=

cron job: media_tree daily build: ERRORS

2012-07-23 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Mon Jul 23 19:00:23 CEST 2012 git hash:931efdf58bd83af8d0578a6cc53421675daf6d41 gcc version: i686-linux-gcc

Re: [PATCH] rtl2832.c: minor cleanup

2012-07-23 Thread Thomas Mair
On 15.07.2012 19:56, Hans-Frieder Vogt wrote: The current formulation of the bw_params loop uses the counter j as an index for the first dimension of the bw_params array which is later incremented by the variable i. It is evaluated correctly only, because j is initialized to 0 at the

[PATCH v2] mt9v032: Export horizontal and vertical blanking as V4L2 controls

2012-07-23 Thread Laurent Pinchart
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/mt9v032.c | 36 +--- 1 files changed, 33 insertions(+), 3 deletions(-) Changes since v1: - Make sure the total horizontal time will not go below 660 when setting the

RE: [PATCH v6 1/2] media: add new mediabus format enums for dm365

2012-07-23 Thread Lad, Prabhakar
Hi Sakari, On Sat, Jul 21, 2012 at 13:02:31, Sakari Ailus wrote: Hi Prabhakar, Thanks for the patch! Just a few comments. On Fri, Jul 20, 2012 at 08:28:09PM +0530, Prabhakar Lad wrote: From: Manjunath Hadli manjunath.ha...@ti.com add new enum entries for supporting the media-bus