Commit c003ab1b ([media] rc-core: add separate defines for protocol bitmaps
and numbers) has introduced a bug which allows store_protocols() to return
without releasing the device mutex it's holding.
Doing that would cause infinite hangs waiting on device mutex next time
around.
Signed-off-by:
Am 06.12.2012 23:58, schrieb Matthew Gyurgyik:
On 12/06/2012 04:49 PM, Frank Schäfer wrote:
Did you switch back to
.mpeg_mode = LGDT3305_MPEG_SERIAL,
.tpclk_edge = LGDT3305_TPCLK_FALLING_EDGE,
in struct lgdt3305_config em2874_lgdt3305_dev (em28xx-dvb.c) before
On 12/08/2012 08:52 AM, Frank Schäfer wrote:
I lied, it works! I must have forgotten to do run make modules_install
or something! This patch accurately states my current code changes:
http://pyther.net/a/digivox_atsc/diff-Dec-06-v1.patch
Great, that's a big one step forward.
Based on this
Am 08.12.2012 15:10, schrieb Matthew Gyurgyik:
On 12/08/2012 08:52 AM, Frank Schäfer wrote:
I lied, it works! I must have forgotten to do run make modules_install
or something! This patch accurately states my current code changes:
http://pyther.net/a/digivox_atsc/diff-Dec-06-v1.patch
Great,
get_next_buf() and vbi_get_next_buf() do exactly the same just with a
different dma queue and buffer. Saving the new buffer pointer back to the
device struct in em28xx_urb_data_copy() instead of doing this from inside
these functions makes it possible to get rid of one of them.
Also refactor the
Signed-off-by: Frank Schäfer fschaefer@googlemail.com
---
drivers/media/usb/em28xx/em28xx.h |1 -
1 Datei geändert, 1 Zeile entfernt(-)
diff --git a/drivers/media/usb/em28xx/em28xx.h
b/drivers/media/usb/em28xx/em28xx.h
index 304896d..b3d72a9 100644
---
This patch series refactors the frame data processing code in em28xx-video.c to
- reduce code duplication
- fix a bug in vbi data processing
- prepare for adding em25xx/em276x frame data processing support
- clean up the code and make it easier to understand
It applies on top of my previous patch
When a new frame header is detected in em28xx_urb_data_copy() and the data
packet contains both, VBI data and video data, the prevoius VBI buffer doesn't
get finished and is overwritten with the new VBI data.
This bug is not triggered with isochronous USB transfers, because the data
packetes are
In the current code em28xx_urb_data_copy() caches the pointer to the vmalloc
memory in videobuf locally.
The alternative would be to call videobuf_to_vmalloc() for each processed USB
data packet (isoc USB transfers = 64 times per URB) in the em28xx_copy_*()
functions.
With the next commits, the
Signed-off-by: Frank Schäfer fschaefer@googlemail.com
---
drivers/media/usb/em28xx/em28xx-video.c | 33 +--
1 Datei geändert, 5 Zeilen hinzugefügt(+), 28 Zeilen entfernt(-)
diff --git a/drivers/media/usb/em28xx/em28xx-video.c
Reduce code duplication by moving the duplicate code for dev-capture_type=0
(vbi start) and dev-capture_type=2 (video start) to a function.
The same function will also be called by the (not yet existing) em25xx frame
data processing code.
Signed-off-by: Frank Schäfer fschaefer@googlemail.com
em28xx_urb_data_copy() actually consists of two parts:
USB urb processing (checks, data extraction) and frame data packet processing.
Move the latter to a separate function and call it from em28xx_urb_data_copy()
for each data packet.
The em25xx, em2760, em2765 (and likely em277x) chip variants
The code in em28xx_vbi_copy can be simplified a lot.
Also rename some variables to something more meaningful and fix+add the
function descriptions.
Signed-off-by: Frank Schäfer fschaefer@googlemail.com
---
drivers/media/usb/em28xx/em28xx-video.c | 65 ++-
1
This field is used to keep track of the current memory position in the buffer,
not in the dma queue, so move it to right place.
This also allows us to get rid of the struct em28xx_dmaqueue pointer parameter
in functions em28xx_copy_video() and em28xx_copy_vbi().
Signed-off-by: Frank Schäfer
On 12/08/2012 10:20 AM, Frank Schäfer wrote:
Am 08.12.2012 15:10, schrieb Matthew Gyurgyik:
Ok, thanks. So the USB log was right and the bridge setup should be
complete, except that the remote control doesn't work yet...
Could you please test the patch in the attachment ?
Changes from V3:
-
Am 08.12.2012 17:51, schrieb Matthew Gyurgyik:
On 12/08/2012 10:20 AM, Frank Schäfer wrote:
Am 08.12.2012 15:10, schrieb Matthew Gyurgyik:
Ok, thanks. So the USB log was right and the bridge setup should be
complete, except that the remote control doesn't work yet...
Could you please test
Is there an interested developer who wants my DVB-T Card for developing?
regards Markus
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date:Sat Dec 8 19:00:21 CET 2012
git hash:16427faf28674451a7a0485ab0a929402f355ffd
gcc version: i686-linux-gcc
On 12/08/2012 12:49 PM, Frank Schäfer wrote:
Am 08.12.2012 17:51, schrieb Matthew Gyurgyik:
That shouldn't be necessary. I just noticed that there is a module
parameter 'ir_debug'. ;)
With ir_debug enabled, you should see messages
em28xx_ir_handle_key: toggle: XX, count: XX, key
On 12/08/2012 11:40 PM, Matthew Gyurgyik wrote:
On 12/08/2012 12:49 PM, Frank Schäfer wrote:
Am 08.12.2012 17:51, schrieb Matthew Gyurgyik:
That shouldn't be necessary. I just noticed that there is a module
parameter 'ir_debug'. ;)
With ir_debug enabled, you should see messages
On 12/08/2012 04:47 PM, Antti Palosaari wrote:
On 12/08/2012 11:40 PM, Matthew Gyurgyik wrote:
On 12/08/2012 12:49 PM, Frank Schäfer wrote:
Am 08.12.2012 17:51, schrieb Matthew Gyurgyik:
That shouldn't be necessary. I just noticed that there is a module
parameter 'ir_debug'. ;)
With ir_debug
This patch provide only analog support.
The device is based on AF9013 demodulator, XC3028 tuner
and CX23885 chipset; subsystem id: 1461:d939
Signed-off-by: Oleh Kravchenko o...@kaa.org.ua
---
drivers/media/pci/cx23885/cx23885-cards.c | 75 +
22 matches
Mail list logo
