Re: sparse: ARRAY_SIZE and sparse array initialization

2014-03-30 Thread Christopher Li
On Fri, Mar 28, 2014 at 3:50 AM, Hans Verkuil hverk...@xs4all.nl wrote: Is there any chance that the three issues I reported will be fixed? If not, then I'll work around it in the kernel code. Most likely it is a sparse issue. Can you generate a minimal stand alone test case that expose this

All that glitters on your wrist

2014-03-30 Thread Linux fsdevel
Designer branded watches available at clearance prices http://bhp-trade.home.pl/bwjobii.php -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: sparse: ARRAY_SIZE and sparse array initialization

2014-03-30 Thread Hans Verkuil
Hi Chris, On 03/30/2014 08:10 AM, Christopher Li wrote: On Fri, Mar 28, 2014 at 3:50 AM, Hans Verkuil hverk...@xs4all.nl wrote: Is there any chance that the three issues I reported will be fixed? If not, then I'll work around it in the kernel code. Most likely it is a sparse issue. Can you

[PATCH 1/8] libdvbv5: cleanup printing tables and descriptors

2014-03-30 Thread André Roth
- log hex values where appropriate - cleanup indents Signed-off-by: André Roth neol...@gmail.com --- lib/libdvbv5/descriptors.c | 6 +-- lib/libdvbv5/descriptors/cat.c | 2 +- .../descriptors/desc_atsc_service_location.c | 1 -

[PATCH 8/8] libdvbv5: add support for tables with multiple ts_id and section gaps

2014-03-30 Thread André Roth
this restores the logic for reading tables like EIT, where the ts_id indicates the service and the sections are incremented by 8 for example. an application might wish to read a complete EIT containing all services. in this case the function dvb_read_sections can be used with allow_section_gaps

[PATCH 7/8] libdvbv5: fix lost ressource in atsc_eit

2014-03-30 Thread André Roth
if the title of the EIT event is longer than the available data, make sure the allocated buffer is not lost Signed-off-by: André Roth neol...@gmail.com --- lib/libdvbv5/descriptors/atsc_eit.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 5/8] libdvbv5: descriptor parser return int

2014-03-30 Thread André Roth
If parsing a descriptor fails, let the outside world know. Returning 0 means success, negative values indicate a parsing error. Free allocated memory on error. Signed-off-by: André Roth neol...@gmail.com --- lib/include/libdvbv5/desc_atsc_service_location.h | 2 +-

[PATCH 6/8] libdvbv5: remove unneeded includes

2014-03-30 Thread André Roth
Signed-off-by: André Roth neol...@gmail.com --- lib/libdvbv5/descriptors/desc_atsc_service_location.c | 1 - lib/libdvbv5/descriptors/desc_ca.c| 1 - lib/libdvbv5/descriptors/desc_ca_identifier.c | 1 - lib/libdvbv5/descriptors/desc_cable_delivery.c| 1 -

[PATCH 3/8] libdvbv5: make dvb_desc_default_init and dvb_desc_default_print private

2014-03-30 Thread André Roth
dvb_desc_default_init and dvb_desc_default_print are used internaly only, remove them from the header file. add extern C to the parser functions, so they can be used from C++ directly. Signed-off-by: André Roth neol...@gmail.com --- lib/include/libdvbv5/descriptors.h | 16

[PATCH 2/8] libdvbv5: use DVB_DESC_HEADER macro in all descriptors

2014-03-30 Thread André Roth
the first fields of a descriptor need to be the type, length and the next pointer. in order to prevent changing these fields by accident, provide them in a macro. Signed-off-by: André Roth neol...@gmail.com --- lib/include/libdvbv5/desc_atsc_service_location.h | 7 ++-

[PATCH 4/8] libdvbv5: allow table parsers to get specific pointer to table struct

2014-03-30 Thread André Roth
this will allow simplifying the parser functions and to return the number of bytes read or an error code. Signed-off-by: André Roth neol...@gmail.com --- lib/include/libdvbv5/atsc_eit.h | 2 +- lib/include/libdvbv5/cat.h | 2 +- lib/include/libdvbv5/descriptors.h | 2 +-

No channels on Hauppauge 950Q

2014-03-30 Thread Sunset Machine
Today is March 30, 2014 The 950Q is a USB TV Stick. The driver loads, the firmware loads. Various software sees the device but none of them find any channels. I use an antenna for over-the-air HD television in the US. The device works on Windows but not Linux (Debian 7.3, Squeeze). I'm not a

Re: sparse: ARRAY_SIZE and sparse array initialization

2014-03-30 Thread Linus Torvalds
On Sun, Mar 30, 2014 at 5:03 AM, Hans Verkuil hverk...@xs4all.nl wrote: which is clearly a sparse bug somewhere. Yes. What is going on is that we create separate symbols for each declaration, and we tie them all together (and warn if they have conflicting types). But then when we look up a

Re: No channels on Hauppauge 950Q

2014-03-30 Thread Devin Heitmueller
On Sun, Mar 30, 2014 at 12:25 PM, Sunset Machine sunsetmachi...@gmail.com wrote: Today is March 30, 2014 The 950Q is a USB TV Stick. The driver loads, the firmware loads. Various software sees the device but none of them find any channels. I use an antenna for over-the-air HD television in

Re: sparse: ARRAY_SIZE and sparse array initialization

2014-03-30 Thread Hans Verkuil
On 03/30/2014 06:48 PM, Linus Torvalds wrote: On Sun, Mar 30, 2014 at 5:03 AM, Hans Verkuil hverk...@xs4all.nl wrote: which is clearly a sparse bug somewhere. Yes. What is going on is that we create separate symbols for each declaration, and we tie them all together (and warn if they have

Re: sparse: ARRAY_SIZE and sparse array initialization

2014-03-30 Thread Christopher Li
On Sun, Mar 30, 2014 at 9:48 AM, Linus Torvalds torva...@linux-foundation.org wrote: But then when we look up a symbol, we only look at the latest one, so when we size the array, we look at that extern declaration, and don't see the size that was created with the initializer. Exactly. Sparse

Re: sparse: ARRAY_SIZE and sparse array initialization

2014-03-30 Thread Linus Torvalds
On Sun, Mar 30, 2014 at 9:48 AM, Linus Torvalds torva...@linux-foundation.org wrote: I'll think about how to fix it cleanly. Expect a patch shortly. Ok, patch sent to linux-sparse mailing list. It fixes the particular cut-down test-case and seems pretty simple and straightforward, but is

em28xx_dvb.c errors

2014-03-30 Thread Chris Lee
I saw a previous email showing the error's but no patch, maybe there was one but I didnt see it on my end. It looks like a previous patch was applied wrong? not sure. Chris em28xx_dvb.c.patch Description: Binary data

Re: lmedm04 NEC scancode question

2014-03-30 Thread Malcolm Priestley
On 28/03/14 00:38, David Härdeman wrote: Hi Malcolm, Hi David I'm trying to make sure that the extended NEC parsing is consistent across drivers and I have a question regarding drivers/media/usb/dvb-usb-v2/lmedm04.c In commit 616a4b83 you changed the scancode from something like this:

Re: No channels on Hauppauge 950Q

2014-03-30 Thread Sunset Machine
On 3/30/14, Devin Heitmueller dheitmuel...@kernellabs.com wrote: On Sun, Mar 30, 2014 at 12:25 PM, Sunset Machine sunsetmachi...@gmail.com wrote: Today is March 30, 2014 The 950Q is a USB TV Stick. The driver loads, the firmware loads. Various software sees the device but none of them find

Re: No channels on Hauppauge 950Q

2014-03-30 Thread Devin Heitmueller
On Sun, Mar 30, 2014 at 3:16 PM, Sunset Machine sunsetmachi...@gmail.com wrote: kernel 3.2.0-4-686-pae and a new 950q Ok. If you own a Revision E1H3 device, then that kernel definitely won't work (the Rev is printed on the back of the stick above the barcode). 3.13-1-686-pae is available in

Re: em28xx_dvb.c errors

2014-03-30 Thread Hans Verkuil
On 03/30/2014 07:42 PM, Chris Lee wrote: I saw a previous email showing the error's but no patch, maybe there was one but I didnt see it on my end. The patch is here: https://patchwork.linuxtv.org/patch/23278/ It looks like a previous patch was applied wrong? not sure. Yeah, it was.

Re: lmedm04 NEC scancode question

2014-03-30 Thread David Härdeman
On Sun, Mar 30, 2014 at 07:18:20PM +0100, Malcolm Priestley wrote: On 28/03/14 00:38, David Härdeman wrote: I'm trying to make sure that the extended NEC parsing is consistent across drivers and I have a question regarding drivers/media/usb/dvb-usb-v2/lmedm04.c In commit 616a4b83 you changed the

Re: [PATCH 5/5] rcar_vin: add devicetree support

2014-03-30 Thread Guennadi Liakhovetski
Hi Ben, Since I never received a reply to this my query, I consider this your patch series suspended. Thanks Guennadi On Sat, 8 Mar 2014, Guennadi Liakhovetski wrote: Hi Ben, On Fri, 7 Mar 2014, Ben Dooks wrote: Add support for devicetree probe for the rcar-vin driver. Thanks for

Re: [PATCH 5/5] rcar_vin: add devicetree support

2014-03-30 Thread Ben Dooks
On 30/03/14 22:04, Guennadi Liakhovetski wrote: Hi Ben, Since I never received a reply to this my query, I consider this your patch series suspended. Thanks Guennadi I meant to send out a patch series for the of probe for soc_camera. The actual rcar_vin does not need much to support async

Re: [PATCH 5/5] rcar_vin: add devicetree support

2014-03-30 Thread Guennadi Liakhovetski
On Sun, 30 Mar 2014, Ben Dooks wrote: On 30/03/14 22:04, Guennadi Liakhovetski wrote: Hi Ben, Since I never received a reply to this my query, I consider this your patch series suspended. Thanks Guennadi I meant to send out a patch series for the of probe for soc_camera. The

Re: [PATCH v2 3/3] [media] atmel-isi: add primary DT support

2014-03-30 Thread Guennadi Liakhovetski
Hi Josh, Please correct me if I'm wrong, but I don't see how this is going to work without the central part - building asynchronous V4L2 data structures from the DT, something that your earlier patch media: soc-camera: OF cameras was doing, but which you stopped developing after a discussion

[RFC 1/3] rcar_vin: copy flags from pdata

2014-03-30 Thread Ben Dooks
The platform data is a single word, so simply copy it into the device's private data structure than keeping a copy of the pointer. This will make changing to device-tree binding easier as it is one allocation instead of two. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk ---

[RFC 3/3] soc_camera: initial of code

2014-03-30 Thread Ben Dooks
Add initial support for OF based soc-camera devices that may be used by any of the soc-camera drivers. The driver itself will need converting to use OF. These changes allow the soc-camera driver to do the connecting of any async capable v4l2 device to the soc-camera driver. This has currently

[RFC 2/3] rcar_vin: add devicetree support

2014-03-30 Thread Ben Dooks
Add support for devicetree probe for the rcar-vin driver. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- .../devicetree/bindings/media/rcar_vin.txt | 79 ++ drivers/media/platform/soc_camera/rcar_vin.c | 67 -- 2 files changed, 140

Re: [PATCH 5/5] rcar_vin: add devicetree support

2014-03-30 Thread Ben Dooks
On 30/03/14 22:17, Guennadi Liakhovetski wrote: On Sun, 30 Mar 2014, Ben Dooks wrote: On 30/03/14 22:04, Guennadi Liakhovetski wrote: Hi Ben, Since I never received a reply to this my query, I consider this your patch series suspended. Thanks Guennadi I meant to send out a patch series

Re: [RFC 2/3] rcar_vin: add devicetree support

2014-03-30 Thread Ben Dooks
On 30/03/14 22:26, Ben Dooks wrote: Add support for devicetree probe for the rcar-vin driver. Sorry, this was an older branch and needed a fix for the pdev-id field. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink -

[RFCv2] rcar_vin: copy flags from pdata

2014-03-30 Thread Ben Dooks
The platform data is a single word, so simply copy it into the device's private data structure than keeping a copy of the pointer. This will make changing to device-tree binding easier as it is one allocation instead of two. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk ---

[RFCv3 1/3] rcar_vin: copy flags from pdata

2014-03-30 Thread Ben Dooks
The platform data is a single word, so simply copy it into the device's private data structure than keeping a copy of the pointer. This will make changing to device-tree binding easier as it is one allocation instead of two. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk ---

[RFCv3 3/3] soc_camera: initial of code

2014-03-30 Thread Ben Dooks
Add initial support for OF based soc-camera devices that may be used by any of the soc-camera drivers. The driver itself will need converting to use OF. These changes allow the soc-camera driver to do the connecting of any async capable v4l2 device to the soc-camera driver. This has currently

[RFCv3 2/3] rcar_vin: add devicetree support

2014-03-30 Thread Ben Dooks
Add support for devicetree probe for the rcar-vin driver. Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- Changes since v1: - fix pdev-id handling via usage of alias property Changes since v2: - fix documentation for v1 updates ---

Re: No channels on Hauppauge 950Q

2014-03-30 Thread Sunset Machine
On 3/30/14, Devin Heitmueller dheitmuel...@kernellabs.com wrote: On Sun, Mar 30, 2014 at 3:16 PM, Sunset Machine sunsetmachi...@gmail.com wrote: kernel 3.2.0-4-686-pae and a new 950q Ok. If you own a Revision E1H3 device, then that kernel definitely won't work (the Rev is printed on the

cron job: media_tree daily build: ERRORS

2014-03-30 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Mon Mar 31 04:00:13 CEST 2014 git branch: test git hash: 3ec40dcfb413214b2874aec858870502b61c2202 gcc