cx23885: DVBSky S952 dvb_register failed err = -22

2015-03-14 Thread Ole Ernst
Hi, using linux-3.19.1-1 (Archlinux) I get the following output while booting without the media-build-tree provided by DVBSky: cx23885 driver version 0.0.4 loaded cx23885 :04:00.0: enabling device ( - 0002) CORE cx23885[0]: subsystem: 4254:0952, board: DVBSky S952 [card=50,autodetected]

Re: [PATCH] v4l2-ioctl: allow all controls if ctrl_class == 0

2015-03-14 Thread Sakari Ailus
On Sat, Mar 14, 2015 at 05:28:25PM +0100, Hans Verkuil wrote: The check_ext_ctrls() function in v4l2-ioctl.c checks if all controls in the control array are from the same control class as c-ctrl_class. However, that check should only be done if c-ctrl_class != 0. A 0 value means that this

Re: [PATCH v3 2/2] v4l: mt9v032: Add OF support

2015-03-14 Thread Sakari Ailus
Hi Laurent, On Sat, Mar 14, 2015 at 04:57:37PM +0200, Laurent Pinchart wrote: ... diff --git a/Documentation/devicetree/bindings/media/i2c/mt9v032.txt b/Documentation/devicetree/bindings/media/i2c/mt9v032.txt new file mode 100644 index 000..68b134e --- /dev/null +++

cron job: media_tree daily build: WARNINGS

2015-03-14 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sun Mar 15 04:00:17 CET 2015 git branch: test git hash: 3d945be05ac1e806af075e9315bc1b3409adae2b gcc

Re: [PATCH] media: au0828 - add vidq busy checks to s_std and s_input

2015-03-14 Thread Hans Verkuil
On 03/14/2015 03:18 AM, Shuah Khan wrote: au0828 s_std and s_input are missing queue busy checks. Add vb2_is_busy() calls to s_std and s_input and return -EBUSY if found busy. I agree with Devin that for this particular driver this patch isn't necessary. Regards, Hans

Re: [PATCHv2 00/21] marvell-ccic: drop and fix formats

2015-03-14 Thread Hans Verkuil
On 03/13/2015 10:59 PM, Hans Verkuil wrote: Hi Jon, On 03/13/2015 10:28 PM, Jonathan Corbet wrote: On Wed, 11 Mar 2015 09:10:24 +0100 Hans Verkuil hverk...@xs4all.nl wrote: After some more testing I realized that the 422P format produced wrong colors and I couldn't get it to work. Since

Re: [PATCHv2 00/21] marvell-ccic: drop and fix formats

2015-03-14 Thread Hans Verkuil
On 03/14/2015 10:15 AM, Hans Verkuil wrote: On 03/13/2015 10:59 PM, Hans Verkuil wrote: Hi Jon, On 03/13/2015 10:28 PM, Jonathan Corbet wrote: On Wed, 11 Mar 2015 09:10:24 +0100 Hans Verkuil hverk...@xs4all.nl wrote: After some more testing I realized that the 422P format produced wrong

Re: [RFC 15/18] omap3isp: Add support for the Device Tree

2015-03-14 Thread Sakari Ailus
Hi Laurent, On Thu, Mar 12, 2015 at 01:48:02AM +0200, Laurent Pinchart wrote: Hi Sakari, Thank you for the patch. On Saturday 07 March 2015 23:41:12 Sakari Ailus wrote: Add the ISP device to omap3 DT include file and add support to the driver to use it. Also obtain information on

[PATCH] vivid: allow s_dv_timings if it is the same as the current

2015-03-14 Thread Hans Verkuil
Allow setting the same timings as the current timings (i.e., do nothing in that case). The code was actually there, but the vb2_is_busy() call was done before the timings check instead of afterwards. Found by v4l2-compliance. Signed-off-by: Hans Verkuil hans.verk...@cisco.com diff --git

[PATCHv3 19/22] marvell-ccic: drop support for PIX_FMT_422P

2015-03-14 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com I cannot get this format to work, the colors keep coming out wrong. Since this has never worked I just drop support for this. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Jonathan Corbet cor...@lwn.net ---

[PATCHv3 18/22] marvell-ccic: fix Y'CbCr ordering

2015-03-14 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Various formats had their byte ordering implemented incorrectly, and the V4L2_PIX_FMT_UYVY is actually impossible to create, instead you get V4L2_PIX_FMT_YVYU. This was working before commit ad6ac452227b7cb93ac79beec092850d178740b1 (add new formats

[PATCHv3 20/22] videodev2.h: add V4L2_PIX_FMT_XBGR444

2015-03-14 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com This is similar to XRGB444 but with the red and blue components swapped. It turns out that the RGB444 format in marvell-ccic driver really was this variant, so we need a proper definition of that. Signed-off-by: Hans Verkuil hans.verk...@cisco.com ---

[PATCHv3 00/22] marvell-ccic: drop and fix formats

2015-03-14 Thread Hans Verkuil
This v3 patch series replaces patch 18 from the first series. Patch 18 and 19 are unchanged from patches 18 and 21 from the second series. Patches 20-21 replace the RGB444 format by the newly defined XBGR444 format (X means that the 'alpha' channel should be ignored and is not filled in). The

[PATCHv3 21/22] marvell-ccic: replace RGB444 by XBGR444

2015-03-14 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com The RGB444 pixel format as implemented in this driver really implements the variant where R and B are swapped, XBGR444. So replace RGB444 by XBGR444. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/platform/marvell-ccic/mcam-core.c

[PATCHv3 22/22] Fix V4L2_PIX_FMT_SBGGR8 support

2015-03-14 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com The REG_CTRL0 register was never written if this format was selected, instead an error was logged and whatever was last set in that register was used. Surprisingly, that seems to work if YUYV was selected, but we should program this register explicitly.

[PATCH 40/40] vivid: add support for 8-bit Bayer formats

2015-03-14 Thread Hans Verkuil
Add support for: PIX_FMT_SBGGR8, SGBRG8, SGRBG8 and SRGGB8. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/platform/vivid/vivid-tpg.c| 57 +++-- drivers/media/platform/vivid/vivid-tpg.h| 17 +---

Re: rt-mutex usage in i2c

2015-03-14 Thread Wolfram Sang
Hi Sebastian, - i2c_transfer() has this piece: 2091 if (in_atomic() || irqs_disabled()) { 2092 ret = i2c_trylock_adapter(adap); is this irqs_disabled() is what bothers me and should not be there. pxa does a spin_lock_irq() which would enable

Re: rt-mutex usage in i2c

2015-03-14 Thread Wolfram Sang
On Sat, Mar 14, 2015 at 12:27:03PM +0100, Wolfram Sang wrote: Hi Sebastian, - i2c_transfer() has this piece: 2091 if (in_atomic() || irqs_disabled()) { 2092 ret = i2c_trylock_adapter(adap); is this irqs_disabled() is what bothers me and

Re: [RFC 14/18] dt: bindings: Add bindings for omap3isp

2015-03-14 Thread Sakari Ailus
Hi Sebastian, Thanks for the comments! On Fri, Mar 13, 2015 at 10:34:53AM +0100, Sebastian Reichel wrote: Hi, On Fri, Mar 13, 2015 at 01:03:21AM +0200, Sakari Ailus wrote: [...] +Required properties +=== + +compatible : ti,omap3-isp I would

Re: [RFC 16/18] arm: dts: omap3: Add DT entries for OMAP 3

2015-03-14 Thread Sakari Ailus
On Sun, Mar 08, 2015 at 01:51:51AM +0200, Laurent Pinchart wrote: Hi Sakari, Thank you for the patch. On Saturday 07 March 2015 23:41:13 Sakari Ailus wrote: The resources the ISP needs are slightly different on 3[45]xx and 3[67]xx. Especially the phy-type property is different.

Re: [PATCH] media: omap3isp: video: Use v4l2_get_timestamp()

2015-03-14 Thread Sakari Ailus
Thanks! On Fri, Mar 13, 2015 at 02:31:27AM +0200, Laurent Pinchart wrote: Replace the open-coded copy by a function call. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Sakari Ailus sakari.ai...@iki.fi -- Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP:

Re: [PATCH] media: omap3isp: video: Don't call vb2 mmap with queue lock held

2015-03-14 Thread Sakari Ailus
On Fri, Mar 13, 2015 at 02:33:35AM +0200, Laurent Pinchart wrote: videobuf2 has long been subject to AB-BA style deadlocks due to the queue lock and mmap_sem being taken in different orders for the mmap operation. The problem has been fixed by making this operation callable without taking the

[PATCH v3 2/2] v4l: mt9v032: Add OF support

2015-03-14 Thread Laurent Pinchart
Parse DT properties into a platform data structure when a DT node is available. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- Changes since v2: - Use of_graph_get_next_endpoint() Changes since v1: - Add MT9V02[24] compatible strings - Prefix all compatible strings

[PATCH v3 1/2] of: Add vendor prefix for Aptina Imaging

2015-03-14 Thread Laurent Pinchart
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) Aptina has recently been acquired by ON Semiconductor, but the name Aptina is still widely used. Should the onnn prefix be used

[GIT PULL FOR v4.1] OMAP3 ISP fixes

2015-03-14 Thread Laurent Pinchart
Hi Mauro, The following changes since commit 3d945be05ac1e806af075e9315bc1b3409adae2b: [media] mn88473: simplify bandwidth registers setting code (2015-03-03 13:09:12 -0300) are available in the git repository at: git://linuxtv.org/pinchartl/media.git omap3isp/next for you to fetch

[GIT PULL 4.0] rtl28xx fixes for 4.0

2015-03-14 Thread Antti Palosaari
The following changes since commit 41f03a00536ebb3d72c051f9e7efe2d4ab76ebc8: [media] s5p-mfc: Fix NULL pointer dereference caused by not set q-lock (2015-03-04 08:59:58 -0300) are available in the git repository at: git://linuxtv.org/anttip/media_tree.git rtl28xx_fixes for you to fetch

[PATCH] uvcvideo: add support for VIDIOC_QUERY_EXT_CTRL

2015-03-14 Thread Hans Verkuil
Add support for the new VIDIOC_QUERY_EXT_CTRL ioctl. Since uvc doesn't use the control framework, support for this ioctl isn't automatic. This is makes v4l2-compliance happy as well. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/usb/uvc/uvc_v4l2.c | 28

Re: [RFC 10/18] omap3isp: Move the syscon register out of the ISP register maps

2015-03-14 Thread Sakari Ailus
Hi Tony, Thanks for the comments!! On Mon, Mar 09, 2015 at 08:20:38AM -0700, Tony Lindgren wrote: * Sakari Ailus sakari.ai...@iki.fi [150307 15:44]: Hi Laurent, On Sun, Mar 08, 2015 at 01:34:17AM +0200, Laurent Pinchart wrote: Hi Sakari, Thank you for the patch. (CC'ing

[PATCH] v4l2-ioctl: allow all controls if ctrl_class == 0

2015-03-14 Thread Hans Verkuil
The check_ext_ctrls() function in v4l2-ioctl.c checks if all controls in the control array are from the same control class as c-ctrl_class. However, that check should only be done if c-ctrl_class != 0. A 0 value means that this restriction does not apply. So return 1 (OK) if c-ctrl_class == 0.

[PATCH 2/2] rtl28xxu: return success for unimplemented FE callback

2015-03-14 Thread Antti Palosaari
Return success for FE callback on case we don't have any special implementation. fc0013 tuner driver calls that callback in order to switch antenna input, even we don't provide antenna switch. Returning error caused fc0013 driver given up tuning. Signed-off-by: Antti Palosaari cr...@iki.fi ---

[PATCH 1/2] rtl2832: disable regmap register cache

2015-03-14 Thread Antti Palosaari
Caching register reads causes some random I/O errors on channel change. Disable caching now in order to avoid those errors. Reverts partly commit dcadb82 Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/dvb-frontends/rtl2832.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)