On 05/22/2018 12:31 AM, Dongwon Kim wrote:
Still need more time to review the whole code changes
Take your time, I just wanted to make sure that all interested parties
are in the discussion, so we all finally have what we all want, not
a thing covering only my use-cases
but I noticed one thin
On 05/21/2018 11:36 PM, Boris Ostrovsky wrote:
On 05/21/2018 03:13 PM, Oleksandr Andrushchenko wrote:
On 05/21/2018 09:53 PM, Boris Ostrovsky wrote:
On 05/21/2018 01:32 PM, Oleksandr Andrushchenko wrote:
On 05/21/2018 07:35 PM, Boris Ostrovsky wrote:
On 05/21/2018 01:40 AM, Oleksandr Andrushc
From: Bingbu Cao
Add a V4L2 sub-device driver for the Sony IMX319 image sensor.
This is a camera sensor using the I2C bus for control and the
CSI-2 bus for data.
Signed-off-by: Bingbu Cao
Signed-off-by: Tianshu Qiu
---
MAINTAINERS|7 +
drivers/media/i2c/Kconfig | 11 +
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Tue May 22 05:00:12 CEST 2018
media-tree git hash:7e6b6b945272c20f6b78d319e07f27897a8373c9
media_build gi
Hello
Greetings to you please i have a business proposal for you contact me
for more detailes asap thanks.
Best Regards,
Miss.Zeliha ömer faruk
Esentepe Mahallesi Büyükdere
Caddesi Kristal Kule Binasi
No:215
Sisli - Istanbul, Turkey
Hi Krzysztof, I've been on vacation, just returned today. I will
find the time this week to attempt to reproduce your results on
a SabreAuto quad with the adv7180.
Btw, if you just need to capture an interlaced frame (lines 0,1,2,...)
without motion compensation, there is no need to use the VDIC
Still need more time to review the whole code changes but I noticed one thing.
We've been using the term "hyper_dmabuf" for hypervisor-agnostic linux dmabuf
solution and we are planning to call any of our future solution for other
hypervisors the same name. So having same name for this xen-specifi
Hi Bingbu,
I love your patch! Perhaps something to improve:
[auto build test WARNING on next-20180517]
[also build test WARNING on v4.17-rc6]
[cannot apply to linuxtv-media/master linus/master v4.17-rc6 v4.17-rc5
v4.17-rc4]
[if your patch is applied to the wrong git tree, please drop us a note t
From: kbuild test robot
drivers/media/i2c/imx319.c:1874:2-3: Unneeded semicolon
drivers/media/i2c/imx319.c:1917:2-3: Unneeded semicolon
Remove unneeded semicolon.
Generated by: scripts/coccinelle/misc/semicolon.cocci
Fixes: 6ee66fafab37 ("media: imx319: Add imx319 camera sensor driver")
CC:
>> diff -u -p drivers/media/dvb-frontends/au8522_decoder.c
>> /tmp/nothing/media/dvb-frontends/au8522_decoder.c
>> --- drivers/media/dvb-frontends/au8522_decoder.c
>> +++ /tmp/nothing/media/dvb-frontends/au8522_decoder.c
>> @@ -280,14 +280,9 @@ static void setup_decoder_defaults(struc
>>
On 05/21/2018 03:13 PM, Oleksandr Andrushchenko wrote:
> On 05/21/2018 09:53 PM, Boris Ostrovsky wrote:
>> On 05/21/2018 01:32 PM, Oleksandr Andrushchenko wrote:
>>> On 05/21/2018 07:35 PM, Boris Ostrovsky wrote:
On 05/21/2018 01:40 AM, Oleksandr Andrushchenko wrote:
> On 05/19/2018 01:04
+Cc: Mauro
On Mon, May 21, 2018 at 3:01 PM, Light wrote:
> Hi,
>
> staring with kernel 4.1 the tevii S650 usb box is not working any more, last
> working version was 4.0.
>
> The bug was also reported here
> https://www.spinics.net/lists/linux-media/msg121356.html
>
> I found a solution for it a
Em Mon, 21 May 2018 14:39:51 -0500
"Gustavo A. R. Silva" escreveu:
> Hi Mauro,
>
> I found some duplicate code with the help of Coccinelle and Coverity. Notice
> that these are not code patches, they only point out the duplicate code in
> some media drivers:
>
> diff -u -p drivers/media/pci/b
Hi Mauro,
I found some duplicate code with the help of Coccinelle and Coverity. Notice
that these are not code patches, they only point out the duplicate code in some
media drivers:
diff -u -p drivers/media/pci/bt8xx/dvb-bt8xx.c
/tmp/nothing/media/pci/bt8xx/dvb-bt8xx.c
--- drivers/media/pci/bt
On 05/21/2018 09:53 PM, Boris Ostrovsky wrote:
On 05/21/2018 01:32 PM, Oleksandr Andrushchenko wrote:
On 05/21/2018 07:35 PM, Boris Ostrovsky wrote:
On 05/21/2018 01:40 AM, Oleksandr Andrushchenko wrote:
On 05/19/2018 01:04 AM, Boris Ostrovsky wrote:
On 05/17/2018 04:26 AM, Oleksandr Andrushc
On 05/21/2018 01:32 PM, Oleksandr Andrushchenko wrote:
> On 05/21/2018 07:35 PM, Boris Ostrovsky wrote:
>> On 05/21/2018 01:40 AM, Oleksandr Andrushchenko wrote:
>>> On 05/19/2018 01:04 AM, Boris Ostrovsky wrote:
On 05/17/2018 04:26 AM, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andr
band->index can be controlled by user-space, hence leading to
a potential exploitation of the Spectre variant 1 vulnerability.
This issue was detected with the help of Smatch:
drivers/media/radio/si470x/radio-si470x-common.c:758
si470x_vidioc_enum_freq_bands() warn: potential spectre issue 'bands
On 05/21/2018 07:35 PM, Boris Ostrovsky wrote:
On 05/21/2018 01:40 AM, Oleksandr Andrushchenko wrote:
On 05/19/2018 01:04 AM, Boris Ostrovsky wrote:
On 05/17/2018 04:26 AM, Oleksandr Andrushchenko wrote:
From: Oleksandr Andrushchenko
A commit message would be useful.
Sure, v1 will have it
Describe the optional properties for endpoint nodes of port@0
and port@1 of the R-Car VIN driver device tree bindings documentation.
Signed-off-by: Jacopo Mondi
Acked-by: Niklas Söderlund
---
Documentation/devicetree/bindings/media/rcar_vin.txt | 13 -
1 file changed, 12 insertions(
Document 'data-active' property in R-Car VIN device tree bindings.
Signed-off-by: Jacopo Mondi
v1 -> v2:
- HSYNC is used in place of data enable signal only when running with
explicit synchronizations.
- The property is no more mandatory when running with embedded
synchronizations, and defau
The 'bus-width' and 'pclk-sample' properties are not parsed by the VIN
driver and only confuse users. Remove them in all Gen2 SoC that use
them.
Signed-off-by: Jacopo Mondi
---
arch/arm/boot/dts/r8a7790-lager.dts | 3 ---
arch/arm/boot/dts/r8a7791-koelsch.dts | 3 ---
arch/arm/boot/dts/r8a7791
Handle CLOCKENB pin polarity, or use HSYNC in its place if polarity is
not specified and we're running on parallel data bus with explicit
synchronism signals.
While at there, simplify the media bus handling flags logic, inspecting
flags only if the system is running on parallel media bus type and
Hello,
this series touches the bindings and the driver handling endpoint
properties for digital subdevices of the R-Car VIN driver.
The first patch simply documents what are the endpoint properties supported
at the moment while the second extends them with 'data-active' one.
As the VIN hardwar
From: Gustavo Padovan
Instead of putting V4L2_CAP_STREAMING and V4L2_CAP_READWRITE
everywhere, set device_caps earlier with these values.
Signed-off-by: Gustavo Padovan
---
drivers/media/usb/hackrf/hackrf.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers
The in-fence implementation involves having a per-buffer fence callback,
that triggers on the fence signal. The fence callback is called asynchronously
and needs a valid reference to the associated ideobuf2 buffer.
Allow this by making the vb2_buffer refcounted, so it can be passed
to other contex
From: Gustavo Padovan
Instead of putting V4L2_CAP_STREAMING everywhere, set device_caps
earlier with this value.
v2: move cap->capabilities assignment down (Hans Verkuil)
Signed-off-by: Gustavo Padovan
---
drivers/media/platform/omap3isp/ispvideo.c | 10 ++
1 file changed, 6 insertion
From: Gustavo Padovan
vb2_ops_wait_prepare() and vb2_ops_wait_finish() were in the
wrong file.
Signed-off-by: Gustavo Padovan
---
drivers/media/common/videobuf2/videobuf2-core.c | 14 ++
drivers/media/common/videobuf2/videobuf2-v4l2.c | 14 --
include/media/videobuf2-co
From: Gustavo Padovan
Explicit synchronization benefits a lot from ordered queues, they fit
better in a pipeline with DRM for example so create a opt-in way for
drivers notify videobuf2 that the queue is unordered.
Drivers don't need implement it if the queue is ordered.
v5: rename it to vb2_op
From: Gustavo Padovan
For explicit synchronization it important for userspace to know if the
format being used by the driver can deliver the buffers back to userspace
in the same order they were queued with QBUF.
Ordered streams fits nicely in a pipeline with DRM for example, where
ordered buffe
From: Gustavo Padovan
Now that we've introduced the V4L2_FMT_FLAG_UNORDERED flag,
mark the appropriate formats.
v2: Set unordered flag before calling the driver callback.
Signed-off-by: Gustavo Padovan
Signed-off-by: Ezequiel Garcia
---
drivers/media/v4l2-core/v4l2-ioctl.c | 74 +
From: Gustavo Padovan
In preparation to have full support to explicit fence we are
marking codec as non-ordered preventively. It is easier and safer from an
uAPI point of view to move from unordered to ordered than the opposite.
v2: mark only codec drivers as unordered (Nicolas and Hans)
Signed
From: Gustavo Padovan
The cobalt driver may reorder the capture buffers so we need to report
it as such.
v3: set formats as unordered
v2: use vb2_ops_set_unordered() helper
Signed-off-by: Gustavo Padovan
Signed-off-by: Ezequiel Garcia
---
drivers/media/pci/cobalt/cobalt-v4l2.c | 4
1 fi
From: Gustavo Padovan
If V4L2_BUF_FLAG_OUT_FENCE flag is present on the QBUF call we create
an out_fence and send its fd to userspace in the fence_fd field as a
return arg for the QBUF call.
The fence is signaled on buffer_done(), when the job on the buffer is
finished.
v12: - Pass the fence_fd
From: Gustavo Padovan
Receive in-fence from userspace and add support for waiting on them
before queueing the buffer to the driver. Buffers can't be queued to the
driver before its fences signal. And a buffer can't be queued to the driver
out of the order they were queued from userspace. That mea
From: Gustavo Padovan
Turn the reserved2 field into fence_fd that we will use to send
an in-fence to the kernel or return an out-fence from the kernel to
userspace.
Two new flags were added, V4L2_BUF_FLAG_IN_FENCE, that should be used
when sending an in-fence to the kernel to be waited on, and
V
From: Gustavo Padovan
Drivers that use videobuf2 are capable of using fences and
should report that to userspace.
v10: - Add CAPS_FENCES to drivers that don't use fh->m2m_ctx.
- Keep the ifdef V4L2_MEM2MEM_DEV.
- Set CAPS_FENCES after vidioc_querycap.
v9: Add in the core.
Signed-off-b
From: Gustavo Padovan
Add section to VIDIOC_QBUF and VIDIOC_QUERY_BUF about it
v9: assorted improvements.
v8: amend querybuf documentation.
v7: minor issues and English improvements (Hans Verkuil)
v6: Close some gaps in the docs (Hans)
v5: - Remove V4L2_CAP_ORDERED
- Add doc about V4L2_F
From: Gustavo Padovan
Drivers capable of using fences (vb2 drivers) should report the
V4L2_CAP_FENCES to userspace, so add this flag to the uapi.
v2: minor doc/english fix (Hans Verkuil)
Signed-off-by: Gustavo Padovan
---
Documentation/media/uapi/v4l/vidioc-querycap.rst | 3 +++
include/uapi/
From: Gustavo Padovan
To better organize the code we concentrate the setting of
V4L2_CAP_STREAMING in one place.
v2: move cap->capabilities assignment down (Hans Verkuil)
Signed-off-by: Gustavo Padovan
---
drivers/media/platform/xilinx/xilinx-dma.c | 10 ++
1 file changed, 6 insertion
Hi all,
The most relevant change for this round is that all the work
done in the fence callback is now moved to a workqueue,
that runs with the queue lock held.
Although this introduces some latency, it is however needed
to take the vb2_queue mutex and safely call vb2 ops.
Given the fence callb
On 05/21/2018 01:40 AM, Oleksandr Andrushchenko wrote:
> On 05/19/2018 01:04 AM, Boris Ostrovsky wrote:
>> On 05/17/2018 04:26 AM, Oleksandr Andrushchenko wrote:
>>> From: Oleksandr Andrushchenko
>>
>> A commit message would be useful.
> Sure, v1 will have it
>>
>>> Signed-off-by: Oleksandr Andrus
On Mon, May 21, 2018 at 04:54:07PM +0100, Sean Young wrote:
> On Mon, May 21, 2018 at 04:38:01PM +0200, Michał Winiarski wrote:
> > It appears that we need to enable CIR device before attempting to touch
> > some of the registers. Previously, this was not a big issue, since we
> > were rarely seein
On 05/17/2018 01:08 PM, Gustavo A. R. Silva wrote:
BTW, Mauro, you sent a patch to fix an spectre v1 issue in this file
yesterday: dvb_ca_en50221.c:1480, but it seems there is another instance
of the same issue some lines above:
diff --git a/drivers/media/dvb-core/dvb_ca_en50221.c
b/drive
On Mon, May 21, 2018 at 1:09 AM, Krzysztof Hałasa wrote:
> Tested with NTSC camera, it's the same as with PAL.
> The only case when IPU2_CSI1_SENS_CONF register is set to interlaced
> mode (PRCTL=3, CCIR interlaced mode (BT.656)) is when all parts of the
> pipeline are set to interlaced:
>
> "adv7
On Mon, May 21, 2018 at 04:38:01PM +0200, Michał Winiarski wrote:
> It appears that we need to enable CIR device before attempting to touch
> some of the registers. Previously, this was not a big issue, since we
> were rarely seeing nvt_close() getting called.
>
> Unfortunately, since:
> cb84343fc
Hi Tomasz,
On 05/18/2018 05:16 PM, Tomasz Figa wrote:
> On Tue, May 15, 2018 at 5:13 PM Stanimir Varbanov <
> stanimir.varba...@linaro.org> wrote:
>
>> Adds set_properties method to handle newer 4xx properties and
>> fall-back to 3xx for the rest.
>
>> Signed-off-by: Stanimir Varbanov
>> ---
>>
It appears that we need to enable CIR device before attempting to touch
some of the registers. Previously, this was not a big issue, since we
were rarely seeing nvt_close() getting called.
Unfortunately, since:
cb84343fced1 ("media: lirc: do not call close() or open() on unregistered
devices")
T
Core rc keeps track of the users - let's use it to tweak the code and
use the common code path on suspend/resume.
Signed-off-by: Michał Winiarski
Cc: Jarod Wilson
Cc: Sean Young
---
drivers/media/rc/nuvoton-cir.c | 82 +++---
1 file changed, 36 insertions(+), 46 del
Doing writes when the device is disabled seems to be a NOOP.
Let's enable the device, write the values, and then disable it on init.
This changes the behavior for wake device, which is now being disabled
after init.
Signed-off-by: Michał Winiarski
Cc: Jarod Wilson
Cc: Sean Young
---
drivers/me
Hi Tomasz,
On 05/18/2018 04:53 PM, Tomasz Figa wrote:
> On Tue, May 15, 2018 at 5:14 PM Stanimir Varbanov <
> stanimir.varba...@linaro.org> wrote:
>
>> HFI version 4xx can pass more properties in the sequence change
>> event, extend the event structure with them.
>
>> Signed-off-by: Stanimir Var
Hi Tomasz,
Thanks for the comments!
On 05/18/2018 12:44 PM, Tomasz Figa wrote:
> Hi Stanimir,
>
> On Tue, May 15, 2018 at 5:14 PM Stanimir Varbanov <
> stanimir.varba...@linaro.org> wrote:
>
>> This covers the differences between 1xx,3xx and 4xx.
>
>> Signed-off-by: Stanimir Varbanov
>> ---
>
Hi All,
The new Google "Fizz" Intel-based ChromeOS device is gaining CEC support
through it's Embedded Controller, to enable the Linux CEC Core to communicate
with it and get the CEC Physical Address from the correct HDMI Connector, the
following must be added/changed:
- Add the CEC sub-device reg
The EC can expose a CEC bus, this patch adds the CEC related definitions
needed by the cros-ec-cec driver.
Having a 16 byte mkbp event size makes it possible to send CEC
messages from the EC to the AP directly inside the mkbp event
instead of first doing a notification and then a read.
Signed-off-
The ChromeOS Embedded Controller can expose a CEC bus, this patch add the
driver for such feature of the Embedded Controller.
This driver is part of the cros-ec MFD and will be add as a sub-device when
the feature bit is exposed by the EC.
The controller will only handle a single logical address
This patchs adds the cec_notifier feature to the intel_hdmi part
of the i915 DRM driver. It uses the HDMI DRM connector name to differentiate
between each HDMI ports.
The changes will allow the i915 HDMI code to notify EDID and HPD changes
to an eventual CEC adapter.
Signed-off-by: Neil Armstrong
The EC can expose a CEC bus, thus add the cros-ec-cec MFD sub-device
when the CEC feature bit is present.
Signed-off-by: Neil Armstrong
Reviewed-by: Enric Balletbo i Serra
---
drivers/mfd/cros_ec_dev.c | 16
1 file changed, 16 insertions(+)
diff --git a/drivers/mfd/cros_ec_dev
In non device-tree world, we can need to get the notifier by the driver
name directly and eventually defer probe if not yet created.
This patch adds a variant of the get function by using the device name
instead and will not create a notifier if not yet created.
But the i915 driver exposes at lea
Hi Dave,
On Monday, 21 May 2018 15:16:19 EEST Dave Stevenson wrote:
> On 19 May 2018 at 08:04, Laurent Pinchart wrote:
> > On Friday, 18 May 2018 18:37:01 EEST Dave Stevenson wrote:
> >> On 18 May 2018 at 16:05, Mauro Carvalho Chehab wrote:
> >>> Em Fri, 18 May 2018 15:27:24 +0300
> >>
> >>
> >>
Hi Tomasz,
On 05/18/2018 06:14 PM, Tomasz Figa wrote:
> On Tue, May 15, 2018 at 5:11 PM Stanimir Varbanov <
> stanimir.varba...@linaro.org> wrote:
>
>> This fixes the suspend function for Venus 3xx versions by
>> add a check for WFI (wait for interrupt) bit. This bit
>> is on when the ARM9 is idl
Hi Tomasz,
On 05/18/2018 05:23 PM, Tomasz Figa wrote:
> On Tue, May 15, 2018 at 5:12 PM Stanimir Varbanov <
> stanimir.varba...@linaro.org> wrote:
>
>> Add AXI halt support for version 4xx by using venus wrapper
>> registers.
>
>> Signed-off-by: Stanimir Varbanov
>> ---
>> drivers/media/platf
Hi Laurent
On 19 May 2018 at 08:04, Laurent Pinchart
wrote:
> Hi Dave,
>
> On Friday, 18 May 2018 18:37:01 EEST Dave Stevenson wrote:
>> On 18 May 2018 at 16:05, Mauro Carvalho Chehab wrote:
>> > Em Fri, 18 May 2018 15:27:24 +0300
>>
>>
>>
>> >>> There, instead of an USB camera, the hardware is
Hi,
staring with kernel 4.1 the tevii S650 usb box is not working any more,
last working version was 4.0.
The bug was also reported here
https://www.spinics.net/lists/linux-media/msg121356.html
I found a solution for it and uploaded a patch to the kernel bugzilla.
See here: https://bugzil
Add a new request state (UPDATING) as well as a count for updating the
request objects. This way, several updates may take place simultaneously
without affecting each other. The drivers (as well as frameworks) still
must serialise access to their own data structures; what is guaranteed by
the new s
Add a new request state (UPDATING) as well as a count for updating the
request objects. This way, several updates may take place simultaneously
without affecting each other. The drivers (as well as frameworks) still
must serialise access to their own data structures; what is guaranteed by
the new s
kref_init initializes the reference count to 1, not 0. This additional
reference is never released since the conversion to reference counters.
As a result, uvc_delete is not called anymore when UVC cameras are
disconnected.
Fix this by adding an additional kref_put in uvc_disconnect and in the
prob
Hi Mauro,
Here's the driver for the Renesas R-Car CSI-2 receiver.
Please pull.
The following changes since commit 8ed8bba70b4355b1ba029b151ade84475dd12991:
media: imx274: remove non-indexed pointers from mode_table (2018-05-17
06:22:08 -0400)
are available in the git repository at:
ssh:
From: Colin Ian King
Trivial fix to spelling mistake in name field
Signed-off-by: Colin Ian King
---
drivers/media/usb/hdpvr/hdpvr-i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/hdpvr/hdpvr-i2c.c
b/drivers/media/usb/hdpvr/hdpvr-i2c.c
index 4720d79b
On 18/05/2018 16:04, Enric Balletbo Serra wrote:
> Hi Neil,
>
> 2018-05-18 15:04 GMT+02:00 Neil Armstrong :
>> Hi All,
>>
>> The new Google "Fizz" Intel-based ChromeOS device is gaining CEC support
>> through it's Embedded Controller, to enable the Linux CEC Core to communicate
>> with it and get
Hi Enric,
On 18/05/2018 17:02, Enric Balletbo Serra wrote:
> Hi Neil,
>
> 2018-05-18 15:05 GMT+02:00 Neil Armstrong :
>> The Chrome OS Embedded Controller can expose a CEC bus, this patch add the
>
> A minor nit, there is a "consensus" on tell cros-ec as "ChromeOS
> Embedded Controller" or "Chro
Hi Enric,
On 18/05/2018 18:19, Enric Balletbo Serra wrote:
> Hi Neil,
>
> 2018-05-18 15:05 GMT+02:00 Neil Armstrong :
>> The EC can expose a CEC bus, this patch adds the CEC related definitions
>> needed by the cros-ec-cec driver.
>> Having a 16 byte mkbp event size makes it possible to send CEC
Add kerneldoc documentation for v4l2_ctrl_request_setup and
v4l2_ctrl_request_complete functions.
Signed-off-by: Sakari Ailus
---
include/media/v4l2-ctrls.h | 26 ++
1 file changed, 26 insertions(+)
diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2-ctrls.h
ind
From: Alexandre Courbot
If 'which' is V4L2_CTRL_WHICH_REQUEST_VAL, then the 'request_fd' field
can be used to specify a request for the G/S/TRY_EXT_CTRLS ioctls.
Signed-off-by: Alexandre Courbot
Signed-off-by: Hans Verkuil
---
drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 5 -
drivers/m
From: Hans Verkuil
Add a 'bool from_other_dev' argument: set to true if the two
handlers refer to different devices (e.g. it is true when
inheriting controls from a subdev into a main v4l2 bridge
driver).
This will be used later when implementing support for the
request API since we need to skip
From: Hans Verkuil
Integrate the request support. This adds the v4l2_ctrl_request_complete
and v4l2_ctrl_request_setup functions to complete a request and (as a
helper function) to apply a request to the hardware.
It takes care of queuing requests and correctly chaining control values
in the req
From: Hans Verkuil
Buffers can now be prepared or queued for a request.
A buffer is unbound from the request at vb2_buffer_done time or
when the queue is cancelled.
Signed-off-by: Hans Verkuil
---
drivers/media/common/videobuf2/videobuf2-core.c | 124 ++--
drivers/media/co
From: Hans Verkuil
Make vb2_buffer a request object.
Signed-off-by: Hans Verkuil
---
include/media/videobuf2-core.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/media/videobuf2-core.h b/include/media/videobuf2-core.h
index 224c4820a0443..3d54654c3cd48 100644
--- a/include/med
Instead of checking the media request state is idle at one point, lock the
request for updating during the S_EXT_CTRLS call. As a by-product, finding
the request has been moved out of the v4l2_ctrls_find_req_obj() in order
to keep request object lookups to the minimum.
Signed-off-by: Sakari Ailus
From: Hans Verkuil
To store request data the handler_new_ref() allocates memory
for it if needed.
Signed-off-by: Hans Verkuil
---
drivers/media/v4l2-core/v4l2-ctrls.c | 20
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c
From: Hans Verkuil
The next patch needs the reference to a control instead of the
control itself, so change struct v4l2_ctrl_helper accordingly.
Signed-off-by: Hans Verkuil
---
drivers/media/v4l2-core/v4l2-ctrls.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff -
From: Hans Verkuil
Embed and initialize a media_request_object in struct v4l2_ctrl_handler.
Add a p_req field to struct v4l2_ctrl_ref that will store the
request value.
Signed-off-by: Hans Verkuil
Signed-off-by: Alexandre Courbot
---
drivers/media/v4l2-core/v4l2-ctrls.c | 1 +
include/media/
From: Hans Verkuil
The userspace-provided plane data needs to be stored in
vb2_v4l2_buffer. Currently this information is applied by
__fill_vb2_buffer() which is called by the core prepare_buf
and qbuf functions, but when using requests these functions
aren't called yet since the buffer won't be
Add a new request state (UPDATING) as well as a count for updating the
request objects. This way, several updates may take place simultaneously
without affecting each other. The drivers (as well as frameworks) still
must serialise access to their own data structures; what is guaranteed by
the new s
From: Hans Verkuil
We need to serialize streamon/off with queueing new requests.
These ioctls may trigger the cancellation of a streaming
operation, and that should not be mixed with queuing a new
request at the same time.
Finally close() needs this lock since that too can trigger the
cancellati
From: Hans Verkuil
Add media_request_object_find to find a request object inside a
request based on ops and/or priv values.
Objects of the same type (vb2 buffer, control handler) will have
the same ops value. And objects that refer to the same 'parent'
object (e.g. the v4l2_ctrl_handler that has
Grab the request spinlock to access media request state
Signed-off-by: Sakari Ailus
---
drivers/media/common/videobuf2/videobuf2-core.c | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/drivers/media/common/videobuf2/videobuf2-core.c
b/drivers/media/common/vi
Hello everyone,
Here are my changes over v13 set Hans posted earlier. The changes since
v13 include:
- Request state is made enum again. This change was motivated by
complicated locking scheme in which it was not obvious which locks would
need to be acquired and when. In some cases the atomic
From: Hans Verkuil
Request API requires a media node. Add one to the vim2m driver so we can
use requests with it.
This probably needs a bit more work to correctly represent m2m
hardware in the media topology.
Signed-off-by: Hans Verkuil
---
drivers/media/platform/vim2m.c | 42
From: Hans Verkuil
Define the public request API.
This adds the new MEDIA_IOC_REQUEST_ALLOC ioctl to allocate a request
and two ioctls that operate on a request in order to queue the
contents of the request to the driver and to re-initialize the
request.
Signed-off-by: Hans Verkuil
---
includ
From: Hans Verkuil
This implements the V4L2 part of the request support. The main
change is that vb2_qbuf and vb2_prepare_buf now have a new
media_device pointer. This required changes to several drivers
that did not use the vb2_ioctl_qbuf/prepare_buf helper functions.
Signed-off-by: Hans Verkui
Make the request state an enum in order to simplify serialising access to
the state as well as other fields in the request. Using the atomic would
be fine as such, but it conveys the suggestion that the atomic operations
alone will be enough for changing that state which is not true.
Signed-off-by
From: Hans Verkuil
Add support for requests to vivid.
Signed-off-by: Hans Verkuil
---
drivers/media/platform/vivid/vivid-core.c| 8
drivers/media/platform/vivid/vivid-kthread-cap.c | 12
drivers/media/platform/vivid/vivid-kthread-out.c | 12
drivers/
media-request.h has been recently added; add it to the documentation build
as well.
Signed-off-by: Sakari Ailus
---
Documentation/media/kapi/mc-core.rst | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/media/kapi/mc-core.rst
b/Documentation/media/kapi/mc-core.rst
index 0c0550
From: Hans Verkuil
Keep track of the number of requests and request objects of a media
device. Helps to verify that all request-related memory is freed.
Signed-off-by: Hans Verkuil
---
drivers/media/media-device.c | 41 +
drivers/media/media-devnode.c |
From: Hans Verkuil
v4l2_ctrl uses mutexes, so we can't setup a ctrl_handler in
interrupt context. Switch to a workqueue instead.
Signed-off-by: Hans Verkuil
---
drivers/media/platform/vim2m.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/drivers/media/pla
The v4l2_m2m_try_schedule function acquires and releases multiple
spinlocks; simplify unlocking the job lock by adding a label to unlock the
job lock and exit the function.
Signed-off-by: Sakari Ailus
---
drivers/media/v4l2-core/v4l2-mem2mem.c | 22 --
1 file changed, 12 inse
Add a sanity check for the number of the media request states equals the
number of status strings for debug purposes. This necessitates a new
entry in the request state enumeration, called NR_OF_MEDIA_REQUEST_STATE.
Signed-off-by: Sakari Ailus
---
drivers/media/media-request.c | 2 ++
include/me
From: Hans Verkuil
Add initial media request support:
1) Add MEDIA_IOC_REQUEST_ALLOC ioctl support to media-device.c
2) Add struct media_request to store request objects.
3) Add struct media_request_object to represent a request object.
4) Add MEDIA_REQUEST_IOC_QUEUE/REINIT ioctl support.
Basic
From: Alexandre Courbot
Document the request API for V4L2 devices, and amend the documentation
of system calls influenced by it.
Signed-off-by: Alexandre Courbot
Signed-off-by: Hans Verkuil
---
Documentation/media/uapi/mediactl/media-funcs.rst | 3 +
.../uapi/mediactl/media-ioc-request-all
From: Hans Verkuil
The v4l2_g/s_ext_ctrls functions now support control handlers that
represent requests.
The v4l2_ctrls_find_req_obj() function is responsible for finding the
request from the fd.
Signed-off-by: Hans Verkuil
---
drivers/media/platform/omap3isp/ispvideo.c | 2 +-
drivers/med
From: Hans Verkuil
Add support for the media_device to vivid. This is a prerequisite
for request support.
Signed-off-by: Hans Verkuil
---
drivers/media/platform/vivid/vivid-core.c | 61 +++
drivers/media/platform/vivid/vivid-core.h | 8
2 files changed, 69 ins
1 - 100 of 119 matches
Mail list logo
