From: Max Thrun
Also set default values unconditionally, for readability.
Signed-off-by: Max Thrun
Signed-off-by: Antonio Ospite
---
linux/drivers/media/video/gspca/ov534.c |8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
Index: gspca/linux/drivers/media/video/gspca/ov534.c
* Indent with tabs, not with spaces.
* Less indentation for controls index comments.
* Use lowercase hex digits.
Signed-off-by: Antonio Ospite
---
linux/drivers/media/video/gspca/ov534.c | 128
1 file changed, 64 insertions(+), 64 deletions(-)
Index
register when AGC is enabled.
* Enable AGC by default.
Note that as Auto Gain Control is now enabled by default, if you are
using the driver for visual computing applications you might need to
disable it explicitly in your software.
Signed-off-by: Max Thrun
Signed-off-by: Antonio Ospite
---
Exposure is now a u16 value, both MSB and LSB are set, but values in the v4l2
control are limited to the interval [0,506] as 0x01fa (506) is the maximum
observed value with AEC enabled.
Skip setting exposure when AEC is enabled.
Signed-off-by: Antonio Ospite
---
linux/drivers/media/video/gspca
- vflip
* Fixed coding style
* Added Powerline Frequency control
The only big behavioural change should be AGC enabled by default, if
users want autogain disabled by default we can rediscuss this again.
Special thanks to Max Thrun and Mosalam Ebrahimi.
Regards,
Antonio
--
Antonio Ospite
http
Hue control doesn't work and the sensor datasheet is not clear about how
to set hue properly.
Signed-off-by: Antonio Ospite
---
linux/drivers/media/video/gspca/ov534.c | 54 ++--
1 file changed, 5 insertions(+), 49 deletions(-)
Index: gspca/linux/drivers/
From: Max Thrun
Signed-off-by: Max Thrun
Signed-off-by: Antonio Ospite
---
linux/drivers/media/video/gspca/ov534.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: gspca/linux/drivers/media/video/gspca/ov534.c
From: Max Thrun
Remove Blue/Red Channel Target Value, they are meant for Black Level
Calibration but it is not completely clear how to use them.
Signed-off-by: Max Thrun
Signed-off-by: Antonio Ospite
---
linux/drivers/media/video/gspca/ov534.c | 100 +---
1 file
From: Max Thrun
* Adjust comments for sharpness control
* Set default value unconditionally, for readability
Signed-off-by: Max Thrun
Signed-off-by: Antonio Ospite
---
linux/drivers/media/video/gspca/ov534.c |6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
Index: gspca
From: Mosalam Ebrahimi
Note that setting this options to 50Hz can reduce the framerate, so the
default is still 60Hz.
Signed-off-by: Mosalam Ebrahimi
Signed-off-by: Antonio Ospite
---
linux/drivers/media/video/gspca/ov534.c | 71 +++-
1 file changed, 70
From: Max Thrun
Set only the needed bits for AWB, and enable it by default.
Signed-off-by: Max Thrun
Signed-off-by: Antonio Ospite
---
linux/drivers/media/video/gspca/ov534.c | 21 +
1 file changed, 13 insertions(+), 8 deletions(-)
Index: gspca/linux/drivers/media
expected frame size.
Signed-off-by: Antonio Ospite
Cc: Max Thrun
---
Max, can you test this as well? This should be better than removing all
the discard logic at once. After this is in I'll keep working on your
changes.
Jean-Francois, if this is proven to be the right thing to do, it shou
On Sat, 16 Jan 2010 17:47:49 +0100
Jean-Francois Moine wrote:
> Hi Antonio,
>
> I recoded your patch with some changes, mainly in gspca.h. If it is
> OK for you, may you sign it?
>
Ok, that's even better.
Signed-off-by: Antonio Ospite
> Best regards.
>
On Sat, 9 Jan 2010 01:41:31 +0100
Antonio Ospite wrote:
> Index: gspca/linux/drivers/media/video/gspca/ov534.c
> ===
> --- gspca.orig/linux/drivers/media/video/gspca/ov534.c
> +++ gspca/linux/drivers/media/video/g
On Sat, 9 Jan 2010 01:41:31 +0100
Antonio Ospite wrote:
> Signed-off-by: Antonio Ospite
>
> ---
>
> Historical note:
>
> This has been re-tested on a reliable machine and it works from guvcview for
> all the framerates; on my old PC I am still having pro
Signed-off-by: Antonio Ospite
---
Historical note:
This has been re-tested on a reliable machine and it works from guvcview for
all the framerates; on my old PC I am still having problems with 640x...@60fps
_regardless_ of this change, so it must be a USB problem.
Thanks,
Antonio
Index
Some drivers support multiple frameintervals (framerates), make gspca able to
enumerate them.
Signed-off-by: Antonio Ospite
---
Changes since the initial RFC version:
- 'i' is now a __u32 and the variable 'index' has been dropped.
- some more comments in gspca.h
Thanks
On Tue, 17 Nov 2009 23:04:20 +0100
Antonio Ospite wrote:
> Hi,
>
> this series removes the init() callback from pxa_camera_platform_data, and
> fixes its users to do initialization statically at machine init time.
>
[...]
> Antonio Ospite (3):
> em-x270: don't use
pxa_camera init() is ambiguous, it's better to configure PXA CIF pins
statically in machine init function.
Signed-off-by: Antonio Ospite
---
The only change from previous version is the commit message, we don't want to
mention .init() removal yet.
arch/arm/mach-pxa/pcm990-baseboar
pxa_camera init() is ambiguous, it's better to statically configure the sensor.
Signed-off-by: Antonio Ospite
Acked-by: Mike Rapoport
---
The only change from previous version is the commit message, we don't want to
mention .init() removal yet. Since the code is not changed the ack
On Fri, 27 Nov 2009 15:37:19 +0100 (CET)
Guennadi Liakhovetski wrote:
> On Fri, 27 Nov 2009, Antonio Ospite wrote:
>
> > On Fri, 27 Nov 2009 15:06:53 +0100 (CET)
> > Guennadi Liakhovetski wrote:
> >
> > > On Tue, 17 Nov 2009, Antonio Ospite wrote:
> > &
On Fri, 27 Nov 2009 15:06:53 +0100 (CET)
Guennadi Liakhovetski wrote:
> On Tue, 17 Nov 2009, Antonio Ospite wrote:
>
> > pxa_camera init() callback is sometimes abused to setup MFP for PXA CIF, or
> > even to request GPIOs to be used by the camera *sensor*. These
> > in
On Thu, 19 Nov 2009 09:08:22 +0100
Hans de Goede wrote:
> Hi,
>
Hi, thanks for commenting on this.
> On 11/17/2009 11:41 AM, Antonio Ospite wrote:
> > Hi,
> >
> > gspca does not implement vidioc_enum_frameintervals yet, so even if a
> > camera can suppo
On Wed, 18 Nov 2009 11:10:06 +0100 (CET)
Guennadi Liakhovetski wrote:
> On Tue, 17 Nov 2009, Antonio Ospite wrote:
>
> > pxa_camera init() is going to be removed.
>
> My nitpick here would be - I would put it the other way round. We do not
> remove .init() in platforms, b
pxa_camera_activate(), hence at device node open, but its users use
it like a generic initialization to be done at module init time (configure
MFP, request GPIOs for *sensor* control).
Signed-off-by: Antonio Ospite
---
arch/arm/mach-pxa/include/mach/camera.h |2 --
drivers/media/video
pxa_camera init() is going to be removed.
Configure PXA CIF pins directly in machine init function.
Signed-off-by: Antonio Ospite
---
arch/arm/mach-pxa/pcm990-baseboard.c |8 +---
1 files changed, 1 insertions(+), 7 deletions(-)
diff --git a/arch/arm/mach-pxa/pcm990-baseboard.c
b/arch
pxa_camera init() is going to be removed.
Signed-off-by: Antonio Ospite
---
arch/arm/mach-pxa/em-x270.c |9 +
1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/arch/arm/mach-pxa/em-x270.c b/arch/arm/mach-pxa/em-x270.c
index aec7f42..f71f34c 100644
--- a/arch/arm/mach
were really exposing some dynamic and generic
initialization, this could be done in soc-camera itself, not in pxa_camera
anyways.
Thanks,
Antonio
Antonio Ospite (3):
em-x270: don't use pxa_camera init() callback
pcm990-baseboard: don't use pxa_camera init() callback
pxa_came
772x_mode);
+ cam->mode_framerates = ov772x_framerates;
cam->bulk = 1;
cam->bulk_size = 16384;
--
Antonio Ospite
http://ao2.it
PGP public key ID: 0x4553B001
A: Because it messes up the order in which people normally read text.
See http://e
Signed-off-by: Bart Visscher
Signed-off-by: Antonio Ospite
---
Changes since v3:
- Check {a780,a910}_camera_init() return value, and register camera
conditionally.
arch/arm/mach-pxa/ezx.c | 174 +-
1 files changed, 170 insertions(+), 4 deletions
On Wed, 11 Nov 2009 19:02:11 +0100 (CET)
Guennadi Liakhovetski wrote:
> Hi Antonio
>
> Still one more nitpick:
>
Comments below.
> On Wed, 11 Nov 2009, Antonio Ospite wrote:
>
[...]
> >
> > +/* camera */
> > +static int a780_camera_init(void)
>
Signed-off-by: Bart Visscher
Signed-off-by: Antonio Ospite
---
Changes since v2:
- Bart's SOB goes first, as he is the original author.
- Add MFP_LPM_DRIVE_HIGH to camera gpios, as per Motorola original
code.
- s/pxacamera/camera/ in function names, as they are not us
/* CAM_FLASH */
};
#endif
Is that right?
I am putting also this into the next version I am going to send for
submission, if you don't object.
Thanks,
Antonio
--
Antonio Ospite
http://ao2.it
PGP public key ID: 0x4553B001
A: Because it messes up the order in which people normally rea
Ospite wrote:
> On Fri, 6 Nov 2009 15:11:55 +0100 (CET)
> Guennadi Liakhovetski wrote:
>
> > On Thu, 5 Nov 2009, Antonio Ospite wrote:
> >
> > > See? It's power(), reset(), init().
> > > Maybe the problem is in soc_camera_probe()?
> >
&
On Thu, 5 Nov 2009 00:53:46 +0100 (CET)
Guennadi Liakhovetski wrote:
> On Wed, 4 Nov 2009, Antonio Ospite wrote:
>
> > Signed-off-by: Antonio Ospite
> > Signed-off-by: Bart Visscher
>
> Is this patch going via Bart? Or should this be an Acked-by?
>
Bart did the i
On Mon, 05 Oct 2009 08:32:10 +0200
Stefan Herbrechtsmeier wrote:
> Antonio Ospite schrieb:
> > On Sun, 4 Oct 2009 00:31:24 +0200 (CEST)
> > Guennadi Liakhovetski wrote:
> >
> >>> Anyways your patch works, but the picture is now shifted, see:
> >>>
On Sun, 4 Oct 2009 00:31:24 +0200 (CEST)
Guennadi Liakhovetski wrote:
> On Sat, 3 Oct 2009, Antonio Ospite wrote:
>
[...]
> > Anyways your patch works, but the picture is now shifted, see:
> > http://people.openezx.org/ao2/a780-pxa-camera-mt9m111-shifted.jpg
> >
> &
On Sat, 3 Oct 2009 01:27:04 +0200 (CEST)
Guennadi Liakhovetski wrote:
> On Fri, 2 Oct 2009, Antonio Ospite wrote:
>
> > Hi,
> >
> > after updating to 2.6.32-rc2 I can't capture anymore with the setup in the
> > subject.
>
> Indeed:-( Please, v
it looks like pxa-camera is trying to force
its native format to the sensor, but I am still investigating; I'll come
back when I find more or if I come up with a solution.
Thanks,
Antonio
--
Antonio Ospite
http://ao2.it
PGP public key ID: 0x4553B001
A: Because it messes up the order in which pe
] New frame - first packet
[55449.656421] Frame completed
[55449.656429] New frame - first packet
[55449.816286] Frame completed
[55449.816294] New frame - first packet
[55449.976166] Frame completed
[55449.976173] New frame - first packet
[55449.976175] Frame marked for discard
[55450.136047] New fr
ostic tools or techniques would be much appreciated.
>
I'd give a run to _latest_ code to see if the problem has been
solved already, and if you really can't use it, then you isolate the fix
and apply it to the code you have to use.
Captain Obvious to the rescue :)
> Thanks,
>
On Tue, 4 Aug 2009 11:31:24 +0200 (CEST)
Guennadi Liakhovetski wrote:
> On Tue, 4 Aug 2009, Antonio Ospite wrote:
>
> > The current patch applies with some fuzzes on vanilla kernels, and it
> > even FAILS to apply for drivers/media/video/sh_mobile_ceu_camera.c in
> >
On Tue, 4 Aug 2009 10:30:47 +0200 (CEST)
Guennadi Liakhovetski wrote:
> On Tue, 4 Aug 2009, Antonio Ospite wrote:
>
> > verified to be present in linux-2.6.31-rc5, here's some info dumped
> > from RAM, since the machine hangs, sorry if it is not complete but I
> >
ra_streamon
[ 104.961840] camera 0-0: pxa_videobuf_queue (vb=0xcc91e760) 0x40144000 614400
active=(null)
maybe some more pxa_videobuf_queue lines are missing,
but again I was not able to extract them from RAM.
Thanks,
Antonio
--
Antonio Ospite
http://ao2.it
PGP public key ID: 0x4553B001
A: Be
t;
> Antonio,
>
> Would you check [1] and see if your stack does correspond to the one I
> reported
> some time ago ? As this is fresh in your memory, you'll be far quicker that
> me.
>
...
> [1] http://osdir.com/ml/linux-media/2009-04/msg00874.html
Yes, I think that
On Fri, 3 Jul 2009 22:03:27 +0200 (CEST)
Guennadi Liakhovetski wrote:
> On Fri, 3 Jul 2009, Antonio Ospite wrote:
>
> > > Linux video capture interface: v2.00
> > > Unable to handle kernel NULL pointer dereference at virtual address
> > > 0060
> >
On Wed, 1 Jul 2009 20:43:25 +0200
Antonio Ospite wrote:
> Hi,
>
> I get this with pxa-camera in mainline linux (from today).
> I haven't touched my board code which used to work in 2.6.30
>
I think I've tracked down the cause. The board code is triggering a
bug in px
from []
(kernel_init+0x8c/0x104)
[] (kernel_init+0x8c/0x104) from []
(kernel_thread_exit+0x0/0x8)
Code: e8bd80f0 2710 0001a36e 000f423f (e5903060)
---[ end trace 1b75b31a2719ed1d ]---
Regards,
Antonio
--
Antonio Ospite
http://ao2.it
PGP public key ID: 0x4553B001
A: Because it messes up the ord
which people normally read text.
See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
Antonio Ospite
http://ao2.it
PGP public key ID: 0x4553B001
pgpmFTfyuUzir.pgp
Description: PGP signature
On Thu, 7 May 2009 02:54:00 +0300
Vasily wrote:
> This patch introduces v4l2 loopback module
>
Hi Vasily, next time it would be useful to summarize what you changed
from the previous version, and put a revision number in the Subject,
like [PATCH v2] [PATCH v3], etc.
Also, the patch has some st
re:
./drivers/media/video/camera4uvc.c
./drivers/media/video/camera4uvc.h
./drivers/usbd/UVC_fd
./drivers/usbd/UVC_fd/uvc.c
./drivers/usbd/UVC_fd/uvc.h
Regards,
Antonio Ospite
[1]
http://www.motorola.com/motoinfo/product/details.jsp?globalObjectId=175
[1a]
http://lists.berlios.de/pipe
_streamoff = &vidioc_streamoff,
> -#ifdef CONFIG_VIDEO_V4L1_COMPAT
> - .vidiocgmbuf = &vidiocgmbuf,
> -#endif
> -};
> -
> -int __init init_module()
> -{
> - int ret;
> -
> - dprintk("entering init_module()\n");
> - /* kfree on module release */
> -
On Tue, 14 Apr 2009 15:53:00 +0300
vas...@gmail.com wrote:
> On Tue, Apr 14, 2009 at 3:12 PM, Mauro Carvalho Chehab
> wrote:
>
> > The issue I see is that the V4L drivers are meant to support real devices.
> > This
> > driver that is a loopback for some userspace driver. I don't discuss its
> >
Call icl->reset() on mt9m111_reset().
Signed-off-by: Antonio Ospite
diff --git a/drivers/media/video/mt9m111.c b/drivers/media/video/mt9m111.c
index c043f62..92dd7f3 100644
--- a/drivers/media/video/mt9m111.c
+++ b/drivers/media/video/mt9m111.c
@@ -393,6 +393,8 @@ static int mt9m111_disa
201 - 254 of 254 matches
Mail list logo
