Re: [PATCH] gspca - ov534: Fix the light frequency filter

On Mon, 26 Nov 2012 16:23:18 +0100 Jean-Francois Moine wrote: > On Mon, 26 Nov 2012 14:08:06 +0100 > Antonio Ospite wrote: > > > For now I'd NAK the patch since it is a regression for users > > with 50Hz power sources and it looks like it does not _always

Re: [PATCH] gspca - ov534: Fix the light frequency filter

On Thu, 29 Nov 2012 10:25:19 +0100 Hans de Goede wrote: > Hi Jean-Francois, Antonio Ospite, > > Could it be that you're both right, and that the register > Jean-Francois suggest is used (0x13) and uses in his patch > is for enabling / disabling the light-freq filter, whe

Re: [PATCH 0/3] gspca: kinect cleanup, ov534 port to control framework

On Fri, 18 May 2012 09:08:29 +0200 Jean-Francois Moine wrote: > On Wed, 16 May 2012 23:42:43 +0200 > Antonio Ospite wrote: > > > The second patch removes the dependency between auto gain and auto white > > balance, I'd like to hear Jean-Francois on this, the webcam

Re: Problems with the gspca_ov519 driver

investigation, I've been experiencing this since commit f7059ea, which in fact removes the lines HdG added back, but I didn't put too much effort in investigating the exact cause, sorry. For the record the guvcview error messages were: VIDIOC_QBUF - Unable to queue buffer: Invalid argument Could

Re: [PATCH] [media] videodev: fix a NULL pointer dereference in v4l2_device_release()

On Wed, 12 Oct 2011 23:59:26 +0200 Antonio Ospite wrote: > The change in 8280b66 does not cover the case when v4l2_dev is already > NULL, fix that. > > With a Kinect sensor, seen as an USB camera using GSPCA in this context, > a NULL pointer dereference BUG can be triggered by

Re: kernel OOPS when releasing usb webcam (random)

e+0xa2/0xf0 [videodev] Hi, I sent a fix for a similar trace last week: http://patchwork.linuxtv.org/patch/8124/ Tomas, can you test it fixes the problem for you too? Thanks, Antonio -- Antonio Ospite http://ao2.it PGP public key ID: 0x4553B001 A: Because it messes up the order in wh

Re: [PATCH v2] [media] gspca: replaced static allocation by video_device_alloc/video_device_release

> --- a/drivers/media/video/gspca/gspca.c > +++ b/drivers/media/video/gspca/gspca.c > @@ -1292,10 +1292,12 @@ static int vidioc_enum_frameintervals(struct file > *filp, void *priv, > [...] Thanks, Antonio -- Antonio Ospite http://ao2.it PGP public key ID: 0x4553B001 A: Beca

Re: [PATCH] m920x: silence compiler warning

: note: ‘ret’ was declared here > > Signed-off-by: Antti Palosaari Acked-by: Antonio Ospite And thanks. BTW Antti, there was another patch for this warning: http://thread.gmane.org/gmane.linux.kernel/1450717 but your change is easier to validate. > --- > drivers/media/usb/dvb-usb/

Re: [Fwd: How to debug problem with Playstation Eye webcam?]

ostic tools or techniques would be much appreciated. > I'd give a run to _latest_ code to see if the problem has been solved already, and if you really can't use it, then you isolate the fix and apply it to the code you have to use. Captain Obvious to the rescue :) > Thanks, >

Re: gspca stv06xx performance regression - request for testing

] New frame - first packet [55449.656421] Frame completed [55449.656429] New frame - first packet [55449.816286] Frame completed [55449.816294] New frame - first packet [55449.976166] Frame completed [55449.976173] New frame - first packet [55449.976175] Frame marked for discard [55450.136047] New fr

pxa_camera + mt9m1111: Failed to configure for format 50323234

it looks like pxa-camera is trying to force its native format to the sensor, but I am still investigating; I'll come back when I find more or if I come up with a solution. Thanks, Antonio -- Antonio Ospite http://ao2.it PGP public key ID: 0x4553B001 A: Because it messes up the order in which pe

Re: pxa_camera + mt9m1111: Failed to configure for format 50323234

On Sat, 3 Oct 2009 01:27:04 +0200 (CEST) Guennadi Liakhovetski wrote: > On Fri, 2 Oct 2009, Antonio Ospite wrote: > > > Hi, > > > > after updating to 2.6.32-rc2 I can't capture anymore with the setup in the > > subject. > > Indeed:-( Please, v

Re: pxa_camera + mt9m1111: Failed to configure for format 50323234

On Sun, 4 Oct 2009 00:31:24 +0200 (CEST) Guennadi Liakhovetski wrote: > On Sat, 3 Oct 2009, Antonio Ospite wrote: > [...] > > Anyways your patch works, but the picture is now shifted, see: > > http://people.openezx.org/ao2/a780-pxa-camera-mt9m111-shifted.jpg > > > &

Re: pxa_camera + mt9m1111: image shifted (was: Failed to configure for format 50323234)

On Mon, 05 Oct 2009 08:32:10 +0200 Stefan Herbrechtsmeier wrote: > Antonio Ospite schrieb: > > On Sun, 4 Oct 2009 00:31:24 +0200 (CEST) > > Guennadi Liakhovetski wrote: > > > >>> Anyways your patch works, but the picture is now shifted, see: > >>>

Re: [PATCH 1/3 v2] ezx: Add camera support for A780 and A910 EZX phones

On Thu, 5 Nov 2009 00:53:46 +0100 (CET) Guennadi Liakhovetski wrote: > On Wed, 4 Nov 2009, Antonio Ospite wrote: > > > Signed-off-by: Antonio Ospite > > Signed-off-by: Bart Visscher > > Is this patch going via Bart? Or should this be an Acked-by? > Bart did the i

Re: [PATCH 1/3 v2] ezx: Add camera support for A780 and A910 EZX phones

Ospite wrote: > On Fri, 6 Nov 2009 15:11:55 +0100 (CET) > Guennadi Liakhovetski wrote: > > > On Thu, 5 Nov 2009, Antonio Ospite wrote: > > > > > See? It's power(), reset(), init(). > > > Maybe the problem is in soc_camera_probe()? > > &

Re: [PATCH 1/3] ezx: Add camera support for A780 and A910 EZX phones

/* CAM_FLASH */ }; #endif Is that right? I am putting also this into the next version I am going to send for submission, if you don't object. Thanks, Antonio -- Antonio Ospite http://ao2.it PGP public key ID: 0x4553B001 A: Because it messes up the order in which people normally rea

[PATCH 1/3 v3] Add camera support for A780 and A910 EZX phones

Signed-off-by: Bart Visscher Signed-off-by: Antonio Ospite --- Changes since v2: - Bart's SOB goes first, as he is the original author. - Add MFP_LPM_DRIVE_HIGH to camera gpios, as per Motorola original code. - s/pxacamera/camera/ in function names, as they are not us

Re: [PATCH 1/3 v3] Add camera support for A780 and A910 EZX phones

On Wed, 11 Nov 2009 19:02:11 +0100 (CET) Guennadi Liakhovetski wrote: > Hi Antonio > > Still one more nitpick: > Comments below. > On Wed, 11 Nov 2009, Antonio Ospite wrote: > [...] > > > > +/* camera */ > > +static int a780_camera_init(void) >

[PATCH 1/3 v4] Add camera support for A780 and A910 EZX phones

Signed-off-by: Bart Visscher Signed-off-by: Antonio Ospite --- Changes since v3: - Check {a780,a910}_camera_init() return value, and register camera conditionally. arch/arm/mach-pxa/ezx.c | 174 +- 1 files changed, 170 insertions(+), 4 deletions

[PATCH 0/2] Documentation/DocBook/media/v4l: typos

Hi, here are a couple of fixes for typos in Documentation/DocBook/media/v4l/subdev-formats.xml Ciao, Antonio Antonio Ospite (2): [media] Documentation/DocBook/media/v4l/subdev-formats.xml: fix a typo [media] Documentation/DocBook/media/v4l: fix typo, s/packet/packed/ Documentation

[PATCH 2/2] [media] Documentation/DocBook/media/v4l: fix typo, s/packet/packed/

Change "packet" to "packed" where the doc is talking about packed data formats. Signed-off-by: Antonio Ospite --- Documentation/DocBook/media/v4l/subdev-formats.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/DocBook/media/v4l/s

[PATCH 1/2] [media] Documentation/DocBook/media/v4l/subdev-formats.xml: fix a typo

The xref to the v4l2-mbus-pixelcode-yuv8 table gets rendered as "Table 4.22, “YUV Formats”", so use the verb in the third person singular because it refers to "Table": s/list/lists/ Signed-off-by: Antonio Ospite --- Documentation/DocBook/media/v4l/subdev-formats.xml | 2 +

Re: question about drivers/media/usb/gspca/kinect.c

} actual_len -= sizeof(*rhdr); Proper patches on their way, to libfreenect too. Thanks again, Antonio [1] http://lxr.linux.no/#linux+v3.12.6/drivers/media/usb/dvb-usb-v2/dvb_usb_urb.c#L37 [2] http://lxr.linux.no/#linux+v3.12.6/Documentation/usb/error-codes.txt#L134 [3] https://github.com/O

[PATCH 1/2] gspca_kinect: fix kinect_read() error path

eport with -EREMOTEIO the case of a partial transfer. Reported-by: Julia Lawall Signed-off-by: Antonio Ospite --- drivers/media/usb/gspca/kinect.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/gspca/kinect.c b/drivers/media/usb/gspca/kinect.c index 3773a8a

[PATCH 2/2] gspca_kinect: fix messages about kinect_read() return value

Messages relative to kinect_read() are printing "res" which contains the return value of a previous kinect_write(). Print the correct value in the messages. Cc: Julia Lawall Signed-off-by: Antonio Ospite --- drivers/media/usb/gspca/kinect.c | 5 +++-- 1 file changed, 3 insert

[PATCH] libv4lconvert: Fix a regression when converting from Y10B

9bf641 this (maybe weird) logic was misunderstood and the v4lconvert_convert_pixfmt() was made to return an error even in the case of a successful conversion from Y10B. Fix the check, and now print only the message letting the errno and the result from the conversion routines to be propagated to the

Re: [PATCH] libv4lconvert: Fix a regression when converting from Y10B

On Tue, 3 Jun 2014 15:48:46 +0200 Antonio Ospite wrote: > Fix a regression introduced in commit > efc29f1764a30808ebf7b3e1d9bfa27b909bf641 (libv4lconvert: Reject too > short source buffer before accessing it). > > The old code: > > case V4L2_PIX_FMT_Y10BPACK: >

[PATCH 01/12] trivial: drivers/media/usb/gspca/gspca.c: fix the indentation of a comment

Fix indentation of a comment, put it on the same level of the code it refers to. Signed-off-by: Antonio Ospite Cc: Hans de Goede Cc: linux-media@vger.kernel.org --- drivers/media/usb/gspca/gspca.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/media/usb/gspca

[PATCH 02/12] trivial: drivers/media/usb/gspca/gspca.h: indent with TABs, not spaces

Signed-off-by: Antonio Ospite Cc: Hans de Goede Cc: linux-media@vger.kernel.org --- drivers/media/usb/gspca/gspca.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/gspca/gspca.h b/drivers/media/usb/gspca/gspca.h index 300642d..c1273e5 100644 --- a/drivers

[RFC 2/2] gspca_kinect: add support for the depth stream

: Antonio Ospite --- For now a command line parameter called "depth_mode" is used to select which mode to activate when loading the driver, this is necessary because gspca is not quite ready to have a subdriver call gspca_dev_probe() multiple times. The problem seems to be that gspca assumes

[RFC 1/2] gspca: provide a mechanism to select a specific transfer endpoint

Add a xfer_ep_index field to struct gspca_dev, and change alt_xfer() so that it accepts a parameter which represents a specific endpoint to look for. If a subdriver wants to specify a value for gspca_dev->xfer_ep_index it can do that in its sd_config() callback. Signed-off-by: Antonio Osp

[RFC 0/2] gspca_kinect: add support for the depth stream

stream in the mainline driver. The first patch is about supporting data streams on endpoints other than the first one in gspca. The second patch adds support for the depth data to the kinect subdriver. Some more specific comments are annotated per-patch. Ciao ciao, Antonio Antonio Ospite (2

Re: [PATCH 1/1] gspca: Add high-speed modes for PS3 Eye camera

nge supports such high frame rates. > > Correct a QVGA mode that was listed as 40 FPS. It is really 37 FPS > (half of 75 FPS). > > Tests confirm that the nominal frame rates are achieved. > > Signed-off-by: Joe Howse Tested-by: Antonio Ospite Thanks Joe. I noticed t

Re: [PATCH] gspca_stv06xx: enable button found on some Quickcam Express variant

On Tue, 28 Oct 2014 15:39:41 +0100 Antonio Ospite wrote: > On Mon, 14 Jul 2014 12:27:57 +0200 > Hans de Goede wrote: > > > Hi, > > > > On 07/11/2014 02:56 PM, Antonio Ospite wrote: > > > Signed-off-by: Antonio Ospite > > > > Thanks, I

Re: [PATCH] gspca_stv06xx: enable button found on some Quickcam Express variant

On Mon, 14 Jul 2014 12:27:57 +0200 Hans de Goede wrote: > Hi, > > On 07/11/2014 02:56 PM, Antonio Ospite wrote: > > Signed-off-by: Antonio Ospite > > Thanks, I've added this to my tree and send a pull-req for it > to Mauro. > Hi Hans, I still don't see

Re: input_polldev interval (was Re: [sur40] Debugging a race condition)?

oader (i.e. before lading another linux instance) and then scrape the dump to look for the kernel messages, but AFAIK this is not going to be reliable —or even possible— on a more complex system. Ciao, Antonio -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people no

[PATCH RESEND] libv4lconvert: Fix a regression when converting from Y10B

9bf641 this (maybe weird) logic was misunderstood and v4lconvert_convert_pixfmt() was made to return an error even in the case of a successful conversion from Y10B. Fix the check, and now print only the message letting the errno and the result from the conversion routines to be propagated to the

Re: [PATCH RESEND] libv4lconvert: Fix a regression when converting from Y10B

On Wed, 18 Jun 2014 13:46:10 +0200 Hans de Goede wrote: > Hi, > > On 06/18/2014 01:43 PM, Hans de Goede wrote: > > Hi, > > > > On 06/16/2014 05:00 PM, Antonio Ospite wrote: > >> Fix a regression introduced in commit > >> efc29f1764a30808ebf7b3

Re: [PATCH RESEND] libv4lconvert: Fix a regression when converting from Y10B

On Wed, 18 Jun 2014 15:59:13 +0200 Hans de Goede wrote: > Hi, > > On 06/18/2014 03:23 PM, Antonio Ospite wrote: > > On Wed, 18 Jun 2014 13:46:10 +0200 > > Hans de Goede wrote: > > > >> Hi, > >> > >> On 06/18/2014 01:43 PM, Hans de Goe

Re: [RFC 1/2] gspca: provide a mechanism to select a specific transfer endpoint

On Thu, 19 Jun 2014 16:27:59 +0200 Hans de Goede wrote: > Hi Antonio, > > Thanks for working on this. > > On 06/04/2014 10:24 PM, Antonio Ospite wrote: > > Add a xfer_ep_index field to struct gspca_dev, and change alt_xfer() so > > that it accepts a parameter

Re: [RFC 2/2] gspca_kinect: add support for the depth stream

On Thu, 19 Jun 2014 16:35:17 +0200 Hans de Goede wrote: > Hi, > > On 06/04/2014 10:24 PM, Antonio Ospite wrote: > > Add support for the depth mode at 10bpp, use a command line parameter to > > switch mode. > > > > NOTE: this is just a proof-of-concept, the fina

[PATCH 1/2] gspca: provide a mechanism to select a specific transfer endpoint

field to struct gspca_dev, and change alt_xfer() so that it accepts a parameter which represents a specific endpoint address to look for. If a subdriver wants to specify a value for gspca_dev->xfer_ep it can do that in its sd_config() callback. Signed-off-by: Antonio Ospite --- drivers/media/

[PATCH 0/2] gspca, gspca_kinect: add support for the depth stream

Hi, here are the patches to make gspca able to deal with the Kinect depth stream at 10bpp. If anyone is really interested in the 11bpp data too, ping me. Alexander, please let us know if you can test these anytime soon. Thanks, Antonio Antonio Ospite (2): gspca: provide a mechanism to

[PATCH 2/2] gspca_kinect: add support for the depth stream

Add support for the depth stream at 10bpp, for now use a 'depth_mode' command line parameter to switch between video and depth mode. Signed-off-by: Alexander Sosna Signed-off-by: Antonio Ospite --- drivers/media/usb/gspca/kinect.c | 98 +++- 1 fi

[PATCH] gspca_stv06xx: enable button found on some Quickcam Express variant

Signed-off-by: Antonio Ospite --- drivers/media/usb/gspca/stv06xx/stv06xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/usb/gspca/stv06xx/stv06xx.c b/drivers/media/usb/gspca/stv06xx/stv06xx.c index 49d209b..6ac93d8 100644 --- a/drivers/media/usb/gspca

Re: [PATCH 1/8] get_dvb_firmware: Add firmware extractor for si2165

ksum -a all -F "#ALGONAME{i} = #CHECKSUM{i}" payload.bin Ciao, Antonio [1] http://www.jonelo.de/java/jacksum/ -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-postin

Re: [PATCH 1/8] get_dvb_firmware: Add firmware extractor for si2165

On Tue, 29 Jul 2014 07:37:44 +0200 Matthias Schwarzott wrote: > On 23.07.2014 22:10, Antonio Ospite wrote: > > On Wed, 23 Jul 2014 21:03:14 +0200 > > Matthias Schwarzott wrote: > > > > [...] > >> The crc value: > >> It protects the cont

Re: [PATCHv1 02/12] vivid.txt: add documentation for the vivid driver.

that to implement Hue support. > I don't know what your requirements are here but JFTR there is already a simplistic implementation of fixed point operations in include/linux/fixp-arith.h I used them in drivers/media/usb/gspca/ov534.c for some hue calculation. Ciao, Antonio -- Ant

Re: [PATCH 12/29] kinect: fix sparse warnings

d on why I overlooked the issue: libfreenect —which is where the code originally comes from— uses the _same_ function for cpu_to_* and *_to_cpu conversions, and this is practically OK on common architectures even though it is not semantically correct. Thanks for the fix. > > Signed-off-by

Re: [PATCH 01/12] trivial: drivers/media/usb/gspca/gspca.c: fix the indentation of a comment

On Wed, 4 Jun 2014 14:03:39 +0200 Antonio Ospite wrote: > Fix indentation of a comment, put it on the same level of the code it > refers to. > > Signed-off-by: Antonio Ospite > Cc: Hans de Goede > Cc: linux-media@vger.kernel.org Ping, I cannot see this in any upstream repos

Re: [PATCH 02/12] trivial: drivers/media/usb/gspca/gspca.h: indent with TABs, not spaces

On Wed, 4 Jun 2014 14:03:40 +0200 Antonio Ospite wrote: > Signed-off-by: Antonio Ospite > Cc: Hans de Goede > Cc: linux-media@vger.kernel.org Ping. linux-media patchwork link: https://patchwork.linuxtv.org/patch/24156/ Thanks, Antonio > --- > drivers/media/usb/gspca/gspc

Re: [PATCH/RFC 1/1] Add a libv4l plugin for Exynos4 camera

f -libv4l_exynos4_camera_la_SOURCES = libv4l-exynos4-camera.c +libv4l_exynos4_camera_la_SOURCES = libv4l-exynos4-camera.c libv4l-devconfig-parser.c libv4l_exynos4_camera_la_CPPFLAGS = -fvisibility=hidden -std=gnu99 libv4l_exynos4_camera_la_LDFLAGS = -avoid-version -module -shared -export-dynamic -lp

[PATCH] mt9m111: Call icl->reset() on mt9m111_reset().

Call icl->reset() on mt9m111_reset(). Signed-off-by: Antonio Ospite diff --git a/drivers/media/video/mt9m111.c b/drivers/media/video/mt9m111.c index c043f62..92dd7f3 100644 --- a/drivers/media/video/mt9m111.c +++ b/drivers/media/video/mt9m111.c @@ -393,6 +393,8 @@ static int mt9m111_disa

<    1   2   3