Re: [PATCH v4 5/5] drm: adv7511: Add support for i2c_new_secondary_device

On Tuesday 13 February 2018 11:18 PM, Kieran Bingham wrote: From: Kieran Bingham The ADV7511 has four 256-byte maps that can be accessed via the main I2C ports. Each map has it own I2C address and acts as a standard slave device on the I2C bus. Allow

Re: [PATCH v4 2/5] dt-bindings: adv7511: Extend bindings to allow specifying slave map addresses

On Tuesday 13 February 2018 11:18 PM, Kieran Bingham wrote: From: Kieran Bingham The ADV7511 has four 256-byte maps that can be accessed via the main I2C ports. Each map has it own I2C address and acts as a standard slave device on the I2C bus.

Re: [PATCH 2/2] drm: adv7511: Add support for i2c_new_secondary_device

Hi, On 01/22/2018 06:20 PM, Kieran Bingham wrote: The ADV7511 has four 256-byte maps that can be accessed via the main I²C ports. Each map has it own I²C address and acts as a standard slave device on the I²C bus. Allow a device tree node to override the default addresses so that address

Re: [PATCH v4] drm: bridge: synopsys/dw-hdmi: Enable cec clock

On 11/26/2017 01:48 AM, Pierre-Hugues Husson wrote: Support the "cec" optional clock. The documentation already mentions "cec" optional clock and it is used by several boards, but currently the driver doesn't enable it, thus preventing cec from working on those boards. And even worse: a

Re: [PATCH v3] drm: bridge: synopsys/dw-hdmi: Enable cec clock

Hi, On 11/20/2017 06:00 PM, Hans Verkuil wrote: I didn't see this merged for 4.15, is it too late to include this? All other changes needed to get CEC to work on rk3288 and rk3399 are all merged. Sorry for the late reply. I was out last week. Dave recently sent the second pull request for

Re: [PATCHv3 0/2] drm/bridge/adv7511: add CEC support

On 10/07/2017 04:16 PM, Hans Verkuil wrote: From: Hans Verkuil This patch series adds CEC support to the drm adv7511/adv7533 drivers. I have tested this with the Qualcomm Dragonboard C410 (adv7533 based) and the Renesas R-Car Koelsch board (adv7511 based). I only

Re: [PATCHv2 2/2] drm: adv7511/33: add HDMI CEC support

Hi Hans, On 09/19/2017 01:03 PM, Hans Verkuil wrote: From: Hans Verkuil Add support for HDMI CEC to the drm adv7511/adv7533 drivers. The CEC registers that we need to use are identical for both drivers, but they appear at different offsets in the register map. The

Re: [PATCH 0/4] drm/bridge/adv7511: add CEC support

On 08/10/2017 02:26 PM, Hans Verkuil wrote: On 10/08/17 10:49, Archit Taneja wrote: Hi Hans, On 07/30/2017 06:37 PM, Hans Verkuil wrote: From: Hans Verkuil <hans.verk...@cisco.com> This patch series adds CEC support to the drm adv7511/adv7533 drivers. I have tested this with the Qu

Re: [PATCH 0/4] drm/bridge/adv7511: add CEC support

Hi Hans, On 07/30/2017 06:37 PM, Hans Verkuil wrote: From: Hans Verkuil This patch series adds CEC support to the drm adv7511/adv7533 drivers. I have tested this with the Qualcomm Dragonboard C410 (adv7533 based) and the Renesas R-Car Koelsch board (adv7511 based).

Re: [PATCH 4/4] drm: adv7511/33: add HDMI CEC support

On 07/30/2017 06:37 PM, Hans Verkuil wrote: From: Hans Verkuil Add support for HDMI CEC to the drm adv7511/adv7533 drivers. The CEC registers that we need to use are identical for both drivers, but they appear at different offsets in the register map. Thanks for

Re: [PATCH 0/4] drm/bridge/adv7511: add CEC support

On 07/30/2017 06:37 PM, Hans Verkuil wrote: From: Hans Verkuil This patch series adds CEC support to the drm adv7511/adv7533 drivers. I have tested this with the Qualcomm Dragonboard C410 (adv7533 based) and the Renesas R-Car Koelsch board (adv7511 based). Note: the

Re: [PATCHv3 4/4] drm/bridge: dw-hdmi: remove CEC engine register definitions

On 08/03/2017 12:11 AM, Hans Verkuil wrote: From: Russell King We don't need the CEC engine register definitions, so let's remove them. Queued to drm-misc-next. Thanks, Archit Signed-off-by: Russell King Acked-by: Hans Verkuil

Re: [PATCHv3 3/4] drm/bridge: dw-hdmi: add cec driver

On 08/03/2017 12:11 AM, Hans Verkuil wrote: From: Russell King Add a CEC driver for the dw-hdmi hardware. Queued to drm-misc-next after fixing up some minor Makefile/Kconfig conflicts. Thanks, Archit Reviewed-by: Neil Armstrong

Re: [PATCHv3 07/22] staging: android: ion: Remove page faulting support

Hi, On 04/04/2017 12:27 AM, Laura Abbott wrote: The new method of syncing with dma_map means that the page faulting sync implementation is no longer applicable. Remove it. Signed-off-by: Laura Abbott --- drivers/staging/android/ion/ion.c | 117

Re: [PATCHv3 08/22] staging: android: ion: Remove crufty cache support

Hi, On 04/04/2017 12:27 AM, Laura Abbott wrote: Now that we call dma_map in the dma_buf API callbacks there is no need to use the existing cache APIs. Remove the sync ioctl and the existing bad dma_sync calls. Explicit caching can be handled with the dma_buf sync API. We could get rid of the

Re: [PATCH v5.1 0/6] drm: bridge: dw-hdmi: Add support for Custom PHYs

Hi, On 03/31/2017 07:55 PM, Neil Armstrong wrote: The Amlogic GX SoCs implements a Synopsys DesignWare HDMI TX Controller in combination with a very custom PHY. Thanks to Laurent Pinchart's changes, the HW report the following : Detected HDMI TX controller v2.01a with HDCP (meson_dw_hdmi_phy)

Re: [PATCH v3 3/6] documentation: media: Add documentation for new RGB and YUV bus formats

On 3/7/2017 10:12 PM, Neil Armstrong wrote: Add documentation for added Bus Formats to describe RGB and YUS formats used s/YUS/YUV as input to the Synopsys DesignWare HDMI TX Controller. Signed-off-by: Neil Armstrong ---

Re: [PATCH v3 2/6] media: uapi: Add RGB and YUV bus formats for Synopsys HDMI TX Controller

-by: Archit Taneja <arch...@codeaurora.org> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> --- include/uapi/linux/media-bus-format.h | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-

Re: [PATCH v3 5/6] drm: bridge: dw-hdmi: Add Documentation on supported input formats

On 3/7/2017 10:12 PM, Neil Armstrong wrote: This patch adds a new DRM documentation entry and links to the input format table added in the dw_hdmi header. Signed-off-by: Neil Armstrong --- Documentation/gpu/dw-hdmi.rst | 15 +++

Re: [RFC PATCH 00/11] Introduce writeback connectors

Hi Brian, On 10/11/2016 08:23 PM, Brian Starkey wrote: Hi, This RFC series introduces a new connector type: DRM_MODE_CONNECTOR_WRITEBACK It is a follow-on from a previous discussion: [1] Writeback connectors are used to expose the memory writeback engines found in some display controllers,

Re: [REVIEWv3 PATCH 07/13] vb2: reject output buffers with V4L2_FIELD_ALTERNATE

On Friday 11 April 2014 01:41 PM, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com This is not allowed by the spec and does in fact not make any sense. Return -EINVAL if this is the case. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Pawel Osciak pa...@osciak.com

Re: [REVIEWv3 PATCH 07/13] vb2: reject output buffers with V4L2_FIELD_ALTERNATE

On Friday 11 April 2014 02:28 PM, Hans Verkuil wrote: On 04/11/2014 10:42 AM, Archit Taneja wrote: On Friday 11 April 2014 01:41 PM, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com This is not allowed by the spec and does in fact not make any sense. Return -EINVAL

[GIT PULL for 3.15 fixes] VPE fixes

:47 +0530) Archit Taneja (9): v4l: ti-vpe: Make sure in job_ready that we have the needed number of dst_bufs v4l: ti-vpe: Use video_device_release_empty v4l: ti-vpe: Allow usage of smaller images v4l: ti-vpe

Re: [PATCH] v4l: ti-vpe: fix devm_ioremap_resource() return value checking

Hi, On Tuesday 18 March 2014 04:11 PM, Bartlomiej Zolnierkiewicz wrote: devm_ioremap_resource() returns a pointer to the remapped memory or an ERR_PTR() encoded error code on failure. Fix the checks inside csc_create() and sc_create() accordingly. Cc: Archit Taneja arc...@ti.com Cc: Hans

Re: [PATCH v4 08/14] v4l: ti-vpe: Rename csc memory resource name

Hi Kamil, On Thursday 13 March 2014 08:14 PM, Kamil Debski wrote: Hi, From: Archit Taneja [mailto:arc...@ti.com] Sent: Thursday, March 13, 2014 12:44 PM Rename the memory block resource vpe_csc to csc since it also exists within the VIP IP block. This would make the name more generic

Re: [PATCH v3 02/14] v4l: ti-vpe: register video device only when firmware is loaded

Hi, On Thursday 13 March 2014 07:59 PM, Kamil Debski wrote: Hi, From: Archit Taneja [mailto:arc...@ti.com] Sent: Thursday, March 13, 2014 1:09 PM Hi Kamil, On Thursday 13 March 2014 05:18 PM, Kamil Debski wrote: Hi Archit, From: Archit Taneja [mailto:arc...@ti.com] Sent: Tuesday, March

[PATCH v4 00/14] v4l: ti-vpe: Some VPE fixes and enhancements

of older cropping API. - Typo fix. - Some changes in patch 6/7 to support composing on the capture side of VPE. Archit Taneja (14): v4l: ti-vpe: Make sure in job_ready that we have the needed number of dst_bufs v4l: ti-vpe: register video device only when firmware is loaded v4l: ti-vpe: Use

[PATCH v4 02/14] v4l: ti-vpe: register video device only when firmware is loaded

device corresponding to it. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/vpdma.c | 8 +++-- drivers/media/platform/ti-vpe/vpdma.h | 7 +++-- drivers/media/platform/ti-vpe/vpe.c | 55 --- 3 files changed, 41 insertions(+), 29

[PATCH v4 03/14] v4l: ti-vpe: Use video_device_release_empty

currently is the helper video_device_release. This causes memory corruption, and leads to issues when we try to re-insert the vpe module. Use the video_device_release_empty helper function instead. Reviewed-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Archit Taneja arc...@ti.com --- drivers

[PATCH v4 09/14] v4l: ti-vpe: report correct capabilities in querycap

querycap currently returns V4L2_CAP_VIDEO_M2M as a capability, this should be V4L2_CAP_VIDEO_M2M_MPLANE instead, as the driver supports multiplanar formats. Reviewed-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/vpe.c | 2

[PATCH v4 13/14] v4l: ti-vpe: Set correct field parameter for output and capture buffers

or V4L2_FIELD_BOTTOM, the vb2 buf_prepare op returns an error. This ensures compliance, and that the dequeued output and captured buffers contain the field type that the driver used internally. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/vpe.c | 13 - 1 file

[PATCH v4 04/14] v4l: ti-vpe: Allow DMABUF buffer type support

to the io_modes of the vb2 output and capture queues. This allows the driver to import dma shared buffers. Reviewed-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/vpe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v4 07/14] v4l: ti-vpe: Add selection API in VPE driver

or destination dimensions change, set_srcdst_params() is called for this purpose. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/vpe.c | 150 1 file changed, 150 insertions(+) diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers

[PATCH v4 12/14] v4l: ti-vpe: zero out reserved fields in try_fmt

-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/vpe.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti-vpe/vpe.c index d7befb9..c0ae847 100644 --- a/drivers

[PATCH v4 14/14] v4l: ti-vpe: retain v4l2_buffer flags for captured buffers

Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/vpe.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti-vpe/vpe.c index 362d5be..972f43f 100644 --- a/drivers/media/platform/ti-vpe

[PATCH v4 08/14] v4l: ti-vpe: Rename csc memory resource name

Rename the memory block resource vpe_csc to csc since it also exists within the VIP IP block. This would make the name more generic, and both VPE and VIP DT nodes in the future can use it. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/csc.c | 2 +- 1 file changed

[PATCH v4 05/14] v4l: ti-vpe: Allow usage of smaller images

than 32x32 didn't make much sense, so stopped at this. Reviewed-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/vpe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/ti-vpe/vpe.c b

[PATCH v4 06/14] v4l: ti-vpe: Fix some params in VPE data descriptors

to the vpdma_add_in_dtd() helper. - Some minor changes are made to the vpdma_add_out_dtd() helper. The c_rect param is used for specifying the 'composition' target, and 'width' is added to calculate the line stride. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/vpdma.c

[PATCH v4 11/14] v4l: ti-vpe: Fix initial configuration queue data

(G_FMT) != G_FMT'. Fix the initial queue configuration such that it wouldn't need to be fixed by try_fmt. Reviewed-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/vpe.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions

[PATCH v4 10/14] v4l: ti-vpe: Use correct bus_info name for the device in querycap

The bus_info parameter in v4l2_capabilities expects a 'platform_' prefix. This wasn't done in the driver and hence was breaking compliance. Update the bus_info parameter accordingly. Reviewed-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media

Re: [PATCH v3 02/14] v4l: ti-vpe: register video device only when firmware is loaded

Hi Kamil, On Thursday 13 March 2014 05:18 PM, Kamil Debski wrote: Hi Archit, From: Archit Taneja [mailto:arc...@ti.com] Sent: Tuesday, March 11, 2014 9:34 AM vpe fops(vpe_open in particular) should be called only when VPDMA firmware is loaded. File operations on the video device are possible

[PATCH v3 00/14] v4l: ti-vpe: Some VPE fixes and enhancements

compatibility. Changes in v2: - selection API used instead of older cropping API. - Typo fix. - Some changes in patch 6/7 to support composing on the capture side of VPE. Archit Taneja (14): v4l: ti-vpe: Make sure in job_ready that we have the needed number of dst_bufs v4l: ti-vpe: register

[PATCH v3 03/14] v4l: ti-vpe: Use video_device_release_empty

currently is the helper video_device_release. This causes memory corruption, and leads to issues when we try to re-insert the vpe module. Use the video_device_release_empty helper function instead Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/vpe.c | 2 +- 1 file changed

[PATCH v3 01/14] v4l: ti-vpe: Make sure in job_ready that we have the needed number of dst_bufs

to hit the condition where we don't have any free buffers for the VPE to write on. Add the extra check in job_ready() to make sure we have the sufficient amount of destination buffers. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/vpe.c | 3 +++ 1 file changed, 3

[PATCH v3 11/14] v4l: ti-vpe: Fix initial configuration queue data

(G_FMT) != G_FMT'. Fix the initial queue configuration such that it wouldn't need to be fixed by try_fmt. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/vpe.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/ti-vpe/vpe.c

[PATCH v3 13/14] v4l: ti-vpe: Set correct field parameter for output and capture buffers

or V4L2_FIELD_BOTTOM, the vb2 buf_prepare op returns an error. This ensures compliance, and that the dequeued output and captured buffers contain the field type that the driver used internally. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/vpe.c | 13 - 1 file

[PATCH v3 07/14] v4l: ti-vpe: Add selection API in VPE driver

or destination dimensions change, set_srcdst_params() is called for this purpose. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/vpe.c | 141 1 file changed, 141 insertions(+) diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers

[PATCH v3 05/14] v4l: ti-vpe: Allow usage of smaller images

than 32x32 didn't make much sense, so stopped at this. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/vpe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti-vpe/vpe.c index 0e7573a

[PATCH v3 04/14] v4l: ti-vpe: Allow DMABUF buffer type support

to the io_modes of the vb2 output and capture queues. This allows the driver to import dma shared buffers. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/vpe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers

[PATCH v3 10/14] v4l: ti-vpe: Use correct bus_info name for the device in querycap

The bus_info parameter in v4l2_capabilities expects a 'platform_' prefix. This wasn't done in the driver and hence was breaking compliance. Update the bus_info parameter accordingly. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/vpe.c | 3 ++- 1 file changed, 2

[PATCH v3 12/14] v4l: ti-vpe: zero out reserved fields in try_fmt

-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/vpe.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti-vpe/vpe.c index 85d1122..970408a 100644 --- a/drivers/media/platform/ti-vpe/vpe.c +++ b/drivers/media

[PATCH v3 09/14] v4l: ti-vpe: report correct capabilities in querycap

querycap currently returns V4L2_CAP_VIDEO_M2M as a capability, this should be V4L2_CAP_VIDEO_M2M_MPLANE instead, as the driver supports multiplanar formats. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/vpe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH v3 14/14] v4l: ti-vpe: retain v4l2_buffer flags for captured buffers

The dequed CAPTURE_MPLANE type buffers don't contain the flags that the originally queued OUTPUT_MPLANE type buffers have. This breaks compliance. Copy the source v4l2_buffer flags to the destination v4l2_buffer flags before they are dequed. Signed-off-by: Archit Taneja arc...@ti.com

[PATCH v3 08/14] v4l: ti-vpe: Rename csc memory resource name

Rename the memory block resource vpe_csc to csc since it also exists within the VIP IP block. This would make the name more generic, and both VPE and VIP DT nodes in the future can use it. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/csc.c | 2 +- 1 file changed

[PATCH v3 02/14] v4l: ti-vpe: register video device only when firmware is loaded

device corresponding to it. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/vpdma.c | 8 +++-- drivers/media/platform/ti-vpe/vpdma.h | 7 +++-- drivers/media/platform/ti-vpe/vpe.c | 55 --- 3 files changed, 41 insertions(+), 29

[PATCH v3 06/14] v4l: ti-vpe: Fix some params in VPE data descriptors

to the vpdma_add_in_dtd() helper. - Some minor changes are made to the vpdma_add_out_dtd() helper. The c_rect param is used for specifying the 'composition' target, and 'width' is added to calculate the line stride. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/vpdma.c

Re: [PATCH v3 07/14] v4l: ti-vpe: Add selection API in VPE driver

On Tuesday 11 March 2014 05:51 PM, Hans Verkuil wrote: Hi Archit, A few small comments below... On 03/11/14 09:33, Archit Taneja wrote: Add selection ioctl ops. For VPE, cropping makes sense only for the input to VPE(or V4L2_BUF_TYPE_VIDEO_OUTPUT/MPLANE buffers) and composing makes sense only

Re: [PATCH v3 07/14] v4l: ti-vpe: Add selection API in VPE driver

On Tuesday 11 March 2014 06:19 PM, Hans Verkuil wrote: On 03/11/14 13:46, Archit Taneja wrote: On Tuesday 11 March 2014 05:51 PM, Hans Verkuil wrote: Hi Archit, A few small comments below... On 03/11/14 09:33, Archit Taneja wrote: snip Yes. If for no other reason that I plan on adding

Re: [PATCH v2 7/7] v4l: ti-vpe: Add selection API in VPE driver

Hi Hans, On Tuesday 04 March 2014 05:05 PM, Hans Verkuil wrote: On 03/04/14 12:25, Archit Taneja wrote: I had a minor question about the selection API: Are the V4L2_SET_TGT_CROP/COMPOSE_DEFAULT and the corresponding 'BOUNDS' targets supposed to be used with VIDIOC_S_SELECTION? If so, what's

Re: [PATCH v2 7/7] v4l: ti-vpe: Add selection API in VPE driver

Hi, On Friday 07 March 2014 06:29 PM, Hans Verkuil wrote: Do you think I can go ahead with posting the v3 patch set for 3.15, and work on fixing the compliance issue for the -rc fixes? It's fine to upstream this in staging, but while not all compliance errors are fixed it can't go to

Re: [PATCH v2 7/7] v4l: ti-vpe: Add selection API in VPE driver

On Friday 07 March 2014 07:02 PM, Hans Verkuil wrote: On 03/07/2014 02:22 PM, Archit Taneja wrote: Hi, On Friday 07 March 2014 06:29 PM, Hans Verkuil wrote: Do you think I can go ahead with posting the v3 patch set for 3.15, and work on fixing the compliance issue for the -rc fixes? It's

Re: [PATCH 7/7] v4l: ti-vpe: Add crop support in VPE driver

Hi, On Tuesday 04 March 2014 01:13 PM, Hans Verkuil wrote: On 03/04/2014 08:38 AM, Archit Taneja wrote: Hi Hans, On Monday 03 March 2014 01:20 PM, Hans Verkuil wrote: Hi Archit! On 03/03/2014 08:33 AM, Archit Taneja wrote: Add crop ioctl ops. For VPE, cropping only makes sense

[PATCH v2 0/7] v4l: ti-vpe: Some VPE fixes and enhancements

. Reference branch: g...@github.com:boddob/linux.git vpe_for_315 Changes in v2: - selection API used instead of older cropping API. - Typo fix. - Some changes in patch 6/7 to support composing on the capture side of VPE. Archit Taneja (7): v4l: ti-vpe: Make sure in job_ready that we have

[PATCH v2 4/7] v4l: ti-vpe: Allow DMABUF buffer type support

to the io_modes of the vb2 output and capture queues. This allows the driver to import dma shared buffers. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/vpe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers

[PATCH v2 2/7] v4l: ti-vpe: register video device only when firmware is loaded

device corresponding to it. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/vpdma.c | 8 +++-- drivers/media/platform/ti-vpe/vpdma.h | 7 +++-- drivers/media/platform/ti-vpe/vpe.c | 55 --- 3 files changed, 41 insertions(+), 29

[PATCH v2 3/7] v4l: ti-vpe: Use video_device_release_empty

currently is the helper video_device_release. This causes memory corruption, and leads to issues when we try to re-insert the vpe module. Use the video_device_release_empty helper function instead Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/vpe.c | 2 +- 1 file changed

[PATCH v2 1/7] v4l: ti-vpe: Make sure in job_ready that we have the needed number of dst_bufs

to hit the condition where we don't have any free buffers for the VPE to write on. Add the extra check in job_ready() to make sure we have the sufficient amount of destination buffers. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/vpe.c | 3 +++ 1 file changed, 3

[PATCH v2 5/7] v4l: ti-vpe: Allow usage of smaller images

than 32x32 didn't make much sense, so stopped at this. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/vpe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti-vpe/vpe.c index 915029b

[PATCH v2 7/7] v4l: ti-vpe: Add selection API in VPE driver

or destination dimensions change, set_srcdst_params() is called for this purpose. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/vpe.c | 142 1 file changed, 142 insertions(+) diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers

[PATCH v2 6/7] v4l: ti-vpe: Fix some params in VPE data descriptors

to the vpdma_add_in_dtd() helper. - Some minor changes are made to the vpdma_add_out_dtd() helper. The c_rect param is used for specifying the 'composition' target, and 'width' is added to calculate the line stride. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/vpdma.c

Re: [PATCH v2 7/7] v4l: ti-vpe: Add selection API in VPE driver

Hi, On Tuesday 04 March 2014 03:10 PM, Hans Verkuil wrote: Hi Archit, On 03/04/14 09:49, Archit Taneja wrote: Add selection ioctl ops. For VPE, cropping makes sense only for the input to VPE(or V4L2_BUF_TYPE_VIDEO_OUTPUT/MPLANE buffers) and composing makes sense only for the output of VPE

Re: [PATCH 7/7] v4l: ti-vpe: Add crop support in VPE driver

Hi, On Monday 03 March 2014 01:20 PM, Hans Verkuil wrote: Hi Archit! On 03/03/2014 08:33 AM, Archit Taneja wrote: Add crop ioctl ops. For VPE, cropping only makes sense with the input to VPE, or the V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE buffer type. For the CAPTURE type, a S_CROP ioctl results

Re: [PATCH 7/7] v4l: ti-vpe: Add crop support in VPE driver

Hi, On Monday 03 March 2014 05:51 PM, Kamil Debski wrote: Hi Archit, From: Archit Taneja [mailto:arc...@ti.com] Sent: Monday, March 03, 2014 9:26 AM Hi, On Monday 03 March 2014 01:20 PM, Hans Verkuil wrote: Hi Archit! On 03/03/2014 08:33 AM, Archit Taneja wrote: Add crop ioctl ops

Re: [PATCH 5/7] v4l: ti-vpe: Allow usage of smaller images

Hi, On Monday 03 March 2014 05:44 PM, Kamil Debski wrote: Hi Archit, From: Archit Taneja [mailto:arc...@ti.com] Sent: Monday, March 03, 2014 8:33 AM The minimum width and height for VPE input/output was kept as 128 pixels. VPE doesn't have a constraint on the image height, it requires

Re: [PATCH 7/7] v4l: ti-vpe: Add crop support in VPE driver

Hi Hans, On Monday 03 March 2014 01:20 PM, Hans Verkuil wrote: Hi Archit! On 03/03/2014 08:33 AM, Archit Taneja wrote: Add crop ioctl ops. For VPE, cropping only makes sense with the input to VPE, or the V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE buffer type. For the CAPTURE type, a S_CROP ioctl

[PATCH 3/7] v4l: ti-vpe: Use video_device_release_empty

currently is the helper video_device_release. This causes memory corruption, and leads to issues when we try to re-insert the vpe module. Use the video_device_release_empty helper function instead Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/vpe.c | 2 +- 1 file changed

[PATCH 1/7] v4l: ti-vpe: Make sure in job_ready that we have the needed number of dst_bufs

to hit the condition where we don't have any free buffers for the VPE to write on. Add the extra check in job_ready() to make sure we have the sufficient amount of destination buffers. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/vpe.c | 3 +++ 1 file changed, 3

[PATCH 4/7] v4l: ti-vpe: Allow DMABUF buffer type support

to the io_modes of the vb2 output and capture queues. This allows the driver to import dma shared buffers. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/vpe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers

[PATCH 5/7] v4l: ti-vpe: Allow usage of smaller images

32x32 didn't make much sense, so stopped at this. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/vpe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti-vpe/vpe.c index 915029b

[PATCH 6/7] v4l: ti-vpe: Fix some params in VPE data descriptors

to the vpdma_add_in_dtd() helper. - Some minor changes are made to the vpdma_add_out_dtd() helper. The c_rect param is removed since cropping isn't possible for outbound data, and 'width' is added to calculate the line stride. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe

[PATCH 2/7] v4l: ti-vpe: register video device only when firmware is loaded

device corresponding to it. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/vpdma.c | 8 +++-- drivers/media/platform/ti-vpe/vpdma.h | 7 +++-- drivers/media/platform/ti-vpe/vpe.c | 55 --- 3 files changed, 41 insertions(+), 29

[PATCH 7/7] v4l: ti-vpe: Add crop support in VPE driver

the crop successfully should result in re-configuration of those registers which are affected when either source or destination dimensions change, set_srcdst_params() is called for this purpose. Some standard crop parameter checks are done in __vpe_try_crop(). Signed-off-by: Archit Taneja arc

[PATCH 0/7] v4l: ti-vpe: Some VPE fixes and enhancements

branch: g...@github.com:boddob/linux.git vpe_for_315 Archit Taneja (7): v4l: ti-vpe: Make sure in job_ready that we have the needed number of dst_bufs v4l: ti-vpe: register video device only when firmware is loaded v4l: ti-vpe: Use video_device_release_empty v4l: ti-vpe: Allow DMABUF

Re: [PATCH 0/8] v4l: ti-vpe: Add support for scaling and color conversion

Hi Hans, On Tuesday 17 December 2013 01:30 PM, Hans Verkuil wrote: On 12/12/2013 09:35 AM, Archit Taneja wrote: The VPE and VIP IPs in DRA7x contain common scaler and color conversion hardware blocks. We create libraries for these components such that the vpe driver and the vip driver

Re: [PATCH 0/8] v4l: ti-vpe: Add support for scaling and color conversion

Hi, On Tuesday 17 December 2013 05:19 PM, Hans Verkuil wrote: On 12/17/13 12:19, Archit Taneja wrote: Hi Hans, On Tuesday 17 December 2013 01:30 PM, Hans Verkuil wrote: On 12/12/2013 09:35 AM, Archit Taneja wrote: The VPE and VIP IPs in DRA7x contain common scaler and color conversion

[PATCH 7/8] v4l: ti-vpe: enable CSC support for VPE

. This requires configuring the output data descriptors differently. Also, make the default colorspace V4L2_COLORSPACE_SMPTE170M as that resembles the Standard Definition colorspace more closely. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/vpe.c | 95

[PATCH 1/8] v4l: ti-vpe: create a scaler block library

relative to the sub-block, and not the VPE IP as a whole. In order for VPDMA to configure registers, it requires it's offset from the top level VPE module. A macro called GET_OFFSET_TOP is added to return the offset of the register relative to the VPE IP. Signed-off-by: Archit Taneja arc...@ti.com

[PATCH 5/8] v4l: ti-vpe: create a color space converter block library

to get the CSC register offset relative to the VPE IP in the vpe driver. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/Makefile | 2 +- drivers/media/platform/ti-vpe/csc.c | 76 drivers/media/platform/ti-vpe/csc.h | 65

[PATCH 8/8] v4l: ti-vpe: Add a type specifier to describe vpdma data format type

case, and possibly more cases in the future. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/vpdma.c | 36 +-- drivers/media/platform/ti-vpe/vpdma.h | 7 +++ 2 files changed, 41 insertions(+), 2 deletions(-) diff --git a/drivers/media

[PATCH 4/8] v4l: ti-vpe: enable basic scaler support

-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/sc.c | 132 ++-- drivers/media/platform/ti-vpe/sc.h | 4 +- drivers/media/platform/ti-vpe/vpe.c | 24 +-- 3 files changed, 149 insertions(+), 11 deletions(-) diff --git a/drivers/media

[PATCH 0/8] v4l: ti-vpe: Add support for scaling and color conversion

on the branch: git://linuxtv.org/media_tree.git master Archit Taneja (8): v4l: ti-vpe: create a scaler block library v4l: ti-vpe: support loading of scaler coefficients v4l: ti-vpe: make vpe driver load scaler coefficients v4l: ti-vpe: enable basic scaler support v4l: ti-vpe: create a color space

[PATCH 3/8] v4l: ti-vpe: make vpe driver load scaler coefficients

if there isn't a need to re-load coefficients into SC. This comes helps unnecessary re-loading of the coefficients when we switch back and forth between vpe contexts. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/vpe.c | 47 - 1 file

[PATCH 6/8] v4l: ti-vpe: Add helper to perform color conversion

for the user to specify the range needed. Not sure if there is a generic control ioctl for this already? Signed-off-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/csc.c | 120 drivers/media/platform/ti-vpe/csc.h | 3 + 2 files changed, 123 insertions

Re: [PATCH 6/6] experimental: arm: dts: dra7xx: Add a DT node for VPE

Hi Laurent, On Friday 09 August 2013 03:41 AM, Laurent Pinchart wrote: Hi Archit, Thank you for the patch. On Friday 02 August 2013 19:33:43 Archit Taneja wrote: Add a DT node for VPE in dra7.dtsi. This is experimental because we might need to split the VPE address space a bit more, and also

[PATCH 2/2] v4l: ti-vpe: make sure VPDMA line stride constraints are met

-by: Archit Taneja arc...@ti.com --- drivers/media/platform/ti-vpe/vpdma.c | 4 +-- drivers/media/platform/ti-vpe/vpdma.h | 5 +++- drivers/media/platform/ti-vpe/vpe.c | 53 ++- 3 files changed, 46 insertions(+), 16 deletions(-) diff --git a/drivers/media/platform

[PATCH 0/2] v4l: ti-vpe: Some VPE fixes

in for the 3.13-rc fixes. Archit Taneja (2): v4l: ti-vpe: Fix the data_type value for UYVY VPDMA format v4l: ti-vpe: make sure VPDMA line stride constraints are met drivers/media/platform/ti-vpe/vpdma.c | 4 +-- drivers/media/platform/ti-vpe/vpdma.h | 5 ++- drivers/media/platform/ti

[PATCH 1/2] v4l: ti-vpe: Fix the data_type value for UYVY VPDMA format

The data_type value to be programmed in the data descriptors to fetch/write a UYVY buffer was not mentioned correctly in the older DRA7x documentation. This caused VPE to fail with UYVY color formats. Update the data_type value to fix functionality when UYVY format is used. Signed-off-by: Archit

Re: [patch] [media] v4l: ti-vpe: checking for IS_ERR() instead of NULL

Hi Dan, On Friday 08 November 2013 03:31 PM, Dan Carpenter wrote: devm_ioremap() returns NULL on error, it doesn't return an ERR_PTR. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti-vpe/vpe.c index

Re: [PATCH -next] [media] v4l: ti-vpe: fix return value check in vpe_probe()

. Reviewed-by: Archit Taneja arc...@ti.com Thanks, Archit Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/media/platform/ti-vpe/vpe.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti-vpe

Re: [PATCH -next] [media] v4l: ti-vpe: fix return value check in vpe_probe()

. Reviewed-by: Archit Taneja arc...@ti.com Thanks, Archit Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/media/platform/ti-vpe/vpe.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti-vpe

  1   2   3   >