The goto needs to be moved after the assignment.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/dvb/frontends/dib7000p.c
b/drivers/media/dvb/frontends/dib7000p.c
index a64a538..9c40267 100644
--- a/drivers/media/dvb/frontends/dib7000p.c
+++ b/drivers/media/dvb/frontends/dib7000p.c
On Thu, Aug 04, 2011 at 12:21:29PM +0200, Florian Mickler wrote:
> Mauro, what to do?
Apply the fix which Tino tested, perhaps? :P (obviously).
The bug is present in 3.0 so it should be tagged for stable as well.
regards,
dan carpenter
--
To unsubscribe from this list: send the l
'!' has higher precedence than '&' so we need parenthesis here.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/video/pwc/pwc-v4l.c
b/drivers/media/video/pwc/pwc-v4l.c
index e9a0e94..8c70e64 100644
--- a/drivers/media/video/pwc/pwc-v4l.c
+++ b/drivers/m
We dereference "buf" on the line before so if it were NULL here we
would have OOPsed earlier. Also list_entry() never returns NULL.
And finally, we handled the situation where the list is empty
earlier in the function.
So this test isn't needed and I've removed it.
Signed-o
In the original code, if the allocation failed we dereference "rr3"
when it was NULL.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/rc/redrat3.c b/drivers/media/rc/redrat3.c
index 5147767..4582ef7 100644
--- a/drivers/media/rc/redrat3.c
+++ b/drivers/media/rc/redrat3.c
If change_protocol() fails and we goto out_raw, then it calls unlock
twice. I noticed that the other time we called change_protocol() we
held the &dev->lock, so I changed it to hold it here too.
Signed-off-by: Dan Carpenter
---
Compile tested only.
diff --git a/drivers/media/rc/rc-m
If the tvp->cmd == DTV_MAX_COMMAND then we read past the end of the
array.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/dvb/dvb-core/dvb_frontend.c
b/drivers/media/dvb/dvb-core/dvb_frontend.c
index 9827804..607e293 100644
--- a/drivers/media/dvb/dvb-core/dvb_frontend.c
+++ b/driv
20r_core.c:743:28: error: bad constant
expression
drivers/media/dvb/frontends/cxd2820r_core.c:748:32: error: cannot size
expression
drivers/media/dvb/frontends/cxd2820r_core.c:762:31: error: cannot size
expression
CC [M] drivers/media/dvb/frontends/cxd2820r_core.o
regards,
dan carpe
;real bug" I
> am missing there? (Or did I already miss a patch posted to linux-media
> addressing it?)
>
My laptop was stolen so I can't review code for the next couple weeks.
I remember that I thought your patch looked correct, but I was hoping that
Dmitri would Ack it.
r
On Fri, Mar 25, 2011 at 11:33:36PM -0500, Mike Isely wrote:
>
> Acked-By: Mike Isely
>
I'd need to reformat this one to get it to apply... :/ It doesn't
actually fix the bug so it's not worth it.
regards,
dan carpenter
--
To unsubscribe from this list: send the line
Using !0 is less readable than just saying 1.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/video/pvrusb2/pvrusb2-std.c
b/drivers/media/video/pvrusb2/pvrusb2-std.c
index 9bebc08..ca4f67b 100644
--- a/drivers/media/video/pvrusb2/pvrusb2-std.c
+++ b/drivers/media/video/pvrusb2/pvrusb2
The generic_standards_cnt define is only used in one place and it's
more readable to just call ARRAY_SIZE(generic_standards) directly.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/video/pvrusb2/pvrusb2-std.c
b/drivers/media/video/pvrusb2/pvrusb2-std.c
index d5a679f..9bebc08 1
This patch renames some variables to bring them more in line with
kernel CodingStyle.
arrPtr => arr
arrSize => arr_size
bufPtr => buf
bufSize => buf_size
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/video/pvrusb2/pvrusb2-std.c
b/drivers/media/video/pvrusb2/pvrusb2
This function returns NULL on failure so lets do that if kzalloc()
fails. There is a separate problem that the caller for this function
doesn't check for errors...
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/video/pvrusb2/pvrusb2-std.c
b/drivers/media/video/pvrusb2/pvrusb2-
* Include instead of .
* Remove unneeded curly braces.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/video/pvrusb2/pvrusb2-std.c
b/drivers/media/video/pvrusb2/pvrusb2-std.c
index a5d4867..370a9ab 100644
--- a/drivers/media/video/pvrusb2/pvrusb2-std.c
+++ b/drivers/media/video
"{" char was on its own line but it
wasn't the start of a function.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/video/pvrusb2/pvrusb2-std.c
b/drivers/media/video/pvrusb2/pvrusb2-std.c
index ca9f83a..a5d4867 100644
--- a/drivers/media/video/pvrusb2/pvrusb2-std.c
+++ b/driv
NULL;
> unsigned int linewidth;
>
This looks like a real bug versus just a GCC warning. It was introduced
in 8aff8ba95155df "[media] tm6000: add radio support to the driver".
I've added Dmitri to the CC list.
regards,
dan carpenter
--
To unsubscribe from this list:
The CellsCoeffs arrays are [3][6][5] not [2][6][5].
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/dvb/frontends/stv0367.c
b/drivers/media/dvb/frontends/stv0367.c
index 7117ce9..ec9de40 100644
--- a/drivers/media/dvb/frontends/stv0367.c
+++ b/drivers/media/dvb/frontends/stv0367.c
We use err to store negative error codes so it should be signed. And
if we return an error from stv0367_get_tuner_freq() that needs to be
handled properly as well. (param->frequency is a u32).
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/dvb/frontends/stv0367.c
b/drivers/media/
an additional leak that I missed in the
first version of this patch.
Signed-off-by: Dan Carpenter
---
v2: Fix the leak Oliver noticed.
diff --git a/drivers/media/dvb/frontends/stv090x.c
b/drivers/media/dvb/frontends/stv090x.c
index d3362d0..41d0f0a 100644
--- a/drivers/media/dvb/fronte
kmalloc() can fail so check whether state->internal is NULL.
append_internal() can return NULL on allocation failures so check that.
Also if we hit the error condition later in the function then there is
a memory leak and we need to call remove_dev() to fix it.
Signed-off-by: Dan Carpen
r of years ago) being told that for things like kmalloc,
> the proper test was !x, not x == NULL.
>
It was Al Viro who said that. Here's the link.
http://lwn.net/Articles/331593/
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe
dib9000_mbx_send_attr() returns an int. It doesn't work to save
negative error codes in an unsigned char, so I've made "ret" an int
type.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/dvb/frontends/dib9000.c
b/drivers/media/dvb/frontends/dib9000.c
index 43fb6e4..
kfree(state) if fe allocation fails.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/dvb/frontends/dib8000.c
b/drivers/media/dvb/frontends/dib8000.c
index 3e20aa8..c1c3e26 100644
--- a/drivers/media/dvb/frontends/dib8000.c
+++ b/drivers/media/dvb/frontends/dib8000.c
@@ -2514,7 +2514,7
info->num comes from the user. It's type int. If the user passes
in a negative value that would cause memory corruption.
Signed-off-by: Dan Carpenter
---
V2: change the check instead of making num and unsigned int
V3: white space changes
diff --git a/drivers/media/dvb/ttpci/av7110
to
an unsigned int in the userspace API? Who would notice? (I'm still
quite a newbie at system programming).
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordo
info->num comes from the user. It's type int. If the user passes
in a negative value that would cause memory corruption.
Signed-off-by: Dan Carpenter
---
V2: change the check instead of making num and unsigned int
diff --git a/drivers/media/dvb/ttpci/av7110_ca.c
b/drivers/media/d
return -EINVAL;
282 av7110->ci_slot[info->num].num = info->num;
Let's just make it unsigned.
Signed-off-by: Dan Carpenter
---
Compile tested.
diff --git a/include/linux/dvb/ca.h b/include/linux/dvb/ca.h
index c18537f..647015e 100644
--- a/include/linux/dvb/ca.h
+++
u meant?
> >
> >Finn
> >
> >> #define EEPROM_SW_AD_MASK 0x0300
> >> #define EEPROM_SW_AD_ENABLE 0x0100
> >>
> >>
> >
>
> no! I changed it to disabled to make it proper..
Finn is obviously right
On Fri, Dec 31, 2010 at 06:17:58AM -0800, Justin P. Mattock wrote:
> >Wrong: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
> >
> >Right: [PATCH 02/15] spi/dw_spi: Typo change diable to disable
> >
> >regards,
> >dan carpenter
> >
d code and
> forgot)
This is really just defensiveness and random grumbling and grumpiness on
my part, but one reason I may have missed the first patch is because
your subject lines are crap.
Wrong: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
Right: [PATCH 02/15] spi
ou missed one from this file:
/* Set the interrupt mask, for poll mode just diable all int */
^^
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to maj
Bitwise negate was intended here. INPUT_SEL_MASK is 0x30.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/video/cx231xx/cx231xx-avcore.c
b/drivers/media/video/cx231xx/cx231xx-avcore.c
index d52955c..c53e972 100644
--- a/drivers/media/video/cx231xx/cx231xx-avcore.c
+++ b/drivers/media
The original code compared "saddr_len" with zero twice in a nonsensical
way. I asked the list, and Andy Walls and Sri Deevi say that the second
check should be if "saddr_len == 1".
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/video/cx231xx/cx231xx-core.c
b
ta()
cx231xx_write_i2c_master()
cx231xx_read_i2c_master()
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
e if (saddr_len == 0)
1645 saddr &= 0xff;
We check "saddr_len == 0" twice which doesn't make sense. I'm not sure
what the correct fix is though. It's been this way since the driver was
merged.
regards,
dan carpenter
--
To unsubscribe from this lis
This is a copy and paste error. It should be using sizeof(cap->driver)
instead of sizeof(cap->card).
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/video/timblogiw.c b/drivers/media/video/timblogiw.c
index cf48aa9..ef1b7a5 100644
--- a/drivers/media/video/timblogiw.c
+++ b/d
if it's
related at all to the other bug you noticed but it can't hurt.
regards,
dan carpenter
>From erro...@gmail.com Thu Nov 18 07:19:15 2010
Date: Thu, 18 Nov 2010 06:55:59 +0300
From: Dan Carpenter
To: Mauro Carvalho Chehab
Cc: linux-media@vger.kernel.org, kernel-janit...@vger.k
e writing to it anyway.
Addresses: https://bugzilla.kernel.org/show_bug.cgi?id=24602
Signed-off-by: Dan Carpenter
---
Sergej could you test this one?
diff --git a/drivers/media/video/bt8xx/bttv-driver.c
b/drivers/media/video/bt8xx/bttv-driver.c
index a529619..6c8f4b0 100644
--- a/drivers/media/video/bt8xx/bttv
b
I'm taking off for the weekend, so I won't be able to look at this
more until Monday. See you then. :)
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo
zr->frame_num is a counter and && was intended here instead of &.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/video/zoran/zoran_device.c
b/drivers/media/video/zoran/zoran_device.c
index b02007e..e8a2784 100644
--- a/drivers/media/video/zoran/zoran_device.c
+++ b/driv
Hi Sergej,
I'm hoping this patch will take care of the bug you reported:
https://bugzilla.kernel.org/show_bug.cgi?id=24602
Please try it out and let me know. I'll resend with a proper
signed-off-by if it fixes the problem. (I don't have the hardware to
test this myself).
diff --git a/drivers/
izeof(int) != 0)
Wait, what? We just checked this a couple lines before.
The rest of the patch is right and a clever catch. It would affect
x86_64 systems and not i386. This doesn't have security implications
does it? You'd just catch the kmalloc() stack trace for insanely large
a
list_first_entry() always returns non-null here. I think the intent was
to test whether there were any entries in the used list.
Signed-off-by: Dan Carpenter
---
I don't have this hardware so I can't test this. Please check
carefully.
diff --git a/drivers/media/video/saa7164/saa7164
The lock isn't held here and doesn't need to be unlocked. The code has
been like this since the driver was merged.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/video/cx231xx/cx231xx-cards.c
b/drivers/media/video/cx231xx/cx231xx-cards.c
index 56c2d81..b7b905f 100644
---
There is a missing unlock here. This was introduced as part of BKL
removal in c37db91fd0d4 "V4L/DVB: bttv: fix driver lock and remove
explicit calls to BKL"
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/video/bt8xx/bttv-driver.c
b/drivers/media/video/bt8xx/bttv-driv
we go though that path if the
length is invalid now, there was another debug print that I removed.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/IR/lirc_dev.c b/drivers/media/IR/lirc_dev.c
index fbca94f..6b9fc74 100644
--- a/drivers/media/IR/lirc_dev.c
+++ b/drivers/media/IR/
:27:got int ( extern [toplevel] *
)( ... )
Signed-off-by: Dan Carpenter
diff --git a/include/media/lirc_dev.h b/include/media/lirc_dev.h
index 54780a5..630e702 100644
--- a/include/media/lirc_dev.h
+++ b/include/media/lirc_dev.h
@@ -217,9 +217,9 @@ int lirc_dev_fop_open(struct inode *inode
We shouldn't unlock here. I think this was a cut and paste error.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/IR/lirc_dev.c b/drivers/media/IR/lirc_dev.c
index 8418b14..8ab9d87 100644
--- a/drivers/media/IR/lirc_dev.c
+++ b/drivers/media/IR/lirc_dev.c
@@ -522,10 +522,8 @@ uns
rs.
The ->name gets set in v4l2_capability() and it always is less than 16
characters so we can easily make the buffer smaller.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/video/saa7164/saa7164.h
b/drivers/media/video/saa7164/saa7164.h
index 1d9c5cb..8b3e844 100644
--- a/drivers/media/video/s
On Fri, Oct 22, 2010 at 09:10:57AM +0200, Sylwester Nawrocki wrote:
> > -Original Message-
> > From: Dan Carpenter [mailto:erro...@gmail.com]
> > Sent: Thursday, October 21, 2010 9:24 PM
> > To: Mauro Carvalho Chehab
> > Cc: Kyungmin Park; Sylwester Nawrocki;
eeds a separate patch so I could handle it and add you
> as reported by it is OK.
>
I thought it was probably a merge conflict. Thanks for taking care of
this.
regards,
dan carpenter
> Regards,
> Sylwester
>
> > ret = fimc_register_m2m_device(fimc);
> > if
’:
drivers/media/video/s5p-fimc/fimc-core.c:286:
error: ‘TASK_NORMAL’ undeclared (first use in this function)
Signed-off-by: Dan Carpenter
---
Compile tested only. :P
diff --git a/drivers/media/video/s5p-fimc/fimc-core.h
b/drivers/media/video/s5p
These are signed so instead of being 1 and 0 as intended they are -1 and
0. It doesn't cause a bug in the current code but Sparse warns about it:
drivers/media/video/s5p-fimc/fimc-core.h:226:28:
error: dubious one-bit signed bitfield
Signed-off-by: Dan Carpenter
diff --git a/dr
There was an unlock missing if kzalloc() failed.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/video/s5p-fimc/fimc-core.c
b/drivers/media/video/s5p-fimc/fimc-core.c
index 1802701..8335045 100644
--- a/drivers/media/video/s5p-fimc/fimc-core.c
+++ b/drivers/media/video/s5p-fimc/fimc
Fixes a gcc warning:
drivers/media/video/cx88/cx88-video.c:772:
warning: ‘core’ may be used uninitialized in this function
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/video/cx88/cx88-video.c
b/drivers/media/video/cx88/cx88-video.c
index 19c64a7..c19ec71 100644
--- a
This was supposed to be an unlock on the error path.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/video/cx231xx/cx231xx-i2c.c
b/drivers/media/video/cx231xx/cx231xx-i2c.c
index cce74e5..8356706 100644
--- a/drivers/media/video/cx231xx/cx231xx-i2c.c
+++ b/drivers/media/video/cx231xx
original code had a deadline of 1.005 seconds and the new code has a
deadline of .065 seconds.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/IR/streamzap.c b/drivers/media/IR/streamzap.c
index 2cf57e6..d5d3cee 100644
--- a/drivers/media/IR/streamzap.c
+++ b/drivers/media/IR/streamzap.c
Add a check after the for loops to see if we found what we were looking
for or if we reached the end of the list.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/video/saa7134/saa7134-video.c
b/drivers/media/video/saa7134/saa7134-video.c
index 45f0ac8..24c3a78 100644
--- a/drivers
at lead to this issue in
the first place.)
There is only one caller for this function and it passes non-NULL
pointers, so this is essentially a cleanup rather than a bugfix.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/video/saa7164/saa7164-buffer.c
b/drivers/media/video/saa7164
We dereference "maskptr" unconditionally at the start of the function
and also inside the call to parse_tlist() towards the end of the
function. This function is called from store_val_any() and it always
passes a non-NULL pointer.
Signed-off-by: Dan Carpenter
diff --git a/drivers/m
"fw" is always a non-NULL pointer at this point, and anyway
release_firmware() accepts NULL pointers.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/dvb/dvb-usb/opera1.c
b/drivers/media/dvb/dvb-usb/opera1.c
index 6b22ec6..f896337 100644
--- a/drivers/media/dvb/dvb-usb/oper
On Thu, Aug 12, 2010 at 05:35:04PM +0300, Maxim Levitsky wrote:
> On Thu, 2010-08-12 at 09:46 +0200, Dan Carpenter wrote:
> > There were a couple issues here. If the allocation failed for "dev"
> > then it would lead to a NULL dereference. If request_irq() or
>
The original code dereferenced ir->raw after freeing it and setting it
to NULL.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/IR/ir-raw-event.c b/drivers/media/IR/ir-raw-event.c
index 43094e7..8e0e1b1 100644
--- a/drivers/media/IR/ir-raw-event.c
+++ b/drivers/media/IR/ir-raw-even
There were a couple issues here. If the allocation failed for "dev"
then it would lead to a NULL dereference. If request_irq() or
request_region() failed it would release the irq and the region even
though they were not successfully aquired.
Signed-off-by: Dan Carpenter
diff --git
If we return directly here then we miss out on some mutex_unlock()s
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/video/s5p-fimc/fimc-core.c
b/drivers/media/video/s5p-fimc/fimc-core.c
index b151c7b..1beb226 100644
--- a/drivers/media/video/s5p-fimc/fimc-core.c
+++ b/drivers/media
"ir_dev->props" can be NULL. We only use raw mode if "ir_dev->props" is
non-NULL and "ir_dev->props->driver_type == RC_DRIVER_IR_RAW".
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/IR/ir-keytable.c b/drivers/media/IR/ir-keytable.c
index 15a0
On Fri, Jul 23, 2010 at 07:46:47AM -0400, Andy Walls wrote:
> On Fri, 2010-07-23 at 12:12 +0200, Dan Carpenter wrote:
> > In ivtvfb_callback_cleanup() we dereference "itv" before checking that
> > it's NULL. "itv" is assigned with container_of() which basic
idered adding a check for v4l2_dev, but I looked at the code and I
don't think that can be NULL either.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/video/ivtv/ivtvfb.c
b/drivers/media/video/ivtv/ivtvfb.c
index 2c2d862..be03a71 100644
--- a/drivers/media/video/ivtv/ivtvfb.c
+++ b/dri
This function has sanity checks to make sure that "dev" is non-null. I
moved the dereference down below the checks. In the current code "dev"
is never actually null.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/video/au0828/au0828-video.c
b/drivers/media
There is a typo here. We meant to test "rbuf" instead of "drv". We
already tested "drv" earlier.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/IR/ir-lirc-codec.c b/drivers/media/IR/ir-lirc-codec.c
index 178bc5b..87e 100644
--- a/drivers/media/IR
. op->init() doesn't need to be
checked because we assumed it was non-null in the other function and
in fact it always is non-null with the current code. I removed these
uneeded checks because it made writing this patch slightly simpler.
Signed-off-by: Dan Carpenter
diff --git a/dri
videobuf_dvb_register_bus() returns negative error codes on failure. This
was introduced in e4425eab6b2: "V4L/DVB: cx23885: Check register errors".
Signed-off-by: Dan Carpenter
---
I don't have the hardware to test this, but it looks reversed.
diff --git a/drivers/media/video/
copy_to_user() returns the number of bytes remaining to be copied which
isn't the right thing to return here. The comments say that these
functions in dvb_ca_en50221.c should return the number of bytes copied or
an error return. I've changed it to return -EFAULT.
Signed-off-by: Dan
I figured if it was in the original code, it was probably OK to leave it.
But I now recognize this as pure laziness on my part and I appologize.
Twenty lashes for me and all that. Fixed patch coming up. ;)
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscrib
copy_to_user() returns the number of bytes remaining to be copied which
isn't the right thing to return here. The comments say that these
functions in dvb_ca_en50221.c should return the number of bytes copied or
an error return. I've changed it to return -EFAULT.
Signed-off-by: Dan
copy_to/from_user() returns the number of bytes remaining to be copied
but the code here was testing for negative returns. I modified it to
return -EFAULT. These functions are called from si4713_s_ext_ctrls() and
that only tests for negative error codes.
Signed-off-by: Dan Carpenter
diff
This is just a cleanup patch. We never use the "udev" variable so I
have removed it.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/video/cpia_usb.c b/drivers/media/video/cpia_usb.c
index ef1f893..58d193f 100644
--- a/drivers/media/video/cpia_usb.c
+++ b/drivers/media/video/
I started fixing one or two lines, but after a while I got into a groove
and started changing everything. I left the lines longer than 80
characters because that seemed to be the style in this file.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/dvb/dvb-usb/dvb-usb-init.c
b/drivers
ice.
I have added a comment and removed the unneeded null check.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/dvb/dvb-usb/anysee.c
b/drivers/media/dvb/dvb-usb/anysee.c
index faca1ad..aa5c7d5 100644
--- a/drivers/media/dvb/dvb-usb/anysee.c
+++ b/drivers/media/dvb/dvb-usb/anysee
On Mon, May 31, 2010 at 06:22:49PM +0300, Antti Palosaari wrote:
> Terve Dan,
>
> On 05/31/2010 06:09 PM, Dan Carpenter wrote:
>> Hi I'm going through some smatch stuff and I had a question.
>>
>> drivers/media/dvb/dvb-usb/anysee.c +482 anysee_probe(30)
>>
o an oops here.
478 alt->desc.bAlternateSetting);
I'm not sure how to fix this.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
The problem is that dprintk() dereferences "dev" which is null here.
The i2cdprintk() uses "ir" so that's OK.
Also Jean Delvare pointed out a typo in the comment so we may as well
fix that.
Signed-off-by: Dan Carpenter
Acked-by: Jean Delvare
---
v2: Jean Delvare sugges
The problem is that dprintk() dereferences "dev" which is null here.
The i2cdprintk() uses "ir" so that's OK.
Signed-off-by: Dan Carpenter
---
v2: Jean Delvare suggested that I use i2cdprintk() instead of modifying
dprintk().
v3: V2 had a bonus cleanup that I remo
The original code had two break statements in a row.
Signed-off-by: Dan Carpenter
---
v3: Put this in a seperate patch.
diff --git a/drivers/media/video/saa7134/saa7134-input.c
b/drivers/media/video/saa7134/saa7134-input.c
index e5565e2..7691bf2 100644
--- a/drivers/media/video/saa7134/saa7134
The problem is that dprintk() dereferences "dev" which is null here.
The i2cdprintk() uses "ir" so that's OK.
Also removed a duplicated break statement.
Signed-off-by: Dan Carpenter
---
v2: Jean Delvare suggested that I use i2cdprintk() instead of modifying
dprintk
I modified the dprintk and i2cdprintk macros to handle null dev and ir
pointers. There are two couple places that call dprintk() when "dev" is
null. One is in get_key_msi_tvanywhere_plus() and the other is in
get_key_flydvb_trio().
Signed-off-by: Dan Carpenter
diff --git a/dri
The "dev" variable is used as a list cursor in a list_for_each_entry()
loop and can never be null here so I removed the check.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/video/em28xx/em28xx-core.c
b/drivers/media/video/em28xx/em28xx-core.c
index 331e1ca..44c63cb 10
y you can fold it into
your patch?
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/cx25821/cx25821-medusa-video.c
b/drivers/staging/cx25821/cx25821-medusa-video.c
index 7545314..34616dc 100644
--- a/drivers/staging/cx25821/cx25821-medusa-video.c
+++ b/drivers/staging/cx25821/cx258
ideo_init()"
I guess this is going through the V4L/DVB so it needs to be reverted
there as well as in the -staging tree.
Sorry for the inconvenience.
regards,
dan carpenter
PS. The correct version is: 423f5c0d016 "V4L/DVB (13955): cx25821: fix
double unlock in medusa_video_init()".
The original code didn't handle the case where vdev was not found so I
added a check for that.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/video/s2255drv.c b/drivers/media/video/s2255drv.c
index ac9c40c..1f9a49e 100644
--- a/drivers/media/video/s2255drv.c
+++ b/drivers/media/
My concern initially was we dereference "dev" in the parameter list to
s2255_dev_err() but it turns out that code path is never used.
The s2255_stop_readpipe() is only called from one place and "dev" is
never null. So this patch just removes the whole condition here.
We dereference "ov" unconditionally throughout the function so there is
no way it can be NULL here. This code has been around for ages so if
it were possible for "ov" to be NULL someone would have complained.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/vid
We dereferenced "ctx" on the error path.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/video/mem2mem_testdev.c
b/drivers/media/video/mem2mem_testdev.c
index baf211b..b161d26 100644
--- a/drivers/media/video/mem2mem_testdev.c
+++ b/drivers/media/video/mem2mem_testdev.c
The "stv6110x" is NULL so we can just return directly without calling
kfree(). Also I changed the printk() to make checkpatch.pl happy.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/dvb/frontends/stv6110x.c
b/drivers/media/dvb/frontends/stv6110x.c
index 2f9cd24..42591ce 10
We can't return here directly, we need to unlock the event_lock first.
This was introduced in: edeada2cde "V4L/DVB: input: Add support for
EVIO[CS]GKEYCODEBIG"
Signed-off-by: Dan Carpenter
diff --git a/drivers/input/input.c b/drivers/input/input.c
index e623edf..7c3fc5e 10064
nel_key_table[i % IMON_KEY_RELEASE_OFFSET].keycode;
> + keycode = imon_panel_key_table[i].keycode;
>
> return keycode;
> }
There is still potentially a problem here because if we don't hit the
break statement, then we're one past the end of the array.
regards,
dan carpenter
--
To
If the az6027_usb_in_op() returns a negative errno ret is -EIO and in
that case the value of b[0] may be undefined. The original code
assigned 0 to ret, but since it's already 0 now we can skip that.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/dvb/dvb-usb/az6027.c
b/drivers/
panel_key_table[i].hw_code == (code | 0xffee))
1209 break;
After the for loop i can be 0 to 21.
1210
1211 keycode = imon_panel_key_table[i %
IMON_KEY_RELEASE_OFFSET].keycode;
IMON_KEY_RELEASE_OFFSET is 1000 so it doesn't affect anything.
regards,
ch
haven't been corrected yet. Btw. Smatch includes a pretty good test to
find places which use stack memory as a dma buffer. That's how I found
these. (http://smatch.sf.net).
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/dvb/dvb-usb/az6027.c
b/drivers/media/dvb/dvb-u
601 - 700 of 738 matches
Mail list logo
