[PATCH v2 4/4] [media] dvb-frontends/stv0367: DVB-C signal strength statistics

2017-06-21 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Provide QAM/DVB-C signal strength in decibel scale. Values returned from stv0367cab_get_rf_lvl() are good but need to be multiplied as they're in 1dBm precision. Signed-off-by: Daniel Scheller <d.schel...@gmx.net> --- drivers/media/d

[PATCH v2 1/4] [media] dvb-frontends/stv0367: initial DDB DVBv5 stats, implement ucblocks

2017-06-21 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> This adds the basics to stv0367ddb_read_status() to be able to properly provide signal statistics in DVBv5 format. Also adds UCB readout and provides those values. Also, don't return -EINVAL in ddb_read_status() if active_demod_state ind

[PATCH v2 3/4] [media] dvb-frontends/stv0367: SNR DVBv5 statistics for DVB-C and T

2017-06-21 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Add signal-to-noise-ratio as provided by the demodulator in decibel scale. QAM/DVB-C needs some intlog calculation to have usable dB values, OFDM/ DVB-T values from the demod look alright already and are provided as-is. Signed-off-by: Daniel Sc

[PATCH] [media] dvb-frontends/stv0367: deduplicate DDB dvb_frontend_ops caps

2017-06-21 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Signed-off-by: Daniel Scheller <d.schel...@gmx.net> --- drivers/media/dvb-frontends/stv0367.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/media/dvb-frontends/stv0367.c b/drivers/media/dvb-front

Re: [PATCH v2 0/4] STV0367/DDB DVBv5 signal statistics

2017-06-21 Thread Daniel Scheller
Am Wed, 21 Jun 2017 21:45:40 +0200 schrieb Daniel Scheller <d.scheller@gmail.com>: > From: Daniel Scheller <d.schel...@gmx.net> > > This series adds DVBv5 statistics support to the new DDB codepath of the > stv0367 demodulator driver. > > The changes utilise

Re: [PATCH] [media] ddbridge: use dev_* macros in favor of printk

2017-06-21 Thread Daniel Scheller
Am Wed, 21 Jun 2017 22:20:35 +0300 schrieb Antti Palosaari <cr...@iki.fi>: > On 06/21/2017 08:20 PM, Mauro Carvalho Chehab wrote: > > Em Wed, 21 Jun 2017 19:14:40 +0200 > > Daniel Scheller <d.scheller@gmail.com> escreveu: > > > >> I inten

[PATCH] [media] dvb-frontends/cxd2841er: require FE_HAS_SYNC for agc readout

2017-06-22 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> When the demod driver puts the demod into sleep or shutdown state and it's status is then polled e.g. via "dvb-fe-tool -m", i2c errors are printed to the kernel log. If the last delsys was DVB-T/T2: cxd2841er: i2c wr failed=-5 addr

[PATCH] [media] ddbridge: make (ddb)readl in while-loops fail-safe

2017-06-23 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Reported by smatch: drivers/media/pci/ddbridge/ddbridge-core.c:1246 input_tasklet() warn: this loop depends on readl() succeeding drivers/media/pci/ddbridge/ddbridge-core.c:1768 flashio() warn: this loop depends on readl() succeeding d

[PATCH 3/9] [media] dvb-frontends/stv0910: add multistream (ISI) and PLS capabilities

2017-06-24 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Implements stream_id filter and scrambling code setup in Start() and also sets FE_CAN_MULTISTREAM in frontend_ops. This enables the driver to properly receive and handle multistream transponders, functionality has been reported working fine by t

[PATCH 4/9] [media] dvb-frontends/stv0910: Fix signal strength reporting

2017-06-24 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Original code at least has some signed/unsigned issues, resulting in values like 32dBm. Change signal strength readout to work without asking the attached tuner, and use a lookup table instead of log calc. Values reported appear plausible. Obs

[PATCH 6/9] [media] dvb-frontends: add ST STV6111 DVB-S/S2 tuner frontend driver

2017-06-24 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> This adds a frontend driver for the ST STV6111 DVB-S/S2 tuners. Like the stv0910 demod frontend driver, this driver originates from the Digital Devices' dddvb vendor driver package as of version 0.9.29, and was cleaned up aswell. No functionali

[PATCH 8/9] [media] ddbridge: support for CineS2 V7(A) and DuoFlex S2 V4 hardware

2017-06-24 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> This adds all required glue code to support - in conjunction with the new stv0910 and stv6111 demod/tuner drivers and additionally the lnbh25 LNB controller driver - all current DVB-S/S2 hardware (bridges and flex modules) from Digital Device

[PATCH 9/9] [media] ddbridge: stv0910 single demod mode module option

2017-06-24 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Adds a stv0910_single modparm which, when set, configures the stv0910 to run in single demodulator mode, currently intended for high bit rate testing. Signed-off-by: Daniel Scheller <d.schel...@gmx.net> --- drivers/media/pci/ddbridge/ddb

[PATCH 0/9] STV0910/STV6111 drivers, ddbridge CineS2 V7 support

2017-06-24 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> For Linux 4.14. This series adds drivers for the ST STV0910 DVB-S/S2 demodulator ICs and the ST STV6111 DVB-S/S2 tuners, and utilises them to enable ddbridge to support the current line of Digital Devices DVB-S/S2 hardware (e.g. Cine S2 V7/V7A ad

[PATCH 7/9] [media] ddbridge: return stv09xx id in port_has_stv0900_aa()

2017-06-24 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> The returned value is required for further evaluation of the exact demodulator chip (stv090x or stv0910). Signed-off-by: Daniel Scheller <d.schel...@gmx.net> --- drivers/media/pci/ddbridge/ddbridge-core.c | 9 - 1 file changed,

[PATCH 5/9] [media] dvb-frontends/stv0910: Add missing set_frontend fe-op

2017-06-24 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> This was missing from the frontend_ops. Signed-off-by: Daniel Scheller <d.schel...@gmx.net> --- drivers/media/dvb-frontends/stv0910.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/dvb-frontends/stv0910.c b/drive

[PATCH 2/9] [media] dvb-frontends/stv0910: Fix possible buffer overflow

2017-06-24 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Fixes smatch error: drivers/media/dvb-frontends/stv0910.c:715 DVBS2_nBCH() error: buffer overflow 'nBCH[FECType]' 2 <= 28 Also, fixes the nBCH array table by adding the DUMMY_PLF element at the top to match the enums (table element orde

Re: [PATCH 4/9] [media] dvb-frontends/stv0910: Fix signal strength reporting

2017-06-26 Thread Daniel Scheller
Am Mon, 26 Jun 2017 10:55:34 +0200 schrieb Ralph Metzler <r...@metzlerbros.de>: > Daniel Scheller writes: > > From: Daniel Scheller <d.schel...@gmx.net> > > > > Original code at least has some signed/unsigned issues, resulting > > i

Re: DD support improvements (was: Re: [PATCH v3 00/13] stv0367/ddbridge: support CTv6/FlexCT hardware)

2017-06-26 Thread Daniel Scheller
ntime a decision should be made if the current in-kernel ddbridge should be kept somewhere or not (ie. as legacy driver). IMHO this is not absolutely neccessary since both driver variants (dddvb directly and the "castrated" one) are in use by people all around and besides MSI (which we can

Re: DD support improvements (was: Re: [PATCH v3 00/13] stv0367/ddbridge: support CTv6/FlexCT hardware)

2017-06-26 Thread Daniel Scheller
ually, this was just some (early) random attempt at fixing something which turned out unrelated and even doesn't apply as is anymore. But that patch might be a start to get this done. Best regards, Daniel Scheller -- https://github.com/herrnst

Re: DD support improvements (was: Re: [PATCH v3 00/13] stv0367/ddbridge: support CTv6/FlexCT hardware)

2017-06-26 Thread Daniel Scheller
ll/12 - if you're fine with the result, I will start a V2 series based on kernel_case naming. Best regards, Daniel Scheller -- https://github.com/herrnst

[PATCH] [media] dvb-frontends/cxd2841er: require STATE_ACTIVE_* for agc readout

2017-06-25 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> When the demod driver puts the demod into sleep or shutdown state and it's status is then polled e.g. via "dvb-fe-tool -m", i2c errors are printed to the kernel log. If the last delsys was DVB-T/T2: cxd2841er: i2c wr failed=-5 addr

[PATCH v3 2/4] [media] dvb-frontends/stv0367: SNR DVBv5 statistics for DVB-C and T

2017-06-25 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Add signal-to-noise-ratio as provided by the demodulator in decibel scale. QAM/DVB-C needs some intlog calculation to have usable dB values, OFDM/ DVB-T values from the demod look alright already and are provided as-is. Signed-off-by: Daniel Sc

[PATCH v3 0/4] STV0367/DDB DVBv5 signal statistics

2017-06-25 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> This series adds DVBv5 statistics support to the new DDB codepath of the stv0367 demodulator driver. The changes utilise already existing functionality (in form of register readouts), but wraps the reads in separate functions so the existing re

[PATCH v3 1/4] [media] dvb-frontends/stv0367: Improve DVB-C/T frontend status

2017-06-25 Thread Daniel Scheller
Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Tested-by: Daniel Scheller <d.schel...@gmx.net> Signed-off-by: Daniel Scheller <d.schel...@gmx.net> --- drivers/media/dvb-frontends/stv0367.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) di

[PATCH v3 3/4] [media] dvb-frontends/stv0367: DVB-C signal strength statistics

2017-06-25 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Provide QAM/DVB-C signal strength in decibel scale. Values returned from stv0367cab_get_rf_lvl() are good but need to be multiplied as they're in 1dBm precision. Signed-off-by: Daniel Scheller <d.schel...@gmx.net> --- drivers/media/d

[PATCH v3 4/4] [media] dvb-frontends/stv0367: update UCB readout condition logic

2017-06-25 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Since the other statistics are read when fe_status conditions are TRUE, change the ucblocks readout logic to match this aswell. Signed-off-by: Daniel Scheller <d.schel...@gmx.net> --- drivers/media/dvb-frontends/stv0367.c | 10 --

Re: DD support improvements (was: Re: [PATCH v3 00/13] stv0367/ddbridge: support CTv6/FlexCT hardware)

2017-06-25 Thread Daniel Scheller
stem > > OK, we can do that, when adding a driver needing such feature. I might volunteer in adding DVB-C2 support to cxd2841er in porting needed bits over from the cxd2843 driver, but someone else need to do testing on a DVB-C2 enabled coax cable. Best regards, Daniel Scheller [1] http

[PATCH] [media] ddbridge: dev_* logging fixup

2017-06-25 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Fixup commit d52786ddd2d5 ("media: ddbridge: make (ddb)readl in while-loops fail-safe") after/wrt commit 11e358bf37e8 ("media: ddbridge: use dev_* macros in favor of printk") Signed-off-by: Daniel Scheller <d.schel..

Re: [PATCH v3 00/13] stv0367/ddbridge: support CTv6/FlexCT hardware

2017-06-19 Thread Daniel Scheller
Am Sun, 28 May 2017 23:45:37 +0200 schrieb Daniel Scheller <d.scheller@gmail.com>: > Am Sun, 7 May 2017 17:42:12 +0200 > schrieb Daniel Scheller <d.scheller@gmail.com>: > > > Am Wed, 12 Apr 2017 21:23:27 +0200 > > schrieb Daniel Scheller <d.scheller

[PATCH] [media] ddbridge: use pr_* macros in favor of printk

2017-06-20 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Side effect: KERN_DEBUG messages aren't written to the kernel log anymore. This also improves the tda18212_ping reporting a bit so users know that if pinging wasn't successful, bad things might happen. Signed-off-by: Daniel Scheller <d.schel..

[PATCH 3/4] [media] dvb-frontends/stv0367: SNR DVBv5 statistics for DVB-C and T

2017-06-20 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Add signal-to-noise-ratio as provided by the demodulator in decibel scale. QAM/DVB-C needs some intlog calculation to have usable dB values, OFDM/ DVB-T values from the demod look alright already and are provided as-is. Signed-off-by: Daniel Sc

[PATCH 4/4] [media] dvb-frontends/stv0367: DVB-C signal strength statistics

2017-06-20 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Provide QAM/DVB-C signal strength in decibel scale. Values returned from stv0367cab_get_rf_lvl() are good but need to be multiplied as they're in 1dBm precision. Signed-off-by: Daniel Scheller <d.schel...@gmx.net> --- drivers/media/d

[PATCH 1/4] [media] dvb-frontends/stv0367: initial DDB DVBv5 stats, implement ucblocks

2017-06-20 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> This adds the basics to stv0367ddb_get_frontend() to be able to properly provide signal statistics in DVBv5 format. Also adds UCB readout and provides those values. Signed-off-by: Daniel Scheller <d.schel...@gmx.net> --- drivers/media/d

[PATCH 0/4] STV0367/DDB DVBv5 signal statistics

2017-06-20 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> This series adds DVBv5 statistics support to the new DDB codepath of the stv0367 demodulator driver. The changes utilise already existing functionality (in form of register readouts), but wraps the reads in separate functions so the existing re

[PATCH 2/4] [media] dvb-frontends/stv0367: split SNR determination into functions

2017-06-20 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> The read_snr() functions currently do some magic to return relative scale values when called. Split out register readouts into separate functions so the functionality can be reused in some other way. Signed-off-by: Daniel Scheller <d.schel..

DD support improvements (was: Re: [PATCH v3 00/13] stv0367/ddbridge: support CTv6/FlexCT hardware)

2017-06-20 Thread Daniel Scheller
Am Tue, 20 Jun 2017 09:36:45 -0300 schrieb Mauro Carvalho Chehab <mche...@s-opensource.com>: Hi Mauro, > Em Mon, 19 Jun 2017 22:18:21 +0200 > Daniel Scheller <d.scheller@gmail.com> escreveu: > > > Well. From how things look, these and the cxd2841er+C2T2 ddbridg

Re: [PATCH] [media] ddbridge: use dev_* macros in favor of printk

2017-06-21 Thread Daniel Scheller
Am Wed, 21 Jun 2017 14:08:08 -0300 schrieb Mauro Carvalho Chehab <mche...@s-opensource.com>: > Em Wed, 21 Jun 2017 18:53:47 +0200 > Daniel Scheller <d.scheller@gmail.com> escreveu: > > > From: Daniel Scheller <d.schel...@gmx.net> > > > > Si

Re: [PATCH 1/4] [media] dvb-frontends/stv0367: initial DDB DVBv5 stats, implement ucblocks

2017-06-21 Thread Daniel Scheller
Am Wed, 21 Jun 2017 09:06:22 +0300 schrieb Antti Palosaari <cr...@iki.fi>: > On 06/20/2017 08:45 PM, Daniel Scheller wrote: > > From: Daniel Scheller <d.schel...@gmx.net> > > > > This adds the basics to stv0367ddb_get_frontend() to be able to properly >

[PATCH] [media] ddbridge: use dev_* macros in favor of printk

2017-06-21 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Side effect: KERN_DEBUG messages aren't written to the kernel log anymore. This also improves the tda18212_ping reporting a bit so users know that if pinging wasn't successful, bad things will happen. Since in module_init_ddbridge() there's no d

Re: [PATCH 3/4] [media] dvb-frontends/stv0367: SNR DVBv5 statistics for DVB-C and T

2017-06-21 Thread Daniel Scheller
Am Wed, 21 Jun 2017 09:30:27 +0300 schrieb Antti Palosaari <cr...@iki.fi>: > On 06/20/2017 08:45 PM, Daniel Scheller wrote: > > From: Daniel Scheller <d.schel...@gmx.net> > > > > Add signal-to-noise-ratio as provided by the demodulator in decibel scale

Re: [PATCH 00/19] cxd2841er/ddbridge: support Sony CXD28xx hardware

2017-05-28 Thread Daniel Scheller
Am Sun, 9 Apr 2017 21:38:09 +0200 schrieb Daniel Scheller <d.scheller@gmail.com>: > Important note: This series depends on the stv0367/ddbridge series > posted earlier (patches 12 [1] and 13 [2], depending on the I2C > functions and the TDA18212 attach function). > >

Re: Build fails Ubuntu 17.04 / "error: implicit declaration of function"

2017-05-28 Thread Daniel Scheller
Am Sun, 28 May 2017 21:06:33 +0200 schrieb Karl Wallin : All, > In "/home/ubuntu/media_build/v4l/cec-core.c" changed row 142 from: > "ret = cdev_device_add(>cdev, >dev);" to: > "ret = device_add(>dev);" > and row 186 from: > "cdev_device_del(>cdev, >dev);" to: >

Re: [PATCH v3 00/13] stv0367/ddbridge: support CTv6/FlexCT hardware

2017-05-28 Thread Daniel Scheller
Am Sun, 7 May 2017 17:42:12 +0200 schrieb Daniel Scheller <d.scheller@gmail.com>: > Am Wed, 12 Apr 2017 21:23:27 +0200 > schrieb Daniel Scheller <d.scheller@gmail.com>: > > > Am Wed, 29 Mar 2017 18:43:00 +0200 > > schrieb Daniel Scheller <d.schell

Re: [PATCH 00/19] cxd2841er/ddbridge: support Sony CXD28xx hardware

2017-05-31 Thread Daniel Scheller
wait lock entirely. Looking forward for your results and opinions! :-) Best regards, Daniel Scheller

Re: [PATCH v3 00/13] stv0367/ddbridge: support CTv6/FlexCT hardware

2017-05-07 Thread Daniel Scheller
Am Wed, 12 Apr 2017 21:23:27 +0200 schrieb Daniel Scheller <d.scheller@gmail.com>: > Am Wed, 29 Mar 2017 18:43:00 +0200 > schrieb Daniel Scheller <d.scheller@gmail.com>: > > > From: Daniel Scheller <d.schel...@gmx.net> > > > > Third iterat

[PATCH RESEND] media: mxl5xx: fix tuning logic

2017-10-15 Thread Daniel Scheller
ource.com> Acked-by: Daniel Scheller <d.schel...@gmx.net> --- Resend (ref. https://patchwork.linuxtv.org/patch/43541/) so this doesn't get lost - this fix really should go in. drivers/media/dvb-frontends/mxl5xx.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a

[PATCH 5/8] [media] ddbridge/max: rename ddbridge-maxs8.[c|h] to ddbridge-max.[c|h]

2017-10-15 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Rename the MaxS4/8 support files following upstream. References to these files and descriptions have been updated aswell. Signed-off-by: Daniel Scheller <d.schel...@gmx.net> --- drivers/media/pci/ddbridge/Makefile

[PATCH 6/8] [media] ddbridge/max: prefix lnb_init_fmode() and fe_attach_mxl5xx()

2017-10-15 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Add a ddb_ prefix to the two functions to better avoid conflicts in the global namespace, ie. when building everything into the kernel image. Signed-off-by: Daniel Scheller <d.schel...@gmx.net> --- drivers/media/pci/ddbridge/ddbridg

[PATCH 7/8] [media] stv0910: read and update mod_cod in read_status()

2017-10-15 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Add missing state->modcod update from upstream driver which needs to be done when manage_matype_info() sets is_vcm on certain S2 transponders. Signed-off-by: Daniel Scheller <d.schel...@gmx.net> --- drivers/media/dvb-frontends

[PATCH 2/8] [media] ddbridge: fixup checkpatch-strict issues

2017-10-15 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Fixes several alignment, braces, space-before-cast, camelcase et al issues reported by checkpatch --strict, plus a few more checkpatch didn't report. Three checks are left after this though: - one CamelCase in ddbridge-core, related to define

[PATCH 1/8] [media] ddbridge: remove unneeded *fe vars from attach functions

2017-10-15 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> These are only used in C/T demod attach functions, don't add any real benefit (ie. line length savings) and in case of cxd28xx_attach aren't even used consequently. Remove them. Signed-off-by: Daniel Scheller <d.schel...@gmx.net> --- drive

[PATCH 3/8] [media] ddbridge: split off CI (common interface) from ddbridge-core

2017-10-15 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Move all CI device support related code from ddbridge-core to ddbridge-ci, following the previously split off MaxS4/8 support. Signed-off-by: Daniel Scheller <d.schel...@gmx.net> --- drivers/media/pci/ddbridge/Makefile| 4 +- d

[PATCH 8/8] [media] ddbridge: update driver version number

2017-10-15 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Update the driver version number/string to 0.9.32-integrated. Signed-off-by: Daniel Scheller <d.schel...@gmx.net> --- drivers/media/pci/ddbridge/ddbridge.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/

[PATCH 4/8] [media] ddbridge/ci: change debug printing to debug severity

2017-10-15 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> slot_ts_enable_xo2() logged debug output to info instead of debug, so fix this up. Signed-off-by: Daniel Scheller <d.schel...@gmx.net> --- drivers/media/pci/ddbridge/ddbridge-ci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH for 4.15] ddbridge update to 0.9.32

2017-10-15 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> For the 4.15 merge window. These patches update the mainline ddbridge driver to version 0.9.32, which was released ~3 weeks ago by upstream. Nothing really fancy in this series, in fact upstream applied many of the changes that went into the ma

[PATCH 3/5] [media] ddbridge: fix sparse warnings

2017-08-23 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Fix several drivers/media/pci/ddbridge/ddbridge-core.c: warning: symbol ... was not declared. Should it be static? drivers/media/pci/ddbridge/ddbridge-core.c: warning: Using plain integer as NULL pointer drivers/media/pci/ddbridge/ddbridg

[PATCH 4/5] [media] staging/cxd2099: Add module parameter for buffer mode

2017-08-23 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> The buffer mode of the cxd2099 driver requires more work regarding error handling and thus can cause issues in some cases, so disable it by default and make that mode of operation controllable by users via a module parameter (ie. 'modprobe c

[PATCH 5/5] [media] dvb-frontends/stv0910: change minsymrate to 100Ksyms/s

2017-08-23 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> The demodulator supports symbol rates as low as 100Ksyms/s - the demod setup in start() already handles such low symbol rates and reviewers of stv0910 equipped cards even found and tested transponders with SRs in that range. So, an

[PATCH 0/5] last-minute misc ddbridge related changed

2017-08-23 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> This small series improves on a few things related to the recently merged ddbridge driver update: stv0910: * add an explanation for the mutex_lock needs in gate_ctrl() and release the lock in case of I2C ctrl errors * announce 100K

[PATCH 2/5] [media] ddbridge: fix teardown/deregistration order in ddb_input_detach()

2017-08-23 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Brought to attention by Matthias Schwarzott <z...@gentoo.org> by fixing possible use-after-free faults in some demod drivers: In ddb_input_detach(), the i2c_client is unregistered and removed before dvb frontends are unregistered and det

[PATCH 1/5] [media] dvb-frontends/stv0910: release lock on gate_ctrl() failure

2017-08-23 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Whenever write_reg() fails to open/close the demod's I2C gate, release the lock to avoid deadlocking situations. If I2c gate open failed, there's no need to hold a lock, and if close fails, the mutex_unlock() at the end of the function is never r

[PATCH] [media_build] ddbridge: backport to enable_msi_block, require kernel 3.8

2017-08-24 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Backport to pci_enable_msi_block for kernels <3.14 (picked from upstream dddvb package). Also, ddbridge requires the PCI_DEVICE_SUB macro, which was added in 3.8. Signed-off-by: Daniel Scheller <d.schel...@gmx.net> Tested-by: Jasm

Re: [PATCH] [media] dvb-frontends/mxl5xx: fix lock check order

2017-08-27 Thread Daniel Scheller
Am Sun, 27 Aug 2017 09:18:07 -0300 schrieb Mauro Carvalho Chehab <mche...@s-opensource.com>: Thanks for looking at this. > Em Sun, 20 Aug 2017 12:45:45 +0200 > Daniel Scheller <d.scheller@gmail.com> escreveu: > > > From: Daniel Scheller <d.schel...@g

[PATCH] [media_build] update v4.7_dma_attrs.patch

2017-08-28 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Fixes apply_patches wrt commit 5b6f9abe5a49 ("media: vb2: add bidirectional flag in vb2_queue") Signed-off-by: Daniel Scheller <d.schel...@gmx.net> Tested-by: Jasmin Jessich <jas...@anw.at> --- Tested and verified by Ja

[PATCH] [media] ddbridge: add IOCTLs

2017-08-20 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> This patch adds back the IOCTL API/functionality which is present in the upstream dddvb driver package. In comparison, the IOCTL handler has been factored to a separate object (and with that, some functionality from -core has been moved there

Re: [PATCH 0/4] MxL5xx demodulator-tuner driver, DD MaxS8 support

2017-08-20 Thread Daniel Scheller
Am Sun, 9 Jul 2017 21:42:42 +0200 schrieb Daniel Scheller <d.scheller@gmail.com>: > Hard-dependency on the STV0910/STV6111 driver+DD support series and > the DD driver bump. > > This adds a driver for the MaxLinear MxL5xx tuner-demodulator series > (a DVB-S/S2/DSS de

Re: [PATCH] [media] ddbridge: add IOCTLs

2017-08-20 Thread Daniel Scheller
Am Sun, 20 Aug 2017 08:53:56 -0300 schrieb Mauro Carvalho Chehab <mche...@s-opensource.com>: > Em Sun, 20 Aug 2017 13:08:55 +0200 > Daniel Scheller <d.scheller@gmail.com> escreveu: > > > From: Daniel Scheller <d.schel...@gmx.net> > > > > Thi

Re: [PATCH] [media] ddbridge: add IOCTLs

2017-08-20 Thread Daniel Scheller
Am Sun, 20 Aug 2017 14:11:26 +0200 schrieb Daniel Scheller <d.scheller@gmail.com>: > > Anyway, I applied today the ddbridge patches we had. I solved a few > > conflicts while merging some things, so I'd appreciate if you could > > check if everything is ok. If

[PATCH 0/2] stv{0910,6111} cosmetics

2017-08-20 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Two cosmetics for the two new demod/tuner drivers. The stv0910 patch is a remainder/leftover from the cleanup and cosmetic series, originally submitted by Colin King. The second one fixes a warning I noticed in Hans' daily build log. @Mauro: To

[PATCH 1/2] [media] dvb-frontends/stv0910: declare global list_head stvlist static

2017-08-20 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Cleans up smatch warning: symbol 'stvlist' was not declared. Should it be static? Patch originally submitted by Colin Ian King <colin.k...@canonical.com>, remainder after the merge of all other stv0910 fixes. Cc: Colin Ian K

[PATCH 2/2] [media] dvb-frontends/stv6111.c: return NULL instead of plain integer

2017-08-20 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Fixes: stv6111.c:665:24: warning: Using plain integer as NULL pointer Signed-off-by: Daniel Scheller <d.schel...@gmx.net> --- drivers/media/dvb-frontends/stv6111.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drive

[PATCH 1/2] [media] dvb-frontends/stv0910: fix FE_HAS_LOCK check order in tune()

2017-08-20 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Signed-off-by: Daniel Scheller <d.schel...@gmx.net> --- drivers/media/dvb-frontends/stv0910.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/media/dvb-frontends/stv0910.c b/drivers/media/dvb-fronten

[PATCH 0/2] stv0910: updates from dddvb 0.9.31

2017-08-20 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Digital Devices released dddvb-0.9.31 which carries these two fixes for the stv0910 demodulator driver. Should go in after the seven stv0910/stv6111 cleanup patches (see [1]), namely after [2]. They might apply cleanly without them, but they ma

[PATCH 2/2] [media] dvb-frontends/stv0910: fix mask for scramblingcode setup

2017-08-20 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Signed-off-by: Daniel Scheller <d.schel...@gmx.net> --- drivers/media/dvb-frontends/stv0910.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/stv0910.c b/drivers/media/dvb-frontends/stv

[PATCH 3/6] [media] ddbridge: move device ID table to ddbridge-hw

2017-08-20 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> This further cleans up ddbridge-main from hardware-related data and moves the exact card type determination into ddbridge-hw.c:get_ddb_info(), right to the hardware maps/structs. Also, const'ify more structs and pointers. Signed-off-by: Daniel Sc

[PATCH 4/6] [media] ddbridge: remove ddb_info's from the global scope

2017-08-20 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Since the DD hardware info and maps aren't needed anymore outside of ddbridge-hw.c (they're returned via get_ddb_info() now), mark them static and remove all refs from ddbridge-hw.h. Signed-off-by: Daniel Scheller <d.schel...@gmx.net> --- d

[PATCH 0/6] ddbridge: updates from dddvb-0.9.31

2017-08-20 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Digital Devices bumped their driver package to version 0.9.31, which most importantly carries all refactorisations which are part of the pending mainline driver bump (bringing dddvb and the proposed kernel version much closer to each other), and im

[PATCH 2/6] [media] ddbridge: move ddb_unmap(), cleanup modparams

2017-08-20 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> adapter_alloc is only used from within ddbridge-core, so move it there, this removes the need for prototyping/referencing the variable. While at it, msi isn't needed outside of ddbridge-main, so don't extref that one aswell. Signed-off-by:

[PATCH 1/6] [media] ddbridge: fix gap handling

2017-08-20 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Force gap setting if given by attribute and enable gap for older regmaps. Also, setting a gap value of 128 via sysfs will now disable gap. Signed-off-by: Daniel Scheller <d.schel...@gmx.net> --- drivers/media/pci/ddbridge/ddbridge-core.c |

[PATCH 6/6] [media] ddbridge: bump version string to 0.9.31intermediate-integrated

2017-08-20 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Signed-off-by: Daniel Scheller <d.schel...@gmx.net> --- drivers/media/pci/ddbridge/ddbridge.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/ddbridge/ddbridge.h b/drivers/media/pci/ddbridge/ddbr

[PATCH 5/6] [media] ddbridge: const'ify all ddb_info, ddb_regmap et al

2017-08-20 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> All data is accessed RO, so mark everything const. Some vars in several functions aswell as function signatures also require the const keyword now, they're also added by this commit. Signed-off-by: Daniel Scheller <d.schel...@gmx.net> --- d

[PATCH] [media] dvb-frontends/mxl5xx: fix lock check order

2017-08-20 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Signed-off-by: Daniel Scheller <d.schel...@gmx.net> --- When the mxl5xx driver together with the ddbridge glue gets merged ([1]), this one should go in aswell - this fix is part of the dddvb-0.9.31 release. drivers/media/dvb-frontends/

[PATCH] [media] dvb-frontends/mxl5xx: declare LIST_HEAD(mxllist) static

2017-09-01 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Fixes one sparse warning: mxl5xx.c:46:1: warning: symbol 'mxllist' was not declared. Should it be static? Signed-off-by: Daniel Scheller <d.schel...@gmx.net> --- drivers/media/dvb-frontends/mxl5xx.c | 2 +- 1 file changed, 1 insertion(+)

[PATCH 6/7] [media] dvb-frontends/stv0910: remove unneeded symbol rate inquiry

2017-11-26 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> tracking_optimization() doesn't make use of the symbol rate reported by the demodulator, so remove the unneeded inquiry and the now unneeded variable. Reported-by: Richard Scobie <rasco...@slingshot.co.nz> Cc: Ralph Metzler <r...@metzler

[PATCH 2/7] [media] dvb-frontends/stv0910: WARN_ON() on consecutive mutex_unlock()

2017-11-26 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Stack dump when gate_ctrl() is called in a way that consecutive unlocks happen. This is a clear indication that other drivers interfacing with the stv0910 driver don't do things properly or don't check for failures, so dump stack so that those d

[PATCH 1/7] [media] frontends/stv0910: add field offsets to field defines

2017-11-26 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Each field (FSTV0910_XX) is declared as reg/off/unused/sign/mask. Add the missing offset value to the defines. Picked up from dddvb master, commit 8a1f27c3d22c ("add field offset to field defines") by Ralph Metzler <r...@metzl

[PATCH 0/7] stv0910+stv6111 updates/fixes/improvements

2017-11-26 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> This series improves (and fixes) a few pending things and a few new ones which were discovered by Richard (thanks!), removing some redundant calls and checks here and there, and putting the symbolrate readout and reporting to get_frontend(). The c

[PATCH 3/7] [media] dvb-frontends/stv6111: handle gate_ctrl errors

2017-11-26 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> When a parent (demod) driver encounters and signals a problem with gate_ctrl(), don't blindly continue poking the I2C bus. Signed-off-by: Daniel Scheller <d.schel...@gmx.net> Tested-by: Richard Scobie <rasco...@slingshot.co.nz> ---

[PATCH 4/7] [media] dvb-frontends/stv0910: remove unneeded check/call to get_if_freq

2017-11-26 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> The result (if any) isn't used anywhere besides being assigned to a local variable (and the only current companion stv6111 doesn't even implement get_if_frequency()), thus remove the ptr check and the call, and also remove the now unused iffreq va

[PATCH 5/7] [media] dvb-frontends/stv0910: read symbolrate in get_frontend()

2017-11-26 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Utilise get_cur_symbol_rate() in get_frontend() to update the dtv_frontend_properties with the current symbol rate as reported by the demodulator. Reported-by: Richard Scobie <rasco...@slingshot.co.nz> Cc: Ralph Metzler <r...@metzlerbros

[PATCH 7/7] [media] dvb-frontends/stv0910: remove unneeded dvb_math.h include

2017-11-26 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Since nothing from dvb_math.h is used, remove the unneeded include. Signed-off-by: Daniel Scheller <d.schel...@gmx.net> --- drivers/media/dvb-frontends/stv0910.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/dvb-fronten

Re: [PATCH] [media] ddbridge: add IOCTLs

2017-11-26 Thread Daniel Scheller
Am Tue, 22 Aug 2017 17:21:16 +0200 schrieb Daniel Scheller <d.scheller@gmail.com>: > Am Tue, 22 Aug 2017 16:05:21 +0200 > schrieb Ralph Metzler <r...@metzlerbros.de>: > > > Daniel Scheller writes: > > > Am Sun, 20 Aug 2017 08:53:56 -0300 > >

Re: [PATCH] media: dvb_frontend: dvb_unregister_frontend must not call dvb_detach for fe->ops.release

2017-11-26 Thread Daniel Scheller
gt;frontend_priv = NULL; FWIW, this patch breaks unloading for all DVB cards in my dev system, in that attached drivers like demod and tuner drivers won't usecount to zero anymore ("rmmod ddbridge" keeps the usecount of stv0367 and cxd2841er up, and "rmmod budget_av" doesn't usecount the tda10023 back to zero). Best regards, Daniel Scheller -- https://github.com/herrnst

Re: [PATCH 0/8] ddbridge improvements and cleanups

2017-12-17 Thread Daniel Scheller
On Sun, 17 Dec 2017 16:40:41 +0100 Daniel Scheller <d.scheller@gmail.com> wrote: > I verified this by simply removing tda18212.ko with this DD setup: Sorry, I forgot to outline this: I also tested by removing stv0367.ko and cxd2841er.ko of course, which resulted in partially working

[PATCH 1/8] [media] ddbridge: unregister I2C tuner client before detaching fe's

2017-12-17 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Currently, rmmod ddbridge on a KASAN enabled kernel yields this report for hardware that utilises the tda18212 tuner driver: [ 50.355229] == [ 50.355271] BUG: KASAN: use-afte

[PATCH 4/8] [media] ddbridge: move CI detach code to ddbridge-ci.c

2017-12-17 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Move the CI teardown code to ddbridge-ci.c where everything else related to CI hardware lives. Cc: Ralph Metzler <r...@metzlerbros.de> Signed-off-by: Daniel Scheller <d.schel...@gmx.net> --- drivers/media/pci/ddbridge/dd

[PATCH 2/8] [media] ddbridge: fix resources cleanup for CI hardware

2017-12-17 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> Do kfree() on port->en->data instead of port->en. port->en only holds a ptr to a struct dvb_ca_en50221, which is a member either of a memalloc'ed struct ddb_ci (DuoFlex CI, Octopus CI Duo) or a struct cxd (CXD2099AR based Sing

[PATCH 8/8] [media] ddbridge: improve ddb_ports_attach() failure handling

2017-12-17 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> As all error handling improved quite a bit, don't stop attaching frontends if one of them failed, since - if other tuner modules are connected to the PCIe bridge - other hardware may just work, so don't break on a single port failure, but

[PATCH 0/8] ddbridge improvements and cleanups

2017-12-17 Thread Daniel Scheller
From: Daniel Scheller <d.schel...@gmx.net> This series improves on a few things in ddbridge: * Fix up a KASAN report which pops up with all TDA18212-equipped hardware by changing the order of all frontend driver teardown. This was originally thought to be a problem of the tda18212

<    1   2   3   4   5   6   >