From: Daniel Scheller <d.schel...@gmx.net>
Provide QAM/DVB-C signal strength in decibel scale. Values returned from
stv0367cab_get_rf_lvl() are good but need to be multiplied as they're in
1dBm precision.
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
---
drivers/media/d
From: Daniel Scheller <d.schel...@gmx.net>
This adds the basics to stv0367ddb_read_status() to be able to properly
provide signal statistics in DVBv5 format. Also adds UCB readout and
provides those values. Also, don't return -EINVAL in ddb_read_status()
if active_demod_state ind
From: Daniel Scheller <d.schel...@gmx.net>
Add signal-to-noise-ratio as provided by the demodulator in decibel scale.
QAM/DVB-C needs some intlog calculation to have usable dB values, OFDM/
DVB-T values from the demod look alright already and are provided as-is.
Signed-off-by: Daniel Sc
From: Daniel Scheller <d.schel...@gmx.net>
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
---
drivers/media/dvb-frontends/stv0367.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/media/dvb-frontends/stv0367.c
b/drivers/media/dvb-front
Am Wed, 21 Jun 2017 21:45:40 +0200
schrieb Daniel Scheller <d.scheller@gmail.com>:
> From: Daniel Scheller <d.schel...@gmx.net>
>
> This series adds DVBv5 statistics support to the new DDB codepath of the
> stv0367 demodulator driver.
>
> The changes utilise
Am Wed, 21 Jun 2017 22:20:35 +0300
schrieb Antti Palosaari <cr...@iki.fi>:
> On 06/21/2017 08:20 PM, Mauro Carvalho Chehab wrote:
> > Em Wed, 21 Jun 2017 19:14:40 +0200
> > Daniel Scheller <d.scheller@gmail.com> escreveu:
> >
> >> I inten
From: Daniel Scheller <d.schel...@gmx.net>
When the demod driver puts the demod into sleep or shutdown state and it's
status is then polled e.g. via "dvb-fe-tool -m", i2c errors are printed
to the kernel log. If the last delsys was DVB-T/T2:
cxd2841er: i2c wr failed=-5 addr
From: Daniel Scheller <d.schel...@gmx.net>
Reported by smatch:
drivers/media/pci/ddbridge/ddbridge-core.c:1246 input_tasklet() warn: this
loop depends on readl() succeeding
drivers/media/pci/ddbridge/ddbridge-core.c:1768 flashio() warn: this loop
depends on readl() succeeding
d
From: Daniel Scheller <d.schel...@gmx.net>
Implements stream_id filter and scrambling code setup in Start() and also
sets FE_CAN_MULTISTREAM in frontend_ops. This enables the driver to
properly receive and handle multistream transponders, functionality has
been reported working fine by t
From: Daniel Scheller <d.schel...@gmx.net>
Original code at least has some signed/unsigned issues, resulting in
values like 32dBm. Change signal strength readout to work without asking
the attached tuner, and use a lookup table instead of log calc. Values
reported appear plausible. Obs
From: Daniel Scheller <d.schel...@gmx.net>
This adds a frontend driver for the ST STV6111 DVB-S/S2 tuners. Like the
stv0910 demod frontend driver, this driver originates from the Digital
Devices' dddvb vendor driver package as of version 0.9.29, and was cleaned
up aswell. No functionali
From: Daniel Scheller <d.schel...@gmx.net>
This adds all required glue code to support - in conjunction with the new
stv0910 and stv6111 demod/tuner drivers and additionally the lnbh25 LNB
controller driver - all current DVB-S/S2 hardware (bridges and flex
modules) from Digital Device
From: Daniel Scheller <d.schel...@gmx.net>
Adds a stv0910_single modparm which, when set, configures the stv0910 to
run in single demodulator mode, currently intended for high bit rate
testing.
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
---
drivers/media/pci/ddbridge/ddb
From: Daniel Scheller <d.schel...@gmx.net>
For Linux 4.14.
This series adds drivers for the ST STV0910 DVB-S/S2 demodulator ICs and
the ST STV6111 DVB-S/S2 tuners, and utilises them to enable ddbridge to
support the current line of Digital Devices DVB-S/S2 hardware (e.g. Cine
S2 V7/V7A ad
From: Daniel Scheller <d.schel...@gmx.net>
The returned value is required for further evaluation of the exact
demodulator chip (stv090x or stv0910).
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
---
drivers/media/pci/ddbridge/ddbridge-core.c | 9 -
1 file changed,
From: Daniel Scheller <d.schel...@gmx.net>
This was missing from the frontend_ops.
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
---
drivers/media/dvb-frontends/stv0910.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/dvb-frontends/stv0910.c
b/drive
From: Daniel Scheller <d.schel...@gmx.net>
Fixes smatch error:
drivers/media/dvb-frontends/stv0910.c:715 DVBS2_nBCH() error: buffer overflow
'nBCH[FECType]' 2 <= 28
Also, fixes the nBCH array table by adding the DUMMY_PLF element at the top
to match the enums (table element orde
Am Mon, 26 Jun 2017 10:55:34 +0200
schrieb Ralph Metzler <r...@metzlerbros.de>:
> Daniel Scheller writes:
> > From: Daniel Scheller <d.schel...@gmx.net>
> >
> > Original code at least has some signed/unsigned issues, resulting
> > i
ntime a decision should be made if the current
in-kernel ddbridge should be kept somewhere or not (ie. as legacy
driver). IMHO this is not absolutely neccessary since both driver
variants (dddvb directly and the "castrated" one) are in use by people
all around and besides MSI (which we can
ually, this was just some (early) random attempt at
fixing something which turned out unrelated and even doesn't apply as is
anymore. But that patch might be a start to get this done.
Best regards,
Daniel Scheller
--
https://github.com/herrnst
ll/12 - if you're fine with the
result, I will start a V2 series based on kernel_case naming.
Best regards,
Daniel Scheller
--
https://github.com/herrnst
From: Daniel Scheller <d.schel...@gmx.net>
When the demod driver puts the demod into sleep or shutdown state and it's
status is then polled e.g. via "dvb-fe-tool -m", i2c errors are printed
to the kernel log. If the last delsys was DVB-T/T2:
cxd2841er: i2c wr failed=-5 addr
From: Daniel Scheller <d.schel...@gmx.net>
Add signal-to-noise-ratio as provided by the demodulator in decibel scale.
QAM/DVB-C needs some intlog calculation to have usable dB values, OFDM/
DVB-T values from the demod look alright already and are provided as-is.
Signed-off-by: Daniel Sc
From: Daniel Scheller <d.schel...@gmx.net>
This series adds DVBv5 statistics support to the new DDB codepath of the
stv0367 demodulator driver.
The changes utilise already existing functionality (in form of register
readouts), but wraps the reads in separate functions so the existing
re
Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com>
Tested-by: Daniel Scheller <d.schel...@gmx.net>
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
---
drivers/media/dvb-frontends/stv0367.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
di
From: Daniel Scheller <d.schel...@gmx.net>
Provide QAM/DVB-C signal strength in decibel scale. Values returned from
stv0367cab_get_rf_lvl() are good but need to be multiplied as they're in
1dBm precision.
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
---
drivers/media/d
From: Daniel Scheller <d.schel...@gmx.net>
Since the other statistics are read when fe_status conditions are TRUE,
change the ucblocks readout logic to match this aswell.
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
---
drivers/media/dvb-frontends/stv0367.c | 10 --
stem
>
> OK, we can do that, when adding a driver needing such feature.
I might volunteer in adding DVB-C2 support to cxd2841er in porting needed bits
over from the cxd2843 driver, but someone else need to do testing on a DVB-C2
enabled coax cable.
Best regards,
Daniel Scheller
[1]
http
From: Daniel Scheller <d.schel...@gmx.net>
Fixup
commit d52786ddd2d5 ("media: ddbridge: make (ddb)readl in while-loops
fail-safe")
after/wrt
commit 11e358bf37e8 ("media: ddbridge: use dev_* macros in favor of printk")
Signed-off-by: Daniel Scheller <d.schel..
Am Sun, 28 May 2017 23:45:37 +0200
schrieb Daniel Scheller <d.scheller@gmail.com>:
> Am Sun, 7 May 2017 17:42:12 +0200
> schrieb Daniel Scheller <d.scheller@gmail.com>:
>
> > Am Wed, 12 Apr 2017 21:23:27 +0200
> > schrieb Daniel Scheller <d.scheller
From: Daniel Scheller <d.schel...@gmx.net>
Side effect: KERN_DEBUG messages aren't written to the kernel log anymore.
This also improves the tda18212_ping reporting a bit so users know that if
pinging wasn't successful, bad things might happen.
Signed-off-by: Daniel Scheller <d.schel..
From: Daniel Scheller <d.schel...@gmx.net>
Add signal-to-noise-ratio as provided by the demodulator in decibel scale.
QAM/DVB-C needs some intlog calculation to have usable dB values, OFDM/
DVB-T values from the demod look alright already and are provided as-is.
Signed-off-by: Daniel Sc
From: Daniel Scheller <d.schel...@gmx.net>
Provide QAM/DVB-C signal strength in decibel scale. Values returned from
stv0367cab_get_rf_lvl() are good but need to be multiplied as they're in
1dBm precision.
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
---
drivers/media/d
From: Daniel Scheller <d.schel...@gmx.net>
This adds the basics to stv0367ddb_get_frontend() to be able to properly
provide signal statistics in DVBv5 format. Also adds UCB readout and
provides those values.
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
---
drivers/media/d
From: Daniel Scheller <d.schel...@gmx.net>
This series adds DVBv5 statistics support to the new DDB codepath of the
stv0367 demodulator driver.
The changes utilise already existing functionality (in form of register
readouts), but wraps the reads in separate functions so the existing
re
From: Daniel Scheller <d.schel...@gmx.net>
The read_snr() functions currently do some magic to return relative scale
values when called. Split out register readouts into separate functions
so the functionality can be reused in some other way.
Signed-off-by: Daniel Scheller <d.schel..
Am Tue, 20 Jun 2017 09:36:45 -0300
schrieb Mauro Carvalho Chehab <mche...@s-opensource.com>:
Hi Mauro,
> Em Mon, 19 Jun 2017 22:18:21 +0200
> Daniel Scheller <d.scheller@gmail.com> escreveu:
>
> > Well. From how things look, these and the cxd2841er+C2T2 ddbridg
Am Wed, 21 Jun 2017 14:08:08 -0300
schrieb Mauro Carvalho Chehab <mche...@s-opensource.com>:
> Em Wed, 21 Jun 2017 18:53:47 +0200
> Daniel Scheller <d.scheller@gmail.com> escreveu:
>
> > From: Daniel Scheller <d.schel...@gmx.net>
> >
> > Si
Am Wed, 21 Jun 2017 09:06:22 +0300
schrieb Antti Palosaari <cr...@iki.fi>:
> On 06/20/2017 08:45 PM, Daniel Scheller wrote:
> > From: Daniel Scheller <d.schel...@gmx.net>
> >
> > This adds the basics to stv0367ddb_get_frontend() to be able to properly
>
From: Daniel Scheller <d.schel...@gmx.net>
Side effect: KERN_DEBUG messages aren't written to the kernel log anymore.
This also improves the tda18212_ping reporting a bit so users know that if
pinging wasn't successful, bad things will happen.
Since in module_init_ddbridge() there's no d
Am Wed, 21 Jun 2017 09:30:27 +0300
schrieb Antti Palosaari <cr...@iki.fi>:
> On 06/20/2017 08:45 PM, Daniel Scheller wrote:
> > From: Daniel Scheller <d.schel...@gmx.net>
> >
> > Add signal-to-noise-ratio as provided by the demodulator in decibel scale
Am Sun, 9 Apr 2017 21:38:09 +0200
schrieb Daniel Scheller <d.scheller@gmail.com>:
> Important note: This series depends on the stv0367/ddbridge series
> posted earlier (patches 12 [1] and 13 [2], depending on the I2C
> functions and the TDA18212 attach function).
>
>
Am Sun, 28 May 2017 21:06:33 +0200
schrieb Karl Wallin :
All,
> In "/home/ubuntu/media_build/v4l/cec-core.c" changed row 142 from:
> "ret = cdev_device_add(>cdev, >dev);" to:
> "ret = device_add(>dev);"
> and row 186 from:
> "cdev_device_del(>cdev, >dev);" to:
>
Am Sun, 7 May 2017 17:42:12 +0200
schrieb Daniel Scheller <d.scheller@gmail.com>:
> Am Wed, 12 Apr 2017 21:23:27 +0200
> schrieb Daniel Scheller <d.scheller@gmail.com>:
>
> > Am Wed, 29 Mar 2017 18:43:00 +0200
> > schrieb Daniel Scheller <d.schell
wait lock entirely.
Looking forward for your results and opinions! :-)
Best regards,
Daniel Scheller
Am Wed, 12 Apr 2017 21:23:27 +0200
schrieb Daniel Scheller <d.scheller@gmail.com>:
> Am Wed, 29 Mar 2017 18:43:00 +0200
> schrieb Daniel Scheller <d.scheller@gmail.com>:
>
> > From: Daniel Scheller <d.schel...@gmx.net>
> >
> > Third iterat
ource.com>
Acked-by: Daniel Scheller <d.schel...@gmx.net>
---
Resend (ref. https://patchwork.linuxtv.org/patch/43541/) so this doesn't
get lost - this fix really should go in.
drivers/media/dvb-frontends/mxl5xx.c | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a
From: Daniel Scheller <d.schel...@gmx.net>
Rename the MaxS4/8 support files following upstream. References to these
files and descriptions have been updated aswell.
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
---
drivers/media/pci/ddbridge/Makefile
From: Daniel Scheller <d.schel...@gmx.net>
Add a ddb_ prefix to the two functions to better avoid conflicts in the
global namespace, ie. when building everything into the kernel image.
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
---
drivers/media/pci/ddbridge/ddbridg
From: Daniel Scheller <d.schel...@gmx.net>
Add missing state->modcod update from upstream driver which needs to be
done when manage_matype_info() sets is_vcm on certain S2 transponders.
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
---
drivers/media/dvb-frontends
From: Daniel Scheller <d.schel...@gmx.net>
Fixes several alignment, braces, space-before-cast, camelcase et al issues
reported by checkpatch --strict, plus a few more checkpatch didn't report.
Three checks are left after this though:
- one CamelCase in ddbridge-core, related to define
From: Daniel Scheller <d.schel...@gmx.net>
These are only used in C/T demod attach functions, don't add any real
benefit (ie. line length savings) and in case of cxd28xx_attach aren't
even used consequently. Remove them.
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
---
drive
From: Daniel Scheller <d.schel...@gmx.net>
Move all CI device support related code from ddbridge-core to ddbridge-ci,
following the previously split off MaxS4/8 support.
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
---
drivers/media/pci/ddbridge/Makefile| 4 +-
d
From: Daniel Scheller <d.schel...@gmx.net>
Update the driver version number/string to 0.9.32-integrated.
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
---
drivers/media/pci/ddbridge/ddbridge.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/
From: Daniel Scheller <d.schel...@gmx.net>
slot_ts_enable_xo2() logged debug output to info instead of debug, so
fix this up.
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
---
drivers/media/pci/ddbridge/ddbridge-ci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Daniel Scheller <d.schel...@gmx.net>
For the 4.15 merge window. These patches update the mainline ddbridge
driver to version 0.9.32, which was released ~3 weeks ago by upstream.
Nothing really fancy in this series, in fact upstream applied many of
the changes that went into the ma
From: Daniel Scheller <d.schel...@gmx.net>
Fix several
drivers/media/pci/ddbridge/ddbridge-core.c: warning: symbol ... was not
declared. Should it be static?
drivers/media/pci/ddbridge/ddbridge-core.c: warning: Using plain integer as
NULL pointer
drivers/media/pci/ddbridge/ddbridg
From: Daniel Scheller <d.schel...@gmx.net>
The buffer mode of the cxd2099 driver requires more work regarding error
handling and thus can cause issues in some cases, so disable it by default
and make that mode of operation controllable by users via a module
parameter (ie. 'modprobe c
From: Daniel Scheller <d.schel...@gmx.net>
The demodulator supports symbol rates as low as 100Ksyms/s - the demod
setup in start() already handles such low symbol rates and reviewers
of stv0910 equipped cards even found and tested transponders with
SRs in that range. So, an
From: Daniel Scheller <d.schel...@gmx.net>
This small series improves on a few things related to the recently merged
ddbridge driver update:
stv0910:
* add an explanation for the mutex_lock needs in gate_ctrl() and release
the lock in case of I2C ctrl errors
* announce 100K
From: Daniel Scheller <d.schel...@gmx.net>
Brought to attention by Matthias Schwarzott <z...@gentoo.org> by fixing
possible use-after-free faults in some demod drivers:
In ddb_input_detach(), the i2c_client is unregistered and removed before
dvb frontends are unregistered and det
From: Daniel Scheller <d.schel...@gmx.net>
Whenever write_reg() fails to open/close the demod's I2C gate, release the
lock to avoid deadlocking situations. If I2c gate open failed, there's no
need to hold a lock, and if close fails, the mutex_unlock() at the end of
the function is never r
From: Daniel Scheller <d.schel...@gmx.net>
Backport to pci_enable_msi_block for kernels <3.14 (picked from upstream
dddvb package). Also, ddbridge requires the PCI_DEVICE_SUB macro, which
was added in 3.8.
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
Tested-by: Jasm
Am Sun, 27 Aug 2017 09:18:07 -0300
schrieb Mauro Carvalho Chehab <mche...@s-opensource.com>:
Thanks for looking at this.
> Em Sun, 20 Aug 2017 12:45:45 +0200
> Daniel Scheller <d.scheller@gmail.com> escreveu:
>
> > From: Daniel Scheller <d.schel...@g
From: Daniel Scheller <d.schel...@gmx.net>
Fixes apply_patches wrt
commit 5b6f9abe5a49 ("media: vb2: add bidirectional flag in vb2_queue")
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
Tested-by: Jasmin Jessich <jas...@anw.at>
---
Tested and verified by Ja
From: Daniel Scheller <d.schel...@gmx.net>
This patch adds back the IOCTL API/functionality which is present in the
upstream dddvb driver package. In comparison, the IOCTL handler has been
factored to a separate object (and with that, some functionality from
-core has been moved there
Am Sun, 9 Jul 2017 21:42:42 +0200
schrieb Daniel Scheller <d.scheller@gmail.com>:
> Hard-dependency on the STV0910/STV6111 driver+DD support series and
> the DD driver bump.
>
> This adds a driver for the MaxLinear MxL5xx tuner-demodulator series
> (a DVB-S/S2/DSS de
Am Sun, 20 Aug 2017 08:53:56 -0300
schrieb Mauro Carvalho Chehab <mche...@s-opensource.com>:
> Em Sun, 20 Aug 2017 13:08:55 +0200
> Daniel Scheller <d.scheller@gmail.com> escreveu:
>
> > From: Daniel Scheller <d.schel...@gmx.net>
> >
> > Thi
Am Sun, 20 Aug 2017 14:11:26 +0200
schrieb Daniel Scheller <d.scheller@gmail.com>:
> > Anyway, I applied today the ddbridge patches we had. I solved a few
> > conflicts while merging some things, so I'd appreciate if you could
> > check if everything is ok. If
From: Daniel Scheller <d.schel...@gmx.net>
Two cosmetics for the two new demod/tuner drivers. The stv0910 patch is
a remainder/leftover from the cleanup and cosmetic series, originally
submitted by Colin King. The second one fixes a warning I noticed in
Hans' daily build log.
@Mauro: To
From: Daniel Scheller <d.schel...@gmx.net>
Cleans up smatch warning:
symbol 'stvlist' was not declared. Should it be static?
Patch originally submitted by Colin Ian King <colin.k...@canonical.com>,
remainder after the merge of all other stv0910 fixes.
Cc: Colin Ian K
From: Daniel Scheller <d.schel...@gmx.net>
Fixes:
stv6111.c:665:24: warning: Using plain integer as NULL pointer
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
---
drivers/media/dvb-frontends/stv6111.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drive
From: Daniel Scheller <d.schel...@gmx.net>
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
---
drivers/media/dvb-frontends/stv0910.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/media/dvb-frontends/stv0910.c
b/drivers/media/dvb-fronten
From: Daniel Scheller <d.schel...@gmx.net>
Digital Devices released dddvb-0.9.31 which carries these two fixes for
the stv0910 demodulator driver.
Should go in after the seven stv0910/stv6111 cleanup patches (see [1]),
namely after [2]. They might apply cleanly without them, but they ma
From: Daniel Scheller <d.schel...@gmx.net>
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
---
drivers/media/dvb-frontends/stv0910.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/dvb-frontends/stv0910.c
b/drivers/media/dvb-frontends/stv
From: Daniel Scheller <d.schel...@gmx.net>
This further cleans up ddbridge-main from hardware-related data and moves
the exact card type determination into ddbridge-hw.c:get_ddb_info(), right
to the hardware maps/structs. Also, const'ify more structs and pointers.
Signed-off-by: Daniel Sc
From: Daniel Scheller <d.schel...@gmx.net>
Since the DD hardware info and maps aren't needed anymore outside of
ddbridge-hw.c (they're returned via get_ddb_info() now), mark them
static and remove all refs from ddbridge-hw.h.
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
---
d
From: Daniel Scheller <d.schel...@gmx.net>
Digital Devices bumped their driver package to version 0.9.31, which most
importantly carries all refactorisations which are part of the pending
mainline driver bump (bringing dddvb and the proposed kernel version much
closer to each other), and im
From: Daniel Scheller <d.schel...@gmx.net>
adapter_alloc is only used from within ddbridge-core, so move it there,
this removes the need for prototyping/referencing the variable. While at
it, msi isn't needed outside of ddbridge-main, so don't extref that one
aswell.
Signed-off-by:
From: Daniel Scheller <d.schel...@gmx.net>
Force gap setting if given by attribute and enable gap for older regmaps.
Also, setting a gap value of 128 via sysfs will now disable gap.
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
---
drivers/media/pci/ddbridge/ddbridge-core.c |
From: Daniel Scheller <d.schel...@gmx.net>
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
---
drivers/media/pci/ddbridge/ddbridge.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/ddbridge/ddbridge.h
b/drivers/media/pci/ddbridge/ddbr
From: Daniel Scheller <d.schel...@gmx.net>
All data is accessed RO, so mark everything const. Some vars in several
functions aswell as function signatures also require the const keyword
now, they're also added by this commit.
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
---
d
From: Daniel Scheller <d.schel...@gmx.net>
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
---
When the mxl5xx driver together with the ddbridge glue gets merged ([1]),
this one should go in aswell - this fix is part of the dddvb-0.9.31
release.
drivers/media/dvb-frontends/
From: Daniel Scheller <d.schel...@gmx.net>
Fixes one sparse warning:
mxl5xx.c:46:1: warning: symbol 'mxllist' was not declared. Should it be
static?
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
---
drivers/media/dvb-frontends/mxl5xx.c | 2 +-
1 file changed, 1 insertion(+)
From: Daniel Scheller <d.schel...@gmx.net>
tracking_optimization() doesn't make use of the symbol rate reported by
the demodulator, so remove the unneeded inquiry and the now unneeded
variable.
Reported-by: Richard Scobie <rasco...@slingshot.co.nz>
Cc: Ralph Metzler <r...@metzler
From: Daniel Scheller <d.schel...@gmx.net>
Stack dump when gate_ctrl() is called in a way that consecutive unlocks
happen. This is a clear indication that other drivers interfacing with
the stv0910 driver don't do things properly or don't check for failures,
so dump stack so that those d
From: Daniel Scheller <d.schel...@gmx.net>
Each field (FSTV0910_XX) is declared as reg/off/unused/sign/mask. Add
the missing offset value to the defines.
Picked up from dddvb master, commit 8a1f27c3d22c ("add field offset to field
defines")
by Ralph Metzler <r...@metzl
From: Daniel Scheller <d.schel...@gmx.net>
This series improves (and fixes) a few pending things and a few new ones
which were discovered by Richard (thanks!), removing some redundant
calls and checks here and there, and putting the symbolrate readout and
reporting to get_frontend(). The c
From: Daniel Scheller <d.schel...@gmx.net>
When a parent (demod) driver encounters and signals a problem with
gate_ctrl(), don't blindly continue poking the I2C bus.
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
Tested-by: Richard Scobie <rasco...@slingshot.co.nz>
---
From: Daniel Scheller <d.schel...@gmx.net>
The result (if any) isn't used anywhere besides being assigned to a local
variable (and the only current companion stv6111 doesn't even implement
get_if_frequency()), thus remove the ptr check and the call, and also
remove the now unused iffreq va
From: Daniel Scheller <d.schel...@gmx.net>
Utilise get_cur_symbol_rate() in get_frontend() to update the
dtv_frontend_properties with the current symbol rate as reported by the
demodulator.
Reported-by: Richard Scobie <rasco...@slingshot.co.nz>
Cc: Ralph Metzler <r...@metzlerbros
From: Daniel Scheller <d.schel...@gmx.net>
Since nothing from dvb_math.h is used, remove the unneeded include.
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
---
drivers/media/dvb-frontends/stv0910.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/dvb-fronten
Am Tue, 22 Aug 2017 17:21:16 +0200
schrieb Daniel Scheller <d.scheller@gmail.com>:
> Am Tue, 22 Aug 2017 16:05:21 +0200
> schrieb Ralph Metzler <r...@metzlerbros.de>:
>
> > Daniel Scheller writes:
> > > Am Sun, 20 Aug 2017 08:53:56 -0300
> >
gt;frontend_priv = NULL;
FWIW, this patch breaks unloading for all DVB cards in my dev system,
in that attached drivers like demod and tuner drivers won't usecount
to zero anymore ("rmmod ddbridge" keeps the usecount of stv0367 and
cxd2841er up, and "rmmod budget_av" doesn't usecount the tda10023 back
to zero).
Best regards,
Daniel Scheller
--
https://github.com/herrnst
On Sun, 17 Dec 2017 16:40:41 +0100
Daniel Scheller <d.scheller@gmail.com> wrote:
> I verified this by simply removing tda18212.ko with this DD setup:
Sorry, I forgot to outline this: I also tested by removing stv0367.ko
and cxd2841er.ko of course, which resulted in partially working
From: Daniel Scheller <d.schel...@gmx.net>
Currently, rmmod ddbridge on a KASAN enabled kernel yields this report
for hardware that utilises the tda18212 tuner driver:
[ 50.355229]
==
[ 50.355271] BUG: KASAN: use-afte
From: Daniel Scheller <d.schel...@gmx.net>
Move the CI teardown code to ddbridge-ci.c where everything else related
to CI hardware lives.
Cc: Ralph Metzler <r...@metzlerbros.de>
Signed-off-by: Daniel Scheller <d.schel...@gmx.net>
---
drivers/media/pci/ddbridge/dd
From: Daniel Scheller <d.schel...@gmx.net>
Do kfree() on port->en->data instead of port->en. port->en only holds a
ptr to a struct dvb_ca_en50221, which is a member either of a memalloc'ed
struct ddb_ci (DuoFlex CI, Octopus CI Duo) or a struct cxd (CXD2099AR
based Sing
From: Daniel Scheller <d.schel...@gmx.net>
As all error handling improved quite a bit, don't stop attaching frontends
if one of them failed, since - if other tuner modules are connected to
the PCIe bridge - other hardware may just work, so don't break on a single
port failure, but
From: Daniel Scheller <d.schel...@gmx.net>
This series improves on a few things in ddbridge:
* Fix up a KASAN report which pops up with all TDA18212-equipped hardware
by changing the order of all frontend driver teardown. This was
originally thought to be a problem of the tda18212
201 - 300 of 516 matches
Mail list logo