On 18 March 2016 at 23:29, Kevin Fitch wrote:
> Well, I just tried, and failed to reproduce those kernel log messages.
> There is a comment in one of the source file about "spammy" messages
> that show up if there is mismatch between the actual and expected
> video standards. I don't think I had t
On 21 March 2016 at 08:44, Hans Verkuil wrote:
> Hi Ezequiel,
>
> On 03/02/2016 03:30 PM, Ezequiel Garcia wrote:
>> This commit introduces the support for the Techwell TW686x video
>> capture IC. This hardware supports a few DMA modes, including
>> scatter-g
Hi Hans,
On 21 March 2016 at 08:41, Hans Verkuil wrote:
> From: Ezequiel Garcia
>
> This commit introduces the support for the Techwell TW686x video
> capture IC. This hardware supports a few DMA modes, including
> scatter-gather and frame (contiguous).
>
> This commit ma
7;t
any known differences with SAA7113, this commit does not
introduces a new saa711x_model value.
Reported-by: Philippe Desrochers
Signed-off-by: Kevin Fitch
Signed-off-by: Ezequiel Garcia
---
drivers/media/i2c/saa7115.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/driv
Signed-off-by: Ezequiel Garcia
---
drivers/media/pci/tw686x/tw686x-audio.c | 32
1 file changed, 28 insertions(+), 4 deletions(-)
diff --git a/drivers/media/pci/tw686x/tw686x-audio.c
b/drivers/media/pci/tw686x/tw686x-audio.c
index 91459ab715b2..a14d1b07edec 10
on to interlaced fields, the device can also be
programmed to deliver alternate fields. Only interlaced
mode is supported for now.
Signed-off-by: Ezequiel Garcia
---
drivers/media/pci/tw686x/Kconfig| 1 +
drivers/media/pci/tw686x/tw686x-core.c | 4 +++
drivers/media/pci/tw686x/tw686x-vi
Currently, the driver has a fixed period size of 4096 bytes
(2048 frames). Since this hardware can configure the audio
capture size, this commit allows a period size range of [512-4096].
This is very useful to reduce the audio latency.
Signed-off-by: Ezequiel Garcia
---
drivers/media/pci
to avoid adding
any complexity until we have some users demanding it.
Series based on v4.6-rc1, plus patch "media: Support
Intersil/Techwell TW686x-based video capture cards"
(https://patchwork.linuxtv.org/patch/33546/)
Ezequiel Garcia (7):
tw686x: Specify that the DMA is 32 bits
tw6
Set vb2_queue.gfp_flags to GFP_DMA32. Otherwise it will start to
create bounce buffers which is something you want to avoid since
those are in limited supply.
Without this patch, DMA scatter-gather may not work because
machines can ran out of buffers easily.
Signed-off-by: Ezequiel Garcia
Now that the driver has the infrastructure to support more
DMA modes, let's add the DMA scatter-gather mode.
In this mode, the device delivers sequential top-bottom
frames.
Signed-off-by: Ezequiel Garcia
---
drivers/media/pci/tw686x/Kconfig| 1 +
drivers/media/pci/tw686x/t
d to return the frames to userspace.
The memcpy-based method described above is named as dma_mode="memcpy".
Current alloc/free functions are renamed as tw686x_memcpy_xxx,
and are now used through a memcpy_dma_ops.
Signed-off-by: Ezequiel Garcia
---
drivers/media/pci/tw686x/tw686x-core
) if any other DMA audio channel is capturing.
Signed-off-by: Ezequiel Garcia
---
drivers/media/pci/tw686x/tw686x-audio.c | 20
drivers/media/pci/tw686x/tw686x.h | 1 +
2 files changed, 17 insertions(+), 4 deletions(-)
diff --git a/drivers/media/pci/tw686x/tw686x
On 21 Apr 08:50 AM, Hans Verkuil wrote:
> From: Hans Verkuil
>
> tw686x-video.c: In function 'tw686x_video_init':
> tw686x-video.c:65:543: warning: array subscript is above array bounds
> [-Warray-bounds]
>
> Signed-off-by: Hans Verkuil
Acked-by: Ezequiel Gar
.
>
> Signed-off-by: Hans Verkuil
Acked-by: Ezequiel Garcia
Thanks for the fixes!
> ---
> drivers/media/pci/tw686x/tw686x-video.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/pci/tw686x/tw686x-video.c
> b/drivers/media/
ded up implementing them
to get it to work. Should that be required?
(To be honest, v4lsrc is quite picky regarding parameters,
so it wouldn't be that surprising if it needs some love).
Thanks!
[1] http://www.spinics.net/lists/linux-media/msg95953.html
[2] http://www.spinics.net/lists/linux
On 23 March 2016 at 01:23, Ezequiel Garcia
wrote:
> From: Kevin Fitch
>
> It's been reported that CJC7113 devices are returning
> all 1s when reading register 0:
>
> "" found @ 0x4a (stk1160)
>
> This new device is apparently compatible
On 23 June 2017 at 05:18, Krzysztof Hałasa wrote:
> Hans Verkuil writes:
>
>> Any progress on this? I gather I can expect a new patch from someone?
>
> Well, the issue is trivial and very easy to test, though not present
> on common x86 hw. That patch I've sent fixes it, but I'm not the one who
>
mented polling read/write bits
>
> Marcel Hasler (3):
> stk1160: Remove stk1160-mixer and setup internal AC97 codec automatically.
> stk1160: Check whether to use AC97 codec.
> stk1160: Wait for completion of transfers to and from AC97 codec.
>
For the whole set:
Acked-by: Ez
The Kconfig currently makes no reference to the snd-usb-audio
driver, which supports audio capture for this type of devices.
Just in case, let's make sure the requirement is mentioned
in the description.
Signed-off-by: Ezequiel Garcia
---
drivers/media/usb/stk1160/Kconfig | 5 -
1
On 20 April 2017 at 07:10, Anuradha Ranasinghe wrote:
> Dear All,
>
> This issue is associated to the Linux Mainline Kernel 4.1.15.2 (branch2)
> tw686x upstream driver and IMX6Q platform.
>
> We have an analog camera capture board (a custom one) based around tw6865.
> We are interfacing it with Ni
Hi Krishan,
On 25 April 2017 at 03:46, Krishan Nilanga wrote:
> Hi All,
>
> gst-launch-1.0 --gst-debug=3 v4l2src device=/dev/video0 !
> video/x-raw,width=640,height=480,pixelformat=UYVY ! imxeglvivsink
>
> I have tried to run the above gstreamer pipeline and I'm getting
>
> [ 97.392807] tw686x
Hi Krzysztof,
On 10 May 2017 at 06:51, Krzysztof Hałasa wrote:
> Signed-off-by: Krzysztof Hałasa
>
> diff --git a/drivers/media/pci/tw686x/tw686x-video.c
> b/drivers/media/pci/tw686x/tw686x-video.c
> index c3fafa9..d637f47 100644
> --- a/drivers/media/pci/tw686x/tw686x-video.c
> +++ b/drivers/m
On 11 May 2017 at 04:41, Krzysztof Hałasa wrote:
> Ezequiel Garcia writes:
>
>>> + /* Initialize vc->dev and vc->ch for the error path first */
>>> + for (ch = 0; ch < max_channels(dev); ch++) {
>>> + struct tw686x_v
Randy Dunlap
Signed-off-by: Mauro Carvalho Chehab
Acked-by: Randy Dunlap
Acked-by: Ezequiel Garcia
---
drivers/media/usb/stk1160/Kconfig | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/media/usb/stk1160/Kconfig
b/drivers/media/usb/stk1160/Kconfig
i
Hi Luis,
(I'm Ccing Mauro, who mantains this driver and might know what's going on).
On Wed, Jul 31, 2013 at 03:47:10PM -0300, Luis Polasek wrote:
> Hi, I just upgraded my kernel to 3.10.3, and dib8000 scanning does not
> work anymore.
>
> I tested using dvbscan (from dvb-apps/util/) and w_scan
Hey Luis,
On Wed, Aug 07, 2013 at 03:48:33PM -0300, Luis Polasek wrote:
> Hi again Mauro, reverting both commits:
>
> * 59501bb792c66b85fb7fdbd740e788e3afc70bbd
> * f45f513a9325b52a5f3e26ee8d15471e8b692947
>
> The problem still exists, I am unable to get any result, and also no
> error logs) :
Mauro, Javier,
On Thu, Aug 22, 2013 at 02:47:33PM -0300, Javier Búcar wrote:
>
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=173a64cb3fcff1993b2aa8113e53fd379f6a968f
>
> This is a very big commit. I don't known where to fix it. Can you help
That's not a commit: tha
Hi Cees Bassa,
On Thu, Sep 19, 2013 at 02:14:57PM +0200, C. Bassa wrote:
>
> My EasyCAP DC60 device works fine in Xubuntu 12.04.3 (kernel 3.2.0)
> but when I try to use it in Xubuntu 13.04 (kernel 3.8.0) it displays a
> green screen when using mplayer, or fails to stream all together using
> chee
On Thu, Sep 19, 2013 at 05:29:42PM +0200, C. Bassa wrote:
> Hi Ezequiel and Andrew,
>
> Andrew replied to my request on his easycap forum, so I'll answer you both
> here.
>
> On Thu, Sep 19, 2013 at 2:39 PM, Ezequiel Garcia
> wrote:
> > If you have any chance
d to return the frames to userspace.
The memcpy-based method described above is named as dma_mode="memcpy".
Current alloc/free functions are renamed as tw686x_memcpy_xxx,
and are now used through a memcpy_dma_ops.
Tested-by: Tim Harvey
Signed-off-by: Ezequiel Garcia
---
drivers/me
he "FIELD" mode provided by the device.
The reason for this is that it looked quite complex, and
required a lot of changes. I'd really like to avoid adding
any complexity until we have some users demanding it.
Any feedback is welcome!
Patchset based on v4.7-rc1.
Ezequiel Garcia (6):
) if any other DMA audio channel is capturing.
Signed-off-by: Ezequiel Garcia
---
drivers/media/pci/tw686x/tw686x-audio.c | 20
drivers/media/pci/tw686x/tw686x.h | 1 +
2 files changed, 17 insertions(+), 4 deletions(-)
diff --git a/drivers/media/pci/tw686x/tw686x
Currently, the driver has a fixed period size of 4096 bytes
(2048 frames). Since this hardware can configure the audio
capture size, this commit allows a period size range of [512-4096].
This is very useful to reduce the audio latency.
Signed-off-by: Ezequiel Garcia
---
drivers/media/pci
Signed-off-by: Ezequiel Garcia
---
drivers/media/pci/tw686x/tw686x-audio.c | 32
1 file changed, 28 insertions(+), 4 deletions(-)
diff --git a/drivers/media/pci/tw686x/tw686x-audio.c
b/drivers/media/pci/tw686x/tw686x-audio.c
index 91459ab715b2..a14d1b07edec 10
on to interlaced fields, the device can also be
programmed to deliver alternate fields. Only interlaced
mode is supported for now.
Tested-by: Tim Harvey
Signed-off-by: Ezequiel Garcia
---
drivers/media/pci/tw686x/Kconfig| 1 +
drivers/media/pci/tw686x/tw686x-core.c | 4 +++
drivers/medi
ned-off-by: Ezequiel Garcia
---
drivers/media/pci/tw686x/Kconfig| 1 +
drivers/media/pci/tw686x/tw686x-core.c | 4 +
drivers/media/pci/tw686x/tw686x-video.c | 188
drivers/media/pci/tw686x/tw686x.h | 14 +++
4 files changed, 207 insertions(+)
On 27 June 2016 at 05:31, Hans Verkuil wrote:
> Users won't know what to put in this module option if it isn't
> described.
>
> Signed-off-by: Hans Verkuil
> ---
> Ezequiel, this sits on top of your tw686x patch series and will be part of
> the pull
> request.
It looks good.
Thanks!
> ---
>
Hi Mauro,
Thanks a lot for the patch.
On 27 April 2016 at 12:27, Mauro Carvalho Chehab
wrote:
> Instead of using two tables to estimate the temporal decimation
> factor, use a formula. This allows to get the closest fps, with
> sounds better than the current tables.
>
> Compile-tested only.
>
>
On 27 June 2016 at 14:38, Mauro Carvalho Chehab wrote:
> Em Mon, 27 Jun 2016 12:45:38 -0300
> Ezequiel Garcia escreveu:
>
>> Hi Mauro,
>>
>> Thanks a lot for the patch.
>>
>> On 27 April 2016 at 12:27, Mauro Carvalho Chehab
>> wrote:
>> >
ssues.
Signed-off-by: Mauro Carvalho Chehab
[Ezequiel:
- introduce a TW686X_MAX_FPS macro for max_fps.
- use hweight_long instead of open coding the set bits count.]
Signed-off-by: Ezequiel Garcia
---
Mauro,
I'm resending your patch with a cosmetic modifications.
Let me know how it looks.
dri
Now that the frame rate can be properly set, this commit adds support
for S_PARM and G_PARM.
Signed-off-by: Ezequiel Garcia
---
drivers/media/pci/tw686x/tw686x-video.c | 46 ++---
1 file changed, 43 insertions(+), 3 deletions(-)
diff --git a/drivers/media/pci/tw686x
tw686x required that driver to be updated as
> well.
> This is the patch for that.
Reviewed-by: Ezequiel Garcia
Thanks for the cleanup,
--
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the
atic?
> tw686x-video.c:361:29: warning: symbol 'sg_dma_ops' was not declared. Should
> it be static?
>
> Signed-off-by: Hans Verkuil
Acked-by: Ezequiel Garcia
Thanks!
> ---
> drivers/media/pci/tw686x/tw686x-video.c | 6 +++---
> 1 file changed, 3 insertions
On 01 Jul 12:46 PM, Hans Verkuil wrote:
> On 06/29/2016 04:17 AM, Ezequiel Garcia wrote:
> > Now that the frame rate can be properly set, this commit adds support
> > for S_PARM and G_PARM.
>
> As mentioned in our irc discussion you also need to add
> enum_framesiz
results
in frame color 'shifting', so set to four row/columns sent/skipped.
Signed-off-by: Michael Stegemann
Signed-off-by: Dale Hamel
Signed-off-by: Ezequiel Garcia
---
Changes from v2:
* Added div_round_integer to ensure the driver only
accepts width and height that results
I've removed the driver verbosity and fixed the frame scale implementation.
In addition to the usual mplayer/vlc/qv4l2, it's now tested with v4l2-compliance
on media_tree master branch.
$ v4l2-compliance -s -f:
Total: 131, Succeeded: 131, Failed: 0, Warnings: 5
Thanks,
Ezequiel
These messages are not really informational, and just makes the driver's
output too verbose. This commit changes some messages to a debug level,
removes a really useless "driver loaded" message and finally undefines
the DEBUG macro.
Signed-off-by: Ezequiel Garcia
---
drivers/me
Bits for length */
+ __le32 phys;
+};
+
+struct tw686x_vb2_buf {
+ struct vb2_buffer vb;
+ struct list_head list;
+};
+
+struct tw686x_video_channel {
+ struct tw686x_dev *dev;
+
+ struct vb2_queue vidq;
+ struct list_head vidq_queued;
+ struct video_device *de
On 6 July 2015 at 11:31, Ezequiel Garcia wrote:
> Hi Krzysztof,
>
> First of all: thanks a lot for the good work!
> The driver looks very clean and promising.
>
> I've been playing with it a lot and have quite a bit
> of feedback.
>
> First of all, I've n
This commits moves the Intersil/Techwell PCI vendor ID, and
the device IDs for the TW68 PCI video capture cards.
This will allow to support future Intersil/Techwell devices
without duplicating the IDs.
Signed-off-by: Ezequiel Garcia
---
drivers/media/pci/tw68/tw68-core.c | 15
This commits moves the Intersil/Techwell PCI vendor ID, and
the device IDs for the TW68 PCI video capture cards.
This will allow to support future Intersil/Techwell devices
without duplicating the IDs.
Signed-off-by: Ezequiel Garcia
---
v2:
* Fixed three additional uses of the defines I missed
Hi everyone,
In case anyone is interested in this device, I'm maintaining an
out-of-tree driver:
https://bitbucket.org/vanguardiasur/tw686x/
It supports audio and DMA frame/S-G modes (with a module parameter).
Testing and bug reports are welcome :-)
--
Ezequiel García, VanguardiaSur
www.vangua
On 12 August 2015 at 03:05, Krzysztof Hałasa wrote:
> Hi Ezequiel,
>
> OTOH I don't see any reason preventing you from sending a pull request
> for the inclusion of the TW686x driver, Mauro could merge this stuff
> then (assuming it's ready).
>
> You don't have to wait for me and a driver doesn't
Marcel,
Thanks a lot for all your stk1160 fixes. They are much appreciated! In
particular,
the click noise was something we really wanted to get rid of:
http://mailman.alsa-project.org/pipermail/alsa-devel/2016-October/113981.html
Regarding the linux-media fixes, is there any chance you re-submi
Marcel,
On 27 October 2016 at 17:34, Marcel Hasler wrote:
> Exposing all the channels of the device's internal AC97 codec to userspace is
> unnecessary and
> confusing. Instead the driver should setup the codec with proper values. This
> patch removes the
> mixer and sets up the codec using opt
On 27 October 2016 at 17:35, Marcel Hasler wrote:
> Allow setting a custom record gain for the internal AC97 codec (if
> available). This can be
> a value between 0 and 15, 8 is the default and should be suitable for most
> users. The Windows
> driver also sets this to 8 without any possibility
On 28 October 2016 at 05:52, Marcel Hasler wrote:
> The STK1160 needs some time to transfer data from the AC97 registers into its
> own. On some
> systems reading the chip's own registers to soon will return wrong values.
> The "proper" way to
> handle this would be to poll STK1160_AC97CTL_0 aft
On 27 October 2016 at 17:34, Marcel Hasler wrote:
> Some STK1160-based devices use the chip's internal 8-bit ADC. This is
> configured through a strap
> pin. The value of this and other pins can be read through the POSVA register.
> If the internal
> ADC is used, there's no point trying to setup
On 26 November 2016 at 10:38, Marcel Hasler wrote:
> Hello, and thanks for your feedback.
>
> 2016-11-20 18:36 GMT+01:00 Ezequiel Garcia :
>> Marcel,
>>
>> On 27 October 2016 at 17:34, Marcel Hasler wrote:
>>> Exposing all the channels of the device's
On 26 November 2016 at 10:52, Marcel Hasler wrote:
> 2016-11-20 18:36 GMT+01:00 Ezequiel Garcia :
>> On 27 October 2016 at 17:35, Marcel Hasler wrote:
>>> Allow setting a custom record gain for the internal AC97 codec (if
>>> available). This can be
>>>
ler (4):
> stk1160: Remove stk1160-mixer and setup internal AC97 codec automatically.
> stk1160: Check whether to use AC97 codec.
> stk1160: Add module param for setting the record gain.
> stk1160: Give the chip some time to retrieve data from AC97 codec.
>
For the whole se
On 2 December 2016 at 08:09, Mauro Carvalho Chehab
wrote:
> Em Sun, 27 Nov 2016 12:12:36 +0100
> Marcel Hasler escreveu:
>
>> The STK1160 needs some time to transfer data from the AC97 registers into
>> its own. On some
>> systems reading the chip's own registers to soon will return wrong values
On 2 December 2016 at 08:05, Mauro Carvalho Chehab
wrote:
> Em Sun, 27 Nov 2016 12:11:48 +0100
> Marcel Hasler escreveu:
>
>> Allow setting a custom record gain for the internal AC97 codec (if
>> available). This can be
>> a value between 0 and 15, 8 is the default and should be suitable for mos
On 4 December 2016 at 10:01, Marcel Hasler wrote:
> Hello
>
> 2016-12-03 21:46 GMT+01:00 Ezequiel Garcia :
>> On 2 December 2016 at 08:05, Mauro Carvalho Chehab
>> wrote:
>>> Em Sun, 27 Nov 2016 12:11:48 +0100
>>> Marcel Hasler escreveu:
>>>
On 5 December 2016 at 09:12, Mauro Carvalho Chehab
wrote:
> Em Sun, 4 Dec 2016 15:25:25 -0300
> Ezequiel Garcia escreveu:
>
>> On 4 December 2016 at 10:01, Marcel Hasler wrote:
>> > Hello
>> >
>> > 2016-12-03 21:46 GMT+01:00 Ezequiel Garcia :
>>
On 5 December 2016 at 18:06, Marcel Hasler wrote:
> Hello
>
> 2016-12-05 16:38 GMT+01:00 Ezequiel Garcia :
>> On 5 December 2016 at 09:12, Mauro Carvalho Chehab
>> wrote:
>>> Em Sun, 4 Dec 2016 15:25:25 -0300
>>> Ezequiel Garcia escreveu:
>>>
On 5 December 2016 at 18:18, Marcel Hasler wrote:
> 2016-12-05 22:06 GMT+01:00 Marcel Hasler :
>> Hello
>>
>> 2016-12-05 16:38 GMT+01:00 Ezequiel Garcia :
>>> On 5 December 2016 at 09:12, Mauro Carvalho Chehab
>>> wrote:
>>>> Em Sun, 4 Dec
.
Reported-by: Hans Verkuil
Signed-off-by: Ezequiel Garcia
---
drivers/media/pci/tw686x/tw686x-video.c | 139 +++-
1 file changed, 81 insertions(+), 58 deletions(-)
diff --git a/drivers/media/pci/tw686x/tw686x-video.c
b/drivers/media/pci/tw686x/tw686x-video.c
index
clear: some devices haven't a frame size discrete
enumeration, but have discrete frame rate. Having a way
to set the frame rate from the qv4l2 tool would be very useful.
Signed-off-by: Ezequiel Garcia
---
utils/qv4l2/general-tab.cpp | 14 +-
1 file changed, 5 insertions(+), 9 dele
element is NULL.
Fixes: c88a96b023d8 ('[media] vivid: add core driver code')
Signed-off-by: Ezequiel Garcia
---
drivers/media/platform/vivid/vivid-core.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/vivid/vivid-core.c
b/drivers/media/plat
The vivid driver currently has a hard-coded limit of 64 devices,
however there's nothing that prevents the creation of even more devices.
This commit adds a new driver option (which defaults to 64) to
allow this maximum number to be configurable.
Signed-off-by: Ezequiel Garcia
---
drivers/
Hi Philippe,
Ccing the linux-media ML. Please don't reply dropping the Cc!
2015-12-02 11:58 GMT-03:00 Philippe Desrochers :
> Hello Ezequiel,
>
> I'm using your stk1160 driver with some EasyCap (china) clone and it is
> working fine.
>
> However, a few days ago, I bought two Sabrent USB-AVCPT and
On 2 December 2015 at 14:43, Philippe Desrochers
wrote:
> I'm sending the email again (in plain text) since it seems it was blocked by
> the server.
>
> EASYCAP CHINA CLONE (OK):
> [ 8630.596236] usb 2-1: new high-speed USB device number 6 using ehci-pci
> [ 8630.729074] usb 2-1: New USB device fo
On 5 December 2015 at 01:29, Philippe Desrochers
wrote:
> The difference seems to be around the "saa7113" chip. Maybe the Sabrent is
> using another video decoder chip ?
Yes, I believe that would explain the kernel log you sent.
> I will open one and check the chips on the PCB.
>
OK, that would
(shoot, we dropped the ML somewhere along the conversation)
>> On 7 December 2015 at 12:32, Philippe Desrochers
>> wrote:
>> > Hello again,
>> >
>> > I open the device and I saw the following chips:
>> >
>> > SYNTEK:
>> > STK1160DLQG
>> > D7A155G-1513
>> >
>> > VIDEO DECODER:
>> > CJC7113
>> >
>>
, results
in frame color 'shifting'.
Signed-off-by: Michael Stegemann
Signed-off-by: Dale Hamel
Signed-off-by: Ezequiel Garcia
---
drivers/media/usb/stk1160/stk1160-reg.h | 34 ++
drivers/media/usb/stk1160/stk1160-v4l.c | 178 +++-
2 files changed, 184
[] stk1160_try_fmt.isra.5+0x1ba/0x1e0
> [stk1160]
> [ 180.136366] RSP
> [ 180.139977] ---[ end trace a699ade0cf2b43de ]---
>
> So this needs a bit more work... Remember: v4l2-compliance is your friend! :-)
>
Indeed, sorry about that.
> I didn't review the patch, t
These messages are not really informational, and just makes the driver's
output too verbose. This commit changes some messages to a debug level,
removes a really useless "driver loaded" message and finally undefines
the DEBUG macro.
Signed-off-by: Ezequiel Garcia
---
drivers/me
returned 0 (Success)
VIDIOC_QUERYCTRL returned 0 (Success)
VIDIOC_G_SELECTION returned -1 (Inappropriate ioctl for device)
Total: 115, Succeeded: 113, Failed: 2, Warnings: 5
Thanks,
Ezequiel Garcia (2):
stk1160: Reduce driver verbosity
stk1160: Add frame scaling support
drivers/media/usb/st
, results
in frame color 'shifting'.
Signed-off-by: Michael Stegemann
Signed-off-by: Dale Hamel
Signed-off-by: Ezequiel Garcia
---
Changes from v1:
* Clamp width and height in stk1160_try_fmt, this guarantees
sane values are given to the driver.
drivers/media/usb/stk1160/stk
On 06/08/2015 07:02 AM, Hans Verkuil wrote:
> Hi Ezequiel,
>
> On 06/07/2015 12:26 AM, Ezequiel Garcia wrote:
>> I've removed the driver verbosity and fixed the frame scale implementation.
>> In addition to the usual mplayer/vlc/qv4l2, it's tested with v4l2-c
Mauro,
On Tue, Oct 23, 2012 at 4:57 PM, Ezequiel Garcia wrote:
> This kind of memcpy() is error-prone. Its replacement with a struct
> assignment is prefered because it's type-safe and much easier to read.
>
> Found by coccinelle. Hand patched and reviewed.
> Tested by com
Hi everyone,
Some stk1160 users (a lot acually) are reporting that stk1160 is broken.
The reports come in the out of tree driver [1], but probably the issue
is in mainline too.
Now, it seems to me the problem is the saa711x decoder can't get matched,
see a portion of dmesg.
[89947.448813] usb 1-
Ccing a few more people to get some feedback.
Toughts anyone? Have you ever seen this before?
On Fri, Dec 28, 2012 at 11:13 AM, Ezequiel Garcia wrote:
> Hi everyone,
>
> Some stk1160 users (a lot acually) are reporting that stk1160 is broken.
> The reports come in the out of tr
Hi Hans,
On Sat, Dec 29, 2012 at 12:10 PM, Hans Verkuil wrote:
> On Sat December 29 2012 15:25:08 Ezequiel Garcia wrote:
>> Ccing a few more people to get some feedback.
>>
>> Toughts anyone? Have you ever seen this before?
>>
>> On Fri, Dec 28, 2012 at 11:
On Fri, Jan 4, 2013 at 4:41 PM, Devin Heitmueller
wrote:
[snip]
> are available in the git repository at:
>
> git://git.kernellabs.com/dheitmueller/linuxtv.git v39staging
>
> for you to fetch changes up to 381abfc158c2dad81a558a3d3ff924fc7f80d277:
>
> em28xx: convert to videobuf2 (2013-01-04 1
On Wed, Jan 9, 2013 at 9:19 PM, Laurent Pinchart
wrote:
> Hi Ezequiel,
>
> On Thursday 27 December 2012 21:49:37 Mauro Carvalho Chehab wrote:
>> Em Thu, 27 Dec 2012 18:12:46 -0300 Ezequiel Garcia escreveu:
>> > On Tue, Oct 23, 2012 at 4:57 PM, Ezequiel Garcia wrote:
&g
This kind of memcpy() is error-prone. Its replacement with a struct
assignment is prefered because it's type-safe and much easier to read.
Cc: Laurent Pinchart
Signed-off-by: Peter Senna Tschudin
Signed-off-by: Ezequiel Garcia
---
Changes from v1:
* Replaced a memcpy() in ucv_ctrl_add
Hi Volokh,
On Wed, Jan 16, 2013 at 10:42 AM, Volokh Konstantin wrote:
> On Wed, Jan 16, 2013 at 04:35:45PM +0300, Dan Carpenter wrote:
>> The problem is that the firmware was being unloaded on disconnect?
>>
> If no firmware was loaded (no exists,wrong or some error) then rmmod fails
> with OOPS
Hello Hans,
On Mon, Feb 4, 2013 at 9:36 AM, Hans Verkuil wrote:
> This patch series updates this driver to the control framework, switches
> it to unlocked_ioctl, fixes a variety of V4L2 compliance issues.
>
> It compiles, but to my knowledge nobody has hardware to test this :-(
>
> If anyone has
Hi Joe,
On Sat, Feb 2, 2013 at 4:43 PM, Joe Perches wrote:
> On Sat, 2013-02-02 at 16:30 -0300, Ezequiel Garcia wrote:
>> ptr = kmalloc(sizeof(foo));
>> if (!ptr) {
>> pr_err("Cannot allocate memory for foo\n");
>> return -ENOMEM;
>>
On Tue, Feb 5, 2013 at 12:35 PM, Hans Verkuil wrote:
> On Tue February 5 2013 16:28:17 Arvydas Sidorenko wrote:
>> On Mon, Feb 4, 2013 at 2:35 PM, Hans Verkuil wrote:
>> >
>> > Hi Arvydas,
>> >
>> > Yes indeed, it would be great if you could test this!
>> >
>> > Note that the patch series is also
Hi Ismael,
On Thu, Feb 21, 2013 at 7:53 PM, Ismael Luceno wrote:
> Signed-off-by: Ismael Luceno
> ---
> MAINTAINERS | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 3b95564..eb277c9 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@
These arrays were embedded in the struct itself, but they weren't
used by anyone, since urbs are now dinamically allocated
at em28xx_usb_isoc_ctl struct.
Tested by compilation only.
Signed-off-by: Ezequiel Garcia
---
drivers/media/video/em28xx/em28xx.h |3 ---
1 files changed, 0 inser
This patch saves 255 bytes of stack on usb_probe() by removing
a char array. In some platforms this is represents a substantial save.
Signed-off-by: Ezequiel Garcia
---
drivers/media/video/em28xx/em28xx-cards.c | 19 ---
1 files changed, 4 insertions(+), 15 deletions(-)
diff
This patch saves 255 bytes of stack on usb_probe() by removing
a char array. In some platforms this is represents a substantial save.
Signed-off-by: Ezequiel Garcia
---
Previous patch was sent as 2/2 by mistake
---
drivers/media/video/em28xx/em28xx-cards.c | 19 ---
1 files
This changes rc_core to not load the IR decoders at load time,
postponing it to load only if a RC_DRIVER_IR_RAW device is registered
via rc_register_device.
Signed-off-by: Ezequiel Garcia
---
drivers/media/rc/rc-main.c |8 ++--
include/media/rc-core.h|2 ++
2 files changed, 8
: Ezequiel Garcia
---
v2: Fix broken logic in v1.
Also, put raw_init as static instead of inside rc_dev
struct to ensure loading is only tried the first time.
---
drivers/media/rc/rc-main.c | 11 +--
1 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/media/rc/rc
: Ezequiel Garcia
---
v3: Fix scope of static bool: now it is local to relevant function.
v2: Fix broken logic in v1.
Also, put raw_init as static instead of inside rc_dev
struct to ensure loading is only tried the first time.
---
drivers/media/rc/rc-main.c |9 +++--
1 files changed, 7
Signed-off-by: Ezequiel Garcia
---
drivers/media/video/em28xx/em28xx-i2c.c |8
1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/drivers/media/video/em28xx/em28xx-i2c.c
b/drivers/media/video/em28xx/em28xx-i2c.c
index 36f5a9b..a88e169 100644
--- a/drivers/media/video
601 - 700 of 1062 matches
Mail list logo
