Re: [RFC/PATCH v3 6/7] omap3: Export omap3isp platform device structure

Hi, On Thu, Nov 25, 2010 at 12:17:59PM +0100, Laurent Pinchart wrote: pass platform_data as an argument to this call ? Then remove the static inline and export this one ? Yes indeed, why ? :-) I guess things like that are difficult to spot when you've had your nose on the code for too long.

Re: [RFC V10 1/7] drivers:media:radio: wl128x: FM Driver common header file

Hi, On Tue, Jan 11, 2011 at 06:31:21AM -0500, manjunatha_ha...@ti.com wrote: From: Manjunatha Halli manjunatha_ha...@ti.com These are common headers used in FM submodules (FM V4L2, FM common, FM Rx,and FM TX). Signed-off-by: Manjunatha Halli manjunatha_ha...@ti.com Reviewed-by: Hans

Re: [RFC V10 2/7] drivers:media:radio: wl128x: FM Driver V4L2 sources

On Tue, Jan 11, 2011 at 06:31:22AM -0500, manjunatha_ha...@ti.com wrote: From: Manjunatha Halli manjunatha_ha...@ti.com This module interfaces V4L2 subsystem and FM common module. It registers itself with V4L2 as Radio module. Signed-off-by: Manjunatha Halli manjunatha_ha...@ti.com

Re: [RFC V10 3/7] drivers:media:radio: wl128x: FM Driver Common sources

Hi, On Tue, Jan 11, 2011 at 06:31:23AM -0500, manjunatha_ha...@ti.com wrote: From: Manjunatha Halli manjunatha_ha...@ti.com These are the sources for the common interfaces required by the FM V4L2 driver for TI WL127x and WL128x chips. These implement the FM channel-8 protocol

Re: [RFC V10 6/7] drivers:media:radio: wl128x: Kconfig Makefile for wl128x driver

Hi, On Tue, Jan 11, 2011 at 06:31:26AM -0500, manjunatha_ha...@ti.com wrote: diff --git a/drivers/media/radio/wl128x/Makefile b/drivers/media/radio/wl128x/Makefile new file mode 100644 index 000..32a0ead --- /dev/null +++ b/drivers/media/radio/wl128x/Makefile @@ -0,0 +1,6 @@ +# +#

Re: [PATCH v6 02/10] omap3: Remove unusued ISP CBUFF resource

On Mon, Feb 14, 2011 at 01:21:29PM +0100, Laurent Pinchart wrote: From: Sergio Aguirre saagui...@ti.com The ISP CBUFF module isn't use, its resource isn't needed. Signed-off-by: Sergio Aguirre saagui...@ti.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Tony

Re: [PATCH v6 03/10] omap3: Add function to register omap3isp platform device structure

Hi, On Mon, Feb 14, 2011 at 01:21:30PM +0100, Laurent Pinchart wrote: diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c index d389756..4cf48ea 100644 --- a/arch/arm/mach-omap2/devices.c +++ b/arch/arm/mach-omap2/devices.c @@ -34,6 +34,8 @@ #include mux.h #include

Re: [PATCH v6 04/10] omap2: Fix camera resources for multiomap

Hi, On Mon, Feb 14, 2011 at 01:21:31PM +0100, Laurent Pinchart wrote: diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c index 4cf48ea..5d844bd 100644 --- a/arch/arm/mach-omap2/devices.c +++ b/arch/arm/mach-omap2/devices.c @@ -38,7 +38,7 @@ #if

Re: [PATCH v6 07/10] omap3isp: CCP2/CSI2 receivers

On Mon, Feb 14, 2011 at 01:21:34PM +0100, Laurent Pinchart wrote: The OMAP3 ISP CCP2 and CSI2 receivers provide an interface to connect serial MIPI sensors to the device. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Signed-off-by: Sakari Ailus sakari.ai...@iki.fi

Re: [PATCH v6 03/10] omap3: Add function to register omap3isp platform device structure

Hi, On Mon, Feb 14, 2011 at 02:07:08PM +0100, Laurent Pinchart wrote: diff --git a/arch/arm/mach-omap2/devices.h b/arch/arm/mach-omap2/devices.h new file mode 100644 index 000..12ddb8a --- /dev/null +++ b/arch/arm/mach-omap2/devices.h @@ -0,0 +1,17 @@ +/* + *

Re: [PATCH v6 04/10] omap2: Fix camera resources for multiomap

Hi, On Mon, Feb 14, 2011 at 02:19:24PM +0100, Laurent Pinchart wrote: Thanks for the review. np. On Monday 14 February 2011 13:35:59 Felipe Balbi wrote: On Mon, Feb 14, 2011 at 01:21:31PM +0100, Laurent Pinchart wrote: diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2

Re: [PATCH resend] video: omap24xxcam: Fix compilation

On Tue, Feb 15, 2011 at 01:28:19PM +0200, Sakari Ailus wrote: Thomas Weber wrote: Add linux/sched.h because of missing declaration of TASK_NORMAL. This patch fixes the following error: drivers/media/video/omap24xxcam.c: In function 'omap24xxcam_vbq_complete':

Re: [PATCH resend] video: omap24xxcam: Fix compilation

Hi, On Sat, Feb 19, 2011 at 01:35:09PM +0200, David Cohen wrote: aha, now I get it, so shouldn't the real fix be including linux/sched.h on linux/wait.h, I mean, it's linuux/wait.h who uses a symbol defined in linux/sched.h, right ? That's a tricky situation. linux/sched.h includes

Re: [PATCH resend] video: omap24xxcam: Fix compilation

Hi, On Sat, Feb 19, 2011 at 06:04:58PM +0200, David Cohen wrote: I have to disagree. The fundamental problem is the circular dependency between those two files: sched.h uses wait_queue_head_t defined in wait.h wait.h uses TASK_* defined in sched.h So, IMO the real fix would be clear

Re: [PATCH resend] video: omap24xxcam: Fix compilation

On Mon, Feb 21, 2011 at 02:09:07PM +0200, David Cohen wrote: On Mon, Feb 21, 2011 at 9:36 AM, Felipe Balbi ba...@ti.com wrote: Hi, On Sat, Feb 19, 2011 at 06:04:58PM +0200, David Cohen wrote: I have to disagree. The fundamental problem is the circular dependency between those two

Re: [PATCH 1/1] headers: fix circular dependency between linux/sched.h and linux/wait.h

On Mon, Feb 21, 2011 at 01:05:51PM +0200, Alexey Dobriyan wrote: On Mon, Feb 21, 2011 at 12:20 PM, David Cohen daco...@gmail.com wrote: Currently sched.h and wait.h have circular dependency between both. wait.h defines macros wake_up*() which use macros TASK_* defined by sched.h. But as

Re: [PATCH 1/1] headers: fix circular dependency between linux/sched.h and linux/wait.h

Hi, On Mon, Feb 21, 2011 at 03:51:25PM +0200, Alexey Dobriyan wrote: I rather have the split done and kill the circular dependency. It's not circular for starters. how come ? wait.h depends on sched and sched.h depends on wait.h -- balbi -- To unsubscribe from this list: send the line

Re: [PATCH 1/1] headers: fix circular dependency between linux/sched.h and linux/wait.h

Hi, On Mon, Feb 21, 2011 at 04:05:14PM +0200, David Cohen wrote: On Mon, Feb 21, 2011 at 3:57 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Mon, Feb 21, 2011 at 03:51:25PM +0200, Alexey Dobriyan wrote: I rather have the split done and kill the circular dependency. It's not circular

Re: [PATCH v2 1/1] headers: fix circular dependency between linux/sched.h and linux/wait.h

Hi, On Mon, Feb 21, 2011 at 05:20:45PM +0100, Peter Zijlstra wrote: I think Alexey already told you what you done wrong. Also, I really don't like the task_state.h header, it assumes a lot of things it doesn't include itself and only works because its using macros and not inlines

Re: [PATCH v2 1/1] headers: fix circular dependency between linux/sched.h and linux/wait.h

Hi, On Mon, Feb 21, 2011 at 05:43:27PM +0100, Peter Zijlstra wrote: And then make sched.c include signal.h and completion.h. you wouldn't prevent the underlying problem which is the need to include sched.h whenever you include wait.h and use wake_up*() If you'd applied your brain for

Re: [PATCH v2 1/1] headers: fix circular dependency between linux/sched.h and linux/wait.h

On Mon, Feb 21, 2011 at 06:06:02PM +0100, Peter Zijlstra wrote: On Mon, 2011-02-21 at 18:54 +0200, Felipe Balbi wrote: What you seem to have missed is that sched.h doesn't include wait.h, it includes completion.h and completion.h needs wait.h due the wait_queue_head_t it uses. Yeah, so

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

Hi, On Wed, Apr 06, 2011 at 08:47:34PM +0200, Samuel Ortiz wrote: What is a MFD cell pointer and why is it needed in struct device? An MFD cell is an MFD instantiated device. MFD (Multi Function Device) drivers instantiate platform devices. Those devices drivers sometimes need a

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

Hi, On Wed, Apr 06, 2011 at 03:09:00PM -0700, Greg KH wrote: On Wed, Apr 06, 2011 at 09:59:02PM +0300, Felipe Balbi wrote: Hi, On Wed, Apr 06, 2011 at 08:47:34PM +0200, Samuel Ortiz wrote: What is a MFD cell pointer and why is it needed in struct device? An MFD cell is an MFD

Re: Improving kernel - userspace (usbfs) usb device hand off

Hi, On Fri, Jun 10, 2011 at 09:55:13AM +0200, Hans de Goede wrote: Currently this will cause the usb mass storage driver to see a disconnect, and any possible still pending writes are lost ... This is IMHO unacceptable, but currently there is nothing we can do to avoid this. 2) So called

Re: Improving kernel - userspace (usbfs) usb device hand off

Hi, On Fri, Jun 10, 2011 at 10:36:47AM +0200, Hans de Goede wrote: On Fri, Jun 10, 2011 at 09:55:13AM +0200, Hans de Goede wrote: Currently this will cause the usb mass storage driver to see a disconnect, and any possible still pending writes are lost ... This is IMHO unacceptable, but

Re: Improving kernel - userspace (usbfs) usb device hand off

Hi, On Fri, Jun 10, 2011 at 02:19:20PM +0200, Hans de Goede wrote: So what do we need to make this situation better: 1) A usb_driver callback alternative to the disconnect callback, I propose to call this soft_disconnect. This serves 2 purposes a) It will allow the driver to tell the

Re: Improving kernel - userspace (usbfs) usb device hand off

Hi, On Fri, Jun 10, 2011 at 01:16:47PM -0500, Theodore Kilgore wrote: As I have been involved in writing the drivers (both the kernel and the libgphoto2 drivers) for many of the affected cameras, perhaps I should expand on this problem. There are lots of responses to this original message

Re: Improving kernel - userspace (usbfs) usb device hand off

Hi, On Fri, Jun 10, 2011 at 05:18:39PM -0400, Alan Stern wrote: 2. Until recently in the history of Linux, there was an irreconcilable conflict. If a kernel driver for the video streaming mode was present and installed, it was not possible to use the camera in stillcam mode at all.

Re: Improving kernel - userspace (usbfs) usb device hand off

Hi, On Fri, Jun 10, 2011 at 05:43:06PM -0500, Theodore Kilgore wrote: there's nothing in the USB spec that says you need different product IDs for different modes of operation. No matter if it's still or webcam configuration, the underlying function is the same: capture images using a set

Re: [PATCH 1/5] MT9P012: Add driver

Hi, not looking at v4l2 part since it's not my area... On Tue, Mar 03, 2009 at 09:44:14PM +0100, ext Aguirre Rodriguez, Sergio Alberto wrote: +#define SENSOR_DETECTED1 +#define SENSOR_NOT_DETECTED0 these two should be unneeded... + +/** + * struct mt9p012_reg -

Re: [PATCH 4/5] usb: gadget/uvc: Port UVC webcam gadget to use videobuf2 framework

On Fri, Jun 01, 2012 at 03:08:57PM +0530, Bhupesh Sharma wrote: This patch reworks the videobuffer management logic present in the UVC webcam gadget and ports it to use the more apt videobuf2 framework for video buffer management. To support routing video data captured from a real V4L2 video

Re: [PATCH 4/5] usb: gadget/uvc: Port UVC webcam gadget to use videobuf2 framework

On Mon, Jun 04, 2012 at 11:21:13PM +0800, Bhupesh SHARMA wrote: Hi Felipe, -Original Message- From: Felipe Balbi [mailto:ba...@ti.com] Sent: Monday, June 04, 2012 8:44 PM To: Bhupesh SHARMA Cc: laurent.pinch...@ideasonboard.com; linux-...@vger.kernel.org; ba...@ti.com; linux

Re: [PATCH 4/5] usb: gadget/uvc: Port UVC webcam gadget to use videobuf2 framework

Hi, On Mon, Jun 04, 2012 at 11:37:59PM +0800, Bhupesh SHARMA wrote: -Original Message- From: Felipe Balbi [mailto:ba...@ti.com] Sent: Monday, June 04, 2012 8:59 PM To: Bhupesh SHARMA Cc: ba...@ti.com; laurent.pinch...@ideasonboard.com; linux- u...@vger.kernel.org; linux-media

Re: [PATCH 4/5] usb: gadget/uvc: Port UVC webcam gadget to use videobuf2 framework

On Mon, Jun 04, 2012 at 06:40:46PM +0200, Laurent Pinchart wrote: Hi Felipe, On Monday 04 June 2012 18:28:33 Felipe Balbi wrote: On Mon, Jun 04, 2012 at 11:21:13PM +0800, Bhupesh SHARMA wrote: On Monday, June 04, 2012 8:44 PM Felipe Balbi wrote: On Fri, Jun 01, 2012 at 03:08:57PM

Re: [PATCH v11 0/8] PHY framework

On Wed, Sep 04, 2013 at 02:27:06PM +0530, Kishon Vijay Abraham I wrote: On Tuesday 03 September 2013 09:20 PM, Greg KH wrote: On Tue, Sep 03, 2013 at 08:55:23PM +0530, Kishon Vijay Abraham I wrote: Hi Greg, On Wednesday 28 August 2013 12:50 AM, Felipe Balbi wrote: Hi, On Mon, Aug 26

Re: [PATCH 42/51] DMA-API: usb: musb: use platform_device_register_full() to avoid directly messing with dma masks

callbacks, which may be called during the musb device probing. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk you want me to carry this one through my tree or you prefer getting my Acked-by ? Either way works for me: Acked-by: Felipe Balbi ba...@ti.com there's also the third option of me

Re: [PATCH 42/51] DMA-API: usb: musb: use platform_device_register_full() to avoid directly messing with dma masks

Hi, On Fri, Sep 20, 2013 at 02:49:38PM +0100, Russell King - ARM Linux wrote: On Fri, Sep 20, 2013 at 08:11:25AM -0500, Felipe Balbi wrote: Hi, On Fri, Sep 20, 2013 at 12:14:38AM +0100, Russell King wrote: Use platform_device_register_full() for those drivers which can, to avoid

Re: [PATCH 1/7] ir-rx51: Handle signals properly

Hi, On Fri, Dec 14, 2012 at 09:28:09AM -0800, Tony Lindgren wrote: * Tony Lindgren t...@atomide.com [121120 12:00]: Hi, * Timo Kokkonen timo.t.kokko...@iki.fi [121118 07:15]: --- a/drivers/media/rc/ir-rx51.c +++ b/drivers/media/rc/ir-rx51.c @@ -74,6 +74,19 @@ static void

Re: [PATCH 1/7] ir-rx51: Handle signals properly

Hi, On Fri, Dec 14, 2012 at 09:46:29AM -0800, Tony Lindgren wrote: * Felipe Balbi ba...@ti.com [121214 09:36]: Hi, On Fri, Dec 14, 2012 at 09:28:09AM -0800, Tony Lindgren wrote: * Tony Lindgren t...@atomide.com [121120 12:00]: Hi, * Timo Kokkonen timo.t.kokko...@iki.fi

Re: [PATCH 1/7] ir-rx51: Handle signals properly

Hi, On Fri, Dec 14, 2012 at 10:06:45AM -0800, Tony Lindgren wrote: * Felipe Balbi ba...@ti.com [121214 09:59]: On Fri, Dec 14, 2012 at 09:46:29AM -0800, Tony Lindgren wrote: * Felipe Balbi ba...@ti.com [121214 09:36]: if it's really for PWM, shouldn't we be using drivers/pwm

Re: [PATCHv3 5/6] media: Convert struct i2c_msg initialization to C99 format

. FWIW: Reviewed-by: Felipe Balbi ba...@ti.com Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com --- drivers/media/radio/saa7706h.c | 15 +-- 1 files changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/media/radio/saa7706h.c b/drivers/media/radio/saa7706h.c index

Re: [balbi-usb:i2c-transferred-bytes-on-NACK 7/9] drivers/media/i2c/adv7604.c:406:9: warning: initialization makes integer from pointer without a cast

Hi, On Wed, Oct 24, 2012 at 09:23:23PM +0800, Fengguang Wu wrote: Sorry, this should really be CCed to the media list. I'll use the list recommended by get_maintainer.pl in future. Actually, I would suggest only testing the following branches from my tree: dwc3, musb, xceiv, gadget and fixes

Re: [PATCH v2 1/5] phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs

Hi, On Tue, Jun 25, 2013 at 04:21:46PM +0200, Sylwester Nawrocki wrote: +enum phy_id { + PHY_CSIS0, + PHY_DSIM0, + PHY_CSIS1, + PHY_DSIM1, + NUM_PHYS please prepend these with EXYNOS_PHY_ or EXYNOS_MIPI_PHY_ +struct exynos_video_phy { + spinlock_t slock; +

Re: [PATCH v2 3/5] video: exynos_mipi_dsim: Use generic PHY driver

Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com this is awesome :-) Acked-by: Felipe Balbi ba...@ti.com -- balbi signature.asc Description: Digital signature

Re: [PATCH v2 4/5] exynos4-is: Use generic MIPI CSIS PHY driver

s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Felipe Balbi ba...@ti.com -- balbi signature.asc Description: Digital signature

Re: [PATCH v2 5/5] ARM: Samsung: Remove MIPI PHY setup code

currently) it should use the generic PHY API to bind the PHYs to respective PHY consumer drivers. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com pretty cool stuff Acked-by: Felipe Balbi ba...@ti.com -- balbi signature.asc

Re: [PATCH v2 1/5] phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs

Hi, On Tue, Jun 25, 2013 at 07:44:52PM +0200, Sylwester Nawrocki wrote: +struct exynos_video_phy { + spinlock_t slock; + struct phy *phys[NUM_PHYS]; more than one phy ? This means you should instantiate driver multiple drivers. Each phy id should call probe again. Why ? This

Re: [PATCH v2 1/5] phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs

On Tue, Jun 25, 2013 at 11:47:13PM +0200, Sylwester Nawrocki wrote: Hi, On 06/25/2013 10:54 PM, Felipe Balbi wrote: +static int exynos_video_phy_probe(struct platform_device *pdev) +{ + struct exynos_video_phy *state; + struct device *dev =pdev-dev; + struct resource

Re: [PATCH v2 1/5] phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs

On Wed, Jun 26, 2013 at 02:03:42PM +0200, Sylwester Nawrocki wrote: On 06/26/2013 01:21 PM, Kishon Vijay Abraham I wrote: +static int exynos_video_phy_probe(struct platform_device *pdev) +{ + struct exynos_video_phy *state; + struct device *dev = pdev-dev; + struct resource *res;

Re: [PATCH v2 1/5] phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs

On Wed, Jun 26, 2013 at 05:00:34PM +0200, Sylwester Nawrocki wrote: Hi, On 06/25/2013 05:06 PM, Felipe Balbi wrote: +static struct platform_driver exynos_video_phy_driver = { +.probe = exynos_video_phy_probe, you *must* provide a remove method. drivers with NULL remove

Re: [PATCH v2 1/5] phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs

On Thu, Jun 27, 2013 at 09:47:47AM +0200, Andrzej Hajda wrote: Hi Felipe, On 06/27/2013 08:17 AM, Felipe Balbi wrote: On Wed, Jun 26, 2013 at 05:00:34PM +0200, Sylwester Nawrocki wrote: Hi, On 06/25/2013 05:06 PM, Felipe Balbi wrote: +static struct platform_driver

Re: [PATCH v3 1/5] phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs

Acked-by: Felipe Balbi ba...@ti.com -- balbi signature.asc Description: Digital signature

Re: [PATCH v3 2/5] ARM: dts: Add MIPI PHY node to exynos4.dtsi

On Wed, Jun 26, 2013 at 05:02:23PM +0200, Sylwester Nawrocki wrote: Add PHY provider node for the MIPI CSIS and MIPI DSIM PHYs. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Felipe Balbi ba...@ti.com -- balbi

Re: [PATCH V2 1/3] phy: Add driver for Exynos DP PHY

On Fri, Jun 28, 2013 at 04:15:32PM +0900, Jingoo Han wrote: Add a PHY provider driver for the Samsung Exynos SoC DP PHY. Signed-off-by: Jingoo Han jg1@samsung.com Now that you fixed Kishon's concerns, this looks pretty good: Acked-by: Felipe Balbi ba...@ti.com -- balbi signature.asc

Re: [PATCH V2 2/3] ARM: dts: Add DP PHY node to exynos5250.dtsi

; + phy-names = dp; for the label, I would use something more descriptive such as 'display-port'. other than that: Acked-by: Felipe Balbi ba...@ti.com -- balbi signature.asc Description: Digital signature

Re: [PATCH V2 3/3] video: exynos_dp: Use the generic PHY driver

-by: Felipe Balbi ba...@ti.com -- balbi signature.asc Description: Digital signature

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

On Sun, Jul 21, 2013 at 08:46:53AM -0700, Greg KH wrote: On Sun, Jul 21, 2013 at 01:12:07PM +0200, Tomasz Figa wrote: On Sunday 21 of July 2013 16:37:33 Kishon Vijay Abraham I wrote: Hi, On Sunday 21 July 2013 04:01 PM, Tomasz Figa wrote: Hi, On Saturday 20 of July 2013

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

Hi, On Wed, Jul 31, 2013 at 11:14:32AM +0530, Kishon Vijay Abraham I wrote: IMHO we need a lookup method for PHYs, just like for clocks, regulators, PWMs or even i2c busses because there are complex cases when passing just a name using platform data will not work. I would second what

Re: [PATCH RESEND] i2c: move of helpers into the core

nodes in the core instead of doing this manually in each driver. So, fix the drivers and documentation, too. Signed-off-by: Wolfram Sang w...@the-dreams.de for i2c-omap.c: Reviewed-by: Felipe Balbi ba...@ti.com -- balbi signature.asc Description: Digital signature

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

Hi, On Mon, Aug 19, 2013 at 10:58:09AM +0530, Kishon Vijay Abraham I wrote: So maybe let's stop solving an already solved problem and just state that you need to explicitly assign device ID to use this framework? Felipe, Can we have it the way I had in my v10 patch series till we find

Re: [PATCH v11 0/8] PHY framework

Hi, On Mon, Aug 26, 2013 at 01:44:49PM +0530, Kishon Vijay Abraham I wrote: On Wednesday 21 August 2013 11:16 AM, Kishon Vijay Abraham I wrote: Added a generic PHY framework that provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a

Re: [PATCH v2 1/3] usb: gadget: uvc: Switch to monotonic clock for buffer timestamps

On Fri, Mar 28, 2014 at 05:02:46PM +0100, Laurent Pinchart wrote: The wall time clock isn't useful for applications as it can jump around due to time adjustement. Switch to the monotonic clock. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Felipe Balbi ba

Re: [PATCH v2 2/3] usb: gadget: uvc: Set the V4L2 buffer field to V4L2_FIELD_NONE

On Fri, Mar 28, 2014 at 05:02:47PM +0100, Laurent Pinchart wrote: The UVC gadget driver doesn't support interlaced video but left the buffer field uninitialized. Set it to V4L2_FIELD_NONE. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Felipe Balbi ba...@ti.com

Re: [PATCH v2 3/3] usb: gadget: uvc: Set the vb2 queue timestamp flags

Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Reviewed-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Felipe Balbi ba...@ti.com --- drivers/usb/gadget/uvc_queue.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/gadget/uvc_queue.c b/drivers/usb/gadget

Re: [GIT PULL FOR v3.16] UVC gadget driver fixes

Hi, On Fri, May 09, 2014 at 02:27:34PM +0200, Laurent Pinchart wrote: Hi Felipe, Could you please pull the following three patches for v3.16 ? They've been reviewed on the linux-media and linux-usb mailing list. ok, are these patches being merged in any other tree ? I don't usually take

[RFC/PATCH 0/5] Add Video Processing Front End Support

Hi all, the following patches add suport for AM43xx's Video Processing Front End (VPFE). Full documentation is available at [1] chapter 14. This driver has been tested with linux-next from yesterday, plus my (already queued) am437x starter kit patches, plus these patches, plus the sensor driver

[RFC/PATCH 3/5] arm: boot: dts: am4372: add vpfe DTS entries

From: Benoit Parrot bpar...@ti.com Add Video Processing Front End (VPFE) device tree nodes for AM34xx family of devices. Signed-off-by: Benoit Parrot bpar...@ti.com Signed-off-by: Darren Etheridge detheri...@ti.com Signed-off-by: Felipe Balbi ba...@ti.com --- arch/arm/boot/dts/am4372.dtsi | 16

[RFC/PATCH 5/5] ARM: dts: am437x-sk-evm: add vpfe support and ov2659 sensor

From: Darren Etheridge detheri...@ti.com Adding necessary dts nodes to enable vpfe and ov2659 sensor on the correct i2c bus and correct vpfe instance. Signed-off-by: Darren Etheridge detheri...@ti.com Signed-off-by: Felipe Balbi ba...@ti.com --- arch/arm/boot/dts/am437x-sk-evm.dts | 63

[RFC/PATCH 4/5] arm: dts: am43x-epos: Add VPFE DTS entries

From: Benoit Parrot bpar...@ti.com Add Video Processing Front End (VPFE) device tree nodes for AM43x-epos. Signed-off-by: Benoit Parrot bpar...@ti.com Signed-off-by: Darren Etheridge detheri...@ti.com Signed-off-by: Felipe Balbi ba...@ti.com --- arch/arm/boot/dts/am43x-epos-evm.dts | 54

[RFC/PATCH 2/5] arm: omap: hwmod: add hwmod entries for AM437x VPFE

From: Benoit Parrot bpar...@ti.com HWMOD entries support for TI Dual Video Processing Front End (VPFE) (aka Dual cam) of AM43xx platform. Signed-off-by: Benoit Parrot bpar...@ti.com Signed-off-by: Darren Etheridge detheri...@ti.com Signed-off-by: Felipe Balbi ba...@ti.com --- arch/arm/mach

Re: [RFC/PATCH 5/5] ARM: dts: am437x-sk-evm: add vpfe support and ov2659 sensor

Hi, On Tue, Jul 15, 2014 at 12:56:52PM -0500, Felipe Balbi wrote: From: Darren Etheridge detheri...@ti.com Adding necessary dts nodes to enable vpfe and ov2659 sensor on the correct i2c clearly this doesn't add ov2659 sensor support because we can't release the driver for it. I'll fix

Re: [PATCH] usb: gadget: f_uvc fix transition to video_ioctl2

On Thu, Aug 28, 2014 at 04:39:27PM +0200, Andrzej Pietrasiewicz wrote: W dniu 28.08.2014 o 13:28, Laurent Pinchart pisze: snip diff --git a/drivers/usb/gadget/function/f_uvc.c b/drivers/usb/gadget/function/f_uvc.c index 5209105..95dc1c6 100644 --- a/drivers/usb/gadget/function/f_uvc.c

[PATCH] arm: omap2: rx51-peripherals: fix build warning

Carvalho Chehab mche...@osg.samsung.com Signed-off-by: Felipe Balbi ba...@ti.com --- arch/arm/mach-omap2/board-rx51-peripherals.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c index d18a5cf..bda20c5

Re: [PATCHv3 1/4] phy: phy-core: Make GENERIC_PHY an invisible option

Hi, On Wed, Apr 22, 2015 at 04:04:10PM -0700, Arun Ramamurthy wrote: Most of the phy providers use select to enable GENERIC_PHY. Since select is only recommended when the config is not visible, GENERIC_PHY is changed an invisible option. To maintain consistency, all phy providers are changed

Re: [PATCHv3 1/4] phy: phy-core: Make GENERIC_PHY an invisible option

Hi, On Fri, May 29, 2015 at 05:04:38PM +0530, Kishon Vijay Abraham I wrote: Hi Felipe, On Wednesday 27 May 2015 12:09 AM, Felipe Balbi wrote: On Tue, May 26, 2015 at 11:37:17AM -0700, Arun Ramamurthy wrote: Hi On 15-05-26 07:19 AM, Felipe Balbi wrote: HI, On Mon, May 25, 2015 at 02

Re: [PATCHv3 1/4] phy: phy-core: Make GENERIC_PHY an invisible option

On Mon, Jun 01, 2015 at 06:22:41PM +0530, Kishon Vijay Abraham I wrote: Hi, On Friday 29 May 2015 08:34 PM, Felipe Balbi wrote: Hi, On Fri, May 29, 2015 at 05:04:38PM +0530, Kishon Vijay Abraham I wrote: Hi Felipe, On Wednesday 27 May 2015 12:09 AM, Felipe Balbi wrote: On Tue, May 26

Re: [PATCHv3 1/4] phy: phy-core: Make GENERIC_PHY an invisible option

On Tue, May 26, 2015 at 11:37:17AM -0700, Arun Ramamurthy wrote: Hi On 15-05-26 07:19 AM, Felipe Balbi wrote: HI, On Mon, May 25, 2015 at 02:19:58PM -0700, Arun Ramamurthy wrote: On 15-05-14 05:52 PM, Felipe Balbi wrote: Hi, On Wed, Apr 22, 2015 at 04:04:10PM -0700, Arun

Re: [PATCHv3 1/4] phy: phy-core: Make GENERIC_PHY an invisible option

HI, On Mon, May 25, 2015 at 02:19:58PM -0700, Arun Ramamurthy wrote: On 15-05-14 05:52 PM, Felipe Balbi wrote: Hi, On Wed, Apr 22, 2015 at 04:04:10PM -0700, Arun Ramamurthy wrote: Most of the phy providers use select to enable GENERIC_PHY. Since select is only recommended when

Re: [Patch 1/1] media: am437x-vpfe: Requested frame size and fmt overwritten by current sensor setting

On Mon, Jun 29, 2015 at 02:42:20PM -0500, Benoit Parrot wrote: Upon a S_FMT the input/requeated frame size and pixel format is overwritten by the current subdevice settings. Fix this so application can actually set the frame size and format. Signed-off-by: Benoit Parrot bpar...@ti.com

Re: [Patch 1/1] media: am437x-vpfe: Fix a race condition during release

On Mon, Jun 29, 2015 at 02:41:53PM -0500, Benoit Parrot wrote: There was a race condition where during cleanup/release operation on-going streaming would cause a kernel panic because the hardware module was disabled prematurely with IRQ still pending. Signed-off-by: Benoit Parrot

Re: [PATCH 00/26] constify local structures

Hi, Jarkko Sakkinen writes: > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: >> >> >> On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: >> >> > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote: >> > > Constify local structures. >> > > >>

Re: g_webcam Isoch high bandwidth transfer

Hi, Bin Liu <b-...@ti.com> writes: > +Fengwei Yin per his request. > > On Thu, Sep 22, 2016 at 10:48:40PM +0300, Felipe Balbi wrote: >> >> Hi, >> >> Bin Liu <b-...@ti.com> writes: >> >> [...] >> >> >> Here's one tha

Re: g_webcam Isoch high bandwidth transfer

Hi, yfw writes: >> Here's one that actually compiles, sorry about that. > > No worries, I was sleeping ;-) > > I will test it out early next week. Thanks. meanwhile, how about some instructions on how to test this out myself? How are you

Re: g_webcam Isoch high bandwidth transfer

Hi, Bin Liu writes: > Hi, > > I am trying to check Isoch high bandwidth transfer with g_webcam.ko in > high-speed connection. > > First I hacked webcam.c as follows to enable 640x480@30fps mode. > > diff --git a/drivers/usb/gadget/legacy/webcam.c >

Re: g_webcam Isoch high bandwidth transfer

Hi, Bin Liu <b-...@ti.com> writes: > On Wed, Sep 21, 2016 at 11:01:21AM +0300, Felipe Balbi wrote: >> >> Hi, >> >> Bin Liu <b-...@ti.com> writes: >> > Hi, >> > >> > I am trying to check Isoch high bandwidth transfer with g_

Re: g_webcam Isoch high bandwidth transfer

Hi, Felipe Balbi <felipe.ba...@linux.intel.com> writes: > Bin Liu <b-...@ti.com> writes: >> On Wed, Sep 21, 2016 at 11:01:21AM +0300, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Bin Liu <b-...@ti.com> writes: >>> > Hi, >

Re: g_webcam Isoch high bandwidth transfer

Hi, Felipe Balbi <felipe.ba...@linux.intel.com> writes: > Felipe Balbi <felipe.ba...@linux.intel.com> writes: >> Bin Liu <b-...@ti.com> writes: >>> On Wed, Sep 21, 2016 at 11:01:21AM +0300, Felipe Balbi wrote: >>>> >>>> Hi, >>>

Re: g_webcam Isoch high bandwidth transfer

Hi, Bin Liu writes: [...] >> Here's one that actually compiles, sorry about that. > > No worries, I was sleeping ;-) > > I will test it out early next week. Thanks. meanwhile, how about some instructions on how to test this out myself? How are you using g_webcam and what are

Re: [RFC/PATCH 14/45] media: usb: uvc: make use of new usb_endpoint_maxp_mult()

Hi, Laurent Pinchart <laurent.pinch...@ideasonboard.com> writes: > Hi Felipe, > > Thanks for the patch. > > On Wednesday 28 Sep 2016 16:05:23 Felipe Balbi wrote: >> We have introduced a helper to calculate multiplier >> value from wMaxPacketSize. Start usin

[RFC/PATCH 13/45] media: usbtv: core: make use of new usb_endpoint_maxp_mult()

We have introduced a helper to calculate multiplier value from wMaxPacketSize. Start using it. Cc: Mauro Carvalho Chehab <mche...@kernel.org> Cc: <linux-media@vger.kernel.org> Signed-off-by: Felipe Balbi <felipe.ba...@linux.intel.com> --- drivers/media/usb/usbtv/usbtv-core.c |

[RFC/PATCH 30/45] media: usb: uvc: remove unnecessary & operation

Now that usb_endpoint_maxp() only returns the lowest 11 bits from wMaxPacketSize, we can remove the & operation from this driver. Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Cc: Mauro Carvalho Chehab <mche...@kernel.org> Cc: <linux-media@vger.kernel.org> Signe

[RFC/PATCH 14/45] media: usb: uvc: make use of new usb_endpoint_maxp_mult()

We have introduced a helper to calculate multiplier value from wMaxPacketSize. Start using it. Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Cc: Mauro Carvalho Chehab <mche...@kernel.org> Cc: <linux-media@vger.kernel.org> Signed-off-by: Felipe Balbi <felipe.

Re: g_webcam Isoch high bandwidth transfer

Hi, Laurent Pinchart <laurent.pinch...@ideasonboard.com> writes: > Hi Felipe, > > On Friday 23 Sep 2016 11:27:26 Felipe Balbi wrote: >> yfw <nh26...@gmail.com> writes: >> >>>>>> Here's one that actually compiles, sorry about

Re: g_webcam Isoch high bandwidth transfer

Hi, Bin Liu <b-...@ti.com> writes: > On Fri, Sep 23, 2016 at 10:49:57AM +0300, Felipe Balbi wrote: >> >> Hi, >> >> Bin Liu <b-...@ti.com> writes: >> > +Fengwei Yin per his request. >> > >> > On Thu, Sep 22, 2016 at 10:48:40PM +

Re: [PATCH] usb: core: urb make use of usb_endpoint_maxp_mult

Hi, Greg KH writes: > On Sun, Nov 13, 2016 at 01:31:16PM +0300, Mike Krinkin wrote: >> Since usb_endpoint_maxp now returns only lower 11 bits mult >> calculation here isn't correct anymore and that breaks webcam >> for me. Patch make use of usb_endpoint_maxp_mult

[PATCH 14/82] media: usb: uvc: make use of new usb_endpoint_maxp_mult()

We have introduced a helper to calculate multiplier value from wMaxPacketSize. Start using it. Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Cc: Mauro Carvalho Chehab <mche...@kernel.org> Cc: <linux-media@vger.kernel.org> Signed-off-by: Felipe Balbi <felipe.

[PATCH 13/82] media: usbtv: core: make use of new usb_endpoint_maxp_mult()

We have introduced a helper to calculate multiplier value from wMaxPacketSize. Start using it. Cc: Mauro Carvalho Chehab <mche...@kernel.org> Cc: <linux-media@vger.kernel.org> Signed-off-by: Felipe Balbi <felipe.ba...@linux.intel.com> --- drivers/media/usb/usbtv/usbtv-core.c |

[PATCH 30/82] media: usb: uvc: remove unnecessary & operation

d-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Signed-off-by: Felipe Balbi <felipe.ba...@linux.intel.com> --- drivers/media/usb/uvc/uvc_video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/

Re: [-next PATCH 0/4] sysfs and DEVICE_ATTR_

Hi, Joe Perches <j...@perches.com> writes: > drivers/usb/phy/phy-tahvo.c| 2 +- Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> -- balbi

Re: Some questions about the UVC gadget

Hi, Kelly Huang writes: > Dear Mr.Balbi, > > I am a college student from China. Recently, I am doing some research on > the UVC gadget. After reading the source code, I found that the uvc gadget > framework only supports two types of video streaming format, the >

  1   2   >