Re: [PATCH] gspca_sn9c20x: device 0c45:62b3: fix status LED

2011-08-22 Thread Frank Schäfer
Ping ... what happened to this patch ? ;-) Am 01.07.2011 12:19, schrieb Frank Schaefer: gspca_sn9c20x: device 0c45:62b3: fix status LED Tested with webcam SilverCrest WC2130. Signed-off-by: Frank Schaeferfschaefer@googlemail.com Cc: sta...@kernel.org ---

Re: [PATCH] gspca_sn9c20x: device 0c45:62b3: fix status LED

2011-08-30 Thread Frank Schäfer
Am 27.08.2011 13:55, schrieb Hans de Goede: Hi, On 08/22/2011 11:27 PM, Frank Schäfer wrote: Ping ... what happened to this patch ? ;-) I think it has fallen through the cracks. I've added it to my tree for 3.1 / 3.2 (more likely will be 3.2) Regards, Hans Thank you Hans. I will check

Question about USB interface index restriction in gspca

2011-09-13 Thread Frank Schäfer
Hi, I have a question about the following code in gspca.c: in function gspca_dev_probe(...): ... /* the USB video interface must be the first one */ if (dev-config-desc.bNumInterfaces != 1 intf-cur_altsetting-desc.bInterfaceNumber != 0) return -ENODEV; ... Is

Re: Question about USB interface index restriction in gspca

2011-09-15 Thread Frank Schäfer
Am 14.09.2011 08:25, schrieb Jean-Francois Moine: On Tue, 13 Sep 2011 21:14:28 +0200 Frank Schäferfschaefer@googlemail.com wrote: I have a question about the following code in gspca.c: in function gspca_dev_probe(...): ... /* the USB video interface must be the first one */

Re: Question about USB interface index restriction in gspca

2011-09-19 Thread Frank Schäfer
Am 16.09.2011 08:33, schrieb Jean-Francois Moine: On Thu, 15 Sep 2011 23:46:57 +0200 Frank Schäferfschaefer@googlemail.com wrote: For webcam devices, the interface class is meaningful only when set to USB_CLASS_VIDEO (UVC). Otherwise, I saw many different values. Does that mean that

Re: em2874 bulk endpoint support

2012-01-06 Thread Frank Schäfer
Am 06.01.2012 01:52, schrieb Devin Heitmueller: On Thu, Jan 5, 2012 at 6:16 PM, Dmitriy Fitisovdmit...@radier.ca wrote: Hello everyone, I know, Devin Heitmueller was about to add support for em2874 bulk endpoint. Is that still in plans? The project that I was slated to do this work for got

Re: eMPIA EM2710 Webcam (em28xx) and LIRC

2012-03-15 Thread Frank Schäfer
for testing/discussion soon). I have no strong opinion about this, but I somehow feel that the em28xx driver gets bloated more and more... Regards, Frank Schäfer -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo

Re: Move em27xx/em28xx webcams to a gspca subdriver ?

2012-03-16 Thread Frank Schäfer
[Was: eMPIA EM2710 Webcam (em28xx) and LIRC] Continue this part of the discussion in a new thread... Am 15.03.2012 14:05, schrieb Mauro Carvalho Chehab: Em 15-03-2012 09:34, Frank Schäfer escreveu: ... I would like to bring up the question, if it wouldn't make sense to move support

Re: [PATCH] [RFT/RFC] Add gspca subdriver for Speedlink VAD Laplace (EM2765+OV2640)

2012-03-21 Thread Frank Schäfer
Am 17.03.2012 14:11, schrieb Jean-Francois Moine: On Fri, 16 Mar 2012 23:15:45 +0100 Frank Schäfer fschaefer@googlemail.com wrote: Anyway, I would be glad to get some feedback concerning form and content of the code, becausse I'm still a newbie to kernel programming. Hi Frank, I agree

Re: Move em27xx/em28xx webcams to a gspca subdriver ?

2012-03-21 Thread Frank Schäfer
Am 16.03.2012 23:18, schrieb Frank Schäfer: [Was: eMPIA EM2710 Webcam (em28xx) and LIRC] Continue this part of the discussion in a new thread... Am 15.03.2012 14:05, schrieb Mauro Carvalho Chehab: Em 15-03-2012 09:34, Frank Schäfer escreveu: ... I would like to bring up the question

[PATCH 3/9] em28xx: rename em28xx_hint_sensor() to em28xx_detect_sensor()

2013-03-27 Thread Frank Schäfer
Now that the board hints and the sensor initialization/configuration have been separated, em28xx_detect_sensor() is the better name for this function. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-cards.c |7 +++ 1 Datei geändert, 3 Zeilen

[PATCH 4/9] em28xx: move sensor code to a separate source code file em28xx-camera.c

2013-03-27 Thread Frank Schäfer
em28xx-cards.c is very large and the sensor/camera related code is growing, so move this code to a separate source code file em28xx-camera.c. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/Makefile|2 +- drivers/media/usb/em28xx/em28xx-camera.c

[PATCH 5/9] em28xx: detect further Micron sensors

2013-03-27 Thread Frank Schäfer
Add further Micron chip IDs to be able to identify all Micron sensors listed by Empiatech. Also probe the two alternate i2c addresses used by Micron sensors with 8 bit address and 16 bit register width. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx

[PATCH 6/9] em28xx: move the probing of Micron sensors to a separate function

2013-03-27 Thread Frank Schäfer
Other sensors like the ones from OmniVision need a different probing procedure, so it makes sense have separate functions for each manufacturer/sensor type. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-camera.c | 23 +++ 1

[PATCH 7/9] em28xx: add probing procedure for OmniVision sensors

2013-03-27 Thread Frank Schäfer
different client addresses). The most commonly used sensors (including the ones listed by Empiatech) are detected properly, although there is no support for them yet. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-camera.c | 114

[PATCH 8/9] em28xx: add comment about Samsung and Kodak sensor probing addresses

2013-03-27 Thread Frank Schäfer
them properly, so leave a comment. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-camera.c |5 + 1 Datei geändert, 5 Zeilen hinzugefügt(+) diff --git a/drivers/media/usb/em28xx/em28xx-camera.c b/drivers/media/usb/em28xx/em28xx-camera.c

[PATCH 9/9] em28xx: add basic support for OmniVision OV2640 sensors

2013-03-27 Thread Frank Schäfer
changes), bridge xclk adjustment and disabling of 16 bit (12 bit) output formats at high resolutions. Image quality should also needs to be improved. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-camera.c | 49 ++ drivers

Re: [PATCH] em28xx: fix typo in scale_to_size().

2013-03-30 Thread Frank Schäfer
-fmt.pix.height = height; Acked-by: Frank Schäfer fschaefer@googlemail.com Thanks for catching this ! Regards, Frank -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 0/3] em28xx: add support for two buses on em2874 and upper

2013-04-01 Thread Frank Schäfer
Am 18.03.2013 22:22, schrieb Mauro Carvalho Chehab: Em Wed, 06 Mar 2013 18:44:07 +0100 Frank Schäfer fschaefer@googlemail.com escreveu: Am 05.03.2013 16:43, schrieb Devin Heitmueller: 2013/3/5 Mauro Carvalho Chehab mche...@redhat.com: The em2874 chips and upper have 2 buses. On all known

Re: Terratec Grabby hwrev 2

2013-04-01 Thread Frank Schäfer
Am 30.03.2013 10:54, schrieb Timo Teras: On Thu, 28 Mar 2013 12:22:52 -0300 Mauro Carvalho Chehab mche...@redhat.com wrote: On the W7 driver, I don't get any of the above mentioned problems. I looked at the saa7113 register init sequence, and copied that over to linux saa7113 init, but that

Re: [PATCH 0/3] em28xx: add support for two buses on em2874 and upper

2013-04-01 Thread Frank Schäfer
Am 01.04.2013 21:22, schrieb Mauro Carvalho Chehab: Em Mon, 01 Apr 2013 19:14:03 +0200 Frank Schäfer fschaefer@googlemail.com escreveu: Am 18.03.2013 22:22, schrieb Mauro Carvalho Chehab: Em Wed, 06 Mar 2013 18:44:07 +0100 Frank Schäfer fschaefer@googlemail.com escreveu: Am

Re: Terratec Grabby hwrev 2

2013-04-02 Thread Frank Schäfer
Am 02.04.2013 07:43, schrieb Timo Teras: On Mon, 01 Apr 2013 19:26:53 +0200 Frank Schäfer fschaefer@googlemail.com wrote: Am 30.03.2013 10:54, schrieb Timo Teras: On Thu, 28 Mar 2013 12:22:52 -0300 Mauro Carvalho Chehab mche...@redhat.com wrote: On the W7 driver, I don't get any

Re: [PATCH 0/3] em28xx: add support for two buses on em2874 and upper

2013-04-02 Thread Frank Schäfer
Am 02.04.2013 00:12, schrieb Mauro Carvalho Chehab: Em Mon, 01 Apr 2013 22:39:28 +0200 Frank Schäfer fschaefer@googlemail.com escreveu: Am 01.04.2013 21:22, schrieb Mauro Carvalho Chehab: Em Mon, 01 Apr 2013 19:14:03 +0200 Frank Schäfer fschaefer@googlemail.com escreveu: Am

Re: [PATCH 0/3] em28xx: add support for two buses on em2874 and upper

2013-04-02 Thread Frank Schäfer
Am 02.04.2013 02:48, schrieb Devin Heitmueller: On Mon, Apr 1, 2013 at 6:14 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: In time, I meant to say: So, it seems very unlikely that any change here will keep it working for model 16009 while breaking it for other HVR-930

Re: Terratec Grabby hwrev 2

2013-04-05 Thread Frank Schäfer
Am 03.04.2013 10:27, schrieb Timo Teras: On Tue, 02 Apr 2013 18:39:25 +0200 Frank Schäfer fschaefer@googlemail.com wrote: Am 02.04.2013 07:43, schrieb Timo Teras: On Mon, 01 Apr 2013 19:26:53 +0200 Frank Schäfer fschaefer@googlemail.com wrote: Am 30.03.2013 10:54, schrieb Timo

em28xx: kernel oops in em28xx_tuner_callback() when watching digital TV

2013-04-05 Thread Frank Schäfer
Mauro, Hans, with the latest media-tree, I'm getting the following kernel oops when starting to watch digital TV with em28xx devices: [ 124.297707] BUG: unable to handle kernel paging request at 38326f3d [ 124.297770] IP: [f8bf1026] em28xx_tuner_callback+0x6/0x40 [em28xx] [ 124.297825] *pdpt =

Re: em28xx: kernel oops in em28xx_tuner_callback() when watching digital TV

2013-04-07 Thread Frank Schäfer
Am 06.04.2013 08:38, schrieb Hans Verkuil: On Fri April 5 2013 18:11:59 Frank Schäfer wrote: Mauro, Hans, with the latest media-tree, I'm getting the following kernel oops when starting to watch digital TV with em28xx devices: [ 124.297707] BUG: unable to handle kernel paging request

Re: em28xx: kernel oops in em28xx_tuner_callback() when watching digital TV

2013-04-08 Thread Frank Schäfer
Am 08.04.2013 10:38, schrieb Hans Verkuil: On Mon April 8 2013 00:02:15 Frank Schäfer wrote: In em28xx_start_streaming() and also em28xx_stop_streaming() we do struct em28xx *dev = dvb-adapter.priv; which I would say should be the culprit. Are you sure that dvb-adapter.priv needs

[PATCH] em28xx: save isoc endpoint number for DVB only if endpoint has alt settings with xMaxPacketSize != 0

2013-04-08 Thread Frank Schäfer
as indicator that the device provides DVB support. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-cards.c |2 +- 1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-) diff --git a/drivers/media/usb/em28xx/em28xx-cards.c b/drivers/media/usb

[PATCH] em28xx: fix snapshot button support

2013-04-11 Thread Frank Schäfer
The snapshot button support is currently broken, because module em28xx-rc is loaded only if the device has remote control support. Fix it by also loading this module if the device has a snapshot button. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx

[PATCH] em28xx: improve em2710/em2820 distinction

2013-04-11 Thread Frank Schäfer
. Fortunately both variants are using different generic USD IDs which give us a hint about the used chip. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-cards.c | 16 1 Datei geändert, 8 Zeilen hinzugefügt(+), 8 Zeilen entfernt(-) diff --git

[PATCH 0/3] em28xx: clean up end extend the GPIO port handling

2013-04-13 Thread Frank Schäfer
Patch 1 removes the unneeded and broken gpio register caching code. Patch 2 adds the gpio register defintions for the em25xx/em276x/7x/8x and patch 3 finally adds a new helper function for gpio ports with separate registers for read and write access. Frank Schäfer (3): em28xx: give up GPIO

[PATCH 2/3] em28xx: add register defines for em25xx/em276x/7x/8x GPIO registers

2013-04-13 Thread Frank Schäfer
em25xx/em276x/7x/8x provides 3 GPIO register sets, each of them consisting of separate read and a write registers. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-reg.h |8 1 Datei geändert, 8 Zeilen hinzugefügt(+) diff --git a/drivers

[PATCH 1/3] em28xx: give up GPIO register tracking/caching

2013-04-13 Thread Frank Schäfer
where input lines are connected to buttons etc. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-cards.c | 12 drivers/media/usb/em28xx/em28xx-core.c | 27 ++- drivers/media/usb/em28xx/em28xx.h |6

[PATCH 3/3] em28xx: add helper function for handling the GPIO registers of newer devices

2013-04-13 Thread Frank Schäfer
). Make em28xx_write_reg_bits() a wrapper function calling this new function with the same value for both registers. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-core.c | 26 +++--- drivers/media/usb/em28xx/em28xx.h |5

[PATCH] em28xx: add basic support for the SpeedLink Vicious And Devine Laplace webcam

2013-04-13 Thread Frank Schäfer
- support for the 3 buttons (snapshot, mute, illumination) is missing - illumination/flash LED support is missing (capturing LED is functional) Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-cards.c | 34 ++- drivers/media/usb

Re: [PATCH 0/3] em28xx: clean up end extend the GPIO port handling

2013-04-13 Thread Frank Schäfer
Am 13.04.2013 16:25, schrieb Mauro Carvalho Chehab: Em Sat, 13 Apr 2013 16:15:39 +0300 Antti Palosaari cr...@iki.fi escreveu: On 04/13/2013 12:48 PM, Frank Schäfer wrote: Patch 1 removes the unneeded and broken gpio register caching code. Patch 2 adds the gpio register defintions

Re: [PATCH 1/3] em28xx: give up GPIO register tracking/caching

2013-04-13 Thread Frank Schäfer
Am 13.04.2013 16:41, schrieb Mauro Carvalho Chehab: Em Sat, 13 Apr 2013 11:48:39 +0200 Frank Schäfer fschaefer@googlemail.com escreveu: The GPIO register tracking/caching code is partially broken, because newer devices provide more than one GPIO register and some of them are even using

Re: [PATCH 1/3] em28xx: give up GPIO register tracking/caching

2013-04-13 Thread Frank Schäfer
Am 13.04.2013 19:04, schrieb Mauro Carvalho Chehab: Em Sat, 13 Apr 2013 17:33:28 +0200 Frank Schäfer fschaefer@googlemail.com escreveu: Am 13.04.2013 16:41, schrieb Mauro Carvalho Chehab: Em Sat, 13 Apr 2013 11:48:39 +0200 Frank Schäfer fschaefer@googlemail.com escreveu: The GPIO

Re: [PATCH 1/3] em28xx: give up GPIO register tracking/caching

2013-04-13 Thread Frank Schäfer
Am 13.04.2013 19:46, schrieb Frank Schäfer: Am 13.04.2013 19:04, schrieb Mauro Carvalho Chehab: Em Sat, 13 Apr 2013 17:33:28 +0200 Frank Schäfer fschaefer@googlemail.com escreveu: Am 13.04.2013 16:41, schrieb Mauro Carvalho Chehab: Em Sat, 13 Apr 2013 11:48:39 +0200 Frank Schäfer

Re: [PATCH 1/3] em28xx: give up GPIO register tracking/caching

2013-04-13 Thread Frank Schäfer
Am 13.04.2013 20:19, schrieb Frank Schäfer: Am 13.04.2013 19:46, schrieb Frank Schäfer: ... We always write to the GPIO register. That's why these functions are called em28xx_write_* ;) Whether the write operation is sane or not (e.g. because it modifies the bit corresponding to an input

Re: [PATCH 1/3] em28xx: give up GPIO register tracking/caching

2013-04-14 Thread Frank Schäfer
Am 13.04.2013 20:08, schrieb Mauro Carvalho Chehab: Em Sat, 13 Apr 2013 19:46:20 +0200 Frank Schäfer fschaefer@googlemail.com escreveu: Am 13.04.2013 19:04, schrieb Mauro Carvalho Chehab: Em Sat, 13 Apr 2013 17:33:28 +0200 Frank Schäfer fschaefer@googlemail.com escreveu: Am

Re: [PATCH RFC] em28xx: split analog part into a separate module

2013-04-14 Thread Frank Schäfer
Am 14.04.2013 20:32, schrieb Mauro Carvalho Chehab: Now that dvb-only devices start to happen, it makes sense to split the analog part on a separate module. Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com --- This was compiled-tested only, and it is not ready yet for merging. Yes,

Re: [PATCH 1/3] em28xx: give up GPIO register tracking/caching

2013-04-15 Thread Frank Schäfer
Am 15.04.2013 14:51, schrieb Mauro Carvalho Chehab: Em Sun, 14 Apr 2013 22:35:05 +0200 Frank Schäfer fschaefer@googlemail.com escreveu: Am 13.04.2013 20:08, schrieb Mauro Carvalho Chehab: Em Sat, 13 Apr 2013 19:46:20 +0200 Frank Schäfer fschaefer@googlemail.com escreveu: Am

Re: Patch update notification: 1 patch updated

2013-04-15 Thread Frank Schäfer
Am 15.04.2013 17:23, schrieb Patchwork: Hello, The following patch (submitted by you) has been updated in patchwork: * em28xx: add basic support for the SpeedLink Vicious And Devine Laplace webcam - http://patchwork.linuxtv.org/patch/17928/ was: New now: Under Review This

Patchwork and em28xx delegates

2013-04-15 Thread Frank Schäfer
I've just noticed that my 2 pending em28xx patches have got delegate assigned: https://patchwork.linuxtv.org/patch/17834/ = delegated to mkrufky https://patchwork.linuxtv.org/patch/17928/ (Obsoleted) = delegated to hverkuil Ist this a patchwork failure or is the new submaintainers workflow

Re: Patchwork and em28xx delegates

2013-04-15 Thread Frank Schäfer
Am 15.04.2013 18:50, schrieb Mauro Carvalho Chehab: Em Mon, 15 Apr 2013 18:41:44 +0200 Frank Schäfer fschaefer@googlemail.com escreveu: I've just noticed that my 2 pending em28xx patches have got delegate assigned: https://patchwork.linuxtv.org/patch/17834/ = delegated to mkrufky

[PATCH] em28xx: add a missing le16_to_cpu conversion

2013-04-19 Thread Frank Schäfer
commit 61ff5d69 em28xx: improve em2710/em2820 distinction missed the le16_to_cpu conversion of the USB vendor ID. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-cards.c |3 ++- 1 Datei geändert, 2 Zeilen hinzugefügt(+), 1 Zeile entfernt(-) diff

Fwd: Device no longer handled by em28xx kernel drivers

2013-04-23 Thread Frank Schäfer
(forwarding to the linux-media mailing list) (2nd try) Am 18.04.2013 21:04, schrieb Michael .: Hi I hope you don't mind me contacting you directly. Issues like this should always be discussed on the linux-media mailing list, so please CC it in the future. Neither I'm the em28xx maintainer

Re: [PATCH 1/3] em28xx: give up GPIO register tracking/caching

2013-04-23 Thread Frank Schäfer
... Am 13.04.2013 20:08, schrieb Mauro Carvalho Chehab: Writing is sane: GPIO input lines requires writing as well, in order to set it to either pull-up or pull-down mode (not sure if em28xx supports both ways). So, the driver needs to know if it will write there a 0 or 1, and this is

Re: 3.9.2 kernel - IR / em28xx_rc broken?

2013-05-18 Thread Frank Schäfer
Am 18.05.2013 15:57, schrieb Chris Rankin: I have a PCTV 290e DVB2 adapter (em28xx, em28xx_dvb, em28xx_rc, cxd2820r), and I have just discovered that the IR remote control has stopped working with VDR when using a vanilla 3.9.2 kernel. Downgrading the kernel to 3.8.12 fixes things again.

Re: 3.9.2 kernel - IR / em28xx_rc broken?

2013-05-18 Thread Frank Schäfer
Am 18.05.2013 17:17, schrieb Chris Rankin: - Original Message - Am 18.05.2013 15:57, schrieb Chris Rankin: I have a PCTV 290e DVB2 adapter (em28xx, em28xx_dvb, em28xx_rc, cxd2820r), and I have just discovered that the IR remote control has stopped working with VDR when using a

Re: 3.9.2 kernel - IR / em28xx_rc broken?

2013-05-19 Thread Frank Schäfer
Am 18.05.2013 23:02, schrieb Chris Rankin: - Original Message - For the em28xx driver: em28xx-input.c: em28xx_ir_work() is called every 100ms calls em28xx_ir_handle_key() - calls ir-get_key() which is em2874_polling_getkey() in case of your device - reports the

Re: 3.9.2 kernel - IR / em28xx_rc broken?

2013-05-19 Thread Frank Schäfer
Am 19.05.2013 16:11, schrieb Chris Rankin: - Original Message - em28xx_ir_change_protocol() should be called at least twice: First from em28xx_ir_init() with RC_BIT_UNKNOWN (initial configuration) and later from the RC core with RC_BIT_RC5. Can you confirm that ? Yes, it does

Re: 3.9.2 kernel - IR / em28xx_rc broken?

2013-05-19 Thread Frank Schäfer
Am 19.05.2013 21:59, schrieb Chris Rankin: - Original Message - Hmm... that's weird. Are you sure about that ? Is this really a 3.9.2 vanilla kernel ? Quite sure, although it turns out that there's a bit more to it. Here is the dmesg output with my debugging messages in: [

Re: 3.9.2 kernel - IR / em28xx_rc broken?

2013-05-20 Thread Frank Schäfer
Am 20.05.2013 01:04, schrieb Chris Rankin: - Original Message - What happens with kernel 3.8 ? Does ir-keytable trigger an em28xx_ir_change_protocol() call there, too, but with type=8 ? Or is this call missing ? This is the dmesg output from 3.8, with an extra ex28xx_info() call at

Re: 3.9.2 kernel - IR / em28xx_rc broken?

2013-05-20 Thread Frank Schäfer
Am 20.05.2013 02:45, schrieb Chris Rankin: - Original Message - I'm not familar with ir-keytable and the RC core. Mauro ? Can you take over ? ;) This patch seems to do the right thing... I doubt it will apply cleanly because of TAB/space issues, but you should get the idea :-).

Re: 3.9.2 kernel - IR / em28xx_rc broken?

2013-05-20 Thread Frank Schäfer
Am 20.05.2013 14:38, schrieb Frank Schäfer: ... But there was a third change: 3.) the scancode passed to the RC core with rc_keypress() in case of RC_BIT_UNKNOWN changed from a 16 bit value to 32 bit value (e.g.: old: 00 00 ab cd = new: ab cd xx xx). See commit

Re: 3.9.2 kernel - IR / em28xx_rc broken?

2013-05-20 Thread Frank Schäfer
Am 20.05.2013 15:01, schrieb Chris Rankin: - Original Message - And this is me calling ir-keytable: [ 2183.812407] em28xx #0: Changing protocol: rc_type=1 So with 3.8 the same happens as with 3.9. Yes, that does appear to be part of the RC core ABI. Well, if ir-keycode / the RC

Re: 3.9.2 kernel - IR / em28xx_rc broken?

2013-05-20 Thread Frank Schäfer
Am 20.05.2013 16:51, schrieb Chris Rankin: - Original Message - If I had to guess, I would say you should check your rc_maps.cfg / keytable. ;) This is unchanged between 3.8.x and 3.9.x, and so is correct by definition. No, just because it didn't change it isn't automatically

[PATCH 1/2] em28xx: add register defines for em25xx/em276x/7x/8x GPIO registers

2013-05-24 Thread Frank Schäfer
em25xx/em276x/7x/8x provides 3 GPIO register sets, each of them consisting of separate read and a write registers. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-reg.h | 8 1 file changed, 8 insertions(+) diff --git a/drivers/media/usb

[PATCH 2/2] em28xx: complete GPIO register caching

2013-05-24 Thread Frank Schäfer
we need to cache this register, too. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-cards.c | 12 - drivers/media/usb/em28xx/em28xx-core.c | 43 ++--- drivers/media/usb/em28xx/em28xx.h | 15 3

[PATCH 4/4] em28xx: remove GPIO register caching

2013-06-03 Thread Frank Schäfer
of extending the caching, get rid of it, because it has no real benefits and just bloats/complicates the code. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-cards.c | 12 drivers/media/usb/em28xx/em28xx-core.c | 27

[PATCH 1/4] em28xx: extend GPIO register definitions for the em25xx, em276x/7x/8x, em2874/174/84

2013-06-03 Thread Frank Schäfer
The em25xx/em276x/7x/8x provides 4 GPIO register sets, each of them consisting of separate read and a write registers. The same registers are also used by the em2874/174/84. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-cards.c | 88

[PATCH 2/4] em28xx: improve em2820-em2873/83 GPIO port register definitions and descriptions

2013-06-03 Thread Frank Schäfer
- add definition for GPIO register 0x09 (reading/input) - extend the information the chip variants that support GPIO registers 0x08/0x09 - rename EM28XX_R08_GPIO to EM2820_R08_GPIO_CTRL Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-cards.c | 128

[PATCH 3/4] em28xx: move snapshot button bit definition for reg 0x0C from em28xx-input.c to em28xx.h

2013-06-03 Thread Frank Schäfer
Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-input.c |1 - drivers/media/usb/em28xx/em28xx-reg.h |3 ++- 2 Dateien geändert, 2 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-) diff --git a/drivers/media/usb/em28xx/em28xx-input.c b/drivers

Re: [PATCH 0/4] em28xx: GPIO registers: extend definitions and remove the caching

2013-06-03 Thread Frank Schäfer
Am 03.06.2013 20:12, schrieb Frank Schäfer: The first two patches add some missing GPIO register definitions, while the third patch is a minor code movement to clean up things. The fourth patch finally removes the GPIO register caching. Frank Schäfer (4): em28xx: extend GPIO register

[regression 3.4-3.5, bisected] kernel oops when starting capturing from gspca-sn9c20x webcams

2012-07-08 Thread Frank Schäfer
for sensors which don't have an implementation for them. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans de Goede hdego...@redhat.com Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com Should I open a bug report at bugzilla, too ? Regards, Frank

Re: [regression 3.4-3.5, bisected] kernel oops when starting capturing from gspca-sn9c20x webcams

2012-07-08 Thread Frank Schäfer
Am 08.07.2012 19:43, schrieb Hans de Goede: Hi, Thanks for reporting this! On 07/08/2012 06:25 PM, Frank Schäfer wrote: Hi, running kernel 3.5.rc6 with the two gspca-sn9c20x webcams 0c45:62b3 Microdia PC Camera with Microphone (SN9C202 + OV9655) 0c45:6270 Microdia PC Camera (SN9C201

Re: [Regression 3.1-3.2, bisected] UVC-webcam: kernel panic when starting capturing

2012-07-15 Thread Frank Schäfer
Am 15.07.2012 14:07, schrieb Laurent Pinchart: Hi Frank, Thanks for the report. On Thursday 12 July 2012 21:07:56 Frank Schäfer wrote: Hi, when I start capturing from the UVC-webcam 2232:1005 (WebCam SCB-0385N) of my netbook, I get a kernel panic. You can find a screenshot

Re: [Regression 3.1-3.2, bisected] UVC-webcam: kernel panic when starting capturing

2012-07-16 Thread Frank Schäfer
Am 16.07.2012 01:24, schrieb Laurent Pinchart: Hi Frank, On Sunday 15 July 2012 21:39:47 Frank Schäfer wrote: Am 15.07.2012 14:07, schrieb Laurent Pinchart: On Thursday 12 July 2012 21:07:56 Frank Schäfer wrote: Hi, when I start capturing from the UVC-webcam 2232:1005 (WebCam SCB-0385N

How to add new chip ids to v4l2-chip-ident.h ?

2012-08-18 Thread Frank Schäfer
Hi, I would like to know how to add new chip ids to v4l2-chip-ident.h. Ist there a kind of policy for choosing numbers ? Which numbers would be approriate for the em25xx/em26xx/em27xx/em28xx chips ? Unfortunately 2700 is already used by V4L2_IDENT_VP27SMPX... Regards, Frank Schäfer

Re: How to add new chip ids to v4l2-chip-ident.h ?

2012-08-20 Thread Frank Schäfer
Am 18.08.2012 17:06, schrieb Hans Verkuil: On Sat August 18 2012 16:19:26 Frank Schäfer wrote: Hi, I would like to know how to add new chip ids to v4l2-chip-ident.h. Ist there a kind of policy for choosing numbers ? Using numbers that match the chip number is recommended, but if that can't

How to add support for the em2765 webcam Speedlink VAD Laplace to the kernel ?

2012-08-20 Thread Frank Schäfer
for testing. What do you think ? Regards, Frank Schäfer -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: How to add support for the em2765 webcam Speedlink VAD Laplace to the kernel ?

2012-08-21 Thread Frank Schäfer
Am 20.08.2012 21:21, schrieb Mauro Carvalho Chehab: Em 20-08-2012 10:02, Hans de Goede escreveu: Hi, On 08/20/2012 01:41 PM, Frank Schäfer wrote: Hi, after a break of 2 1/2 kernel releases (sorry, I was busy with another project), I would like to bring up again the question how to add

Re: How to add support for the em2765 webcam Speedlink VAD Laplace to the kernel ?

2012-08-21 Thread Frank Schäfer
Am 21.08.2012 14:32, schrieb Mauro Carvalho Chehab: Em 21-08-2012 08:35, Frank Schäfer escreveu: Am 20.08.2012 21:21, schrieb Mauro Carvalho Chehab: Em 20-08-2012 10:02, Hans de Goede escreveu: Hi, On 08/20/2012 01:41 PM, Frank Schäfer wrote: Hi, after a break of 2 1/2 kernel releases

Re: How to add support for the em2765 webcam Speedlink VAD Laplace to the kernel ?

2012-08-22 Thread Frank Schäfer
. And according to the chip id, it's none of the devices we already know. I wouldn't hesitate to open my device to verify it, if the chance to damage the device wouldn't be that high... Em 21-08-2012 13:04, Frank Schäfer escreveu: Am 21.08.2012 14:32, schrieb Mauro Carvalho Chehab: Em 21-08-2012 08:35

Re: em28xx + ov2640 and v4l2-clk

2013-09-02 Thread Frank Schäfer
Sorry for the delayed reply. A few remarks: Am 27.08.2013 14:52, schrieb Laurent Pinchart: ... Even if the bridge doesn't control the clock, it provides a clock to the sensor. As such, it's the responsibility of the bridge driver to provide the clock to the sensor driver. The sensor

Re: [PATCH 0/3] V4L2: fix em28xx ov2640 support

2013-09-02 Thread Frank Schäfer
Am 28.08.2013 15:28, schrieb Guennadi Liakhovetski: This patch series adds a V4L2 clock support to em28xx with an ov2640 sensor. Only compile tested, might need fixing, please, test. Guennadi Liakhovetski (3): V4L2: add v4l2-clock helpers to register and unregister a fixed-rate clock

Re: [PATCH 0/3] V4L2: fix em28xx ov2640 support

2013-09-05 Thread Frank Schäfer
Hi Guennadi, sorry for delayed replies, I'm currently burried under lots of stuff with a higher priority... Am 03.09.2013 08:34, schrieb Guennadi Liakhovetski: Hi Frank Thanks for testing! Let's have a look then: On Mon, 2 Sep 2013, Frank Schäfer wrote: Am 28.08.2013 15:28, schrieb

Re: [PATCH] em28xx: balance subdevice power-off calls

2013-09-09 Thread Frank Schäfer
Hi Guennadi, thank you for looking at this. A few thoughts: Am 05.09.2013 15:11, schrieb Guennadi Liakhovetski: The em28xx USB driver powers off its subdevices, by calling their .s_power() methods to save power, but actually never powers them on. Apparently this works with currently used

Re: [PATCH 0/3] V4L2: fix em28xx ov2640 support

2013-09-09 Thread Frank Schäfer
Am 09.09.2013 19:27, schrieb Frank Schäfer: Am 05.09.2013 17:57, schrieb Guennadi Liakhovetski: On Thu, 5 Sep 2013, Mauro Carvalho Chehab wrote: Rewriting that part of the code would require to test the changes on several hundreds of different devices, and even if you find someone with all

Re: [PATCH 0/3] V4L2: fix em28xx ov2640 support

2013-09-09 Thread Frank Schäfer
Am 05.09.2013 17:57, schrieb Guennadi Liakhovetski: On Thu, 5 Sep 2013, Mauro Carvalho Chehab wrote: Em Thu, 05 Sep 2013 17:22:36 +0200 Frank Schäfer fschaefer@googlemail.com escreveu: Hi Guennadi, sorry for delayed replies, I'm currently burried under lots of stuff with a higher

Re: em28xx + ov2640 and v4l2-clk

2013-10-08 Thread Frank Schäfer
Am 18.08.2013 17:20, schrieb Mauro Carvalho Chehab: Em Sun, 18 Aug 2013 13:40:25 +0200 Frank Schäfer fschaefer@googlemail.com escreveu: Am 17.08.2013 12:51, schrieb Guennadi Liakhovetski: Hi Frank, As I mentioned on the list, I'm currently on a holiday, so, replying briefly. Sorry, I

Re: [PATCH] Add support for KWorld UB435-Q V2

2013-10-08 Thread Frank Schäfer
you please elaborate on this ? What's the official driver and what changes after using it ? Are these changes permanent ? The commit message should be included in the patch and not be sent as a separate message. Can you fix the patch and resend it ? Regards, Frank Schäfer Jean-Francois Thibert (1

Re: em28xx + ov2640 and v4l2-clk

2013-10-10 Thread Frank Schäfer
Am 08.10.2013 18:38, schrieb Guennadi Liakhovetski: Hi Frank, On Tue, 8 Oct 2013, Frank SchÀfer wrote: Am 18.08.2013 17:20, schrieb Mauro Carvalho Chehab: Em Sun, 18 Aug 2013 13:40:25 +0200 Frank SchÀfer fschaefer@googlemail.com escreveu: Am 17.08.2013 12:51, schrieb Guennadi

Re: [PATCH] Add support for KWorld UB435-Q V2

2013-10-10 Thread Frank Schäfer
Am 09.10.2013 15:48, schrieb Jean-Francois Thibert: On Tue, Oct 8, 2013 at 12:24 PM, Frank Schäfer fschaefer@googlemail.com wrote: This adds support for the UB435-Q V2. It seems that you might need to use the device once with the official driver to reprogram the device descriptors. Thanks

Re: [PATCH v2] Add support for KWorld UB435-Q V2

2013-10-10 Thread Frank Schäfer
. Or the other way around: wouldn't TDA18271_GATE_DIGITAL also work for the A340 ? Apart from that: Reviewed-by: Frank Schäfer fschaefer@googlemail.com Regards, Frank +}; + + static struct zl10353_config em28xx_zl10353_xc3028_no_i2c_gate = { .demod_address = (0x1e 1), .no_tuner = 1

Re: em28xx + ov2640 and v4l2-clk

2013-10-10 Thread Frank Schäfer
Am 10.10.2013 15:50, schrieb Guennadi Liakhovetski: Hi Frank, On Thu, 10 Oct 2013, Frank Schäfer wrote: Am 08.10.2013 18:38, schrieb Guennadi Liakhovetski: Hi Frank, On Tue, 8 Oct 2013, Frank SchÀfer wrote: Am 18.08.2013 17:20, schrieb Mauro Carvalho Chehab: Em Sun, 18 Aug 2013 13:40

[PATCH 1/2] v4l2-ctrls: fix typo in header file media/v4l2-ctrls.h

2013-10-10 Thread Frank Schäfer
Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- include/media/v4l2-ctrls.h |2 +- 1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-) diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2-ctrls.h index 47ada23..16f7f26 100644 --- a/include/media/v4l2-ctrls.h

Re: [PATCH 1/2] v4l2-ctrls: fix typo in header file media/v4l2-ctrls.h

2013-10-10 Thread Frank Schäfer
Sorry, there is no PATCH 2/2, this one is the only one. :) Frank Am 10.10.2013 19:21, schrieb Frank Schäfer: Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- include/media/v4l2-ctrls.h |2 +- 1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-) diff --git

[PATCH] em28xx: fix and unify the coding style of the GPIO register write sequences

2013-10-10 Thread Frank Schäfer
Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-cards.c | 102 +++ drivers/media/usb/em28xx/em28xx-dvb.c | 16 ++--- 2 Dateien geändert, 59 Zeilen hinzugefügt(+), 59 Zeilen entfernt(-) diff --git a/drivers/media/usb

[PATCH] em28xx: fix error path in em28xx_start_analog_streaming()

2013-10-10 Thread Frank Schäfer
Increase the streaming_users count only if streaming start succeeds. Signed-off-by: Frank Schäfer fschaefer@googlemail.com Cc: sta...@kernel.org --- drivers/media/usb/em28xx/em28xx-video.c |7 --- 1 Datei geändert, 4 Zeilen hinzugefügt(+), 3 Zeilen entfernt(-) diff --git a/drivers

Re: em28xx + ov2640 and v4l2-clk

2013-10-10 Thread Frank Schäfer
Am 10.10.2013 19:50, schrieb Guennadi Liakhovetski: On Thu, 10 Oct 2013, Frank Schäfer wrote: Am 10.10.2013 15:50, schrieb Guennadi Liakhovetski: Hi Frank, On Thu, 10 Oct 2013, Frank Schäfer wrote: Am 08.10.2013 18:38, schrieb Guennadi Liakhovetski: Hi Frank, On Tue, 8 Oct 2013, Frank

Re: em28xx + ov2640 and v4l2-clk

2013-10-10 Thread Frank Schäfer
Am 10.10.2013 20:38, schrieb Frank Schäfer: [...] Hmm... your patch didn't change this, but: Why do we call these functions only in case of V4L2_BUF_TYPE_VIDEO_CAPTURE ? Isn't it needed for VBI capturing, too ? em28xx_wake_i2c() is probably also needed for radio mode... Right, my patch

[RFC PATCH] em28xx: fix device initialization in em28xx_v4l2_open() for radio and VBI mode

2013-10-10 Thread Frank Schäfer
-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-video.c | 17 +++-- 1 Datei geändert, 11 Zeilen hinzugefügt(+), 6 Zeilen entfernt(-) diff --git a/drivers/media/usb/em28xx/em28xx-video.c b/drivers/media/usb/em28xx/em28xx-video.c index fc5d60e

Re: em28xx + ov2640 and v4l2-clk

2013-10-13 Thread Frank Schäfer
[snip] Am 12.10.2013 05:45, schrieb Mauro Carvalho Chehab: Changing the input will likely power on the device. The design of the old suspend callback were to call it when the device is not being used. Any try to use the device makes it to wake up, as it makes no sense to use a device in

Re: em28xx + ov2640 and v4l2-clk

2013-10-16 Thread Frank Schäfer
Am 13.10.2013 16:00, schrieb Frank Schäfer: [snip] Am 12.10.2013 05:45, schrieb Mauro Carvalho Chehab: Changing the input will likely power on the device. The design of the old suspend callback were to call it when the device is not being used. Any try to use the device makes it to wake up

[PATCH] em28xx: make sure that all subdevices are powered on when needed

2013-10-16 Thread Frank Schäfer
on again when needed. This patch fixes this issue by adding a (s_power, 1) call to function em28xx_wake_i2c(). Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-core.c |1 + 1 Datei geändert, 1 Zeile hinzugefügt(+) diff --git a/drivers/media/usb

Re: [PATCH] em28xx: make sure that all subdevices are powered on when needed

2013-10-19 Thread Frank Schäfer
Am 18.10.2013 22:30, schrieb Guennadi Liakhovetski: Hi Frank Thanks for the patch On Wed, 16 Oct 2013, Frank Schäfer wrote: Commit 622b828ab7 (v4l2_subdev: rename tuner s_standby operation to core s_power) replaced the tuner s_standby call in the em28xx driver with a (s_power, 0) call

  1   2   3   4   5   6   7   8   9   >