Re: Bugreport for libv4l: error out on webcam: error parsing JPEG header: Bogus jpeg format

2010-07-19 Thread Hans de Goede
Hi, On 07/15/2010 09:30 PM, Yuri wrote: I use Logitech QuickCam Deluxe on FreeBSD-8.1. It shows the image for a while but after 20sec-5min it errors out with the message from libv4l, see below. Could this be a bug in libv4l or it maybe it should be passed some tolerance to errors option?

Re: Bugreport for libv4l: error out on webcam: error parsing JPEG header: Bogus jpeg format

2010-07-19 Thread Hans de Goede
Hi, On 07/19/2010 06:53 PM, Yuri wrote: On 07/19/2010 05:22, Hans de Goede wrote: This is not really a bug in libv4l, but more of a problem with error tolerance in the application you are using. However many apps don't handle any kind of errors all that well. So the latest libv4l will retry

Announcing v4l-utils-0.8.1

2010-08-28 Thread Hans de Goede
Hi, I'm happy to announce the second stable release of v4l-utils, with as highlight that libv4l1 no longer needs the kernel v4l1 compat code, so that can be removed from the kernel (jay!). New this release: v4l-utils-0.8.1 --- * Utils changes: * Various v4l-keytable improvements

Re: ibmcam (xrilink_cit) and konica webcam driver porting to gspca update

2010-08-28 Thread Hans de Goede
Hi, On 08/28/2010 12:54 AM, Jonathan Isom wrote: On Sun, Jul 4, 2010 at 6:29 AM, Hans de Goedehdego...@redhat.com wrote: Hi all, I've finished porting the usbvideo v4l1 ibmcam and konicawc drivers to gspcav2. The ibmcam driver is replaced by gspca_xirlink_cit, which also adds support for 2

Re: [PATCH] gspca_cpia1: Add lamp control for Intel Play QX3 microscope

2010-09-05 Thread Hans de Goede
Hi, On 09/03/2010 03:09 AM, Andy Walls wrote: # HG changeset patch # User Andy Wallsawa...@radix.net # Date 1283475832 14400 # Node ID 0d251a2976b46e11cc817207de191896718b93a3 # Parent a4c762698bcb138982b81cf59e5bc4b7155866a9 gspca_cpia1: Add lamp cotrol for Intel Play QX3 microscope From:

Re: [PATCH] LED control

2010-09-05 Thread Hans de Goede
Hi, On 09/05/2010 10:04 AM, Peter Korsgaard wrote: Hans == Hans de Goedehdego...@redhat.com writes: Hi, + entryconstantV4L2_CID_LEDS/constant/entry + entryinteger/entry + entrySwitch on or off the LED(s) or illuminator(s) of the device. + The control type and

Re: [PATCH] gspca_cpia1: Add lamp control for Intel Play QX3 microscope

2010-09-05 Thread Hans de Goede
Hi, p.s. (forgot to mention this in my previous mail) On 09/03/2010 03:09 AM, Andy Walls wrote: snip @@ -447,6 +449,20 @@ .set = sd_setcomptarget, .get = sd_getcomptarget, }, + { + { +#define V4L2_CID_LAMPS (V4L2_CID_PRIVATE_BASE+1)

Re: ibmcam (xrilink_cit) and konica webcam driver porting to gspca update

2010-09-05 Thread Hans de Goede
Hi, On 08/31/2010 11:43 PM, David Ellingsworth wrote: Hans, I haven't had any success with this driver as of yet. My camera is shown here: http://www.amazon.com/IBM-Net-Camera-Pro-camera/dp/B0009MH25U The part number listed on the bottom is 22P5086. It's also labeled as being an IBM Net Camera

Re: [PATCH] LED control

2010-09-05 Thread Hans de Goede
Hi, On 09/05/2010 10:56 AM, Jean-Francois Moine wrote: On Sun, 05 Sep 2010 09:56:54 +0200 Hans de Goedehdego...@redhat.com wrote: I think that using one control for both status leds (which is what we are usually talking about) and illuminator(s) is a bad idea. I'm fine with standardizing

Re: [PATCH] LED control

2010-09-05 Thread Hans de Goede
Hi, On 09/05/2010 08:43 PM, Andy Walls wrote: On Sun, 2010-09-05 at 15:54 +0200, Hans de Goede wrote: Hi, On 09/05/2010 10:56 AM, Jean-Francois Moine wrote: On Sun, 05 Sep 2010 09:56:54 +0200 Hans de Goedehdego...@redhat.com wrote: I think that using one control for both status leds

Pull request: http://linuxtv.org/hg/~hgoede/ibmcam3 : new xirlink_cit + konica drivers

2010-09-06 Thread Hans de Goede
Hi Mauro, Please pull from: http://linuxtv.org/hg/~hgoede/ibmcam3 Which is my gspca tree which features 2 new (rewritten old v4l1 drivers) gspca subdrivers for xirlink cit and konica chipset webcams. The complete pull consists of the following commits: 4 minutes Hans de Goede

Re: [PATCH] Illuminators and status LED controls

2010-09-07 Thread Hans de Goede
Hi, Looks good to me. Acked-by: Hans de Goede hdego...@redhat.com Regards, Hans On 09/06/2010 08:11 PM, Jean-Francois Moine wrote: Hi, This new proposal cancels the previous 'LED control' patch. Cheers. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr

Re: [PATCH] Illuminators and status LED controls

2010-09-07 Thread Hans de Goede
Hi, On 09/07/2010 09:30 AM, Hans Verkuil wrote: On Monday, September 06, 2010 20:11:05 Jean-Francois Moine wrote: Hi, This new proposal cancels the previous 'LED control' patch. Cheers. Hi Jean-Francois, You must also add support for these new controls in v4l2-ctrls.c in

Re: [PATCH] Illuminators and status LED controls

2010-09-07 Thread Hans de Goede
Replying to myself. On 09/07/2010 11:42 AM, Hans de Goede wrote: Hi, On 09/07/2010 09:30 AM, Hans Verkuil wrote: On Monday, September 06, 2010 20:11:05 Jean-Francois Moine wrote: Hi, This new proposal cancels the previous 'LED control' patch. Cheers. Hi Jean-Francois, You must also

Re: [PATCH] Illuminators and status LED controls

2010-09-07 Thread Hans de Goede
Hi all, On 09/07/2010 11:47 AM, Hans Verkuil wrote: On Tuesday, September 07, 2010 11:44:18 Hans de Goede wrote: Replying to myself. On 09/07/2010 11:42 AM, Hans de Goede wrote: Hi, On 09/07/2010 09:30 AM, Hans Verkuil wrote: On Monday, September 06, 2010 20:11:05 Jean-Francois Moine wrote

Re: [PATCH] Illuminators and status LED controls

2010-09-07 Thread Hans de Goede
Hi, On 09/07/2010 04:50 PM, Hans Verkuil wrote: On Tuesday, September 07, 2010 13:59:19 Hans de Goede wrote: Hi all, On 09/07/2010 11:47 AM, Hans Verkuil wrote: On Tuesday, September 07, 2010 11:44:18 Hans de Goede wrote: Replying to myself. On 09/07/2010 11:42 AM, Hans de Goede wrote: Hi

Re: [PATCH] Illuminators and status LED controls

2010-09-07 Thread Hans de Goede
Hi, On 09/07/2010 05:30 PM, Hans Verkuil wrote: On Tuesday, September 07, 2010 15:04:55 Hans de Goede wrote: Hi, On 09/07/2010 04:50 PM, Hans Verkuil wrote: snip Both off Top on, Bottom off Top off, Bottom on Both on Which raises the question do we leave this as is, or do we make this 2

Re: [PATCH] Illuminators and status LED controls

2010-09-09 Thread Hans de Goede
Hi, On 09/09/2010 08:55 AM, Hans Verkuil wrote: On Tuesday, September 07, 2010 23:14:10 Hans de Goede wrote: snip How about a compromise, we add a set of standard defines for menu index meanings, with a note that these are present as a way to standardize things between drivers

Re: [PATCH] Illuminators and status LED controls

2010-09-09 Thread Hans de Goede
Hi, On 09/09/2010 08:55 AM, Peter Korsgaard wrote: Hans == Hans Verkuilhverk...@xs4all.nl writes: Hi, - the status LED should be controlled by the LED interface. Hans I originally was in favor of controlling these through v4l as Hans well, but people made some good arguments

Re: [PATCH] Illuminators and status LED controls

2010-09-09 Thread Hans de Goede
Hi, On 09/09/2010 03:29 PM, Hans Verkuil wrote: Hi, On 09/09/2010 08:55 AM, Peter Korsgaard wrote: Hans == Hans Verkuilhverk...@xs4all.nl writes: Hi, - the status LED should be controlled by the LED interface. Hans I originally was in favor of controlling these through v4l

Re: [PATCH] Illuminators and status LED controls

2010-09-09 Thread Hans de Goede
Hi, On 09/09/2010 04:14 PM, Andy Walls wrote: I'm of the mind that independent boolean illuminator controls are Ok. I think that scales better. Not that I could imagine many in use for 1 camera anyway, but some may be colors other than white. Illuminator0 should always correspond to the

Re: [PATCH] Illuminators and status LED controls

2010-09-09 Thread Hans de Goede
Hi, On 09/09/2010 04:41 PM, Andy Walls wrote: Hans de Goede, The uvc API that creates v4l2 ctrls on behalf of userspace could intercept those calls and create an LED interface instead of, or in addition to, the v4l2 ctrl. That would mean special casing certain extension controls which I

Re: [PATCH 1/3] gspca_cpia1: Add basic v4l2 illuminator controls for the Intel Play QX3

2010-09-12 Thread Hans de Goede
Ack. Acked-by: Hans de Goede hdego...@redhat.com On 09/12/2010 03:51 AM, Andy Walls wrote: gspca_cpia1: Add basic v4l2 illuminator controls for the Intel Play QX3 This patch add basic V4L2 controls for the illuminators on the Intel Play QX3 microscope. Signed-off-by: Andy Wallsawa

Re: [PATCH 2/3] gspca_cpia1: Disable illuminator controls if not an Intel Play QX3

2010-09-12 Thread Hans de Goede
Hi, On 09/12/2010 03:51 AM, Andy Walls wrote: gspca_cpia1: Disable illuminator controls if not an Intel Play QX3 The illuminator controls should only be available to the user for the Intel Play QX3 microscope. Signed-off-by: Andy Wallsawa...@md.metrocast.net diff -r d165649ca8a0 -r

Re: [PATCH 3/3] gspca_cpia1: Restore QX3 illuminators' state on resume

2010-09-12 Thread Hans de Goede
Hi, On 09/12/2010 03:51 AM, Andy Walls wrote: gspca_cpia1: Restore QX3 illuminators' state on resume Turn the lights of the QX3 on (or off) as needed when resuming and at module load. Signed-off-by: Andy Wallsawa...@md.metrocast.net diff -r 32d5c323c541 -r c2e7fb2d768e

Re: [PATCH v2 2/3] gspca_cpia1: Restore QX3 illuminators' state on resume

2010-09-13 Thread Hans de Goede
Ack! Acked-by: Hans de Goede hdego...@redhat.com On 09/12/2010 07:45 PM, Andy Walls wrote: Turn the lights of the QX3 on (or off) as needed when resuming and at module load. Signed-off-by: Andy Wallsawa...@md.metrocast.net diff -r f09faf8dd85d -r 5e576066eeaf linux/drivers/media/video/gspca

Re: [PATCH v2 3/3] gspca_cpia1: Disable illuminator controls if not an Intel Play QX3

2010-09-13 Thread Hans de Goede
Ack, Acked-by: Hans de Goede hdego...@redhat.com p.s. Jean-Francois, since your tree also has the needed videodev2.h changes I assume you'll take these patches in your tree and thus I won't add them to mine. Regards, Hans On 09/12/2010 07:45 PM, Andy Walls wrote: The illuminator controls

Re: RFC: Move ivtv utilities and ivtv X video extension to v4l-utils

2010-09-16 Thread Hans de Goede
Hi, On 09/17/2010 12:58 AM, Andy Walls wrote: Hi Hans and Hans, I'd like to move the source code maintained here: http://ivtvdriver.org/svn/ to someplace where it may be less likely to suffer bit rot. I was hoping the v4l-utils git repo would be an appropriate place. Do either of you have

Re: libv4l conversion problem

2010-10-18 Thread Hans de Goede
Hi, On 10/14/2010 01:16 PM, Gary Thomas wrote: Hans, Please forgive the direct email; try as I might, I could not find any other vehicle to discuss this (feel free to steer me to the proper place). There indeed is a lack of a mailinglist or forum for v4l-utils. This has been discussed

Re: [PATCH] v4l-utils: libv4l1: When asked for RGB, return RGB and not BGR

2010-10-18 Thread Hans de Goede
Hi, NACK The byte ordering in v4l1's VIDEO_PALETTE_RGB24 was never really clear, but the kernel v4l1 compatibility ioctl handling has been mapping VIDEO_PALETTE_RGB24 - V4L2_PIX_FMT_BGR24 for ever and many v4l1 apps actually expect VIDEO_PALETTE_RGB24 to be BGR24. The only one I know of to get

[GIT PATCHES FOR 2.6.37] Various gspca patches

2010-10-27 Thread Hans de Goede
Hi Mauro, Please pull from: http://linuxtv.org/hg/~hgoede/ibmcam3 Starting at the commit titled: gspca: submit interrupt urbs *after* isoc urbs This pull consists of the following commits: gspca: submit interrupt urbs *after* isoc urbs gspca: only set gspca-int_urb if submitting it succeeds

[PATCH 2/7] gspca: only set gspca-int_urb if submitting it succeeds

2010-10-27 Thread Hans de Goede
-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/gspca/gspca.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/gspca/gspca.c b/drivers/media/video/gspca/gspca.c index dbd63c5..a089fca 100644 --- a/drivers/media/video/gspca/gspca.c +++ b

[PATCH 3/7] gspca-stv06xx: support bandwidth changing

2010-10-27 Thread Hans de Goede
sensor, as this is the only one for which we know how to change the framerate. This patch is based on an initial incomplete patch by Lee Jones lee.jo...@canonical.com Signed-off-by: Lee Jones lee.jo...@canonical.com Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/gspca/stv06xx

[PATCH 5/7] gspca_xirlink_cit: Frames have a 4 byte footer

2010-10-27 Thread Hans de Goede
Atleast on the ibm netcam pro frames have a 4 byte footer, take this into account when calculating sizeimage. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/gspca/xirlink_cit.c | 24 1 files changed, 12 insertions(+), 12 deletions(-) diff

[PATCH 4/7] gspca_xirlink_cit: various usb bandwidth allocation improvements / fixes

2010-10-27 Thread Hans de Goede
not need full bandwidth - Make minimum acceptable bandwidth depend upon resolution Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/gspca/xirlink_cit.c | 41 +++--- 1 files changed, 31 insertions(+), 10 deletions(-) diff --git a/drivers/media/video

[PATCH 7/7] gspca_ov519: generate release button event on stream stop if needed

2010-10-27 Thread Hans de Goede
Generate a release button event when the button is still pressed when the stream stops. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/gspca/ov519.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/gspca/ov519.c b

Re: [PATCH 3/7] gspca-stv06xx: support bandwidth changing

2010-10-27 Thread Hans de Goede
Hi, On 10/27/2010 02:39 PM, Erik Andrén wrote: 2010/10/27 Hans de Goedehdego...@redhat.com: stv06xx devices have only one altsetting, but the actual used bandwidth can be programmed through a register. We were already setting this register lower then the max packetsize of the altsetting

Re: [PATCH] Too slow libv4l MJPEG decoding with HD cameras

2010-10-27 Thread Hans de Goede
Hi, On 10/27/2010 12:49 PM, Janne Grunau wrote: snip With using ffmpeg MJPEG decoding it takes my computer on average 43.616 ms to decode the frame what is 0.0087 us per pixel. That is a great improvement, but using ffmpeg in libv4l is not an option for multiple reasons: 1) It is GPL

Re: [PATCH] Too slow libv4l MJPEG decoding with HD cameras

2010-10-27 Thread Hans de Goede
Hi, On 10/27/2010 03:59 PM, Mitar wrote: Hi! On Wed, Oct 27, 2010 at 3:23 PM, Hans de Goedehdego...@redhat.com wrote: If and only if libjpeg-turbo turns out to be much slower this is something to consider. But the first thing to do here is see if we can solve this in a way which is

Re: [GIT PULL for 2.6.37-rc1] V4L/DVB updates

2010-10-27 Thread Hans de Goede
Hi, On 10/27/2010 04:32 PM, Mauro Carvalho Chehab wrote: Linus, Please pull from ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git v4l_for_linus snip snip I see that you did not include the changes from my pull request send today, understandably so, but I

Re: RFCl libv4l2 plugin API

2010-10-28 Thread Hans de Goede
Hi Sakari, On 10/28/2010 08:30 AM, Hans de Goede wrote: Hans de Goede wrote: Hi All, Hi Hans, Thanks for the RFC! I'd have a few comments and questions. The coding style for libv4l hasn't been defined as far as I understand. Should kernel coding style be assumed, or something else? v4l

Re: Webcam driver not working: drivers/media/video/gspca/ov519.c device 05a9:4519

2010-10-31 Thread Hans de Goede
Hi, On 10/30/2010 12:40 PM, Anca Emanuel wrote: On Fri, Oct 29, 2010 at 3:12 PM, Anca Emanuelanca.eman...@gmail.com wrote: Hi all, sorry for the noise, but in current mainline (2.6.36-git12) there are some updates in ov519.c I'm running this kernel now and my camera is still not working

[GIT PATCHES FOR 2.6.38] gspca-stv06xx: support bandwidth changing

2010-11-10 Thread Hans de Goede
) are available in the git repository at: git://linuxtv.org/hgoede/gspca gspca-for_v2.6.38 Hans de Goede (1): gspca-stv06xx: support bandwidth changing drivers/media/video/gspca/stv06xx/stv06xx.c| 55 +++- drivers/media/video/gspca/stv06xx/stv06xx_hdcs.h | 11

Re: Bounty for the first Open Source driver for Kinect

2010-11-11 Thread Hans de Goede
Hi, On 11/10/2010 10:14 PM, Markus Rechberger wrote: On Wed, Nov 10, 2010 at 9:54 PM, Mohamed Ikbel Boulabiar boulab...@gmail.com wrote: The bounty is already taken by that developer. But now, the Kinect thing is supported like a GPL userspace library. Maybe still need more work to be

[GIT PATCHES FOR 2.6.38] Fixes for driver pwc

2010-11-16 Thread Hans de Goede
repository at: git://linuxtv.org/hgoede/gspca.git gspca-for_v2.6.38 Hans de Goede (3): pwc: do not start isoc stream on /dev/video open pwc: Also set alt setting to alt0 when no error occured pwc: failure to submit an urb is a fatal error drivers/media/video/pwc/pwc-ctrl.c

Re: Zooming with V4L2

2010-11-22 Thread Hans de Goede
Hi, On 11/22/2010 11:59 AM, Laurent Pinchart wrote: Hi Shuzhen, On Sunday 21 November 2010 00:50:59 Shuzhen Wang wrote: Hello, Laurent, Thank you for the reply. In our case, most of the time the sensor outputs bigger image size than the output size, so the ISP hardware does downscaling.

Re: Kinect sensor and Linux kernel driver.

2010-12-07 Thread Hans de Goede
Hi, On 12/06/2010 10:18 PM, Antonio Ospite wrote: Hi, a first, very simplified, linux kernel driver for the Kinect sensor device is now available, so you now can use it as a ridiculously expensive webcam with any v4l2 application. Here's the code: http://git.ao2.it/gspca_kinect.git/ Great!

Re: Regression at gspca core affecting SXGA mode on sn9c201 driver

2010-12-08 Thread Hans de Goede
Hi, On 12/07/2010 09:01 PM, Mauro Carvalho Chehab wrote: Hi Jean-Fronçois, git commit 35680baa6822df98a6ed602e2380aa0a04e18b07 (see enclosed) caused not only a regression at PS/3 Eye webcam (git commit f43402fa55bf5e7e190c176343015122f694857c), but also at sn9c201 driver, when used on SXGA

Re: Regression at gspca core affecting SXGA mode on sn9c201 driver

2010-12-08 Thread Hans de Goede
Hi, On 12/08/2010 01:54 PM, Mauro Carvalho Chehab wrote: Em 08-12-2010 08:01, Hans de Goede escreveu: Hi, On 12/07/2010 09:01 PM, Mauro Carvalho Chehab wrote: Hi Jean-Fronçois, git commit 35680baa6822df98a6ed602e2380aa0a04e18b07 (see enclosed) caused not only a regression at PS/3 Eye

Re: [PATCH] libv4l: Add support for 8-bits grey format (V4L2_PIX_FMT_GREY)

2010-12-08 Thread Hans de Goede
Hi, On 12/08/2010 03:14 PM, Mauro Carvalho Chehab wrote: Grey format is like YUV, with U/V channels with 0. Add the corresponding bits to libv4l, for it to handle this format. Signed-off-by: Mauro Carvalho Chehabmche...@redhat.com diff --git a/lib/libv4lconvert/libv4lconvert-priv.h

Re: Regression at gspca core affecting SXGA mode on sn9c201 driver

2010-12-09 Thread Hans de Goede
Hi, On 12/09/2010 01:08 PM, Jean-Francois Moine wrote: On Wed, 08 Dec 2010 14:06:06 -0200 Mauro Carvalho Chehabmche...@redhat.com wrote: Drivers should provide a wmaxpacketsize range which they need / can deal with for a given resolution. This way we can fix your does not need highest alt

Re: Regression at gspca core affecting SXGA mode on sn9c201 driver

2010-12-09 Thread Hans de Goede
Hi, On 12/09/2010 01:08 PM, Jean-Francois Moine wrote: On Wed, 08 Dec 2010 14:06:06 -0200 Mauro Carvalho Chehabmche...@redhat.com wrote: Drivers should provide a wmaxpacketsize range which they need / can deal with for a given resolution. This way we can fix your does not need highest alt

Re: Kinect sensor and Linux kernel driver.

2010-12-09 Thread Hans de Goede
Hi, On 12/09/2010 04:55 PM, Antonio Ospite wrote: On Mon, 6 Dec 2010 22:49:48 +0100 Hans Verkuilhverk...@xs4all.nl wrote: On Monday, December 06, 2010 22:18:47 Antonio Ospite wrote: snip We are talking about LED(s?) on the webcam and the motor controlling the webcam? That is typically

Re: Kinect sensor and Linux kernel driver.

2010-12-09 Thread Hans de Goede
Hi, On 12/09/2010 06:04 PM, Jason wrote: On 12/09/2010 10:33 AM, Antonio Ospite wrote: On Tue, 07 Dec 2010 12:29:31 +0100 Hans de Goedehdego...@redhat.com wrote: On 12/06/2010 10:18 PM, Antonio Ospite wrote: [...] - Check if gspca can handle two video nodes for the same USB device

[GIT PATCHES FOR 2.6.38] gspca_sonixb: Various updates / fixes

2010-12-12 Thread Hans de Goede
repository at: git://linuxtv.org/hgoede/gspca.git gspca-for_v2.6.38 Hans de Goede (3): gspca_sonixb: Make sonixb handle 0c45:6007 instead of sn9c102 gspca_sonixb: Rewrite start of frame detection gspca_sonixb: Add support for 0c45:602a drivers/media/video/gspca/sonixb.c

Re: [PATCH 6/6] gspca - sonixj: Better handling of the bridge registers 0x01 and 0x17

2010-12-13 Thread Hans de Goede
Hi, On 12/13/2010 02:27 PM, Mauro Carvalho Chehab wrote: Em 13-12-2010 11:04, Jean-Francois Moine escreveu: I'm not sure about this... On my tests with the two devices I have with ov7660 (sn9c105 and sn9c120), the original driver uses 48 MHz for all resolutions. My 2 cents: In my

Re: Question about libv4lconvert.

2010-12-15 Thread Hans de Goede
Hi, On 12/15/2010 05:11 PM, Antonio Ospite wrote: Hi, I am taking a look at libv4lconvert, and I have a question about the logic in v4lconvert_convert_pixfmt(), in some conversion switches there is code like this: case V4L2_PIX_FMT_GREY: switch (dest_pix_fmt) {

Re: Question about libv4lconvert.

2010-12-15 Thread Hans de Goede
Hi, On 12/16/2010 12:49 AM, Antonio Ospite wrote: On Wed, 15 Dec 2010 21:10:52 +0100 Hans de Goedehdego...@redhat.com wrote: Hi, Hi Hans, thanks for the quick reply. On 12/15/2010 05:11 PM, Antonio Ospite wrote: Hi, I am taking a look at libv4lconvert, and I have a question about the

Re: nasty bug at qv4l2

2010-12-24 Thread Hans de Goede
Hi, On 12/22/2010 12:30 PM, Mauro Carvalho Chehab wrote: Hans V/Hans G, There's a nasty bug at qv4l2 or at libv4l: it is not properly updating all info, if you change the video device. On my tests with uvcvideo (video0) and a gspca camera (pac7302, video1), it was showing the supported formats

Re: nasty bug at qv4l2

2010-12-24 Thread Hans de Goede
Hi, On 12/24/2010 03:20 PM, Hans Verkuil wrote: On Friday, December 24, 2010 15:19:26 Hans de Goede wrote: Hi, On 12/22/2010 12:30 PM, Mauro Carvalho Chehab wrote: Hans V/Hans G, There's a nasty bug at qv4l2 or at libv4l: it is not properly updating all info, if you change the video device

Re: Removal of V4L1 drivers

2010-12-24 Thread Hans de Goede
Hi, On 12/24/2010 02:42 PM, Hans Verkuil wrote: Hi Hans, Mauro, The se401, vicam, ibmcam and konicawc drivers are the only V4L1 drivers left in 2.6.37. The others are either converted or moved to staging (stradis and cpia), ready to be removed. Hans, what is the status of those four drivers?

Re: Removal of V4L1 drivers

2010-12-24 Thread Hans de Goede
Hi, On 12/24/2010 07:58 PM, Hans Verkuil wrote: On Friday, December 24, 2010 15:47:57 Hans de Goede wrote: Hi, On 12/24/2010 02:42 PM, Hans Verkuil wrote: Hi Hans, Mauro, The se401, vicam, ibmcam and konicawc drivers are the only V4L1 drivers left in 2.6.37. The others are either converted

Re: [PATCH] Adds the Lego Bionicle to existing sq905c

2010-12-24 Thread Hans de Goede
Mauro, Will you pick up this patch directly or should I put it in my tree ? Regards, Hans On 12/24/2010 09:06 PM, Theodore Kilgore wrote: This patch adds the Vendor:Product number of the Lego Bionicle camera to the existing gspca/sq905c.c and also a line for the camera in gspca.txt. The

Re: [PATCH] Adds the Lego Bionicle to existing sq905c

2010-12-25 Thread Hans de Goede
Hi, On 12/25/2010 10:20 AM, Mauro Carvalho Chehab wrote: Em 24-12-2010 17:55, Hans de Goede escreveu: Mauro, Will you pick up this patch directly or should I put it in my tree ? Either way works for me (but I prefer if one of the gspca maintainers/sub-mainainers pick). If you don't pick

Re: [RFC PATCH] Modify volatile auto cluster handling as per earlier discussions

2011-08-25 Thread Hans de Goede
Hi, First of all thanks for doing this! Overall it looks good, see below for several (small) remarks which I have. On 08/09/2011 06:40 PM, Hans Verkuil wrote: This patch modifies the way autoclusters work when the 'foo' controls are volatile if autofoo is on. E.g.: if autogain is true, then

Re: [RFCv2 PATCH 0/8] Add V4L2_CTRL_FLAG_VOLATILE and change volatile autocluster handling.

2011-08-27 Thread Hans de Goede
Looks good ACK series. Acked-by: Hans de Goede hdego...@redhat.com On 08/26/2011 02:00 PM, Hans Verkuil wrote: This is the second patch for this. The first is here: http://comments.gmane.org/gmane.linux.drivers.video-input-infrastructure/36650 This second version changes the pwc code

Re: [PATCH] gspca_sn9c20x: device 0c45:62b3: fix status LED

2011-08-27 Thread Hans de Goede
Hi, On 08/22/2011 11:27 PM, Frank Schäfer wrote: Ping ... what happened to this patch ? ;-) I think it has fallen through the cracks. I've added it to my tree for 3.1 / 3.2 (more likely will be 3.2) Regards, Hans Am 01.07.2011 12:19, schrieb Frank Schaefer: gspca_sn9c20x: device

Re: [PATCH 01/10] alsa_stream: port changes made on xawtv3

2011-09-06 Thread Hans de Goede
Hi, On 09/06/2011 06:24 PM, Devin Heitmueller wrote: snip I've been thinking for a while that perhaps the project should be renamed (or I considered prepending kl onto the front resulting in it being called kl-tvtime). This isn't out of vanity but rather my concern that the fork will get

Re: [PATCH 01/10] alsa_stream: port changes made on xawtv3

2011-09-06 Thread Hans de Goede
Hi, On 09/06/2011 08:35 PM, Michael Krufky wrote: On Tue, Sep 6, 2011 at 2:19 PM, Hans de Goedehdego...@redhat.com wrote: Hi, On 09/06/2011 06:24 PM, Devin Heitmueller wrote: snip I've been thinking for a while that perhaps the project should be renamed (or I considered prepending kl onto

Re: [PATCH 01/10] alsa_stream: port changes made on xawtv3

2011-09-07 Thread Hans de Goede
Hi, Lots of good stuff in this thread! It seems Mauro has answered most things, so I'm just going to respond to this bit. On 09/07/2011 05:37 AM, Devin Heitmueller wrote: Snip We've added a parameter for that on xawtv3 (--alsa-latency). We've parametrized it at the alsa stream function call.

Re: libv4l2 misbehavior after calling S_STD or S_DV_PRESET

2011-10-07 Thread Hans de Goede
. Regards, Hans From a5abaaa08602b540c88ae4776f557a3b0c34b24d Mon Sep 17 00:00:00 2001 From: Hans de Goede hdego...@redhat.com Date: Fri, 7 Oct 2011 09:18:39 +0200 Subject: [PATCH 1/2] libv4l2: Move s_fmt handling code into a helper function Signed-off-by: Hans de Goede hdego...@redhat.com --- lib

Re: [RFC] Merge v4l-utils. dvb-apps and mediactl to media-utils.git

2011-10-07 Thread Hans de Goede
Hi, On 10/06/2011 02:23 PM, Hans Verkuil wrote: Currently we have three repositories containing libraries and utilities that are relevant to the media drivers: dvb-apps (http://linuxtv.org/hg/dvb-apps/) v4l-utils (http://git.linuxtv.org/v4l-utils.git) media-ctl

Re: libv4l2 misbehavior after calling S_STD or S_DV_PRESET

2011-10-07 Thread Hans de Goede
Hi, On 10/07/2011 11:06 AM, Hans Verkuil wrote: On Friday 07 October 2011 09:57:42 Hans de Goede wrote: Hi, Hmm, nasty... On 10/06/2011 01:13 PM, Hans Verkuil wrote: Hi Hans! I've been looking into a problem with libv4l2 that occurs when you change TV standard or video preset using

Re: [RFC] Merge v4l-utils. dvb-apps and mediactl to media-utils.git

2011-10-07 Thread Hans de Goede
Hi, On 10/07/2011 03:02 PM, Mauro Carvalho Chehab wrote: Em 07-10-2011 03:05, Hans Verkuil escreveu: On Friday, October 07, 2011 04:07:38 Mauro Carvalho Chehab wrote: Em 06-10-2011 14:24, Mauro Carvalho Chehab escreveu: Em 06-10-2011 10:27, Mauro Carvalho Chehab escreveu: Em 06-10-2011

Re: [RFC] Merge v4l-utils. dvb-apps and mediactl to media-utils.git

2011-10-08 Thread Hans de Goede
Hi, On 10/07/2011 03:46 PM, Mauro Carvalho Chehab wrote: Em 07-10-2011 10:05, Hans de Goede escreveu: Hi, On 10/07/2011 03:02 PM, Mauro Carvalho Chehab wrote: Em 07-10-2011 03:05, Hans Verkuil escreveu: On Friday, October 07, 2011 04:07:38 Mauro Carvalho Chehab wrote: Em 06-10-2011 14:24

Add v4l2_subscribed_event_ops

2011-10-24 Thread Hans de Goede
Hi Hans et all, As discussed at the kernel summit. Note I have only compile tested this as I've no control event capable hardware with me (until I'm done with adding support for ctrl events to the UVC driver). Regards, Hans -- To unsubscribe from this list: send the line unsubscribe

[PATCH 1/3] v4l2-event: Deny subscribing with a type of V4L2_EVENT_ALL

2011-10-24 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/v4l2-event.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/v4l2-event.c b/drivers/media/video/v4l2-event.c index 53b190c..9f56f18 100644 --- a/drivers/media/video/v4l2-event.c

[PATCH 3/3] v4l2-ctrls: Use v4l2_subscribed_event_ops

2011-10-24 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/ivtv/ivtv-ioctl.c |3 +- drivers/media/video/pwc/pwc-v4l.c |2 +- drivers/media/video/v4l2-ctrls.c | 56 +++-- drivers/media/video/v4l2-event.c | 39

[PATCH 2/3] v4l2-event: Add v4l2_subscribed_event_ops

2011-10-24 Thread Hans de Goede
Just like with ctrl events, drivers may want to get called back on listener add / remove for other event types too. Rather then special casing all of this in subscribe / unsubscribe event it is better to use ops for this. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video

Various ctrl and event frame work patches

2011-10-27 Thread Hans de Goede
Hi All, This patch set obsoletes my previous add v4l2_subscribed_event_ops set, while working on adding support for ctrl-events to the uvc driver I found a few bugs in the event code, which this patchset fixes. Regards, Hans -- To unsubscribe from this list: send the line unsubscribe

[PATCH 1/6] v4l2-ctrl: Send change events to all fh for auto cluster slave controls

2011-10-27 Thread Hans de Goede
Otherwise the fh changing the master control won't get the inactive state change event for the slave controls. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/v4l2-ctrls.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/v4l2

[PATCH 5/6] v4l2-event: Add v4l2_subscribed_event_ops

2011-10-27 Thread Hans de Goede
Just like with ctrl events, drivers may want to get called back on listener add / remove for other event types too. Rather then special casing all of this in subscribe / unsubscribe event it is better to use ops for this. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video

[PATCH 6/6] v4l2-ctrls: Use v4l2_subscribed_event_ops

2011-10-27 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/ivtv/ivtv-ioctl.c |3 +- drivers/media/video/pwc/pwc-v4l.c |2 +- drivers/media/video/v4l2-ctrls.c | 56 +++-- drivers/media/video/v4l2-event.c | 39

uvcvideo: Add support for control events

2011-10-27 Thread Hans de Goede
Hi All, This patch set adds support for control events to the uvcvideo driver. Note this patch set depends on the Various ctrl and event frame work patches set which I just send out. Regards, Hans -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message

[PATCH 1/2] uvcvideo: Refactor uvc_ctrl_get and query

2011-10-27 Thread Hans de Goede
This is a preparation patch for adding ctrl event support. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/uvc/uvc_ctrl.c | 62 +--- 1 files changed, 43 insertions(+), 19 deletions(-) diff --git a/drivers/media/video/uvc/uvc_ctrl.c b

[PATCH 2/2] uvcvideo: Add support for control events

2011-10-27 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/uvc/uvc_ctrl.c | 104 drivers/media/video/uvc/uvc_v4l2.c | 51 - drivers/media/video/uvc/uvcvideo.h |9 +++ 3 files changed, 161 insertions(+), 3 deletions(-) diff

Re: [PATCH 4/6] v4l2-event: Don't set sev-fh to NULL on unsubcribe

2011-10-28 Thread Hans de Goede
Hi, Thanks for the reviews! On 10/27/2011 02:20 PM, Laurent Pinchart wrote: Hi Hans, On Thursday 27 October 2011 13:18:01 Hans de Goede wrote: 1: There is no reason for this after v4l2_event_unsubscribe releases the spinlock nothing is holding a reference to the sev anymore except

Re: [PATCH 5/6] v4l2-event: Add v4l2_subscribed_event_ops

2011-10-28 Thread Hans de Goede
Hi, On 10/27/2011 02:30 PM, Laurent Pinchart wrote: Hi Hans, On Thursday 27 October 2011 13:18:02 Hans de Goede wrote: Just like with ctrl events, drivers may want to get called back on listener add / remove for other event types too. Rather then special casing all of this in subscribe

[GIT PATCHES FOR 3.2] pwc driver ctrl events + fixes + pac207 exposure fix

2011-10-31 Thread Hans de Goede
in the git repository at: git://linuxtv.org/hgoede/gspca.git media-for_v3.2 Hans de Goede (7): pwc: Add support for control events pwc: properly mark device_hint as unused in all probe error paths pwc: Make auto white balance speed and delay available as v4l2 controls pwc

Re: [PATCH] Increase max exposure value to 255 from 26.

2011-10-31 Thread Hans de Goede
Hi, Thanks for the patch, I've taken a look at this, and the way the pac207's exposure control works is it sets the fps according to the formula of: 90 / exposure reg value. So the old max setting gave you a max exposure time of 90 / 26 = 3.46 fps or 288.9 milliseconds. 3.46 fps already is

Various ctrl and event frame work patches (version 2)

2011-10-31 Thread Hans de Goede
Hi All, This patch set obsoletes my previous add v4l2_subscribed_event_ops set, while working on adding support for ctrl-events to the uvc driver I found a few bugs in the event code, which this patchset fixes. Changes since version 1: -Added a documentation update (update v4l2-framework.txt)

[PATCH 1/6] v4l2-ctrl: Send change events to all fh for auto cluster slave controls

2011-10-31 Thread Hans de Goede
Otherwise the fh changing the master control won't get the inactive state change event for the slave controls. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/v4l2-ctrls.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/v4l2

[PATCH 2/6] v4l2-event: Deny subscribing with a type of V4L2_EVENT_ALL

2011-10-31 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/v4l2-event.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/v4l2-event.c b/drivers/media/video/v4l2-event.c index 53b190c..9f56f18 100644 --- a/drivers/media/video/v4l2-event.c

[PATCH 3/6] v4l2-event: Remove pending events from fh event queue when unsubscribing

2011-10-31 Thread Hans de Goede
on unsubscription. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/v4l2-event.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/v4l2-event.c b/drivers/media/video/v4l2-event.c index 9f56f18..01cbb7f 100644 --- a/drivers

[PATCH 4/6] v4l2-event: Don't set sev-fh to NULL on unsubcribe

2011-10-31 Thread Hans de Goede
of this series, since this op needs a way to get to its own data structures, and typically this will be done by using container_of on an embedded v4l2_fh struct. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/v4l2-event.c |1 - 1 files changed, 0 insertions(+), 1 deletions

[PATCH 5/6] v4l2-event: Add v4l2_subscribed_event_ops

2011-10-31 Thread Hans de Goede
Just like with ctrl events, drivers may want to get called back on listener add / remove for other event types too. Rather then special casing all of this in subscribe / unsubscribe event it is better to use ops for this. Signed-off-by: Hans de Goede hdego...@redhat.com --- Documentation

[PATCH 6/6] v4l2-ctrls: Use v4l2_subscribed_event_ops

2011-10-31 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/ivtv/ivtv-ioctl.c |3 +- drivers/media/video/pwc/pwc-v4l.c |2 +- drivers/media/video/v4l2-ctrls.c | 56 +++-- drivers/media/video/v4l2-event.c | 39

Re: Various ctrl and event frame work patches (version 2)

2011-11-01 Thread Hans de Goede
Hi, On 10/31/2011 05:17 PM, Hans Verkuil wrote: Hi Hans! On Monday, October 31, 2011 16:16:43 Hans de Goede wrote: Hi All, This patch set obsoletes my previous add v4l2_subscribed_event_ops set, while working on adding support for ctrl-events to the uvc driver I found a few bugs in the event

Re: [PATCH 3/6] v4l2-event: Remove pending events from fh event queue when unsubscribing

2011-11-01 Thread Hans de Goede
Hi, hverkuil wrote: This patch fixes these dangling pointers in the available queue by removing all matching pending events on unsubscription. The idea is fine, but the implementation is inefficient. Instead of the list_for_each_entry_safe you can just do: for (i = 0; i

Re: [PATCH 4/6] v4l2-event: Don't set sev-fh to NULL on unsubscribe

2011-11-02 Thread Hans de Goede
resend with correct subject, sorry for the confusing wrong subject with the previous mail Hi, hverkuil wrote: On Thursday, October 27, 2011 13:18:01 Hans de Goede wrote: 1: There is no reason for this after v4l2_event_unsubscribe releases the spinlock nothing is holding a reference

  1   2   3   4   5   6   7   8   9   10   >