Re: [3.0.y+] [media] Avoid sysfs oops when an rc_dev's raw device is absent

2012-08-07 Thread Herton Ronaldo Krzesinski
On Tue, Aug 07, 2012 at 07:58:44PM +1200, Douglas Bagnall wrote: > Ben Hutchings wrote: > > This returns without unlocking dev->lock, which isn't much of an > > improvement. Please get that fixed in mainline, and then I can apply > > both of the changes to 3.2.y at once. Thanks for reviewing it

[PATCH] v4l: make sure drivers supply a zeroed struct v4l2_subdev

2011-04-01 Thread Herton Ronaldo Krzesinski
gLink: http://bugs.launchpad.net/bugs/745213 Cc: Signed-off-by: Herton Ronaldo Krzesinski --- drivers/media/radio/saa7706h.c |2 +- drivers/media/radio/tef6862.c |2 +- drivers/media/video/m52790.c|2 +- drivers/media/video/tda9840.c |2 +- drivers/media/video/tea6415c.c |2

Re: [PATCH] v4l: subdev: initialize sd->internal_ops in v4l2_subdev_init

2011-04-01 Thread Herton Ronaldo Krzesinski
On Fri, Apr 01, 2011 at 05:05:27PM +0200, Hans Verkuil wrote: > On Friday, April 01, 2011 16:24:17 Herton Ronaldo Krzesinski wrote: > > Many v4l drivers currently don't initialize their struct v4l2_subdev > > with zeros, so since the addition of internal_ops in commit 45f6f84

[PATCH] v4l: subdev: initialize sd->internal_ops in v4l2_subdev_init

2011-04-01 Thread Herton Ronaldo Krzesinski
ort at http://bugs.launchpad.net/bugs/745213 So make sure internal_ops is cleared in v4l2_subdev_init. BugLink: http://bugs.launchpad.net/bugs/745213 Cc: # .38.x Signed-off-by: Herton Ronaldo Krzesinski --- drivers/media/video/v4l2-subdev.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) d

Random crashes with v4l2_device_register_subdev

2011-04-01 Thread Herton Ronaldo Krzesinski
Hi, Recently I received a report about crashes with mxb v4l driver (https://bugs.launchpad.net/ubuntu/+source/linux/+bug/745213), there are two slightly different reported crashes which I paste here: 1) BootDmesg.txt crash: [ 21.210232] general protection fault: [#1] SMP [ 21.210292] l

Re: Status of the patches under review (85 patches) and some misc notes about the devel procedures

2010-05-10 Thread Herton Ronaldo Krzesinski
Em Sáb 08 Mai 2010, às 19:41:32, Mauro Carvalho Chehab escreveu: > Herton Ronaldo Krzesinski wrote: > > Em Sex 07 Mai 2010, às 09:39:16, Mauro Carvalho Chehab escreveu: > >>== Patch(broken) - waiting for Herton Ronaldo Krzesinski > >> new submission == >

[PATCH] saa7134: add RM-K6 remote control support for Avermedia M135A

2010-05-10 Thread Herton Ronaldo Krzesinski
This change adds support for one more remote control type for Avermedia M135A (model RM-K6), shipped with Positivo machines. Signed-off-by: Herton Ronaldo Krzesinski --- drivers/media/IR/keymaps/Makefile |2 +- .../media/IR/keymaps/rc-avermedia-m135a-rm-jx.c| 90

Re: Status of the patches under review (85 patches) and some misc notes about the devel procedures

2010-05-07 Thread Herton Ronaldo Krzesinski
Em Sex 07 Mai 2010, às 09:39:16, Mauro Carvalho Chehab escreveu: > == Patch(broken) - waiting for Herton Ronaldo Krzesinski > new submission == > > Apr, 5 2010: saa7134: add support for Avermedia M733A > http://patchwork.kernel.org/

[PATCH v2] saa7134: add support for Avermedia M733A

2010-05-07 Thread Herton Ronaldo Krzesinski
-by: Herton Ronaldo Krzesinski --- Documentation/video4linux/CARDLIST.saa7134 |5 +- drivers/media/IR/keymaps/Makefile |1 + .../media/IR/keymaps/rc-avermedia-m733a-rm-k6.c| 95 drivers/media/video/saa7134/saa7134-cards.c| 57

[PATCH] saa7134: add support for Avermedia M733A

2010-04-05 Thread Herton Ronaldo Krzesinski
This change adds support for Avermedia M733A. The original version for linux 2.6.31 was sent to me from Avermedia, original author is unknown. I ported it to current kernels, and modified for the two pci ids supported (1461:4155, 1461:4255). Signed-off-by: Herton Ronaldo Krzesinski

Re: [PATCH] saa7134: add support for one more remote control for Avermedia M135A

2010-03-19 Thread Herton Ronaldo Krzesinski
Em Sex 19 Mar 2010, às 18:56:57, Mauro Carvalho Chehab escreveu: > Hi Herton, > > Herton Ronaldo Krzesinski wrote: > > This change adds support for one more remote control type for Avermedia > > M135A. The new remote control reports slightly different codes, and was > &

[PATCH] Revert "V4L/DVB (11906): saa7134: Use v4l bounding/alignment function"

2010-03-19 Thread Herton Ronaldo Krzesinski
ferent result. If I comment the round calculation in clamp_align like this: "x = (x /*+ (1 << (align - 1))*/) & mask", I get it fixed too, because this way the calculation is the same then. Signed-off-by: Herton Ronaldo Krzesinski --- drivers/media/video/saa7134/saa7134-video.c | 11 +

[PATCH] saa7134: add support for one more remote control for Avermedia M135A

2010-03-19 Thread Herton Ronaldo Krzesinski
some keys reported duplicated codes, probably because the previous mask_keycode missing valid bits, so this should fix also original remote control support ("The keys bellow aren't ok" comment). Signed-off-by: Herton Ronaldo Krzesinski --- drivers/media/IR/ir-keymaps.c

saa7134: add support for one more remote control for Avermedia M135A

2010-03-19 Thread Herton Ronaldo Krzesinski
some keys reported duplicated codes, probably because the previous mask_keycode missing valid bits, so this should fix also original remote control support ("The keys bellow aren't ok" comment). Signed-off-by: Herton Ronaldo Krzesinski --- drivers/media/IR/ir-keymaps.c

Re: V4L1 compatibility broken for VIDIOCGTUNER with radio

2009-12-03 Thread Herton Ronaldo Krzesinski
Em Qui 03 Dez 2009, às 19:54:29, hermann pitton escreveu: > Hi, > > Am Donnerstag, den 03.12.2009, 16:56 -0200 schrieb Herton Ronaldo > Krzesinski: > > Hi, > > > > After commit 9bedc7f ("V4L/DVB (12429): v4l2-ioctl: fix G_STD and G_PARM > > default hand

V4L1 compatibility broken for VIDIOCGTUNER with radio

2009-12-03 Thread Herton Ronaldo Krzesinski
Hi, After commit 9bedc7f ("V4L/DVB (12429): v4l2-ioctl: fix G_STD and G_PARM default handlers"), radio software using V4L1 stopped to work on a saa7134 card, a git bisect pointed to this commit introducing the regression. All VIDIOCGTUNER calls on a v4l1 application are returning -EINVAL after