[PATCH v2 06/16] s5p-jpeg: Fix clock resource management

2013-11-25 Thread Jacek Anaszewski
moves control of jpeg clock to runtime_pm callbacks. Signed-off-by: Marek Szyprowski Signed-off-by: Seung-Woo Kim Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 35 +++ 1 file changed, 30 insertions(+), 5

[PATCH v2 08/16] s5p-jpeg: Synchronize cached controls with V4L2 core

2013-11-25 Thread Jacek Anaszewski
This patch adds proper initialization of the in-driver cached state of JPEG controls with V4L2 core. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff

[PATCH v2 15/16] s5p-jpeg: Ensure setting correct value of the chroma subsampling control

2013-11-25 Thread Jacek Anaszewski
callback containing mechanism that prevents setting invalid value of the V4L2_CID_JPEG_CHROMA_SUBSAMPLING control. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 35 +++ 1 file changed, 35 insertions(+) diff

[PATCH v2 16/16] s5p-jpeg: Adjust g_volatile_ctrl callback to Exynos4x12 needs

2013-11-25 Thread Jacek Anaszewski
Whereas S5PC210 device produces decoded JPEG subsampling values that map on V4L2_JPEG_CHROMA_SUBSAMPLNG values, the Exynos4x12 device doesn't. This patch adds helper function s5p_jpeg_to_user_subsampling, which performs suitable translation. Signed-off-by: Jacek Anaszewski Signed-o

[PATCH v3 2/8] s5p-jpeg: Add hardware API for the exynos4x12 JPEG codec.

2013-12-18 Thread Jacek Anaszewski
Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/Makefile |2 +- drivers/media/platform/s5p-jpeg/jpeg-core.c | 621 ++--- drivers/media/platform/s5p-jpeg/jpeg-core.h | 64 ++- drivers/media/platform/s5p

[PATCH v3 0/8] Add support for Exynos4x12 device to the s5p-jpeg driver

2013-12-18 Thread Jacek Anaszewski
uot;exynos4" prefixes to the HW API functions Thanks, Jacek Anaszewski Jacek Anaszewski (8): s5p-jpeg: Split jpeg-hw.h to jpeg-hw-s5p.c and jpeg-hw-s5p.c s5p-jpeg: Add hardware API for the exynos4x12 JPEG codec. s5p-jpeg: Retrieve "YCbCr subsampling" field from the jpeg header s5p-

[PATCH v3 1/8] s5p-jpeg: Split jpeg-hw.h to jpeg-hw-s5p.c and jpeg-hw-s5p.c

2013-12-18 Thread Jacek Anaszewski
Move function definitions from jpeg-hw.h to jpeg-hw-s5p.c, add "s5p" prefix and put function declarations in the jpeg-hw-s5p.h. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/Makefile |2 +- drivers/media/platform/s5p

[PATCH v3 3/8] s5p-jpeg: Retrieve "YCbCr subsampling" field from the jpeg header

2013-12-18 Thread Jacek Anaszewski
device as the decoding process will not succeed if the destination format is set to YUV with subsampling lower than the one of the source JPEG image. With this knowledge the driver can adjust the destination format appropriately. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --

[PATCH v3 4/8] s5p-jpeg: Ensure correct capture format for Exynos4x12

2013-12-18 Thread Jacek Anaszewski
Adjust capture format to the Exynos4x12 device limitations, according to the subsampling value parsed from the source JPEG image header. If the capture format was set to YUV with subsampling lower than the one of the source JPEG image the decoding process would not succeed. Signed-off-by: Jacek

[PATCH v3 8/8] s5p-jpeg: Adjust g_volatile_ctrl callback to Exynos4x12 needs

2013-12-18 Thread Jacek Anaszewski
Whereas S5PC210 device produces decoded JPEG subsampling values that map on V4L2_JPEG_CHROMA_SUBSAMPLNG values, the Exynos4x12 device doesn't. This patch adds helper function s5p_jpeg_to_user_subsampling, which performs suitable translation. Signed-off-by: Jacek Anaszewski Signed-o

[PATCH v3 7/8] s5p-jpeg: Ensure setting correct value of the chroma subsampling control

2013-12-18 Thread Jacek Anaszewski
callback containing mechanism that prevents setting invalid value of the V4L2_CID_JPEG_CHROMA_SUBSAMPLING control. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 35 +++ 1 file changed, 35 insertions(+) diff

[PATCH v3 5/8] s5p-jpeg: Allow for wider JPEG subsampling scope for Exynos4x12 encoder

2013-12-18 Thread Jacek Anaszewski
Exynos4x12 supports wider scope of subsampling modes than S5PC210. Adjust corresponding mask accordingly. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a

[PATCH v3 6/8] s5p-jpeg: Synchronize V4L2_CID_JPEG_CHROMA_SUBSAMPLING control value

2013-12-18 Thread Jacek Anaszewski
setting an illegal subsampling mode for Exynos4x12 encoder. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c |8 1 file changed, 8 insertions(+) diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform

[PATCH/RFC 6/8] leds: Add support for max77693 mfd flash cell

2014-03-20 Thread Jacek Anaszewski
triggered externally or by software. Signed-off-by: Andrzej Hajda Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie Cc: SangYoung Son Cc: Samuel Ortiz Cc: Lee Jones --- drivers/leds/Kconfig |9 + drivers/leds/Makefile|1

[PATCH/RFC 8/8] DT: Add documentation for exynos4-is camera-flash property

2014-03-20 Thread Jacek Anaszewski
Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala --- .../devicetree/bindings/media/samsung-fimc.txt |3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/media

[PATCH/RFC 7/8] DT: Add documentation for the mfd Maxim max77693 flash cell

2014-03-20 Thread Jacek Anaszewski
This patch adds device tree binding documentation for the flash cell of the Maxim max77693 multifunctional device. Signed-off-by: Andrzej Hajda Acked-by: Kyungmin Park Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala --- Documentation/devicetree/bindings/mfd/

[PATCH/RFC 1/8] leds: Add sysfs and kernel internal API for flash LEDs

2014-03-20 Thread Jacek Anaszewski
made unavailable then. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie --- drivers/leds/led-class.c| 216 +-- drivers/leds/led-core.c | 124 +++-- drivers/leds/led-triggers.c | 17

[PATCH/RFC 3/8] Documentation: leds: Add description of flash mode

2014-03-20 Thread Jacek Anaszewski
Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie --- Documentation/leds/leds-class.txt | 25 + 1 file changed, 25 insertions(+) diff --git a/Documentation/leds/leds-class.txt b/Documentation/leds/leds-class.txt index 62261c0

[PATCH/RFC 5/8] media: exynos4-is: Add support for v4l2-flash subdevs

2014-03-20 Thread Jacek Anaszewski
This patch adds suppport for external v4l2-flash devices. The support includes parsing camera-flash DT property and asynchronous subdevice registration. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park --- drivers/media/platform/exynos4-is/media-dev.c | 34

[PATCH/RFC 4/8] media: Add registration helpers for V4L2 flash sub-devices

2014-03-20 Thread Jacek Anaszewski
igned-off-by: Jacek Anaszewski Acked-by: Kyungmin Park --- drivers/media/v4l2-core/Makefile |2 +- drivers/media/v4l2-core/v4l2-flash.c | 320 ++ include/media/v4l2-flash.h | 102 +++ 3 files changed, 423 insertions(+), 1 deletion(-) c

[PATCH/RFC 2/8] leds: Improve and export led_update_brightness function

2014-03-20 Thread Jacek Anaszewski
status. This patch adds checking brightness_get callback error code and adds the function to the LED subsystem public API. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie --- drivers/leds/led-class.c |6 -- drivers/leds/led-core.c | 17

[PATCH/RFC 0/8] LED / flash API integration

2014-03-20 Thread Jacek Anaszewski
- Update of the max77693.txt DT bindings documentation - Update of the LED subsystem documentation Thanks, Jacek Anaszewski [1] http://www.spinics.net/lists/linux-media/msg69253.html Jacek Anaszewski (8): leds: Add sysfs and kernel internal API for flash LEDs leds: Improve and export

Re: [PATCH/RFC 6/8] leds: Add support for max77693 mfd flash cell

2014-03-21 Thread Jacek Anaszewski
On 03/20/2014 04:34 PM, Lee Jones wrote: On Thu, 20 Mar 2014, Jacek Anaszewski wrote: This patch adds led-flash support to Maxim max77693 chipset. Device can be exposed to user space through LED subsystem sysfs interface or through V4L2 subdevice when the support for Multimedia Framework is

Re: [PATCH/RFC 1/8] leds: Add sysfs and kernel internal API for flash LEDs

2014-03-21 Thread Jacek Anaszewski
On 03/20/2014 04:28 PM, Richard Purdie wrote: On Thu, 2014-03-20 at 15:51 +0100, Jacek Anaszewski wrote: Some LED devices support two operation modes - torch and flash. This patch provides support for flash LED devices in the LED subsystem by introducing new sysfs attributes and kernel internal

[PATCH/RFC v2 2/8] leds: Improve and export led_update_brightness function

2014-03-28 Thread Jacek Anaszewski
device. This patch adds checking brightness_get callback error code and adds the function to the LED subsystem public API. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie --- drivers/leds/led-class.c |6 -- drivers/leds/led-core.c | 17

Re: [PATCH/RFC 1/8] leds: Add sysfs and kernel internal API for flash LEDs

2014-03-28 Thread Jacek Anaszewski
tion because it is not clear for me how an indicator led is related to a torch led. There is a control for setting indicator intensity but there is not one for enabling it. Could you shed some light on this issue? Regards, Jacek Anaszewski -- To unsubscribe from this list: send the line "u

[PATCH/RFC v2 8/8] DT: Add documentation for exynos4-is camera-flash property

2014-03-28 Thread Jacek Anaszewski
Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala --- .../devicetree/bindings/media/samsung-fimc.txt |3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/media

[PATCH/RFC v2 5/8] DT: Add documentation for the mfd Maxim max77693 flash cell

2014-03-28 Thread Jacek Anaszewski
This patch adds device tree binding documentation for the flash cell of the Maxim max77693 multifunctional device. Signed-off-by: Andrzej Hajda Acked-by: Kyungmin Park Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala --- Documentation/devicetree/bindings/mfd/

Re: [PATCH/RFC 4/8] media: Add registration helpers for V4L2 flash sub-devices

2014-03-28 Thread Jacek Anaszewski
:-) I don't get your point here. Could you be more specific? :) Torch only mode is supported by V4L2_CID_FLASH_LED_MODE control, isn't it? Regards, Jacek Anaszewski -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH/RFC v2 3/8] Documentation: leds: Add description of flash mode

2014-03-28 Thread Jacek Anaszewski
Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie --- Documentation/leds/leds-class.txt | 52 + 1 file changed, 52 insertions(+) diff --git a/Documentation/leds/leds-class.txt b/Documentation/leds/leds-class.txt

[PATCH/RFC v2 7/8] media: exynos4-is: Add support for v4l2-flash subdevs

2014-03-28 Thread Jacek Anaszewski
This patch adds suppport for external v4l2-flash devices. The support includes parsing camera-flash DT property and asynchronous subdevice registration. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park --- drivers/media/platform/exynos4-is/media-dev.c | 34

Re: [PATCH/RFC 8/8] DT: Add documentation for exynos4-is camera-flash property

2014-03-28 Thread Jacek Anaszewski
Hi Sakari, On 03/24/2014 02:05 AM, Sakari Ailus wrote: Hi Jacek, On Thu, Mar 20, 2014 at 03:51:10PM +0100, Jacek Anaszewski wrote: Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala

[PATCH/RFC v2 4/8] leds: Add support for max77693 mfd flash cell

2014-03-28 Thread Jacek Anaszewski
triggered externally or by software. Signed-off-by: Andrzej Hajda Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie Cc: SangYoung Son Cc: Samuel Ortiz Cc: Lee Jones --- drivers/leds/Kconfig | 10 + drivers/leds/Makefile|1

[PATCH/RFC v2 1/8] leds: Add sysfs and kernel internal API for flash LEDs

2014-03-28 Thread Jacek Anaszewski
class device control and communicate with it through the kernel internal interface. The LED sysfs interface is made unavailable then. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie --- drivers/leds/Kconfig|8 + drivers/leds/Makefile |1

[PATCH/RFC v2 0/8] LED / flash API integration

2014-03-28 Thread Jacek Anaszewski
, Jacek Anaszewski [1] http://www.spinics.net/lists/linux-media/msg69253.html Jacek Anaszewski (8): leds: Add sysfs and kernel internal API for flash LEDs leds: Improve and export led_update_brightness function Documentation: leds: Add description of flash mode leds: Add support for max77693 mfd

[PATCH/RFC v2 6/8] media: Add registration helpers for V4L2 flash sub-devices

2014-03-28 Thread Jacek Anaszewski
igned-off-by: Jacek Anaszewski Acked-by: Kyungmin Park --- drivers/media/v4l2-core/Kconfig | 10 ++ drivers/media/v4l2-core/Makefile |2 + drivers/media/v4l2-core/v4l2-flash.c | 302 ++ include/media/v4l2-flash.h | 104 4

Re: brightness units

2014-04-03 Thread Jacek Anaszewski
Hi Bryan, Milo and Sakari, Thanks for the replies. On 04/02/2014 05:17 PM, Sakari Ailus wrote: Hi Bryan, On Tue, Apr 01, 2014 at 03:09:55PM -0700, Bryan Wu wrote: On Tue, Apr 1, 2014 at 12:21 AM, Jacek Anaszewski wrote: I am currently integrating LED subsystem and V4L2 Flash API. V4L2

[PATCH 1/8] [media] s5p-jpeg: Add fmt_ver_flag field to the s5p_jpeg_variant structure

2014-04-07 Thread Jacek Anaszewski
Simplify the code by adding fmt_ver_flag field to the s5p_jpeg_variant structure which allows to avoid "if" statement in the s5p_jpeg_find_format function. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 11 --

[PATCH 2/8] [media] s5p-jpeg: Perform fourcc downgrade only for Exynos4x12 SoCs

2014-04-07 Thread Jacek Anaszewski
Change the driver variant check from "is not S5PC210" to "is Exynos4" while checking whether YUV format needs to be downgraded in order to prevent upsampling which is not supported by Exynos4 SoCs family. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- dr

[PATCH 3/8] [media] s5p-jpeg: Add m2m_ops field to the s5p_jpeg_variant structure

2014-04-07 Thread Jacek Anaszewski
Simplify the code by adding m2m_ops field to the s5p_jpeg_variant structure which allows to avoid "if" statement in the s5p_jpeg_probe function. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 12 dri

[PATCH 6/8] [media] s5p-jpeg: Fix sysmmu page fault

2014-04-07 Thread Jacek Anaszewski
-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 46 +-- 1 file changed, 43 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform/s5p-jpeg/jpeg-core.c index

[PATCH 4/8] [media] s5p-jpeg: Fix build break when CONFIG_OF is undefined

2014-04-07 Thread Jacek Anaszewski
This patch fixes build break occurring when there is no support for Device Tree turned on in the kernel configuration. In such a case only the driver variant for S5PC210 SoC will be available. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg

[PATCH 8/8] [media] s5p_jpeg: Fix NV12 format entry related to S5C2120 SoC

2014-04-07 Thread Jacek Anaszewski
S5PC210 SoC doesn't support encoding NV12 raw images. Remove the relavant flag from the respective entry in the sjpeg_formats array. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c |3 +-- 1 file changed, 1 insertion(

[PATCH 5/8] [media] s5p-jpeg: g_selection callback should always succeed

2014-04-07 Thread Jacek Anaszewski
Remove erroneous guard preventing successful execution of g_selection callback in case the driver variant is different from SJPEG_S5P. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c |3 +-- 1 file changed, 1 insertion(+), 2

[PATCH 7/8] [media] s5p_jpeg: Prevent JPEG 4:2:0 > YUV 4:2:0 decompression

2014-04-07 Thread Jacek Anaszewski
Prevent decompression of a JPEG 4:2:0 with odd width to the YUV 4:2:0 compliant formats for Exynos4x12 SoCs and adjust capture format to RGB565 in such a case. This is required because the configuration would produce a raw image with broken luma component. Signed-off-by: Jacek Anaszewski Signed

Re: [PATCH 7/8] [media] s5p_jpeg: Prevent JPEG 4:2:0 > YUV 4:2:0 decompression

2014-04-09 Thread Jacek Anaszewski
On 04/08/2014 09:49 AM, Sachin Kamat wrote: Hi Jacek, On 7 April 2014 18:46, Jacek Anaszewski wrote: Prevent decompression of a JPEG 4:2:0 with odd width to the YUV 4:2:0 compliant formats for Exynos4x12 SoCs and adjust capture format to RGB565 in such a case. This is required because the

Re: [PATCH 7/8] [media] s5p_jpeg: Prevent JPEG 4:2:0 > YUV 4:2:0 decompression

2014-04-09 Thread Jacek Anaszewski
On 04/09/2014 09:56 AM, Sachin Kamat wrote: Hi Jacek, On 9 April 2014 13:01, Jacek Anaszewski wrote: On 04/08/2014 09:49 AM, Sachin Kamat wrote: Hello Sachin, Thanks for the review. I put it into info message because this is rather hard for the user to figure out why the adjustment

[PATCH v2 6/8] s5p-jpeg: Fix sysmmu page fault

2014-04-10 Thread Jacek Anaszewski
-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 46 +-- 1 file changed, 43 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform/s5p-jpeg/jpeg-core.c index

[PATCH v2 5/8] s5p-jpeg: g_selection callback should always succeed

2014-04-10 Thread Jacek Anaszewski
Remove erroneous guard preventing successful execution of g_selection callback in case the driver variant is different from SJPEG_S5P. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c |3 +-- 1 file changed, 1 insertion(+), 2

[PATCH v2 7/8] s5p_jpeg: Prevent JPEG 4:2:0 > YUV 4:2:0 decompression

2014-04-10 Thread Jacek Anaszewski
Prevent decompression of a JPEG 4:2:0 with odd width to the YUV 4:2:0 compliant formats for Exynos4x12 SoCs and adjust capture format to RGB565 in such a case. This is required because the configuration would produce a raw image with broken luma component. Signed-off-by: Jacek Anaszewski Signed

[PATCH v2 2/8] s5p-jpeg: Perform fourcc downgrade only for Exynos4x12 SoCs

2014-04-10 Thread Jacek Anaszewski
Change the driver variant check from "is not S5PC210" to "is Exynos4" while checking whether YUV format needs to be downgraded in order to prevent upsampling which is not supported by Exynos4 SoCs family. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- dr

[PATCH v2 3/8] s5p-jpeg: Add m2m_ops field to the s5p_jpeg_variant structure

2014-04-10 Thread Jacek Anaszewski
Simplify the code by adding m2m_ops field to the s5p_jpeg_variant structure which allows to avoid "if" statement in the s5p_jpeg_probe function. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 12 dri

[PATCH v2 1/8] s5p-jpeg: Add fmt_ver_flag field to the s5p_jpeg_variant structure

2014-04-10 Thread Jacek Anaszewski
Simplify the code by adding fmt_ver_flag field to the s5p_jpeg_variant structure which allows to avoid "if" statement in the s5p_jpeg_find_format function. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 11 --

[PATCH v2 4/8] s5p-jpeg: Fix build break when CONFIG_OF is undefined

2014-04-10 Thread Jacek Anaszewski
This patch fixes build break occurring when there is no support for Device Tree turned on in the kernel configuration. In such a case only the driver variant for S5PC210 SoC will be available. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg

[PATCH v2 8/8] s5p_jpeg: Fix NV12 format entry related to S5C2120 SoC

2014-04-10 Thread Jacek Anaszewski
S5PC210 SoC doesn't support encoding NV12 raw images. Remove the relavant flag from the respective entry in the sjpeg_formats array. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c |3 +-- 1 file changed, 1 insertion(

[PATCH/RFC v3 5/5] media: Add registration helpers for V4L2 flash sub-devices

2014-04-11 Thread Jacek Anaszewski
used. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park --- drivers/media/v4l2-core/Kconfig | 10 + drivers/media/v4l2-core/Makefile |2 + drivers/media/v4l2-core/v4l2-flash.c | 393 ++ include/media/v4l2-flash.h | 119 ++ 4

[PATCH/RFC v3 4/5] DT: Add documentation for the mfd Maxim max77693 flash cell

2014-04-11 Thread Jacek Anaszewski
This patch adds device tree binding documentation for the flash cell of the Maxim max77693 multifunctional device. Signed-off-by: Andrzej Hajda Acked-by: Kyungmin Park Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala --- Documentation/devicetree/bindings/mfd/

[PATCH/RFC v3 1/5] leds: Add sysfs and kernel internal API for flash LEDs

2014-04-11 Thread Jacek Anaszewski
. The design assumes that V4L2 sub-device can take of the LED class device control and communicate with it through the kernel internal interface. When V4L2 Flash sub-device file is opened, the LED class device sysfs interface is made unavailable. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin

[PATCH/RFC v3 3/5] leds: Add support for max77693 mfd flash cell

2014-04-11 Thread Jacek Anaszewski
be triggered externally or by software. Signed-off-by: Andrzej Hajda Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie Cc: SangYoung Son Cc: Samuel Ortiz Cc: Lee Jones --- drivers/leds/Kconfig | 10 + drivers/leds/Makefile|1

[PATCH/RFC v3 2/5] leds: Improve and export led_update_brightness function

2014-04-11 Thread Jacek Anaszewski
device. This patch adds checking brightness_get callback error code and adds the function to the LED subsystem public API. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie --- drivers/leds/led-class.c |6 -- drivers/leds/led-core.c | 16

[PATCH/RFC v3 0/5] LED / flash API integration

2014-04-11 Thread Jacek Anaszewski
- removed modifications to the LED class devices documentation, it will be covered after the whole functionality is accepted Thanks, Jacek Anaszewski [1] http://www.spinics.net/lists/linux-media/msg69253.html Jacek Anaszewski (5): leds: Add sysfs and kernel internal API for flash LEDs led

Re: [PATCH/RFC v3 5/5] media: Add registration helpers for V4L2 flash sub-devices

2014-04-17 Thread Jacek Anaszewski
s: + v4l2_ctrl_handler_free(sd->ctrl_handler); + return -EINVAL; +} +EXPORT_SYMBOL_GPL(v4l2_flash_init); + +void v4l2_flash_release(struct led_classdev *led_cdev) +{ + struct v4l2_flash *flash = &led_cdev->flash->v4l2_flash; + + v4l2_ctrl_handler_free(flash-&

Re: [PATCH/RFC v3 3/5] leds: Add support for max77693 mfd flash cell

2014-04-17 Thread Jacek Anaszewski
Hi Sakari, Thanks for the review. On 04/16/2014 07:26 PM, Sakari Ailus wrote: Hi Jacek, Thanks for the patch! Comments below. On Fri, Apr 11, 2014 at 04:56:54PM +0200, Jacek Anaszewski wrote: This patch adds led-flash support to Maxim max77693 chipset. A device can be exposed to user space

Re: [PATCH/RFC v3 5/5] media: Add registration helpers for V4L2 flash sub-devices

2014-04-28 Thread Jacek Anaszewski
Hi Sakari, On 04/23/2014 05:24 PM, Sakari Ailus wrote: Hi Jacek, On Thu, Apr 17, 2014 at 10:26:44AM +0200, Jacek Anaszewski wrote: Hi Sakari, Thanks for the review. On 04/16/2014 08:21 PM, Sakari Ailus wrote: Hi Jacek, Thanks for the update! [...] +static inline enum led_brightness

Re: [PATCH/RFC v3 3/5] leds: Add support for max77693 mfd flash cell

2014-04-28 Thread Jacek Anaszewski
Hi Sakari, On 04/23/2014 05:52 PM, Sakari Ailus wrote: Hi Jacek, Thanks for the answers to my comments! :-) On Thu, Apr 17, 2014 at 11:23:06AM +0200, Jacek Anaszewski wrote: On 04/16/2014 07:26 PM, Sakari Ailus wrote: Hi Jacek, Thanks for the patch! Comments below. On Fri, Apr 11, 2014 at

Re: [PATCH/RFC v3 1/5] leds: Add sysfs and kernel internal API for flash LEDs

2014-04-28 Thread Jacek Anaszewski
Hi Bryan, Thanks for the review. On 04/26/2014 01:17 AM, Bryan Wu wrote: On Fri, Apr 11, 2014 at 7:56 AM, Jacek Anaszewski wrote: Some LED devices support two operation modes - torch and flash. Do we have a method to look up the capabilities from LED devices driver? For example, the LED

Re: [PATCH/RFC v3 5/5] media: Add registration helpers for V4L2 flash sub-devices

2014-05-05 Thread Jacek Anaszewski
trl callback, and thus it expects to get the intensity aligned to the step value, so it will always be a multiple of step. Is it possible that s_ctrl callback would be passed a non-aligned control value? Regards, Jacek Anaszewski -- To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH/RFC v3 5/5] media: Add registration helpers for V4L2 flash sub-devices

2014-05-07 Thread Jacek Anaszewski
On 05/06/2014 11:10 AM, Sakari Ailus wrote: Hi Jacek, On Tue, May 06, 2014 at 08:44:41AM +0200, Jacek Anaszewski wrote: Hi Sakari, On 05/02/2014 01:06 PM, Sakari Ailus wrote: [...] +static inline enum led_brightness v4l2_flash_intensity_to_led_brightness

Re: [PATCH/RFC v3 5/5] media: Add registration helpers for V4L2 flash sub-devices

2014-05-09 Thread Jacek Anaszewski
Hi Sakari, On 05/07/2014 09:58 AM, Sakari Ailus wrote: Hi Jacek, On Wed, May 07, 2014 at 09:20:17AM +0200, Jacek Anaszewski wrote: On 05/06/2014 11:10 AM, Sakari Ailus wrote: Hi Jacek, On Tue, May 06, 2014 at 08:44:41AM +0200, Jacek Anaszewski wrote: Hi Sakari, On 05/02/2014 01:06 PM

[PATCH/RFC v9 18/19] leds: max77693: add support for V4L2 Flash sub-device

2014-12-03 Thread Jacek Anaszewski
Add support for V4L2 Flash sub-device to the max77693 LED Flash class driver. The support allows for V4L2 Flash sub-device to take the control of the LED Flash class device. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie Cc: Sakari Ailus --- drivers

[PATCH/RFC v9 19/19] leds: aat1290: add support for V4L2 Flash sub-device

2014-12-03 Thread Jacek Anaszewski
Add support for V4L2 Flash sub-device to the aat1290 LED Flash class driver. The support allows for V4L2 Flash sub-device to take the control of the LED Flash class device. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie Cc: Sakari Ailus --- drivers

[PATCH/RFC v9 17/19] DT: Add documentation for exynos4-is 'flashes' property

2014-12-03 Thread Jacek Anaszewski
This patch adds a description of 'flashes' property to the samsung-fimc.txt. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Sylwester Nawrocki Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Cc: --- .../devicetree/bindings/med

[PATCH/RFC v9 04/19] mfd: max77693: adjust max77693_led_platform_data

2014-12-03 Thread Jacek Anaszewski
Add "label" array for Device Tree strings with the name of a LED device and make flash_timeout a two element array, for caching the sub-led related flash timeout. Added is also an array for caching pointers to the sub-nodes representing sub-leds. Signed-off-by: Jacek Anaszewski

[PATCH/RFC v9 11/19] v4l2-async: change custom.match callback argument type

2014-12-03 Thread Jacek Anaszewski
It is useful to have an access to the async sub-device being matched, not only to the related struct device. Change match callback argument from struct device to struct v4l2_subdev. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Guennadi Liakhovetski Cc: Laurent Pinchart Cc: Hans

[PATCH/RFC v9 09/19] of: Add Skyworks Solutions, Inc. vendor prefix

2014-12-03 Thread Jacek Anaszewski
Use "skyworks" as the vendor prefix for the Skyworks Solutions, Inc. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Cc: --- .../devicetree/bindings/vendor-prefixes.txt|1 + 1 fi

[PATCH/RFC v9 06/19] DT: Add documentation for the mfd Maxim max77693

2014-12-03 Thread Jacek Anaszewski
This patch adds device tree binding documentation for the flash cell of the Maxim max77693 multifunctional device. Signed-off-by: Jacek Anaszewski Signed-off-by: Andrzej Hajda Acked-by: Kyungmin Park Cc: Lee Jones Cc: Chanwoo Choi Cc: Bryan Wu Cc: Richard Purdie Cc: Rob Herring Cc: Pawel

[PATCH/RFC v9 03/19] mfd: max77693: Modify flash cell name identifiers

2014-12-03 Thread Jacek Anaszewski
Change flash cell identifiers from max77693-flash to max77693-led to avoid confusion with NOR/NAND Flash. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Chanwoo Choi Cc: Lee Jones --- drivers/mfd/max77693.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH/RFC v9 14/19] media: Add registration helpers for V4L2 flash sub-devices

2014-12-03 Thread Jacek Anaszewski
ll be used. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Sakari Ailus Cc: Hans Verkuil --- drivers/media/v4l2-core/Kconfig | 11 + drivers/media/v4l2-core/Makefile |2 + drivers/media/v4l2-core/v4l2-flash.c | 546 ++ include/media

[PATCH/RFC v9 15/19] Documentation: leds: Add description of v4l2-flash sub-device

2014-12-03 Thread Jacek Anaszewski
This patch extends LED Flash class documention by the description of interactions with v4l2-flash sub-device. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Acked-by: Sakari Ailus Cc: Bryan Wu Cc: Richard Purdie --- Documentation/leds/leds-class-flash.txt | 13 + 1

[PATCH/RFC v9 07/19] dt-binding: mfd: max77693: Add DT binding related macros

2014-12-03 Thread Jacek Anaszewski
Add macros for max77693 led part related binding. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Lee Jones Cc: Chanwoo Choi --- include/dt-bindings/mfd/max77693.h | 38 1 file changed, 38 insertions(+) create mode 100644 include/dt

[PATCH/RFC v9 16/19] exynos4-is: Add support for v4l2-flash subdevs

2014-12-03 Thread Jacek Anaszewski
This patch adds suppport for external v4l2-flash devices. The support includes parsing camera-flash DT property and asynchronous subdevice registration. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Sylwester Nawrocki --- drivers/media/platform/exynos4-is/media-dev.c | 42

[PATCH/RFC v9 13/19] v4l2-ctrls: Add V4L2_CID_FLASH_SYNC_STROBE control

2014-12-03 Thread Jacek Anaszewski
Add V4L2_CID_FLASH_SYNC_STROBE control for determining whether a flash device strobe has to be synchronized with other flash leds controller by the same device. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Sakari Ailus Cc: Hans Verkuil --- Documentation/DocBook/media/v4l

[PATCH/RFC v9 10/19] DT: Add documentation for the Skyworks AAT1290

2014-12-03 Thread Jacek Anaszewski
This patch adds device tree binding documentation for 1.5A Step-Up Current Regulator for Flash LEDs. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Cc

[PATCH/RFC v9 05/19] leds: Add support for max77693 mfd flash cell

2014-12-03 Thread Jacek Anaszewski
This patch adds led-flash support to Maxim max77693 chipset. A device can be exposed to user space through LED subsystem sysfs interface. Device supports up to two leds which can work in flash and torch mode. The leds can be triggered externally or by software. Signed-off-by: Jacek Anaszewski

[PATCH/RFC v9 08/19] leds: Add driver for AAT1290 current regulator

2014-12-03 Thread Jacek Anaszewski
This patch adds a driver for the 1.5A Step-Up Current Regulator for Flash LEDs. The device is programmed through a Skyworks proprietary AS2Cwire serial digital interface. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie --- drivers/leds/Kconfig

[PATCH/RFC v9 12/19] v4l2-async: add V4L2_ASYNC_MATCH_CUSTOM_OF matching type

2014-12-03 Thread Jacek Anaszewski
V4L2_ASYNC_MATCH_CUSTOM_OF matching type to declare this type of matching. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Guennadi Liakhovetski Cc: Laurent Pinchart Cc: Hans Verkuil --- drivers/media/v4l2-core/v4l2-async.c | 106 ++ include/media

[PATCH/RFC v9 02/19] Documentation: leds: Add description of LED Flash class extension

2014-12-03 Thread Jacek Anaszewski
The documentation being added contains overall description of the LED Flash Class and the related sysfs attributes. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie --- Documentation/leds/leds-class-flash.txt | 50 +++ 1

[PATCH/RFC v9 00/19] LED / flash API integration

2014-12-03 Thread Jacek Anaszewski
facilities from the LED Flash Class and provided external_strobe_set op in v4l2-flash. LED subsystem should be strobe provider agnostic. Thanks, Jacek Anaszewski Jacek Anaszewski (19): leds: Add LED Flash class extension to the LED subsystem Documentation: leds: Add description of LED

[PATCH/RFC v9 01/19] leds: Add LED Flash class extension to the LED subsystem

2014-12-03 Thread Jacek Anaszewski
design assumes that V4L2 sub-device can take of the LED class device control and communicate with it through the kernel internal interface. When V4L2 Flash sub-device file is opened, the LED class device sysfs interface is made unavailable. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc

Re: [PATCH/RFC v9 01/19] leds: Add LED Flash class extension to the LED subsystem

2014-12-04 Thread Jacek Anaszewski
Hi Sakari, Thanks for the review. On 12/03/2014 05:50 PM, Sakari Ailus wrote: Hi Jacek, Thanks for the update. A few comments below. On Wed, Dec 03, 2014 at 05:06:36PM +0100, Jacek Anaszewski wrote: Some LED devices support two operation modes - torch and flash. This patch provides support

Re: [PATCH/RFC v9 02/19] Documentation: leds: Add description of LED Flash class extension

2014-12-04 Thread Jacek Anaszewski
Hi Sakari, Thanks for the review. On 12/03/2014 06:08 PM, Sakari Ailus wrote: Hi Jacek, On Wed, Dec 03, 2014 at 05:06:37PM +0100, Jacek Anaszewski wrote: The documentation being added contains overall description of the LED Flash Class and the related sysfs attributes. Signed-off-by: Jacek

Re: [PATCH/RFC v9 05/19] leds: Add support for max77693 mfd flash cell

2014-12-04 Thread Jacek Anaszewski
Hi Sakari, Thanks for the review. On 12/04/2014 10:39 AM, Sakari Ailus wrote: Hi Jacek, On Wed, Dec 03, 2014 at 05:06:40PM +0100, Jacek Anaszewski wrote: This patch adds led-flash support to Maxim max77693 chipset. A device can be exposed to user space through LED subsystem sysfs interface

Re: [PATCH/RFC v9 06/19] DT: Add documentation for the mfd Maxim max77693

2014-12-04 Thread Jacek Anaszewski
Hi Sakari, Thanks for the review. On 12/04/2014 11:07 AM, Sakari Ailus wrote: Hi Jacek, On Wed, Dec 03, 2014 at 05:06:41PM +0100, Jacek Anaszewski wrote: This patch adds device tree binding documentation for the flash cell of the Maxim max77693 multifunctional device. Signed-off-by: Jacek

Re: [PATCH/RFC v9 06/19] DT: Add documentation for the mfd Maxim max77693

2014-12-08 Thread Jacek Anaszewski
Hi Pavel, On 12/04/2014 05:12 PM, Pavel Machek wrote: Hi! +- maxim,boost-mode : + In boost mode the device can produce up to 1.2A of total current + on both outputs. The maximum current on each output is reduced + to 625mA then. If there are two child led nodes defined then b

Re: [PATCH/RFC v8 02/14] Documentation: leds: Add description of LED Flash class extension

2014-12-08 Thread Jacek Anaszewski
have to be different than for the devices which don't clear faults on readout. In case of devices which use writing to clear error code - I'd do that after reading flash_fault attribute, in the same callback. Best Regards, Jacek Anaszewski -- To unsubscribe from this list: send the lin

Re: [PATCH/RFC v8 01/14] leds: Add LED Flash class extension to the LED subsystem

2014-12-08 Thread Jacek Anaszewski
On 12/05/2014 08:27 PM, Bryan Wu wrote: On Fri, Nov 28, 2014 at 1:17 AM, Jacek Anaszewski wrote: Some LED devices support two operation modes - torch and flash. This patch provides support for flash LED devices in the LED subsystem by introducing new sysfs attributes and kernel internal

Re: [PATCH/RFC v8 02/14] Documentation: leds: Add description of LED Flash class extension

2014-12-09 Thread Jacek Anaszewski
Hi Pavel, On 12/08/2014 09:18 PM, Pavel Machek wrote: On Mon 2014-12-08 17:55:20, Jacek Anaszewski wrote: On 12/06/2014 01:43 PM, Pavel Machek wrote: The format of a sysfs attribute should be concise. The error codes are generic and map directly to the V4L2 Flash error codes. Actually

Re: [PATCH/RFC v9 04/19] mfd: max77693: adjust max77693_led_platform_data

2014-12-09 Thread Jacek Anaszewski
On 12/09/2014 09:50 AM, Lee Jones wrote: On Wed, 03 Dec 2014, Jacek Anaszewski wrote: Add "label" array for Device Tree strings with the name of a LED device and make flash_timeout a two element array, for caching the sub-led related flash timeout. Added is also an array for cachin

Re: [PATCH/RFC v9 03/19] mfd: max77693: Modify flash cell name identifiers

2014-12-09 Thread Jacek Anaszewski
On 12/09/2014 09:52 AM, Lee Jones wrote: On Wed, 03 Dec 2014, Jacek Anaszewski wrote: Change flash cell identifiers from max77693-flash to max77693-led to avoid confusion with NOR/NAND Flash. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Chanwoo Choi Cc: Lee Jones

Re: [PATCH/RFC v9 04/19] mfd: max77693: adjust max77693_led_platform_data

2014-12-09 Thread Jacek Anaszewski
On 12/09/2014 11:04 AM, Lee Jones wrote: On Tue, 09 Dec 2014, Jacek Anaszewski wrote: On 12/09/2014 09:50 AM, Lee Jones wrote: On Wed, 03 Dec 2014, Jacek Anaszewski wrote: Add "label" array for Device Tree strings with the name of a LED device and make flash_timeout a two element

<    1   2   3   4   5   6   7   8   >