[PATCH 2/2] media: dvb: represent min/max/step/tolerance freqs in Hz

2018-07-04 Thread Mauro Carvalho Chehab
nd by needing to hack the drivers in order to support such hybrid frontends. So, convert everything to specify frontend frequencies in Hz. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/siano/smsdvb-main.c | 6 +- drivers/media/dvb-core/dvb_frontend.c

[PATCH 1/2] media: dvb: convert tuner_info frequencies to Hz

2018-07-04 Thread Mauro Carvalho Chehab
ng to hack the drivers in order to support such hybrid tuners. So, convert everything to specify tuner frequencies in Hz. Plese notice that a similar patch is also needed for frontends. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-core/dvb_frontend.c

Re: [PATCH v3 0/3] IOCTLs in ddbridge.

2018-07-04 Thread Mauro Carvalho Chehab
Hi Daniel, Em Sat, 12 May 2018 13:24:29 +0200 Daniel Scheller escreveu: > From: Daniel Scheller > > Third iteration of the IOCTL patches for ddbridge, split into multiple > patches: > > Patch 1 just adds the reservation/information of the used IOCTLs into > ioctl-numbers.txt in the Docs dir.

Re: [PATCH] vivid: fix gain when autogain is on

2018-07-04 Thread Mauro Carvalho Chehab
Em Fri, 29 Jun 2018 11:40:41 +0200 Hans Verkuil escreveu: > In the vivid driver you want gain to continuous change while autogain > is on. However, dev->jiffies_vid_cap doesn't actually change. It probably > did in the past, but changes in the code caused this to be a fixed value > that is only s

Re: [PATCHv15 29/35] Documentation: v4l: document request API

2018-07-03 Thread Mauro Carvalho Chehab
Em Tue, 3 Jul 2018 15:02:05 +0200 Hans Verkuil escreveu: > On 03/07/18 13:50, Mauro Carvalho Chehab wrote: > > Em Mon, 4 Jun 2018 13:46:42 +0200 > > Hans Verkuil escreveu: > > > >> From: Alexandre Courbot > >> > >> Document the request A

Re: [PATCHv15 29/35] Documentation: v4l: document request API

2018-07-03 Thread Mauro Carvalho Chehab
Em Mon, 4 Jun 2018 13:46:42 +0200 Hans Verkuil escreveu: > From: Alexandre Courbot > > Document the request API for V4L2 devices, and amend the documentation > of system calls influenced by it. I'm starting reviewing the patch series from this patch, as it defines how the request API is suppo

Re: [PATCHv15 01/35] uapi/linux/media.h: add request API

2018-07-03 Thread Mauro Carvalho Chehab
Em Tue, 3 Jul 2018 11:33:13 +0200 Hans Verkuil escreveu: > On 03/07/18 11:21, Mauro Carvalho Chehab wrote: > > Em Mon, 4 Jun 2018 13:46:14 +0200 > > Hans Verkuil escreveu: > > > >> From: Hans Verkuil > >> > >> Define the

Re: [PATCHv15 01/35] uapi/linux/media.h: add request API

2018-07-03 Thread Mauro Carvalho Chehab
Em Mon, 4 Jun 2018 13:46:14 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > Define the public request API. > > This adds the new MEDIA_IOC_REQUEST_ALLOC ioctl to allocate a request > and two ioctls that operate on a request in order to queue the > contents of the request to the driver a

Re: [RFC] Make entity to interface links immutable

2018-07-02 Thread Mauro Carvalho Chehab
Em Mon, 2 Jul 2018 12:38:23 +0200 Hans Verkuil escreveu: > On 02/07/18 11:41, Mauro Carvalho Chehab wrote: > > Em Mon, 2 Jul 2018 10:18:37 +0200 > > Hans Verkuil escreveu: > > > >> While working on v4l2-compliance I noticed that entity to inte

Re: [RFC] Make entity to interface links immutable

2018-07-02 Thread Mauro Carvalho Chehab
Em Mon, 2 Jul 2018 10:18:37 +0200 Hans Verkuil escreveu: > While working on v4l2-compliance I noticed that entity to interface links > have just the MEDIA_LNK_FL_ENABLED flag set. > > Shouldn't we also set the MEDIA_LNK_FL_IMMUTABLE? After all, you cannot change > an entity-interface link. It fe

Re: [PATCHv4 02/10] media-ioc-g-topology.rst: document new 'index' field

2018-06-29 Thread Mauro Carvalho Chehab
Em Fri, 29 Jun 2018 12:26:50 +0200 Hans Verkuil escreveu: > On 06/29/18 11:54, Mauro Carvalho Chehab wrote: > > Em Thu, 28 Jun 2018 15:12:00 +0200 > > Hans Verkuil escreveu: > > > >> From: Hans Verkuil > >> > >> Document the new struct med

Re: [PATCHv4 00/10] media/mc: fix inconsistencies

2018-06-29 Thread Mauro Carvalho Chehab
Em Thu, 28 Jun 2018 15:11:58 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > This series is v4 of my previous attempt: > > https://www.mail-archive.com/linux-media@vger.kernel.org/msg132942.html Patches 1 and 3-10 looks OK to me. Thanks, Mauro

Re: [PATCHv4 02/10] media-ioc-g-topology.rst: document new 'index' field

2018-06-29 Thread Mauro Carvalho Chehab
Em Thu, 28 Jun 2018 15:12:00 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > Document the new struct media_v2_pad 'index' field. > > Signed-off-by: Hans Verkuil > Acked-by: Sakari Ailus > --- > .../media/uapi/mediactl/media-ioc-g-topology.rst | 11 +-- > 1 file changed, 9

Re: [PATCH] [RFC] em28xx: Fix dual transport stream use

2018-06-28 Thread Mauro Carvalho Chehab
Em Thu, 28 Jun 2018 12:33:41 -0500 Brad Love escreveu: > Hi Mauro, > > > On 2018-06-28 09:23, Brad Love wrote: > > Hi Mauro, > > > > > > On 2018-06-28 04:10, Mauro Carvalho Chehab wrote: > >> Em Wed, 27 Jun 2018 14:41:22 -0500 > >> Brad L

Re: [GIT PULL FOR v4.19] Convert last soc-camera users, rcar fixes, subdev std support

2018-06-28 Thread Mauro Carvalho Chehab
Em Fri, 8 Jun 2018 16:39:43 +0200 Hans Verkuil escreveu: > Hi Mauro, > > This pull requests converts the last users of soc-camera (thanks, Jacopo!), > has a few rcar fixes and adds support for SDTV to v4l2-subdev (HDTV was > supported, but not SDTV). > > Regards, > > Hans > > The follow

Re: [PATCH] [RFC] em28xx: Fix dual transport stream use

2018-06-28 Thread Mauro Carvalho Chehab
Em Wed, 27 Jun 2018 14:41:22 -0500 Brad Love escreveu: > When dual transport stream support was added the call to set > alt mode on the USB interface was moved to em28xx_dvb_init. > This was reported to break streaming for a device, so the > call was re-added to em28xx_start_streaming. > > Commi

Re: Software-only image processing for Intel "complex" cameras

2018-06-25 Thread Mauro Carvalho Chehab
Em Mon, 25 Jun 2018 09:48:56 + "Zheng, Jian Xu" escreveu: > Hi Mauro, > > > -Original Message- > > From: linux-media-ow...@vger.kernel.org [mailto:linux-media- > > ow...@vger.kernel.org] On Behalf Of Mauro Carvalho Chehab > > Se

Re: Software-only image processing for Intel "complex" cameras

2018-06-21 Thread Mauro Carvalho Chehab
Em Fri, 22 Jun 2018 06:08:50 +0900 Mauro Carvalho Chehab escreveu: > Em Thu, 21 Jun 2018 18:58:37 + > escreveu: > > > > -Original Message- > > > From: Mauro Carvalho Chehab [mailto:mchehab+sams...@kernel.org] > > > Sent: Thursday, June 21, 2018

Re: Software-only image processing for Intel "complex" cameras

2018-06-21 Thread Mauro Carvalho Chehab
Em Thu, 21 Jun 2018 18:58:37 + escreveu: > > -Original Message- > > From: Mauro Carvalho Chehab [mailto:mchehab+sams...@kernel.org] > > Sent: Thursday, June 21, 2018 1:50 PM > > To: Limonciello, Mario > > Cc: pa...@ucw.cz; nico...@ndufresne.c

Re: Software-only image processing for Intel "complex" cameras

2018-06-21 Thread Mauro Carvalho Chehab
Em Thu, 21 Jun 2018 13:41:37 + escreveu: > > -Original Message- > > From: Pavel Machek [mailto:pa...@ucw.cz] > > Sent: Wednesday, June 20, 2018 4:12 PM > > To: Nicolas Dufresne > > Cc: linux-media@vger.kernel.org; sakari.ai...@linux.intel.com; > > niklas.soderl...@ragnatech.se; jerry.

Re: Software-only image processing for Intel "complex" cameras

2018-06-21 Thread Mauro Carvalho Chehab
Em Wed, 20 Jun 2018 16:57:59 -0400 Nicolas Dufresne escreveu: > The IPU3 sensor produce a vendor specific form of bayer. If we manage > to implement support for this format, it would likely be done in > software. I don't think anyone can answer your other questions has no > one have ever implemen

Re: [ANN v2] Complex Camera Workshop - Tokyo - Jun, 19

2018-06-07 Thread Mauro Carvalho Chehab
Em Thu, 7 Jun 2018 16:47:50 +0900 Tomasz Figa escreveu: > On Thu, Jun 7, 2018 at 1:26 AM Mauro Carvalho Chehab > wrote: > > > > Em Wed, 6 Jun 2018 13:19:39 +0900 > > Tomasz Figa escreveu: > > > > > On Mon, Jun 4, 2018 at 10:33 PM Mauro Carvalho Cheh

Re: [RFC, libv4l]: Make libv4l2 usable on devices with complex pipeline

2018-06-06 Thread Mauro Carvalho Chehab
Em Wed, 6 Jun 2018 12:51:16 +0200 Pavel Machek escreveu: > > > > The scenario that I could think of is: > > > > - legacy app would call open(/dev/video?), which would be handled by > > > > libv4l open hook (v4l2_open()?), > > > > > > I don't think that kind of legacy apps is in use any more. I'

Re: [RFC, libv4l]: Make libv4l2 usable on devices with complex pipeline

2018-06-06 Thread Mauro Carvalho Chehab
Em Wed, 6 Jun 2018 12:01:50 +0200 Pavel Machek escreveu: > Hi! > > > > > Who would be calling this function? > > > > > > > > The scenario that I could think of is: > > > > - legacy app would call open(/dev/video?), which would be handled by > > > > libv4l open hook (v4l2_open()?), > > > > > >

Re: [ANN v2] Complex Camera Workshop - Tokyo - Jun, 19

2018-06-06 Thread Mauro Carvalho Chehab
Em Wed, 6 Jun 2018 13:19:39 +0900 Tomasz Figa escreveu: > On Mon, Jun 4, 2018 at 10:33 PM Mauro Carvalho Chehab > wrote: > > > > Hi all, > > > > I consolidated hopefully all comments I receive on the past announcement > > with regards to the complex camera

Re: [ANN] Prague Media summit report October 2017

2018-06-04 Thread Mauro Carvalho Chehab
Em Tue, 16 Jan 2018 11:11:54 +0200 Sakari Ailus escreveu: > Hello everyone, > > Here's the Prague Media summit report from 26th and 27th October 2017. It > took long but finally it's here! It took an even longer time, but I finally added it to our "news" and added the group photo: https

[ANN v2] Complex Camera Workshop - Tokyo - Jun, 19

2018-06-04 Thread Mauro Carvalho Chehab
ndle pipeline configuration). 4 Complex camera workshop = The workshop will be happening in Tokyo, Japan, at Jun, 19, at the google offices. The location is: 〒106-6126 Tokyo, Minato, Roppongi, 6 Chome−10−1 Roppongi Hills Mori Tower 44F 4.1 Physical Attendees =

Re: [ANN] Meeting to discuss improvements to support MC-based cameras on generic apps

2018-05-31 Thread Mauro Carvalho Chehab
Em Thu, 31 May 2018 23:18:38 +0900 Tomasz Figa escreveu: > Hi Hans and everyone, > > On Thu, May 31, 2018 at 10:58 PM Hans Verkuil wrote: > > > > On 05/31/18 15:22, Mauro Carvalho Chehab wrote: > > > Em Mon, 28 May 2018 10:43:51 -0300 > > > Mauro Carva

Re: [ANN] Meeting to discuss improvements to support MC-based cameras on generic apps

2018-05-31 Thread Mauro Carvalho Chehab
Em Mon, 28 May 2018 10:43:51 -0300 Mauro Carvalho Chehab escreveu: > Em Thu, 17 May 2018 16:07:08 -0300 > Mauro Carvalho Chehab escreveu: > > > Hi all, > > > > The goal of this e-mail is to schedule a meeting in order to discuss > > improvements at the me

[PATCH 3/3] media: videodev2: get rid of VIDIOC_RESERVED

2018-05-30 Thread Mauro Carvalho Chehab
While this ioctl is there at least since Kernel 2.6.12-rc2, it was never used by any upstream driver. Get rid of it. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/videodev2.h.rst.exceptions | 1 - include/uapi/linux/videodev2.h | 1 - 2 files changed, 2 deletions

[PATCH 2/3] media: dvb/audio.h: get rid of unused APIs

2018-05-30 Thread Mauro Carvalho Chehab
There are a number of other ioctls that aren't used anywhere inside the Kernel tree. Get rid of them. Signed-off-by: Mauro Carvalho Chehab --- .../media/uapi/dvb/audio-get-pts.rst | 65 -- .../media/uapi/dvb/audio-set-attributes.rst

[PATCH 1/3] media: dvb/video.h: get rid of unused APIs

2018-05-30 Thread Mauro Carvalho Chehab
There are a number of other ioctls that aren't used anywhere inside the Kernel tree. Get rid of them. Signed-off-by: Mauro Carvalho Chehab --- .../media/uapi/dvb/video-get-frame-rate.rst | 61 -- .../media/uapi/dvb/video-get-navi.rst | 84 - .../media/uap

[PATCH v2] media: dvb: get rid of VIDEO_SET_SPU_PALETTE

2018-05-30 Thread Mauro Carvalho Chehab
No upstream drivers use it. It doesn't make any sense to have a compat32 code for something that nobody uses upstream. Reported-by: Alexander Viro Signed-off-by: Mauro Carvalho Chehab --- .../media/uapi/dvb/video-set-spu-palette.rst | 82 --- .../media/uap

Re: [PATCH v5 03/14] media: ov772x: allow i2c controllers without I2C_FUNC_PROTOCOL_MANGLING

2018-05-29 Thread Mauro Carvalho Chehab
Em Tue, 29 May 2018 15:29:29 +0200 Wolfram Sang escreveu: > > It is a very bad idea to replace an i2c xfer by a pair of i2c > > send()/recv(), as, if are there any other device at the bus managed > > by an independent driver, you may end by mangling i2c transfers and > > eventually cause device m

Re: [PATCH v5 03/14] media: ov772x: allow i2c controllers without I2C_FUNC_PROTOCOL_MANGLING

2018-05-29 Thread Mauro Carvalho Chehab
for example). So, IMO, the best is to push the patch you proposed that adds a new I2C flag: https://patchwork.linuxtv.org/patch/49396/ > Cc: Jacopo Mondi > Cc: Laurent Pinchart > Cc: Hans Verkuil > Cc: Sakari Ailus > Cc: Mauro Carvalho Chehab > Cc: Wolfram

Re: [RFC PATCH] i2c: add I2C_M_FORCE_STOP

2018-05-29 Thread Mauro Carvalho Chehab
nt->adapter, msg, 2); > if (ret != 2) > return (ret < 0) ? ret : -EIO; > > return val; > } > > This is another approach based on Mauro's advise for the initial attempt > (http://patchwork.ozlabs.org/patch/905192/). > >

[PATCH] media: imx258: get rid of an unused var

2018-05-28 Thread Mauro Carvalho Chehab
drivers/media/i2c/imx258.c: In function 'imx258_init_controls': drivers/media/i2c/imx258.c:1117:6: warning: variable 'exposure_max' set but not used [-Wunused-but-set-variable] s64 exposure_max; ^~~~ Signed-off-by: Mauro Carvalho Chehab --- drivers/media/i2

Re: [GIT PULL FOR v4.18] R-Car VSP1 TLB optimisation

2018-05-28 Thread Mauro Carvalho Chehab
Em Mon, 28 May 2018 11:31:01 +0300 Laurent Pinchart escreveu: > Hi Mauro and Dan, > > Dan, there's a question for you below. > > On Monday, 28 May 2018 11:28:41 EEST Laurent Pinchart wrote: > > On Saturday, 26 May 2018 14:28:18 EEST Mauro Carvalho Chehab wrote: &g

[PATCH] media: dvb: get rid of VIDEO_SET_SPU_PALETTE

2018-05-28 Thread Mauro Carvalho Chehab
No upstream drivers use it. It doesn't make any sense to have a compat32 code for something that nobody uses upstream. Reported-by: Alexander Viro Signed-off-by: Mauro Carvalho Chehab --- .../media/uapi/dvb/video-set-spu-palette.rst | 82 --- .../media/uap

Re: [ANN] Meeting to discuss improvements to support MC-based cameras on generic apps

2018-05-28 Thread Mauro Carvalho Chehab
Em Thu, 17 May 2018 16:07:08 -0300 Mauro Carvalho Chehab escreveu: > Hi all, > > The goal of this e-mail is to schedule a meeting in order to discuss > improvements at the media subsystem in order to support complex camera > hardware by usual apps. > > The main f

Re: [GIT PULL FOR v4.18] R-Car VSP1 TLB optimisation

2018-05-28 Thread Mauro Carvalho Chehab
Em Mon, 28 May 2018 11:28:41 +0300 Laurent Pinchart escreveu: > Hi Mauro, > > On Saturday, 26 May 2018 14:28:18 EEST Mauro Carvalho Chehab wrote: > > Em Sat, 26 May 2018 03:24:00 +0300 Laurent Pinchart escreveu: > > [snip] > > > > I've reproduced the

Re: [GIT PULL FOR v4.18] R-Car VSP1 TLB optimisation

2018-05-26 Thread Mauro Carvalho Chehab
Em Sat, 26 May 2018 03:24:00 +0300 Laurent Pinchart escreveu: > Hi Mauro, > > On Saturday, 26 May 2018 02:39:16 EEST Laurent Pinchart wrote: > > On Saturday, 26 May 2018 02:10:27 EEST Mauro Carvalho Chehab wrote: > > > Em Sun, 20 May 2018 15:10:50 +0300 Laurent Pincha

Re: [GIT PULL FOR v4.18] R-Car VSP1 TLB optimisation

2018-05-25 Thread Mauro Carvalho Chehab
Em Sun, 20 May 2018 15:10:50 +0300 Laurent Pinchart escreveu: > Hi Mauro, > > The following changes since commit 8ed8bba70b4355b1ba029b151ade84475dd12991: > > media: imx274: remove non-indexed pointers from mode_table (2018-05-17 > 06:22:08 -0400) > > are available in the Git repository at:

Re: [media] duplicate code in media drivers

2018-05-21 Thread Mauro Carvalho Chehab
Em Mon, 21 May 2018 14:39:51 -0500 "Gustavo A. R. Silva" escreveu: > Hi Mauro, > > I found some duplicate code with the help of Coccinelle and Coverity. Notice > that these are not code patches, they only point out the duplicate code in > some media drivers: > > diff -u -p drivers/media/pci/b

Re: [ANN] Meeting to discuss improvements to support MC-based cameras on generic apps

2018-05-18 Thread Mauro Carvalho Chehab
Em Fri, 18 May 2018 15:27:24 +0300 Laurent Pinchart escreveu: > Hi Mauro, > > On Thursday, 17 May 2018 22:07:08 EEST Mauro Carvalho Chehab wrote: > > Hi all, > > > > The goal of this e-mail is to schedule a meeting in order to discuss > > improvements at the me

Re: [ANN] Meeting to discuss improvements to support MC-based cameras on generic apps

2018-05-18 Thread Mauro Carvalho Chehab
Em Fri, 18 May 2018 11:15:39 +0300 Laurent Pinchart escreveu: > Hi Nicolas, > > On Friday, 18 May 2018 00:38:53 EEST Nicolas Dufresne wrote: > > Le jeudi 17 mai 2018 à 16:07 -0300, Mauro Carvalho Chehab a écrit : > > > Hi all, > > > > > > The goal

[ANN] Meeting to discuss improvements to support MC-based cameras on generic apps

2018-05-17 Thread Mauro Carvalho Chehab
Hi all, The goal of this e-mail is to schedule a meeting in order to discuss improvements at the media subsystem in order to support complex camera hardware by usual apps. The main focus here is to allow supporting devices with MC-based hardware connected to a camera. In short, my proposal is to

Re: [PATCH 01/11] media: tm6000: fix potential Spectre variant 1

2018-05-17 Thread Mauro Carvalho Chehab
Em Thu, 17 May 2018 08:43:24 -0300 Mauro Carvalho Chehab escreveu: > > > > On 05/15/2018 02:39 PM, Dan Carpenter wrote: > > > > > >> You'd need to rebuild the db (possibly twice but definitely once). > > > > How? Here, I just pull fro

Re: [PATCH 01/11] media: tm6000: fix potential Spectre variant 1

2018-05-17 Thread Mauro Carvalho Chehab
Em Thu, 17 May 2018 08:34:40 -0300 Mauro Carvalho Chehab escreveu: > Em Thu, 17 May 2018 05:36:03 -0500 > "Gustavo A. R. Silva" escreveu: > > > > > > > On 05/16/2018 08:14 PM, Gustavo A. R. Silva wrote: > > > > > > > > > On 0

Re: [PATCH 01/11] media: tm6000: fix potential Spectre variant 1

2018-05-17 Thread Mauro Carvalho Chehab
Em Thu, 17 May 2018 05:36:03 -0500 "Gustavo A. R. Silva" escreveu: > > > On 05/16/2018 08:14 PM, Gustavo A. R. Silva wrote: > > > > > > On 05/15/2018 02:39 PM, Dan Carpenter wrote: > >> You'd need to rebuild the db (possibly twice but definitely once). How? Here, I just pull from your git t

[PATCH] media: dw9807: remove an unused var

2018-05-16 Thread Mauro Carvalho Chehab
drivers/media/i2c/dw9807.c: In function 'dw9807_set_dac': drivers/media/i2c/dw9807.c:81:16: warning: unused variable 'retry' [-Wunused-variable] int val, ret, retry = 0; ^ Signed-off-by: Mauro Carvalho Chehab --- drivers/media/i2c/dw9807.c | 2 +- 1 file

Re: [PATCH 01/11] media: tm6000: fix potential Spectre variant 1

2018-05-16 Thread Mauro Carvalho Chehab
Em Wed, 16 May 2018 16:11:08 +0300 Dan Carpenter escreveu: > On Tue, May 15, 2018 at 04:00:33PM -0300, Mauro Carvalho Chehab wrote: > > Yeah, that's the same I'm getting from media upstream. > > > > > drivers/media/cec/cec-pin-error-inj.c:170 cec_pin_

Re: [RFC, libv4l]: Make libv4l2 usable on devices with complex pipeline

2018-05-15 Thread Mauro Carvalho Chehab
Em Tue, 15 May 2018 22:01:17 +0200 Pavel Machek escreveu: > Hi! > > > So, IMHO, entities should be described as: > > > > [entity entity1] > > name = foo > > function = bar > > I don't really think windows-style config file is suitable here, as we > have more than

Re: [PATCH v4 0/6] Asynchronous UVC

2018-05-15 Thread Mauro Carvalho Chehab
Em Tue, 15 May 2018 21:19:50 +0100 Kieran Bingham escreveu: > Hi Mauro, > > On 15/05/18 20:22, Mauro Carvalho Chehab wrote: > > Em Tue, 27 Mar 2018 17:45:57 +0100 > > Kieran Bingham escreveu: > > > >> The Linux UVC driver has long provided adequat

[PATCH] media: cec-pin-error-inj: avoid a false-positive Spectre detection

2018-05-15 Thread Mauro Carvalho Chehab
;pin->error_inj_args' Signed-off-by: Mauro Carvalho Chehab --- drivers/media/cec/cec-pin-error-inj.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/media/cec/cec-pin-error-inj.c b/drivers/media/cec/cec-pin-error-inj.c index 7132a2758bd

Re: [PATCH v4 0/6] Asynchronous UVC

2018-05-15 Thread Mauro Carvalho Chehab
Em Tue, 27 Mar 2018 17:45:57 +0100 Kieran Bingham escreveu: > The Linux UVC driver has long provided adequate performance capabilities for > web-cams and low data rate video devices in Linux while resolutions were low. > > Modern USB cameras are now capable of high data rates thanks to USB3 with

Re: [PATCH 01/11] media: tm6000: fix potential Spectre variant 1

2018-05-15 Thread Mauro Carvalho Chehab
macro. This fixes indirect call > >> mismatches with Control-Flow Integrity, caused by calling standard > >> ioctls using a function pointer that doesn't match the function type. > >> > >> Signed-off-by: Sami Tolvanen > >>

[PATCH] media: dvb_ca_en50221: prevent using slot_info for Spectre attacs

2018-05-15 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-core/dvb_ca_en50221.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/dvb-core/dvb_ca_en50221.c b/drivers/media/dvb-core/dvb_ca_en50221.c index 97365a863519..1310526b0d49 100644 --- a/drivers/media/dvb-core/dvb_ca_en

[PATCH] media: dvb_ca_en50221: prevent using slot_info for Spectre attacs

2018-05-15 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-core/dvb_ca_en50221.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/dvb-core/dvb_ca_en50221.c b/drivers/media/dvb-core/dvb_ca_en50221.c index 97365a863519..1310526b0d49 100644 --- a/drivers/media/dvb-core/dvb_ca_en

Re: [PATCH 01/11] media: tm6000: fix potential Spectre variant 1

2018-05-15 Thread Mauro Carvalho Chehab
Em Mon, 14 May 2018 22:31:37 -0500 "Gustavo A. R. Silva" escreveu: > Hi Mauro, > > On 04/26/2018 06:42 PM, Mauro Carvalho Chehab wrote: > > >> > >> I noticed you changed the status of this series from rejected to new. > > > > Yes. > &g

Re: Are media drivers abusing of GFP_DMA? - was: Re: [LSF/MM TOPIC NOTES] x86 ZONE_DMA love

2018-05-15 Thread Mauro Carvalho Chehab
Hi Laurent, Em Tue, 15 May 2018 11:27:44 +0300 Laurent Pinchart escreveu: > Hello, > > On Tuesday, 15 May 2018 10:30:28 EEST Fabien DESSENNE wrote: > > On 14/05/18 12:39, Mauro Carvalho Chehab wrote: > > > Em Mon, 14 May 2018 07:35:03 -0300 Mauro Carvalho Chehab escre

Re: Are media drivers abusing of GFP_DMA? - was: Re: [LSF/MM TOPIC NOTES] x86 ZONE_DMA love

2018-05-14 Thread Mauro Carvalho Chehab
Em Mon, 14 May 2018 07:35:03 -0300 Mauro Carvalho Chehab escreveu: > Hi Fabien, > > Em Mon, 14 May 2018 08:00:37 + > Fabien DESSENNE escreveu: > > > On 07/05/18 17:19, Mauro Carvalho Chehab wrote: > > > Em Mon, 07 May 2018 16:26:08 +0300 > > > Lauren

Re: Are media drivers abusing of GFP_DMA? - was: Re: [LSF/MM TOPIC NOTES] x86 ZONE_DMA love

2018-05-14 Thread Mauro Carvalho Chehab
Hi Fabien, Em Mon, 14 May 2018 08:00:37 + Fabien DESSENNE escreveu: > On 07/05/18 17:19, Mauro Carvalho Chehab wrote: > > Em Mon, 07 May 2018 16:26:08 +0300 > > Laurent Pinchart escreveu: > > > >> Hi Mauro, > >> > >> On Saturday, 5 Ma

Re: [PATCH v6 3/5] dvb-usb/friio, dvb-usb-v2/gl861: decompose friio and merge with gl861

2018-05-13 Thread Mauro Carvalho Chehab
Em Mon, 14 May 2018 03:13:44 +0900 Akihiro TSUKADA escreveu: > Hi, > thanks for the review. > > >> +gl861_i2c_rawwrite(struct dvb_usb_device *d, u8 addr, u8 *wbuf, u16 > >> wlen)>> +{>> +u8 *buf;>> +int ret;>> +>> +buf = > >> kmalloc(wlen, GFP_KERNEL);>> +if (!buf)>> +

[PATCH] media: update/fix my e-mail on some places

2018-05-10 Thread Mauro Carvalho Chehab
on, all places will be pointing to the same SMTP server. Signed-off-by: Mauro Carvalho Chehab --- Documentation/ABI/testing/sysfs-class-rc | 16 Documentation/ABI/testing/sysfs-class-rc-nuvoton | 2 +- Documentation/ABI/testing/sysfs-devices-edac | 14 +++---

Re: Regression: DVBSky S960 USB tuner doesn't work in 4.10 or newer

2018-05-10 Thread Mauro Carvalho Chehab
(you probably did not expect > that either). Ok, I'll apply it then. Having one less lock makes it cleaner. > > > Cheers, > -olli > > On 27 April 2018 at 18:33, Mauro Carvalho Chehab > wrote: > > Em Fri, 27 Apr 2018 16:25:08 +0200 > > Olli S

[PATCH] qm1d1b0004: fix a warning about an unused default_cfg var

2018-05-10 Thread Mauro Carvalho Chehab
unused. So, comment it out. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/tuners/qm1d1b0004.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/tuners/qm1d1b0004.c b/drivers/media/tuners/qm1d1b0004.c index 9dac1b875c18..b4495cc1626b 100644 --- a/drivers/media/tuners/qm

Re: [GIT PULL for 4.18] Cadence CSI-2 TX and RX drivers

2018-05-09 Thread Mauro Carvalho Chehab
Em Mon, 7 May 2018 15:35:43 +0300 Sakari Ailus escreveu: > Hi Mauro, > > Here are the drivers for Cadence CSI-2 TX and RX hardware blocks. > > Please pull. > > > The following changes since commit f10379aad39e9da8bc7d1822e251b5f0673067ef: > > media: include/video/omapfb_dss.h: use IS_ENABL

Re: [RESEND PATCH v9 2/2] media: dw9807: Add dw9807 vcm driver

2018-05-09 Thread Mauro Carvalho Chehab
Em Wed, 2 May 2018 23:53:48 +0800 Andy Yeh escreveu: > From: Alan Chiang > > DW9807 is a 10 bit DAC from Dongwoon, designed for linear > control of voice coil motor. > > This driver creates a V4L2 subdevice and > provides control to set the desired focus. > > Signed-off-by: Andy Yeh > Revie

Re: [PATCH v11] media: imx258: Add imx258 camera sensor driver

2018-05-09 Thread Mauro Carvalho Chehab
Em Wed, 2 May 2018 23:46:08 +0800 Andy Yeh escreveu: > From: Jason Chen > > Add a V4L2 sub-device driver for the Sony IMX258 image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for data. > > Signed-off-by: Andy Yeh > Signed-off-by: Alan Chiang > Reviewe

[PATCH 3/3] media: v4l: fix broken video4linux docs locations

2018-05-09 Thread Mauro Carvalho Chehab
/video4linux/videobuf Documentation/video4linux/Zoran Make them point to the new location where available, removing otherwise. Signed-off-by: Mauro Carvalho Chehab --- .../translations/zh_CN/video4linux/v4l2-framework.txt | 6 +++--- drivers/media/pci/bt8xx/Kconfig| 2

[PATCH 2/3] media: dvb: point to the location of the old README.dvb-usb file

2018-05-09 Thread Mauro Carvalho Chehab
This file got renamed, but the references still point to the old place. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/dib3000.h| 2 +- drivers/media/dvb-frontends/dib3000mb.c | 2 +- drivers/media/dvb-frontends/eds1547.h| 2 +- drivers/media/dvb

[PATCH 1/3] media: dvb: fix location of get_dvb_firmware script

2018-05-09 Thread Mauro Carvalho Chehab
This script was moved out of Documentation/dvb, but the links weren't updated. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/Kconfig | 18 +- drivers/media/dvb-frontends/nxt200x.c| 4 ++-- drivers/media/dvb-frontends/or51211.c

Re: [PATCHv13 03/28] media-request: implement media requests

2018-05-08 Thread Mauro Carvalho Chehab
Em Tue, 8 May 2018 13:52:33 +0300 Sakari Ailus escreveu: > Hi Mauro, Hans, > > On Tue, May 08, 2018 at 07:21:16AM -0300, Mauro Carvalho Chehab wrote: > > Em Fri, 4 May 2018 15:27:50 +0300 > > Sakari Ailus escreveu: > > > > > Hi Hans, > > > >

Re: [PATCHv13 12/28] v4l2-ctrls: add core request support

2018-05-08 Thread Mauro Carvalho Chehab
Em Tue, 8 May 2018 10:07:22 +0200 Hans Verkuil escreveu: > >> diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2-ctrls.h > >> index 76352eb59f14..a0f7c38d1a90 100644 > >> --- a/include/media/v4l2-ctrls.h > >> +++ b/include/media/v4l2-ctrls.h > >> @@ -250,6 +250,10 @@ struct v4l2_ctrl {

Re: [PATCHv13 06/28] v4l2-dev: lock req_queue_mutex

2018-05-08 Thread Mauro Carvalho Chehab
Em Tue, 8 May 2018 09:45:27 +0200 Hans Verkuil escreveu: > On 05/07/2018 07:20 PM, Mauro Carvalho Chehab wrote: > > Em Thu, 3 May 2018 16:52:56 +0200 > > Hans Verkuil escreveu: > > > >> From: Hans Verkuil > >> > >> We need to serialize str

Re: [PATCHv13 04/28] media-request: add media_request_get_by_fd

2018-05-08 Thread Mauro Carvalho Chehab
Em Tue, 8 May 2018 09:34:11 +0200 Hans Verkuil escreveu: > On 05/07/2018 07:01 PM, Mauro Carvalho Chehab wrote: > > Em Thu, 3 May 2018 16:52:54 +0200 > > Hans Verkuil escreveu: > > > >> From: Hans Verkuil > >> > >> Add media_request

Re: [PATCHv13 00/28] Request API

2018-05-08 Thread Mauro Carvalho Chehab
Em Thu, 3 May 2018 16:52:50 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > Regarding locking: > > There are two request locks used: req_queue_mutex (part of media_device) > ensures high-level serialization of queueing/reiniting and canceling > requests. It serializes STREAMON/OFF, TRY/S_

Re: [PATCHv13 03/28] media-request: implement media requests

2018-05-08 Thread Mauro Carvalho Chehab
Em Fri, 4 May 2018 15:27:50 +0300 Sakari Ailus escreveu: > Hi Hans, > > I've read this patch a large number of times and I think also the details > begin to seem sound. A few comments below. I'm sending this after analyzing the other patches in this series, as this is the core of the changes. S

Re: [PATCHv13 16/28] videobuf2-core: embed media_request_object

2018-05-08 Thread Mauro Carvalho Chehab
Em Thu, 3 May 2018 16:53:06 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > Make vb2_buffer a request object. > > Signed-off-by: Hans Verkuil > --- > include/media/videobuf2-core.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/media/videobuf2-core.h b/include/me

Re: [PATCHv13 12/28] v4l2-ctrls: add core request support

2018-05-07 Thread Mauro Carvalho Chehab
Em Thu, 3 May 2018 16:53:02 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > Integrate the request support. This adds the v4l2_ctrl_request_complete > and v4l2_ctrl_request_setup functions to complete a request and (as a > helper function) to apply a request to the hardware. > > It takes

Re: [PATCHv13 09/28] v4l2-ctrls: prepare internal structs for request API

2018-05-07 Thread Mauro Carvalho Chehab
Em Thu, 3 May 2018 16:52:59 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > Embed and initialize a media_request_object in struct v4l2_ctrl_handler. > > Add a p_req field to struct v4l2_ctrl_ref that will store the > request value. > > Signed-off-by: Hans Verkuil > Signed-off-by: Alex

Re: [PATCHv13 06/28] v4l2-dev: lock req_queue_mutex

2018-05-07 Thread Mauro Carvalho Chehab
Em Thu, 3 May 2018 16:52:56 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > We need to serialize streamon/off with queueing new requests. > These ioctls may trigger the cancellation of a streaming > operation, and that should not be mixed with queuing a new > request at the same time. >

Re: [PATCHv13 05/28] media-request: add media_request_object_find

2018-05-07 Thread Mauro Carvalho Chehab
Em Fri, 4 May 2018 15:43:07 +0300 Sakari Ailus escreveu: > On Thu, May 03, 2018 at 04:52:55PM +0200, Hans Verkuil wrote: > > From: Hans Verkuil > > > > Add media_request_object_find to find a request object inside a > > request based on ops and/or priv values. > > > > Objects of the same type

Re: [PATCHv13 04/28] media-request: add media_request_get_by_fd

2018-05-07 Thread Mauro Carvalho Chehab
Em Thu, 3 May 2018 16:52:54 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > Add media_request_get_by_fd() to find a request based on the file > descriptor. > > The caller has to call media_request_put() for the returned > request since this function increments the refcount. > > Signed-

Re: [PATCHv13 01/28] v4l2-device.h: always expose mdev

2018-05-07 Thread Mauro Carvalho Chehab
Em Fri, 4 May 2018 13:51:28 +0300 Sakari Ailus escreveu: > On Thu, May 03, 2018 at 04:52:51PM +0200, Hans Verkuil wrote: > > From: Hans Verkuil > > > > The mdev field is only present if CONFIG_MEDIA_CONTROLLER is set. > > But since we will need to pass the media_device to vb2 and the > > contro

Re: [PATCH] media: vsp1: cleanup a false positive warning

2018-05-07 Thread Mauro Carvalho Chehab
Em Mon, 07 May 2018 17:05:24 +0300 Laurent Pinchart escreveu: > Hi Mauro, > > Thank you for the patch. > > On Friday, 4 May 2018 15:13:58 EEST Mauro Carvalho Chehab wrote: > > With the new vsp1 code changes introduced by changeset > > f81f9adc4ee1 ("media:

Re: Are media drivers abusing of GFP_DMA? - was: Re: [LSF/MM TOPIC NOTES] x86 ZONE_DMA love

2018-05-07 Thread Mauro Carvalho Chehab
Em Mon, 07 May 2018 16:26:08 +0300 Laurent Pinchart escreveu: > Hi Mauro, > > On Saturday, 5 May 2018 19:08:15 EEST Mauro Carvalho Chehab wrote: > > There was a recent discussion about the use/abuse of GFP_DMA flag when > > allocating memories at LSF/MM 2018 (se

[PATCH] media: v4l2-dev.h: document VFL_TYPE_MAX

2018-05-07 Thread Mauro Carvalho Chehab
Cleanup this Sphinx warning: read./include/media/v4l2-dev.h:42: warning: Enum value 'VFL_TYPE_MAX' not described in enum 'vfl_devnode_type' Signed-off-by: Mauro Carvalho Chehab --- include/media/v4l2-dev.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/includ

Re: [PATCH 1/2] media: siano: don't use GFP_DMA

2018-05-06 Thread Mauro Carvalho Chehab
Em Sun, 6 May 2018 08:05:05 +0900 Tomoki Sekiyama escreveu: > 2018/5/6 1:09 Mauro Carvalho Chehab : > > > I can't think on a single reason why this driver would be using > > GFP_DMA. The typical usage is as an USB driver. Any DMA restrictions > > should be handled

Re: [PATCH] media: include/video/omapfb_dss.h: use IS_ENABLED()

2018-05-05 Thread Mauro Carvalho Chehab
Em Sat, 5 May 2018 10:59:23 -0700 Randy Dunlap escreveu: > On 05/04/2018 01:49 PM, Mauro Carvalho Chehab wrote: > > Just checking for ifdefs cause build issues as reported by > > kernel test: > > > > config: openrisc-allmodconfig (attached as .config) > > com

[PATCH 1/2] media: siano: don't use GFP_DMA

2018-05-05 Thread Mauro Carvalho Chehab
I can't think on a single reason why this driver would be using GFP_DMA. The typical usage is as an USB driver. Any DMA restrictions should be handled inside the HCI driver, if any. Cc: "Luis R. Rodriguez" Cc: linux...@kvack.org Signed-off-by: Mauro Carvalho Chehab --- drive

[PATCH 2/2] media: gp8psk: don't abuse of GFP_DMA

2018-05-05 Thread Mauro Carvalho Chehab
There's s no reason why it should be using GFP_DMA there. This is an USB driver. Any restriction should be, instead, at HCI core, if any. Cc: "Luis R. Rodriguez" Cc: linux...@kvack.org Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/dvb-usb/gp8psk.c | 2 +- 1

Are media drivers abusing of GFP_DMA? - was: Re: [LSF/MM TOPIC NOTES] x86 ZONE_DMA love

2018-05-05 Thread Mauro Carvalho Chehab
There was a recent discussion about the use/abuse of GFP_DMA flag when allocating memories at LSF/MM 2018 (see Luis notes enclosed). The idea seems to be to remove it, using CMA instead. Before doing that, better to check if what we have on media is are valid use cases for it, or if it is there ju

[PATCH] media: siano: don't use GFP_DMA

2018-05-05 Thread Mauro Carvalho Chehab
I can't think on a single reason why this driver would be using GFP_DMA. The typical usage is as an USB driver. Any DMA restrictions should be handled inside the HCI driver, if any. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/siano/smscoreapi.c | 20 ++

Re: [PATCH v3 0/8] R-Car DU: Support CRC calculation

2018-05-05 Thread Mauro Carvalho Chehab
Em Sat, 05 May 2018 17:06:50 +0300 Laurent Pinchart escreveu: > Hi Daniel, > > (CC'ing Mauro) > > On Thursday, 3 May 2018 16:45:36 EEST Daniel Vetter wrote: > > On Thu, May 3, 2018 at 2:06 PM, Laurent Pinchart wrote: > > > Hi Dave, > > > > > > Ping ? > > > > Not aware of any crc core work

Re: [RFC PATCH] media: i2c: add SCCB helpers

2018-05-05 Thread Mauro Carvalho Chehab
vers. > > With the sccb_read_byte() that issues two separated requests in order to > avoid repeated start, the driver doesn't require I2C_FUNC_PROTOCOL_MANGLING. > > Cc: Wolfram Sang > Cc: Jacopo Mondi > Cc: Laurent Pinchart > Cc: Hans Verkuil > Cc: Sakari Ail

Re: [PATCH 1/7] i2c: i2c-gpio: move header to platform_data

2018-05-05 Thread Mauro Carvalho Chehab
oard-gpr.c| 2 +- > drivers/i2c/busses/i2c-gpio.c| 2 +- > drivers/media/platform/marvell-ccic/mmp-driver.c | 2 +- Acked-by: Mauro Carvalho Chehab > drivers/mfd/sm501.c | 2 +- > include/linux/{ => platform_data}/i2c-gpio.h

[PATCH] media: pt1: use #ifdef CONFIG_PM_SLEEP instead of #if

2018-05-05 Thread Mauro Carvalho Chehab
As pointed by ktest: >> drivers/media//pci/pt1/pt1.c:1433:5: warning: "CONFIG_PM_SLEEP" is not >> defined, evaluates to 0 [-Wundef] #if CONFIG_PM_SLEEP ^~~ Reported-by: kbuild test robot Signed-off-by: Mauro Carvalho Chehab --- drivers/media/p

[PATCH] media: pt1: fix strncmp() size warning

2018-05-05 Thread Mauro Carvalho Chehab
As warned by smatch: drivers/media/pci/pt1/pt1.c:213 config_demod() error: strncmp() '"tc90522sat"' too small (11 vs 20) Use the same strncmp() syntax as pt1_init_frontends() does. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/pci/pt1/pt1.c | 3 ++

<    3   4   5   6   7   8   9   10   11   12   >