From: Márton Németh nm...@freemail.hu
The PO2030N sensor chip found in hama AC-150 webcam supports horizontal flipping
the image by hardware. Add support for this in the gspca_sonixj driver also.
Signed-off-by: Márton Németh nm...@freemail.hu
---
diff -upr c/drivers/media/video/gspca/sonixj.c
From: Márton Németh nm...@freemail.hu
The PO2030N sensor chip found in hama AC-150 webcam supports vertical flipping
the image by hardware. Add support for this in the gspca_sonixj driver also.
Signed-off-by: Márton Németh nm...@freemail.hu
---
diff -upr b/drivers/media/video/gspca/sonixj.c
From: Márton Németh nm...@freemail.hu
The number 0xdd is used for marking delay init sequence steps. Replace
0xdd values only if the meaning is delay.
Signed-off-by: Márton Németh nm...@freemail.hu
---
diff -upr a/drivers/media/video/gspca/sonixj.c
b/drivers/media/video/gspca/sonixj.c
---
Hi,
Marius Bjørnstad wrote:
A problem with the em28xx driver was brought up in June by Thorsten
Hirsch: http://www.spinics.net/lists/linux-media/msg20588.html . I also
have a TerraTec Cinergy Hybrid T USB XS. When I used my device with
Linux, it would take a long time to be recognised by the
From: Márton Németh nm...@freemail.hu
The usb_control_msg() may return error at any time so it is necessary to handle
it. The error handling mechanism is taken from the pac7302.
The resulting driver was tested with hama AC-150 webcam (USB ID 0c45:6142).
Signed-off-by: Márton Németh
Mauro Carvalho Chehab wrote:
== Gspca patches - Waiting Hans de Goede hdego...@redhat.com
review ==
Jan,29 2010: [gspca_jf,tree] gspca zc3xx: signal when unknown packet received
http://patchwork.kernel.org/patch/75837 Németh Márton
nm...@freemail.hu
This was
Hi,
Jean-Francois Moine írta:
On Sun, 17 Oct 2010 16:45:03 +0200
Németh Márton nm...@freemail.hu wrote:
The usb_control_msg() may return error at any time so it is necessary
to handle it. The error handling mechanism is taken from the pac7302.
The resulting driver was tested with hama AC
Hi Jean-Francois,
Jean-Francois Moine wrote:
On Sun, 17 Oct 2010 13:08:01 +0200
Németh Márton nm...@freemail.hu wrote:
The PO2030N sensor chip found in hama AC-150 webcam supports vertical
flipping the image by hardware. Add support for this in the
gspca_sonixj driver also.
[snip
Hi Lars,
Lars Noschinski wrote:
I'm using a webcam (Philipps SPC500NC) which identifies itself as
093a:2603 Pixart Imaging, Inc. PAC7312 Camera
and is sort-of supported by the gspca_pac7311 module. sort-of because
the image alternates quickly between having a red tint or a green tint
Lars Noschinski wrote:
* Németh Márton nm...@freemail.hu [11-10-18 22:14]:
Hi Lars,
Lars Noschinski wrote:
I'm using a webcam (Philipps SPC500NC) which identifies itself as
093a:2603 Pixart Imaging, Inc. PAC7312 Camera
and is sort-of supported by the gspca_pac7311 module. sort
Hi,
I'm running Debian with Linux 2.6.38-2-486 on a computer. I have a hama AC-150
webcam
attached to this computer. The webcam works continouosly and I use mencoder to
do some
cropping and transformation and to encode the video stream to a file.
When I plug the device the following appears in
Trent Piepho wrote:
On Sat, 25 Apr 2009, [UTF-8] Németh Márton wrote:
The VIDIOC_S_FMT is a write-read ioctl: it sets the format and returns
the current format in case of success. The parameter of VIDIOC_S_FMT
ioctl is a pointer to struct v4l2_format. [1] This structure contains some
fields
The V4L2 ioctls usually return 0 when the operation was successful
and -1 in case of error. Currently VIDIOC_REQBUFS returns the
number of buffers which is redundant because this information is
available in count field of struct v4l2_requestbuffers. The
V4L2 API specification, revision 0.24 [1]
The parameter of VIDIOC_REQBUFS is a pointer to struct v4l2_requestbuffers.
This structure has reserved fields which has to be filled with zeros
according to the V4L2 API specification, revision 0.24 [1].
The patch was tested with v4l-test 0.13 [2] with vivi driver.
References:
[1] V4L2 API
From: Trent Piepho xy...@speakeasy.org
Some ioctls have structs that are a different size depending on what type
of buffer is being used. If the buffer type leaves a field unused or has
padding space at the end, this space should be zeroed out. This patch modifies
the VIDIOC_S_FMT,
Laurent Pinchart worte:
Could a very large number of control requests be used as a DoS attack vector
?
A userspace application could kmalloc large amounts of memory without any
restriction. Memory would be reclaimed eventually, but after performing a
large number of USB requests, which
Mauro Carvalho Chehab wrote:
Em Wed, 10 Jun 2009 10:52:28 -0300
Mauro Carvalho Chehab mche...@infradead.org escreveu:
Em Mon, 25 May 2009 11:16:34 -0300
Mauro Carvalho Chehab mche...@infradead.org escreveu:
Em Mon, 25 May 2009 13:17:02 +0200
Laurent Pinchart laurent.pinch...@skynet.be
From: Márton Németh nm...@freemail.hu
The original implementation of pac_find_sof() does not always find
the Start Of Frame (SOF) marker. Replace it with a state machine
based design.
The change was tested with Labtec Webcam 2200.
Signed-off-by: Márton Németh nm...@freemail.hu
---
---
at offset 2
PASSED
Test case 12: no match, extra byte at offset 3
PASSED
Test case 13: no match, extra byte at offset 4
PASSED
I also executed the test with the patched pac_find_sof() implementation
and that one passes all these test cases.
Regards,
Márton Németh
Németh Márton wrote
Hi,
the following patchset refactores the Pixart PAC7311 subdriver. The
current situation is that the code contains a lot of decisions
like this:
if (sd-sensor == SENSOR_PAC7302) {
... do this ...
} else {
... do something else ...
}
The sensor type is determined
From: Márton Németh nm...@freemail.hu
There are some functions which are already sensor specific. Mark them
with pac7302_ or pac7311_ prefix
Signed-off-by: Márton Németh nm...@freemail.hu
Cc: Thomas Kaiser tho...@kaiser-linux.li
Cc: Theodore Kilgore kilg...@auburn.edu
Cc: Kyle Guinn
From: Márton Németh nm...@freemail.hu
Separate the pkt_scan function. Remove the run-time decision for
PAC7302 and PAC7311 sensors.
Signed-off-by: Márton Németh nm...@freemail.hu
Cc: Thomas Kaiser tho...@kaiser-linux.li
Cc: Theodore Kilgore kilg...@auburn.edu
Cc: Kyle Guinn ely...@gmail.com
---
From: Márton Németh nm...@freemail.hu
Separate the config function. Remove the run-time decision for
PAC7302 and PAC7311 sensors.
Signed-off-by: Márton Németh nm...@freemail.hu
Cc: Thomas Kaiser tho...@kaiser-linux.li
Cc: Theodore Kilgore kilg...@auburn.edu
Cc: Kyle Guinn ely...@gmail.com
---
From: Márton Németh nm...@freemail.hu
Separate the init function. Remove the run-time decision for
PAC7302 and PAC7311 sensors.
Signed-off-by: Márton Németh nm...@freemail.hu
Cc: Thomas Kaiser tho...@kaiser-linux.li
Cc: Theodore Kilgore kilg...@auburn.edu
Cc: Kyle Guinn ely...@gmail.com
---
diff
From: Márton Németh nm...@freemail.hu
Separate the start function. Remove the run-time decision for
PAC7302 and PAC7311 sensors.
Signed-off-by: Márton Németh nm...@freemail.hu
Cc: Thomas Kaiser tho...@kaiser-linux.li
Cc: Theodore Kilgore kilg...@auburn.edu
Cc: Kyle Guinn ely...@gmail.com
---
From: Márton Németh nm...@freemail.hu
Separate the stopN function. Remove the run-time decision for
PAC7302 and PAC7311 sensors.
Signed-off-by: Márton Németh nm...@freemail.hu
Cc: Thomas Kaiser tho...@kaiser-linux.li
Cc: Theodore Kilgore kilg...@auburn.edu
Cc: Kyle Guinn ely...@gmail.com
---
From: Márton Németh nm...@freemail.hu
Separate the stop0 function. Remove the run-time decision for
PAC7302 and PAC7311 sensors.
Signed-off-by: Márton Németh nm...@freemail.hu
Cc: Thomas Kaiser tho...@kaiser-linux.li
Cc: Theodore Kilgore kilg...@auburn.edu
Cc: Kyle Guinn ely...@gmail.com
---
From: Márton Németh nm...@freemail.hu
Separate the dq_callback function. Remove the run-time decision for
PAC7302 and PAC7311 sensors.
Signed-off-by: Márton Németh nm...@freemail.hu
Cc: Thomas Kaiser tho...@kaiser-linux.li
Cc: Theodore Kilgore kilg...@auburn.edu
Cc: Kyle Guinn ely...@gmail.com
From: Márton Németh nm...@freemail.hu
Separate the horizontal and vertical flip control. Remove the run-time
decision for PAC7302 and PAC7311 sensors.
Signed-off-by: Márton Németh nm...@freemail.hu
Cc: Thomas Kaiser tho...@kaiser-linux.li
Cc: Theodore Kilgore kilg...@auburn.edu
Cc: Kyle Guinn
From: Márton Németh nm...@freemail.hu
Separate the gain and autogain controls. Remove the run-time
decision for PAC7302 and PAC7311 sensors.
Signed-off-by: Márton Németh nm...@freemail.hu
Cc: Thomas Kaiser tho...@kaiser-linux.li
Cc: Theodore Kilgore kilg...@auburn.edu
Cc: Kyle Guinn
From: Márton Németh nm...@freemail.hu
Remove struct sd dependency from pac_find_sof() function implementation,
This step prepares separation of pac7302 and pac7311 specific parts of
struct sd.
Signed-off-by: Márton Németh nm...@freemail.hu
Cc: Thomas Kaiser tho...@kaiser-linux.li
Cc: Theodore
From: Márton Németh nm...@freemail.hu
Separate the exposure control. Remove the run-time
decision for PAC7302 and PAC7311 sensors.
Signed-off-by: Márton Németh nm...@freemail.hu
Cc: Thomas Kaiser tho...@kaiser-linux.li
Cc: Theodore Kilgore kilg...@auburn.edu
Cc: Kyle Guinn ely...@gmail.com
---
From: Márton Németh nm...@freemail.hu
Separate the private struct sd where the sensor specific data is stored.
The sensor field is no longer needed because we use separate functions.
Brightness and color fields are not used in pac7311, so removed.
Signed-off-by: Márton Németh nm...@freemail.hu
From: Márton Németh nm...@freemail.hu
The original implementation of reg_w_var contains direct references to pac7302
and 7311 specific structures. Move these references to the parameter list.
Signed-off-by: Márton Németh nm...@freemail.hu
Cc: Thomas Kaiser tho...@kaiser-linux.li
Cc: Theodore
From: Márton Németh nm...@freemail.hu
Creating the start of the frame is done in the same way for pac7302
and for pac7311. Extract this common part to the pac_start_frame()
function.
Signed-off-by: Márton Németh nm...@freemail.hu
Cc: Thomas Kaiser tho...@kaiser-linux.li
Cc: Theodore Kilgore
From: Márton Németh nm...@freemail.hu
The pac7302_ and pac7311_ prefixes are no longer needed as these
functions are in separated files. The sensor information can also
be removed from the USB tables.
Signed-off-by: Márton Németh nm...@freemail.hu
Cc: Thomas Kaiser tho...@kaiser-linux.li
Cc:
From: Márton Németh nm...@freemail.hu
The pac7302_ and pac7311_ prefixes are no longer needed as these
functions are in separated files. The sensor information can also
be removed from the USB tables.
Signed-off-by: Márton Németh nm...@freemail.hu
Cc: Thomas Kaiser tho...@kaiser-linux.li
Cc:
Jean-Francois Moine wrote:
On Sun, 01 Nov 2009 00:13:10 +0100
Németh Márton nm...@freemail.hu wrote:
the following patchset refactores the Pixart PAC7311 subdriver. The
current situation is that the code contains a lot of decisions
like this:
if (sd-sensor == SENSOR_PAC7302
From: Márton Németh nm...@freemail.hu
Remove struct sd dependency from pac_find_sof() function implementation.
This step prepares separation of pac7302 and pac7311 specific parts of
struct sd.
Signed-off-by: Márton Németh nm...@freemail.hu
Cc: Thomas Kaiser tho...@kaiser-linux.li
Cc: Theodore
From: Márton Németh nm...@freemail.hu
Creating the start of the frame is done in the same way for pac7302
and for pac7311. Extract this common part to the pac_start_frame()
function.
Signed-off-by: Márton Németh nm...@freemail.hu
Cc: Thomas Kaiser tho...@kaiser-linux.li
Cc: Theodore Kilgore
From: Márton Németh nm...@freemail.hu
All PAC7311 specific functions remain in pac7311.c. All PAC7302 specific
functions are moved to pac7302.c. The USB device table is also divided into
two parts. This makes it possible to remove the sensor specific decisions
from different functions and also
Theodore Kilgore wrote:
On Sun, 1 Nov 2009, Németh Márton wrote:
Remove struct sd dependency from pac_find_sof() function implementation.
This step prepares separation of pac7302 and pac7311 specific parts of
struct sd.
[...]
But here is the point. The sn9c2028 cameras have a structure
Theodore Kilgore írta:
On Mon, 2 Nov 2009, Németh Márton wrote:
Theodore Kilgore wrote:
On Sun, 1 Nov 2009, Németh Márton wrote:
Remove struct sd dependency from pac_find_sof() function implementation.
This step prepares separation of pac7302 and pac7311 specific parts of
struct sd
From: Márton Németh nm...@freemail.hu
Webcams may return -1 and errno=EINVAL when there is no standard which
they support. Handle this case in pixfmt-test.
Signed-off-by: Márton Németh nm...@freemail.hu
---
diff -r 43878f8dbfb0 v4l2-apps/test/pixfmt-test.c
--- a/v4l2-apps/test/pixfmt-test.c
Is the separated driver working for you?
Do you have any idea what could went wrong? Maybe some timing problem?
Regards,
Márton Németh
Németh Márton wrote:
From: Márton Németh nm...@freemail.hu
All PAC7311 specific functions remain in pac7311.c. All PAC7302 specific
functions are moved
From: Márton Németh nm...@freemail.hu
The function usb_control_msg() can return error any time so at least
warn the user if an error happens. No message is printed in case of
normal operation.
Signed-off-by: Márton Németh nm...@freemail.hu
---
diff -r e628f4381170
From: Márton Németh nm...@freemail.hu
The stream off command is sent to the device twice, one is enough.
The patch was tested together with Labtec Webcam 2200 (USB ID 093a:2626).
Signed-off-by: Márton Németh nm...@freemail.hu
---
diff -r 40705fec2fb2 linux/drivers/media/video/gspca/pac7302.c
From: Márton Németh nm...@freemail.hu
The usb_control_msg() can fail any time. Only continue writing
sequence if there was no error with the previous write. If there
was any problem stop sending URBs and propagate the error to the
gspca_main.
Only the pac7302 driver was tested with Labtec Webcam
From: Márton Németh nm...@freemail.hu
The init sequence contains register writes which are overwritten later.
Remove these redundant writes from the init sequence.
The patch was tested together with Labtec Webcam 2200 (USB ID 093a:2626).
Signed-off-by: Márton Németh nm...@freemail.hu
---
diff
Hi Jef,
Jean-Francois Moine wrote:
On Sat, 07 Nov 2009 10:41:19 +0100
Németh Márton nm...@freemail.hu wrote:
The init sequence contains register writes which are overwritten
later. Remove these redundant writes from the init sequence.
[snip]
Hello Németh,
I am not sure
From: Márton Németh nm...@freemail.hu
Add the red and blue balance control to the pac7302 driver. The valid
values for these controls are 0..3 which was identified by trial and error
on Labtec Webcam 2200 (USB ID 093a:2626). The upper 5 bits are ignored
on page 0, registers 0xc5 and 0xc7 by the
Németh Márton wrote:
Add the red and blue balance control to the pac7302 driver. The valid
values for these controls are 0..3 which was identified by trial and error
on Labtec Webcam 2200 (USB ID 093a:2626). The upper 5 bits are ignored
The upper 6 bits, I mean. The lower two bits are only
From: Márton Németh nm...@freemail.hu
Add the red and blue balance control to the pac7302 driver. The valid
values for these controls are 0..3 (lower two bits) which was identified
by trial and error on Labtec Webcam 2200 (USB ID 093a:2626). The upper
6 bits are ignored on page 0, registers 0xc5
From: Márton Németh nm...@freemail.hu
Add white balance control to pac7302 driver. All 8 bits seems to be
relevant on Labtec Webcam 2200 (USB ID 093a:2626). The control is
at page 0, register 0xc6.
Signed-off-by: Márton Németh nm...@freemail.hu
---
diff -upr
From: Márton Németh nm...@freemail.hu
The Labtec Webcam 2200 (USB ID 093a:2626) device can produce some
diagnostic patterns instead of the sensor image. An overlay test
pattern also exsits which can be combined with the sensor image or
with any test patterns. Add controls to activate these test
Hi,
Hans de Goede wrote:
[snip]
About the usb control msg errors, I don't think they are related to this
issue at all, no real
world app ever does a streamon and an mmap at the same time. As said if we
could serialize mmap and
ioctl at a high enough level, things would be fine too.
I
From: Márton Németh nm...@freemail.hu
The usb_control_msg() can fail any time. Only continue writing
sequence if there was no error with the previous write. If there
was any problem stop sending URBs and propagate the error to the
gspca_main.
Only the pac7302 driver was tested with Labtec Webcam
From: Márton Németh nm...@freemail.hu
Add debug register write interface to pac7302 to be able to set
for example the edge detect mode (bit 2 register 0x55) or the
test pattern (bit 0..3, register 0x72) and test overlay (bit 4,
register 0x72) from the user space. Only write of register
page 0 is
From: Márton Németh nm...@freemail.hu
Report the fail reason to the user when writing a register even if
the verbose mode is switched off.
Remove duplicated code ioctl() call which may cause different ioctl()
function call in case of verbose and non verbose if not handled carefully.
Hi,
I have some problem that libv4l cannot decode all image coming from the
Labtec Webcam 2200. There are some cases when no image at all can be decoded.
This case can be reproduced always for example by setting the camera to test
mode to produce a color test bar. The raw data arrives from the
From: Márton Németh nm...@freemail.hu
It is no use to continue sending URBs if one of them already
failed.
Signed-off-by: Márton Németh nm...@freemail.hu
---
The patch is based on 13335:3fd924da7091 from
http://linuxtv.org/hg/~jfrancois/gspca/ .
---
diff -r 3fd924da7091
From: Márton Németh nm...@freemail.hu
Add debug register write interface to pac7302 to be able to set
for example the edge detect mode (bit 2 register 0x55) or the
test pattern (bit 0..3, register 0x72) and test overlay (bit 4,
register 0x72) from the user space. Only write of register
page 0 is
Hans Verkuil wrote:
On Sunday 08 November 2009 13:32:50 Németh Márton wrote:
From: Márton Németh nm...@freemail.hu
Report the fail reason to the user when writing a register even if
the verbose mode is switched off.
Remove duplicated code ioctl() call which may cause different ioctl
From: Márton Németh nm...@freemail.hu
The include path is changed from ../lib to ../lib4vl2util .
Signed-off-by: Márton Németh nm...@freemail.hu
---
diff -r 60f784aa071d v4l2-apps/util/decode_tm6000.c
--- a/v4l2-apps/util/decode_tm6000.cWed Nov 11 18:28:53 2009 +0100
+++
Hans Verkuil wrote:
On Thursday 12 November 2009 07:52:51 Németh Márton wrote:
From: Márton Németh nm...@freemail.hu
The include path is changed from ../lib to ../lib4vl2util .
Signed-off-by: Márton Németh nm...@freemail.hu
---
diff -r 60f784aa071d v4l2-apps/util/decode_tm6000.c
From: Márton Németh nm...@freemail.hu
Report the fail reason to the user when writing a register even if
the verbose mode is switched off.
Remove duplicated code ioctl() call which may cause different ioctl()
function call in case of verbose and non verbose if not handled carefully.
From: Márton Németh nm...@freemail.hu
Report the fail reason to the user when writing a register even if
the verbose mode is switched off.
Remove duplicated code ioctl() call which may cause different ioctl()
function call in case of verbose and non verbose if not handled carefully.
From: Márton Németh nm...@freemail.hu
Add support for snapshot button found on Labtec Webcam 2200.
Signed-off-by: Márton Németh nm...@freemail.hu
---
Hi,
this is the first trial to add support for the snapshot button. This
code is working only before the streaming is started. When the streaming
in order
the common points can be identified for interrupt endpoints?
Regards,
Márton Németh
On 11/15/2009 09:47 AM, Németh Márton wrote:
From: Márton Némethnm...@freemail.hu
Add support for snapshot button found on Labtec Webcam 2200.
Signed-off-by: Márton Némethnm...@freemail.hu
---
Hi
From: Márton Németh nm...@fremail.hu
Add check for the mandatory config, init, start and pkt_scan
gspca subdriver operations.
Signed-off-by: Márton Németh nm...@fremail.hu
---
diff -r 182b5f8fa160 linux/drivers/media/video/gspca/gspca.c
--- a/linux/drivers/media/video/gspca/gspca.c Sun Nov 15
From: Márton Németh nm...@freemail.hu
Add helper functions for interrupt endpoint based input handling.
Signed-off-by: Márton Németh nm...@freemail.hu
---
Hi,
maybe a new configuration option should be also introduced?
Regards,
Márton Németh
---
diff -r 182b5f8fa160
From: Márton Németh nm...@freemail.hu
Add support for snapshot button found on Labtec Webcam 2200.
Signed-off-by: Márton Németh nm...@freemail.hu
---
diff -r 182b5f8fa160 linux/drivers/media/video/gspca/pac7302.c
--- a/linux/drivers/media/video/gspca/pac7302.c Sun Nov 15 10:05:30 2009 +0100
+++
Hi,
Hans de Goede wrote:
Hi Márton,
On 11/19/2009 08:46 AM, Németh Márton wrote:
Add helper functions for interrupt endpoint based input handling.
First of all many many thanks for doing this!
You are welcome :-) . My goal is to just make my webcam working properly...
maybe a new
From: Márton Németh nm...@freemail.hu
Add support for snapshot button found on Labtec Webcam 2200.
Signed-off-by: Márton Németh nm...@freemail.hu
---
diff -r abfdd03b800d linux/drivers/media/video/gspca/pac7302.c
--- a/linux/drivers/media/video/gspca/pac7302.c Thu Nov 19 10:34:21 2009 +0100
+++
Hi,
first of all: Hans and Jef, thank you for your helping guidance with
this patchset.
Jean-Francois Moine wrote:
Hi,
On Fri, 20 Nov 2009 08:14:10 +0100
Németh Márton nm...@freemail.hu wrote:
Hans de Goede wrote:
[snip]
I'm personally not a big fan of adding more configuration
From: Márton Németh nm...@freemail.hu
Add support for snapshot button found on Labtec Webcam 2200.
Signed-off-by: Márton Németh nm...@freemail.hu
---
diff -r abfdd03b800d linux/drivers/media/video/gspca/pac7302.c
--- a/linux/drivers/media/video/gspca/pac7302.c Thu Nov 19 10:34:21 2009 +0100
+++
From: Márton Németh nm...@freemail.hu
Use strlcat() to append a string to the previously created first part.
The semantic match that finds this kind of problem is as follows:
(http://coccinelle.lip6.fr/)
// smpl
@@
expression dev;
expression phys;
expression str;
expression size;
@@
From: Márton Németh nm...@freemail.hu
Use strlcat() to append a string to the previously created first part.
The strlcat() function limits the size of the string to the whole
destination buffer.
The semantic match that finds this kind of problem is as follows:
(http://coccinelle.lip6.fr/)
//
From: Márton Németh nm...@freemial.hu
The function usb_control_msg() can fail any time. Propagate the error to
higher level software. Do not continue sending URBs after the first error.
The change was tested with Trust 610 LCD pow...@m Zoom in webcam mode
(USB ID 06d6:0031).
Signed-off-by:
Németh Márton wrote:
Jean-Francois Moine wrote:
On Fri, 20 Nov 2009 08:14:10 +0100
Németh Márton nm...@freemail.hu wrote:
Unfortunately I still get the following error when I start streaming,
stop streaming or unplug the device:
[ 6876.780726] uhci_hcd :00:10.1: dma_pool_free buffer-32
From: Márton Németh nm...@freemail.hu
Add helper functions for interrupt endpoint based input handling.
Signed-off-by: Márton Németh nm...@freemail.hu
---
diff -r bc16afd1e7a4 linux/drivers/media/video/gspca/Makefile
--- a/linux/drivers/media/video/gspca/Makefile Sat Nov 21 12:01:36 2009 +0100
From: Márton Németh nm...@freemail.hu
Add support for snapshot button found on Labtec Webcam 2200
(USB ID 093a:2626).
Signed-off-by: Márton Németh nm...@freemail.hu
---
diff -r bc16afd1e7a4 linux/drivers/media/video/gspca/pac7302.c
--- a/linux/drivers/media/video/gspca/pac7302.c Sat Nov 21
Hans Verkuil worte:
linux-2.6.22.19-armv5: WARNINGS
/marune/build/v4l-dvb-master/v4l/videobuf-core.c: In function
'videobuf_reqbufs':
/marune/build/v4l-dvb-master/v4l/videobuf-core.c:434: warning: format '%d'
expects type 'int', but argument 4 has type 'long unsigned int'
I think this can be
From: Márton Németh nm...@freemail.hu
The return value may be used uninitialized when the size parameter
happens to be 0.
Signed-off-by: Márton Németh nm...@freemail.hu
---
diff -r bc16afd1e7a4 linux/drivers/media/dvb/siano/smssdio.c
--- a/linux/drivers/media/dvb/siano/smssdio.c Sat Nov 21
From: Márton Németh nm...@freemail.hu
Merge two ifs: the condition is the same. The second if
uses the ncoeff which is initialized in the first if.
Signed-off-by: Márton Németh nm...@freemail.hu
---
diff -r bc16afd1e7a4 linux/drivers/media/dvb/frontends/dib8000.c
---
Hi,
Gustavo Chaín Dumit wrote:
Hi
I'm testing a Pixart Imaging device (0x93a:0x2622)
Everything works fine, but vertical orientation. Image looks rotated.
So I wrote a little hack to prevent it.
[...]
Any one has the same problem ?
You might want to have a look to libv4l (
Hello Mauro,
Patch from Mauro Carvalho Chehab wrote:
The patch number 13472 was added via Mauro Carvalho Chehab
mche...@redhat.com
to http://linuxtv.org/hg/v4l-dvb master development tree.
Kernel patches in this development tree may be modified to be backward
compatible with older kernels.
From: Márton Németh nm...@freemail.hu
Eliminate redundant code by reorganizing the loop.
Signed-off-by: Márton Németh nm...@freemail.hu
---
diff -r 064a82aa2daa linux/drivers/media/video/gspca/gspca.c
--- a/linux/drivers/media/video/gspca/gspca.c Thu Nov 26 19:36:40 2009 +0100
+++
From: Márton Németh nm...@freemail.hu
Calling gspca_set_alt0() in gspca_dev_probe() is not needed as gspca_set_alt0()
will do nothing because gspca_dev-alt is always zero at that time.
Signed-off-by: Márton Németh nm...@freemail.hu
---
diff -r 064a82aa2daa linux/drivers/media/video/gspca/gspca.c
Jean-Francois Moine wrote:
On Sat, 28 Nov 2009 08:13:05 +0100
Németh Márton nm...@freemail.hu wrote:
what do you think about this patch?
Hi Márton,
There are many other drivers where the usb_control_msg() errors are not
tested nor propagated to higher levels. Generally, this does
Hans Verkuil wrote:
This message is generated daily by a cron job that builds v4l-dvb for
the kernels and architectures in the list below.
Results of the daily build of v4l-dvb:
date:Tue Dec 1 19:00:02 CET 2009
path:http://www.linuxtv.org/hg/v4l-dvb
changeset:
From: Márton Németh nm...@freemail.hu
The device_table structure is used as a constant. The driver_info field
is only copied to the struct sd so it is also not modified.
Signed-off-by: Márton Németh nm...@freemail.hu
---
diff -r e16961fe157d linux/drivers/media/video/gspca/conex.c
---
Laurent Pinchart wrote:
Hi Mauro,
On Wednesday 10 June 2009 23:58:31 Laurent Pinchart wrote:
On Wednesday 10 June 2009 15:53:57 Mauro Carvalho Chehab wrote:
Em Wed, 10 Jun 2009 10:52:28 -0300
Mauro Carvalho Chehab mche...@infradead.org escreveu:
Em Mon, 25 May 2009 11:16:34 -0300
Mauro
From: Márton Németh nm...@freemail.hu
Eliminate the following sparse warnings (see make C=1):
* dib8000.c:125:15: warning: symbol 'coeff_2k_sb_1seg_dqpsk' was not declared.
Should it be static?
* dib8000.c:130:15: warning: symbol 'coeff_2k_sb_1seg' was not declared.
Should it be static?
*
From: Márton Németh nm...@freemail.hu
Make module_init static and mark it with __init.
Make module_exit static and mark it with __exit.
Mark probe functions with __devinit.
Make id table static and mark with __devinitconst.
This will eliminate the following sparse warnings (see make C=1):
*
From: Márton Németh nm...@freemail.hu
The gpio field in the cx231xx_board.input structure is a pointer. Eliminate the
following sparse warnings (see make C=1):
* cx231xx-cards.c:72:13: warning: Using plain integer as NULL pointer
* cx231xx-cards.c:77:13: warning: Using plain integer as NULL
From: Márton Németh nm...@freemail.hu
Make the local filter coefficients static and const. This will eliminate the
following sparse warnings (see make C=1):
* au8522_decoder.c:71:31: warning: symbol 'filter_coef' was not declared.
Should it be static?
* au8522_decoder.c:113:31: warning: symbol
Hans Verkuil wrote:
Detailed results are available here:
http://www.xs4all.nl/~hverkuil/logs/Sunday.log
linux-2.6.24.7-i686: ERRORS
/marune/build/v4l-dvb-master/v4l/conex.c:1049: error: expected '=', ',',
';', 'asm' or '__attribute__' before '__devinitconst'
From: Márton Németh nm...@freemail.hu
Make one-bit bitfields unsigned which will remove the following
sparse warning messages (see make C=1):
* lgdt3305.h:57:21: error: dubious one-bit signed bitfield
* lgdt3305.h:60:26: error: dubious one-bit signed bitfield
* lgdt3305.h:63:19: error: dubious
Hans Verkuil wrote:
Detailed results are available here:
http://www.xs4all.nl/~hverkuil/logs/Tuesday.log
linux-2.6.33-rc2-armv5: ERRORS
In file included from command-line:0:
/marune/build/v4l-dvb-master/v4l/config-compat.h:4:28: error: linux/autoconf.h:
No such file or directory
In file
1 - 100 of 226 matches
Mail list logo
