Hi Hans,
thank you for your comments as always.
Hans Verkuil wrote hverk...@xs4all.nl:
Hi Pawel,
Looks good, but I have a few small suggestions:
On Friday 09 July 2010 20:59:45 Pawel Osciak wrote:
(snip)
struct v4l2_format {
enum v4l2_buf_type type;
union
be able to call the
kernel-only ioctl.
So a driver has to be careful not to expose a node to the userspace if
it has kernel-callable subdev ioctls.
As long as drivers obey that rule and we do not require both types of
ioctls in one subdev, there is no problem.
Best regards
--
Pawel Osciak
Linux
want to lose the ability to use multiplanar API for single-plane
formats?
Best regards
--
Pawel Osciak
Linux Platform Group
Samsung Poland RD Center
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info
regards,
--
Pawel Osciak
Linux Platform Group
Samsung Poland RD Center
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
100644 drivers/media/video/s5p-fimc/fimc-core.h
create mode 100644 drivers/media/video/s5p-fimc/fimc-reg.c
Best regards
--
Pawel Osciak
Linux Platform Group
Samsung Poland RD Center
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord
://www.spinics.net/lists/linux-media/msg14063.html
http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/10668
Best regards
--
Pawel Osciak
Linux Platform Group
Samsung Poland RD Center
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message
, together with video
data.
Signed-off-by: Pawel Osciak p.osc...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Reviewed-by: Marek Szyprowski m.szyprow...@samsung.com
---
drivers/media/video/v4l2-ioctl.c |2 +
include/linux/videodev2.h| 126
to mapped (V4L2_BUF_FLAG_MAPPED flag) only after all
of its planes have been mmapped successfully.
Best regards
--
Pawel Osciak
Linux Platform Group
Samsung Poland RD Center
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
Add multi-planar ioctl handling to the 32bit compatibility layer.
Signed-off-by: Pawel Osciak p.osc...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/media/video/v4l2-compat-ioctl32.c | 221 +
1 files changed, 190 insertions(+), 31
Add multi-planar API core ioctl handling and conversion functions.
Signed-off-by: Pawel Osciak p.osc...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Reviewed-by: Marek Szyprowski m.szyprow...@samsung.com
---
drivers/media/video/v4l2-ioctl.c | 418
and back.
The reason behind this conversion layer is to ease driver development.
Drivers won't have to implement both vidioc_*_fmt_* and
vidioc_*_fmt_*_mplane versions of calls, only mplane ones.
Best regards
--
Pawel Osciak
Linux Platform Group
Samsung Poland RD Center
--
To unsubscribe from
Hi Hans,
thank you for the review.
Hans Verkuil hverk...@xs4all.nl wrote:
On Friday 30 July 2010 10:49:41 Pawel Osciak wrote:
snip
@@ -157,9 +158,23 @@ enum v4l2_buf_type {
/* Experimental */
V4L2_BUF_TYPE_VIDEO_OUTPUT_OVERLAY = 8,
#endif
+V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE
Hi,
Hans Verkuil hverk...@xs4all.nl wrote:
On Friday 30 July 2010 10:49:42 Pawel Osciak wrote:
snip
static long __video_do_ioctl(struct file *file,
unsigned int cmd, void *arg)
{
struct video_device *vfd = video_devdata(file);
const struct v4l2_ioctl_ops *ops = vfd
Russell King - ARM Linux li...@arm.linux.org.uk wrote:
On Mon, Aug 02, 2010 at 12:32:20PM +0200, Pawel Osciak wrote:
Well, some of them are indeed unused, but it's not an uncommon practice in
kernel and might help future developers.
On the other hand, arch/arm is getting soo big that we need
definitions to the V4L2 API
[PATCH v6 2/3] v4l: Add multi-planar ioctl handling code
[PATCH v6 3/3] v4l: Add compat functions for the multi-planar API
Best regards
--
Pawel Osciak
Linux Platform Group
Samsung Poland RD Center
--
To unsubscribe from this list: send the line unsubscribe linux-media
Add multi-planar ioctl handling to the 32bit compatibility layer.
Signed-off-by: Pawel Osciak p.osc...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/media/video/v4l2-compat-ioctl32.c | 221 +
1 files changed, 190 insertions(+), 31
Add multi-planar API core ioctl handling and conversion functions.
Signed-off-by: Pawel Osciak p.osc...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Reviewed-by: Marek Szyprowski m.szyprow...@samsung.com
---
drivers/media/video/v4l2-ioctl.c | 418
100644 drivers/media/video/s5p-fimc/fimc-core.h
create mode 100644 drivers/media/video/s5p-fimc/fimc-reg.c
create mode 100644 drivers/media/video/s5p-fimc/regs-fimc.h
Best regards
--
Pawel Osciak
Linux Platform Group
Samsung Poland RD Center
--
To unsubscribe from this list: send the line
Richard Röjfors richard.rojf...@pelagicore.com wrote:
On 08/04/2010 11:50 AM, Pawel Osciak wrote:
How do you propose to allocate the buffers? They need to be contiguous
and using uncached memory gave really bad performance.
829440 bytes is a quite a lot and one can't reliably depend
Signed-off-by: Pawel Osciak p.osc...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/media/video/s5p-fimc/fimc-core.c | 36 +
drivers/media/video/s5p-fimc/fimc-core.h | 30 +++--
2 files changed, 44 insertions
about videobuf. If you think it
needs any changes/corrections, please let me know.
http://www.linuxplumbersconf.org/2010/ocw/proposals/915
--
Best regards,
Pawel Osciak
Linux Platform Group
Samsung Poland RD Center
--
To unsubscribe from this list: send the line unsubscribe linux-media
v4l/multiplane-api
Pawel Osciak (4):
v4l: Add multi-planar API definitions to the V4L2 API
v4l: Add multi-planar ioctl handling code
v4l: Add compat functions for the multi-planar API
v4l: fix copy sizes in compat32 for ext controls
drivers/media/video/v4l2-compat-ioctl32
to impossible to have a contiguous
allocator merged.
Your help and support would be very much appreciated. Working in
embedded Linux for some time now, I feel that the need is definitely
there and is quite substantial.
--
Best regards,
Pawel Osciak
Linux Platform Group
Samsung Poland RD Center
into it, as should be any other allocator for
that matter.
--
Best regards,
Pawel Osciak
Linux Platform Group
Samsung Poland RD Center
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
Port memory-to-memory framework to videobuf2 framework.
Signed-off-by: Pawel Osciak p.osc...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/media/video/Kconfig|3 +-
drivers/media/video/v4l2-mem2mem.c | 185
Add an implementation of DMA coherent memory allocator and handling
routines for videobuf2, implemented on top of dma_alloc_coherent() call.
Signed-off-by: Pawel Osciak p.osc...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/media/video/Kconfig
Add an implementation of contiguous virtual memory allocator and handling
routines for videobuf2, implemented on top of vmalloc()/vfree() calls.
Signed-off-by: Pawel Osciak p.osc...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/media/video/Kconfig
:
- Laurent Pinchart videobuf - the good, the bad and the ugly
http://linuxtv.org/downloads/presentations/summit_jun_2010/20100614-v4l2_summit-videobuf.pdf
- Pawel Osciak Future of the videobuf framework
http://linuxtv.org/downloads/presentations/summit_jun_2010/Videobuf_Helsinki_June2010.pdf
Add support for the CMA contiguous memory allocator to videobuf2.
Signed-off-by: Pawel Osciak p.osc...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/media/video/Kconfig |5 +
drivers/media/video/Makefile|2 +
drivers/media/video/videobuf2
the
high-level buffer management functions and API.
The framework provides:
- implementations of streaming I/O V4L2 ioctls and file operations
- high-level video buffer, video queue and state management functions
- video buffer memory allocation and management
Signed-off-by: Pawel Osciak p.osc
Make vivi use videobuf2 in place of videobuf.
Signed-off-by: Pawel Osciak p.osc...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/media/video/Kconfig |2 +-
drivers/media/video/vivi.c | 248 +--
2 files changed, 124
Add generic memory handling routines for userspace pointer handling,
contiguous memory verification and mapping.
Signed-off-by: Pawel Osciak p.osc...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/media/video/Kconfig|3 +
drivers/media/video
On 09/09/2010 06:19 PM, Pawel Osciak wrote:
Hello,
These patches add a new driver framework for Video for Linux 2 driver
- Videobuf2.
Sorry, I failed to mention that these patches depend on the multi-planar
API extensions, but do not require multi-planar support in drivers and
in vivi
Hello Mauro,
On 09/10/2010 02:53 AM, Mauro Carvalho Chehab wrote:
Em 09-09-2010 06:19, Pawel Osciak escreveu:
Hello,
These patches add a new driver framework for Video for Linux 2 driver
- Videobuf2.
I didn't test the patches, but, from a source code review, they seem
on a good shape. I
-2.6-samsung
v4l/fixes_for_v2.6.36
Pawel Osciak (2):
v4l: mem2mem_testdev: fix errorenous comparison
v4l: mem2mem_testdev: add missing release for video_device
drivers/media/video/mem2mem_testdev.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
--
Best regards,
Pawel
Hello Mauro,
Thank you for the review. Please see my responses inline.
Please also note that my e-mail address has changed.
On 09/09/2010 07:29 PM, Mauro Carvalho Chehab wrote:
Em 09-09-2010 06:19, Pawel Osciak escreveu:
Videobuf2 is a Video for Linux 2 API-compatible driver framework
not always call
VIDIOC_REQBUFS(0) after finishing. If an application just closes
the file descriptor (or even dies), we need a way to clean up the
memory.
--
Best regards,
Pawel Osciak
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord
Hi Hans,
Big thanks for the review!
On 09/25/2010 07:27 AM, Hans Verkuil wrote:
Hi Pawel,
I finally had some time for a code review:
On Thursday, September 09, 2010 11:19:42 Pawel Osciak wrote:
Videobuf2 is a Video for Linux 2 API-compatible driver framework for
multimedia devices
to clean the list.
== Videobuf2 series ==
Oct,20 2010: [7/7] v4l: videobuf2: add CMA allocator
http://patchwork.kernel.org/patch/267521 Pawel Osciak
p.osc...@samsung.com
Oct,20 2010: [2/7] v4l: videobuf2: add generic memory handling routines
On Fri, Oct 22, 2010 at 17:18, Mauro Carvalho Chehab mche...@redhat.com wrote:
Em 06-09-2010 03:53, Marek Szyprowski escreveu:
From: Pawel Osciak p.osc...@samsung.com
VIDIOC_STREAMON should return EBUSY if streaming is already active.
Signed-off-by: Pawel Osciak p.osc...@samsung.com
Signed
of buffers
used by emulator and detemines the style of read() emulation
('streaming' or 'one shot').
Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
CC: Pawel Osciak pa...@osciak.com
---
drivers/media/video/videobuf2-core.c | 322
Hi Marek,
Thanks for your patches, I went through your changes. Minor comments below.
On Tue, Oct 19, 2010 at 23:41, Marek Szyprowski
m.szyprow...@samsung.com wrote:
From: Pawel Osciak p.osc...@samsung.com
+/**
+ * __vb2_queue_cancel() - cancel and stop (pause) streaming
+ *
+ * Removes all
for driver's buffer queue.
--
Best regards,
Pawel Osciak
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Hans,
On Thu, Nov 18, 2010 at 01:17, Hans Verkuil hverk...@xs4all.nl wrote:
Hi Marek!
Some comments below...
On Wednesday, November 17, 2010 09:39:28 Marek Szyprowski wrote:
From: Pawel Osciak p.osc...@samsung.com
+/**
+ * struct vb2_mem_ops - memory handling/memory allocator
:
From: Pawel Osciak p.osc...@samsung.com
Videobuf2 is a Video for Linux 2 API-compatible driver framework for
[snip]
+/**
+ * __vb2_queue_alloc() - allocate videobuf buffer structures and (for MMAP
type) + * video buffer memory for all buffers/planes on the queue and
initializes
Hi,
On Thu, Nov 25, 2010 at 03:23, Hans Verkuil hverk...@xs4all.nl wrote:
On Thursday, November 25, 2010 10:48:39 Marek Szyprowski wrote:
Hello,
On Thursday, November 25, 2010 2:17 AM Laurent Pinchart wrote:
On Friday 19 November 2010 16:55:38 Marek Szyprowski wrote:
From: Pawel Osciak
,
On Wednesday, December 01, 2010 9:36 AM Jonghun Han wrote:
Marek Szyprowski wrote:
2010/11/20 Marek Szyprowski m.szyprow...@samsung.com:
From: Pawel Osciak p.osc...@samsung.com
Add support for the CMA contiguous memory allocator to videobuf2.
Signed-off-by: Pawel Osciak p.osc...@samsung.com
Hi all,
I would side with Laurent on this. Judging by formats seems to be
enough for this driver and it has great, in my opinion, advantages of
a) not overcomplicating things for applications b) not adding new
pieces to the API...
--
Best regards,
Pawel Osciak
--
To unsubscribe from this list
From: Pawel Osciak p.osc...@samsung.com
Add multi-planar API core ioctl handling and conversion functions.
Signed-off-by: Pawel Osciak p.osc...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Reviewed-by: Marek Szyprowski m.szyprow...@samsung.com
---
drivers/media/video/v4l2
On Wed, Dec 22, 2010 at 12:38, Hans Verkuil hverk...@xs4all.nl wrote:
On Wednesday, December 22, 2010 18:10:26 Pawel Osciak wrote:
From: Pawel Osciak p.osc...@samsung.com
Add multi-planar API core ioctl handling and conversion functions.
Signed-off-by: Pawel Osciak p.osc...@samsung.com
, buf_sizes,
plane_sizes, alloc_ctxs);
}
If the driver didn't want create_bufs, it'd just not implement it.
What do you think?
--
Best regards,
Pawel Osciak
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo
Marek?
--
Best regards,
Pawel Osciak
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi
On Wed, Aug 17, 2011 at 02:11, Guennadi Liakhovetski
g.liakhovet...@gmx.de wrote:
On Tue, 16 Aug 2011, Pawel Osciak wrote:
Hi Guennadi,
On Tue, Aug 16, 2011 at 06:13, Guennadi Liakhovetski
g.liakhovet...@gmx.de wrote:
On Mon, 15 Aug 2011, Guennadi Liakhovetski wrote:
On Mon, 15 Aug
later.
--
Best regards,
Pawel Osciak
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
m.szyprow...@samsung.com
Cc: Mauro Carvalho Chehab mche...@infradead.org
Cc: Pawel Osciak pa...@osciak.com
Cc: Sakari Ailus sakari.ai...@maxwell.research.nokia.com
---
drivers/media/video/videobuf2-core.c | 278
--
include/media/videobuf2-core.h
,
Pawel Osciak
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
.
(...)
== Waiting for Pawel Osiak pa...@osciak.com review ==
Jul,12 2011: v4l: mem2mem: add wait_{prepare,finish} ops to m2m_testdev
http://patchwork.linuxtv.org/patch/7431 Michael Olbrich
m.olbr...@pengutronix.de
This is an ack from me.
--
Best regards,
Pawel Osciak
.
Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
CC: Pawel Osciak pa...@osciak.com
---
drivers/media/video/videobuf2-core.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/video
;
+ ret = -EINVAL;
goto err;
}
--
1.7.1.569.g6f426
Acked-by: Pawel Osciak pa...@osciak.com
--
Best regards,
Pawel Osciak
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
/videobuf2-core.c
+++ b/drivers/media/video/videobuf2-core.c
@@ -254,6 +254,7 @@ static void __vb2_queue_free(struct vb2_queue *q)
q-num_buffers = 0;
q-memory = 0;
+ INIT_LIST_HEAD(q-queued_list);
}
/**
--
1.7.1
Acked-by: Pawel Osciak pa...@osciak.com
--
Best
,
neither of those can be active for reqbufs to proceed.
--
Best regards,
Pawel Osciak
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi,
Thanks for reporting the bug, and thanks to Sylwester for a quick
response, that should fix it.
I intend to change my e-mail address in one larger batch during the
merge window, if vb2 patches are taken in.
Best regards,
Pawel Osciak
--
To unsubscribe from this list: send the line unsubscribe
Add DocBook documentation for the new multi-planar API extensions to the
Video for Linux 2 API DocBook.
Signed-off-by: Pawel Osciak pa...@osciak.com
---
Documentation/DocBook/media-entities.tmpl |4 +
Documentation/DocBook/v4l/common.xml |2 +
Documentation/DocBook/v4l
Hi Hans,
Huge thanks for the review!
On Mon, Jan 3, 2011 at 23:53, Hans Verkuil hverk...@xs4all.nl wrote:
On Tuesday, January 04, 2011 05:20:45 Pawel Osciak wrote:
Add DocBook documentation for the new multi-planar API extensions to the
Video for Linux 2 API DocBook.
Signed-off-by: Pawel
Correct ioctl return value handling and fix coding style issues.
Signed-off-by: Pawel Osciak pa...@osciak.com
---
Documentation/DocBook/v4l/io.xml | 40 +++---
1 files changed, 20 insertions(+), 20 deletions(-)
diff --git a/Documentation/DocBook/v4l/io.xml b
Add DocBook documentation for the new multi-planar API extensions to the
Video for Linux 2 API DocBook.
Signed-off-by: Pawel Osciak pa...@osciak.com
---
Documentation/DocBook/media-entities.tmpl |4 +
Documentation/DocBook/v4l/common.xml |2 +
Documentation/DocBook/v4l
On Thu, Jan 6, 2011 at 20:40, Pawel Osciak pa...@osciak.com wrote:
Correct ioctl return value handling and fix coding style issues.
Signed-off-by: Pawel Osciak pa...@osciak.com
---
Documentation/DocBook/v4l/io.xml | 40
+++---
1 files changed, 20
Hi Mauro,
On Tue, Jan 11, 2011 at 10:23, Mauro Carvalho Chehab mche...@redhat.com wrote:
Pawel Osciak (8):
v4l: Add multi-planar API definitions to the V4L2 API
v4l: Add multi-planar ioctl handling code
v4l: Add compat functions for the multi-planar API
v4l: fix copy
Hi Mauro,
On Tue, Jan 11, 2011 at 13:57, Mauro Carvalho Chehab mche...@redhat.com wrote:
Em 03-01-2011 14:48, Sylwester Nawrocki escreveu:
Pawel Osciak (8):
v4l: Add multi-planar API definitions to the V4L2 API
Where are the corresponding DocBook changes?
They are at:
https
be commenting the patches as I'll be seeing any issues.
Pawel Osciak (2):
Fix mmap() example in the V4L2 API DocBook
In fact, the check for retval 0 instead of retval == -1 is not a fix.
According with
mmap man pages:
RETURN VALUE
On success, mmap() returns
video_device is already being freed in video_device.release callback on
release.
Signed-off-by: Pawel Osciak pa...@osciak.com
Reported-by: Roland Kletzing devz...@web.de
---
drivers/media/video/mem2mem_testdev.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers
Add DocBook documentation for the new multi-planar API extensions to the
Video for Linux 2 API DocBook.
Signed-off-by: Pawel Osciak pa...@osciak.com
---
Removed references to single-multi planar API conversion layer.
Documentation/DocBook/media-entities.tmpl |4 +
Documentation/DocBook
This feature will probably be moved to libv4l2.
Signed-off-by: Pawel Osciak pa...@osciak.com
---
Documentation/DocBook/v4l/planar-apis.xml | 35 +---
Documentation/DocBook/v4l/vidioc-querycap.xml | 22 +++
2 files changed, 18 insertions(+), 39 deletions
-0800)
are available in the git repository at:
ssh://linuxtv.org/git/posciak/media_tree.git staging/for_v2.6.38rc
Pawel Osciak (1):
[media] Fix double free of video_device in mem2mem_testdev
drivers/media/video/mem2mem_testdev.c | 1 -
1 files changed, 0 insertions(+), 1 deletions
streaming mode
(2011-02-02 12:06:14 -0200)
are available in the git repository at:
ssh://linuxtv.org/git/posciak/media_tree.git staging/for_v2.6.39
Pawel Osciak (1):
[media] Remove compatibility layer from multi-planar API documentation
Documentation/DocBook/v4l/planar-apis.xml | 35
a
PCM audio data plane in there too, if I though I could get away with
it. ;) ]
Those are all good ideas. It'd be great if we could do some more
brainstorming, gather requirements for different devices and come up
with an universal solution.
--
Best regards,
Pawel Osciak
--
To unsubscribe from
in documentation above. As we
are returning buf_queue return values to userspace directly, drivers
need to be careful what they return.
--
Best regards,
Pawel Osciak
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo
Hi Laurent,
On Tue, Mar 1, 2011 at 02:54, Laurent Pinchart
laurent.pinch...@ideasonboard.com wrote:
Hi Pawel,
On Monday 28 February 2011 16:44:38 Pawel Osciak wrote:
Hi Laurent,
A few questions from me below. I feel we need to talk about this
change a bit more, it introduces some recovery
Use vb2_dma_contig_plane_paddr to retrieve a physical address for a plane
instead of calling an internal mem_ops callback.
Signed-off-by: Pawel Osciak pa...@osciak.com
---
drivers/media/video/sh_mobile_ceu_camera.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git
dma_addr_t may not fit into void* on some architectures. To be safe, make
vb2_dma_contig_cookie() return a pointer to dma_addr_t and dereference it
in vb2_dma_contig_plane_paddr() back to dma_addr_t.
Signed-off-by: Pawel Osciak pa...@osciak.com
Reported-by: Hans Verkuil hverk...@xs4all.nl
would be faster without having to call STREAMON anyway...
--
Best regards,
Pawel Osciak
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Fix vb2 not handling return value from start_streaming() callback.
Signed-off-by: Pawel Osciak pa...@osciak.com
---
drivers/media/video/videobuf2-core.c | 11 ---
1 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/media/video/videobuf2-core.c
b/drivers/media/video
Multi-planar API was added to 2.6.39 version of Video for Linux 2 API.
Signed-off-by: Pawel Osciak pa...@osciak.com
---
Documentation/DocBook/v4l/compat.xml | 13 -
Documentation/DocBook/v4l/v4l2.xml | 13 ++---
2 files changed, 6 insertions(+), 20 deletions(-)
diff
18:09:02 -0300)
are available in the git repository at:
ssh://linuxtv.org/git/posciak/media_tree.git staging/for_v2.6.39
Pawel Osciak (4):
[media] Make 2.6.39 not 2.6.38 the version when Multi-planar API was added
Update Pawel Osciak's e-mail address.
[media] vb2: vb2_poll
Hi Guennadi,
On Mon, Mar 21, 2011 at 03:47, Guennadi Liakhovetski
g.liakhovet...@gmx.de wrote:
On Mon, 14 Mar 2011, Pawel Osciak wrote:
dma_addr_t may not fit into void* on some architectures. To be safe, make
vb2_dma_contig_cookie() return a pointer to dma_addr_t and dereference
mapped:1;
};
that probably should be an unsigned int (I can see code that assigns
1 to it that just won't fit).
Hi David,
Thanks for the report, will fix soon.
--
Best regards,
Pawel Osciak
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body
is worth it...
- I understand SUBMIT is optional?
- Could you give an example of how this could be used in an application?
--
Best regards,
Pawel Osciak
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info
vb2_queue_release(struct vb2_queue *q);
--
1.7.2.5
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Best regards,
Pawel Osciak
--
To unsubscribe from
Update documentation for videobuf2 driver callbacks and memory operations.
Signed-off-by: Pawel Osciak pa...@osciak.com
---
include/media/videobuf2-core.h | 146 +---
1 files changed, 91 insertions(+), 55 deletions(-)
diff --git a/include/media/videobuf2
Signed-off-by: Pawel Osciak pa...@osciak.com
Reported-by: David Alan Gilbert li...@treblig.org
---
include/media/videobuf2-core.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/media/videobuf2-core.h b/include/media/videobuf2-core.h
index 4c1e91f..f3bdbb2 100644
Add a sanity check to make sure drivers do not adjust the number of buffers
or planes above the supported limit on reqbufs.
Signed-off-by: Pawel Osciak pa...@osciak.com
---
drivers/media/video/videobuf2-core.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/drivers
[PATCH 4/5] [media] sh_mobile_ceu_camera: remove stop_streaming() callback
return
[PATCH 5/5] [media] mx3_camera: remove stop_streaming() callback return
--
Best regards,
Pawel Osciak
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord
.
Signed-off-by: Pawel Osciak pa...@osciak.com
---
drivers/media/video/videobuf2-core.c | 16 ++--
include/media/videobuf2-core.h | 16 +++-
2 files changed, 21 insertions(+), 11 deletions(-)
diff --git a/drivers/media/video/videobuf2-core.c
b/drivers/media/video
The stop_streaming() callback does not return a value anymore.
Signed-off-by: Pawel Osciak pa...@osciak.com
---
drivers/media/video/sh_mobile_ceu_camera.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/video/sh_mobile_ceu_camera.c
b/drivers/media/video
The stop_streaming() callback does not return a value anymore.
Signed-off-by: Pawel Osciak pa...@osciak.com
---
drivers/media/video/mx3_camera.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/media/video/mx3_camera.c b/drivers/media/video/mx3_camera.c
index
The stop_streaming() callback does not return a value anymore.
Signed-off-by: Pawel Osciak pa...@osciak.com
---
drivers/media/video/s5p-fimc/fimc-capture.c |4 ++--
drivers/media/video/s5p-fimc/fimc-core.c|4 +---
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers
Drivers are no longer required to call vb2_buffer_done() for all buffers
they have queued in stop_streaming().
The return value for stop_streaming() has also been removed.
Signed-off-by: Pawel Osciak pa...@osciak.com
---
drivers/media/video/vivi.c |9 +++--
1 files changed, 3 insertions
Hi Laurent,
On Mon, Apr 4, 2011 at 03:27, Laurent Pinchart
laurent.pinch...@ideasonboard.com wrote:
Hi Pawel,
On Monday 04 April 2011 01:51:05 Pawel Osciak wrote:
Hi,
This series implements a slight redesign of the stop_streaming() callback
in vb2. The callback has been made obligatory
On Sun, Apr 3, 2011 at 22:49, Marek Szyprowski m.szyprow...@samsung.com wrote:
Hello,
On Monday, April 04, 2011 1:51 AM Pawel Osciak wrote:
Drivers are now required to implement the stop_streaming() callback
to ensure that all ongoing hardware operations are finished and their
ownership
Hi again Marek
On Sun, Apr 3, 2011 at 22:49, Marek Szyprowski m.szyprow...@samsung.com wrote:
Hello,
On Monday, April 04, 2011 1:51 AM Pawel Osciak wrote:
Drivers are now required to implement the stop_streaming() callback
to ensure that all ongoing hardware operations are finished
1 - 100 of 342 matches
Mail list logo
