Re: [PATCH 3/3] media: mtk-cir: lower de-glitch counter for rc-mm protocol

2019-07-14 Thread Sean Wang
On Fri, Jul 12, 2019 at 3:47 PM Sean Young wrote: > > The rc-mm protocol can't be decoded by the mtk-cir since the de-glitch > filter removes pulses/spaces shorter than 294 microseconds. > > Tested on a BananaPi R2. Thanks for grabbing the board and do the test voluntarily

Re: [PATCH v2 2/3] [media] mceusb: Reword messages referring to "urb"

2019-07-15 Thread Sean Young
Hi, On Tue, Jun 25, 2019 at 05:29:02PM -0400, A Sun wrote: > > Hi again, > > On 6/25/2019 12:12 PM, Sean Young wrote: > > Hello, > > > > On Tue, Jun 25, 2019 at 11:01:32AM -0400, A Sun wrote: > >> On 6/25/2019 6:51 AM, Sean Young wrote: > >>&

Re: PATCH V3.5 1/2] dvbsky: add support for "Mygica T230C v2"

2019-07-15 Thread Sean Young
ID in dvb-usb-ids.h . > > This is v3.5 of the proposed patch, based on feedback from Sean > Young and Antti Palosaari. > Tested by patch author on DVB(T/T2/C). > Tested by Frank Rysanek on a T230C v2: can tune into locally > available DVB-T and DVB-T2 muxes, video and audi

Re: PATCH V3.5 1/2] dvbsky: add support for "Mygica T230C v2"

2019-07-16 Thread Sean Young
On Tue, Jul 16, 2019 at 05:11:52AM +0200, JP wrote: > On 7/15/19 11:21 PM, Sean Young wrote: > > On Tue, Jul 09, 2019 at 08:39:32PM +0200, Jan Pieter van Woerkom wrote: > > > From: Jan Pieter van Woerkom > > > > > > Adds support for the "Mygica T230C v2

Re: [PATCH V3.6 2/2] linux-media: dvbsky: add support for Mygica T230C v2

2019-07-17 Thread Sean Young
&cmd); > + if (ret) > + return ret; > + } > /* set TS_MODE property */ > memcpy(cmd.args, "\x14\x00\x01\x10\x10\x00", 6); > + cmd.args[4] <<= (dev->ts_mode & SI2168_TS_CLK_MANUAL) >> 5; I'm sorry but this

Re: MyGica T230 dvb-t2 data corruption since commit 5fa8815

2019-07-21 Thread Sean Young
On Fri, Jul 19, 2019 at 08:35:42PM +0200, Jan Pieter van Woerkom wrote: > dvbsky: add MyGica T230. > Moved from cxusb driver as that driver can't handle FX2 FIFO issue. Well then it should be deleted from the cxusb driver. Also how well is this tested? Thanks Sean > > Signed-o

Re: scancodes identified as invalid

2019-07-21 Thread Sean Young
is not the same as nec or nec32, is it scheduled to be added to > ir-ctl in the near future? Please let me know how you get on with the above. Thanks Sean

Re: scancodes identified as invalid

2019-07-21 Thread Sean Young
Hi, On Sun, Jul 21, 2019 at 11:33:54PM +, John G wrote: > Hi Sean, > > Thank you for the reply and the links! (difficult to find with Google) > > >  I'm not sure what the nec1 protocol is exactly. This sounds like a > >AnalysIR invention. > > Actually

Re: scancodes identified as invalid (I found the problem)

2019-07-22 Thread Sean Young
Hi John, On Mon, Jul 22, 2019 at 11:44:02AM +, John G wrote: > Hi Sean, > Using s = 0x20df10ef, protocol_scancode_valid() will return false (meaning it > is not a valid scancode). > > s>>24 = 0x0020 > s>>16 = 0x20df > ~(0x20df) = 0xdf20 > ( 0x002

[GIT PULL FOR v5.4] RC & DVB fixes

2019-07-22 Thread Sean Young
Hi Mauro, Here is the first batch of dvb & rc changes. Thanks Sean The following changes since commit 3f98538c7673e5306a126fd3cb7e0a84abc170ee: Merge tag 'v5.3-rc1' into patchwork (2019-07-22 07:40:55 -0400) are available in the Git repository at: git://linu

[PATCH v4l-utils] ir-ctl: show user how scancodes should be presented

2019-07-23 Thread Sean Young
Currently ir-ctl just says the scancode is invalid, which is not very clear. Signed-off-by: Sean Young --- utils/common/ir-encode.c | 66 utils/common/ir-encode.h | 2 +- utils/ir-ctl/ir-ctl.c| 10 ++ 3 files changed, 56 insertions(+), 22

[PATCH 1/2] media: lirc: document BPF IR decoding

2019-07-27 Thread Sean Young
This is just a start. Signed-off-by: Sean Young --- .../media/uapi/rc/lirc-dev-intro.rst | 47 +++ 1 file changed, 38 insertions(+), 9 deletions(-) diff --git a/Documentation/media/uapi/rc/lirc-dev-intro.rst b/Documentation/media/uapi/rc/lirc-dev-intro.rst index

[PATCH 2/2] media: rc: describe rc protocols and their scancodes

2019-07-27 Thread Sean Young
Signed-off-by: Sean Young --- .../media/uapi/rc/lirc-dev-intro.rst | 10 +- Documentation/media/uapi/rc/lirc-read.rst | 3 +- Documentation/media/uapi/rc/lirc-write.rst| 3 +- Documentation/media/uapi/rc/rc-protos.rst | 461 ++ .../media/uapi/rc

[PATCH v4l-utils] keytable: check keymaps

2019-07-30 Thread Sean Young
Signed-off-by: Sean Young --- utils/keytable/Makefile.am | 3 +++ utils/keytable/keytable.c | 40 +- 2 files changed, 29 insertions(+), 14 deletions(-) diff --git a/utils/keytable/Makefile.am b/utils/keytable/Makefile.am index 148b9446..0a8f5936 100644

[PATCH v4l-utils] keytable: generate missing keys like KEY_ZOOM

2019-07-30 Thread Sean Young
The input-event-codes.h now contains lines like: Ensure these parsed correctly. Signed-off-by: Sean Young --- utils/keytable/Makefile.am | 40 + utils/keytable/gen_input_events.pl | 92 ++ utils/keytable/parse.h | 9 +++ 3 files

[GIT PULL FOR v5.4] dvb/rc fixes

2019-07-31 Thread Sean Young
Hi Mauro, Here is another dvb/rc pull request. Note the dvb-pll id module parameter removal, see discussion on the list. More to come, I'm travelling and this is all I have time for now. Thanks Sean The following changes since commit 4590c07462fbff4ecbfe1deec44431c16191bd19: media

[GIT PULL FOR v5.4] dvb/rc fixes, take #2

2019-08-01 Thread Sean Young
Hi Mauro, Here is another dvb/rc pull request. More to come. Thanks Sean The following changes since commit 4590c07462fbff4ecbfe1deec44431c16191bd19: media: via-camera: convert to the vb2 framework (2019-07-30 12:18:34 -0400) are available in the Git repository at: git://linuxtv.org

Re: [ANN] Media summit in Lisbon at September

2019-08-01 Thread Sean Young
the Linux Plumber Conference and the Kernel Summit. > > > > We're still discussing the details about that. > > Gently reminder. > > Right now, we have just one extra theme proposal from Sean: > > - possible dvb improvements. TBH, this wasn't much of

[PATCH] media: dvb-frontends: use ida for pll number

2019-08-02 Thread Sean Young
89c9e600: 04 fa fa fa fa fa fa fa 04 fa fa fa fa fa fa fa 89c9e680: 04 fa fa fa fa fa fa fa 04 fa fa fa fa fa fa fa == Signed-off-by: Sean Young --- drivers/media/dvb-frontends/dvb-pll.c | 41 --- 1 f

[GIT PULL FOR v5.4] dvb/rc fixes, take #3

2019-08-03 Thread Sean Young
Hi Mauro, Here is another dvb/rc pull request; I've dropped the commit with the devm_i2c_new_dummy_device. Thanks Sean The following changes since commit 4590c07462fbff4ecbfe1deec44431c16191bd19: media: via-camera: convert to the vb2 framework (2019-07-30 12:18:34 -0400) are availab

Re: [PATCH v2 7/7] media: rc: mceusb: allow the timeout to be configurable

2018-05-09 Thread Sean Young
Hi Hias, On Mon, May 07, 2018 at 05:54:55PM +0200, Matthias Reichl wrote: > Hi Sean! > > [ I trimmed the Cc list, as this is mceusb specific ] > > On Sat, Apr 21, 2018 at 07:41:21PM +0200, Matthias Reichl wrote: > > On Sat, Apr 21, 2018 at 03:18:52PM +0200, Matthias Reichl

[PATCH 1/3] media: mceusb: filter out bogus timing irdata of duration 0

2018-05-11 Thread Sean Young
A mceusb device has been observed producing invalid irdata. Proactively guard against this. Suggested-by: Matthias Reichl Signed-off-by: Sean Young --- drivers/media/rc/mceusb.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/media/rc/mceusb.c b/drivers/media/rc/mceusb.c index

[PATCH 2/3] media: mceusb: add missing break

2018-05-11 Thread Sean Young
Fallthrough is not intended here. Signed-off-by: Sean Young --- drivers/media/rc/mceusb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/rc/mceusb.c b/drivers/media/rc/mceusb.c index 1ca49491abc8..4c0c8008872a 100644 --- a/drivers/media/rc/mceusb.c +++ b/drivers/media/rc

[PATCH 3/3] media: lirc-func.rst: new ioctl LIRC_GET_REC_TIMEOUT is not in a separate file

2018-05-11 Thread Sean Young
This fixes the warning: Documentation/media/uapi/rc/lirc-func.rst:9: WARNING: toctree contains reference to nonexisting document 'media/uapi/rc/lirc-get-rec-timeout' The ioctl is documented in lirc-set-rec-timeout. Signed-off-by: Sean Young --- Documentation/media/uapi/rc/lirc-fu

[PATCH 3/3] media: rc: winbond: do not send reset and timeout raw events on startup

2018-05-12 Thread Sean Young
ir_raw_event_set_idle() sends a timeout event which is not needed, and on startup no reset event is needed either. Signed-off-by: Sean Young --- drivers/media/rc/winbond-cir.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/rc/winbond-cir.c b/drivers/media

[PATCH 1/3] media: rc: drivers should produce alternate pulse and space timing events

2018-05-12 Thread Sean Young
Report an error if this is not the case or any problem with the generated raw events. Signed-off-by: Sean Young --- drivers/media/rc/rc-ir-raw.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/drivers/media/rc/rc-ir-raw.c b/drivers/media/rc/rc-ir-raw.c

[PATCH 2/3] media: rc: decoders do not need to check for transitions

2018-05-12 Thread Sean Young
Drivers should never produce consecutive pulse or space raw events. Should that occur, we would have bigger problems than this code is trying to guard against. Note that we already log an error should a driver misbehave. Signed-off-by: Sean Young --- drivers/media/rc/ir-mce_kbd-decoder.c | 6

[PATCH] media: rc: default to idle on at startup or after reset

2018-05-13 Thread Sean Young
Any spaces events received after a reset or startup should be discarded, so ensure the rc device is in idle mode. This also makes it much easier to detect incorrect raw events, as we will do in a following commit. Signed-off-by: Sean Young --- drivers/media/rc/rc-ir-raw.c | 1 + include/media

[GIT PULL FOR v4.18] RC fixes

2018-05-13 Thread Sean Young
Hi Mauro, Here is a fix for the lirc docs warning, a fix for the topseed mceusb device which did not like having its IR timeout set, and some patches which validate the IR raw events drivers produce. Thanks Sean The following changes since commit 2a5f2705c97625aa1a4e1dd4d584eaa05392e060

[PATCH v1 4/4] samples/bpf: an example of a raw IR decoder

2018-05-14 Thread Sean Young
This implements the grundig-16 IR protocol. Signed-off-by: Sean Young --- samples/bpf/Makefile | 4 + samples/bpf/bpf_load.c| 9 +- samples/bpf/grundig_decoder_kern.c| 112 ++ samples/bpf/grundig_decoder_user.c

[PATCH v1 2/4] media: bpf: allow raw IR decoder bpf programs to be used

2018-05-14 Thread Sean Young
This implements attaching, detaching, querying and execution. The target fd has to be the /dev/lircN device. Signed-off-by: Sean Young --- drivers/media/rc/ir-bpf-decoder.c | 191 ++ drivers/media/rc/lirc_dev.c | 30 + drivers/media/rc/rc-core-priv.h

[PATCH v1 3/4] media: rc bpf: move ir_raw_event to uapi

2018-05-14 Thread Sean Young
The context provided to a BPF_PROG_RAWIR_DECODER is a struct ir_raw_event; ensure user space has a a definition. Signed-off-by: Sean Young --- include/media/rc-core.h| 19 +-- include/uapi/linux/bpf_rcdev.h | 24 2 files changed, 25 insertions

[PATCH v1 1/4] media: rc: introduce BPF_PROG_IR_DECODER

2018-05-14 Thread Sean Young
Add support for BPF_PROG_IR_DECODER. This type of BPF program can call rc_keydown() to reported decoded IR scancodes, or rc_repeat() to report that the last key should be repeated. Signed-off-by: Sean Young --- drivers/media/rc/Kconfig | 8 +++ drivers/media/rc/Makefile | 1

[PATCH v1 0/4] IR decoding using BPF

2018-05-14 Thread Sean Young
nderway to extend ir-keytable to have an extensive library of bpf-based decoders, and a much expanded library of rc keymaps. Another future application would be to compile IRP[3] to a IR BPF program, and so support virtually every remote without having to write a decoder for each. Thanks, Sean

Re: [PATCH v1 1/4] media: rc: introduce BPF_PROG_IR_DECODER

2018-05-15 Thread Sean Young
On Mon, May 14, 2018 at 09:48:05PM -0700, Y Song wrote: > On Mon, May 14, 2018 at 2:10 PM, Sean Young wrote: > > Add support for BPF_PROG_IR_DECODER. This type of BPF program can call > > rc_keydown() to reported decoded IR scancodes, or rc_repeat() to report > > that t

Re: [PATCH v1 4/4] samples/bpf: an example of a raw IR decoder

2018-05-15 Thread Sean Young
On Mon, May 14, 2018 at 10:34:57PM -0700, Y Song wrote: > On Mon, May 14, 2018 at 2:11 PM, Sean Young wrote: > > This implements the grundig-16 IR protocol. > > > > Signed-off-by: Sean Young > > --- > > samples/bpf/Makefile |

Re: [PATCH v1 1/4] media: rc: introduce BPF_PROG_IR_DECODER

2018-05-15 Thread Sean Young
On Mon, May 14, 2018 at 04:27:19PM -0700, Randy Dunlap wrote: > On 05/14/2018 02:10 PM, Sean Young wrote: > > Add support for BPF_PROG_IR_DECODER. This type of BPF program can call > > Kconfig file below uses IR_BPF_DECODER instead of the symbol name above. > > and then

[PATCH v2 1/2] media: rc: introduce BPF_PROG_RAWIR_EVENT

2018-05-15 Thread Sean Young
device. Signed-off-by: Sean Young --- drivers/media/rc/Kconfig | 10 + drivers/media/rc/Makefile | 1 + drivers/media/rc/bpf-rawir-event.c | 322 + drivers/media/rc/lirc_dev.c| 28 +++ drivers/media/rc/rc-core-priv.h| 19 ++ drivers

[PATCH v2 0/2] IR decoding using BPF

2018-05-15 Thread Sean Young
nderway to extend ir-keytable to have an extensive library of bpf-based decoders, and a much expanded library of rc keymaps. Another future application would be to compile IRP[3] to a IR BPF program, and so support virtually every remote without having to write a decoder for each. Thanks, Sean

[PATCH v2 2/2] bpf: add selftest for rawir_event type program

2018-05-15 Thread Sean Young
This is simple test over rc-loopback. Signed-off-by: Sean Young --- tools/bpf/bpftool/prog.c | 1 + tools/include/uapi/linux/bpf.h| 55 +++- tools/lib/bpf/libbpf.c| 1 + tools/testing/selftests/bpf/Makefile | 7

Re: [PATCH v2 1/2] media: rc: introduce BPF_PROG_RAWIR_EVENT

2018-05-16 Thread Sean Young
On Tue, May 15, 2018 at 07:50:19PM +0100, Sean Young wrote: > Add support for BPF_PROG_RAWIR_EVENT. This type of BPF program can call > rc_keydown() to reported decoded IR scancodes, or rc_repeat() to report > that the last key should be repeated. > > The bpf program can be attach

[PATCH v3 2/2] bpf: add selftest for rawir_event type program

2018-05-16 Thread Sean Young
This is simple test over rc-loopback. Signed-off-by: Sean Young --- tools/bpf/bpftool/prog.c | 1 + tools/include/uapi/linux/bpf.h| 57 +++- tools/lib/bpf/libbpf.c| 1 + tools/testing/selftests/bpf/Makefile | 8

[PATCH v3 1/2] media: rc: introduce BPF_PROG_RAWIR_EVENT

2018-05-16 Thread Sean Young
device. Signed-off-by: Sean Young --- drivers/media/rc/Kconfig | 13 ++ drivers/media/rc/Makefile | 1 + drivers/media/rc/bpf-rawir-event.c | 363 + drivers/media/rc/lirc_dev.c| 24 ++ drivers/media/rc/rc-core-priv.h| 24 ++ drivers

[PATCH v3 0/2] IR decoding using BPF

2018-05-16 Thread Sean Young
ally every remote without having to write a decoder for each. It might also be possible to support non-button devices such as analog directional pads or air conditioning remote controls and decode the target temperature in bpf, and pass that to an input device. Thanks, Sean Young [1] http:

Re: [PATCH v3 1/2] media: rc: introduce BPF_PROG_RAWIR_EVENT

2018-05-17 Thread Sean Young
Hi Quentin, On Thu, May 17, 2018 at 01:10:56PM +0100, Quentin Monnet wrote: > 2018-05-16 22:04 UTC+0100 ~ Sean Young > > Add support for BPF_PROG_RAWIR_EVENT. This type of BPF program can call > > rc_keydown() to reported decoded IR scancodes, or rc_repeat() to report > &

Re: [PATCH v3 2/2] bpf: add selftest for rawir_event type program

2018-05-17 Thread Sean Young
On Thu, May 17, 2018 at 10:17:59AM -0700, Y Song wrote: > On Wed, May 16, 2018 at 2:04 PM, Sean Young wrote: > > This is simple test over rc-loopback. > > > > Signed-off-by: Sean Young > > --- > > tools/bpf/bpftool/prog.c | 1 + &g

Re: [PATCH v3 1/2] media: rc: introduce BPF_PROG_RAWIR_EVENT

2018-05-17 Thread Sean Young
Hi, Again thanks for a thoughtful review. This will definitely will improve the code. On Thu, May 17, 2018 at 10:02:52AM -0700, Y Song wrote: > On Wed, May 16, 2018 at 2:04 PM, Sean Young wrote: > > Add support for BPF_PROG_RAWIR_EVENT. This type of BPF program can call > >

Re: [PATCH v3 2/2] bpf: add selftest for rawir_event type program

2018-05-18 Thread Sean Young
On Fri, May 18, 2018 at 11:13:07AM +0100, Quentin Monnet wrote: > 2018-05-17 22:01 UTC+0100 ~ Sean Young > > On Thu, May 17, 2018 at 10:17:59AM -0700, Y Song wrote: > >> On Wed, May 16, 2018 at 2:04 PM, Sean Young wrote: > >>> This is simple test over rc-loopback. &

[PATCH v4 2/3] media: rc: introduce BPF_PROG_LIRC_MODE2

2018-05-18 Thread Sean Young
device. Signed-off-by: Sean Young --- drivers/media/rc/Kconfig| 13 ++ drivers/media/rc/Makefile | 1 + drivers/media/rc/bpf-lirc.c | 308 drivers/media/rc/lirc_dev.c | 30 drivers/media/rc/rc-core-priv.h | 22 +++ drivers/media/rc/rc

[PATCH v4 3/3] bpf: add selftest for lirc_mode2 type program

2018-05-18 Thread Sean Young
This is simple test over rc-loopback. Signed-off-by: Sean Young --- tools/bpf/bpftool/prog.c | 1 + tools/include/uapi/linux/bpf.h| 53 - tools/include/uapi/linux/lirc.h | 217 ++ tools/lib/bpf/libbpf.c

[PATCH v4 1/3] bpf: bpf_prog_array_copy() should return -ENOENT if exclude_prog not found

2018-05-18 Thread Sean Young
This makes is it possible for bpf prog detach to return -ENOENT. Signed-off-by: Sean Young --- kernel/bpf/core.c| 11 +-- kernel/trace/bpf_trace.c | 2 ++ 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/kernel/bpf/core.c b/kernel/bpf/core.c index 2194c6a9df42

[PATCH v4 0/3] IR decoding using BPF

2018-05-18 Thread Sean Young
ally every remote without having to write a decoder for each. It might also be possible to support non-button devices such as analog directional pads or air conditioning remote controls and decode the target temperature in bpf, and pass that to an input device. Thanks, Sean Young [1] http:

Re: [PATCH] lirc.4: remove ioctls and feature bits which were never implemented

2018-05-18 Thread Sean Young
On Sun, May 06, 2018 at 12:34:53PM +0200, Michael Kerrisk (man-opages) wrote: > [CCing original author of this page] > > > On 04/23/2018 12:26 PM, Sean Young wrote: > > The lirc header file included ioctls and feature bits which were never > > implemented by any driv

Re: [PATCH v2 1/5] media: cec-notifier: Get notifier by device and connector name

2018-05-18 Thread Sean Paul
#endif > > /** > + * cec_notifier_get - find or create a new cec_notifier for the given device. > + * @dev: device that sends the events. > + * > + * If a notifier for device @dev already exists, then increase the refcount > + * and return that notifier. &g

Re: [PATCH 1/3] media: rc: nuvoton: Tweak the interrupt enabling dance

2018-05-21 Thread Sean Young
se(). > And since nvt_open() is broken, the device doesn't seem to work as > expected. Since that commit was in v4.16, should we have the following: Cc: sta...@vger.kernel.org # v4.16+ On this commit (and not the other two, if I understand them correctly)? Thanks, Sean > >

Re: ir-keytable protocol setup broken and no ir events

2018-05-22 Thread Sean Young
ir-keytable -s rc0 -p nec" (or rc1), I'm not sure it will work by selecting input device. > No events shown with evtest and ir-keytable -t. > > I am using the amd-staging-drm-next kernel. I tested also with the > stock Debian kernel 4.15. I tested also with the latest Manjaro Linux. A git bisect would be ideal. I did not spot anything from looking at the code. Thanks, Sean

Re: [PATCH v4 0/3] IR decoding using BPF

2018-05-23 Thread Sean Young
On Wed, May 23, 2018 at 02:21:27PM +0200, Daniel Borkmann wrote: > On 05/18/2018 04:07 PM, Sean Young wrote: > > The kernel IR decoders (drivers/media/rc/ir-*-decoder.c) support the most > > widely used IR protocols, but there are many protocols which are not > > supported

[PATCH] media: rc: ensure input/lirc device can be opened after register

2018-05-24 Thread Sean Young
lirc or input device can be opened. Fixes: cb84343fced1 ("media: lirc: do not call close() or open() on unregistered devices") Cc: sta...@vger.kernel.org # v4.16+ Signed-off-by: Sean Young --- drivers/media/rc/rc-main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -

Re: [PATCH 3/3] media: rc: nuvoton: Keep device enabled during reg init

2018-05-24 Thread Sean Young
er init. I don't have the datasheet so I might be misunderstanding this. We want the IR wakeup to work fine even after kernel crash/power loss, right? > Signed-off-by: Michał Winiarski > Cc: Jarod Wilson > Cc: Sean Young > --- > drivers/media/rc/nuvoton-cir.c | 9 +++--

Re: [PATCH 3/3] media: rc: nuvoton: Keep device enabled during reg init

2018-05-25 Thread Sean Young
On Fri, May 25, 2018 at 03:35:23PM +0200, Michał Winiarski wrote: > On Thu, May 24, 2018 at 12:31:40PM +0100, Sean Young wrote: > > On Mon, May 21, 2018 at 04:38:03PM +0200, Michał Winiarski wrote: > > > Doing writes when the device is disabled seems to be a NOOP. > > &

[GIT PULL FOR v4.18] RC fixes

2018-05-25 Thread Sean Young
Hi Mauro, Fixes for a regression in v4.16, and broken open/close handling in the nuvoton driver. Thanks Sean The following changes since commit 8ed8bba70b4355b1ba029b151ade84475dd12991: media: imx274: remove non-indexed pointers from mode_table (2018-05-17 06:22:08 -0400) are available in

Re: [PATCH 3/3] media: rc: nuvoton: Keep device enabled during reg init

2018-05-25 Thread Sean Young
On Fri, May 25, 2018 at 04:42:02PM +0200, Michał Winiarski wrote: > On Fri, May 25, 2018 at 02:59:41PM +0100, Sean Young wrote: > > On Fri, May 25, 2018 at 03:35:23PM +0200, Michał Winiarski wrote: > > > On Thu, May 24, 2018 at 12:31:40PM +0100, Sean Young wrote: > > > &

Re: [PATCH v4 2/3] media: rc: introduce BPF_PROG_LIRC_MODE2

2018-05-26 Thread Sean Young
On Fri, May 25, 2018 at 01:45:11PM -0700, Alexei Starovoitov wrote: > On Fri, May 18, 2018 at 03:07:29PM +0100, Sean Young wrote: > > Add support for BPF_PROG_LIRC_MODE2. This type of BPF program can call > > rc_keydown() to reported decoded IR scancodes, or rc_repeat() to report &g

[PATCH v5 3/3] bpf: add selftest for lirc_mode2 type program

2018-05-27 Thread Sean Young
This is simple test over rc-loopback. Acked-by: Yonghong Song Signed-off-by: Sean Young --- tools/bpf/bpftool/prog.c | 1 + tools/include/uapi/linux/bpf.h| 53 - tools/include/uapi/linux/lirc.h | 217 ++ tools/lib/bpf

[PATCH v5 0/3] IR decoding using BPF

2018-05-27 Thread Sean Young
ally every remote without having to write a decoder for each. It might also be possible to support non-button devices such as analog directional pads or air conditioning remote controls and decode the target temperature in bpf, and pass that to an input device. Thanks, Sean Young [1] http:

[PATCH v5 2/3] media: rc: introduce BPF_PROG_LIRC_MODE2

2018-05-27 Thread Sean Young
device. Acked-by: Yonghong Song Signed-off-by: Sean Young --- drivers/media/rc/Kconfig| 13 ++ drivers/media/rc/Makefile | 1 + drivers/media/rc/bpf-lirc.c | 313 drivers/media/rc/lirc_dev.c | 30 +++ drivers/media/rc/rc-core-priv.h | 21

[PATCH v5 1/3] bpf: bpf_prog_array_copy() should return -ENOENT if exclude_prog not found

2018-05-27 Thread Sean Young
This makes is it possible for bpf prog detach to return -ENOENT. Acked-by: Yonghong Song Signed-off-by: Sean Young --- kernel/bpf/core.c| 11 +-- kernel/trace/bpf_trace.c | 2 ++ 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/kernel/bpf/core.c b/kernel/bpf

[RFC PATCH v1 4/4] keytable: add bpf protocols

2018-06-02 Thread Sean Young
Add grundig decoder and infrastructure for build bpf protocols. Signed-off-by: Sean Young --- configure.ac| 5 + utils/keytable/Makefile.am | 4 + utils/keytable/bpf_protocols/Makefile.am| 14 + utils/keytable/bpf_protocols/bpf_helpers.h

[RFC PATCH v1 1/4] keytable: add toml keymap reader

2018-06-02 Thread Sean Young
32 bit scancode -> keycode. In order to make this possible, we want the scancodes to be specified for their protocol, in case multiple protocols are selected. Signed-off-by: Sean Young --- utils/keytable/Makefile.am |2 +- utils/keytable/keytable.c | 174 +++- utils/keytable/toml.c

[RFC PATCH v1 0/4] Add BPF decoders to ir-keytable

2018-06-02 Thread Sean Young
5 ms Steps to complete this work: - Write more IR decoders - More rc_keymaps - More testing - lircd.conf to toml converter script (python/perl?) Sean Young (4): keytable: add toml keymap reader keytable: convert keymaps to new toml format keytable: add support for BPF based decoders ke

[RFC PATCH v1 3/4] keytable: add support for BPF based decoders

2018-06-02 Thread Sean Young
We use a modified version of samples/bpf/bpf_load.c from linux kernel tree to load elf based BPF decoders, clear them on '-c' and show the program ids when no commands are given. Any global int variables can be overrided from toml. They are patched to be immediate loads. Signed-of

Re: [RFC PATCH v1 0/4] Add BPF decoders to ir-keytable

2018-06-02 Thread Sean Young
On Sat, Jun 02, 2018 at 01:37:54PM +0100, Sean Young wrote: > This is not ready for merging yet, however while I finish this work I would > like some feedback and ideas. > > The idea is that IR decoders can be written in C, compiled to BPF relocatable > object file. Any globa

Re: [PATCH] lirc.4: remove ioctls and feature bits which were never implemented

2018-06-06 Thread Sean Young
Hi Alec, On Sat, May 19, 2018 at 08:38:11AM +0200, Alec Leamas wrote: > On 18/05/18 17:25, Sean Young wrote: > > On Sun, May 06, 2018 at 12:34:53PM +0200, Michael Kerrisk (man-opages) > > wrote: > >> [CCing original author of this page] > >> > >> >

Re: [1/3] media: rc: drivers should produce alternate pulse and space timing events

2018-06-19 Thread Sean Young
On Tue, Jun 19, 2018 at 02:08:12PM +0200, Jerome Brunet wrote: > On Sat, 2018-05-12 at 11:55 +0100, Sean Young wrote: > > Report an error if this is not the case or any problem with the generated > > raw events. > > Hi, > > Since the inclusion of this patch, every

[RFC PATCH v2 0/4] Add BPF decoders to ir-keytable

2018-06-24 Thread Sean Young
script (python/perl?) Changes since v2: - bpf parameters can be specified on the command line - bpf decoders can be loaded by path without keymap Sean Young (4): keytable: add toml keymap reader keytable: convert keymaps to new toml format keytable: add support for BPF based decoders ke

[RFC PATCH v2 1/4] keytable: add toml keymap reader

2018-06-24 Thread Sean Young
32 bit scancode -> keycode. In order to make this possible, we want the scancodes to be specified for their protocol, in case multiple protocols are selected. Signed-off-by: Sean Young --- utils/keytable/Makefile.am |2 +- utils/keytable/keytable.c | 174 +++- utils/keytable/toml.c

[RFC PATCH v2 2/4] keytable: convert keymaps to new toml format

2018-06-24 Thread Sean Young
We will be added new BPF based keymaps which require the toml format. Convert all the existing keymaps to toml, so that only one format is used. Include the protocol variant as well. This will be useful in the future if we want to use rc keymaps for transmitting IR. Signed-off-by: Sean Young

[RFC PATCH v2 4/4] keytable: add bpf protocols

2018-06-24 Thread Sean Young
Add grundig decoder and infrastructure for build bpf protocols. Signed-off-by: Sean Young --- configure.ac | 4 + utils/keytable/Makefile.am| 4 + utils/keytable/bpf_protocols/Makefile.am | 21 ++ utils/keytable/bpf_protocols

Re: [1/3] media: rc: drivers should produce alternate pulse and space timing events

2018-06-26 Thread Sean Young
On Tue, Jun 19, 2018 at 04:09:20PM +0200, Jerome Brunet wrote: > On Tue, 2018-06-19 at 13:57 +0100, Sean Young wrote: > > On Tue, Jun 19, 2018 at 02:08:12PM +0200, Jerome Brunet wrote: > > > On Sat, 2018-05-12 at 11:55 +0100, Sean Young wrote: > > > > Report an error

Re: [1/3] media: rc: drivers should produce alternate pulse and space timing events

2018-06-26 Thread Sean Young
On Tue, Jun 26, 2018 at 04:39:51PM +0200, Jerome Brunet wrote: > On Tue, 2018-06-26 at 15:37 +0100, Sean Young wrote: > > On Tue, Jun 19, 2018 at 04:09:20PM +0200, Jerome Brunet wrote: > > > On Tue, 2018-06-19 at 13:57 +0100, Sean Young wrote: > > > > On Tue, Ju

[GIT FIXES FOR v4.18] meson-ir produces too many warnings

2018-06-27 Thread Sean Young
Hi Mauro, The meson-ir drivers produces a lot of errors since v4.18. Simply make this dev_warn_once(). Thanks, Sean The following changes since commit e88f5e9ebd54bdf75c9833e3d9add7c2c0d39b0b: media: uvcvideo: Prevent setting unavailable flags (2018-06-05 08:53:17 -0400) are available in

[PATCH] media: bpf: ensure bpf program is freed on detach

2018-07-04 Thread Sean Young
Currently we are leaking bpf programs when they are detached from the lirc device; the refcount never reaches zero. Signed-off-by: Sean Young --- drivers/media/rc/bpf-lirc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/rc/bpf-lirc.c b/drivers/media/rc/bpf-lirc.c index

[GIT FIXES FOR v4.18] leaking bpf programs after detach

2018-07-04 Thread Sean Young
kasan and ubsan. The list of bpf programs can be using the bpftool (in the kernel tree), command line "bpftool prog list". Thanks, Sean The following changes since commit 0ca54b29054151b7a52cbb8904732280afe5a302: media: rc: be less noisy when driver misbehaves (2018-06-27 10:03

Re: [PATCH] lirc.4: remove ioctls and feature bits which were never implemented

2018-07-12 Thread Sean Young
On Thu, Jul 12, 2018 at 09:33:32AM -0300, Mauro Carvalho Chehab wrote: > Hi Michael/Alec, > > Em Fri, 18 May 2018 16:25:29 +0100 > Sean Young escreveu: > > > On Sun, May 06, 2018 at 12:34:53PM +0200, Michael Kerrisk (man-opages) > > wrote: > > >

[PATCH v2 1/2] media: dt-bindings: bind nokia,n900-ir to generic pwm-ir-tx driver

2018-07-13 Thread Sean Young
The generic pwm-ir-tx driver should work for the Nokia n900. Compile tested only. Cc: Rob Herring Cc: Ivaylo Dimitrov Cc: Pali Rohár Cc: Pavel Machek Cc: Timo Kokkonen Cc: Tony Lindgren Signed-off-by: Sean Young --- .../devicetree/bindings/media/nokia,n900-ir | 20

[PATCH v2 2/2] media: rc: remove ir-rx51 in favour of generic pwm-ir-tx

2018-07-13 Thread Sean Young
the transmit completes. Compile tested only. Cc: Ivaylo Dimitrov Cc: Pali Rohár Cc: Pavel Machek Cc: Timo Kokkonen Cc: Tony Lindgren Signed-off-by: Sean Young --- arch/arm/configs/omap2plus_defconfig | 1 - drivers/media/rc/Kconfig | 10 - drivers/media/rc/Makefile

[PATCH v3 2/2] media: rc: remove ir-rx51 in favour of generic pwm-ir-tx

2018-07-13 Thread Sean Young
transmit completes. Compile tested only. Cc: Ivaylo Dimitrov Cc: Pali Rohár Cc: Pavel Machek Cc: Timo Kokkonen Cc: Tony Lindgren Signed-off-by: Sean Young --- arch/arm/configs/omap2plus_defconfig | 1 - drivers/media/rc/Kconfig | 10 - drivers/media/rc/Makefile| 1

[PATCH v3 1/2] media: dt-bindings: bind nokia,n900-ir to generic pwm-ir-tx driver

2018-07-13 Thread Sean Young
The generic pwm-ir-tx driver should work for the Nokia n900. Compile tested only. Cc: Rob Herring Cc: Ivaylo Dimitrov Cc: Pali Rohár Cc: Pavel Machek Cc: Timo Kokkonen Cc: Tony Lindgren Signed-off-by: Sean Young --- arch/arm/boot/dts/omap3-n900.dts | 2 +- drivers/media/rc/pwm-ir-tx.c

Re: [PATCH v2 1/2] media: dt-bindings: bind nokia,n900-ir to generic pwm-ir-tx driver

2018-07-13 Thread Sean Young
On Fri, Jul 13, 2018 at 01:13:20PM +0200, Pavel Machek wrote: > Hi! > > > Signed-off-by: Sean Young > > --- > > .../devicetree/bindings/media/nokia,n900-ir | 20 --- > > arch/arm/boot/dts/omap3-n900.dts | 2 +- >

[PATCH v3 2/5] keytable: add bpf protocols

2018-07-13 Thread Sean Young
Add a few BPF protocols and infrastructure for building them. Signed-off-by: Sean Young --- configure.ac | 4 + utils/keytable/Makefile.am| 4 + utils/keytable/bpf_protocols/Makefile.am | 21 ++ utils/keytable/bpf_protocols

[PATCH v3 0/5] Add BPF decoders to ir-keytable

2018-07-13 Thread Sean Young
back, thank you. Changes since v3: - lots of fixes - Wrote python script to convert lircd.conf to toml file Changes since v2: - bpf parameters can be specified on the command line - bpf decoders can be loaded by path without keymap Sean Young (5): keytable: add support for BPF based protocols

[PATCH v3 4/5] keytable: convert keymaps to new toml format

2018-07-13 Thread Sean Young
Convert all the existing keymaps to toml, so that only one format is used. Include the protocol variant as well. This will be useful in the future if we want to use rc keymaps for transmitting IR. Signed-off-by: Sean Young --- utils/keytable/gen_keytables.pl | 33 ++- utils

[PATCH v3 5/5] ir-keytable: add tool to aid migration from lircd

2018-07-13 Thread Sean Young
This python script is written to help users translate their lircd.conf remote definition to ir-keytable toml format. The tool does not cover every possible lircd.conf, but the majority should work. ./lircd2toml.py PD-202.lircd.conf -o PD-202.toml Signed-off-by: Sean Young --- contrib

[PATCH v3 3/5] keytable: add toml keymap reader

2018-07-13 Thread Sean Young
her the existing 32 bit scancode -> keycode. In order to make this possible, we want the scancodes to be specified for their protocol, in case multiple protocols are selected. Signed-off-by: Sean Young --- utils/keytable/Makefile.am |2 +- utils/keytable/bpf_load.c | 21 +- utils/ke

Re: [RFC PATCH 1/8] cec: fix epoll() by calling poll_wait first

2019-02-08 Thread Sean Young
ts) > res |= EPOLLPRI; > - poll_wait(filp, &fh->wait, poll); > mutex_unlock(&adap->lock); > return res; > } > -- > 2.20.1 Reviewed-by: Sean Young Sean

Re: [RFC PATCH 8/8] dvb-core: fix epoll() by calling poll_wait first

2019-02-08 Thread Sean Young
, dvb_dvr_poll() and > dvb_ca_en50221_io_poll(). Fix this, otherwise epoll() > can timeout when it shouldn't. > > Signed-off-by: Hans Verkuil Reviewed-by: Sean Young > --- > drivers/media/dvb-core/dmxdev.c | 8 > drivers/media/dvb-core/dvb_ca_en50221.c | 5 ++--- &g

[GIT PULL FOR v5.1] RC fixes

2019-02-08 Thread Sean Young
Hi Mauro, Here are the last RC fixes for 5.1. Thanks, Sean The following changes since commit 6fd369dd1cb65a032f1ab9227033ecb7b759656d: media: vimc: fill in bus_info in media_device_info (2019-02-07 12:38:59 -0500) are available in the Git repository at: git://linuxtv.org/syoung

Re: [GIT PULL FOR v5.1] RC fixes

2019-02-18 Thread Sean Young
On Mon, Feb 18, 2019 at 02:22:52PM -0300, Mauro Carvalho Chehab wrote: > Em Fri, 8 Feb 2019 22:15:22 + > Sean Young escreveu: > > > Hi Mauro, > > > > Here are the last RC fixes for 5.1. > > > > Thanks, > > > &g

[GIT PULL FOR v5.1] RC fixes v2

2019-02-18 Thread Sean Young
Hi Mauro, Here are the last RC fixes for 5.1, this time with the documentation warnings fixed. Thanks, Sean The following changes since commit 46c039d06b6ecabb94bd16c3a999b28dc83b79ce: media: cx25840: mark pad sig_types to fix cx231xx init (2019-02-18 12:33:20 -0500) are available in the

Re: [PATCH] media: dvb/earth-pt1: fix wrong initialization for demod blocks

2019-02-18 Thread Sean Young
; } > > + ret = pt1_demod_block_init(pt1); > + if (ret < 0) > + goto fe_unregister; > + > return 0; > > tuner_release: > @@ -1245,6 +1283,10 @@ static int pt1_resume(struct device *dev) > pt1_update_power(pt1); > usleep_range(1000, 2000); > > + ret = pt1_demod_block_init(pt1); > + if (ret < 0) > + goto resume_err; > + > for (i = 0; i < PT1_NR_ADAPS; i++) > dvb_frontend_reinitialise(pt1->adaps[i]->fe); > > -- > 2.20.1 Many thanks, Sean

<    1   2   3   4   5   6   7   8   9   10   >