Re: [PATCH 03/16] lirc_dev: correct error handling

On Mon, May 01, 2017 at 06:03:51PM +0200, David Härdeman wrote: > If an error is generated, nonseekable_open() shouldn't be called. There is no harm in calling nonseekable_open(), so this commit is misleading. Sean > > Signed-off-by: David Härdeman > --- > drivers/media/

Re: [PATCH 13/16] lirc_dev: use an ida instead of a hand-rolled array to keep track of minors

> if (retval) { > class_destroy(lirc_class); > @@ -613,7 +561,7 @@ static int __init lirc_dev_init(void) > static void __exit lirc_dev_exit(void) > { > class_destroy(lirc_class); > - unregister_chrdev_region(lirc_base_dev, MAX_IRCTL_DEVICES); > +

Re: [PATCH 3/7] rc-core: img-nec-decoder - leave the internals of rc_dev alone

On Mon, May 01, 2017 at 06:10:06PM +0200, David Härdeman wrote: > Obvious fix, leave repeat handling to rc-core > > Signed-off-by: David Härdeman > --- > drivers/media/rc/ir-nec-decoder.c | 10 +++--- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/media/rc/ir-n

Re: [PATCH 4/7] rc-core: sanyo - leave the internals of rc_dev alone

On Mon, May 01, 2017 at 06:10:12PM +0200, David Härdeman wrote: > Leave repeat handling to rc-core. > > Signed-off-by: David Härdeman > --- > drivers/media/rc/ir-sanyo-decoder.c | 10 +++--- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/media/rc/ir-sanyo-decod

Re: [PATCH 5/7] rc-core: ir-raw - leave the internals of rc_dev alone

> type |= IR_START_EVENT; So this is just a fail-safe to ensure that the IR decoders are reset after a period of IR silence. The decoders should reset themselves anyway if they receive a long space, so it's just belt and braces. Why is a static value better? At least REP_DELAY can be changed from user space. Maybe we should do away with it. Sean > else > ev.duration = delta;

Re: [[media] sir_ir] 592ddc9f7d: BUG: unable to handle kernel NULL pointer dereference at 00000000000005b8

bf9ffdfd93d8d5d548e48 > Author: Sean Young > AuthorDate: Tue May 16 04:56:14 2017 -0300 > Commit: Mauro Carvalho Chehab > CommitDate: Thu May 18 06:16:41 2017 -0300 > > [media] sir_ir: infinite loop in interrupt handler > > Since this driver does no detecti

[PATCH] [media] rc-core: race condition before rc_register_device()

A rc device can call ir_raw_event_handle() after rc_allocate_device(), but before rc_register_device() has completed. This is racey because rcdev->raw is set before rcdev->raw->thread has a valid value. Reported-by: kbuild test robot Signed-off-by: Sean Young --- drivers/media/rc/rc

Re: [PATCH 03/16] lirc_dev: correct error handling

On Sun, May 28, 2017 at 10:23:37AM +0200, David Härdeman wrote: > On Sun, May 21, 2017 at 09:57:13AM +0100, Sean Young wrote: > >On Mon, May 01, 2017 at 06:03:51PM +0200, David Härdeman wrote: > >> If an error is generated, nonseekable_open() shouldn't be called. > > &

Re: [PATCH 13/16] lirc_dev: use an ida instead of a hand-rolled array to keep track of minors

On Sun, May 28, 2017 at 10:26:59AM +0200, David Härdeman wrote: > On Mon, May 22, 2017 at 09:09:42PM +0100, Sean Young wrote: > >On Mon, May 01, 2017 at 06:04:42PM +0200, David Härdeman wrote: > >> Using the kernel ida facilities, we can avoid a lot of unnecessary code &g

[PATCH] [media] rc-core: simplify ir_raw_event_store_edge()

There is no need to called ir_raw_event_reset() either after a long space or on startup. Many rc drivers never do this. Signed-off-by: Sean Young --- drivers/media/pci/saa7134/saa7134-input.c | 2 +- drivers/media/rc/gpio-ir-recv.c | 6 +++--- drivers/media/rc/img-ir/img-ir-raw.c

[GIT PULL FOR v4.13] RC fixes

Hi Mauro, Just minor cleanups and fixes this time round. Thanks, Sean The following changes since commit 36bcba973ad478042d1ffc6e89afd92e8bd17030: [media] mtk_vcodec_dec: return error at mtk_vdec_pic_info_update() (2017-05-19 07:12:05 -0300) are available in the git repository at: git

[GIT PULL FOR v4.12] RC race condition

Hi Mauro, Just a fix for an issue which the 0day robot found. I think the bug has always been present. Thanks Sean The following changes since commit dd8245f445f5e751b38126140b6ba1723f06c60b: [media] atomisp: don't treat warnings as errors (2017-05-18 05:44:00 -0300) are available i

[GIT PULL FOR v4.15] ids and RC timer API change

Hi Mauro, Here the timer updates and some IDs for mceusb and cx231xx. Thanks Sean The following changes since commit bbae615636155fa43a9b0fe0ea31c678984be864: media: staging: atomisp2: cleanup null check on memory allocation (2017-10-27 17:33:39 +0200) are available in the git repository

Re: 'LITE-ON USB2.0 DVB-T Tune' driver crash with kernel 4.13 / ubuntu 17.10

On Sun, Oct 29, 2017 at 06:54:28PM +0100, Laurent Caumont wrote: > Hi Sean, > > I recompiled the modules by following the > https://www.linuxtv.org/wiki/index.php/How_to_Obtain,_Build_and_Install_V4L-DVB_Device_Drivers > page and applied the patch. > But I still have proble

[PATCH 00/28] lirc scancode interface, and more

() - Fix a bug in kfifo on arm 32-bit - this inferface won't be used for cec remote control passthrough v4: - Rewrote zilog driver to send raw IR rather than codes from database - Minor ir-kbd-i2c improvements Sean Young (28): media: rc: i2c: set parent of rc device and improve name

[PATCH 02/28] media: rc: i2c: use dev_dbg rather hand-rolled debug

Use the dev_dbg dynamic infrastructure instead of rolling our own custom debug logic. Signed-off-by: Sean Young --- drivers/media/i2c/ir-kbd-i2c.c | 61 +- 1 file changed, 25 insertions(+), 36 deletions(-) diff --git a/drivers/media/i2c/ir-kbd-i2c.c b

[PATCH 03/28] media: rc: i2c: only poll if the rc device is opened

The lirc_zilog driver only polls the device if the lirc chardev is opened; do the same with the rc-core driver. Signed-off-by: Sean Young --- drivers/media/i2c/ir-kbd-i2c.c | 25 + 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/ir-kbd

[PATCH 01/28] media: rc: i2c: set parent of rc device and improve name

-0071/ir0 [ivtv i2c driver #0] Now we simply get: rc rc1: Hauppauge WinTV PVR-150 as /devices/pci:00/:00:1e.0/:02:00.0/i2c-10/10-0071/rc/rc1 Note that we no longer copy the name. I've checked all call sites to verfiy this is not a problem. Signed-off-by: Sean Young --- dr

[PATCH 04/28] media: merge ir_tx_z8f0811_haup and ir_rx_z8f0811_haup i2c devices

-off-by: Sean Young --- drivers/media/i2c/ir-kbd-i2c.c | 4 ++-- drivers/media/pci/cx18/cx18-cards.h | 8 +--- drivers/media/pci/cx18/cx18-i2c.c| 13 + drivers/media/pci/ivtv/ivtv-cards.h | 22 +++--- drivers/media/pci

[PATCH 06/28] media: i2c: enable i2c IR for hardware which isn't HD-PVR

ded, the i2c IR part of the HD-PVR will be enabled anyway. Fixes: 329d88da4df9 ("[media] media: i2c: Don't export ir-kbd-i2c module alias") Signed-off-by: Sean Young --- drivers/media/i2c/ir-kbd-i2c.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/media/i2c/ir

[PATCH 19/28] media: lirc: do not call rc_close() on unregistered devices

If a lirc chardev is held open after a device is unplugged, rc_close() will be called after rc_unregister_device(). The driver is not expecting any calls at this point, and the iguanair driver causes an oops in this scenario. Signed-off-by: Sean Young --- drivers/media/rc/rc-main.c | 2 +- 1

[PATCH 15/28] media: rc: document and fix rc_validate_scancode()

For some IR protocols, some scancode values not valid, i.e. they're part of a different protocol variant. Signed-off-by: Sean Young --- drivers/media/rc/rc-main.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/media/rc/rc-main.c b/drivers/

[PATCH 07/28] media: staging: remove lirc_zilog driver

through the mutex. The polling period is 402ms in the ir-kdb-i2c driver, and 260ms in the lirc_zilog driver. Signed-off-by: Sean Young --- drivers/staging/media/Kconfig |3 - drivers/staging/media/Makefile |1 - drivers/staging/media/lirc/Kconfig | 21 - drivers

[PATCH 10/28] media: lirc: implement scancode sending

be set to 0. Note that toggle (rc5, rc6) and repeats (nec) are not implemented. Nor is there a method for holding down a key for a period. Signed-off-by: Sean Young --- drivers/media/rc/ir-lirc-codec.c | 99 +--- drivers/media/rc/rc-core-priv.h | 2 +- incl

[PATCH 17/28] media: lirc: use kfifo rather than lirc_buffer for raw IR

Since the only mode lirc devices can handle is raw IR, handle this in a plain kfifo. Remove lirc_buffer since this is no longer needed. Signed-off-by: Sean Young --- drivers/media/rc/ir-lirc-codec.c | 79 +--- drivers/media/rc/lirc_dev.c | 199

[PATCH 11/28] media: lirc: use the correct carrier for scancode transmit

If the lirc device supports it, set the carrier for the protocol. Signed-off-by: Sean Young --- drivers/media/rc/ir-jvc-decoder.c | 1 + drivers/media/rc/ir-lirc-codec.c | 29 ++--- drivers/media/rc/ir-mce_kbd-decoder.c | 1 + drivers/media/rc/ir-nec-decoder.c

[PATCH 09/28] media: lirc: remove LIRCCODE and LIRC_GET_LENGTH

LIRCCODE is a lirc mode where a driver produces driver-dependent codes for receive and transmit. No driver uses this any more. The LIRC_GET_LENGTH ioctl was used for this mode only. Signed-off-by: Sean Young --- Documentation/media/lirc.h.rst.exceptions | 5 +++ Documentation/media

[PATCH 13/28] media: lirc: lirc interface should not be a raw decoder

other, so they've been merged into one module rc-core to avoid circular dependencies. Since ir-lirc-codec no longer exists as separate codec module, there is no need for RC_DRIVER_IR_RAW_TX type drivers to call ir_raw_event_register(). Signed-off-by: Sean Young --- drivers/media/rc/Kc

[PATCH 18/28] media: lirc: move lirc_dev->attached to rc_dev->registered

This is done to further remove the lirc kernel api. Ensure that every fops checks for this. Signed-off-by: Sean Young --- drivers/media/rc/ir-lirc-codec.c | 16 ++-- drivers/media/rc/lirc_dev.c | 4 +--- drivers/media/rc/rc-main.c | 8 include/media/lirc_dev.h

[PATCH 14/28] media: lirc: validate scancode for transmit

Ensure we reject an attempt to transmit invalid scancodes. Signed-off-by: Sean Young --- drivers/media/rc/ir-lirc-codec.c | 10 drivers/media/rc/rc-core-priv.h | 1 + drivers/media/rc/rc-main.c | 53 +--- 3 files changed, 44 insertions(+), 20

[PATCH 12/28] media: rc: auto load encoder if necessary

When sending scancodes, load the encoder if we need it. Signed-off-by: Sean Young --- drivers/media/rc/rc-core-priv.h | 1 + drivers/media/rc/rc-ir-raw.c| 2 ++ drivers/media/rc/rc-main.c | 2 +- 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/rc/rc-core

[PATCH 08/28] media: MAINTAINERS: remove lirc staging area

Now that lirc is no longer in the staging area, remove the entry. Signed-off-by: Sean Young --- MAINTAINERS | 6 -- 1 file changed, 6 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index adbf69306e9e..59c061d3d61a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -12712,12 +12712,6 @@ S

[PATCH 05/28] media: rc: implement zilog transmitter

new driver can send raw IR, but the hardware is limited o few different lengths of pulse and spaces, so it is best to use generated IR rather than recorded IR. Signed-off-by: Sean Young --- drivers/media/i2c/ir-kbd-i2c.c | 436 - include/media/i2c/ir-kbd

[PATCH 22/28] media: lirc: remove last remnants of lirc kapi

rc-core has replaced the lirc kapi many years ago, and now with the last driver ported to rc-core, we can finally remove it. Note this has no effect on userspace. All future IR drivers should use the rc-core api. Signed-off-by: Sean Young --- Documentation/media/kapi/rc-core.rst | 5

[PATCH 20/28] media: lirc: create rc-core open and close lirc functions

Replace the generic kernel lirc api with ones which use rc-core, further reducing the lirc_dev members. Signed-off-by: Sean Young --- drivers/media/rc/ir-lirc-codec.c | 59 -- drivers/media/rc/lirc_dev.c | 68 ++-- include

[PATCH 21/28] media: lirc: remove name from lirc_dev

This is a duplicate of rcdev->driver_name. Signed-off-by: Sean Young --- Documentation/media/uapi/rc/lirc-dev-intro.rst | 2 +- drivers/media/rc/ir-lirc-codec.c | 2 -- drivers/media/rc/lirc_dev.c| 9 +++-- include/media/lirc_dev.h

[PATCH 16/28] media: lirc: merge lirc_dev_fop_ioctl and ir_lirc_ioctl

Calculate lirc features when necessary, and add LIRC_{S,G}ET_REC_MODE cases to ir_lirc_ioctl. This makes lirc_dev_fop_ioctl() unnecessary since all cases are already handled by ir_lirc_ioctl(). Signed-off-by: Sean Young --- drivers/media/rc/ir-lirc-codec.c | 79

[PATCH 23/28] media: lirc: implement reading scancode

lags & LIRC_SCANCODE_FLAG_REPEAT)); } close(fd); } Signed-off-by: Sean Young --- drivers/media/rc/ir-lirc-codec.c | 102 +- drivers/media/rc/ir-mce_kbd-decoder.c | 5 ++ drivers/media/rc/lirc_dev.c | 13 + drivers/media/rc/rc-core-priv.h

[PATCH 24/28] media: rc: ensure lirc device receives nec repeats

The lirc device should get lirc repeats whether there is a keymap match or not. Signed-off-by: Sean Young --- drivers/media/rc/rc-main.c | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c

[PATCH 26/28] media: lirc: introduce LIRC_SET_POLL_MODES

printf("space %u\n", LIRC_VAL(sample))); if (LIRC_IS_PULSE(sample)) printf("pulse %u\n", LIRC_VAL(sample))); } } Note that LIRC_SET_REC_MODE will also affect the poll mode, so you must set it again before calling poll.

[PATCH 27/28] media: lirc: scancode rc devices should have a lirc device too

Now that the lirc interface supports scancodes, RC scancode devices can also have a lirc device. The only receiving feature they will have enabled is LIRC_CAN_REC_SCANCODE. Note that CEC devices have no lirc device, since they can be controlled from their /dev/cecN chardev. Signed-off-by: Sean

[PATCH 28/28] kfifo: DECLARE_KIFO_PTR(fifo, u64) does not work on arm 32 bit

returns EINVAL. So, ensure that __is_kfifo_ptr() compares to the right structure. Signed-off-by: Sean Young Acked-by: Stefani Seibold --- include/linux/kfifo.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/linux/kfifo.h b/include/linux/kfifo.h index 41eb6fdf87a8

[PATCH 25/28] media: lirc: document LIRC_MODE_SCANCODE

Lirc supports a new mode which requires documentation. Signed-off-by: Sean Young --- Documentation/media/lirc.h.rst.exceptions | 26 +++ Documentation/media/uapi/rc/lirc-dev-intro.rst | 51 +++--- Documentation/media/uapi/rc/lirc-get-features.rst | 16

Re: [PATCH] media: av7110: switch to useing timer_setup()

scancodes for the remote(s) are, for example. Any suggestions for what hardware to get off ebay for this? New patch will be reply this. Thanks, Sean

[PATCH] media: ttpci: remove autorepeat handling and use timer_setup

Leave the autorepeat handling up to the input layer, and move to the new timer API. Compile tested only. Signed-off-by: Sean Young --- drivers/media/pci/ttpci/av7110.h| 2 +- drivers/media/pci/ttpci/av7110_ir.c | 54 ++--- 2 files changed, 21 insertions

Re: [PATCH] media: ttpci: remove autorepeat handling and use timer_setup

Hi Dmitry, On Tue, Oct 31, 2017 at 11:22:36AM -0700, Dmitry Torokhov wrote: > Hi Sean, > > On Tue, Oct 31, 2017 at 05:45:58PM +0000, Sean Young wrote: > > Leave the autorepeat handling up to the input layer, and move > > to the new timer API. > > > > Compile te

[PATCH v2] media: ttpci: remove autorepeat handling and use timer_setup

Leave the autorepeat handling up to the input layer, and move to the new timer API. Compile tested only. Signed-off-by: Sean Young --- v2: - fixes and improvements from Dmitry Torokhov drivers/media/pci/ttpci/av7110.h| 2 +- drivers/media/pci/ttpci/av7110_ir.c | 56

[PATCH] media: rc: remove ir-rx51 in favour of generic pwm-ir-tx

the transmit completes. Cc: Ivaylo Dimitrov Cc: Pali Rohár Cc: Pavel Machek Cc: Timo Kokkonen Signed-off-by: Sean Young --- arch/arm/boot/dts/omap3-n900.dts | 2 +- drivers/media/rc/Kconfig | 10 -- drivers/media/rc/Makefile| 1 - drivers/media/rc/ir-rx51.c | 316

Re: [PATCH] media: rc: remove ir-rx51 in favour of generic pwm-ir-tx

On Wed, Nov 01, 2017 at 12:58:21PM +0100, Pali Rohár wrote: > On Wednesday 01 November 2017 11:55:33 Sean Young wrote: > > The ir-rx51 is a pwm-based TX driver specific to the n900. This can be > > handled entirely by the generic pwm-ir-tx driver. > > > > Note that the

[PATCH 3/5] media: lirc: allow lirc device to opened more than once

This makes it possible for lircd to read from a lirc chardev, and not keep it busy. Note that this changes the default for timeout reports to on. Signed-off-by: Sean Young --- drivers/media/rc/lirc_dev.c | 280 include/media/rc-core.h | 56

[PATCH 5/5] media: rc: iguanair: remove unnecessary locking

Since lirc now correctly locks the rcdev, this locking is no longer needed. Signed-off-by: Sean Young --- drivers/media/rc/iguanair.c | 28 1 file changed, 28 deletions(-) diff --git a/drivers/media/rc/iguanair.c b/drivers/media/rc/iguanair.c index 30e24da67226

[PATCH 0/5] lirc improvements

This patch series depend on the lirc scancode and lirc kapi removal series. This implements correct locking for lirc and allows the chardev to be opened more than once. Sean Young (5): media: rc: move ir-lirc-codec.c contents into lirc_dev.c media: rc: include rather than media: lirc

[PATCH 1/5] media: rc: move ir-lirc-codec.c contents into lirc_dev.c

Since removing the lirc kapi, ir-lirc-codec.c only contains lirc fops so the file name is no longer correct. By moving its content into lirc_dev.c the ugly extern struct lirc_fops is not longer needed, and everything lirc related is in one file. Signed-off-by: Sean Young --- drivers/media/rc

[PATCH 4/5] media: lirc: improve locking

Once rc_unregister_device() has been called, no driver function should be called. Signed-off-by: Sean Young --- drivers/media/rc/lirc_dev.c | 255 +--- 1 file changed, 147 insertions(+), 108 deletions(-) diff --git a/drivers/media/rc/lirc_dev.c b/drivers

[PATCH 2/5] media: rc: include rather than

This removes the need for include/media/lirc.h, which just includes the uapi file. Signed-off-by: Sean Young --- drivers/media/rc/lirc_dev.c | 2 +- include/media/lirc.h| 1 - 2 files changed, 1 insertion(+), 2 deletions(-) delete mode 100644 include/media/lirc.h diff --git a/drivers

Re: 'LITE-ON USB2.0 DVB-T Tune' driver crash with kernel 4.13 / ubuntu 17.10

Hi Laurent, Sorry about the delay, I forgot about this. :/ On Mon, Oct 30, 2017 at 09:59:34PM +0100, Laurent Caumont wrote: > Hi Sean, > > I found the problem. The read buffer needs to be allocated with kmalloc too. > > int dibusb_read_eeprom_byte(struct dvb_usb_device *d, u

Re: 'LITE-ON USB2.0 DVB-T Tune' driver crash with kernel 4.13 / ubuntu 17.10

f it's the way the > repository was created. The difference might be in the git index (or not in it). If you send a Signed-off-by: Laurent etc line then I'm happy to handle the patch generation. Thanks Sean

Re: 'LITE-ON USB2.0 DVB-T Tune' driver crash with kernel 4.13 / ubuntu 17.10

Hi Laurent, On Sat, Nov 11, 2017 at 06:53:54PM +0100, Laurent Caumont wrote: > Hi Sean, > > I just realized that files in media_build/linux/driver are not > associate with a git repository. They are retrieved by the build > command. > So, I cloned the linux-stable reposito

Re: 'LITE-ON USB2.0 DVB-T Tune' driver crash with kernel 4.13 / ubuntu 17.10

Hi Laurant, On Sat, Nov 11, 2017 at 08:06:38PM +0100, Laurent Caumont wrote: > Hi Sean, > > I hope this one will be okay. There is a memory leak in there, and there is no reason to have to kmallocs for this function. Please would you mind testing this version? Please note that there w

Re: 'LITE-ON USB2.0 DVB-T Tune' driver crash with kernel 4.13 / ubuntu 17.10

On Sun, Nov 12, 2017 at 09:38:47AM +0100, Laurent Caumont wrote: > Hi Sean, > > Thank you for the changes, It's better like this, I will test it. Great, thanks. Please let us know if it works, then it can be included. > Don't you think that a much better way would

Re: 4.14 regression from commit d57ea877af38 media: rc: per-protocol repeat period

On Thu, Nov 16, 2017 at 04:27:01PM +0100, Matthias Reichl wrote: > The following commit introduced a regression > > commit d57ea877af38057b0ef31758cf3b99765dc33695 > Author: Sean Young > Date: Wed Aug 9 13:19:16 2017 -0400 > > media: rc: per-protocol repeat period

[PATCH] media: rc: double keypresses due to timeout expiring to early

o, add the IR timeout to the keyup timeout. Cc: # 4.14 Reported-by: Matthias Reichl Signed-off-by: Sean Young --- drivers/media/rc/rc-main.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c index 17950e29d4e3..fa

Re: [PATCH] media: rc: double keypresses due to timeout expiring to early

On Fri, Nov 17, 2017 at 03:52:50PM +0100, Matthias Reichl wrote: > Hi Sean! > > On Thu, Nov 16, 2017 at 09:54:51PM +0000, Sean Young wrote: > > Since commit d57ea877af38 ("media: rc: per-protocol repeat period"), > > double keypresses are reported on the ite-

Re: [PATCH 2/6] media: rc keymaps: add SPDX identifiers to the code I wrote

- * > - * This program is free software; you can redistribute it and/or modify > - * it under the terms of the GNU General Public License as published by > - * the Free Software Foundation; either version 2 of the License, or > - * (at your option) any later version. This says GPLv2 or hi

[PATCH] media: imon: auto-config ffdc 30 device

Another device with the 0xffdc device id, this one with 0x30 in the config byte. Its an iMON VFD + iMON IR (it does not understand rc6). Signed-off-by: Sean Young --- drivers/media/rc/imon.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/rc/imon.c b/drivers/media/rc/imon.c

Re: 'LITE-ON USB2.0 DVB-T Tune' driver crash with kernel 4.13 / ubuntu 17.10

Hi Laurent, On Sun, Nov 12, 2017 at 09:38:47AM +0100, Laurent Caumont wrote: > Thank you for the changes, It's better like this, I will test it. Just wondering if you have had the time to test this patch. It would be great if it could be included after being tested. Thanks, Sean

[GIT FIXES FOR v4.15] RC repeat and DVB fix

Hi Mauro, Here are two fixes which would be nice to have in v4.15. I am working on a better rework of the repeat stuff (including moving cec repeats into rc-core), but it is far too much change for v4.15 or the stable tree. Thanks, Sean The following changes since commit

[PATCH 1/3] input: remove redundant check for EV_REP

The caller input_pass_values has already checked this bit. Signed-off-by: Sean Young --- drivers/input/input.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/input/input.c b/drivers/input/input.c index 762bfb9487dc..ecc41d65b82a 100644 --- a/drivers/input/input.c

[PATCH 0/3] Improve CEC autorepeat handling

the first keydown, to prevent autorepeat. Sean Young (3): input: remove redundant check for EV_REP input: handle case whether first repeated key triggers repeat media: cec: move cec autorepeat handling to rc-core Documentation/input/input.rst | 4 +++- drivers/input/input.c | 21

[PATCH 2/3] input: handle case whether first repeated key triggers repeat

In the CEC protocol, as soon as the first repeated key is received, the autorepeat should start. We introduce a special value 3 for this situation. Signed-off-by: Sean Young --- Documentation/input/input.rst | 4 +++- drivers/input/input.c | 17 +++-- 2 files changed, 18

[PATCH 3/3] media: cec: move cec autorepeat handling to rc-core

starting. See commit a9a249a2c997 ("media: cec: fix remote control passthrough") for the original change. Signed-off-by: Sean Young --- drivers/media/cec/cec-adap.c | 56 drivers/media/cec/cec-core.c | 12 -- drivers/media/rc/rc-mai

Re: [PATCH 0/3] Improve CEC autorepeat handling

Hi Hans, On Mon, Nov 27, 2017 at 10:13:51AM +0100, Hans Verkuil wrote: > On 11/26/2017 12:47 AM, Dmitry Torokhov wrote: > > On Fri, Nov 24, 2017 at 11:43:58AM +0000, Sean Young wrote: > >> Due to the slowness of the CEC bus, autorepeat handling rather special > >> o

[GIT PULL FOR v4.16] RC changes

lirc device can be opened more than once. - Line count is down 1500 and code is cleaner. Thanks, Sean The following changes since commit 04226916d2360f56d57ad00bc48d2d1854d1e0b0: media: usbtv: add a new usbid (2017-11-27 14:49:18 -0500) are available in the Git repository at: git

[PATCH 1/2] keytable: fail more gracefully when commandline cannot be parsed

KNOWN is not correct and it should exit on parse failures. Signed-off-by: Sean Young --- utils/keytable/keytable.c | 33 ++--- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/utils/keytable/keytable.c b/utils/keytable/keytable.c index 64db7703..4c1e864

[PATCH 2/2] keytable: allow a period or delay of 0 to be set

If both period or delay are zero, then autorepeat is turned off. Signed-off-by: Sean Young --- utils/keytable/keytable.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/utils/keytable/keytable.c b/utils/keytable/keytable.c index 4c1e8641..988e9857

Re: [PATCH Resend] staging: media: lirc: style fix - replace hard-coded function names

re-written. https://patchwork.linuxtv.org/patch/45189/ It hasn't been merged yet, but I suspect that is imminent. Sean > @@ -888,9 +888,9 @@ static ssize_t read(struct file *filep, char __user > *outbuf, size_t n, > unsigned int m; > DECLARE_WAITQUEUE(wait, curren

Re: [BUG] ir-ctl: error sending file with multiple scancodes

Hi Matthias, On Wed, Nov 29, 2017 at 03:44:00PM +0100, Matthias Reichl wrote: > Hi Sean! > > According to the ir-ctl manpage it should be possible to send a file > containing multiple scancodes, but when trying to do this I get > a warning and an error message. > > I init

[PATCH 1/2] ir-ctl: fix multiple scancodes in one file

A file with contents: scancode sony12:0x100015 space 25000 scancode sony12:0x100015 Will produce bogus results. Reported-by: Matthias Reichl Signed-off-by: Sean Young --- utils/ir-ctl/ir-ctl.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/utils/ir-ctl/ir-ctl.c b

[PATCH 2/2] ir-ctl: specify the gap between scancodes or files

When sending multiple scancodes, or pulse space files, by default there is 125ms gap between them. Allow this to be specified. Signed-off-by: Sean Young --- utils/ir-ctl/ir-ctl.1.in | 5 + utils/ir-ctl/ir-ctl.c| 18 +- 2 files changed, 18 insertions(+), 5 deletions

Re: [BUG] ir-ctl: error sending file with multiple scancodes

Hi Matthias, On Thu, Nov 30, 2017 at 04:34:33PM +0100, Matthias Reichl wrote: > Hi Sean, > > On Wed, Nov 29, 2017 at 08:05:21PM +0000, Sean Young wrote: > > On Wed, Nov 29, 2017 at 03:44:00PM +0100, Matthias Reichl wrote: > > > The goal I'm trying to achieve is to s

Re: [PATCH v4 06/12] [media] cxd2880: Add integration layer for the driver

On Fri, Oct 13, 2017 at 03:08:34PM +0900, yasunari.takigu...@sony.com wrote: > From: Yasunari Takiguchi > > These functions monitor the driver and watch for task completion. > This is part of the Sony CXD2880 DVB-T2/T tuner + demodulator driver. > > Signed-off-by: Yasunari Takiguchi > Signed-of

Re: [PATCH v4 07/12] [media] cxd2880: Add top level of the driver

the driver looks very good, and is ready for merging except for the minor things listed. Thank you for your submission. Regards, Sean On Fri, Oct 13, 2017 at 03:09:34PM +0900, yasunari.takigu...@sony.com wrote: > From: Yasunari Takiguchi > > This provides the main dvb frontend

Re: [bug report] media: lirc: improve locking

On Wed, Dec 13, 2017 at 01:07:31PM +0300, Dan Carpenter wrote: > Hello Sean Young, > > The patch 131fd7fc3c01: "media: lirc: improve locking" from Nov 4, > 2017, leads to the following static checker warning: > > drivers/media/rc/lirc_dev.c:373 ir_lirc_transmi

[PATCH 02/10] media: rc: mce_kbd: simplify key up

For key up, rather than iterating over 224 keys, just remember which key was pressed. Signed-off-by: Sean Young --- drivers/media/rc/ir-mce_kbd-decoder.c | 23 ++- drivers/media/rc/rc-core-priv.h | 1 + 2 files changed, 15 insertions(+), 9 deletions(-) diff --git a

[PATCH 10/10] media: ir-spi: add SPDX identifier

From: Andi Shyti Replace the original license statement with the SPDX identifier. Update also the copyright owner adding myself as co-owner of the copyright. Signed-off-by: Andi Shyti Signed-off-by: Sean Young --- drivers/media/rc/ir-spi.c | 15 +-- 1 file changed, 5 insertions

[PATCH 09/10] media: lirc: release lock before sleep

There is no reason to hold the lock while we wait for the IR to transmit. Reported-by: Dan Carpenter Signed-off-by: Sean Young --- drivers/media/rc/lirc_dev.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/media/rc/lirc_dev.c b/drivers/media/rc/lirc_dev.c

[PATCH 06/10] media: rc: iguanair: simplify tx loop

Signed-off-by: Sean Young --- drivers/media/rc/iguanair.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/drivers/media/rc/iguanair.c b/drivers/media/rc/iguanair.c index 30e24da67226..7daac8bab83b 100644 --- a/drivers/media/rc/iguanair.c +++ b/drivers

[PATCH 07/10] media: lirc: do not pass ERR_PTR to kfree

If memdup_user() fails, txbuf will be an error pointer and passed to kfree. Reported-by: Dan Carpenter Signed-off-by: Sean Young --- drivers/media/rc/lirc_dev.c | 35 ++- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/drivers/media/rc/lirc_dev.c

[PATCH 08/10] media: lirc: no need to recalculate duration

This is code existed for when drivers would send less than the whole buffer; no driver does this any more, so this is redundant. Drivers should return -EINVAL if they cannot send the entire buffer. Signed-off-by: Sean Young --- drivers/media/rc/lirc_dev.c | 10 +- 1 file changed, 1

[PATCH 01/10] media: imon: auto-config ffdc 26 device

Another device with the 0xffdc device id, this one with 0x26 in the config byte. Its an iMON Inside + iMON IR. It does respond to rc-6, but seems to produce random garbage rather than a scancode. Signed-off-by: Sean Young --- drivers/media/rc/imon.c | 5 + 1 file changed, 5 insertions

[PATCH 05/10] media: lirc: when transmitting scancodes, block until transmit is done

of milliseconds, and then send a repeat message. It turns out that for transmitting scancodes this feature is even more useful, as user space has no idea how long the IR is. So, maintain the existing semantics for IR scancode transmit. Signed-off-by: Sean Young --- Documentation/media/uapi/rc

[PATCH 04/10] media: rc: bang in ir_do_keyup

89 f1 ff ff 85 c0 79 0e f3 90 48 89 df e8 7b Fixes: b2c96ba352b5 ("media: cec: move cec autorepeat handling to rc-core") Signed-off-by: Sean Young --- drivers/media/rc/rc-main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/rc/rc-main.c b/driver

[PATCH 03/10] media: imon: remove unused function tv2int

Since commit 9c7fd60e951d ("media: rc: Replace timeval with ktime_t in imon.c"), the function tv2int() is no longer used. Remove it. Signed-off-by: Sean Young --- drivers/media/rc/imon.c | 23 --- 1 file changed, 23 deletions(-) diff --git a/drivers/media/r

[PATCH] DVB USB should not depend on RC

input which also has dependants. This can save a reasonable amount of memory: $ ./scripts/bloat-o-meter vmlinux vmlinux-no-rc add/remove: 0/909 grow/shrink: 1/20 up/down: 4/-159171 (-159167) Diff against current mainline. Signed-off-by: Sean Young --- diff --git a/drivers/media/dvb/dvb-usb

Re: IR raw input is not sutable for input system

ot enforce this "policy". In the past I've spent time dissecting the IR output of a strange remote, I would hate to think this would not be possible due to mad kernel interfaces which cater just for drooling in front of the telly with your *new* remote. Sean -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] saa7134 can capture 720x480 when capturing NTSC

in Windows. Tested on an AverMedia GO 007 FM Plus. Signed-off-by: Sean Young -- diff --git a/drivers/media/video/saa7134/saa7134-video.c b/drivers/media/video/saa7134/saa7134-video.c index cb73264..31138d3 100644 --- a/drivers/media/video/saa7134/saa7134-video.c +++ b/drivers/media/video/saa7134

[PATCH 2/5] [media] rc: add feedback led trigger for rc keypresses

Many devices with an ir receiver also have a feedback led. Add the led trigger to support this. Signed-off-by: Sean Young --- drivers/media/rc/rc-main.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c index 1cf382a..628ac2a

[PATCH 3/5] [media] ttusbir: wire up rc feedback led

Signed-off-by: Sean Young --- drivers/media/rc/ttusbir.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/rc/ttusbir.c b/drivers/media/rc/ttusbir.c index 891762d..d8de205 100644 --- a/drivers/media/rc/ttusbir.c +++ b/drivers/media/rc/ttusbir.c @@ -302,6 +302,7 @@ static int

[PATCH 5/5] [media] redrat3: wire up rc feedback led

Signed-off-by: Sean Young --- drivers/media/rc/Kconfig | 2 ++ drivers/media/rc/redrat3.c | 83 -- 2 files changed, 82 insertions(+), 3 deletions(-) diff --git a/drivers/media/rc/Kconfig b/drivers/media/rc/Kconfig index 7fa6b22..11e84bc 100644

[PATCH 4/5] [media] winbond: wire up rc feedback led

Note that with the rc-feedback trigger, the cir-rx trigger is now redundant. The cir-tx trigger is not used by default; if this functionality is desired then it should exist in rc-core, not in a driver. Also make sure that the led is suspended on suspend. Signed-off-by: Sean Young --- drivers

<    5   6   7   8   9   10   11   12   13   >