Re: [PATCH v2 0/2] Fix potential buffer overrun root cause

2018-05-15 Thread Simon Horman
s a correct one > in 2/2. I think this should be picked up for v4.18. > > * Changes since v1 > - Add commit message to 1/2. > > Niklas Söderlund (2): > Revert "media: rcar-vin: enable field toggle after a set number of > lines for Gen3" > rcar-vin: fix crop and compose handling for Gen3 Reviewed-by: Simon Horman <horms+rene...@verge.net.au>

Re: [PATCH] media: dt-bindings: media: rcar_vin: add support for r8a77965

2018-05-15 Thread Simon Horman
On Sun, May 13, 2018 at 08:58:18PM +0200, Niklas Söderlund wrote: > Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Simon Horman <horms+rene...@verge.net.au>

[PATCH] media: rcar-vin: Drop unnecessary register properties from example vin port

2018-05-09 Thread Simon Horman
The example vin port node does not have an address and thus does not need address-cells or address size-properties. Signed-off-by: Simon Horman <horms+rene...@verge.net.au> --- Documentation/devicetree/bindings/media/rcar_vin.txt | 3 --- 1 file changed, 3 deletions(-) diff

Re: [PATCH v2 2/2] ARM: dts: r8a7740: Add CEU0

2018-05-08 Thread Simon Horman
On Thu, Apr 26, 2018 at 08:24:43PM +0200, Jacopo Mondi wrote: > Describe CEU0 peripheral for Renesas R-Mobile A1 R8A7740 Soc. > > Reported-by: Geert Uytterhoeven > Signed-off-by: Jacopo Mondi Thanks, applied.

Re: [PATCH v2 2/2] ARM: dts: r8a7740: Add CEU0

2018-05-16 Thread Simon Horman
On Wed, May 16, 2018 at 09:40:09AM +0200, Geert Uytterhoeven wrote: > Hi Jacopo, > > On Thu, Apr 26, 2018 at 8:24 PM, Jacopo Mondi > wrote: > > Describe CEU0 peripheral for Renesas R-Mobile A1 R8A7740 Soc. > > > > Reported-by: Geert Uytterhoeven > >

Re: [PATCH v2] v4l: vsp1: Fix vsp1_regs.h license header

2018-05-22 Thread Simon Horman
On Sun, May 20, 2018 at 10:24:37AM +0300, Laurent Pinchart wrote: > All source files of the vsp1 driver are licensed under the GPLv2+ except > for vsp1_regs.h which is licensed under GPLv2. This is caused by a bad > copy that dates back from the initial version of the driver. Fix > it. > > Cc:

Re: [PATCH v2] v4l: vsp1: Fix vsp1_regs.h license header

2018-05-23 Thread Simon Horman
On Tue, May 22, 2018 at 01:04:56PM +0200, Geert Uytterhoeven wrote: > Hi Simon, > > On Tue, May 22, 2018 at 11:05 AM, Simon Horman <ho...@verge.net.au> wrote: > >> --- a/drivers/media/platform/vsp1/vsp1_regs.h > >> +++ b/drivers/media/platform/vsp1/vsp1_regs.h &

Re: [PATCH v2] v4l: vsp1: Fix vsp1_regs.h license header

2018-05-23 Thread Simon Horman
On Wed, May 23, 2018 at 11:37:47AM +0300, Laurent Pinchart wrote: > Hi Simon, > > On Wednesday, 23 May 2018 11:33:26 EEST Simon Horman wrote: > > On Tue, May 22, 2018 at 01:04:56PM +0200, Geert Uytterhoeven wrote: > > > On Tue, May 22, 2018 at 11:05 AM, Simon Horman &l

Re: [PATCH] media: dt-bindings: media: rcar_vin: add support for r8a77965

2018-05-23 Thread Simon Horman
On Sun, May 13, 2018 at 08:58:18PM +0200, Niklas Söderlund wrote: > Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Simon Horman <horms+rene...@verge.net.au> > --- > Documentation/devicetree/bindings/media/rcar_vin.txt | 1 + > 1 f

Re: [PATCH 5/6] ARM: dts: rcar-gen2: Remove unused VIN properties

2018-05-22 Thread Simon Horman
On Thu, May 17, 2018 at 11:01:10AM +0200, jacopo mondi wrote: > Hi Niklas, > > On Thu, May 17, 2018 at 12:13:07AM +0200, Niklas Söderlund wrote: > > Hi Jacopo, > > > > Thanks for your work. > > > > On 2018-05-16 18:32:31 +0200, Jacopo Mondi wrote: > > > The 'bus-width' and 'pclk-sample'

Re: [PATCH 2/2] ARM: dts: r8a7740: Enable CEU0

2018-04-26 Thread Simon Horman
Thanks Jacopo, I'm very pleased to see this series. On Wed, Apr 25, 2018 at 01:15:20PM +0200, Jacopo Mondi wrote: > Enable CEU0 peripheral for Renesas R-Mobile A1 R8A7740. Given 'status = "disabled"' below I think you are describing but not enabling CEU0. Also in the subject. Should we also

Re: [PATCH] rcar-vin: remove generic gen3 compatible string

2018-04-26 Thread Simon Horman
function. > Remove it before it is added to any device tree descriptions. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Simon Horman <horms+rene...@verge.net.au> > --- > Documentation/devicetree/bindings/media/rcar_vin.txt | 1 - &g

Re: [PATCH] rcar-vin: fix null pointer dereference in rvin_group_get()

2018-04-26 Thread Simon Horman
On Wed, Apr 25, 2018 at 01:45:06AM +0200, Niklas Söderlund wrote: > Store the group pointer before disassociating the VIN from the group. > > Fixes: 3bb4c3bc85bf77a7 ("media: rcar-vin: add group allocator functions") > Reported-by: Colin Ian King > Signed-off-by: Niklas

Re: [PATCH 2/2] ARM: dts: r8a7740: Enable CEU0

2018-04-26 Thread Simon Horman
On Thu, Apr 26, 2018 at 09:26:09AM +0200, jacopo mondi wrote: > Hi Simon, > > On Thu, Apr 26, 2018 at 08:11:30AM +0200, Simon Horman wrote: > > Thanks Jacopo, > > > > I'm very pleased to see this series. > > Credits to Geert that pointed out to me R-Mobile A1 com

Re: [PATCH v2 1/2] dt-bindings: media: renesas-ceu: Add R-Mobile R8A7740

2018-04-30 Thread Simon Horman
On Thu, Apr 26, 2018 at 08:24:42PM +0200, Jacopo Mondi wrote: > Add R-Mobile A1 R8A7740 SoC to the list of compatible values for the CEU > unit. > > Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> Reviewed-by: Simon Horman <horms+rene...@verge.net.au> > ---

Re: [PATCH] rcar-vin: fix null pointer dereference in rvin_group_get()

2018-04-30 Thread Simon Horman
On Thu, Apr 26, 2018 at 05:20:05PM +0200, Niklas Söderlund wrote: > Hi Simon, > > Thanks for your feedback. > > On 2018-04-25 09:18:51 +0200, Simon Horman wrote: > > On Wed, Apr 25, 2018 at 01:45:06AM +0200, Niklas Söderlund wrote: > > > Store the group pointer befo

Re: [PATCH v3 4/9] ARM: dts: r7s72100: Add Capture Engine Unit (CEU)

2018-01-04 Thread Simon Horman
On Thu, Jan 04, 2018 at 05:03:12PM +0100, Jacopo Mondi wrote: > Add Capture Engine Unit (CEU) node to device tree. > > Signed-off-by: Jacopo Mondi > Reviewed-by: Geert Uytterhoeven > Reviewed-by: Laurent Pinchart

Re: [PATCH v4 1/9] dt-bindings: media: Add Renesas CEU bindings

2018-01-11 Thread Simon Horman
On Fri, Jan 12, 2018 at 12:50:41AM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > On Tuesday, 9 January 2018 18:25:23 EET Jacopo Mondi wrote: > > Add bindings documentation for Renesas Capture Engine Unit (CEU). > > > > Signed-off-by: Jacopo Mondi

Re: [PATCH v11 04/10] ARM: dts: r7s72100: Add Capture Engine Unit (CEU)

2018-02-23 Thread Simon Horman
On Thu, Feb 22, 2018 at 11:37:20AM +0100, Jacopo Mondi wrote: > Add Capture Engine Unit (CEU) node to device tree. > > Signed-off-by: Jacopo Mondi > Reviewed-by: Geert Uytterhoeven > Reviewed-by: Laurent Pinchart

Re: [PATCH v10 04/10] ARM: dts: r7s72100: Add Capture Engine Unit (CEU)

2018-02-21 Thread Simon Horman
On Wed, Feb 21, 2018 at 06:47:58PM +0100, Jacopo Mondi wrote: > Add Capture Engine Unit (CEU) node to device tree. > > Signed-off-by: Jacopo Mondi > Reviewed-by: Geert Uytterhoeven > Reviewed-by: Laurent Pinchart

Re: [PATCH] media: renesas-ceu: mark PM functions as __maybe_unused

2018-03-01 Thread Simon Horman
time_resume(struct device *dev) > ^~ > > This adds a __maybe_unused annotation to shut up the warning. > > Fixes: 32e5a70dc8f4 ("media: platform: Add Renesas CEU driver") > Signed-off-by: Arnd Bergmann <a...@arndb.de> Reviewed-by: Simon Horman <horms+rene...@verge.net.au>

Re: [PATCH] media: platform: Drop OF dependency of VIDEO_RENESAS_VSP1

2018-03-07 Thread Simon Horman
On Tue, Mar 06, 2018 at 01:37:38PM -0300, Mauro Carvalho Chehab wrote: > Em Tue, 06 Mar 2018 18:35:32 +0200 > Laurent Pinchart escreveu: > > > Hi Mauro, > > > > On Tuesday, 6 March 2018 18:25:15 EET Mauro Carvalho Chehab wrote: > > > Em Mon, 26 Feb 2018

Re: [PATCH] media: entity: fix spelling for media_entity_get_fwnode_pad()

2018-04-09 Thread Simon Horman
> Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Simon Horman <horms+rene...@verge.net.au>

Re: [PATCH 2/8] dmaengine: shdmac: Change platform check to CONFIG_ARCH_RENESAS

2018-04-23 Thread Simon Horman
remaining #ifdefs. > > This will allow to drop ARCH_SHMOBILE on ARM in the near future. > > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Reviewed-by: Simon Horman <horms+rene...@verge.net.au>

Re: [PATCH 1/8] arm: shmobile: Change platform dependency to ARCH_RENESAS

2018-04-23 Thread Simon Horman
On Fri, Apr 20, 2018 at 05:53:18PM +0300, Sergei Shtylyov wrote: > On 04/20/2018 04:28 PM, Geert Uytterhoeven wrote: > > > Since commit 9b5ba0df4ea4f940 ("ARM: shmobile: Introduce ARCH_RENESAS") > > is ARCH_RENESAS a more appropriate platform dependency than the legacy > >"ARCH_RENESAS is",

Re: [PATCH 6/8] ASoC: sh: Update menu title and platform dependency

2018-04-23 Thread Simon Horman
in the near > future. > > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Reviewed-by: Simon Horman <horms+rene...@verge.net.au>

Re: [PATCH 5/8] staging: emxx_udc: Change platform dependency to ARCH_RENESAS

2018-04-23 Thread Simon Horman
ce use the > former. > > This will allow to drop ARCH_SHMOBILE on ARM in the near future. > > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Reviewed-by: Simon Horman <horms+rene...@verge.net.au>

Re: [PATCH/RFC 7/8] ARM: shmobile: Remove the ARCH_SHMOBILE Kconfig symbol

2018-04-23 Thread Simon Horman
On Fri, Apr 20, 2018 at 03:28:33PM +0200, Geert Uytterhoeven wrote: > All drivers for Renesas ARM SoCs have gained proper ARCH_RENESAS > platform dependencies. Hence finish the conversion from ARCH_SHMOBILE > to ARCH_RENESAS for Renesas 32-bit ARM SoCs, as started by commit > 9b5ba0df4ea4f940

Re: [PATCH 4/8] sh_eth: Change platform check to CONFIG_ARCH_RENESAS

2018-04-23 Thread Simon Horman
sas SuperH SH-Mobile SoCs are still covered by the CONFIG_CPU_SH4 > check. > > This will allow to drop ARCH_SHMOBILE on ARM and ARM64 in the near > future. > > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Reviewed-by: Simon Horman <horms+rene...@verge.net.au>

Re: [PATCH 3/8] [media] v4l: rcar_fdp1: Change platform dependency to ARCH_RENESAS

2018-04-23 Thread Simon Horman
y > than the legacy ARCH_SHMOBILE, hence use the former. > > This will allow to drop ARCH_SHMOBILE on ARM and ARM64 in the near > future. > > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Reviewed-by: Simon Horman <horms+rene...@verge.net.au>

Re: [PATCH/RFC 7/8] ARM: shmobile: Remove the ARCH_SHMOBILE Kconfig symbol

2018-04-23 Thread Simon Horman
On Fri, Apr 20, 2018 at 03:28:33PM +0200, Geert Uytterhoeven wrote: > All drivers for Renesas ARM SoCs have gained proper ARCH_RENESAS > platform dependencies. Hence finish the conversion from ARCH_SHMOBILE > to ARCH_RENESAS for Renesas 32-bit ARM SoCs, as started by commit > 9b5ba0df4ea4f940

Re: [PATCH 4/8] arm64: dts: renesas: eagle: Add thc63 LVDS map

2018-04-23 Thread Simon Horman
On Thu, Apr 19, 2018 at 11:31:05AM +0200, Jacopo Mondi wrote: > Add LVDS map mode description property to THC63LVD1024 LVDS decoder in > R-Car V3M-Eagle board device tree. > > Signed-off-by: Jacopo Mondi Hi Jacopo, it looks like there has been a request to change

Re: [PATCH v10 04/10] ARM: dts: r7s72100: Add Capture Engine Unit (CEU)

2018-04-24 Thread Simon Horman
On Mon, Apr 23, 2018 at 05:21:43PM +0200, jacopo mondi wrote: > Hi Simon, > > On Wed, Feb 21, 2018 at 07:29:18PM +0100, Simon Horman wrote: > > On Wed, Feb 21, 2018 at 06:47:58PM +0100, Jacopo Mondi wrote: > > > Add Capture Engine Unit (CEU) node to device tree. > >

Re: [PATCH v6] ARM: dts: wheat: Fix ADV7513 address usage

2018-03-27 Thread Simon Horman
On Mon, Mar 26, 2018 at 10:04:24AM +0100, Kieran Bingham wrote: > Hi Simon, > > On 26/03/18 09:31, Simon Horman wrote: > > On Fri, Mar 23, 2018 at 09:16:13PM +, Kieran Bingham wrote: > >> Hi Simon, > >> > >> On 23/03/18 08:51, Simon Horman wrote: >

Re: [PATCH v6] ARM: dts: wheat: Fix ADV7513 address usage

2018-03-26 Thread Simon Horman
On Fri, Mar 23, 2018 at 09:16:13PM +, Kieran Bingham wrote: > Hi Simon, > > On 23/03/18 08:51, Simon Horman wrote: > > On Thu, Mar 22, 2018 at 09:30:40PM +, Kieran Bingham wrote: > >> The r8a7792 Wheat board has two ADV7513 devices sharing a single I2C > >&g

Re: [PATCH v6] ARM: dts: wheat: Fix ADV7513 address usage

2018-03-23 Thread Simon Horman
On Thu, Mar 22, 2018 at 09:30:40PM +, Kieran Bingham wrote: > The r8a7792 Wheat board has two ADV7513 devices sharing a single I2C > bus, however in low power mode the ADV7513 will reset it's slave maps to > use the hardware defined default addresses. > > The ADV7511 driver was adapted to

Re: [PATCH] dt-bindings: media: rcar_vin: Use status "okay"

2018-03-19 Thread Simon Horman
On Sun, Mar 18, 2018 at 07:47:57AM -0500, Rob Herring wrote: > On Fri, Mar 09, 2018 at 10:34:40AM +0100, Geert Uytterhoeven wrote: > > According to the Devicetree Specification, "ok" is not a valid status. > > Correct. > > > Fixes: 47c71bd61b772cd7 ("[media] rcar_vin: add devicetree support") >

Re: [PATCH] media: platform: Drop OF dependency of VIDEO_RENESAS_VSP1

2018-02-27 Thread Simon Horman
that ARCH_RENESAS depends on ARCH_MULTI_V7, which in turn depends on ARCH_MULTIPLATFORM which selects OF via USE_OF Reviewed-by: Simon Horman <horms+rene...@verge.net.au>

<    1   2