Re: [PATCH v2 53/58] firewire: don't break long lines

2016-10-19 Thread Stefan Richter
printing. [...] > Stefan, > > Would the above be OK for you? ACK. -- Stefan Richter -==- =-=- =-=-- http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 53/58] firewire: don't break long lines

2016-10-19 Thread Stefan Richter
s made to use dev_XYZ(). (On an unrelated note, this reminds me that I still need to take care of Mauro's patches "Add a keymap for FireDTV board" and "firedtv: Port it to use rc_core" from May 28, 2012.) -- Stefan Richter -==- =-=- =--== http://arcgraph.de/sr/ -- To unsubscribe

Re: [PATCH 03/57] [media] firewire: don't break long lines

2016-10-15 Thread Stefan Richter
strings at the source code. So, join those continuation > > lines. > > > > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> > > I prefer this patch because of the same reason in patch comment. > > Reviewed-by: Takashi Sakamoto <o-taka...@s

Re: [PATCH 00/57] don't break long lines on strings

2016-10-15 Thread Stefan Richter
On Oct 14 Mauro Carvalho Chehab wrote: > There are lots of drivers on media that breaks long line strings in order to > fit into 80 columns. This was an usual practice to make checkpatch happy. This was practice even before checkpatch existed. -- Stefan Richter -==- =-=- -===

Re: [PATCH 18/26] [media] dvb: Get rid of typedev usage for enums

2015-06-08 Thread Stefan Richter
On Jun 08 Mauro Carvalho Chehab wrote: The DVB API was originally defined using typedefs. This is against Kernel CodingStyle, and there's no good usage here. While we can't remove its usage on userspace, we can avoid its usage in Kernelspace. [...] Acked-by: Stefan Richter stef...@s5r6

Re: [PATCH] media:firewire:Remove unneeded function definition,avc_tuner_host2ca

2015-02-08 Thread Stefan Richter
; - ret = avc_write(fdtv); - - /* FIXME: check response code? */ - - mutex_unlock(fdtv-avc_mutex); - - return ret; -} -#endif - static int get_ca_object_pos(struct avc_response_frame *r) { int length = 1; -- Stefan Richter -=-= --=- -=--- http

Re: [PATCH] media:firewire:Remove unneeded function definition,avc_tuner_host2ca in firedtv-avc.c

2015-02-08 Thread Stefan Richter
On Feb 08 nick wrote: On 2015-02-08 06:55 PM, Stefan Richter wrote: I still am missing research on the question whether or not the Common Interface serving part of the driver needs to send Host2CA commands. If yes, we implement it and use the function. If not, we remove the function

Re: [PATCH] media:firewire:Remove unneeded function definition,avc_tuner_host2ca in firedtv-avc.c

2015-02-08 Thread Stefan Richter
get_ca_object_pos(struct avc_response_frame *r) { int length = 1; -- Stefan Richter -=-= --=- -=--= http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 1/1] [media] firewire: Deletion of an unnecessary check before the function call dvb_unregister_device

2014-11-20 Thread Stefan Richter
was detected by using the Coccinelle software. Signed-off-by: Markus Elfring elfr...@users.sourceforge.net Reviewed-by: Stefan Richter stef...@s5r6.in-berlin.de --- drivers/media/firewire/firedtv-ci.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/firewire

Re: [PATCH] [media] fix a warning on avr32 arch

2014-10-30 Thread Stefan Richter
, the signal is desired, as the isochannel var can be initalized with -1 inside the driver. So, change the type to s8, to avoid issues on archs where char is unsigned. Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com Reviewed-by: Stefan Richter stef...@s5r6.in-berlin.de diff

Re: [patch] [media] firewire: firedtv-avc: potential buffer overflow

2014-09-08 Thread Stefan Richter
On Sep 08 Dan Carpenter wrote: program_info_length is user controlled and can go up to 4095. The operand[] array has 509 bytes so we need to add a limit here to prevent buffer overflows. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Reviewed-by: Stefan Richter stef...@s5r6

Re: [patch] [media] firewire: firedtv-avc: potential buffer overflow

2014-09-08 Thread Stefan Richter
On Sep 08 Stefan Richter wrote: On Sep 08 Dan Carpenter wrote: program_info_length is user controlled and can go up to 4095. The operand[] array has 509 bytes so we need to add a limit here to prevent buffer overflows. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Reviewed

Re: [PATCH 2/3] femon: Display SNR in dB

2013-11-25 Thread Stefan Richter
On Nov 25 Stefan Richter wrote: On Nov 25 Jean Delvare wrote: Hi Manu, On Sun, 24 Nov 2013 22:51:33 +0530, Manu Abraham wrote: Sorry, that I came upon this patch quite late. No problem, better late than never! :) On Mon, Jun 3, 2013 at 8:51 PM, Jean Delvare kh...@linux-fr.org

Re: [PATCH 2/3] femon: Display SNR in dB

2013-11-25 Thread Stefan Richter
...). When I looked at that application and at kaffeine some years ago, they displayed grossly different values. I did not research back then whether the Linux driver or kaffeine or both treated it wrong. Any advice for the quoted kernel driver code? Thanks, -- Stefan Richter

Re: [PATCH] driver: firewire: remove unnecessary #if 0 code

2013-09-24 Thread Stefan Richter
should fix up this code for support of length 127, or can we just delete this #if 0 block? -- Stefan Richter -=-===-= =--= ==--- http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH] net: add ETH_P_802_3_MIN

2013-03-21 Thread Stefan Richter
some more users of this constant when adding MPLS support to Open vSwtich. As suggested by Jesse Gross. Compile tested only. Cc: Jesse Gross je...@nicira.com Cc: Stefan Richter stef...@s5r6.in-berlin.de Cc: Karsten Keil i...@linux-pingi.de Cc: Mauro Carvalho Chehab mche...@redhat.com Cc

[PATCH] firedtv: add MAINTAINERS entry

2012-11-03 Thread Stefan Richter
/firewire/ pattern and the FireWire media drivers title are currently synonymous with firedtv. If more drivers get added there, this can be revisited. I don't have documentation or DVB-S2 devices to test, but I have DVB-C and DVB-T devices for testing. Signed-off-by: Stefan Richter stef...@s5r6

Re: [RFC PATCH 0/3] Improve Kconfig selection for media devices

2012-05-28 Thread Stefan Richter
categories silently do select RC_CORE if INPUT for combined tuner + IR/RF rx/tx hardware? -- Stefan Richter -=-===-- -=-= ===-- http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [RFC PATCH 0/3] Improve Kconfig selection for media devices

2012-05-28 Thread Stefan Richter
On May 28 Mauro Carvalho Chehab wrote: Em 28-05-2012 06:48, Stefan Richter escreveu: c) The RC_CORE_SUPP help text gives the impression that RC core is always needed if there is hardware with an IR feature. But the firedtv driver is a case where the driver directly works on top

Re: [PATCH 2/2] [media] firedtv: Port it to use rc_core

2012-05-28 Thread Stefan Richter
On May 28 Stefan Richter wrote: + idev-phys = /ir0;/* FIXME */ Something similar to drivers/media/dvb/dvb-usb/dvb-usb-remote.c:: usb_make_path(d-udev, d-rc_phys, sizeof(d-rc_phys)); strlcat(d-rc_phys, /ir0, sizeof(d-rc_phys)); should be implemented

Re: [GIT PULL for v3.5-rc1] media updates for v3.5

2012-05-25 Thread Stefan Richter
# DVB-S (satellite) frontends # DVB-T (terrestrial) frontends # DVB-C (cable) frontends # SEC control devices for DVB-S # CONFIG_DVB_DUMMY_FE is not set -- Stefan Richter -=-===-- -=-= ==-=- http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body

Re: [PATCH 9/9] [media] firedtv: handle errors from dvb_net_init

2011-12-31 Thread Stefan Richter
-by: Stefan Richter stef...@s5r6.in-berlin.de [...] --- a/drivers/media/dvb/firewire/firedtv-dvb.c +++ b/drivers/media/dvb/firewire/firedtv-dvb.c @@ -203,7 +203,9 @@ int fdtv_dvb_register(struct firedtv *fdtv, const char *name) if (err) goto fail_rem_frontend; - dvb_net_init

Re: [PATCHv2 00/94] Only use DVBv5 internally on frontend drivers

2011-12-31 Thread Stefan Richter
. -- Stefan Richter -=-==-== ==-- = http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 4/14] staging/media/as102: checkpatch fixes

2011-10-31 Thread Stefan Richter
=svnbe3fa9125e708348c7baf04ebe9507a72a9d1800r=0cfd112032017ab68ed576f6bb5258452084ebf1 This converts the # User and # Date lines of HG patches into RFC 2822 From: and Date: lines which are then used as authorship metadata. -- Stefan Richter -=-==-== =-=- = http://arcgraph.de/sr/ -- To unsubscribe

Re: [PATCH v3 4/14] staging/media/as102: checkpatch fixes

2011-10-30 Thread Stefan Richter
increases the human- readability of the diff. Of course in this patch here which changes almost the entire file, this bit is not important for readability. But keep it in mind for future patch postings. -- Stefan Richter -=-==-== =-=- - http://arcgraph.de/sr/ -- To unsubscribe

Re: [RESEND PATCH 11/14] staging/media/as102: fix compile warning about unused function

2011-10-30 Thread Stefan Richter
such a cleanup in its scope. If the compat removal isn't already included later on in Piotr's series, it will be done later before this driver can be moved out of staging. -- Stefan Richter -=-==-== =-=- - http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line unsubscribe linux-media

Re: [RESEND PATCH 1/14] staging/media/as102: initial import from Abilis

2011-10-30 Thread Stefan Richter
else, the right thing to do is IMO to keep the special characters that the author chose and only make sure that the file (and the patch mailing) are UTF-8 encoded. -- Stefan Richter -=-==-== =-=- - http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line unsubscribe linux-media

Re: [PATCH 1/7] Staging submission: PCTV 74e driver (as102)

2011-10-16 Thread Stefan Richter
, but not many developers take the time to do so.) Again, thanks for the effort and also thanks to Devin for making it possible. -- Stefan Richter -=-==-== =-=- = http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord

Re: [RFCv2 PATCH 2/7] V4L menu: move legacy drivers into their own submenu.

2011-09-30 Thread Stefan Richter
several already existing menuconfigs in the video section which do not have these sentences; so maybe don't add the above, or add it separately across the board, or whatever. I find these sentences helpful when running make oldconfig or the likes. -- Stefan Richter -=-==-== =--= - http

Staging submission: PCTV 80e and PCTV 74e drivers (was Re: Problems cloning the git repostories)

2011-09-27 Thread Stefan Richter
, and then folks can work on mainline inclusion. (Somebody who actually has such a device might be most motivated to do it.) No need to get angry that it hasn't happened yet. :-) It's just a matter of the right people joining the effort at the right time. Thanks Devin for the offer, -- Stefan

Re: Staging submission: PCTV 80e and PCTV 74e drivers (was Re: Problems cloning the git repostories)

2011-09-27 Thread Stefan Richter
On Sep 27 Greg KH wrote: On Tue, Sep 27, 2011 at 09:44:09AM +0200, Stefan Richter wrote: Adding Cc: staging maintainer and mailinglist. On Sep 26 Devin Heitmueller wrote: On Sun, Sep 25, 2011 at 11:25 PM, Mauro Carvalho Chehab mauroche...@gmail.com wrote: In summary, if you don't

[PATCH] [media] firedtv: change some -EFAULT returns to more fitting error codes

2011-07-06 Thread Stefan Richter
returns of lower level I/O code where applicable, and -EACCES (permission denied) when a seemingly valid but negative FCP response or an unknown-to-firedtv CA message is received. Signed-off-by: Stefan Richter stef...@s5r6.in-berlin.de Cc: Henrik Kurelid hen...@kurelid.se --- Only tested on FireDTV-{C

[PATCH resend] [media] firedtv: change some -EFAULT returns to more fitting error codes

2011-07-06 Thread Stefan Richter
returns of lower level I/O code where applicable, and -EACCES (permission denied) when a seemingly valid but negative FCP response or an unknown-to-firedtv CA message is received. Signed-off-by: Stefan Richter stef...@s5r6.in-berlin.de Cc: Henrik Kurelid hen...@kurelid.se --- Resent, hopefully without

Re: [RFC] Don't use linux/version.h anymore to indicate a per-driver version - Was: Re: [PATCH 03/37] Remove unneeded version.h includes from include/

2011-06-24 Thread Stefan Richter
to learn it too; I certainly wasn't born with an instinct knowledge how to do it properly. (Disclaimer: I have no stake in drivers/media/ ABIs. But I am involved in maintaining a userspace ABI elsewhere in drivers/firewire/, and one of the userspace libraries that use this ABI.) -- Stefan Richter

Re: [RFC] Don't use linux/version.h anymore to indicate a per-driver version - Was: Re: [PATCH 03/37] Remove unneeded version.h includes from include/

2011-06-24 Thread Stefan Richter
to the uname(2) syscall. ¹) Yes, it is still an ABI version, nothing less. With all its backwards and forwards compatibility ramifications. -- Stefan Richter -=-==-== -==- ==--- http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message

Re: [RFC] Don't use linux/version.h anymore to indicate a per-driver version - Was: Re: [PATCH 03/37] Remove unneeded version.h includes from include/

2011-06-24 Thread Stefan Richter
code is not released within kernel source code. -- Stefan Richter -=-==-== -==- ==--- http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [RFC] Don't use linux/version.h anymore to indicate a per-driver version - Was: Re: [PATCH 03/37] Remove unneeded version.h includes from include/

2011-06-24 Thread Stefan Richter
On Jun 24 Devin Heitmueller wrote: On Fri, Jun 24, 2011 at 5:20 PM, Stefan Richter stef...@s5r6.in-berlin.de wrote: Easier:  I run Ubuntu 10.4.  I run kernel 2.6.32. One of these is usually already included in the first post or IRC message from the user. Separate driver versions

[PATCH] firewire: octlet AT payloads can be stack-allocated

2011-04-22 Thread Stefan Richter
requests on the other hand needs to remain slab-allocated in order to keep the allocation around until end of AT DMA. Signed-off-by: Stefan Richter stef...@s5r6.in-berlin.de --- Tested with firedtv, snd-firewire-speakers, sind-isight, and Coriander on a kernel with CONFIG_DMA_API_DEBUG=y. The patch

Re: firedtv and removal of old IEEE1394 stack

2011-02-09 Thread Stefan Richter
as well and fully describes the problem and its solution. :-) -- Stefan Richter -=-==-== --=- -=--= http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: firedtv and removal of old IEEE1394 stack

2011-02-09 Thread Stefan Richter
On Feb 09 Stefan Richter wrote: https://bugs.launchpad.net/ubuntu/+source/linux-kernel-headers/+bug/134222 Correction: Bug 134222 has *nothing* to do with the removal of the older ieee1394 stack. The bug is about 1. a defect during assembling the linux-kernel-headers package

Re: [GIT PATCHES FOR 2.6.39] Remove se401, usbvideo, dabusb, firedtv-1394 and VIDIOC_OLD

2011-02-06 Thread Stefan Richter
-backend abstraction. I tend to think that the three parts of firedtv-fw.c (asynchronous I/O, isochronous I/O, device probe/update/removal) can be moved into firedtv-avc.c, -fe.c, and -dvb.c. I will post something. If you rewrite the changelog, you can add Reviewed-by: Stefan Richter stef...@s5r6

[PATCH] firedtv: drop obsolete backend abstraction

2011-02-06 Thread Stefan Richter
and removal are implemented. Signed-off-by: Stefan Richter stef...@s5r6.in-berlin.de --- Applies after Hans' firedtv: remove dependency on the deleted ieee1394 stack., http://git.linuxtv.org/hverkuil/media_tree.git?a=commitdiff;h=f02c316436eef3baf349c489545edc7ade419ff6 drivers/media/dvb/firewire/firedtv

Re: firedtv and removal of old IEEE1394 stack

2011-02-05 Thread Stefan Richter
sources. If CONFIG_IEEE1394 is not defined, neither make nor gcc ever see anything that includes ieee1394 headers. Vice versa regarding CONFIG_FIREWIRE and the newer firewire headers. -- Stefan Richter -=-==-== --=- --=-= http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line

Re: [GIT PATCHES FOR 2.6.39] Remove se401, usbvideo, dabusb, firedtv-1394 and VIDIOC_OLD

2011-02-05 Thread Stefan Richter
will have a look at your changes later. -- Stefan Richter -=-==-== --=- --=-= http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: firedtv and removal of old IEEE1394 stack

2011-02-05 Thread Stefan Richter
On Feb 05 Stefan Richter wrote: On Feb 03 Hans Verkuil wrote: It would be nice to remove this since building the firedtv driver for older kernels always gives problems on ubuntu due to some missing ieee1394 headers. How so? Then there is something wrong with the backported sources

[PATCH update] firedtv: fix remote control with newer Xorg evdev

2011-01-17 Thread Stefan Richter
console did not have an issue with the FireDTV's RC though. The fix is to insert EV_SYN events after the key-down/-up events. Dimitry notes that EV_SYN is also necessary between down and up, otherwise userspace could combine their state. Signed-off-by: Stefan Richter stef...@s5r6.in-berlin.de

[PATCH incremental update] firedtv: fix remote control - addendum

2011-01-17 Thread Stefan Richter
Dimitry notes that EV_SYN is also necessary between down and up, otherwise userspace could combine their state. Signed-off-by: Stefan Richter stef...@s5r6.in-berlin.de --- Hi Mauro, since you already pushed out the first version of firedtv: fix remote control with newer Xorg evdev, here

[PATCH] firedtv: fix remote control with newer Xorg evdev

2011-01-16 Thread Stefan Richter
console did not have an issue with the FireDTV's RC though. The fix is to insert EV_SYN events after the key-down/-up events. Signed-off-by: Stefan Richter stef...@s5r6.in-berlin.de --- drivers/media/dvb/firewire/firedtv-rc.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) Index

drivers/media/IR/ir-keytable.c::ir_getkeycode - 'retval' may be used uninitialized

2010-10-31 Thread Stefan Richter
but I don't know the fix. -- Stefan Richter -=-==-=- =-=- = http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[git pull] dvb/firewire update

2010-10-13 Thread Stefan Richter
(-) -- Stefan Richter -=-==-=- =-=- -==-= http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH update] V4L/DVB: firedtv: support for PSK8 for S2 devices. To watch HD.

2010-10-04 Thread Stefan Richter
; It adds support for tuning with PSK8 modulation, pilot and rolloff with the S2 versions of firedtv. Signed-off-by: Tommy Jonsson quazz...@gmail.com Signed-off-by: Stefan Richter stef...@s5r6.in-berlin.de (trivial simplification) --- Update: resend with whitespace preserved, fe pointer does not have

[PATCH update2] V4L/DVB: firedtv: support for PSK8 for S2 devices. To watch HD.

2010-10-04 Thread Stefan Richter
; It adds support for tuning with PSK8 modulation, pilot and rolloff with the S2 versions of firedtv. Signed-off-by: Tommy Jonsson quazz...@gmail.com Signed-off-by: Stefan Richter stef...@s5r6.in-berlin.de (trivial simplification) --- Sorry, missed two space-before-tab. drivers/media/dvb/firewire

Re: [PATCH] firedtv driver: support for PSK8 for S2 devices. To watch HD.

2010-09-15 Thread Stefan Richter
whitespace issues in it. I will have a closer look at it later today and repost the patch so that Mauro can apply it without manual intervention. -- Stefan Richter -=-==-=- =--= - http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body

Re: [PATCH] firedtv driver: support for PSK8 for S2 devices. To watch HD.

2010-09-15 Thread Stefan Richter
= fdtv_read_ber; ops-read_signal_strength = fdtv_read_signal_strength; [...] (Hmm, note to self: Can't DVB core provide empty default methods?) -- Stefan Richter -=-==-=- =--= - http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line

Re: [PATCH 1/3] IR: add core lirc device interface

2010-06-05 Thread Stefan Richter
always only as 32 bits wide AFAIK. -- Stefan Richter -=-==-=- -==- --=-= http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: post 2.6.34 bug: new code enabled by default

2010-05-26 Thread Stefan Richter
Mauro Carvalho Chehab wrote: Stefan Richter wrote: [CONFIG_RC_MAP et al] Please leave the default of new options at N. (Unless this were a special case of new options that replaced older options and need to be migrated to 'on' per default in make oldconfig. I think this is not the case here

Re: ideal DVB-C PCI/e card? [linux-media]

2010-05-25 Thread Stefan Richter
Jed wrote: On 24/05/10 4:18 AM, Stefan Richter wrote: Jed wrote: Ideally it'd be dual DVB-C, the only one I've found is more than dual DVB-C is far too expensive. If you need two receivers but can only spare up to one PCI or PCIe slot, why not use two USB or FireWire attached receivers

post 2.6.34 bug: new code enabled by default

2010-05-25 Thread Stefan Richter
options that replaced older options and need to be migrated to 'on' per default in make oldconfig. I think this is not the case here.) -- Stefan Richter -=-==-=- -=-= ==--= http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message

Re: ideal DVB-C PCI/e card? [linux-media]

2010-05-23 Thread Stefan Richter
and weren't exactly on the cheap side. OTOH one can drive up to 3 DVB FireWire receivers on a single FireWire bus; and for those who need even more there are dual link FireWire PCI and PCIe cards readily available. -- Stefan Richter -=-==-=- -=-= =-=== http://arcgraph.de/sr/ -- To unsubscribe from

Re: V4L-DVB drivers and BKL

2010-04-03 Thread Stefan Richter
devices. We need to get rid of it. Get rid of its lock_kernel in open and its locked ioctl, or of the dvbdev 'library' itself? That's said, Stefan Richter sent a patch meant to reduce the issues with DVB. Unfortunately, I haven't seen any comments on it. It would be really important to test

Re: V4L-DVB drivers and BKL

2010-04-01 Thread Stefan Richter
that need to be checked for possible concurrency issues, then converted to .unlocked_ioctl, - remaining .llseek uses (all implicit) which need to be checked whether they should be no_llseek() (accompanied by nonseekable_open) or generic_file_llseek() or default_llseek(). -- Stefan Richter

Re: V4L-DVB drivers and BKL

2010-04-01 Thread Stefan Richter
Stefan Richter wrote: linux/drivers/media/dvb/dvb-core/dvbdev.c: lock_kernel(); linux/drivers/media/dvb/dvb-core/dvbdev.c: unlock_kernel(); linux/drivers/media/dvb/dvb-core/dvbdev.c: unlock_kernel(); This is from when the BKL was pushed down into drivers' open

Re: V4L-DVB drivers and BKL

2010-04-01 Thread Stefan Richter
: https://patchwork.kernel.org/patch/88778/ -- Stefan Richter -=-==-=- -=-- = http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH RFC v2] DVB: add dvb_generic_nonseekable_open, dvb_generic_unlocked_ioctl, use in firedtv

2010-03-28 Thread Stefan Richter
and remove .kernel_ioctl and the temporarily introduced dvbdev.c::legacy_usercopy(). Applies to: drivers/media/dvb/ttpci/av7110.c drivers/media/dvb/ttpci/av7110_av.c drivers/media/dvb/ttpci/av7110_ca.c drivers/media/dvb/dvb-core/dvb_frontend.c Signed-off-by: Stefan Richter stef

[PATCH RFC] DVB: add dvb_generic_nonseekable_open, dvb_generic_unlocked_ioctl, use in firedtv

2010-03-27 Thread Stefan Richter
. Signed-off-by: Stefan Richter stef...@s5r6.in-berlin.de --- This patch is motivated by Arnd's bkl removal: make unlocked_ioctl mandatory http://git.kernel.org/?p=linux/kernel/git/arnd/playground.git;a=blobdiff;f=drivers/media/dvb/firewire/firedtv-ci.c;h=7ab89035c101240a860d6c72bf8541a0fdf3aed9

Re: [PATCH] firedtv: add parameter to fake ca_system_ids in CA_INFO

2010-03-06 Thread Stefan Richter
Mauro Carvalho Chehab wrote: Stefan Richter wrote: The Digital Everywhere firmware have the shortcoming that ca_info_enq and ca_info are not supported. This means that we can never retrieve the correct ca_system_id to present in the CI message CA_INFO. Currently the driver uses

Re: [PATCH] firedtv: add parameter to fake ca_system_ids in CA_INFO

2010-03-06 Thread Stefan Richter
Stefan Richter wrote: I already posted an updated version of the patch which correctly defines num_fake_ca_system_ids as an unsigned long. err, unsigned int of course, as http://patchwork.kernel.org/patch/82912/. -- Stefan Richter -=-==-=- --== --==- http://arcgraph.de/sr

[PATCH] firedtv: correct version number and current/next in CA_PMT

2010-03-01 Thread Stefan Richter
number as the old. The version number is now copied from the original PMT. Signed-off-by: Henrik Kurelid hen...@kurelid.se Signed-off-by: Stefan Richter stef...@s5r6.in-berlin.de --- This patch got stuck somehow on the long way upstream. :-) Would be good to get into one of the next .34-rc releases

[PATCH] firedtv: add parameter to fake ca_system_ids in CA_INFO

2010-03-01 Thread Stefan Richter
ca_system_ids can be specified. This is needed for users with CAMs that have different manufacturer id and ca_system_id and that uses applications that take this into account, like MythTV. Signed-off-by: Henrik Kurelid hen...@kurelid.se Signed-off-by: Stefan Richter stef...@s5r6.in-berlin.de (rebased, format

Re: [PATCH] firedtv: add parameter to fake ca_system_ids in CA_INFO

2010-03-01 Thread Stefan Richter
with different system IDs until success, initially during fdtv_dvb_register/ fdtv_ca_register? (I don't know how CI works, and alas I don't have a CAM myself for testing and am not very keen on getting one...) -- Stefan Richter -=-==-=- --== = http://arcgraph.de/sr/ -- To unsubscribe from this list

[PATCH update] firedtv: add parameter to fake ca_system_ids in CA_INFO

2010-03-01 Thread Stefan Richter
message. Up to four ca_system_ids can be specified. This is needed for users with CAMs that have different manufacturer id and ca_system_id and that uses applications that take this into account, like MythTV. Signed-off-by: Henrik Kurelid hen...@kurelid.se Signed-off-by: Stefan Richter stef...@s5r6

How to add DVB-S2 support to firedtv?

2010-02-14 Thread Stefan Richter
?) or is the current driver code enough to connect the dots? Is the transport stream different from DVB-C HD streams so that changes to the isochronous I/O part would be required? -- Stefan Richter -=-==-=- --=- -===- http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line unsubscribe linux-media

Re: [hg:v4l-dvb] firedtv: do not DMA-map stack addresses

2010-02-01 Thread Stefan Richter
. :-) -- Stefan Richter -=-==-=- --=- = http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4l/dvb] firedtv: add forgotten __exit annotation

2010-01-10 Thread Stefan Richter
Stefan Richter wrote on 2009-12-26: fdtv_fw_exit() is part of the firedtv driver's .exit.text section. ... --- linux-2.6.33-rc2.orig/drivers/media/dvb/firewire/firedtv-fw.c +++ linux-2.6.33-rc2/drivers/media/dvb/firewire/firedtv-fw.c @@ -332,7 +332,7 @@ int __init fdtv_fw_init(void

[PATCH v4l/dvb] firedtv: add forgotten __exit annotation

2009-12-25 Thread Stefan Richter
fdtv_fw_exit() is part of the firedtv driver's .exit.text section. Signed-off-by: Stefan Richter stef...@s5r6.in-berlin.de --- drivers/media/dvb/firewire/firedtv-fw.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.33-rc2/drivers/media/dvb/firewire/firedtv-fw.c

[PATCH v4l/dvb] firedtv: add missing NULL pointer check

2009-12-25 Thread Stefan Richter
. The firewire variant of firedtv's device probe is not affected. The fix makes sure that such an unexpected firmware is safely recognized by fdtv_alloc as an unknown firmware. Signed-off-by: Stefan Richter stef...@s5r6.in-berlin.de --- drivers/media/dvb/firewire/firedtv-1394.c | 10 +++--- 1

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

2009-11-28 Thread Stefan Richter
--- but this does not affect LIRC and whether to merge it in any way. PS: Drop your specific vs. generic tools terminology already. Your configfs based proposal requires specific tools as well, it's just that they can be implemented in bash, among else. -- Stefan Richter -=-==--= =-== ===-- http

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

2009-11-28 Thread Stefan Richter
everywhere, they /do/ auto-load when the device is inserted. And if there should be an issue with power management (is there any?), then improve the ABI and libusb can surely be improved. I don't see why a device with a userspace driver cannot be included in power management. -- Stefan Richter

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

2009-11-28 Thread Stefan Richter
Jon Smirl wrote: On Sat, Nov 28, 2009 at 1:17 PM, Stefan Richter stef...@s5r6.in-berlin.de wrote: Jon Smirl wrote: There are two very basic things that we need to reach consensus on first. 1) Unification with mouse/keyboard in evdev - put IR on equal footing. 2) Specific tools (xmodmap

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

2009-11-28 Thread Stefan Richter
Jon Smirl wrote: On Sat, Nov 28, 2009 at 2:30 PM, Stefan Richter stef...@s5r6.in-berlin.de wrote: Jon Smirl wrote: If these drivers are for specific USB devices it is straight forward to turn them into kernel based drivers. If we are going for plug and play this needs to happen. All USB

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

2009-11-28 Thread Stefan Richter
Jon Smirl wrote: On Sat, Nov 28, 2009 at 2:45 PM, Stefan Richter stef...@s5r6.in-berlin.de wrote: Jon Smirl wrote: Also, how do you create the devices for each remote? You would need to create these devices before being able to do EVIOCSKEYCODE to them. The input subsystem creates devices

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

2009-11-28 Thread Stefan Richter
Stefan Richter wrote: Jon Smirl wrote: We have one IR receiver device and multiple remotes. How does the input system know how many devices to create corresponding to how many remotes you have? If several remotes are to be used on the same receiver, then they necessarily need to generate

Re: [IR-RFC PATCH v4 0/6] In-kernel IR support using evdev

2009-11-26 Thread Stefan Richter
in itself is an interface really; rather there is a number of interfaces which are implemented by means of sysfs. sysfs is primarily meant for simple textual attributes though, not for I/O streams. -- Stefan Richter -=-==--= =-== ==-== http://arcgraph.de/sr/ -- To unsubscribe from this list: send

Re: [RFC] Should we create a raw input interface for IR's ? - Was: Re: [PATCH 1/3 v2] lirc core device driver infrastructure

2009-11-23 Thread Stefan Richter
no idea whether a pulse/space - scancode - keycode translation would be practical there.) -- Stefan Richter -=-==--= =-== =-=== http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 0/6] DVB: firedtv: simplifications and a portability fix

2009-11-20 Thread Stefan Richter
On 18 Nov, Stefan Richter wrote: The following three patches are applicable after firedtv: port to new firewire core from 2009-11-08: ... The rest of this patch set additionally requires the latest firedtv as of 2.6.32-rc7: ... I updated the firedtv branch at git://git.kernel.org/pub/scm

[PATCH 0/6] DVB: firedtv: simplifications and a portability fix

2009-11-18 Thread Stefan Richter
-avc.c | 520 +++--- drivers/media/dvb/firewire/firedtv-dvb.c |1 drivers/media/dvb/firewire/firedtv-fw.c | 39 - drivers/media/dvb/firewire/firedtv.h |8 5 files changed, 306 insertions(+), 275 deletions(-) -- Stefan Richter -=-==--= =-== =--=- http://arcgraph.de

[PATCH 1/6] firedtv: shrink buffer pointer table

2009-11-18 Thread Stefan Richter
Cache only addresses of whole pages, not of each buffer chunk. Besides, page addresses can be obtained by page_address() instead of kmap() since they were allocated in lowmem. Signed-off-by: Stefan Richter stef...@s5r6.in-berlin.de --- drivers/media/dvb/firewire/firedtv-fw.c | 19

[PATCH 2/6] firedtv: packet requeuing is likely to succeed

2009-11-18 Thread Stefan Richter
at which packet buffer to set the interrupt flag. Signed-off-by: Stefan Richter stef...@s5r6.in-berlin.de --- drivers/media/dvb/firewire/firedtv-fw.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) Index: linux-2.6.32-rc7/drivers/media/dvb/firewire/firedtv-fw.c

[PATCH 3/6] firedtv: remove an unnecessary function argument

2009-11-18 Thread Stefan Richter
All read transactions initiated by firedtv are only quadlet-sized, hence the backend-read call can be simplified a little. Signed-off-by: Stefan Richter stef...@s5r6.in-berlin.de --- drivers/media/dvb/firewire/firedtv-1394.c |4 ++-- drivers/media/dvb/firewire/firedtv-avc.c |8

[PATCH 4/6] firedtv: do not DMA-map stack addresses

2009-11-18 Thread Stefan Richter
transactions, let it wait for an interim response. Signed-off-by: Stefan Richter stef...@s5r6.in-berlin.de --- drivers/media/dvb/firewire/firedtv-1394.c |9 + drivers/media/dvb/firewire/firedtv-avc.c | 437 +- drivers/media/dvb/firewire/firedtv-dvb.c |1 - drivers/media

[PATCH 5/6] firedtv: remove check for interrupting signal

2009-11-18 Thread Stefan Richter
time out, usually much shorter). Hence simplify the code to plain mutex_lock. Signed-off-by: Stefan Richter stef...@s5r6.in-berlin.de --- drivers/media/dvb/firewire/firedtv-avc.c | 51 --- 1 file changed, 17 insertions(+), 34 deletions(-) Index: linux-2.6.32-rc7/drivers/media

[PATCH 6/6] firedtv: reduce memset()s

2009-11-18 Thread Stefan Richter
length response will be taken. Signed-off-by: Stefan Richter stef...@s5r6.in-berlin.de --- drivers/media/dvb/firewire/firedtv-avc.c | 146 ++- 1 file changed, 65 insertions(+), 81 deletions(-) Index: linux-2.6.32-rc7/drivers/media/dvb/firewire/firedtv-avc.c

Re: [PATCH] firedtv: fix regression: tuning fails due to bogus error return

2009-11-13 Thread Stefan Richter
Stefan Richter wrote on 2009-10-17: Since 2.6.32(-rc1), DVB core checks the return value of dvb_frontend_ops.set_frontend. Now it becomes apparent that firedtv always returned a bogus value from its set_frontend method. Signed-off-by: Stefan Richter stef...@s5r6.in-berlin.de Hi Mauro

Re: [PATCH] firedtv: fix regression: tuning fails due to bogus error return

2009-11-13 Thread Stefan Richter
Stefan Richter wrote: ...the firedtv-avc.c part of the patch vanished when you committed it. It was still there in the linuxtv-commits message of the respective Mercurial commit, BTW. Something wrong with the hg to git workflow? -- Stefan Richter -=-==--= =-== -==-= http://arcgraph.de/sr

[PATCH 0/4] DVB: firedtv: port to new firewire driver stack

2009-11-08 Thread Stefan Richter
|2 drivers/media/dvb/firewire/firedtv.h | 17 8 files changed, 471 insertions(+), 43 deletions(-) -- Stefan Richter -=-==--= =-== -=--- http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord

[PATCH 1/4] firedtv: move remote control workqueue handling into rc source file

2009-11-08 Thread Stefan Richter
Preparation for the port of firedtv to the firewire-core kernel API: Canceling of the remote control workqueue job is factored into firedtv-rc.c. Plus trivial whitespace change. Signed-off-by: Stefan Richter stef...@s5r6.in-berlin.de --- drivers/media/dvb/firewire/firedtv-1394.c |5

[PATCH 2/4] firedtv: reform lock transaction backend call

2009-11-08 Thread Stefan Richter
Preparation for the port of firedtv to the firewire-core kernel API: The fdtv-backend-lock() hook and thus the CMP code is slightly changed to better fit with the new API. Signed-off-by: Stefan Richter stef...@s5r6.in-berlin.de --- drivers/media/dvb/firewire/firedtv-1394.c | 11 - drivers

[PATCH 3/4] firedtv: add missing include, rename a constant

2009-11-08 Thread Stefan Richter
. the IEEE 1394 isochronous packet header. So choose a more precise name. Also, express the payload size as a preprocessor constant too. Signed-off-by: Stefan Richter stef...@s5r6.in-berlin.de --- drivers/media/dvb/firewire/firedtv-1394.c | 15 +-- 1 file changed, 9 insertions(+), 6

[PATCH 4/4] firedtv: port to new firewire core

2009-11-08 Thread Stefan Richter
or the other or both backends will be built into the firedtv driver. This has been tested with a DVB-T and a DVB-C box on x86-64 and x86-32 together with a few different controllers (Agere FW323, a NEC chip, TI TSB82AA2, TSB43AB22/A, VIA VT6306). Signed-off-by: Stefan Richter stef...@s5r6

Re: + firedtv-fix-regression-tuning-fails-due-to-bogus-error-return.patch added to -mm tree

2009-11-03 Thread Stefan Richter
material. The ca2host fix is possibly also good for 2.6.x.y, but this is something which Henrik knows better than me. -- Stefan Richter -=-==--= =-== ---== http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord

  1   2   >