drivers/media/v4l2-core/videobuf2-dma-contig.c:486:2: error: implicit declaration of function 'dma_get_cache_alignment'
Hi Hans,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: fa8410b355251fd30341662a40ac6b22d3e38468
commit: c1023ba74fc77dc56dc317bd98f5060aab889ac1 [media]
drivers/media/platform/Kconfig: fix VIDEO_MEDIATEK_VCODEC dependency
date: 6 weeks ago
config: m32r-allmodconfig (attached as .config)
compiler: m32r-linux-gcc (GCC) 4.9.0
reproduce:
wget
https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross
-O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout c1023ba74fc77dc56dc317bd98f5060aab889ac1
# save the attached .config to linux build tree
make.cross ARCH=m32r
All errors (new ones prefixed by >>):
drivers/media/v4l2-core/videobuf2-dma-contig.c: In function
'vb2_dc_get_userptr':
>> drivers/media/v4l2-core/videobuf2-dma-contig.c:486:2: error: implicit
>> declaration of function 'dma_get_cache_alignment'
>> [-Werror=implicit-function-declaration]
unsigned long dma_align = dma_get_cache_alignment();
^
cc1: some warnings being treated as errors
vim +/dma_get_cache_alignment +486
drivers/media/v4l2-core/videobuf2-dma-contig.c
774d2301 drivers/media/v4l2-core/videobuf2-dma-contig.c Marek Szyprowski
2013-06-19 470 {
774d2301 drivers/media/v4l2-core/videobuf2-dma-contig.c Marek Szyprowski
2013-06-19 471 /* really, we cannot do anything better at this point */
774d2301 drivers/media/v4l2-core/videobuf2-dma-contig.c Marek Szyprowski
2013-06-19 472 return (dma_addr_t)(pfn) << PAGE_SHIFT;
774d2301 drivers/media/v4l2-core/videobuf2-dma-contig.c Marek Szyprowski
2013-06-19 473 }
774d2301 drivers/media/v4l2-core/videobuf2-dma-contig.c Marek Szyprowski
2013-06-19 474 #endif
774d2301 drivers/media/v4l2-core/videobuf2-dma-contig.c Marek Szyprowski
2013-06-19 475
36c0f8b3 drivers/media/v4l2-core/videobuf2-dma-contig.c Hans Verkuil
2016-04-15 476 static void *vb2_dc_get_userptr(struct device *dev, unsigned
long vaddr,
cd474037 drivers/media/v4l2-core/videobuf2-dma-contig.c Hans Verkuil
2014-11-18 477 unsigned long size, enum dma_data_direction dma_dir)
1a758d4e drivers/media/video/videobuf2-dma-contig.c Pawel Osciak
2010-10-11 478 {
1a758d4e drivers/media/video/videobuf2-dma-contig.c Pawel Osciak
2010-10-11 479 struct vb2_dc_buf *buf;
fb639eb3 drivers/media/v4l2-core/videobuf2-dma-contig.c Jan Kara
2015-07-13 480 struct frame_vector *vec;
e15dab75 drivers/media/v4l2-core/videobuf2-dma-contig.c Tomasz Stanislawski
2012-06-14 481 unsigned long offset;
fb639eb3 drivers/media/v4l2-core/videobuf2-dma-contig.c Jan Kara
2015-07-13 482 int n_pages, i;
e15dab75 drivers/media/v4l2-core/videobuf2-dma-contig.c Tomasz Stanislawski
2012-06-14 483 int ret = 0;
e15dab75 drivers/media/v4l2-core/videobuf2-dma-contig.c Tomasz Stanislawski
2012-06-14 484 struct sg_table *sgt;
e15dab75 drivers/media/v4l2-core/videobuf2-dma-contig.c Tomasz Stanislawski
2012-06-14 485 unsigned long contig_size;
d81e870d drivers/media/v4l2-core/videobuf2-dma-contig.c Marek Szyprowski
2012-06-12 @486 unsigned long dma_align = dma_get_cache_alignment();
251a79f8 drivers/media/v4l2-core/videobuf2-dma-contig.c Hans Verkuil
2014-11-18 487 DEFINE_DMA_ATTRS(attrs);
251a79f8 drivers/media/v4l2-core/videobuf2-dma-contig.c Hans Verkuil
2014-11-18 488
251a79f8 drivers/media/v4l2-core/videobuf2-dma-contig.c Hans Verkuil
2014-11-18 489 dma_set_attr(DMA_ATTR_SKIP_CPU_SYNC, &attrs);
d81e870d drivers/media/v4l2-core/videobuf2-dma-contig.c Marek Szyprowski
2012-06-12 490
d81e870d drivers/media/v4l2-core/videobuf2-dma-contig.c Marek Szyprowski
2012-06-12 491 /* Only cache aligned DMA transfers are reliable */
d81e870d drivers/media/v4l2-core/videobuf2-dma-contig.c Marek Szyprowski
2012-06-12 492 if (!IS_ALIGNED(vaddr | size, dma_align)) {
d81e870d drivers/media/v4l2-core/videobuf2-dma-contig.c Marek Szyprowski
2012-06-12 493 pr_debug("user data must be aligned to %lu
bytes\n", dma_align);
d81e870d drivers/media/v4l2-core/videobuf2-dma-contig.c Marek Szyprowski
2012-06-12 494 return ERR_PTR(-EINVAL);
:: The code at line 486 was first introduced by commit
:: d81e870d5afa1b0a95ea94c4052d3c7e973fae8c [media] v4l: vb2-dma-contig:
fail if user ptr buffer is not correctly aligned
:: TO: Marek Szyprowski
:: CC: Mauro Carvalho Chehab
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: Binary data
Re: [PATCH v5 2/3] st-hva: multi-format video encoder V4L2 driver
Hi Jean-Christophe, [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.8-rc4 next-20160825] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] [Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on] [Check https://git-scm.com/docs/git-format-patch for more information] url: https://github.com/0day-ci/linux/commits/Jean-Christophe-Trotin/Documentation-DT-add-bindings-for-ST-HVA/20160829-212937 base: git://linuxtv.org/media_tree.git master config: m32r-allyesconfig (attached as .config) compiler: m32r-linux-gcc (GCC) 4.9.0 reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=m32r All warnings (new ones prefixed by >>): warning: (VIDEO_MEDIATEK_VCODEC && VIDEO_STI_HVA) selects VIDEOBUF2_DMA_CONTIG which has unmet direct dependencies (MEDIA_SUPPORT && HAS_DMA) --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: Binary data
[linuxtv-media:master 189/209] warning: (VIDEO_MEDIATEK_VCODEC) selects VIDEO_MEDIATEK_VPU which has unmet direct dependencies (MEDIA_SUPPORT && ..))
tree: git://linuxtv.org/media_tree.git master head: fb6609280db902bd5d34445fba1c926e95e63914 commit: 69d4a521586ef93db94451afa5072ec3f6bee401 [189/209] [media] VIDEO_MEDIATEK_VPU should depend on HAS_DMA config: m32r-allmodconfig (attached as .config) compiler: m32r-linux-gcc (GCC) 4.9.0 reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 69d4a521586ef93db94451afa5072ec3f6bee401 # save the attached .config to linux build tree make.cross ARCH=m32r All warnings (new ones prefixed by >>): warning: (VIDEO_MEDIATEK_VCODEC) selects VIDEO_MEDIATEK_VPU which has unmet direct dependencies (MEDIA_SUPPORT && V4L_MEM2MEM_DRIVERS && VIDEO_DEV && VIDEO_V4L2 && HAS_DMA && (ARCH_MEDIATEK || COMPILE_TEST)) --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: Binary data
Re: [PATCH v2 3/7] [media] rc-core: add support for IR raw transmitters
Hi Andi,
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v4.8-rc4 next-20160825]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
[Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto for
convenience) to record what (public, well-known) commit your patch series was
built on]
[Check https://git-scm.com/docs/git-format-patch for more information]
url:
https://github.com/0day-ci/linux/commits/Andi-Shyti/Add-support-for-IR-transmitters/20160902-060825
base: git://linuxtv.org/media_tree.git master
reproduce: make htmldocs
All warnings (new ones prefixed by >>):
make[3]: warning: jobserver unavailable: using -j1. Add '+' to parent make
rule.
drivers/gpu/drm/i915/i915_vgpu.c:105: warning: No description found for
parameter 'dev_priv'
drivers/gpu/drm/i915/i915_vgpu.c:184: warning: No description found for
parameter 'dev_priv'
drivers/gpu/drm/i915/i915_vgpu.c:184: warning: Excess function parameter
'dev' description in 'intel_vgt_balloon'
drivers/gpu/drm/i915/i915_vgpu.c:106: warning: No description found for
parameter 'dev_priv'
drivers/gpu/drm/i915/i915_vgpu.c:185: warning: No description found for
parameter 'dev_priv'
drivers/gpu/drm/i915/i915_vgpu.c:185: warning: Excess function parameter
'dev' description in 'intel_vgt_balloon'
drivers/gpu/drm/i915/i915_gem.c:929: warning: No description found for
parameter 'i915'
drivers/gpu/drm/i915/i915_gem.c:929: warning: Excess function parameter
'dev' description in 'i915_gem_gtt_pwrite_fast'
drivers/gpu/drm/i915/intel_hotplug.c:543: warning: Excess function parameter
'enabled' description in 'intel_hpd_poll_init'
drivers/gpu/drm/i915/intel_hotplug.c:544: warning: Excess function parameter
'enabled' description in 'intel_hpd_poll_init'
drivers/gpu/drm/i915/intel_fbc.c:1087: warning: No description found for
parameter 'crtc_state'
drivers/gpu/drm/i915/intel_fbc.c:1087: warning: No description found for
parameter 'plane_state'
drivers/gpu/drm/i915/intel_fbc.c:1088: warning: No description found for
parameter 'crtc_state'
drivers/gpu/drm/i915/intel_fbc.c:1088: warning: No description found for
parameter 'plane_state'
>> include/media/rc-core.h:39: warning: bad line:driver
>> requires pulce/spce data sequence.
drivers/gpu/drm/drm_crtc.c:1272: WARNING: Inline literal start-string
without end-string.
drivers/gpu/drm/drm_crtc.c:1387: WARNING: Inline literal start-string
without end-string.
include/drm/drm_crtc.h:1200: WARNING: Inline literal start-string without
end-string.
include/drm/drm_crtc.h:1253: WARNING: Inline literal start-string without
end-string.
include/drm/drm_crtc.h:1266: WARNING: Inline literal start-string without
end-string.
include/drm/drm_crtc.h:1270: WARNING: Inline literal start-string without
end-string.
drivers/gpu/drm/drm_irq.c:718: WARNING: Option list ends without a blank
line; unexpected unindent.
drivers/gpu/drm/drm_fb_helper.c:2196: WARNING: Inline emphasis start-string
without end-string.
drivers/gpu/drm/drm_simple_kms_helper.c:156: WARNING: Inline literal
start-string without end-string.
include/drm/drm_gem.h:212: WARNING: Inline emphasis start-string without
end-string.
drivers/gpu/drm/i915/intel_uncore.c:1622: ERROR: Unexpected indentation.
drivers/gpu/drm/i915/intel_uncore.c:1623: WARNING: Block quote ends without
a blank line; unexpected unindent.
drivers/gpu/drm/i915/intel_uncore.c:1656: ERROR: Unexpected indentation.
drivers/gpu/drm/i915/intel_uncore.c:1657: WARNING: Block quote ends without
a blank line; unexpected unindent.
drivers/gpu/drm/i915/i915_vgpu.c:178: WARNING: Literal block ends without a
blank line; unexpected unindent.
drivers/gpu/drm/i915/intel_audio.c:54: WARNING: Inline emphasis start-string
without end-string.
drivers/gpu/drm/i915/intel_audio.c:54: WARNING: Inline emphasis start-string
without end-string.
drivers/gpu/drm/i915/intel_lrc.c:1166: ERROR: Unexpected indentation.
drivers/gpu/drm/i915/intel_lrc.c:1167: WARNING: Block quote ends without a
blank line; unexpected unindent.
drivers/gpu/drm/i915/intel_guc_fwif.h:159: WARNING: Block quote ends without
a blank line; unexpected unindent.
drivers/gpu/drm/i915/intel_guc_fwif.h:178: WARNING: Enumerated list ends
without a blank line; unexpected unindent.
WARNING: dvipng command 'dvipng' cannot be run (needed for math display),
check the imgmath_dvipng setting
vim +39 include/media/rc-core.h
23 #include
24
25 extern int rc_core_debug;
26 #define IR_dprintk(level, fmt, ...) \
27 do {\
28 if (rc_core_debug >= level) \
29 printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__); \
30 } while (0)
31
32 /**
33 * enum rc_d
drivers/media/v4l2-core/videobuf2-dma-contig.c:486:2: error: implicit declaration of function 'dma_get_cache_alignment'
Hi Hans,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 28e68154c5e2793123b248d38cf17b34dcb16d87
commit: c1023ba74fc77dc56dc317bd98f5060aab889ac1 [media]
drivers/media/platform/Kconfig: fix VIDEO_MEDIATEK_VCODEC dependency
date: 8 weeks ago
config: m32r-allyesconfig (attached as .config)
compiler: m32r-linux-gcc (GCC) 4.9.0
reproduce:
wget
https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross
-O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout c1023ba74fc77dc56dc317bd98f5060aab889ac1
# save the attached .config to linux build tree
make.cross ARCH=m32r
All errors (new ones prefixed by >>):
drivers/media/v4l2-core/videobuf2-dma-contig.c: In function
'vb2_dc_get_userptr':
>> drivers/media/v4l2-core/videobuf2-dma-contig.c:486:2: error: implicit
>> declaration of function 'dma_get_cache_alignment'
>> [-Werror=implicit-function-declaration]
unsigned long dma_align = dma_get_cache_alignment();
^
cc1: some warnings being treated as errors
vim +/dma_get_cache_alignment +486
drivers/media/v4l2-core/videobuf2-dma-contig.c
774d2301 drivers/media/v4l2-core/videobuf2-dma-contig.c Marek Szyprowski
2013-06-19 470 {
774d2301 drivers/media/v4l2-core/videobuf2-dma-contig.c Marek Szyprowski
2013-06-19 471 /* really, we cannot do anything better at this point */
774d2301 drivers/media/v4l2-core/videobuf2-dma-contig.c Marek Szyprowski
2013-06-19 472 return (dma_addr_t)(pfn) << PAGE_SHIFT;
774d2301 drivers/media/v4l2-core/videobuf2-dma-contig.c Marek Szyprowski
2013-06-19 473 }
774d2301 drivers/media/v4l2-core/videobuf2-dma-contig.c Marek Szyprowski
2013-06-19 474 #endif
774d2301 drivers/media/v4l2-core/videobuf2-dma-contig.c Marek Szyprowski
2013-06-19 475
36c0f8b3 drivers/media/v4l2-core/videobuf2-dma-contig.c Hans Verkuil
2016-04-15 476 static void *vb2_dc_get_userptr(struct device *dev, unsigned
long vaddr,
cd474037 drivers/media/v4l2-core/videobuf2-dma-contig.c Hans Verkuil
2014-11-18 477 unsigned long size, enum dma_data_direction dma_dir)
1a758d4e drivers/media/video/videobuf2-dma-contig.c Pawel Osciak
2010-10-11 478 {
1a758d4e drivers/media/video/videobuf2-dma-contig.c Pawel Osciak
2010-10-11 479 struct vb2_dc_buf *buf;
fb639eb3 drivers/media/v4l2-core/videobuf2-dma-contig.c Jan Kara
2015-07-13 480 struct frame_vector *vec;
e15dab75 drivers/media/v4l2-core/videobuf2-dma-contig.c Tomasz Stanislawski
2012-06-14 481 unsigned long offset;
fb639eb3 drivers/media/v4l2-core/videobuf2-dma-contig.c Jan Kara
2015-07-13 482 int n_pages, i;
e15dab75 drivers/media/v4l2-core/videobuf2-dma-contig.c Tomasz Stanislawski
2012-06-14 483 int ret = 0;
e15dab75 drivers/media/v4l2-core/videobuf2-dma-contig.c Tomasz Stanislawski
2012-06-14 484 struct sg_table *sgt;
e15dab75 drivers/media/v4l2-core/videobuf2-dma-contig.c Tomasz Stanislawski
2012-06-14 485 unsigned long contig_size;
d81e870d drivers/media/v4l2-core/videobuf2-dma-contig.c Marek Szyprowski
2012-06-12 @486 unsigned long dma_align = dma_get_cache_alignment();
251a79f8 drivers/media/v4l2-core/videobuf2-dma-contig.c Hans Verkuil
2014-11-18 487 DEFINE_DMA_ATTRS(attrs);
251a79f8 drivers/media/v4l2-core/videobuf2-dma-contig.c Hans Verkuil
2014-11-18 488
251a79f8 drivers/media/v4l2-core/videobuf2-dma-contig.c Hans Verkuil
2014-11-18 489 dma_set_attr(DMA_ATTR_SKIP_CPU_SYNC, &attrs);
d81e870d drivers/media/v4l2-core/videobuf2-dma-contig.c Marek Szyprowski
2012-06-12 490
d81e870d drivers/media/v4l2-core/videobuf2-dma-contig.c Marek Szyprowski
2012-06-12 491 /* Only cache aligned DMA transfers are reliable */
d81e870d drivers/media/v4l2-core/videobuf2-dma-contig.c Marek Szyprowski
2012-06-12 492 if (!IS_ALIGNED(vaddr | size, dma_align)) {
d81e870d drivers/media/v4l2-core/videobuf2-dma-contig.c Marek Szyprowski
2012-06-12 493 pr_debug("user data must be aligned to %lu
bytes\n", dma_align);
d81e870d drivers/media/v4l2-core/videobuf2-dma-contig.c Marek Szyprowski
2012-06-12 494 return ERR_PTR(-EINVAL);
:: The code at line 486 was first introduced by commit
:: d81e870d5afa1b0a95ea94c4052d3c7e973fae8c [media] v4l: vb2-dma-contig:
fail if user ptr buffer is not correctly aligned
:: TO: Marek Szyprowski
:: CC: Mauro Carvalho Chehab
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: Binary data
[linuxtv-media:master 325/346] drivers/media/platform/soc_camera/built-in.o:(___ksymtab+soc_mbus_image_size+0x0): multiple definition of `__ksymtab_soc_mbus_image_size'
tree: git://linuxtv.org/media_tree.git master head: 8a5a2ba86ab8fc12267fea974b9cd730ad2dee24 commit: 5809ecdd6c3c0d6d568a10280f3736f1f4304930 [325/346] [media] pxa_camera: allow building it if COMPILE_TEST is set config: powerpc-allyesconfig (attached as .config) compiler: powerpc64-linux-gnu-gcc (Debian 5.4.0-6) 5.4.0 20160609 reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 5809ecdd6c3c0d6d568a10280f3736f1f4304930 # save the attached .config to linux build tree make.cross ARCH=powerpc All errors (new ones prefixed by >>): >> drivers/media/platform/soc_camera/built-in.o:(___ksymtab+soc_mbus_image_size+0x0): >> multiple definition of `__ksymtab_soc_mbus_image_size' drivers/media/platform/soc_camera/soc_mediabus.o:(___ksymtab+soc_mbus_image_size+0x0): first defined here drivers/media/platform/soc_camera/built-in.o:(___ksymtab+soc_mbus_samples_per_pixel+0x0): multiple definition of `__ksymtab_soc_mbus_samples_per_pixel' drivers/media/platform/soc_camera/soc_mediabus.o:(___ksymtab+soc_mbus_samples_per_pixel+0x0): first defined here >> drivers/media/platform/soc_camera/built-in.o:(.opd+0x678): multiple >> definition of `soc_mbus_config_compatible' drivers/media/platform/soc_camera/soc_mediabus.o:(.opd+0x78): first defined here drivers/media/platform/soc_camera/built-in.o:(.opd+0x630): multiple definition of `soc_mbus_image_size' drivers/media/platform/soc_camera/soc_mediabus.o:(.opd+0x30): first defined here >> drivers/media/platform/soc_camera/built-in.o:(___ksymtab+soc_mbus_find_fmtdesc+0x0): >> multiple definition of `__ksymtab_soc_mbus_find_fmtdesc' drivers/media/platform/soc_camera/soc_mediabus.o:(___ksymtab+soc_mbus_find_fmtdesc+0x0): first defined here drivers/media/platform/soc_camera/built-in.o:(.opd+0x600): multiple definition of `soc_mbus_samples_per_pixel' drivers/media/platform/soc_camera/soc_mediabus.o:(.opd+0x0): first defined here drivers/media/platform/soc_camera/built-in.o: In function `.soc_mbus_bytes_per_line': >> (.text+0x4c40): multiple definition of `.soc_mbus_bytes_per_line' drivers/media/platform/soc_camera/soc_mediabus.o:(.text+0x120): first defined here drivers/media/platform/soc_camera/built-in.o: In function `.soc_mbus_get_fmtdesc': >> (.text+0x4eb0): multiple definition of `.soc_mbus_get_fmtdesc' drivers/media/platform/soc_camera/soc_mediabus.o:(.text+0x390): first defined here drivers/media/platform/soc_camera/built-in.o:(.opd+0x660): multiple definition of `soc_mbus_get_fmtdesc' drivers/media/platform/soc_camera/soc_mediabus.o:(.opd+0x60): first defined here drivers/media/platform/soc_camera/built-in.o: In function `.soc_mbus_image_size': (.text+0x4d30): multiple definition of `.soc_mbus_image_size' drivers/media/platform/soc_camera/soc_mediabus.o:(.text+0x210): first defined here drivers/media/platform/soc_camera/built-in.o: In function `.soc_mbus_samples_per_pixel': (.text+0x4b20): multiple definition of `.soc_mbus_samples_per_pixel' drivers/media/platform/soc_camera/soc_mediabus.o:(.text+0x0): first defined here drivers/media/platform/soc_camera/built-in.o: In function `.soc_mbus_config_compatible': (.text+0x4f50): multiple definition of `.soc_mbus_config_compatible' drivers/media/platform/soc_camera/soc_mediabus.o:(.text+0x430): first defined here drivers/media/platform/soc_camera/built-in.o:(___ksymtab+soc_mbus_get_fmtdesc+0x0): multiple definition of `__ksymtab_soc_mbus_get_fmtdesc' drivers/media/platform/soc_camera/soc_mediabus.o:(___ksymtab+soc_mbus_get_fmtdesc+0x0): first defined here drivers/media/platform/soc_camera/built-in.o: In function `.soc_mbus_find_fmtdesc': (.text+0x4de0): multiple definition of `.soc_mbus_find_fmtdesc' drivers/media/platform/soc_camera/soc_mediabus.o:(.text+0x2c0): first defined here drivers/media/platform/soc_camera/built-in.o:(___ksymtab+soc_mbus_bytes_per_line+0x0): multiple definition of `__ksymtab_soc_mbus_bytes_per_line' drivers/media/platform/soc_camera/soc_mediabus.o:(___ksymtab+soc_mbus_bytes_per_line+0x0): first defined here drivers/media/platform/soc_camera/built-in.o:(___ksymtab+soc_mbus_config_compatible+0x0): multiple definition of `__ksymtab_soc_mbus_config_compatible' drivers/media/platform/soc_camera/soc_mediabus.o:(___ksymtab+soc_mbus_config_compatible+0x0): first defined here drivers/media/platform/soc_camera/built-in.o:(.opd+0x648): multiple definition of `soc_mbus_find_fmtdesc' drivers/media/platform/soc_camera/soc_mediabus.o:(.opd+0x48): first defined here drivers/media/platform/soc_camera/built-in.o:(.opd+0x618): multiple definition of `soc_mbus_bytes_per_line' drivers/media/platform/soc_camera/soc_mediabus.o:(.opd+0x18): first defined here --- 0-DAY kernel test infrastructureOpen Source Tec
[linuxtv-media:master 327/346] drivers/media/platform/soc_camera/built-in.o:(___ksymtab+soc_mbus_samples_per_pixel+0x0): multiple definition of `__ksymtab_soc_mbus_samples_per_pixel'
Hi Mauro, First bad commit (maybe != root cause): tree: git://linuxtv.org/media_tree.git master head: 8a5a2ba86ab8fc12267fea974b9cd730ad2dee24 commit: ade50f4ff8029a182c16c6418995e6ec569ea9fc [327/346] [media] pxa_camera: remove an unused structure pointer config: xtensa-allyesconfig (attached as .config) compiler: xtensa-linux-gcc (GCC) 4.9.0 reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout ade50f4ff8029a182c16c6418995e6ec569ea9fc # save the attached .config to linux build tree make.cross ARCH=xtensa All errors (new ones prefixed by >>): drivers/media/platform/soc_camera/built-in.o:(___ksymtab+soc_mbus_image_size+0x0): multiple definition of `__ksymtab_soc_mbus_image_size' drivers/media/platform/soc_camera/soc_mediabus.o:(___ksymtab+soc_mbus_image_size+0x0): first defined here >> drivers/media/platform/soc_camera/built-in.o:(___ksymtab+soc_mbus_samples_per_pixel+0x0): >> multiple definition of `__ksymtab_soc_mbus_samples_per_pixel' drivers/media/platform/soc_camera/soc_mediabus.o:(___ksymtab+soc_mbus_samples_per_pixel+0x0): first defined here drivers/media/platform/soc_camera/built-in.o: In function `soc_mbus_config_compatible': (.text+0x3840): multiple definition of `soc_mbus_config_compatible' drivers/media/platform/soc_camera/soc_mediabus.o:(.text+0x134): first defined here drivers/media/platform/soc_camera/built-in.o: In function `soc_mbus_image_size': (.text+0x37a4): multiple definition of `soc_mbus_image_size' drivers/media/platform/soc_camera/soc_mediabus.o:(.text+0x98): first defined here drivers/media/platform/soc_camera/built-in.o:(___ksymtab+soc_mbus_find_fmtdesc+0x0): multiple definition of `__ksymtab_soc_mbus_find_fmtdesc' drivers/media/platform/soc_camera/soc_mediabus.o:(___ksymtab+soc_mbus_find_fmtdesc+0x0): first defined here drivers/media/platform/soc_camera/built-in.o: In function `soc_mbus_samples_per_pixel': (.text+0x370c): multiple definition of `soc_mbus_samples_per_pixel' drivers/media/platform/soc_camera/soc_mediabus.o:(.text+0x0): first defined here drivers/media/platform/soc_camera/built-in.o: In function `soc_mbus_get_fmtdesc': (.text+0x3818): multiple definition of `soc_mbus_get_fmtdesc' drivers/media/platform/soc_camera/soc_mediabus.o:(.text+0x10c): first defined here drivers/media/platform/soc_camera/built-in.o:(___ksymtab+soc_mbus_get_fmtdesc+0x0): multiple definition of `__ksymtab_soc_mbus_get_fmtdesc' drivers/media/platform/soc_camera/soc_mediabus.o:(___ksymtab+soc_mbus_get_fmtdesc+0x0): first defined here drivers/media/platform/soc_camera/built-in.o:(___ksymtab+soc_mbus_bytes_per_line+0x0): multiple definition of `__ksymtab_soc_mbus_bytes_per_line' drivers/media/platform/soc_camera/soc_mediabus.o:(___ksymtab+soc_mbus_bytes_per_line+0x0): first defined here drivers/media/platform/soc_camera/built-in.o:(___ksymtab+soc_mbus_config_compatible+0x0): multiple definition of `__ksymtab_soc_mbus_config_compatible' drivers/media/platform/soc_camera/soc_mediabus.o:(___ksymtab+soc_mbus_config_compatible+0x0): first defined here drivers/media/platform/soc_camera/built-in.o: In function `soc_mbus_find_fmtdesc': (.text+0x37e0): multiple definition of `soc_mbus_find_fmtdesc' drivers/media/platform/soc_camera/soc_mediabus.o:(.text+0xd4): first defined here drivers/media/platform/soc_camera/built-in.o: In function `soc_mbus_bytes_per_line': (.text+0x375c): multiple definition of `soc_mbus_bytes_per_line' drivers/media/platform/soc_camera/soc_mediabus.o:(.text+0x50): first defined here --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: Binary data
drivers/media/v4l2-core/videobuf2-dma-contig.c:486:2: error: implicit declaration of function 'dma_get_cache_alignment'
Hi Hans,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 98ac9a608dc79ba8a20cee77fe959a6dfccdaa63
commit: c1023ba74fc77dc56dc317bd98f5060aab889ac1 [media]
drivers/media/platform/Kconfig: fix VIDEO_MEDIATEK_VCODEC dependency
date: 9 weeks ago
config: m32r-allmodconfig (attached as .config)
compiler: m32r-linux-gcc (GCC) 4.9.0
reproduce:
wget
https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross
-O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout c1023ba74fc77dc56dc317bd98f5060aab889ac1
# save the attached .config to linux build tree
make.cross ARCH=m32r
All errors (new ones prefixed by >>):
drivers/media/v4l2-core/videobuf2-dma-contig.c: In function
'vb2_dc_get_userptr':
>> drivers/media/v4l2-core/videobuf2-dma-contig.c:486:2: error: implicit
>> declaration of function 'dma_get_cache_alignment'
>> [-Werror=implicit-function-declaration]
unsigned long dma_align = dma_get_cache_alignment();
^
cc1: some warnings being treated as errors
vim +/dma_get_cache_alignment +486
drivers/media/v4l2-core/videobuf2-dma-contig.c
774d2301 drivers/media/v4l2-core/videobuf2-dma-contig.c Marek Szyprowski
2013-06-19 470 {
774d2301 drivers/media/v4l2-core/videobuf2-dma-contig.c Marek Szyprowski
2013-06-19 471 /* really, we cannot do anything better at this point */
774d2301 drivers/media/v4l2-core/videobuf2-dma-contig.c Marek Szyprowski
2013-06-19 472 return (dma_addr_t)(pfn) << PAGE_SHIFT;
774d2301 drivers/media/v4l2-core/videobuf2-dma-contig.c Marek Szyprowski
2013-06-19 473 }
774d2301 drivers/media/v4l2-core/videobuf2-dma-contig.c Marek Szyprowski
2013-06-19 474 #endif
774d2301 drivers/media/v4l2-core/videobuf2-dma-contig.c Marek Szyprowski
2013-06-19 475
36c0f8b3 drivers/media/v4l2-core/videobuf2-dma-contig.c Hans Verkuil
2016-04-15 476 static void *vb2_dc_get_userptr(struct device *dev, unsigned
long vaddr,
cd474037 drivers/media/v4l2-core/videobuf2-dma-contig.c Hans Verkuil
2014-11-18 477 unsigned long size, enum dma_data_direction dma_dir)
1a758d4e drivers/media/video/videobuf2-dma-contig.c Pawel Osciak
2010-10-11 478 {
1a758d4e drivers/media/video/videobuf2-dma-contig.c Pawel Osciak
2010-10-11 479 struct vb2_dc_buf *buf;
fb639eb3 drivers/media/v4l2-core/videobuf2-dma-contig.c Jan Kara
2015-07-13 480 struct frame_vector *vec;
e15dab75 drivers/media/v4l2-core/videobuf2-dma-contig.c Tomasz Stanislawski
2012-06-14 481 unsigned long offset;
fb639eb3 drivers/media/v4l2-core/videobuf2-dma-contig.c Jan Kara
2015-07-13 482 int n_pages, i;
e15dab75 drivers/media/v4l2-core/videobuf2-dma-contig.c Tomasz Stanislawski
2012-06-14 483 int ret = 0;
e15dab75 drivers/media/v4l2-core/videobuf2-dma-contig.c Tomasz Stanislawski
2012-06-14 484 struct sg_table *sgt;
e15dab75 drivers/media/v4l2-core/videobuf2-dma-contig.c Tomasz Stanislawski
2012-06-14 485 unsigned long contig_size;
d81e870d drivers/media/v4l2-core/videobuf2-dma-contig.c Marek Szyprowski
2012-06-12 @486 unsigned long dma_align = dma_get_cache_alignment();
251a79f8 drivers/media/v4l2-core/videobuf2-dma-contig.c Hans Verkuil
2014-11-18 487 DEFINE_DMA_ATTRS(attrs);
251a79f8 drivers/media/v4l2-core/videobuf2-dma-contig.c Hans Verkuil
2014-11-18 488
251a79f8 drivers/media/v4l2-core/videobuf2-dma-contig.c Hans Verkuil
2014-11-18 489 dma_set_attr(DMA_ATTR_SKIP_CPU_SYNC, &attrs);
d81e870d drivers/media/v4l2-core/videobuf2-dma-contig.c Marek Szyprowski
2012-06-12 490
d81e870d drivers/media/v4l2-core/videobuf2-dma-contig.c Marek Szyprowski
2012-06-12 491 /* Only cache aligned DMA transfers are reliable */
d81e870d drivers/media/v4l2-core/videobuf2-dma-contig.c Marek Szyprowski
2012-06-12 492 if (!IS_ALIGNED(vaddr | size, dma_align)) {
d81e870d drivers/media/v4l2-core/videobuf2-dma-contig.c Marek Szyprowski
2012-06-12 493 pr_debug("user data must be aligned to %lu
bytes\n", dma_align);
d81e870d drivers/media/v4l2-core/videobuf2-dma-contig.c Marek Szyprowski
2012-06-12 494 return ERR_PTR(-EINVAL);
:: The code at line 486 was first introduced by commit
:: d81e870d5afa1b0a95ea94c4052d3c7e973fae8c [media] v4l: vb2-dma-contig:
fail if user ptr buffer is not correctly aligned
:: TO: Marek Szyprowski
:: CC: Mauro Carvalho Chehab
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: Binary data
Re: [PATCH] [media] vivid: support for contiguous DMA buffers
Hi Vincent, [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.8-rc6 next-20160909] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] [Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on] [Check https://git-scm.com/docs/git-format-patch for more information] url: https://github.com/0day-ci/linux/commits/Vincent-Abriou/vivid-support-for-contiguous-DMA-buffers/20160909-212653 base: git://linuxtv.org/media_tree.git master config: m32r-allyesconfig (attached as .config) compiler: m32r-linux-gcc (GCC) 4.9.0 reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=m32r All warnings (new ones prefixed by >>): warning: (VIDEO_MEDIATEK_VCODEC && VIDEO_VIVID) selects VIDEOBUF2_DMA_CONTIG which has unmet direct dependencies (MEDIA_SUPPORT && HAS_DMA) --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: Binary data
[linux-review:Mauro-Carvalho-Chehab/Don-t-use-stack-for-DMA-transers-on-dvb-usb-drivers/20161008-021635 21/26] drivers/media/usb/dvb-usb/pctv452e.c:113:26: error: expected expression before '||' token
tree: https://github.com/0day-ci/linux
Mauro-Carvalho-Chehab/Don-t-use-stack-for-DMA-transers-on-dvb-usb-drivers/20161008-021635
head: 01e4e9b657c0de0c857817353b4ffbb3da5b9cb3
commit: 71eb7f5998d859d9de08128ebd4f3187b5f9fcbf [21/26] pctv452e: don't call
BUG_ON() on non-fatal error
config: x86_64-rhel (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
git checkout 71eb7f5998d859d9de08128ebd4f3187b5f9fcbf
# save the attached .config to linux build tree
make ARCH=x86_64
All error/warnings (new ones prefixed by >>):
drivers/media/usb/dvb-usb/pctv452e.c: In function 'tt3650_ci_msg':
>> drivers/media/usb/dvb-usb/pctv452e.c:112:19: warning: suggest parentheses
>> around '&&' within '||' [-Wparentheses]
if (NULL == data && 0 != (write_len | read_len) ||
>> drivers/media/usb/dvb-usb/pctv452e.c:113:26: error: expected expression
>> before '||' token
write_len > 64 - 4) || (read_len > 64 - 4)) {
^~
drivers/media/usb/dvb-usb/pctv452e.c:112:2: warning: this 'if' clause does
not guard... [-Wmisleading-indentation]
if (NULL == data && 0 != (write_len | read_len) ||
^~
drivers/media/usb/dvb-usb/pctv452e.c:113:48: note: ...this statement, but
the latter is misleadingly indented as if it is guarded by the 'if'
write_len > 64 - 4) || (read_len > 64 - 4)) {
^
>> drivers/media/usb/dvb-usb/pctv452e.c:113:48: error: expected statement
>> before ')' token
vim +113 drivers/media/usb/dvb-usb/pctv452e.c
106 {
107 struct pctv452e_state *state = (struct pctv452e_state *)d->priv;
108 u8 id;
109 unsigned int rlen;
110 int ret;
111
> 112 if (NULL == data && 0 != (write_len | read_len) ||
> 113 write_len > 64 - 4) || (read_len > 64 - 4)) {
114 ret = -EIO;
115 goto failed;
116 };
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
[linux-review:Mauro-Carvalho-Chehab/Don-t-use-stack-for-DMA-transers-on-dvb-usb-drivers/20161008-021635 21/26] drivers/media/usb/dvb-usb/pctv452e.c:112:2: warning: this 'if' clause does not guard...
tree: https://github.com/0day-ci/linux
Mauro-Carvalho-Chehab/Don-t-use-stack-for-DMA-transers-on-dvb-usb-drivers/20161008-021635
head: 01e4e9b657c0de0c857817353b4ffbb3da5b9cb3
commit: 71eb7f5998d859d9de08128ebd4f3187b5f9fcbf [21/26] pctv452e: don't call
BUG_ON() on non-fatal error
config: sparc64-allmodconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
wget
https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross
-O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 71eb7f5998d859d9de08128ebd4f3187b5f9fcbf
# save the attached .config to linux build tree
make.cross ARCH=sparc64
All warnings (new ones prefixed by >>):
drivers/media/usb/dvb-usb/pctv452e.c: In function 'tt3650_ci_msg':
drivers/media/usb/dvb-usb/pctv452e.c:112:19: warning: suggest parentheses
around '&&' within '||' [-Wparentheses]
if (NULL == data && 0 != (write_len | read_len) ||
drivers/media/usb/dvb-usb/pctv452e.c:113:26: error: expected expression
before '||' token
write_len > 64 - 4) || (read_len > 64 - 4)) {
^~
>> drivers/media/usb/dvb-usb/pctv452e.c:112:2: warning: this 'if' clause does
>> not guard... [-Wmisleading-indentation]
if (NULL == data && 0 != (write_len | read_len) ||
^~
drivers/media/usb/dvb-usb/pctv452e.c:113:48: note: ...this statement, but
the latter is misleadingly indented as if it is guarded by the 'if'
write_len > 64 - 4) || (read_len > 64 - 4)) {
^
drivers/media/usb/dvb-usb/pctv452e.c:113:48: error: expected statement
before ')' token
vim +/if +112 drivers/media/usb/dvb-usb/pctv452e.c
96
97 u8 c; /* transaction counter, wraps around... */
98 u8 initialized; /* set to 1 if 0x15 has been sent */
99 u16 last_rc_key;
100
101 unsigned char data[80];
102 };
103
104 static int tt3650_ci_msg(struct dvb_usb_device *d, u8 cmd, u8 *data,
105 unsigned int write_len, unsigned int read_len)
106 {
107 struct pctv452e_state *state = (struct pctv452e_state *)d->priv;
108 u8 id;
109 unsigned int rlen;
110 int ret;
111
> 112 if (NULL == data && 0 != (write_len | read_len) ||
113 write_len > 64 - 4) || (read_len > 64 - 4)) {
114 ret = -EIO;
115 goto failed;
116 };
117
118 id = state->c++;
119
120 state->data[0] = SYNC_BYTE_OUT;
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
[linux-review:Mauro-Carvalho-Chehab/Don-t-use-stack-for-DMA-transers-on-media-usb-drivers/20161011-182408 22/31] drivers/media/usb/dvb-usb/pctv452e.c:115:2-3: Unneeded semicolon
tree: https://github.com/0day-ci/linux Mauro-Carvalho-Chehab/Don-t-use-stack-for-DMA-transers-on-media-usb-drivers/20161011-182408 head: ff49f775552fe4ebe2944527cf882073679cb1e5 commit: 4bafb476079bf7e4aa258248cfa853f130c46c8c [22/31] pctv452e: don't call BUG_ON() on non-fatal error coccinelle warnings: (new ones prefixed by >>) >> drivers/media/usb/dvb-usb/pctv452e.c:115:2-3: Unneeded semicolon Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] pctv452e: fix semicolon.cocci warnings
drivers/media/usb/dvb-usb/pctv452e.c:115:2-3: Unneeded semicolon
Remove unneeded semicolon.
Generated by: scripts/coccinelle/misc/semicolon.cocci
CC: Mauro Carvalho Chehab
Signed-off-by: Fengguang Wu
---
pctv452e.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/media/usb/dvb-usb/pctv452e.c
+++ b/drivers/media/usb/dvb-usb/pctv452e.c
@@ -112,7 +112,7 @@ static int tt3650_ci_msg(struct dvb_usb_
if (!data || (write_len > 64 - 4) || (read_len > 64 - 4)) {
err("%s: transfer data invalid", __func__);
return -EIO;
- };
+ }
mutex_lock(&state->ca_mutex);
id = state->c++;
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[linux-next:master 5319/5462] drivers/media/rc/lirc_dev.c:368:2: warning: 'txbuf' may be used uninitialized in this function
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: a5791b188fb25ff731d01d1c463b01a99c58f930
commit: d60ea519eb2fbee045ca18a26bd37d5949ac4f87 [5319/5462] Merge
remote-tracking branch 'v4l-dvb/master'
config: xtensa-allmodconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 7.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout d60ea519eb2fbee045ca18a26bd37d5949ac4f87
# save the attached .config to linux build tree
make.cross ARCH=xtensa
Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings
All warnings (new ones prefixed by >>):
drivers/media/rc/lirc_dev.c: In function 'ir_lirc_transmit_ir':
>> drivers/media/rc/lirc_dev.c:368:2: warning: 'txbuf' may be used
>> uninitialized in this function [-Wmaybe-uninitialized]
kfree(txbuf);
^~~~
vim +/txbuf +368 drivers/media/rc/lirc_dev.c
74c839b2f drivers/media/rc/lirc_dev.c Sean Young 2017-01-30 228
42e0442f8 drivers/media/rc/lirc_dev.c Sean Young 2017-11-02 229
static ssize_t ir_lirc_transmit_ir(struct file *file, const char __user *buf,
42e0442f8 drivers/media/rc/lirc_dev.c Sean Young 2017-11-02 230
size_t n, loff_t *ppos)
42e0442f8 drivers/media/rc/lirc_dev.c Sean Young 2017-11-02 231 {
7e45d660e drivers/media/rc/lirc_dev.c Sean Young 2017-11-02 232
struct lirc_fh *fh = file->private_data;
7e45d660e drivers/media/rc/lirc_dev.c Sean Young 2017-11-02 233
struct rc_dev *dev = fh->rc;
a74b2bff5 drivers/media/rc/lirc_dev.c Sean Young 2017-12-13 234
unsigned int *txbuf;
42e0442f8 drivers/media/rc/lirc_dev.c Sean Young 2017-11-02 235
struct ir_raw_event *raw = NULL;
4957133fe drivers/media/rc/lirc_dev.c Sean Young 2017-11-04 236
ssize_t ret;
42e0442f8 drivers/media/rc/lirc_dev.c Sean Young 2017-11-02 237
size_t count;
42e0442f8 drivers/media/rc/lirc_dev.c Sean Young 2017-11-02 238
ktime_t start;
42e0442f8 drivers/media/rc/lirc_dev.c Sean Young 2017-11-02 239
s64 towait;
42e0442f8 drivers/media/rc/lirc_dev.c Sean Young 2017-11-02 240
unsigned int duration = 0; /* signal duration in us */
42e0442f8 drivers/media/rc/lirc_dev.c Sean Young 2017-11-02 241
int i;
42e0442f8 drivers/media/rc/lirc_dev.c Sean Young 2017-11-02 242
4957133fe drivers/media/rc/lirc_dev.c Sean Young 2017-11-04 243
ret = mutex_lock_interruptible(&dev->lock);
4957133fe drivers/media/rc/lirc_dev.c Sean Young 2017-11-04 244
if (ret)
4957133fe drivers/media/rc/lirc_dev.c Sean Young 2017-11-04 245
return ret;
4a62a5ab5 drivers/media/IR/lirc_dev.c Jarod Wilson2010-07-03 246
4957133fe drivers/media/rc/lirc_dev.c Sean Young 2017-11-04 247
if (!dev->registered) {
4957133fe drivers/media/rc/lirc_dev.c Sean Young 2017-11-04 248
ret = -ENODEV;
a74b2bff5 drivers/media/rc/lirc_dev.c Sean Young 2017-12-13 249
goto out_unlock;
4a62a5ab5 drivers/media/IR/lirc_dev.c Jarod Wilson2010-07-03 250
}
4a62a5ab5 drivers/media/IR/lirc_dev.c Jarod Wilson2010-07-03 251
42e0442f8 drivers/media/rc/lirc_dev.c Sean Young 2017-11-02 252
start = ktime_get();
4a62a5ab5 drivers/media/IR/lirc_dev.c Jarod Wilson2010-07-03 253
42e0442f8 drivers/media/rc/lirc_dev.c Sean Young 2017-11-02 254
if (!dev->tx_ir) {
42e0442f8 drivers/media/rc/lirc_dev.c Sean Young 2017-11-02 255
ret = -EINVAL;
a74b2bff5 drivers/media/rc/lirc_dev.c Sean Young 2017-12-13 256
goto out_unlock;
42e0442f8 drivers/media/rc/lirc_dev.c Sean Young 2017-11-02 257
}
4a62a5ab5 drivers/media/IR/lirc_dev.c Jarod Wilson2010-07-03 258
7e45d660e drivers/media/rc/lirc_dev.c Sean Young 2017-11-02 259
if (fh->send_mode == LIRC_MODE_SCANCODE) {
42e0442f8 drivers/media/rc/lirc_dev.c Sean Young 2017-11-02 260
struct lirc_scancode scan;
3381b779a drivers/media/rc/lirc_dev.c David Härdeman 2017-06-30 261
4957133fe drivers/media/rc/lirc_dev.c Sean Young 2017-11-04 262
if (n != sizeof(scan)) {
4957133fe drivers/media/rc/lirc_dev.c Sean Young 2017-11-04 263
ret = -EINVAL;
a74b2bff5 drivers/media/rc/lirc_dev.c Sean Young 2017-12-13 264
goto out_unlock;
3381b779a drivers/media/rc/lirc_dev.c David Härdeman 2017-06-30 265
}
3381b779a drivers/media/rc/lirc_dev.c David Härdeman 2017-06-30 266
4957133fe driv
Re: [PATCH v2 2/2] media: coda: Add i.MX51 (CodaHx4) support
Hi Philipp,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v4.15-rc4 next-20171220]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Philipp-Zabel/media-dt-bindings-coda-Add-compatible-for-CodaHx4-on-i-MX51/20171221-050217
base: git://linuxtv.org/media_tree.git master
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings
All warnings (new ones prefixed by >>):
drivers/media/platform/coda/coda-bit.c: In function 'coda_setup_iram':
>> drivers/media/platform/coda/coda-bit.c:648:28: warning: 'me_bits' may be
>> used uninitialized in this function [-Wmaybe-uninitialized]
iram_info->axi_sram_use |= me_bits;
^~
vim +/me_bits +648 drivers/media/platform/coda/coda-bit.c
588
589 static void coda_setup_iram(struct coda_ctx *ctx)
590 {
591 struct coda_iram_info *iram_info = &ctx->iram_info;
592 struct coda_dev *dev = ctx->dev;
593 int w64, w128;
594 int mb_width;
595 int dbk_bits;
596 int bit_bits;
597 int ip_bits;
598 int me_bits;
599
600 memset(iram_info, 0, sizeof(*iram_info));
601 iram_info->next_paddr = dev->iram.paddr;
602 iram_info->remaining = dev->iram.size;
603
604 if (!dev->iram.vaddr)
605 return;
606
607 switch (dev->devtype->product) {
608 case CODA_HX4:
609 dbk_bits = CODA7_USE_HOST_DBK_ENABLE;
610 bit_bits = CODA7_USE_HOST_BIT_ENABLE;
611 ip_bits = CODA7_USE_HOST_IP_ENABLE;
612 me_bits = CODA7_USE_HOST_ME_ENABLE;
613 break;
614 case CODA_7541:
615 dbk_bits = CODA7_USE_HOST_DBK_ENABLE |
CODA7_USE_DBK_ENABLE;
616 bit_bits = CODA7_USE_HOST_BIT_ENABLE |
CODA7_USE_BIT_ENABLE;
617 ip_bits = CODA7_USE_HOST_IP_ENABLE |
CODA7_USE_IP_ENABLE;
618 me_bits = CODA7_USE_HOST_ME_ENABLE |
CODA7_USE_ME_ENABLE;
619 break;
620 case CODA_960:
621 dbk_bits = CODA9_USE_HOST_DBK_ENABLE |
CODA9_USE_DBK_ENABLE;
622 bit_bits = CODA9_USE_HOST_BIT_ENABLE |
CODA7_USE_BIT_ENABLE;
623 ip_bits = CODA9_USE_HOST_IP_ENABLE |
CODA7_USE_IP_ENABLE;
624 break;
625 default: /* CODA_DX6 */
626 return;
627 }
628
629 if (ctx->inst_type == CODA_INST_ENCODER) {
630 struct coda_q_data *q_data_src;
631
632 q_data_src = get_q_data(ctx,
V4L2_BUF_TYPE_VIDEO_OUTPUT);
633 mb_width = DIV_ROUND_UP(q_data_src->width, 16);
634 w128 = mb_width * 128;
635 w64 = mb_width * 64;
636
637 /* Prioritize in case IRAM is too small for everything
*/
638 if (dev->devtype->product == CODA_HX4 ||
639 dev->devtype->product == CODA_7541) {
640 iram_info->search_ram_size = round_up(mb_width
* 16 *
64136 +
2048, 1024);
642 iram_info->search_ram_paddr =
coda_iram_alloc(iram_info,
643
iram_info->search_ram_size);
644 if (!iram_info->search_ram_paddr) {
645 pr_err("IRAM is smaller than the search
ram size\n");
646 goto out;
647 }
> 648 iram_info->axi_sram_use |= me_bits;
649 }
650
651 /* Only H.264BP and H.263P3 are considered */
652 iram_info->buf_dbk_y_use = coda_iram_alloc(iram_info,
w64);
653 iram_info->buf_dbk_c_use = coda_iram_alloc(iram_info,
w64);
654 if (!iram_info->buf_dbk_c_use)
655 goto out;
656 iram_info->axi_sram_use |= dbk_bits;
657
658 iram_info->buf_bit_use = coda_iram_alloc(iram_info,
w128);
659 if (!iram_info->buf_bit_use)
660 goto out;
661 iram_info->axi_sram_use |= bit_bits;
662
663 iram_info->buf_ip_ac_dc_use =
coda_ira
Re: [PATCH v4 14/18] scripts: kernel-doc: print the declaration name on warnings
Hi Mauro,
I love your patch! Perhaps something to improve:
[auto build test WARNING on lwn/docs-next]
[also build test WARNING on v4.15-rc4 next-20171220]
[cannot apply to linus/master]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/kernel-doc-add-supported-to-document-nested-structs/20171221-055609
base: git://git.lwn.net/linux-2.6 docs-next
reproduce: make htmldocs
All warnings (new ones prefixed by >>):
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.30), passed through in regex; marked by <-- HERE in
m/(struct|union)([^{};]+){ <-- HERE ([^{}]*)}([^{}\;]*)\;/ at
scripts/kernel-doc line 1036.
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.30), passed through in regex; marked by <-- HERE in
m/(struct|union)([^{};]+){ <-- HERE ([^{}]*)}([^{}\;]*)\;/ at
scripts/kernel-doc line 1058.
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.30), passed through in regex; marked by <-- HERE in
m/(struct|union)([^{};]+){ <-- HERE ([^{}]*)}([^{}\;]*)\;/ at
scripts/kernel-doc line 1036.
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.30), passed through in regex; marked by <-- HERE in
m/(struct|union)([^{};]+){ <-- HERE ([^{}]*)}([^{}\;]*)\;/ at
scripts/kernel-doc line 1058.
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.30), passed through in regex; marked by <-- HERE in
m/(struct|union)([^{};]+){ <-- HERE ([^{}]*)}([^{}\;]*)\;/ at
scripts/kernel-doc line 1036.
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.30), passed through in regex; marked by <-- HERE in
m/(struct|union)([^{};]+){ <-- HERE ([^{}]*)}([^{}\;]*)\;/ at
scripts/kernel-doc line 1058.
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.30), passed through in regex; marked by <-- HERE in
m/(struct|union)([^{};]+){ <-- HERE ([^{}]*)}([^{}\;]*)\;/ at
scripts/kernel-doc line 1036.
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.30), passed through in regex; marked by <-- HERE in
m/(struct|union)([^{};]+){ <-- HERE ([^{}]*)}([^{}\;]*)\;/ at
scripts/kernel-doc line 1058.
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.30), passed through in regex; marked by <-- HERE in
m/(struct|union)([^{};]+){ <-- HERE ([^{}]*)}([^{}\;]*)\;/ at
scripts/kernel-doc line 1036.
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.30), passed through in regex; marked by <-- HERE in
m/(struct|union)([^{};]+){ <-- HERE ([^{}]*)}([^{}\;]*)\;/ at
scripts/kernel-doc line 1058.
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.30), passed through in regex; marked by <-- HERE in
m/(struct|union)([^{};]+){ <-- HERE ([^{}]*)}([^{}\;]*)\;/ at
scripts/kernel-doc line 1036.
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.30), passed through in regex; marked by <-- HERE in
m/(struct|union)([^{};]+){ <-- HERE ([^{}]*)}([^{}\;]*)\;/ at
scripts/kernel-doc line 1058.
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.30), passed through in regex; marked by <-- HERE in
m/(struct|union)([^{};]+){ <-- HERE ([^{}]*)}([^{}\;]*)\;/ at
scripts/kernel-doc line 1036.
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.30), passed through in regex; marked by <-- HERE in
m/(struct|union)([^{};]+){ <-- HERE ([^{}]*)}([^{}\;]*)\;/ at
scripts/kernel-doc line 1058.
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.30), passed through in regex; marked by <-- HERE in
m/(struct|union)([^{};]+){ <-- HERE ([^{}]*)}([^{}\;]*)\;/ at
scripts/kernel-doc line 1036.
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.30), passed through in regex; marked by <-- HERE in
m/(struct|union)([^{};]+){ <-- HERE ([^{}]*)}([^{}\;]*)\;/ at
scripts/kernel-doc line 1058.
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.30), passed through in regex; marked by <-- HERE in
m/(struct|union)([^{};]+){ <-- HERE ([^{}]*)}([^{}\;]*)\;/ at
scripts/kernel-doc line 1036.
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.30), passed through in regex; marked by <-- HERE in
m/(struct|union)([^{};]+){ <-- HERE ([^{}]*)}([^{}\;]*)\;/ at
scripts/kernel-doc line 1058.
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.30), passed through in regex; marked by <-- HERE in
m/(struct|union)([^{};]+){ <-- HERE ([^{}]*)}([^{}\;]*)\;/ at
scripts/kernel-doc line 1036.
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.30), passed through in regex; marked by <--
Re: [PATCH v4 15/18] scripts: kernel-doc: handle nested struct function arguments
Hi Mauro,
I love your patch! Perhaps something to improve:
[auto build test WARNING on lwn/docs-next]
[also build test WARNING on v4.15-rc4 next-20171221]
[cannot apply to linus/master]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/kernel-doc-add-supported-to-document-nested-structs/20171221-055609
base: git://git.lwn.net/linux-2.6 docs-next
reproduce: make htmldocs
All warnings (new ones prefixed by >>):
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.30), passed through in regex; marked by <-- HERE in
m/(struct|union)([^{};]+){ <-- HERE ([^{}]*)}([^{}\;]*)\;/ at
scripts/kernel-doc line 1036.
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.30), passed through in regex; marked by <-- HERE in
m/(struct|union)([^{};]+){ <-- HERE ([^{}]*)}([^{}\;]*)\;/ at
scripts/kernel-doc line 1072.
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.30), passed through in regex; marked by <-- HERE in
m/(struct|union)([^{};]+){ <-- HERE ([^{}]*)}([^{}\;]*)\;/ at
scripts/kernel-doc line 1036.
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.30), passed through in regex; marked by <-- HERE in
m/(struct|union)([^{};]+){ <-- HERE ([^{}]*)}([^{}\;]*)\;/ at
scripts/kernel-doc line 1072.
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.30), passed through in regex; marked by <-- HERE in
m/(struct|union)([^{};]+){ <-- HERE ([^{}]*)}([^{}\;]*)\;/ at
scripts/kernel-doc line 1036.
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.30), passed through in regex; marked by <-- HERE in
m/(struct|union)([^{};]+){ <-- HERE ([^{}]*)}([^{}\;]*)\;/ at
scripts/kernel-doc line 1072.
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.30), passed through in regex; marked by <-- HERE in
m/(struct|union)([^{};]+){ <-- HERE ([^{}]*)}([^{}\;]*)\;/ at
scripts/kernel-doc line 1036.
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.30), passed through in regex; marked by <-- HERE in
m/(struct|union)([^{};]+){ <-- HERE ([^{}]*)}([^{}\;]*)\;/ at
scripts/kernel-doc line 1072.
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.30), passed through in regex; marked by <-- HERE in
m/(struct|union)([^{};]+){ <-- HERE ([^{}]*)}([^{}\;]*)\;/ at
scripts/kernel-doc line 1036.
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.30), passed through in regex; marked by <-- HERE in
m/(struct|union)([^{};]+){ <-- HERE ([^{}]*)}([^{}\;]*)\;/ at
scripts/kernel-doc line 1072.
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.30), passed through in regex; marked by <-- HERE in
m/(struct|union)([^{};]+){ <-- HERE ([^{}]*)}([^{}\;]*)\;/ at
scripts/kernel-doc line 1036.
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.30), passed through in regex; marked by <-- HERE in
m/(struct|union)([^{};]+){ <-- HERE ([^{}]*)}([^{}\;]*)\;/ at
scripts/kernel-doc line 1072.
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.30), passed through in regex; marked by <-- HERE in
m/(struct|union)([^{};]+){ <-- HERE ([^{}]*)}([^{}\;]*)\;/ at
scripts/kernel-doc line 1036.
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.30), passed through in regex; marked by <-- HERE in
m/(struct|union)([^{};]+){ <-- HERE ([^{}]*)}([^{}\;]*)\;/ at
scripts/kernel-doc line 1072.
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.30), passed through in regex; marked by <-- HERE in
m/(struct|union)([^{};]+){ <-- HERE ([^{}]*)}([^{}\;]*)\;/ at
scripts/kernel-doc line 1036.
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.30), passed through in regex; marked by <-- HERE in
m/(struct|union)([^{};]+){ <-- HERE ([^{}]*)}([^{}\;]*)\;/ at
scripts/kernel-doc line 1072.
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.30), passed through in regex; marked by <-- HERE in
m/(struct|union)([^{};]+){ <-- HERE ([^{}]*)}([^{}\;]*)\;/ at
scripts/kernel-doc line 1036.
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.30), passed through in regex; marked by <-- HERE in
m/(struct|union)([^{};]+){ <-- HERE ([^{}]*)}([^{}\;]*)\;/ at
scripts/kernel-doc line 1072.
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.30), passed through in regex; marked by <-- HERE in
m/(struct|union)([^{};]+){ <-- HERE ([^{}]*)}([^{}\;]*)\;/ at
scripts/kernel-doc line 1036.
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.30), passed through in regex; marked by <--
Re: [PATCH v4 16/18] scripts: kernel-doc: improve nested logic to handle multiple identifiers
Hi Mauro, I love your patch! Perhaps something to improve: [auto build test WARNING on lwn/docs-next] [also build test WARNING on v4.15-rc4 next-20171221] [cannot apply to linus/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/kernel-doc-add-supported-to-document-nested-structs/20171221-055609 base: git://git.lwn.net/linux-2.6 docs-next reproduce: make htmldocs All warnings (new ones prefixed by >>): WARNING: convert(1) not found, for SVG to PDF conversion install ImageMagick (https://www.imagemagick.org) include/crypto/hash.h:89: warning: duplicate section name 'Note' include/crypto/hash.h:95: warning: duplicate section name 'Note' include/crypto/hash.h:102: warning: duplicate section name 'Note' include/crypto/hash.h:89: warning: duplicate section name 'Note' include/crypto/hash.h:95: warning: duplicate section name 'Note' include/crypto/hash.h:102: warning: duplicate section name 'Note' include/crypto/hash.h:89: warning: duplicate section name 'Note' include/crypto/hash.h:95: warning: duplicate section name 'Note' include/crypto/hash.h:102: warning: duplicate section name 'Note' include/crypto/hash.h:89: warning: duplicate section name 'Note' include/crypto/hash.h:95: warning: duplicate section name 'Note' include/crypto/hash.h:102: warning: duplicate section name 'Note' include/crypto/hash.h:89: warning: duplicate section name 'Note' include/crypto/hash.h:95: warning: duplicate section name 'Note' include/crypto/hash.h:102: warning: duplicate section name 'Note' include/crypto/hash.h:89: warning: duplicate section name 'Note' include/crypto/hash.h:95: warning: duplicate section name 'Note' include/crypto/hash.h:102: warning: duplicate section name 'Note' include/crypto/hash.h:89: warning: duplicate section name 'Note' include/crypto/hash.h:95: warning: duplicate section name 'Note' include/crypto/hash.h:102: warning: duplicate section name 'Note' include/crypto/hash.h:89: warning: duplicate section name 'Note' include/crypto/hash.h:95: warning: duplicate section name 'Note' include/crypto/hash.h:102: warning: duplicate section name 'Note' include/linux/crypto.h:469: warning: Function parameter or member 'cra_u.ablkcipher' not described in 'crypto_alg' include/linux/crypto.h:469: warning: Function parameter or member 'cra_u.blkcipher' not described in 'crypto_alg' include/linux/crypto.h:469: warning: Function parameter or member 'cra_u.cipher' not described in 'crypto_alg' include/linux/crypto.h:469: warning: Function parameter or member 'cra_u.compress' not described in 'crypto_alg' include/linux/crypto.h:469: warning: Function parameter or member 'cra_u.ablkcipher' not described in 'crypto_alg' include/linux/crypto.h:469: warning: Function parameter or member 'cra_u.blkcipher' not described in 'crypto_alg' include/linux/crypto.h:469: warning: Function parameter or member 'cra_u.cipher' not described in 'crypto_alg' include/linux/crypto.h:469: warning: Function parameter or member 'cra_u.compress' not described in 'crypto_alg' include/linux/crypto.h:469: warning: Function parameter or member 'cra_u.ablkcipher' not described in 'crypto_alg' include/linux/crypto.h:469: warning: Function parameter or member 'cra_u.blkcipher' not described in 'crypto_alg' include/linux/crypto.h:469: warning: Function parameter or member 'cra_u.cipher' not described in 'crypto_alg' include/linux/crypto.h:469: warning: Function parameter or member 'cra_u.compress' not described in 'crypto_alg' include/linux/crypto.h:469: warning: Function parameter or member 'cra_u.ablkcipher' not described in 'crypto_alg' include/linux/crypto.h:469: warning: Function parameter or member 'cra_u.blkcipher' not described in 'crypto_alg' include/linux/crypto.h:469: warning: Function parameter or member 'cra_u.cipher' not described in 'crypto_alg' include/linux/crypto.h:469: warning: Function parameter or member 'cra_u.compress' not described in 'crypto_alg' include/linux/crypto.h:469: warning: Function parameter or member 'cra_u.ablkcipher' not described in 'crypto_alg' include/linux/crypto.h:469: warning: Function parameter or member 'cra_u.blkcipher' not described in 'crypto_alg' include/linux/crypto.h:469: warning: Function parameter or member 'cra_u.cipher' not described in 'crypto_alg' include/linux/crypto.h:469: warning: Function parameter or member 'cra_u.compress' not described in 'crypto_alg' include/linux/crypto.h:469: warning: Function parameter or member 'cra_u.ablkcipher' not described in 'crypto_alg' include/linux/crypto.h:469: warning: Function parameter or member 'cra_u.blkcipher' not described in 'crypto_alg' include/linux/crypto.h:469: warning: Function parameter or member 'cra_u.cipher' not described in 'crypto_alg' includ
Re: [PATCH 1/4] media: ov5695: add support for OV5695 sensor
Hi Shunqian,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v4.15-rc5 next-20171222]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Shunqian-Zheng/media-ov5695-add-support-for-OV5695-sensor/20171226-110821
base: git://linuxtv.org/media_tree.git master
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
vim +713 drivers/media/i2c/ov5695.c
697
698 /* Write registers up to 4 at a time */
699 static int ov5695_write_reg(struct i2c_client *client, u16 reg,
700 unsigned int len, u32 val)
701 {
702 int buf_i;
703 int val_i;
704 u8 buf[6];
705 u8 *val_p;
706
707 if (len > 4)
708 return -EINVAL;
709
710 buf[0] = reg >> 8;
711 buf[1] = reg & 0xff;
712
> 713 val = cpu_to_be32(val);
714 val_p = (u8 *)&val;
715 buf_i = 2;
716 val_i = 4 - len;
717
718 while (val_i < 4)
719 buf[buf_i++] = val_p[val_i++];
720
721 if (i2c_master_send(client, buf, len + 2) != len + 2)
722 return -EIO;
723
724 return 0;
725 }
726
727 static int ov5695_write_array(struct i2c_client *client,
728const struct regval *regs)
729 {
730 int i, ret = 0;
731
732 for (i = 0; ret == 0 && regs[i].addr != REG_NULL; i++)
733 ret = ov5695_write_reg(client, regs[i].addr,
734 OV5695_REG_VALUE_08BIT,
regs[i].val);
735
736 return ret;
737 }
738
739 /* Read registers up to 4 at a time */
740 static int ov5695_read_reg(struct i2c_client *client, u16 reg, unsigned
int len,
741 u32 *val)
742 {
743 struct i2c_msg msgs[2];
744 u8 *data_be_p;
745 u32 data_be = 0;
> 746 u16 reg_addr_be = cpu_to_be16(reg);
747 int ret;
748
749 if (len > 4)
750 return -EINVAL;
751
752 data_be_p = (u8 *)&data_be;
753 /* Write register address */
754 msgs[0].addr = client->addr;
755 msgs[0].flags = 0;
756 msgs[0].len = 2;
757 msgs[0].buf = (u8 *)®_addr_be;
758
759 /* Read data from register */
760 msgs[1].addr = client->addr;
761 msgs[1].flags = I2C_M_RD;
762 msgs[1].len = len;
763 msgs[1].buf = &data_be_p[4 - len];
764
765 ret = i2c_transfer(client->adapter, msgs, ARRAY_SIZE(msgs));
766 if (ret != ARRAY_SIZE(msgs))
767 return -EIO;
768
> 769 *val = be32_to_cpu(data_be);
770
771 return 0;
772 }
773
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Re: [PATCH 3/4] media: ov2685: add support for OV2685 sensor
Hi Shunqian,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v4.15-rc5 next-20171222]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Shunqian-Zheng/media-ov5695-add-support-for-OV5695-sensor/20171226-110821
base: git://linuxtv.org/media_tree.git master
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
vim +248 drivers/media/i2c/ov2685.c
232
233 /* Write registers up to 4 at a time */
234 static int ov2685_write_reg(struct i2c_client *client, u16 reg,
235 unsigned int len, u32 val)
236 {
237 int buf_i;
238 int val_i;
239 u8 buf[6];
240 u8 *val_p;
241
242 if (len > 4)
243 return -EINVAL;
244
245 buf[0] = reg >> 8;
246 buf[1] = reg & 0xff;
247
> 248 val = cpu_to_be32(val);
249 val_p = (u8 *)&val;
250 buf_i = 2;
251 val_i = 4 - len;
252
253 while (val_i < 4)
254 buf[buf_i++] = val_p[val_i++];
255
256 if (i2c_master_send(client, buf, len + 2) != len + 2)
257 return -EIO;
258
259 return 0;
260 }
261
262 static int ov2685_write_array(struct i2c_client *client,
263const struct regval *regs)
264 {
265 int i, ret = 0;
266
267 for (i = 0; ret == 0 && regs[i].addr != REG_NULL; i++)
268 ret = ov2685_write_reg(client, regs[i].addr,
269 OV2685_REG_VALUE_08BIT,
regs[i].val);
270
271 return ret;
272 }
273
274 /* Read registers up to 4 at a time */
275 static int ov2685_read_reg(struct i2c_client *client, u16 reg,
276 unsigned int len, u32 *val)
277 {
278 struct i2c_msg msgs[2];
279 u8 *data_be_p;
280 u32 data_be = 0;
> 281 u16 reg_addr_be = cpu_to_be16(reg);
282 int ret;
283
284 if (len > 4)
285 return -EINVAL;
286
287 data_be_p = (u8 *)&data_be;
288 /* Write register address */
289 msgs[0].addr = client->addr;
290 msgs[0].flags = 0;
291 msgs[0].len = 2;
292 msgs[0].buf = (u8 *)®_addr_be;
293
294 /* Read data from register */
295 msgs[1].addr = client->addr;
296 msgs[1].flags = I2C_M_RD;
297 msgs[1].len = len;
298 msgs[1].buf = &data_be_p[4 - len];
299
300 ret = i2c_transfer(client->adapter, msgs, ARRAY_SIZE(msgs));
301 if (ret != ARRAY_SIZE(msgs))
302 return -EIO;
303
> 304 *val = be32_to_cpu(data_be);
305
306 return 0;
307 }
308
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[PATCH] media: fix semicolon.cocci warnings
From: Fengguang Wu
drivers/media/common/videobuf/videobuf2-core.c:2525:34-35: Unneeded semicolon
Remove unneeded semicolon.
Generated by: scripts/coccinelle/misc/semicolon.cocci
Fixes: 03fbdb2fc2b8 ("media: move videobuf2 to drivers/media/common")
Signed-off-by: Fengguang Wu
---
videobuf2-core.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/media/common/videobuf/videobuf2-core.c
+++ b/drivers/media/common/videobuf/videobuf2-core.c
@@ -2522,7 +2522,7 @@ static int vb2_thread(void *data)
break;
call_void_qop(q, wait_finish, q);
if (copy_timestamp)
- vb->timestamp = ktime_get_ns();;
+ vb->timestamp = ktime_get_ns();
if (!threadio->stop)
ret = vb2_core_qbuf(q, vb->index, NULL);
call_void_qop(q, wait_prepare, q);
[linuxtv-media:master 3288/3291] drivers/media/common/videobuf/videobuf2-core.c:2525:34-35: Unneeded semicolon
tree: git://linuxtv.org/media_tree.git master head: a114a585be4f3173fe454921a0918fb7e71633b0 commit: 03fbdb2fc2b8bb27b0ee0534fd3e9c57cdc3854a [3288/3291] media: move videobuf2 to drivers/media/common config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025 reproduce: git checkout 03fbdb2fc2b8bb27b0ee0534fd3e9c57cdc3854a # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): In file included from drivers/media/common/videobuf/videobuf2-dvb.c:21:0: >> include/media/videobuf2-dvb.h:5:10: fatal error: dvbdev.h: No such file or >> directory #include ^~ compilation terminated. coccinelle warnings: (new ones prefixed by >>) >> drivers/media/common/videobuf/videobuf2-core.c:2525:34-35: Unneeded semicolon Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
[linuxtv-media:master 3281/3294] drivers/media/dvb-core/dvb_vb2.c:170: undefined reference to `vb2_vmalloc_memops'
tree: git://linuxtv.org/media_tree.git master
head: 201b56737f4ea59ee840ebdb88a9970ea6d49cf1
commit: 57868acc369ab73ec8f6b43a0c6749077376b189 [3281/3294] media: videobuf2:
Add new uAPI for DVB streaming I/O
config: i386-randconfig-n0-201752 (attached as .config)
compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025
reproduce:
git checkout 57868acc369ab73ec8f6b43a0c6749077376b189
# save the attached .config to linux build tree
make ARCH=i386
Note: the linuxtv-media/master HEAD 201b56737f4ea59ee840ebdb88a9970ea6d49cf1
builds fine.
It only hurts bisectibility.
All errors (new ones prefixed by >>):
drivers/media/dvb-core/dvb_vb2.o: In function `dvb_vb2_init':
>> drivers/media/dvb-core/dvb_vb2.c:170: undefined reference to
>> `vb2_vmalloc_memops'
vim +170 drivers/media/dvb-core/dvb_vb2.c
151
152 /*
153 * Videobuf operations
154 */
155 int dvb_vb2_init(struct dvb_vb2_ctx *ctx, const char *name, int
nonblocking)
156 {
157 struct vb2_queue *q = &ctx->vb_q;
158 int ret;
159
160 memset(ctx, 0, sizeof(struct dvb_vb2_ctx));
161 q->type = DVB_BUF_TYPE_CAPTURE;
162 /**capture type*/
163 q->is_output = 0;
164 /**only mmap is supported currently*/
165 q->io_modes = VB2_MMAP;
166 q->drv_priv = ctx;
167 q->buf_struct_size = sizeof(struct dvb_buffer);
168 q->min_buffers_needed = 1;
169 q->ops = &dvb_vb2_qops;
> 170 q->mem_ops = &vb2_vmalloc_memops;
171 q->buf_ops = &dvb_vb2_buf_ops;
172 q->num_buffers = 0;
173 ret = vb2_core_queue_init(q);
174 if (ret) {
175 ctx->state = DVB_VB2_STATE_NONE;
176 dprintk(1, "[%s] errno=%d\n", ctx->name, ret);
177 return ret;
178 }
179
180 mutex_init(&ctx->mutex);
181 spin_lock_init(&ctx->slock);
182 INIT_LIST_HEAD(&ctx->dvb_q);
183
184 strncpy(ctx->name, name, DVB_VB2_NAME_MAX);
185 ctx->nonblocking = nonblocking;
186 ctx->state = DVB_VB2_STATE_INIT;
187
188 dprintk(3, "[%s]\n", ctx->name);
189
190 return 0;
191 }
192
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
[linuxtv-media:master 3281/3294] drivers/media/dvb-core/dvb_vb2.c:173: undefined reference to `vb2_core_queue_init'
tree: git://linuxtv.org/media_tree.git master
head: 201b56737f4ea59ee840ebdb88a9970ea6d49cf1
commit: 57868acc369ab73ec8f6b43a0c6749077376b189 [3281/3294] media: videobuf2:
Add new uAPI for DVB streaming I/O
config: i386-randconfig-s1-201752 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
git checkout 57868acc369ab73ec8f6b43a0c6749077376b189
# save the attached .config to linux build tree
make ARCH=i386
Note: the linuxtv-media/master HEAD 201b56737f4ea59ee840ebdb88a9970ea6d49cf1
builds fine.
It only hurts bisectibility.
All errors (new ones prefixed by >>):
drivers/media/dvb-core/dvb_vb2.o: In function `dvb_vb2_init':
drivers/media/dvb-core/dvb_vb2.c:170: undefined reference to
`vb2_vmalloc_memops'
>> drivers/media/dvb-core/dvb_vb2.c:173: undefined reference to
>> `vb2_core_queue_init'
drivers/media/dvb-core/dvb_vb2.o: In function `dvb_vb2_release':
>> drivers/media/dvb-core/dvb_vb2.c:198: undefined reference to
>> `vb2_core_queue_release'
drivers/media/dvb-core/dvb_vb2.o: In function `dvb_vb2_stream_on':
>> drivers/media/dvb-core/dvb_vb2.c:211: undefined reference to
>> `vb2_core_streamon'
drivers/media/dvb-core/dvb_vb2.o: In function `dvb_vb2_stream_off':
>> drivers/media/dvb-core/dvb_vb2.c:238: undefined reference to
>> `vb2_buffer_done'
>> drivers/media/dvb-core/dvb_vb2.c:242: undefined reference to
>> `vb2_core_streamoff'
drivers/media/dvb-core/dvb_vb2.o: In function `dvb_vb2_fill_buffer':
drivers/media/dvb-core/dvb_vb2.c:294: undefined reference to
`vb2_buffer_done'
>> drivers/media/dvb-core/dvb_vb2.c:301: undefined reference to
>> `vb2_plane_vaddr'
drivers/media/dvb-core/dvb_vb2.c:310: undefined reference to
`vb2_buffer_done'
drivers/media/dvb-core/dvb_vb2.c:317: undefined reference to
`vb2_buffer_done'
drivers/media/dvb-core/dvb_vb2.o: In function `dvb_vb2_reqbufs':
>> drivers/media/dvb-core/dvb_vb2.c:336: undefined reference to
>> `vb2_core_reqbufs'
drivers/media/dvb-core/dvb_vb2.o: In function `dvb_vb2_querybuf':
>> drivers/media/dvb-core/dvb_vb2.c:352: undefined reference to
>> `vb2_core_querybuf'
drivers/media/dvb-core/dvb_vb2.o: In function `dvb_vb2_expbuf':
>> drivers/media/dvb-core/dvb_vb2.c:362: undefined reference to
>> `vb2_core_expbuf'
drivers/media/dvb-core/dvb_vb2.o: In function `dvb_vb2_qbuf':
>> drivers/media/dvb-core/dvb_vb2.c:378: undefined reference to `vb2_core_qbuf'
drivers/media/dvb-core/dvb_vb2.o: In function `dvb_vb2_dqbuf':
>> drivers/media/dvb-core/dvb_vb2.c:393: undefined reference to `vb2_core_dqbuf'
drivers/media/dvb-core/dvb_vb2.o: In function `dvb_vb2_mmap':
>> drivers/media/dvb-core/dvb_vb2.c:407: undefined reference to `vb2_mmap'
drivers/media/dvb-core/dvb_vb2.o: In function `dvb_vb2_poll':
>> drivers/media/dvb-core/dvb_vb2.c:421: undefined reference to `vb2_core_poll'
vim +173 drivers/media/dvb-core/dvb_vb2.c
151
152 /*
153 * Videobuf operations
154 */
155 int dvb_vb2_init(struct dvb_vb2_ctx *ctx, const char *name, int
nonblocking)
156 {
157 struct vb2_queue *q = &ctx->vb_q;
158 int ret;
159
160 memset(ctx, 0, sizeof(struct dvb_vb2_ctx));
161 q->type = DVB_BUF_TYPE_CAPTURE;
162 /**capture type*/
163 q->is_output = 0;
164 /**only mmap is supported currently*/
165 q->io_modes = VB2_MMAP;
166 q->drv_priv = ctx;
167 q->buf_struct_size = sizeof(struct dvb_buffer);
168 q->min_buffers_needed = 1;
169 q->ops = &dvb_vb2_qops;
> 170 q->mem_ops = &vb2_vmalloc_memops;
171 q->buf_ops = &dvb_vb2_buf_ops;
172 q->num_buffers = 0;
> 173 ret = vb2_core_queue_init(q);
174 if (ret) {
175 ctx->state = DVB_VB2_STATE_NONE;
176 dprintk(1, "[%s] errno=%d\n", ctx->name, ret);
177 return ret;
178 }
179
180 mutex_init(&ctx->mutex);
181 spin_lock_init(&ctx->slock);
182 INIT_LIST_HEAD(&ctx->dvb_q);
183
184 strncpy(ctx->name, name, DVB_VB2_NAME_MAX);
185 ctx->nonblocking = nonblocking;
186 ctx->state = DVB_VB2_STATE_INIT;
187
188 dprintk(3, "[%s]\n", ctx->name);
189
190 return 0;
191 }
192
193 int dvb_vb2_release(struct dvb_vb2_ctx *ctx)
194 {
195 struct vb2_queue *q = (struct vb2_queue *)&ctx->vb_q;
196
197 if (ctx->state & DVB_VB2_STATE_INIT)
> 198 vb2_core_queue_release(q);
199
200 ctx->state = DVB_VB2_STATE_NONE;
201 dprintk(3, "[%s]\n", ctx->name);
202
203 return 0;
204 }
205
206 int dvb_vb2_stream_on(struct dvb_vb2_ctx *ctx)
207 {
208 struct vb2_queue *q = &ctx->vb_q;
209 int ret;
210
> 211
[linuxtv-media:master 3292/3294] htmldocs: include/media/dmxdev.h:152: warning: Function parameter or member 'vb2_ctx' not described in 'dmxdev_filter'
tree: git://linuxtv.org/media_tree.git master head: 201b56737f4ea59ee840ebdb88a9970ea6d49cf1 commit: fada1935590f66dc6784981e0d557ca09013c847 [3292/3294] media: move dvb kAPI headers to include/media reproduce: make htmldocs All warnings (new ones prefixed by >>): include/crypto/hash.h:89: warning: duplicate section name 'Note' include/crypto/hash.h:95: warning: duplicate section name 'Note' include/crypto/hash.h:102: warning: duplicate section name 'Note' include/crypto/hash.h:89: warning: duplicate section name 'Note' include/crypto/hash.h:95: warning: duplicate section name 'Note' include/crypto/hash.h:102: warning: duplicate section name 'Note' include/crypto/hash.h:89: warning: duplicate section name 'Note' include/crypto/hash.h:95: warning: duplicate section name 'Note' include/crypto/hash.h:102: warning: duplicate section name 'Note' include/crypto/hash.h:89: warning: duplicate section name 'Note' include/crypto/hash.h:95: warning: duplicate section name 'Note' include/crypto/hash.h:102: warning: duplicate section name 'Note' include/crypto/hash.h:89: warning: duplicate section name 'Note' include/crypto/hash.h:95: warning: duplicate section name 'Note' include/crypto/hash.h:102: warning: duplicate section name 'Note' include/crypto/hash.h:89: warning: duplicate section name 'Note' include/crypto/hash.h:95: warning: duplicate section name 'Note' include/crypto/hash.h:102: warning: duplicate section name 'Note' include/crypto/hash.h:89: warning: duplicate section name 'Note' include/crypto/hash.h:95: warning: duplicate section name 'Note' include/crypto/hash.h:102: warning: duplicate section name 'Note' include/crypto/hash.h:89: warning: duplicate section name 'Note' include/crypto/hash.h:95: warning: duplicate section name 'Note' include/crypto/hash.h:102: warning: duplicate section name 'Note' include/linux/crypto.h:469: warning: Function parameter or member 'cra_u.ablkcipher' not described in 'crypto_alg' include/linux/crypto.h:469: warning: Function parameter or member 'cra_u.blkcipher' not described in 'crypto_alg' include/linux/crypto.h:469: warning: Function parameter or member 'cra_u.cipher' not described in 'crypto_alg' include/linux/crypto.h:469: warning: Function parameter or member 'cra_u.compress' not described in 'crypto_alg' include/net/cfg80211.h:3278: warning: Excess enum value 'WIPHY_FLAG_SUPPORTS_SCHED_SCAN' description in 'wiphy_flags' include/net/cfg80211.h:4115: warning: Function parameter or member 'wext.ibss' not described in 'wireless_dev' include/net/cfg80211.h:4115: warning: Function parameter or member 'wext.connect' not described in 'wireless_dev' include/net/cfg80211.h:4115: warning: Function parameter or member 'wext.keys' not described in 'wireless_dev' include/net/cfg80211.h:4115: warning: Function parameter or member 'wext.ie' not described in 'wireless_dev' include/net/cfg80211.h:4115: warning: Function parameter or member 'wext.ie_len' not described in 'wireless_dev' include/net/cfg80211.h:4115: warning: Function parameter or member 'wext.bssid' not described in 'wireless_dev' include/net/cfg80211.h:4115: warning: Function parameter or member 'wext.prev_bssid' not described in 'wireless_dev' include/net/cfg80211.h:4115: warning: Function parameter or member 'wext.ssid' not described in 'wireless_dev' include/net/cfg80211.h:4115: warning: Function parameter or member 'wext.default_key' not described in 'wireless_dev' include/net/cfg80211.h:4115: warning: Function parameter or member 'wext.default_mgmt_key' not described in 'wireless_dev' include/net/cfg80211.h:4115: warning: Function parameter or member 'wext.prev_bssid_valid' not described in 'wireless_dev' include/net/mac80211.h:2251: warning: Function parameter or member 'radiotap_timestamp.units_pos' not described in 'ieee80211_hw' include/net/mac80211.h:2251: warning: Function parameter or member 'radiotap_timestamp.accuracy' not described in 'ieee80211_hw' include/net/mac80211.h:950: warning: Function parameter or member 'rates' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'control.rts_cts_rate_idx' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'control.use_rts' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'control.use_cts_prot' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'control.short_preamble' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'control.skip_table' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'control.jiffies' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: war
[linuxtv-media:master 3320/3326] drivers/staging/media/imx/imx-media-dev.c:55:49: error: request for member 'name' in something not a structure or union
tree: git://linuxtv.org/media_tree.git master
head: e3401c2d3804ec67f90ac20ce684171a02c8bf3e
commit: 4e48afecd5ee3a394d228349fc1c33982e9fb557 [3320/3326] media: v4l2-async:
simplify v4l2_async_subdev structure
config: arm-allyesconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 4e48afecd5ee3a394d228349fc1c33982e9fb557
# save the attached .config to linux build tree
make.cross ARCH=arm
All errors (new ones prefixed by >>):
drivers/staging/media/imx/imx-media-dev.c: In function 'find_async_subdev':
>> drivers/staging/media/imx/imx-media-dev.c:55:49: error: request for member
>> 'name' in something not a structure or union
if (devname && !strcmp(asd->match.device_name.name,
^
drivers/staging/media/imx/imx-media-dev.c: In function
'imx_media_add_async_subdev':
drivers/staging/media/imx/imx-media-dev.c:110:25: error: request for member
'name' in something not a structure or union
asd->match.device_name.name = devname;
^
vim +/name +55 drivers/staging/media/imx/imx-media-dev.c
e13029121 Steve Longerbeam 2017-06-10 34
e13029121 Steve Longerbeam 2017-06-10 35 /*
9f6a0c59e Steve Longerbeam 2017-12-14 36 * Find an asd by fwnode or
device name. This is called during
e13029121 Steve Longerbeam 2017-06-10 37 * driver load to form the
async subdev list and bind them.
e13029121 Steve Longerbeam 2017-06-10 38 */
9f6a0c59e Steve Longerbeam 2017-12-14 39 static struct v4l2_async_subdev
*
9f6a0c59e Steve Longerbeam 2017-12-14 40 find_async_subdev(struct
imx_media_dev *imxmd,
4eef678d3 Steve Longerbeam 2017-12-14 41struct
fwnode_handle *fwnode,
e13029121 Steve Longerbeam 2017-06-10 42const char
*devname)
e13029121 Steve Longerbeam 2017-06-10 43 {
9f6a0c59e Steve Longerbeam 2017-12-14 44 struct
imx_media_async_subdev *imxasd;
9f6a0c59e Steve Longerbeam 2017-12-14 45 struct
v4l2_async_subdev *asd;
e13029121 Steve Longerbeam 2017-06-10 46
9f6a0c59e Steve Longerbeam 2017-12-14 47
list_for_each_entry(imxasd, &imxmd->asd_list, list) {
9f6a0c59e Steve Longerbeam 2017-12-14 48 asd =
&imxasd->asd;
9f6a0c59e Steve Longerbeam 2017-12-14 49 switch
(asd->match_type) {
e13029121 Steve Longerbeam 2017-06-10 50 case
V4L2_ASYNC_MATCH_FWNODE:
4e48afecd Mauro Carvalho Chehab 2017-09-27 51 if
(fwnode && asd->match.fwnode == fwnode)
9f6a0c59e Steve Longerbeam 2017-12-14 52
return asd;
e13029121 Steve Longerbeam 2017-06-10 53 break;
e13029121 Steve Longerbeam 2017-06-10 54 case
V4L2_ASYNC_MATCH_DEVNAME:
9f6a0c59e Steve Longerbeam 2017-12-14 @55 if
(devname && !strcmp(asd->match.device_name.name,
9f6a0c59e Steve Longerbeam 2017-12-14 56
devname))
9f6a0c59e Steve Longerbeam 2017-12-14 57
return asd;
e13029121 Steve Longerbeam 2017-06-10 58 break;
e13029121 Steve Longerbeam 2017-06-10 59 default:
e13029121 Steve Longerbeam 2017-06-10 60 break;
e13029121 Steve Longerbeam 2017-06-10 61 }
e13029121 Steve Longerbeam 2017-06-10 62 }
e13029121 Steve Longerbeam 2017-06-10 63
e13029121 Steve Longerbeam 2017-06-10 64 return NULL;
e13029121 Steve Longerbeam 2017-06-10 65 }
e13029121 Steve Longerbeam 2017-06-10 66
:: The code at line 55 was first introduced by commit
:: 9f6a0c59eba91c116f6cd7a487f4929faa07a7f8 media: staging/imx: remove
static subdev arrays
:: TO: Steve Longerbeam
:: CC: Mauro Carvalho Chehab
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
[linuxtv-media:master 3288/3327] drivers/media/common/videobuf/videobuf2-v4l2.c:678: undefined reference to `video_devdata'
tree: git://linuxtv.org/media_tree.git master
head: d0c8f6ad8b381dd572576ac50b9696d4d31142bb
commit: 03fbdb2fc2b8bb27b0ee0534fd3e9c57cdc3854a [3288/3327] media: move
videobuf2 to drivers/media/common
config: x86_64-randconfig-s4-12300216 (attached as .config)
compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025
reproduce:
git checkout 03fbdb2fc2b8bb27b0ee0534fd3e9c57cdc3854a
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
drivers/media/common/videobuf/videobuf2-v4l2.o: In function `vb2_poll':
>> drivers/media/common/videobuf/videobuf2-v4l2.c:678: undefined reference to
>> `video_devdata'
>> drivers/media/common/videobuf/videobuf2-v4l2.c:685: undefined reference to
>> `v4l2_event_pending'
drivers/media/common/videobuf/videobuf2-v4l2.o: In function
`vb2_ioctl_reqbufs':
drivers/media/common/videobuf/videobuf2-v4l2.c:714: undefined reference to
`video_devdata'
drivers/media/common/videobuf/videobuf2-v4l2.o: In function
`vb2_ioctl_create_bufs':
drivers/media/common/videobuf/videobuf2-v4l2.c:733: undefined reference to
`video_devdata'
drivers/media/common/videobuf/videobuf2-v4l2.o: In function
`vb2_ioctl_prepare_buf':
drivers/media/common/videobuf/videobuf2-v4l2.c:759: undefined reference to
`video_devdata'
drivers/media/common/videobuf/videobuf2-v4l2.o: In function
`vb2_ioctl_querybuf':
drivers/media/common/videobuf/videobuf2-v4l2.c:769: undefined reference to
`video_devdata'
drivers/media/common/videobuf/videobuf2-v4l2.o: In function `vb2_ioctl_qbuf':
drivers/media/common/videobuf/videobuf2-v4l2.c:778: undefined reference to
`video_devdata'
drivers/media/common/videobuf/videobuf2-v4l2.o:drivers/media/common/videobuf/videobuf2-v4l2.c:788:
more undefined references to `video_devdata' follow
drivers/media/common/videobuf/videobuf2-v4l2.o: In function
`_vb2_fop_release':
>> drivers/media/common/videobuf/videobuf2-v4l2.c:848: undefined reference to
>> `v4l2_fh_release'
drivers/media/common/videobuf/videobuf2-v4l2.o: In function
`vb2_fop_release':
drivers/media/common/videobuf/videobuf2-v4l2.c:854: undefined reference to
`video_devdata'
drivers/media/common/videobuf/videobuf2-v4l2.o: In function `vb2_fop_write':
drivers/media/common/videobuf/videobuf2-v4l2.c:864: undefined reference to
`video_devdata'
drivers/media/common/videobuf/videobuf2-v4l2.o: In function `vb2_fop_read':
drivers/media/common/videobuf/videobuf2-v4l2.c:888: undefined reference to
`video_devdata'
drivers/media/common/videobuf/videobuf2-v4l2.o: In function `vb2_fop_poll':
drivers/media/common/videobuf/videobuf2-v4l2.c:911: undefined reference to
`video_devdata'
vim +678 drivers/media/common/videobuf/videobuf2-v4l2.c
3c5be988 drivers/media/v4l2-core/videobuf2-v4l2.c Junghak Sung 2015-10-06 675
49d8ab9f drivers/media/v4l2-core/videobuf2-v4l2.c Junghak Sung 2015-11-03 676
unsigned int vb2_poll(struct vb2_queue *q, struct file *file, poll_table *wait)
49d8ab9f drivers/media/v4l2-core/videobuf2-v4l2.c Junghak Sung 2015-11-03 677
{
49d8ab9f drivers/media/v4l2-core/videobuf2-v4l2.c Junghak Sung 2015-11-03 @678
struct video_device *vfd = video_devdata(file);
49d8ab9f drivers/media/v4l2-core/videobuf2-v4l2.c Junghak Sung 2015-11-03 679
unsigned long req_events = poll_requested_events(wait);
49d8ab9f drivers/media/v4l2-core/videobuf2-v4l2.c Junghak Sung 2015-11-03 680
unsigned int res = 0;
49d8ab9f drivers/media/v4l2-core/videobuf2-v4l2.c Junghak Sung 2015-11-03 681
49d8ab9f drivers/media/v4l2-core/videobuf2-v4l2.c Junghak Sung 2015-11-03 682
if (test_bit(V4L2_FL_USES_V4L2_FH, &vfd->flags)) {
49d8ab9f drivers/media/v4l2-core/videobuf2-v4l2.c Junghak Sung 2015-11-03 683
struct v4l2_fh *fh = file->private_data;
49d8ab9f drivers/media/v4l2-core/videobuf2-v4l2.c Junghak Sung 2015-11-03 684
49d8ab9f drivers/media/v4l2-core/videobuf2-v4l2.c Junghak Sung 2015-11-03 @685
if (v4l2_event_pending(fh))
49d8ab9f drivers/media/v4l2-core/videobuf2-v4l2.c Junghak Sung 2015-11-03 686
res = POLLPRI;
49d8ab9f drivers/media/v4l2-core/videobuf2-v4l2.c Junghak Sung 2015-11-03 687
else if (req_events & POLLPRI)
49d8ab9f drivers/media/v4l2-core/videobuf2-v4l2.c Junghak Sung 2015-11-03 688
poll_wait(file, &fh->wait, wait);
3c5be988 drivers/media/v4l2-core/videobuf2-v4l2.c Junghak Sung 2015-10-06 689
}
49d8ab9f drivers/media/v4l2-core/videobuf2-v4l2.c Junghak Sung 2015-11-03 690
49d8ab9f drivers/media/v4l2-core/videobuf2-v4l2.c Junghak Sung 2015-11-03 691
return res | vb2_core_poll(q, file, wait);
3c5be988 drivers/media/v4l2-core/videobuf2-v4l2.c Junghak Sung 2015-10-06 692
}
3c5be988 drivers/media/v4l2-core/videobuf2-v4l2.c Junghak Sung 2015-10-06 693
EXPORT_SYMBOL_GPL(vb2_poll);
3c5be988 drivers/media/v4l2-core/videobuf2-
Re: [PATCH v2 5/9] arch: sh: migor: Use new renesas-ceu camera driver
Hi Jacopo,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.15-rc5 next-20171222]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Jacopo-Mondi/Renesas-Capture-Engine-Unit-CEU-V4L2-driver/20171230-212202
base: git://linuxtv.org/media_tree.git master
config: sh-migor_defconfig (attached as .config)
compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=sh
Note: the
linux-review/Jacopo-Mondi/Renesas-Capture-Engine-Unit-CEU-V4L2-driver/20171230-212202
HEAD 71df4d9132d9f8a1821abcec32c12adba1892c50 builds fine.
It only hurts bisectibility.
All errors (new ones prefixed by >>):
>> arch/sh/boards/mach-migor/setup.c:403:3: error: 'struct ov772x_camera_info'
>> has no member named 'xclk_rate'
.xclk_rate = 1000,
^
vim +403 arch/sh/boards/mach-migor/setup.c
401
402 static struct ov772x_camera_info ov7725_info = {
> 403 .xclk_rate = 1000,
404 };
405
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
[ragnatech:media-tree 3128/3327] drivers/media/dvb-frontends/stb0899_drv.h:151:36: error: weak declaration of 'stb0899_attach' being applied to a already existing, static definition
tree: git://git.ragnatech.se/linux media-tree
head: d0c8f6ad8b381dd572576ac50b9696d4d31142bb
commit: 6cdeaed3b1420bd2569891be0c4123ff59628e9e [3128/3327] media:
dvb_usb_pctv452e: module refcount changes were unbalanced
config: x86_64-randconfig-s3-12311435 (attached as .config)
compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025
reproduce:
git checkout 6cdeaed3b1420bd2569891be0c4123ff59628e9e
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
In file included from drivers/media/usb/dvb-usb/pctv452e.c:20:0:
drivers/media/usb/dvb-usb/pctv452e.c: In function 'pctv452e_frontend_attach':
>> drivers/media/dvb-frontends/stb0899_drv.h:151:36: error: weak declaration of
>> 'stb0899_attach' being applied to a already existing, static definition
static inline struct dvb_frontend *stb0899_attach(struct stb0899_config
*config,
^~
vim +/stb0899_attach +151 drivers/media/dvb-frontends/stb0899_drv.h
ae9902da9 drivers/media/dvb/frontends/stb0899_drv.h Manu Abraham 2007-10-08
150
ae9902da9 drivers/media/dvb/frontends/stb0899_drv.h Manu Abraham 2007-10-08
@151 static inline struct dvb_frontend *stb0899_attach(struct stb0899_config
*config,
ae9902da9 drivers/media/dvb/frontends/stb0899_drv.h Manu Abraham 2007-10-08
152 struct i2c_adapter *i2c)
ae9902da9 drivers/media/dvb/frontends/stb0899_drv.h Manu Abraham 2007-10-08
153 {
ae9902da9 drivers/media/dvb/frontends/stb0899_drv.h Manu Abraham 2007-10-08
154printk(KERN_WARNING "%s: Driver disabled by Kconfig\n", __func__);
ae9902da9 drivers/media/dvb/frontends/stb0899_drv.h Manu Abraham 2007-10-08
155return NULL;
ae9902da9 drivers/media/dvb/frontends/stb0899_drv.h Manu Abraham 2007-10-08
156 }
ae9902da9 drivers/media/dvb/frontends/stb0899_drv.h Manu Abraham 2007-10-08
157
:: The code at line 151 was first introduced by commit
:: ae9902da96b4d2d82707706c7fbc93a8e501dde8 V4L/DVB (9417): DVB_ATTACH for
STB0899, STB6100, TDA8261
:: TO: Manu Abraham
:: CC: Mauro Carvalho Chehab
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH 01/33] clk_ops: change round_rate() to return unsigned long
Hi Bryan,
I love your patch! Perhaps something to improve:
[auto build test WARNING on tegra/for-next]
[also build test WARNING on v4.15-rc6]
[cannot apply to clk/clk-next next-20171222]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Bryan-O-Donoghue/change-clk_ops-round_rate-to-scale-past-LONG_MAX/20180101-212907
base: https://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git for-next
config: i386-randconfig-b0-01011934 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All warnings (new ones prefixed by >>):
>> drivers/clk/clk-versaclock5.c:321:2: warning: initialization from
>> incompatible pointer type
.round_rate = vc5_dbl_round_rate,
^
drivers/clk/clk-versaclock5.c:321:2: warning: (near initialization for
'vc5_dbl_ops.round_rate')
vim +321 drivers/clk/clk-versaclock5.c
8c1ebe97 Marek Vasut 2017-07-09 318
8c1ebe97 Marek Vasut 2017-07-09 319 static const struct clk_ops vc5_dbl_ops =
{
8c1ebe97 Marek Vasut 2017-07-09 320.recalc_rate= vc5_dbl_recalc_rate,
8c1ebe97 Marek Vasut 2017-07-09 @321.round_rate = vc5_dbl_round_rate,
8c1ebe97 Marek Vasut 2017-07-09 322.set_rate = vc5_dbl_set_rate,
8c1ebe97 Marek Vasut 2017-07-09 323 };
8c1ebe97 Marek Vasut 2017-07-09 324
:: The code at line 321 was first introduced by commit
:: 8c1ebe9762670159ca982167131af63c94ff1571 clk: vc5: Add support for the
input frequency doubler
:: TO: Marek Vasut
:: CC: Stephen Boyd
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH 01/33] clk_ops: change round_rate() to return unsigned long
Hi Bryan,
I love your patch! Yet something to improve:
[auto build test ERROR on tegra/for-next]
[also build test ERROR on v4.15-rc6]
[cannot apply to clk/clk-next next-20171222]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Bryan-O-Donoghue/change-clk_ops-round_rate-to-scale-past-LONG_MAX/20180101-212907
base: https://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git for-next
config: x86_64-randconfig-x016-201800 (attached as .config)
compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
>> drivers//clk/clk-versaclock5.c:321:16: error: initialization from
>> incompatible pointer type [-Werror=incompatible-pointer-types]
.round_rate = vc5_dbl_round_rate,
^~
drivers//clk/clk-versaclock5.c:321:16: note: (near initialization for
'vc5_dbl_ops.round_rate')
cc1: some warnings being treated as errors
vim +321 drivers//clk/clk-versaclock5.c
8c1ebe97 Marek Vasut 2017-07-09 318
8c1ebe97 Marek Vasut 2017-07-09 319 static const struct clk_ops vc5_dbl_ops =
{
8c1ebe97 Marek Vasut 2017-07-09 320.recalc_rate= vc5_dbl_recalc_rate,
8c1ebe97 Marek Vasut 2017-07-09 @321.round_rate = vc5_dbl_round_rate,
8c1ebe97 Marek Vasut 2017-07-09 322.set_rate = vc5_dbl_set_rate,
8c1ebe97 Marek Vasut 2017-07-09 323 };
8c1ebe97 Marek Vasut 2017-07-09 324
:: The code at line 321 was first introduced by commit
:: 8c1ebe9762670159ca982167131af63c94ff1571 clk: vc5: Add support for the
input frequency doubler
:: TO: Marek Vasut
:: CC: Stephen Boyd
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH 01/33] clk_ops: change round_rate() to return unsigned long
Hi Bryan,
I love your patch! Perhaps something to improve:
[auto build test WARNING on tegra/for-next]
[also build test WARNING on v4.15-rc6]
[cannot apply to clk/clk-next next-20171222]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Bryan-O-Donoghue/change-clk_ops-round_rate-to-scale-past-LONG_MAX/20180101-212907
base: https://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git for-next
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
vim +321 drivers/clk/clk-versaclock5.c
8c1ebe97 Marek Vasut 2017-07-09 318
8c1ebe97 Marek Vasut 2017-07-09 319 static const struct clk_ops vc5_dbl_ops =
{
8c1ebe97 Marek Vasut 2017-07-09 320.recalc_rate= vc5_dbl_recalc_rate,
8c1ebe97 Marek Vasut 2017-07-09 @321.round_rate = vc5_dbl_round_rate,
8c1ebe97 Marek Vasut 2017-07-09 322.set_rate = vc5_dbl_set_rate,
8c1ebe97 Marek Vasut 2017-07-09 323 };
8c1ebe97 Marek Vasut 2017-07-09 324
:: The code at line 321 was first introduced by commit
:: 8c1ebe9762670159ca982167131af63c94ff1571 clk: vc5: Add support for the
input frequency doubler
:: TO: Marek Vasut
:: CC: Stephen Boyd
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[linux-next:master 6051/9035] drivers/media/common/videobuf/videobuf2-core.o:(__jump_table+0x10): undefined reference to `__tracepoint_vb2_buf_queue'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: b4464bcab38d3f7fe995a7cb960eeac6889bec08 commit: 03fbdb2fc2b8bb27b0ee0534fd3e9c57cdc3854a [6051/9035] media: move videobuf2 to drivers/media/common config: x86_64-randconfig-s5-01110339 compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025 reproduce: git checkout 03fbdb2fc2b8bb27b0ee0534fd3e9c57cdc3854a make ARCH=x86_64 randconfig make ARCH=x86_64 All errors (new ones prefixed by >>): --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
[linux-next:master 3773/9944] drivers/media/dvb-frontends/stb0899_drv.h:151:36: error: weak declaration of 'stb0899_attach' being applied to a already existing, static definition
Hi Wolfgang,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: fdddade65d7b5f8779374eb73d09889185280f60
commit: 6cdeaed3b1420bd2569891be0c4123ff59628e9e [3773/9944] media:
dvb_usb_pctv452e: module refcount changes were unbalanced
config: x86_64-randconfig-s4-01170712 (attached as .config)
compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025
reproduce:
git checkout 6cdeaed3b1420bd2569891be0c4123ff59628e9e
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
In file included from drivers/media/usb/dvb-usb/pctv452e.c:20:0:
drivers/media/usb/dvb-usb/pctv452e.c: In function 'pctv452e_frontend_attach':
>> drivers/media/dvb-frontends/stb0899_drv.h:151:36: error: weak declaration of
>> 'stb0899_attach' being applied to a already existing, static definition
static inline struct dvb_frontend *stb0899_attach(struct stb0899_config
*config,
^~
vim +/stb0899_attach +151 drivers/media/dvb-frontends/stb0899_drv.h
ae9902da9 drivers/media/dvb/frontends/stb0899_drv.h Manu Abraham 2007-10-08
150
ae9902da9 drivers/media/dvb/frontends/stb0899_drv.h Manu Abraham 2007-10-08
@151 static inline struct dvb_frontend *stb0899_attach(struct stb0899_config
*config,
ae9902da9 drivers/media/dvb/frontends/stb0899_drv.h Manu Abraham 2007-10-08
152 struct i2c_adapter *i2c)
ae9902da9 drivers/media/dvb/frontends/stb0899_drv.h Manu Abraham 2007-10-08
153 {
ae9902da9 drivers/media/dvb/frontends/stb0899_drv.h Manu Abraham 2007-10-08
154printk(KERN_WARNING "%s: Driver disabled by Kconfig\n", __func__);
ae9902da9 drivers/media/dvb/frontends/stb0899_drv.h Manu Abraham 2007-10-08
155return NULL;
ae9902da9 drivers/media/dvb/frontends/stb0899_drv.h Manu Abraham 2007-10-08
156 }
ae9902da9 drivers/media/dvb/frontends/stb0899_drv.h Manu Abraham 2007-10-08
157
:: The code at line 151 was first introduced by commit
:: ae9902da96b4d2d82707706c7fbc93a8e501dde8 V4L/DVB (9417): DVB_ATTACH for
STB0899, STB6100, TDA8261
:: TO: Manu Abraham
:: CC: Mauro Carvalho Chehab
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
[linux-next:master 6054/10286] drivers/media/common/videobuf/videobuf2-v4l2.c:678: undefined reference to `video_devdata'
Hi Mauro, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 1fec57a31e561b110756a8b0bd2135a29bd6268f commit: 03fbdb2fc2b8bb27b0ee0534fd3e9c57cdc3854a [6054/10286] media: move videobuf2 to drivers/media/common config: x86_64-randconfig-h0-01180022 (attached as .config) compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025 reproduce: git checkout 03fbdb2fc2b8bb27b0ee0534fd3e9c57cdc3854a # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): drivers/media/common/videobuf/videobuf2-core.o: In function `__read_once_size': include/linux/compiler.h:183: undefined reference to `__tracepoint_vb2_buf_queue' include/linux/compiler.h:183: undefined reference to `__tracepoint_vb2_buf_queue' include/linux/compiler.h:183: undefined reference to `__tracepoint_vb2_buf_queue' include/linux/compiler.h:183: undefined reference to `__tracepoint_vb2_buf_queue' include/linux/compiler.h:183: undefined reference to `__tracepoint_vb2_buf_done' include/linux/compiler.h:183: undefined reference to `__tracepoint_vb2_buf_done' include/linux/compiler.h:183: undefined reference to `__tracepoint_vb2_buf_done' include/linux/compiler.h:183: undefined reference to `__tracepoint_vb2_buf_done' include/linux/compiler.h:183: undefined reference to `__tracepoint_vb2_qbuf' include/linux/compiler.h:183: undefined reference to `__tracepoint_vb2_qbuf' include/linux/compiler.h:183: undefined reference to `__tracepoint_vb2_qbuf' include/linux/compiler.h:183: undefined reference to `__tracepoint_vb2_qbuf' include/linux/compiler.h:183: undefined reference to `__tracepoint_vb2_dqbuf' include/linux/compiler.h:183: undefined reference to `__tracepoint_vb2_dqbuf' include/linux/compiler.h:183: undefined reference to `__tracepoint_vb2_dqbuf' include/linux/compiler.h:183: undefined reference to `__tracepoint_vb2_dqbuf' drivers/media/common/videobuf/videobuf2-core.o: In function `vb2_core_streamon': drivers/media/common/videobuf/videobuf2-core.c:1726: undefined reference to `v4l_vb2q_enable_media_source' drivers/media/common/videobuf/videobuf2-core.o:(__jump_table+0x10): undefined reference to `__tracepoint_vb2_buf_queue' drivers/media/common/videobuf/videobuf2-core.o:(__jump_table+0x28): undefined reference to `__tracepoint_vb2_buf_done' drivers/media/common/videobuf/videobuf2-core.o:(__jump_table+0x40): undefined reference to `__tracepoint_vb2_qbuf' drivers/media/common/videobuf/videobuf2-core.o:(__jump_table+0x58): undefined reference to `__tracepoint_vb2_dqbuf' drivers/media/common/videobuf/videobuf2-v4l2.o: In function `vb2_poll': >> drivers/media/common/videobuf/videobuf2-v4l2.c:678: undefined reference to >> `video_devdata' >> drivers/media/common/videobuf/videobuf2-v4l2.c:685: undefined reference to >> `v4l2_event_pending' drivers/media/common/videobuf/videobuf2-v4l2.o: In function `vb2_ioctl_reqbufs': drivers/media/common/videobuf/videobuf2-v4l2.c:714: undefined reference to `video_devdata' drivers/media/common/videobuf/videobuf2-v4l2.o: In function `vb2_ioctl_create_bufs': drivers/media/common/videobuf/videobuf2-v4l2.c:733: undefined reference to `video_devdata' drivers/media/common/videobuf/videobuf2-v4l2.o: In function `vb2_ioctl_prepare_buf': drivers/media/common/videobuf/videobuf2-v4l2.c:759: undefined reference to `video_devdata' drivers/media/common/videobuf/videobuf2-v4l2.o: In function `vb2_ioctl_querybuf': drivers/media/common/videobuf/videobuf2-v4l2.c:769: undefined reference to `video_devdata' drivers/media/common/videobuf/videobuf2-v4l2.o: In function `vb2_ioctl_qbuf': drivers/media/common/videobuf/videobuf2-v4l2.c:778: undefined reference to `video_devdata' drivers/media/common/videobuf/videobuf2-v4l2.o:drivers/media/common/videobuf/videobuf2-v4l2.c:788: more undefined references to `video_devdata' follow drivers/media/common/videobuf/videobuf2-v4l2.o: In function `_vb2_fop_release': >> drivers/media/common/videobuf/videobuf2-v4l2.c:848: undefined reference to >> `v4l2_fh_release' drivers/media/common/videobuf/videobuf2-v4l2.o: In function `vb2_fop_release': drivers/media/common/videobuf/videobuf2-v4l2.c:854: undefined reference to `video_devdata' drivers/media/common/videobuf/videobuf2-v4l2.o: In function `vb2_fop_write': drivers/media/common/videobuf/videobuf2-v4l2.c:864: undefined reference to `video_devdata' drivers/media/common/videobuf/videobuf2-v4l2.o: In function `vb2_fop_read': drivers/media/common/videobuf/videobuf2-v4l2.c:888: undefined reference to `video_devdata' drivers/media/common/videobuf/videobuf2-v4l2.o: In function `vb2_fop_poll': drivers/media/common/videobuf/videobuf2-v4l2.c:911: undefined reference to `video_devdata' vim +678 drivers/media/common/videobuf/videobuf2-v4l2.c 3c5be988 drivers/media/v4l2-c
Re: [PATCH v6 3/9] v4l: platform: Add Renesas CEU driver
Hi Jacopo,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v4.15-rc8]
[cannot apply to linuxtv-media/master next-20180119]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Jacopo-Mondi/Renesas-Capture-Engine-Unit-CEU-V4L2-driver/20180120-053007
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 7.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=ia64
Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings
All warnings (new ones prefixed by >>):
drivers/media/platform/renesas-ceu.c: In function 'ceu_start_streaming':
>> drivers/media/platform/renesas-ceu.c:287:2: warning: 'cdwdr' may be used
>> uninitialized in this function [-Wmaybe-uninitialized]
iowrite32(data, priv->base + reg_offs);
^~
drivers/media/platform/renesas-ceu.c:335:27: note: 'cdwdr' was declared here
u32 camcr, cdocr, cfzsr, cdwdr, capwr;
^
>> drivers/media/platform/renesas-ceu.c:287:2: warning: 'cfzsr' may be used
>> uninitialized in this function [-Wmaybe-uninitialized]
iowrite32(data, priv->base + reg_offs);
^~
drivers/media/platform/renesas-ceu.c:335:20: note: 'cfzsr' was declared here
u32 camcr, cdocr, cfzsr, cdwdr, capwr;
^
>> drivers/media/platform/renesas-ceu.c:415:8: warning: 'camcr' may be used
>> uninitialized in this function [-Wmaybe-uninitialized]
camcr |= mbus_flags & V4L2_MBUS_HSYNC_ACTIVE_LOW ? 1 << 0 : 0;
~~^~~
drivers/media/platform/renesas-ceu.c:335:6: note: 'camcr' was declared here
u32 camcr, cdocr, cfzsr, cdwdr, capwr;
^
drivers/media/platform/renesas-ceu.c: In function 'ceu_probe':
>> drivers/media/platform/renesas-ceu.c:1621:9: warning: 'ret' may be used
>> uninitialized in this function [-Wmaybe-uninitialized]
return ret;
^~~
vim +/cdwdr +287 drivers/media/platform/renesas-ceu.c
284
285 static void ceu_write(struct ceu_device *priv, unsigned int reg_offs,
u32 data)
286 {
> 287 iowrite32(data, priv->base + reg_offs);
288 }
289
290 static u32 ceu_read(struct ceu_device *priv, unsigned int reg_offs)
291 {
292 return ioread32(priv->base + reg_offs);
293 }
294
295 /*
296 * ceu_soft_reset() - Software reset the CEU interface.
297 * @ceu_device: CEU device.
298 *
299 * Returns 0 for success, -EIO for error.
300 */
301 static int ceu_soft_reset(struct ceu_device *ceudev)
302 {
303 unsigned int i;
304
305 ceu_write(ceudev, CEU_CAPSR, CEU_CAPSR_CPKIL);
306
307 for (i = 0; i < 100; i++) {
308 if (!(ceu_read(ceudev, CEU_CSTSR) & CEU_CSTRST_CPTON))
309 break;
310 udelay(1);
311 }
312
313 if (i == 100) {
314 dev_err(ceudev->dev, "soft reset time out\n");
315 return -EIO;
316 }
317
318 for (i = 0; i < 100; i++) {
319 if (!(ceu_read(ceudev, CEU_CAPSR) & CEU_CAPSR_CPKIL))
320 return 0;
321 udelay(1);
322 }
323
324 /* If we get here, CEU has not reset properly. */
325 return -EIO;
326 }
327
328 /* --- CEU Capture Operations --- */
329
330 /*
331 * ceu_hw_config() - Configure CEU interface registers.
332 */
333 static int ceu_hw_config(struct ceu_device *ceudev)
334 {
> 335 u32 camcr, cdocr, cfzsr, cdwdr, capwr;
336 struct v4l2_pix_format_mplane *pix = &ceudev->v4l2_pix;
337 struct ceu_subdev *ceu_sd = ceudev->sd;
338 struct ceu_mbus_fmt *mbus_fmt = &ceu_sd->mbus_fmt;
339 unsigned int mbus_flags = ceu_sd->mbus_flags;
340
341 /* Start configuring CEU registers */
342 ceu_write(ceudev, CEU_CAIFR, 0);
343 ceu_write(ceudev, CEU_CFWCR, 0);
344 ceu_write(ceudev, CEU_CRCNTR, 0);
345 ceu_write(ceudev, CEU_CRCMPR, 0);
346
347 /* Set the frame capture period for both image capture and data
sync. */
348 capwr = (pix->height << 16) | pix->width * mbus_fmt->bpp / 8;
349
350 /*
351 * Swap input data endianness by default.
352 * In data fetch mode bytes are rec
Re: [PATCH v6 3/9] v4l: platform: Add Renesas CEU driver
Hi Jacopo,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v4.15-rc8]
[cannot apply to linuxtv-media/master next-20180119]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Jacopo-Mondi/Renesas-Capture-Engine-Unit-CEU-V4L2-driver/20180120-053007
config: mn10300-allmodconfig (attached as .config)
compiler: am33_2.0-linux-gcc (GCC) 7.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=mn10300
Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings
All warnings (new ones prefixed by >>):
In file included from include/linux/scatterlist.h:9:0,
from include/linux/dma-mapping.h:11,
from drivers/media/platform/renesas-ceu.c:16:
drivers/media/platform/renesas-ceu.c: In function 'ceu_start_streaming':
>> arch/mn10300/include/asm/io.h:63:25: warning: 'cdwdr' may be used
>> uninitialized in this function [-Wmaybe-uninitialized]
*(volatile u32 *) addr = b;
~~~^~~
drivers/media/platform/renesas-ceu.c:335:27: note: 'cdwdr' was declared here
u32 camcr, cdocr, cfzsr, cdwdr, capwr;
^
In file included from include/linux/scatterlist.h:9:0,
from include/linux/dma-mapping.h:11,
from drivers/media/platform/renesas-ceu.c:16:
>> arch/mn10300/include/asm/io.h:63:25: warning: 'cfzsr' may be used
>> uninitialized in this function [-Wmaybe-uninitialized]
*(volatile u32 *) addr = b;
~~~^~~
drivers/media/platform/renesas-ceu.c:335:20: note: 'cfzsr' was declared here
u32 camcr, cdocr, cfzsr, cdwdr, capwr;
^
drivers/media/platform/renesas-ceu.c:415:8: warning: 'camcr' may be used
uninitialized in this function [-Wmaybe-uninitialized]
camcr |= mbus_flags & V4L2_MBUS_HSYNC_ACTIVE_LOW ? 1 << 0 : 0;
~~^~~
drivers/media/platform/renesas-ceu.c:335:6: note: 'camcr' was declared here
u32 camcr, cdocr, cfzsr, cdwdr, capwr;
^
drivers/media/platform/renesas-ceu.c: In function 'ceu_probe':
drivers/media/platform/renesas-ceu.c:1621:9: warning: 'ret' may be used
uninitialized in this function [-Wmaybe-uninitialized]
return ret;
^~~
--
In file included from include/linux/scatterlist.h:9:0,
from include/linux/dma-mapping.h:11,
from drivers/media//platform/renesas-ceu.c:16:
drivers/media//platform/renesas-ceu.c: In function 'ceu_start_streaming':
>> arch/mn10300/include/asm/io.h:63:25: warning: 'cdwdr' may be used
>> uninitialized in this function [-Wmaybe-uninitialized]
*(volatile u32 *) addr = b;
~~~^~~
drivers/media//platform/renesas-ceu.c:335:27: note: 'cdwdr' was declared here
u32 camcr, cdocr, cfzsr, cdwdr, capwr;
^
In file included from include/linux/scatterlist.h:9:0,
from include/linux/dma-mapping.h:11,
from drivers/media//platform/renesas-ceu.c:16:
>> arch/mn10300/include/asm/io.h:63:25: warning: 'cfzsr' may be used
>> uninitialized in this function [-Wmaybe-uninitialized]
*(volatile u32 *) addr = b;
~~~^~~
drivers/media//platform/renesas-ceu.c:335:20: note: 'cfzsr' was declared here
u32 camcr, cdocr, cfzsr, cdwdr, capwr;
^
drivers/media//platform/renesas-ceu.c:415:8: warning: 'camcr' may be used
uninitialized in this function [-Wmaybe-uninitialized]
camcr |= mbus_flags & V4L2_MBUS_HSYNC_ACTIVE_LOW ? 1 << 0 : 0;
~~^~~
drivers/media//platform/renesas-ceu.c:335:6: note: 'camcr' was declared here
u32 camcr, cdocr, cfzsr, cdwdr, capwr;
^
drivers/media//platform/renesas-ceu.c: In function 'ceu_probe':
drivers/media//platform/renesas-ceu.c:1621:9: warning: 'ret' may be used
uninitialized in this function [-Wmaybe-uninitialized]
return ret;
^~~
vim +/cdwdr +63 arch/mn10300/include/asm/io.h
b920de1b include/asm-mn10300/io.h David Howells 2008-02-08 60
b920de1b include/asm-mn10300/io.h David Howells 2008-02-08 61 static inline
void writel(u32 b, volatile void __iomem *addr)
b920de1b include/asm-mn10300/io.h David Howells 2008-02-08 62 {
b920de1b include/asm-mn10300/io.h David Howells 2008-02-08 @63
*(volatile u32 *) addr = b;
b920de1b include/asm-mn10300/io.h David Howells 2008-02-08 64 }
b920de1b include/asm-mn10300/io.h Da
[linux-next:master 6047/11012] include/linux/compiler.h:183: undefined reference to `__tracepoint_vb2_buf_queue'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: 761914dd2975bc443024f0ec10a66a26b7186ec2
commit: 03fbdb2fc2b8bb27b0ee0534fd3e9c57cdc3854a [6047/11012] media: move
videobuf2 to drivers/media/common
config: x86_64-randconfig-n0-01202005 (attached as .config)
compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025
reproduce:
git checkout 03fbdb2fc2b8bb27b0ee0534fd3e9c57cdc3854a
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
drivers/media/common/videobuf/videobuf2-core.o: In function
`__read_once_size':
>> include/linux/compiler.h:183: undefined reference to
>> `__tracepoint_vb2_buf_queue'
>> include/linux/compiler.h:183: undefined reference to
>> `__tracepoint_vb2_buf_queue'
>> include/linux/compiler.h:183: undefined reference to
>> `__tracepoint_vb2_buf_done'
>> include/linux/compiler.h:183: undefined reference to
>> `__tracepoint_vb2_buf_done'
>> include/linux/compiler.h:183: undefined reference to `__tracepoint_vb2_qbuf'
>> include/linux/compiler.h:183: undefined reference to `__tracepoint_vb2_qbuf'
>> include/linux/compiler.h:183: undefined reference to `__tracepoint_vb2_dqbuf'
>> include/linux/compiler.h:183: undefined reference to `__tracepoint_vb2_dqbuf'
drivers/media/common/videobuf/videobuf2-core.o:(__jump_table+0x10):
undefined reference to `__tracepoint_vb2_buf_queue'
drivers/media/common/videobuf/videobuf2-core.o:(__jump_table+0x28):
undefined reference to `__tracepoint_vb2_buf_done'
drivers/media/common/videobuf/videobuf2-core.o:(__jump_table+0x40):
undefined reference to `__tracepoint_vb2_qbuf'
drivers/media/common/videobuf/videobuf2-core.o:(__jump_table+0x58):
undefined reference to `__tracepoint_vb2_dqbuf'
drivers/media/common/videobuf/videobuf2-v4l2.o: In function `vb2_poll':
drivers/media/common/videobuf/videobuf2-v4l2.c:678: undefined reference to
`video_devdata'
drivers/media/common/videobuf/videobuf2-v4l2.c:685: undefined reference to
`v4l2_event_pending'
drivers/media/common/videobuf/videobuf2-v4l2.o: In function
`vb2_ioctl_reqbufs':
drivers/media/common/videobuf/videobuf2-v4l2.c:714: undefined reference to
`video_devdata'
drivers/media/common/videobuf/videobuf2-v4l2.o: In function
`vb2_ioctl_create_bufs':
drivers/media/common/videobuf/videobuf2-v4l2.c:733: undefined reference to
`video_devdata'
drivers/media/common/videobuf/videobuf2-v4l2.o: In function
`vb2_ioctl_prepare_buf':
drivers/media/common/videobuf/videobuf2-v4l2.c:759: undefined reference to
`video_devdata'
drivers/media/common/videobuf/videobuf2-v4l2.o: In function
`vb2_ioctl_querybuf':
drivers/media/common/videobuf/videobuf2-v4l2.c:769: undefined reference to
`video_devdata'
drivers/media/common/videobuf/videobuf2-v4l2.o: In function `vb2_ioctl_qbuf':
drivers/media/common/videobuf/videobuf2-v4l2.c:778: undefined reference to
`video_devdata'
drivers/media/common/videobuf/videobuf2-v4l2.o:drivers/media/common/videobuf/videobuf2-v4l2.c:788:
more undefined references to `video_devdata' follow
drivers/media/common/videobuf/videobuf2-v4l2.o: In function
`_vb2_fop_release':
drivers/media/common/videobuf/videobuf2-v4l2.c:848: undefined reference to
`v4l2_fh_release'
vim +183 include/linux/compiler.h
d976441f Andrey Ryabinin 2015-10-19 179
d976441f Andrey Ryabinin 2015-10-19 180 static __always_inline
d976441f Andrey Ryabinin 2015-10-19 181 void __read_once_size(const
volatile void *p, void *res, int size)
230fa253 Christian Borntraeger 2014-11-25 182 {
d976441f Andrey Ryabinin 2015-10-19 @183 __READ_ONCE_SIZE;
230fa253 Christian Borntraeger 2014-11-25 184 }
d976441f Andrey Ryabinin 2015-10-19 185
:: The code at line 183 was first introduced by commit
:: d976441f44bc5d48635d081d277aa76556ffbf8b compiler, atomics, kasan:
Provide READ_ONCE_NOCHECK()
:: TO: Andrey Ryabinin
:: CC: Ingo Molnar
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
[linux-next:master 7145/11012] drivers/media//i2c/ov7740.c:1139:38: error: 'struct v4l2_subdev' has no member named 'entity'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: 761914dd2975bc443024f0ec10a66a26b7186ec2
commit: 39c5c4471b8d793daf868bd004e56ed420e89707 [7145/11012] media: i2c: Add
the ov7740 image sensor driver
config: i386-randconfig-x007-201803 (attached as .config)
compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025
reproduce:
git checkout 39c5c4471b8d793daf868bd004e56ed420e89707
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
drivers/media//i2c/ov7740.c: In function 'ov7740_probe':
>> drivers/media//i2c/ov7740.c:1139:38: error: 'struct v4l2_subdev' has no
>> member named 'entity'
media_entity_cleanup(&ov7740->subdev.entity);
^
vim +1139 drivers/media//i2c/ov7740.c
1100
1101 ret = ov7740_set_power(ov7740, 1);
1102 if (ret)
1103 return ret;
1104
1105 ret = ov7740_detect(ov7740);
1106 if (ret)
1107 goto error_detect;
1108
1109 mutex_init(&ov7740->mutex);
1110
ret = ov7740_init_controls(ov7740);
1112 if (ret)
1113 goto error_init_controls;
1114
1115 v4l_info(client, "chip found @ 0x%02x (%s)\n",
1116 client->addr << 1, client->adapter->name);
1117
1118 ov7740->fmt = &ov7740_formats[0];
1119 ov7740->frmsize = &ov7740_framesizes[0];
1120
1121 ov7740_get_default_format(sd, &ov7740->format);
1122
1123 ret = v4l2_async_register_subdev(sd);
1124 if (ret)
1125 goto error_async_register;
1126
1127 pm_runtime_set_active(&client->dev);
1128 pm_runtime_enable(&client->dev);
1129 pm_runtime_idle(&client->dev);
1130
1131 return 0;
1132
1133 error_async_register:
1134 v4l2_ctrl_handler_free(ov7740->subdev.ctrl_handler);
1135 error_init_controls:
1136 ov7740_free_controls(ov7740);
1137 error_detect:
1138 ov7740_set_power(ov7740, 0);
> 1139 media_entity_cleanup(&ov7740->subdev.entity);
1140
1141 return ret;
1142 }
1143
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH v6 2/2] media: V3s: Add support for Allwinner CSI.
Hi Yong,
I love your patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.15-rc9 next-20180119]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Yong-Deng/dt-bindings-media-Add-Allwinner-V3s-Camera-Sensor-Interface-CSI/20180126-054511
base: git://linuxtv.org/media_tree.git master
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c: In function
'sun6i_csi_update_buf_addr':
>> drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c:567:31: error:
>> 'PHYS_OFFSET' undeclared (first use in this function); did you mean
>> 'PAGE_OFFSET'?
dma_addr_t bus_addr = addr - PHYS_OFFSET;
^~~
PAGE_OFFSET
drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c:567:31: note: each
undeclared identifier is reported only once for each function it appears in
vim +567 drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
562
563 void sun6i_csi_update_buf_addr(struct sun6i_csi *csi, dma_addr_t addr)
564 {
565 struct sun6i_csi_dev *sdev = sun6i_csi_to_dev(csi);
566 /* transform physical address to bus address */
> 567 dma_addr_t bus_addr = addr - PHYS_OFFSET;
568
569 regmap_write(sdev->regmap, CSI_CH_F0_BUFA_REG,
570 (bus_addr + sdev->planar_offset[0]) >> 2);
571 if (sdev->planar_offset[1] != -1)
572 regmap_write(sdev->regmap, CSI_CH_F1_BUFA_REG,
573 (bus_addr + sdev->planar_offset[1]) >> 2);
574 if (sdev->planar_offset[2] != -1)
575 regmap_write(sdev->regmap, CSI_CH_F2_BUFA_REG,
576 (bus_addr + sdev->planar_offset[2]) >> 2);
577 }
578
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
[linux-next:master 3766/11889] drivers/media/dvb-frontends/stb0899_drv.h:151:36: error: weak declaration of 'stb0899_attach' being applied to a already existing, static definition
Hi Wolfgang,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: f0701bf7db7ab816244aed52d28ac49f32c8c2c9
commit: 6cdeaed3b1420bd2569891be0c4123ff59628e9e [3766/11889] media:
dvb_usb_pctv452e: module refcount changes were unbalanced
config: i386-randconfig-c0-01270453 (attached as .config)
compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025
reproduce:
git checkout 6cdeaed3b1420bd2569891be0c4123ff59628e9e
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
In file included from drivers/media/usb/dvb-usb/pctv452e.c:20:0:
drivers/media/usb/dvb-usb/pctv452e.c: In function 'pctv452e_frontend_attach':
>> drivers/media/dvb-frontends/stb0899_drv.h:151:36: error: weak declaration of
>> 'stb0899_attach' being applied to a already existing, static definition
static inline struct dvb_frontend *stb0899_attach(struct stb0899_config
*config,
^~
vim +/stb0899_attach +151 drivers/media/dvb-frontends/stb0899_drv.h
ae9902da9 drivers/media/dvb/frontends/stb0899_drv.h Manu Abraham 2007-10-08
150
ae9902da9 drivers/media/dvb/frontends/stb0899_drv.h Manu Abraham 2007-10-08
@151 static inline struct dvb_frontend *stb0899_attach(struct stb0899_config
*config,
ae9902da9 drivers/media/dvb/frontends/stb0899_drv.h Manu Abraham 2007-10-08
152 struct i2c_adapter *i2c)
ae9902da9 drivers/media/dvb/frontends/stb0899_drv.h Manu Abraham 2007-10-08
153 {
ae9902da9 drivers/media/dvb/frontends/stb0899_drv.h Manu Abraham 2007-10-08
154printk(KERN_WARNING "%s: Driver disabled by Kconfig\n", __func__);
ae9902da9 drivers/media/dvb/frontends/stb0899_drv.h Manu Abraham 2007-10-08
155return NULL;
ae9902da9 drivers/media/dvb/frontends/stb0899_drv.h Manu Abraham 2007-10-08
156 }
ae9902da9 drivers/media/dvb/frontends/stb0899_drv.h Manu Abraham 2007-10-08
157
:: The code at line 151 was first introduced by commit
:: ae9902da96b4d2d82707706c7fbc93a8e501dde8 V4L/DVB (9417): DVB_ATTACH for
STB0899, STB6100, TDA8261
:: TO: Manu Abraham
:: CC: Mauro Carvalho Chehab
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH v6 2/2] media: V3s: Add support for Allwinner CSI.
Hi Yong,
I love your patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.15-rc9 next-20180126]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Yong-Deng/dt-bindings-media-Add-Allwinner-V3s-Camera-Sensor-Interface-CSI/20180126-054511
base: git://linuxtv.org/media_tree.git master
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c: In function
'sun6i_csi_update_buf_addr':
>> drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c:567:31: error:
>> 'PHYS_OFFSET' undeclared (first use in this function)
dma_addr_t bus_addr = addr - PHYS_OFFSET;
^~~
drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c:567:31: note: each
undeclared identifier is reported only once for each function it appears in
vim +/PHYS_OFFSET +567 drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
562
563 void sun6i_csi_update_buf_addr(struct sun6i_csi *csi, dma_addr_t addr)
564 {
565 struct sun6i_csi_dev *sdev = sun6i_csi_to_dev(csi);
566 /* transform physical address to bus address */
> 567 dma_addr_t bus_addr = addr - PHYS_OFFSET;
568
569 regmap_write(sdev->regmap, CSI_CH_F0_BUFA_REG,
570 (bus_addr + sdev->planar_offset[0]) >> 2);
571 if (sdev->planar_offset[1] != -1)
572 regmap_write(sdev->regmap, CSI_CH_F1_BUFA_REG,
573 (bus_addr + sdev->planar_offset[1]) >> 2);
574 if (sdev->planar_offset[2] != -1)
575 regmap_write(sdev->regmap, CSI_CH_F2_BUFA_REG,
576 (bus_addr + sdev->planar_offset[2]) >> 2);
577 }
578
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
[ragnatech:media-tree] BUILD SUCCESS 273caa260035c03d89ad63d72d8cd3d9e5c5e3f1
tree/branch: git://git.ragnatech.se/linux media-tree branch HEAD: 273caa260035c03d89ad63d72d8cd3d9e5c5e3f1 media: v4l2-compat-ioctl32.c: make ctrl_is_pointer work for subdevs elapsed time: 283m configs tested: 131 The following configs have been built successfully. More configs may be tested in the coming days. x86_64 acpi-redef x86_64 allyesdebian x86_64nfsroot i386 randconfig-x019-201804 i386 randconfig-x010-201804 i386 randconfig-x015-201804 i386 randconfig-x014-201804 i386 randconfig-x012-201804 i386 randconfig-x011-201804 i386 randconfig-x017-201804 i386 randconfig-x016-201804 i386 randconfig-x018-201804 i386 randconfig-x013-201804 i386 randconfig-n0-201804 x86_64 randconfig-x008-201804 x86_64 randconfig-x000-201804 x86_64 randconfig-x005-201804 x86_64 randconfig-x002-201804 x86_64 randconfig-x007-201804 x86_64 randconfig-x009-201804 x86_64 randconfig-x006-201804 x86_64 randconfig-x001-201804 x86_64 randconfig-x003-201804 x86_64 randconfig-x004-201804 i386 randconfig-i0-201804 i386 randconfig-i1-201804 alpha defconfig pariscallnoconfig parisc b180_defconfig pariscc3000_defconfig parisc defconfig arm allnoconfig arm at91_dt_defconfig arm efm32_defconfig arm exynos_defconfig armmulti_v5_defconfig armmulti_v7_defconfig armshmobile_defconfig arm sunxi_defconfig arm64 allnoconfig arm64 defconfig blackfinBF526-EZBRD_defconfig blackfinBF533-EZKIT_defconfig blackfinBF561-EZKIT-SMP_defconfig blackfin TCM-BF537_defconfig cris etrax-100lx_v2_defconfig powerpc katmai_defconfig sparc64 allyesconfig x86_64 randconfig-g0-02011358 frv defconfig mn10300 asb2364_defconfig openriscor1ksim_defconfig tile tilegx_defconfig um i386_defconfig um x86_64_defconfig i386 allmodconfig i386 randconfig-a0-201804 i386 randconfig-a1-201804 x86_64 randconfig-s0-02011538 x86_64 randconfig-s1-02011538 x86_64 randconfig-s2-02011538 x86_64 randconfig-x010-201804 x86_64 randconfig-x011-201804 x86_64 randconfig-x012-201804 x86_64 randconfig-x013-201804 x86_64 randconfig-x014-201804 x86_64 randconfig-x015-201804 x86_64 randconfig-x016-201804 x86_64 randconfig-x017-201804 x86_64 randconfig-x018-201804 x86_64 randconfig-x019-201804 i386 alldefconfig i386 allnoconfig i386defconfig m68k m5475evb_defconfig m68k multi_defconfig m68k sun3_defconfig i386 randconfig-s0-201804 i386 randconfig-s1-201804 x86_64 randconfig-s3-02011549 x86_64 randconfig-s4-02011549 x86_64 randconfig-s5-02011549 arm colibri_pxa270_defconfig mips jazz_defconfig shdreamcast_defconfig x86_64 randconfig-u0-02011532 powerpc allnoconfig powerpc defconfig powerpc ppc64_defconfig s390default_defconfig microblaze mmu_defconfig microblazenommu_defconfig sparc defconfig sparc64 allnoconfig sparc64 defconfig c6xevmc6678_defconfig h8300h8300h-sim_defconfig m32r m32104ut_defconfig m32r mappi3.smp_defconfig m32r opsput_defconfig m32r usrv_defconfig nios2 10m
Re: [PATCH] media: cx25821: prevent out-of-bounds read on array card
Hi Colin,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v4.15 next-20180202]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Colin-King/media-cx25821-prevent-out-of-bounds-read-on-array-card/20180203-130958
base: git://linuxtv.org/media_tree.git master
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 7.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=xtensa
All warnings (new ones prefixed by >>):
In file included from include/linux/printk.h:7:0,
from include/linux/kernel.h:14,
from include/linux/list.h:9,
from include/linux/kobject.h:20,
from include/linux/device.h:17,
from include/linux/i2c.h:30,
from drivers/media/pci/cx25821/cx25821-core.c:22:
drivers/media/pci/cx25821/cx25821-core.c: In function 'cx25821_dev_setup':
>> include/linux/kern_levels.h:5:18: warning: format '%ld' expects argument of
>> type 'long int', but argument 3 has type 'unsigned int' [-Wformat=]
#define KERN_SOH "\001" /* ASCII Start Of Header */
^
include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH'
#define KERN_INFO KERN_SOH "6" /* informational */
^~~~
include/linux/printk.h:308:9: note: in expansion of macro 'KERN_INFO'
printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
^
>> drivers/media/pci/cx25821/cx25821.h:380:2: note: in expansion of macro
>> 'pr_info'
pr_info("(%d): " fmt, dev->board, ##args)
^~~
>> drivers/media/pci/cx25821/cx25821-core.c:871:3: note: in expansion of macro
>> 'CX25821_INFO'
CX25821_INFO("dev->nr >= %ld", ARRAY_SIZE(card));
^~~~
vim +/pr_info +380 drivers/media/pci/cx25821/cx25821.h
02b20b0b drivers/staging/cx25821/cx25821.h Mauro Carvalho Chehab 2009-09-15
374
36d89f7d drivers/staging/cx25821/cx25821.h Joe Perches 2010-11-07
375 #define CX25821_ERR(fmt, args...) \
36d89f7d drivers/staging/cx25821/cx25821.h Joe Perches 2010-11-07
376pr_err("(%d): " fmt, dev->board, ##args)
36d89f7d drivers/staging/cx25821/cx25821.h Joe Perches 2010-11-07
377 #define CX25821_WARN(fmt, args...)\
36d89f7d drivers/staging/cx25821/cx25821.h Joe Perches 2010-11-07
378pr_warn("(%d): " fmt, dev->board, ##args)
36d89f7d drivers/staging/cx25821/cx25821.h Joe Perches 2010-11-07
379 #define CX25821_INFO(fmt, args...)\
36d89f7d drivers/staging/cx25821/cx25821.h Joe Perches 2010-11-07
@380pr_info("(%d): " fmt, dev->board, ##args)
02b20b0b drivers/staging/cx25821/cx25821.h Mauro Carvalho Chehab 2009-09-15
381
:: The code at line 380 was first introduced by commit
:: 36d89f7de4a4937848de86d9b35cb03a9f0357e1 [media]
drivers/staging/cx25821: Use pr_fmt and pr_
:: TO: Joe Perches
:: CC: Mauro Carvalho Chehab
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH] media: cx25821: prevent out-of-bounds read on array card
Hi Colin,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v4.15 next-20180202]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Colin-King/media-cx25821-prevent-out-of-bounds-read-on-array-card/20180203-130958
base: git://linuxtv.org/media_tree.git master
config: i386-randconfig-sb0-02031534 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All warnings (new ones prefixed by >>):
In file included from include/linux/kernel.h:15:0,
from include/linux/list.h:9,
from include/linux/kobject.h:20,
from include/linux/device.h:17,
from include/linux/i2c.h:30,
from drivers/media/pci/cx25821/cx25821-core.c:22:
drivers/media/pci/cx25821/cx25821-core.c: In function 'cx25821_dev_setup':
>> include/linux/build_bug.h:30:45: warning: format '%ld' expects argument of
>> type 'long int', but argument 3 has type 'unsigned int' [-Wformat=]
#define BUILD_BUG_ON_ZERO(e) (sizeof(struct { int:(-!!(e)); }))
^
include/linux/compiler-gcc.h:65:28: note: in expansion of macro
'BUILD_BUG_ON_ZERO'
#define __must_be_array(a) BUILD_BUG_ON_ZERO(__same_type((a), &(a)[0]))
^
include/linux/kernel.h:71:59: note: in expansion of macro '__must_be_array'
#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) +
__must_be_array(arr))
^
>> include/linux/printk.h:308:34: note: in expansion of macro 'ARRAY_SIZE'
printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
^
drivers/media/pci/cx25821/cx25821.h:380:2: note: in expansion of macro
'pr_info'
pr_info("(%d): " fmt, dev->board, ##args)
^
drivers/media/pci/cx25821/cx25821-core.c:871:3: note: in expansion of macro
'CX25821_INFO'
CX25821_INFO("dev->nr >= %ld", ARRAY_SIZE(card));
^
--
In file included from include/linux/kernel.h:15:0,
from include/linux/list.h:9,
from include/linux/kobject.h:20,
from include/linux/device.h:17,
from include/linux/i2c.h:30,
from drivers/media//pci/cx25821/cx25821-core.c:22:
drivers/media//pci/cx25821/cx25821-core.c: In function 'cx25821_dev_setup':
>> include/linux/build_bug.h:30:45: warning: format '%ld' expects argument of
>> type 'long int', but argument 3 has type 'unsigned int' [-Wformat=]
#define BUILD_BUG_ON_ZERO(e) (sizeof(struct { int:(-!!(e)); }))
^
include/linux/compiler-gcc.h:65:28: note: in expansion of macro
'BUILD_BUG_ON_ZERO'
#define __must_be_array(a) BUILD_BUG_ON_ZERO(__same_type((a), &(a)[0]))
^
include/linux/kernel.h:71:59: note: in expansion of macro '__must_be_array'
#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) +
__must_be_array(arr))
^
>> include/linux/printk.h:308:34: note: in expansion of macro 'ARRAY_SIZE'
printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
^
drivers/media//pci/cx25821/cx25821.h:380:2: note: in expansion of macro
'pr_info'
pr_info("(%d): " fmt, dev->board, ##args)
^
drivers/media//pci/cx25821/cx25821-core.c:871:3: note: in expansion of macro
'CX25821_INFO'
CX25821_INFO("dev->nr >= %ld", ARRAY_SIZE(card));
^
vim +/ARRAY_SIZE +308 include/linux/printk.h
968ab183 Linus Torvalds 2010-11-15 287
6e099f55 Dan Streetman 2014-06-04 288 /*
6e099f55 Dan Streetman 2014-06-04 289 * These can be used to print at the
various log levels.
6e099f55 Dan Streetman 2014-06-04 290 * All of these will print
unconditionally, although note that pr_debug()
6e099f55 Dan Streetman 2014-06-04 291 * and other debug macros are compiled
out unless either DEBUG is defined
6e099f55 Dan Streetman 2014-06-04 292 * or CONFIG_DYNAMIC_DEBUG is set.
6e099f55 Dan Streetman 2014-06-04 293 */
a0cba217 Linus Torvalds 2016-08-09 294 #define pr_emerg(fmt, ...) \
a0cba217 Linus Torvalds 2016-08-09 295 printk(KERN_EMERG pr_fmt(fmt),
##__VA_ARGS__)
a0cba217 Linus Torvalds 2016-08-09 296 #define pr_alert(fmt, ...) \
a0cba217 Linus Torvalds 2016-08-09 297 printk(KERN_ALERT pr_fmt(fmt),
##__VA_ARGS__)
a0cba217 Linus Torvalds 2016-08-09 298 #define pr_crit(fmt, ...) \
a0cba217 Linus Torvalds 2016-08-09 299 printk(KERN_CRIT pr_fmt(fmt),
##__VA_ARGS__)
a0cba217 Linus Torvalds 2016-08-09 300 #define pr_err(fmt, ...) \
a0cba217 Linus Torvalds 2016-08-09 301
[linux-next:master 3746/12754] drivers/media/dvb-frontends/stb0899_drv.h:151:36: error: weak declaration of 'stb0899_attach' being applied to a already existing, static definition
Hi Wolfgang,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: ba0749266e17f43d4740781b2120127215440bd1
commit: 6cdeaed3b1420bd2569891be0c4123ff59628e9e [3746/12754] media:
dvb_usb_pctv452e: module refcount changes were unbalanced
config: x86_64-randconfig-s5-02032012 (attached as .config)
compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025
reproduce:
git checkout 6cdeaed3b1420bd2569891be0c4123ff59628e9e
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
In file included from drivers/media/usb/dvb-usb/pctv452e.c:20:0:
drivers/media/usb/dvb-usb/pctv452e.c: In function 'pctv452e_frontend_attach':
>> drivers/media/dvb-frontends/stb0899_drv.h:151:36: error: weak declaration of
>> 'stb0899_attach' being applied to a already existing, static definition
static inline struct dvb_frontend *stb0899_attach(struct stb0899_config
*config,
^~
vim +/stb0899_attach +151 drivers/media/dvb-frontends/stb0899_drv.h
ae9902da9 drivers/media/dvb/frontends/stb0899_drv.h Manu Abraham 2007-10-08
150
ae9902da9 drivers/media/dvb/frontends/stb0899_drv.h Manu Abraham 2007-10-08
@151 static inline struct dvb_frontend *stb0899_attach(struct stb0899_config
*config,
ae9902da9 drivers/media/dvb/frontends/stb0899_drv.h Manu Abraham 2007-10-08
152 struct i2c_adapter *i2c)
ae9902da9 drivers/media/dvb/frontends/stb0899_drv.h Manu Abraham 2007-10-08
153 {
ae9902da9 drivers/media/dvb/frontends/stb0899_drv.h Manu Abraham 2007-10-08
154printk(KERN_WARNING "%s: Driver disabled by Kconfig\n", __func__);
ae9902da9 drivers/media/dvb/frontends/stb0899_drv.h Manu Abraham 2007-10-08
155return NULL;
ae9902da9 drivers/media/dvb/frontends/stb0899_drv.h Manu Abraham 2007-10-08
156 }
ae9902da9 drivers/media/dvb/frontends/stb0899_drv.h Manu Abraham 2007-10-08
157
:: The code at line 151 was first introduced by commit
:: ae9902da96b4d2d82707706c7fbc93a8e501dde8 V4L/DVB (9417): DVB_ATTACH for
STB0899, STB6100, TDA8261
:: TO: Manu Abraham
:: CC: Mauro Carvalho Chehab
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
[ragnatech:media-tree] BUILD INCOMPLETE 231783073ebfc4acf02a45cb78a52ffa16e4e6d3
tree/branch: git://git.ragnatech.se/linux media-tree branch HEAD: 231783073ebfc4acf02a45cb78a52ffa16e4e6d3 media: v4l: rcar_fdp1: Enable compilation on Gen2 platforms TIMEOUT after 600m Sorry we cannot finish the testset for your branch within a reasonable time. It's our fault -- either some build server is down or some build worker is busy doing bisects for _other_ trees. The branch will get more complete coverage and possible error reports when our build infrastructure is restored or catches up. There will be no more build success notification for this branch head, but you can expect reasonably good test coverage after waiting for 1 day. configs tested: 50 i386 tinyconfig i386 randconfig-x012-201829 i386 randconfig-x017-201829 i386 randconfig-x014-201829 i386 randconfig-x016-201829 i386 randconfig-x013-201829 i386 randconfig-x011-201829 i386 randconfig-x018-201829 i386 randconfig-x010-201829 i386 randconfig-x015-201829 i386 randconfig-x019-201829 x86_64 randconfig-x007-201829 x86_64 randconfig-x003-201829 x86_64 randconfig-x000-201829 x86_64 randconfig-x005-201829 x86_64 randconfig-x004-201829 x86_64 randconfig-x008-201829 x86_64 randconfig-x001-201829 x86_64 randconfig-x009-201829 x86_64 randconfig-x002-201829 x86_64 randconfig-x006-201829 x86_64 acpi-redef x86_64 allyesdebian x86_64nfsroot x86_64 randconfig-x010-201829 x86_64 randconfig-x011-201829 x86_64 randconfig-x012-201829 x86_64 randconfig-x013-201829 x86_64 randconfig-x014-201829 x86_64 randconfig-x015-201829 x86_64 randconfig-x016-201829 x86_64 randconfig-x017-201829 x86_64 randconfig-x018-201829 x86_64 randconfig-x019-201829 ia64 alldefconfig ia64 allnoconfig ia64defconfig openriscor1ksim_defconfig um i386_defconfig um x86_64_defconfig c6xevmc6678_defconfig h8300h8300h-sim_defconfig nios2 10m50_defconfig xtensa common_defconfig xtensa iss_defconfig alpha defconfig pariscallnoconfig parisc b180_defconfig pariscc3000_defconfig parisc defconfig --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
drivers/video/fbdev/omap2/omapfb/omapfb-main.c:290:9-10: WARNING: return of 0/1 in function 'cmp_var_to_colormode' with return type bool
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 9981b4fb8684883dcc0daf088891ff32260b9794 commit: 7378f1149884b183631c6c16c0f1c62bcd7d759d media: omap2: omapfb: allow building it with COMPILE_TEST date: 3 months ago coccinelle warnings: (new ones prefixed by >>) >> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:290:9-10: WARNING: return of >> 0/1 in function 'cmp_var_to_colormode' with return type bool -- >> drivers/video/fbdev/omap2/omapfb/dss/dss_features.c:895:2-5: WARNING: Use >> BUG_ON instead of if condition followed by BUG. Please make sure the condition has no side effects (see conditional BUG_ON definition in include/asm-generic/bug.h) -- >> drivers/video/fbdev/omap2/omapfb/dss/core.c:141:2-26: WARNING: NULL check >> before some freeing functions is not needed. Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
[PATCH] media: omap2: omapfb: fix ifnullfree.cocci warnings
From: kbuild test robot
drivers/video/fbdev/omap2/omapfb/dss/core.c:141:2-26: WARNING: NULL check
before some freeing functions is not needed.
NULL check before some freeing functions is not needed.
Based on checkpatch warning
"kfree(NULL) is safe this check is probably not required"
and kfreeaddr.cocci by Julia Lawall.
Generated by: scripts/coccinelle/free/ifnullfree.cocci
Fixes: 7378f1149884 ("media: omap2: omapfb: allow building it with
COMPILE_TEST")
Signed-off-by: kbuild test robot
---
Please take the patch only if it's a positive warning. Thanks!
core.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/video/fbdev/omap2/omapfb/dss/core.c
+++ b/drivers/video/fbdev/omap2/omapfb/dss/core.c
@@ -137,8 +137,7 @@ static int dss_initialize_debugfs(void)
static void dss_uninitialize_debugfs(void)
{
- if (dss_debugfs_dir)
- debugfs_remove_recursive(dss_debugfs_dir);
+ debugfs_remove_recursive(dss_debugfs_dir);
}
int dss_debugfs_create_file(const char *name, void (*write)(struct seq_file *))
[PATCH] media: omap2: omapfb: fix boolreturn.cocci warnings
From: kbuild test robot
drivers/video/fbdev/omap2/omapfb/omapfb-main.c:290:9-10: WARNING: return of 0/1
in function 'cmp_var_to_colormode' with return type bool
Return statements in functions returning bool should use
true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci
Fixes: 7378f1149884 ("media: omap2: omapfb: allow building it with
COMPILE_TEST")
Signed-off-by: kbuild test robot
---
omapfb-main.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/video/fbdev/omap2/omapfb/omapfb-main.c
+++ b/drivers/video/fbdev/omap2/omapfb/omapfb-main.c
@@ -287,7 +287,7 @@ static bool cmp_var_to_colormode(struct
var->red.length == 0 ||
var->blue.length == 0 ||
var->green.length == 0)
- return 0;
+ return false;
return var->bits_per_pixel == color->bits_per_pixel &&
cmp_component(&var->red, &color->red) &&
[PATCH] media: omap2: omapfb: fix bugon.cocci warnings
From: kbuild test robot
drivers/video/fbdev/omap2/omapfb/dss/dss_features.c:895:2-5: WARNING: Use
BUG_ON instead of if condition followed by BUG.
Please make sure the condition has no side effects (see conditional BUG_ON
definition in include/asm-generic/bug.h)
Use BUG_ON instead of a if condition followed by BUG.
Semantic patch information:
This makes an effort to find cases where BUG() follows an if
condition on an expression and replaces the if condition and BUG()
with a BUG_ON having the conditional expression of the if statement
as argument.
Generated by: scripts/coccinelle/misc/bugon.cocci
Fixes: 7378f1149884 ("media: omap2: omapfb: allow building it with
COMPILE_TEST")
Signed-off-by: kbuild test robot
---
Please take the patch only if it's a positive warning. Thanks!
dss_features.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/video/fbdev/omap2/omapfb/dss/dss_features.c
+++ b/drivers/video/fbdev/omap2/omapfb/dss/dss_features.c
@@ -891,8 +891,7 @@ bool dss_has_feature(enum dss_feat_id id
void dss_feat_get_reg_field(enum dss_feat_reg_field id, u8 *start, u8 *end)
{
- if (id >= omap_current_dss_features->num_reg_fields)
- BUG();
+ BUG_ON(id >= omap_current_dss_features->num_reg_fields);
*start = omap_current_dss_features->reg_fields[id].start;
*end = omap_current_dss_features->reg_fields[id].end;
[linuxtv-media:master 247/250] arch/mips/include/asm/uaccess.h:445:32: warning: initialization makes integer from pointer without a cast
tree: git://linuxtv.org/media_tree.git master
head: 343b23a7c6b6680ef949e6112a4ee60688acf39d
commit: f863ce990030cfc5a57a490b4613be4a523ffce1 [247/250] media: dvb: get rid
of VIDEO_SET_SPU_PALETTE
config: mips-fuloong2e_defconfig (attached as .config)
compiler: mips64el-linux-gnuabi64-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout f863ce990030cfc5a57a490b4613be4a523ffce1
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=mips
All warnings (new ones prefixed by >>):
fs/compat_ioctl.c: In function 'do_video_set_spu_palette':
fs/compat_ioctl.c:218:45: error: invalid application of 'sizeof' to
incomplete type 'struct video_spu_palette'
up_native = compat_alloc_user_space(sizeof(struct video_spu_palette));
^~
In file included from include/linux/uaccess.h:14:0,
from include/linux/compat.h:19,
from fs/compat_ioctl.c:17:
fs/compat_ioctl.c:219:46: error: dereferencing pointer to incomplete type
'struct video_spu_palette'
err = put_user(compat_ptr(palp), &up_native->palette);
^
arch/mips/include/asm/uaccess.h:444:15: note: in definition of macro
'__put_user_check'
__typeof__(*(ptr)) __user *__pu_addr = (ptr); \
^~~
fs/compat_ioctl.c:219:9: note: in expansion of macro 'put_user'
err = put_user(compat_ptr(palp), &up_native->palette);
^~~~
>> arch/mips/include/asm/uaccess.h:445:32: warning: initialization makes
>> integer from pointer without a cast [-Wint-conversion]
__typeof__(*(ptr)) __pu_val = (x);\
^
>> arch/mips/include/asm/uaccess.h:158:2: note: in expansion of macro
>> '__put_user_check'
__put_user_check((x), (ptr), sizeof(*(ptr)))
^~~~
fs/compat_ioctl.c:219:9: note: in expansion of macro 'put_user'
err = put_user(compat_ptr(palp), &up_native->palette);
^~~~
At top level:
fs/compat_ioctl.c:206:12: warning: 'do_video_set_spu_palette' defined but
not used [-Wunused-function]
static int do_video_set_spu_palette(struct file *file,
^~~~
vim +445 arch/mips/include/asm/uaccess.h
^1da177e include/asm-mips/uaccess.h Linus Torvalds 2005-04-16 441
^1da177e include/asm-mips/uaccess.h Linus Torvalds 2005-04-16 442
#define __put_user_check(x, ptr, size)\
^1da177e include/asm-mips/uaccess.h Linus Torvalds 2005-04-16 443 ({
\
fe00f943 include/asm-mips/uaccess.h Ralf Baechle2005-03-01 @444
__typeof__(*(ptr)) __user *__pu_addr = (ptr); \
fe00f943 include/asm-mips/uaccess.h Ralf Baechle2005-03-01 @445
__typeof__(*(ptr)) __pu_val = (x); \
8d2d91e8 include/asm-mips/uaccess.h Ralf Baechle2008-10-11 446
int __pu_err = -EFAULT; \
^1da177e include/asm-mips/uaccess.h Linus Torvalds 2005-04-16 447
\
ef41f460 arch/mips/include/asm/uaccess.h Ralf Baechle2009-04-28 448
might_fault(); \
ac1d8590 arch/mips/include/asm/uaccess.h Markos Chandras 2013-12-11 449
if (likely(access_ok(VERIFY_WRITE, __pu_addr, size))) {\
12060666 arch/mips/include/asm/uaccess.h Paul Burton 2015-05-24 450
if (eva_kernel_access())\
ac1d8590 arch/mips/include/asm/uaccess.h Markos Chandras 2013-12-11 451
__put_kernel_common(__pu_addr, size); \
ac1d8590 arch/mips/include/asm/uaccess.h Markos Chandras 2013-12-11 452
else\
ec56b1d4 arch/mips/include/asm/uaccess.h Markos Chandras 2013-12-17 453
__put_user_common(__pu_addr, size); \
ac1d8590 arch/mips/include/asm/uaccess.h Markos Chandras 2013-12-11 454
} \
ec56b1d4 arch/mips/include/asm/uaccess.h Markos Chandras 2013-12-17 455
\
^1da177e include/asm-mips/uaccess.h Linus Torvalds 2005-04-16 456
__pu_err; \
^1da177e include/asm-mips/uaccess.h Linus Torvalds 2005-04-16 457 })
^1da177e include/asm-mips/uaccess.h Linus Torvalds 2005-04-16 458
:: The code at line 445 was first introduced by commit
:: fe00f943e0ef98b4057ab
[ragnatech:media-tree 247/250] arch/arm64/include/asm/uaccess.h:403:18: note: in expansion of macro '__put_user'
tree: git://git.ragnatech.se/linux media-tree
head: 343b23a7c6b6680ef949e6112a4ee60688acf39d
commit: f863ce990030cfc5a57a490b4613be4a523ffce1 [247/250] media: dvb: get rid
of VIDEO_SET_SPU_PALETTE
config: arm64-allmodconfig (attached as .config)
compiler: aarch64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout f863ce990030cfc5a57a490b4613be4a523ffce1
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=arm64
All warnings (new ones prefixed by >>):
fs/compat_ioctl.c: In function 'do_video_set_spu_palette':
fs/compat_ioctl.c:218:45: error: invalid application of 'sizeof' to
incomplete type 'struct video_spu_palette'
up_native = compat_alloc_user_space(sizeof(struct video_spu_palette));
^~
In file included from include/linux/uaccess.h:14:0,
from include/linux/compat.h:19,
from fs/compat_ioctl.c:17:
fs/compat_ioctl.c:219:46: error: dereferencing pointer to incomplete type
'struct video_spu_palette'
err = put_user(compat_ptr(palp), &up_native->palette);
^
arch/arm64/include/asm/uaccess.h:380:15: note: in definition of macro
'__put_user_check'
__typeof__(*(ptr)) __user *__p = (ptr);\
^~~
>> arch/arm64/include/asm/uaccess.h:403:18: note: in expansion of macro
>> '__put_user'
#define put_user __put_user
^~
fs/compat_ioctl.c:219:9: note: in expansion of macro 'put_user'
err = put_user(compat_ptr(palp), &up_native->palette);
^~~~
>> arch/arm64/include/asm/uaccess.h:352:32: warning: initialization makes
>> integer from pointer without a cast [-Wint-conversion]
__typeof__(*(ptr)) __pu_val = (x);\
^
>> arch/arm64/include/asm/uaccess.h:384:3: note: in expansion of macro
>> '__put_user_err'
__put_user_err((x), __p, (err)); \
^~
>> arch/arm64/include/asm/uaccess.h:399:2: note: in expansion of macro
>> '__put_user_check'
__put_user_check((x), (ptr), __pu_err);\
^~~~
>> arch/arm64/include/asm/uaccess.h:403:18: note: in expansion of macro
>> '__put_user'
#define put_user __put_user
^~
fs/compat_ioctl.c:219:9: note: in expansion of macro 'put_user'
err = put_user(compat_ptr(palp), &up_native->palette);
^~~~
At top level:
fs/compat_ioctl.c:206:12: warning: 'do_video_set_spu_palette' defined but
not used [-Wunused-function]
static int do_video_set_spu_palette(struct file *file,
^~~~
vim +/__put_user +403 arch/arm64/include/asm/uaccess.h
84624087 Will Deacon 2018-02-05 335
57f4959b James Morse 2016-02-05 336 #define __put_user_asm(instr,
alt_instr, reg, x, addr, err, feature) \
0aea86a2 Catalin Marinas 2012-03-05 337asm volatile(
\
57f4959b James Morse 2016-02-05 338"1:"ALTERNATIVE(instr " "
reg "1, [%2]\n", \
57f4959b James Morse 2016-02-05 339alt_instr " "
reg "1, [%2]\n", feature) \
0aea86a2 Catalin Marinas 2012-03-05 340"2:\n"
\
0aea86a2 Catalin Marinas 2012-03-05 341" .section
.fixup,\"ax\"\n" \
0aea86a2 Catalin Marinas 2012-03-05 342" .align 2\n"
\
0aea86a2 Catalin Marinas 2012-03-05 343"3: mov %w0, %3\n"
\
0aea86a2 Catalin Marinas 2012-03-05 344" b 2b\n"
\
0aea86a2 Catalin Marinas 2012-03-05 345" .previous\n"
\
6c94f27a Ard Biesheuvel 2016-01-01 346_ASM_EXTABLE(1b, 3b)
\
0aea86a2 Catalin Marinas 2012-03-05 347: "+r" (err)
\
0aea86a2 Catalin Marinas 2012-03-05 348: "r" (x), "r" (addr), "i"
(-EFAULT))
0aea86a2 Catalin Marinas 2012-03-05 349
0aea86a2 Catalin Marinas 2012-03-05 350 #define __put_user_err(x, ptr, err)
\
0aea86a2 Catalin Marinas 2012-03-05 351 do {
\
0aea86a2 Catalin Marinas 2012-03-05 @352__typeof__(*(ptr)) __pu_val =
(x); \
0aea86a2 Catalin Marinas 2012-03-05 353__chk_user_ptr(ptr);
\
bd38967d Catalin Marinas 2016-07-01 354uacc
[linux-next:master 9330/9982] fs/compat_ioctl.c:218:45: error: invalid application of 'sizeof' to incomplete type 'struct video_spu_palette'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: 639d109b21f1413c54ca7042e40a57856e7679bb
commit: f863ce990030cfc5a57a490b4613be4a523ffce1 [9330/9982] media: dvb: get
rid of VIDEO_SET_SPU_PALETTE
config: x86_64-kexec (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
git checkout f863ce990030cfc5a57a490b4613be4a523ffce1
# save the attached .config to linux build tree
make ARCH=x86_64
Note: the linux-next/master HEAD 639d109b21f1413c54ca7042e40a57856e7679bb
builds fine.
It may have been fixed somewhere.
All errors (new ones prefixed by >>):
fs/compat_ioctl.c: In function 'do_video_set_spu_palette':
>> fs/compat_ioctl.c:218:45: error: invalid application of 'sizeof' to
>> incomplete type 'struct video_spu_palette'
up_native = compat_alloc_user_space(sizeof(struct video_spu_palette));
^~
In file included from include/linux/uaccess.h:14:0,
from include/linux/compat.h:19,
from fs/compat_ioctl.c:17:
>> fs/compat_ioctl.c:219:46: error: dereferencing pointer to incomplete type
>> 'struct video_spu_palette'
err = put_user(compat_ptr(palp), &up_native->palette);
^
arch/x86/include/asm/uaccess.h:257:15: note: in definition of macro
'put_user'
__typeof__(*(ptr)) __pu_val;\
^~~
arch/x86/include/asm/uaccess.h:260:11: warning: assignment makes integer
from pointer without a cast [-Wint-conversion]
__pu_val = x; \
^
fs/compat_ioctl.c:219:9: note: in expansion of macro 'put_user'
err = put_user(compat_ptr(palp), &up_native->palette);
^~~~
At top level:
fs/compat_ioctl.c:206:12: warning: 'do_video_set_spu_palette' defined but
not used [-Wunused-function]
static int do_video_set_spu_palette(struct file *file,
^~~~
vim +218 fs/compat_ioctl.c
6e87abd0 David S. Miller 2005-11-16 205
66cf191f Al Viro 2016-01-07 206 static int
do_video_set_spu_palette(struct file *file,
b4341721 Jann Horn 2016-01-05 207unsigned int cmd,
struct compat_video_spu_palette __user *up)
6e87abd0 David S. Miller 2005-11-16 208 {
6e87abd0 David S. Miller 2005-11-16 209struct video_spu_palette __user
*up_native;
6e87abd0 David S. Miller 2005-11-16 210compat_uptr_t palp;
6e87abd0 David S. Miller 2005-11-16 211int length, err;
6e87abd0 David S. Miller 2005-11-16 212
6e87abd0 David S. Miller 2005-11-16 213err = get_user(palp,
&up->palette);
6e87abd0 David S. Miller 2005-11-16 214err |= get_user(length,
&up->length);
12176503 Kees Cook 2012-10-25 215if (err)
12176503 Kees Cook 2012-10-25 216return -EFAULT;
6e87abd0 David S. Miller 2005-11-16 217
6e87abd0 David S. Miller 2005-11-16 @218up_native =
compat_alloc_user_space(sizeof(struct video_spu_palette));
7116e994 Heiko Carstens 2006-12-06 @219err =
put_user(compat_ptr(palp), &up_native->palette);
7116e994 Heiko Carstens 2006-12-06 220err |= put_user(length,
&up_native->length);
7116e994 Heiko Carstens 2006-12-06 221if (err)
7116e994 Heiko Carstens 2006-12-06 222return -EFAULT;
6e87abd0 David S. Miller 2005-11-16 223
66cf191f Al Viro 2016-01-07 224err = do_ioctl(file, cmd,
(unsigned long) up_native);
6e87abd0 David S. Miller 2005-11-16 225
6e87abd0 David S. Miller 2005-11-16 226return err;
6e87abd0 David S. Miller 2005-11-16 227 }
6e87abd0 David S. Miller 2005-11-16 228
:: The code at line 218 was first introduced by commit
:: 6e87abd0b8cbb23ed9ffe5cc9f790fb5cac45eae [DVB]: Add compat ioctl
handling.
:: TO: David S. Miller
:: CC: David S. Miller
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
[ragnatech:media-tree] BUILD SUCCESS 4070fc9ade52f7d0ad1397fe74f564ae95e68a4f
tree/branch: git://git.ragnatech.se/linux media-tree branch HEAD: 4070fc9ade52f7d0ad1397fe74f564ae95e68a4f media: rcar-csi2: update stream start for V3M elapsed time: 160m configs tested: 195 The following configs have been built successfully. More configs may be tested in the coming days. alpha defconfig pariscallnoconfig parisc b180_defconfig pariscc3000_defconfig parisc defconfig powerpc mpc834x_itx_defconfig sh sh7770_generic_defconfig arm pcm027_defconfig sh polaris_defconfig armmulti_v7_defconfig sh landisk_defconfig x86_64 randconfig-a0-07272220 x86_64 randconfig-a0-07272321 i386 tinyconfig powerpc tqm8555_defconfig sh magicpanelr2_defconfig armtrizeps4_defconfig m68k sun3_defconfig shallnoconfig sh rsk7269_defconfig sh sh7785lcr_32bit_defconfig shtitan_defconfig powerpc pq2fads_defconfig sh se7705_defconfig mips ip27_defconfig powerpc mpc8540_ads_defconfig i386 randconfig-x012-201829 i386 randconfig-x017-201829 i386 randconfig-x014-201829 i386 randconfig-x016-201829 i386 randconfig-x013-201829 i386 randconfig-x011-201829 i386 randconfig-x018-201829 i386 randconfig-x010-201829 i386 randconfig-x015-201829 i386 randconfig-x019-201829 microblaze mmu_defconfig microblazenommu_defconfig i386 randconfig-n0-201829 x86_64 randconfig-x007-201829 x86_64 randconfig-x003-201829 x86_64 randconfig-x000-201829 x86_64 randconfig-x005-201829 x86_64 randconfig-x004-201829 x86_64 randconfig-x008-201829 x86_64 randconfig-x001-201829 x86_64 randconfig-x009-201829 x86_64 randconfig-x002-201829 x86_64 randconfig-x006-201829 i386 randconfig-i0-201829 i386 randconfig-i1-201829 mips xway_defconfig sh j2_defconfig x86_64allnoconfig arm nuc960_defconfig x86_64 randconfig-v0-07272303 arm allnoconfig arm at91_dt_defconfig arm efm32_defconfig arm exynos_defconfig armmulti_v5_defconfig armshmobile_defconfig arm sunxi_defconfig arm64 allnoconfig arm64 defconfig powerpc mpc834x_mds_defconfig um allyesconfig x86_64 fedora-25 x86_64 kexec x86_64 rhel x86_64 rhel-7.2 powerpc defconfig s390default_defconfig powerpc ppc64_defconfig powerpc allnoconfig x86_64 randconfig-g0-07272246 openriscor1ksim_defconfig um i386_defconfig um x86_64_defconfig c6xevmc6678_defconfig h8300h8300h-sim_defconfig nios2 10m50_defconfig xtensa common_defconfig xtensa iss_defconfig x86_64 randconfig-x018-201829 x86_64 randconfig-x011-201829 x86_64 randconfig-x015-201829 x86_64 randconfig-x019-201829 x86_64 randconfig-x014-201829 x86_64 randconfig-x010-201829 x86_64 randconfig-x013-201829 x86_64 randconfig-x016-201829 x86_64 randconfig-x017-201829 x86_64 randconfig-x012-201829 ia64 alldefconfig ia64 allnoconfig ia64defconfig arm allmodconfig arm arm5 arm arm67 arm imx_v6_v7_defconfig arm ixp4xx_defconfig arm
Re: [PATCH] media: rc: read out of bounds if bpf reports high protocol number
Hi Sean, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.18-rc6 next-20180727] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Sean-Young/media-rc-read-out-of-bounds-if-bpf-reports-high-protocol-number/20180729-035942 base: git://linuxtv.org/media_tree.git master reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> drivers/media/rc/rc-main.c:682:14: sparse: symbol 'repeat_period' was not >> declared. Should it be static? Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
[RFC PATCH] media: rc: repeat_period() can be static
Fixes: f52e85dbaa91 ("media: rc: read out of bounds if bpf reports high
protocol number")
Signed-off-by: kbuild test robot
---
rc-main.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c
index a24850b..ca68e1d 100644
--- a/drivers/media/rc/rc-main.c
+++ b/drivers/media/rc/rc-main.c
@@ -679,7 +679,7 @@ static void ir_timer_repeat(struct timer_list *t)
spin_unlock_irqrestore(&dev->keylock, flags);
}
-unsigned int repeat_period(int protocol)
+static unsigned int repeat_period(int protocol)
{
if (protocol >= ARRAY_SIZE(protocols))
return 100;
[RFC PATCH ragnatech] media: tvp5150: tvp5150_volatile_reg() can be static
Fixes: 07dff5b8c030 ("media: tvp5150: convert register access to regmap")
Signed-off-by: kbuild test robot
---
tvp5150.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
index b3c7b65..2bd9500 100644
--- a/drivers/media/i2c/tvp5150.c
+++ b/drivers/media/i2c/tvp5150.c
@@ -1321,7 +1321,7 @@ static const struct regmap_range
tvp5150_readable_ranges[] = {
},
};
-bool tvp5150_volatile_reg(struct device *dev, unsigned int reg)
+static bool tvp5150_volatile_reg(struct device *dev, unsigned int reg)
{
switch (reg) {
case TVP5150_VERT_LN_COUNT_MSB:
[ragnatech:media-tree 311/324] drivers/media/i2c/tvp5150.c:1324:6: sparse: symbol 'tvp5150_volatile_reg' was not declared. Should it be static?
tree: git://git.ragnatech.se/linux media-tree head: 1d06352e18ef502e30837cedfe618298816fb48c commit: 07dff5b8c03053db6fb6e33fd38c3e5d37f67bc5 [311/324] media: tvp5150: convert register access to regmap reproduce: # apt-get install sparse git checkout 07dff5b8c03053db6fb6e33fd38c3e5d37f67bc5 make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) drivers/media/i2c/tvp5150.c:893:21: sparse: expression using sizeof(void) drivers/media/i2c/tvp5150.c:893:21: sparse: expression using sizeof(void) drivers/media/i2c/tvp5150.c:893:21: sparse: expression using sizeof(void) drivers/media/i2c/tvp5150.c:893:21: sparse: expression using sizeof(void) drivers/media/i2c/tvp5150.c:893:21: sparse: expression using sizeof(void) drivers/media/i2c/tvp5150.c:893:21: sparse: expression using sizeof(void) drivers/media/i2c/tvp5150.c:893:21: sparse: expression using sizeof(void) drivers/media/i2c/tvp5150.c:894:20: sparse: expression using sizeof(void) drivers/media/i2c/tvp5150.c:894:20: sparse: expression using sizeof(void) drivers/media/i2c/tvp5150.c:894:20: sparse: expression using sizeof(void) drivers/media/i2c/tvp5150.c:894:20: sparse: expression using sizeof(void) drivers/media/i2c/tvp5150.c:894:20: sparse: expression using sizeof(void) drivers/media/i2c/tvp5150.c:894:20: sparse: expression using sizeof(void) drivers/media/i2c/tvp5150.c:894:20: sparse: expression using sizeof(void) >> drivers/media/i2c/tvp5150.c:1324:6: sparse: symbol 'tvp5150_volatile_reg' >> was not declared. Should it be static? Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
[ragnatech:media-tree 273/382] drivers/media/i2c/mt9v111.c:801:10: error: implicit declaration of function 'v4l2_subdev_get_try_format'; did you mean 'v4l2_subdev_notify_event'?
tree: git://git.ragnatech.se/linux media-tree
head: 12f336c88090fb8004736fd4329184326a49673b
commit: aab7ed1c392703604fbdc5bd5005dfb61a0b32f9 [273/382] media: i2c: Add
driver for Aptina MT9V111
config: x86_64-randconfig-x010-201831 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
git checkout aab7ed1c392703604fbdc5bd5005dfb61a0b32f9
# save the attached .config to linux build tree
make ARCH=x86_64
All error/warnings (new ones prefixed by >>):
drivers/media/i2c/mt9v111.c: In function '__mt9v111_get_pad_format':
>> drivers/media/i2c/mt9v111.c:801:10: error: implicit declaration of function
>> 'v4l2_subdev_get_try_format'; did you mean 'v4l2_subdev_notify_event'?
>> [-Werror=implicit-function-declaration]
return v4l2_subdev_get_try_format(&mt9v111->sd, cfg, pad);
^~
v4l2_subdev_notify_event
>> drivers/media/i2c/mt9v111.c:801:10: warning: return makes pointer from
>> integer without a cast [-Wint-conversion]
return v4l2_subdev_get_try_format(&mt9v111->sd, cfg, pad);
^~
drivers/media/i2c/mt9v111.c: In function 'mt9v111_set_format':
drivers/media/i2c/mt9v111.c:887:15: warning: 'idx' may be used uninitialized
in this function [-Wmaybe-uninitialized]
unsigned int idx;
^~~
cc1: some warnings being treated as errors
vim +801 drivers/media/i2c/mt9v111.c
791
792 static struct v4l2_mbus_framefmt *__mt9v111_get_pad_format(
793 struct mt9v111_dev *mt9v111,
794 struct v4l2_subdev_pad_config
*cfg,
795 unsigned int pad,
796 enum v4l2_subdev_format_whence
which)
797 {
798 switch (which) {
799 case V4L2_SUBDEV_FORMAT_TRY:
800 #if IS_ENABLED(CONFIG_MEDIA_CONTROLLER)
> 801 return v4l2_subdev_get_try_format(&mt9v111->sd, cfg,
> pad);
802 #else
803 return &cfg->try_fmt;
804 #endif
805 case V4L2_SUBDEV_FORMAT_ACTIVE:
806 return &mt9v111->fmt;
807 default:
808 return NULL;
809 }
810 }
811
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCHv2 5/5] adv7842: enable reduced fps detection
Hi Hans,
I love your patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.18 next-20180815]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Hans-Verkuil/Handling-of-reduced-FPS-in-V4L2/20180816-051924
base: git://linuxtv.org/media_tree.git master
config: i386-randconfig-a0-201832 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
drivers/media/i2c/adv7842.o: In function `adv7842_query_dv_timings':
>> drivers/media/i2c/adv7842.c:1602: undefined reference to `__udivdi3'
vim +1602 drivers/media/i2c/adv7842.c
1530
1531 static int adv7842_query_dv_timings(struct v4l2_subdev *sd,
1532 struct v4l2_dv_timings *timings)
1533 {
1534 struct adv7842_state *state = to_state(sd);
1535 struct v4l2_bt_timings *bt = &timings->bt;
1536 struct stdi_readback stdi = { 0 };
1537
1538 v4l2_dbg(1, debug, sd, "%s:\n", __func__);
1539
1540 memset(timings, 0, sizeof(struct v4l2_dv_timings));
1541
1542 /* SDP block */
1543 if (state->mode == ADV7842_MODE_SDP)
1544 return -ENODATA;
1545
1546 /* read STDI */
1547 if (read_stdi(sd, &stdi)) {
1548 state->restart_stdi_once = true;
1549 v4l2_dbg(1, debug, sd, "%s: no valid signal\n",
__func__);
1550 return -ENOLINK;
1551 }
1552 bt->interlaced = stdi.interlaced ?
1553 V4L2_DV_INTERLACED : V4L2_DV_PROGRESSIVE;
1554 bt->standards = V4L2_DV_BT_STD_CEA861 | V4L2_DV_BT_STD_DMT |
1555 V4L2_DV_BT_STD_GTF | V4L2_DV_BT_STD_CVT;
1556
1557 if (is_digital_input(sd)) {
1558 u32 freq;
1559
1560 timings->type = V4L2_DV_BT_656_1120;
1561
1562 bt->width = (hdmi_read(sd, 0x07) & 0x0f) * 256 +
hdmi_read(sd, 0x08);
1563 bt->height = (hdmi_read(sd, 0x09) & 0x0f) * 256 +
hdmi_read(sd, 0x0a);
1564 freq = ((hdmi_read(sd, 0x51) << 1) + (hdmi_read(sd,
0x52) >> 7)) * 100;
1565 freq += ((hdmi_read(sd, 0x52) & 0x7f) * 7813);
1566 if (is_hdmi(sd)) {
1567 /* adjust for deep color mode */
1568 freq = freq * 8 / (((hdmi_read(sd, 0x0b) &
0xc0) >> 6) * 2 + 8);
1569 }
1570 bt->pixelclock = freq;
1571 bt->hfrontporch = (hdmi_read(sd, 0x20) & 0x03) * 256 +
1572 hdmi_read(sd, 0x21);
1573 bt->hsync = (hdmi_read(sd, 0x22) & 0x03) * 256 +
1574 hdmi_read(sd, 0x23);
1575 bt->hbackporch = (hdmi_read(sd, 0x24) & 0x03) * 256 +
1576 hdmi_read(sd, 0x25);
1577 bt->vfrontporch = ((hdmi_read(sd, 0x2a) & 0x1f) * 256 +
1578 hdmi_read(sd, 0x2b)) / 2;
1579 bt->vsync = ((hdmi_read(sd, 0x2e) & 0x1f) * 256 +
1580 hdmi_read(sd, 0x2f)) / 2;
1581 bt->vbackporch = ((hdmi_read(sd, 0x32) & 0x1f) * 256 +
1582 hdmi_read(sd, 0x33)) / 2;
1583 bt->polarities = ((hdmi_read(sd, 0x05) & 0x10) ?
V4L2_DV_VSYNC_POS_POL : 0) |
1584 ((hdmi_read(sd, 0x05) & 0x20) ?
V4L2_DV_HSYNC_POS_POL : 0);
1585 if (bt->interlaced == V4L2_DV_INTERLACED) {
1586 bt->height += (hdmi_read(sd, 0x0b) & 0x0f) *
256 +
1587 hdmi_read(sd, 0x0c);
1588 bt->il_vfrontporch = ((hdmi_read(sd, 0x2c) &
0x1f) * 256 +
1589 hdmi_read(sd, 0x2d)) / 2;
1590 bt->il_vsync = ((hdmi_read(sd, 0x30) & 0x1f) *
256 +
1591 hdmi_read(sd, 0x31)) / 2;
1592 bt->il_vbackporch = ((hdmi_read(sd, 0x34) &
0x1f) * 256 +
1593 hdmi_read(sd, 0x35)) / 2;
1594 } else {
1595 bt->il_vfrontporch = 0;
1596 bt->il_vsync = 0;
1597 bt->il_vbackporch = 0;
1598 }
1599 adv7842_fill_optional_dv_timings_fields(sd, timings);
1600 if ((timings->bt.flags & V4L2_DV_FL_CAN_REDUCE_FPS) &&
1601 freq < bt->pixelclock) {
> 1602 u32 reduced_freq = (bt->pixelclock /
Re: [PATCH v2 02/14] media: v4l2: taint pads with the signal types for consumer devices
Hi Mauro, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.19-rc4 next-20180913] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/Better-handle-pads-for-tuning-decoder-part-of-the-devices/20180916-233739 base: git://linuxtv.org/media_tree.git master reproduce: make htmldocs All warnings (new ones prefixed by >>): include/net/mac80211.h:977: warning: Function parameter or member 'status.ampdu_len' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.antenna' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.tx_time' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.is_valid_ack_signal' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.status_driver_data' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'driver_rates' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'pad' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'rate_driver_data' not described in 'ieee80211_tx_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'rx_stats_avg' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'rx_stats_avg.signal' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'rx_stats_avg.chain_signal' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.filtered' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.retry_failed' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.retry_count' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.lost_packets' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.last_tdls_pkt_time' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.msdu_retries' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.msdu_failed' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.last_ack' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.last_ack_signal' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.ack_signal_filled' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.avg_ack_signal' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'tx_stats.packets' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'tx_stats.bytes' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'tx_stats.last_rate' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'tx_stats.msdu' not described in 'sta_info' include/linux/mod_devicetable.h:763: warning: Function parameter or member 'driver_data' not described in 'typec_device_id' kernel/sched/fair.c:3371: warning: Function parameter or member 'flags' not described in 'attach_entity_load_avg' arch/x86/include/asm/atomic.h:84: warning: Excess function parameter 'i' description in 'arch_atomic_sub_and_test' arch/x86/include/asm/atomic.h:84: warning: Excess function parameter 'v' description in 'arch_atomic_sub_and_test' arch/x86/include/asm/atomic.h:96: warning: Excess function parameter 'v' description in 'arch_atomic_inc' arch/x86/include/asm/atomic.h:109: warning: Excess function parameter 'v' description in 'arch_atomic_dec' arch/x86/include/asm/atomic.h:124: warning: Excess function parameter 'v' description in 'arch_atomic_dec_and_test' arch/x86/include/asm/atomic.h:138: warning: Excess function parameter 'v' description in 'arch_atomic_inc_and_test' arch/x86/include/asm/atomic.h:153: warning: Excess function parameter 'i' description in 'arch_atomic_add_negative' arch/x86/include/asm/atomic.h:153: warning: Excess function parameter 'v' description in 'arch_atomic_add_negative' include/linux/dma-buf.h:304: warning: Functio
Re: [PATCH v5] media: add imx319 camera sensor driver
Hi Bingbu,
I love your patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.19-rc4 next-20180913]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/bingbu-cao-intel-com/media-add-imx319-camera-sensor-driver/20180917-135744
base: git://linuxtv.org/media_tree.git master
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
drivers/media/i2c/imx319.c: In function 'imx319_set_stream':
>> drivers/media/i2c/imx319.c:2146:2: error: implicit declaration of function
>> '__v4l2_ctrl_grab'; did you mean 'v4l2_ctrl_grab'?
>> [-Werror=implicit-function-declaration]
__v4l2_ctrl_grab(imx319->vflip, enable);
^~~~
v4l2_ctrl_grab
cc1: some warnings being treated as errors
vim +2146 drivers/media/i2c/imx319.c
2111
2112 static int imx319_set_stream(struct v4l2_subdev *sd, int enable)
2113 {
2114 struct imx319 *imx319 = to_imx319(sd);
2115 struct i2c_client *client = v4l2_get_subdevdata(sd);
2116 int ret = 0;
2117
2118 mutex_lock(&imx319->mutex);
2119 if (imx319->streaming == enable) {
2120 mutex_unlock(&imx319->mutex);
2121 return 0;
2122 }
2123
2124 if (enable) {
2125 ret = pm_runtime_get_sync(&client->dev);
2126 if (ret < 0) {
2127 pm_runtime_put_noidle(&client->dev);
2128 goto err_unlock;
2129 }
2130
2131 /*
2132 * Apply default & customized values
2133 * and then start streaming.
2134 */
2135 ret = imx319_start_streaming(imx319);
2136 if (ret)
2137 goto err_rpm_put;
2138 } else {
2139 imx319_stop_streaming(imx319);
2140 pm_runtime_put(&client->dev);
2141 }
2142
2143 imx319->streaming = enable;
2144
2145 /* vflip and hflip cannot change during streaming */
> 2146 __v4l2_ctrl_grab(imx319->vflip, enable);
2147 __v4l2_ctrl_grab(imx319->hflip, enable);
2148
2149 mutex_unlock(&imx319->mutex);
2150
2151 return ret;
2152
2153 err_rpm_put:
2154 pm_runtime_put(&client->dev);
2155 err_unlock:
2156 mutex_unlock(&imx319->mutex);
2157
2158 return ret;
2159 }
2160
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH 1/1] v4l: samsung, ov9650: Rely on V4L2-set sub-device names
Hi Sakari,
I love your patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on next-20180913]
[cannot apply to v4.19-rc4]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Sakari-Ailus/v4l-samsung-ov9650-Rely-on-V4L2-set-sub-device-names/20180916-232558
base: git://linuxtv.org/media_tree.git master
config: i386-randconfig-x0-09171846 (attached as .config)
compiler: gcc-5 (Debian 5.5.0-3) 5.4.1 20171010
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
drivers/media/i2c/s5c73m3/s5c73m3-core.c: In function 's5c73m3_probe':
>> drivers/media/i2c/s5c73m3/s5c73m3-core.c:1686:2: error: implicit declaration
>> of function 'v4l2_i2c_subdev_set_name'
>> [-Werror=implicit-function-declaration]
v4l2_i2c_subdev_set_name(sd, client, NULL, NULL);
^
cc1: some warnings being treated as errors
vim +/v4l2_i2c_subdev_set_name +1686 drivers/media/i2c/s5c73m3/s5c73m3-core.c
1660
1661 static int s5c73m3_probe(struct i2c_client *client,
1662 const struct i2c_device_id *id)
1663 {
1664 struct device *dev = &client->dev;
1665 struct v4l2_subdev *sd;
1666 struct v4l2_subdev *oif_sd;
1667 struct s5c73m3 *state;
1668 int ret, i;
1669
1670 state = devm_kzalloc(dev, sizeof(*state), GFP_KERNEL);
1671 if (!state)
1672 return -ENOMEM;
1673
1674 state->i2c_client = client;
1675 ret = s5c73m3_get_platform_data(state);
1676 if (ret < 0)
1677 return ret;
1678
1679 mutex_init(&state->lock);
1680 sd = &state->sensor_sd;
1681 oif_sd = &state->oif_sd;
1682
1683 v4l2_subdev_init(sd, &s5c73m3_subdev_ops);
1684 sd->owner = client->dev.driver->owner;
1685 v4l2_set_subdevdata(sd, state);
> 1686 v4l2_i2c_subdev_set_name(sd, client, NULL, NULL);
1687
1688 sd->internal_ops = &s5c73m3_internal_ops;
1689 sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
1690
1691 state->sensor_pads[S5C73M3_JPEG_PAD].flags =
MEDIA_PAD_FL_SOURCE;
1692 state->sensor_pads[S5C73M3_ISP_PAD].flags = MEDIA_PAD_FL_SOURCE;
1693 sd->entity.function = MEDIA_ENT_F_CAM_SENSOR;
1694
1695 ret = media_entity_pads_init(&sd->entity, S5C73M3_NUM_PADS,
1696
state->sensor_pads);
1697 if (ret < 0)
1698 return ret;
1699
1700 v4l2_i2c_subdev_init(oif_sd, client, &oif_subdev_ops);
1701 v4l2_i2c_subdev_set_name(sd, client, NULL, "-oif");
1702
1703 oif_sd->internal_ops = &oif_internal_ops;
1704 oif_sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
1705
1706 state->oif_pads[OIF_ISP_PAD].flags = MEDIA_PAD_FL_SINK;
1707 state->oif_pads[OIF_JPEG_PAD].flags = MEDIA_PAD_FL_SINK;
1708 state->oif_pads[OIF_SOURCE_PAD].flags = MEDIA_PAD_FL_SOURCE;
1709 oif_sd->entity.function = MEDIA_ENT_F_PROC_VIDEO_SCALER;
1710
1711 ret = media_entity_pads_init(&oif_sd->entity, OIF_NUM_PADS,
1712
state->oif_pads);
1713 if (ret < 0)
1714 return ret;
1715
1716 ret = s5c73m3_configure_gpios(state);
1717 if (ret)
1718 goto out_err;
1719
1720 for (i = 0; i < S5C73M3_MAX_SUPPLIES; i++)
1721 state->supplies[i].supply = s5c73m3_supply_names[i];
1722
1723 ret = devm_regulator_bulk_get(dev, S5C73M3_MAX_SUPPLIES,
1724 state->supplies);
1725 if (ret) {
1726 dev_err(dev, "failed to get regulators\n");
1727 goto out_err;
1728 }
1729
1730 ret = s5c73m3_init_controls(state);
1731 if (ret)
1732 goto out_err;
1733
1734 state->sensor_pix_size[RES_ISP] = &s5c73m3_isp_resolutions[1];
1735 state->sensor_pix_size[RES_JPEG] = &s5c73m3_jpeg_resolutions[1];
1736 state->oif_pix_size[RES_ISP] = state->sensor_pix_size[RES_ISP];
1737 state->oif_pix_size[RES_JPEG] =
state->sensor_pix_size[RES_JPEG];
1738
1739 state->mbus_code = S5C73M3_ISP_FMT;
1740
1741 state->fiv = &s5c73m3_intervals[S5C73M3_DEFAULT_FRAME_INTERVAL];
1742
1743 state->fw_file_version[0] = 'G';
1744 state->fw_file_version[1] = 'C';
1745
1746 ret = s5c73m3_register_spi_driver(state);
1747 if (ret < 0)
1748 goto out_err;
1749
1750
[experimental:tvp5150-5 131/138] drivers/media/i2c/tvp5150.c:71:32: error: 'TVP5150_NUM_PADS' undeclared here (not in a function)
tree: git://linuxtv.org/mchehab/experimental tvp5150-5
head: c223c451df23ac71a844d05aab65ede057b70eb0
commit: 71c04fa3b90605e64a5bf2ea9b686c2d64f0066b [131/138] tvp5150: add input
source selection of_graph support
config: i386-randconfig-s0-09171149 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
git checkout 71c04fa3b90605e64a5bf2ea9b686c2d64f0066b
# save the attached .config to linux build tree
make ARCH=i386
All error/warnings (new ones prefixed by >>):
>> drivers/media/i2c/tvp5150.c:71:32: error: 'TVP5150_NUM_PADS' undeclared here
>> (not in a function)
struct device_node *endpoints[TVP5150_NUM_PADS + 1];
^~~~
drivers/media/i2c/tvp5150.c: In function 'tvp5150_fill_fmt':
>> drivers/media/i2c/tvp5150.c:1017:33: error: 'TVP5150_PAD_VID_OUT' undeclared
>> (first use in this function)
if (!format || (format->pad != TVP5150_PAD_VID_OUT))
^~~
drivers/media/i2c/tvp5150.c:1017:33: note: each undeclared identifier is
reported only once for each function it appears in
drivers/media/i2c/tvp5150.c: In function 'tvp5150_mc_init':
>> drivers/media/i2c/tvp5150.c:1840:9: error: 'ret' undeclared (first use in
>> this function)
return ret;
^~~
drivers/media/i2c/tvp5150.c:1839:1: warning: label 'out' defined but not
used [-Wunused-label]
out:
^~~
drivers/media/i2c/tvp5150.c: In function 'tvp5150_of_valid_input':
>> drivers/media/i2c/tvp5150.c:1852:7: error: 'TVP5150_PAD_AIP1A' undeclared
>> (first use in this function)
case TVP5150_PAD_AIP1A:
^
>> drivers/media/i2c/tvp5150.c:1860:7: error: 'TVP5150_PAD_AIP1B' undeclared
>> (first use in this function)
case TVP5150_PAD_AIP1B:
^
drivers/media/i2c/tvp5150.c: In function 'tvp5150_parse_dt':
drivers/media/i2c/tvp5150.c:1904:8: error: 'TVP5150_PAD_AIP1A' undeclared
(first use in this function)
case TVP5150_PAD_AIP1A:
^
drivers/media/i2c/tvp5150.c:1905:8: error: 'TVP5150_PAD_AIP1B' undeclared
(first use in this function)
case TVP5150_PAD_AIP1B:
^
drivers/media/i2c/tvp5150.c:1915:8: error: 'TVP5150_PAD_VID_OUT' undeclared
(first use in this function)
case TVP5150_PAD_VID_OUT:
^~~
>> drivers/media/i2c/tvp5150.c:1947:9: error: 'struct tvp5150' has no member
>> named 'connectors_num'
decoder->connectors_num = in;
^~
drivers/media/i2c/tvp5150.c: In function 'tvp5150_mc_init':
>> drivers/media/i2c/tvp5150.c:1841:1: warning: control reaches end of non-void
>> function [-Wreturn-type]
}
^
vim +/TVP5150_NUM_PADS +71 drivers/media/i2c/tvp5150.c
67
68 struct tvp5150 {
69 struct v4l2_subdev sd;
70 /* additional additional endpoint for the svideo connector */
> 71 struct device_node *endpoints[TVP5150_NUM_PADS + 1];
72 unsigned int endpoints_num;
73 #if defined(CONFIG_MEDIA_CONTROLLER)
74 struct media_pad pads[TVP5150_NUM_PADS];
75 int pads_state[TVP5150_NUM_PADS];
76 struct tvp5150_connector *connectors;
77 int connectors_num;
78 bool modify_second_link;
79 #endif
80 struct v4l2_ctrl_handler hdl;
81 struct v4l2_rect rect;
82 struct regmap *regmap;
83 int irq;
84
85 v4l2_std_id norm; /* Current set standard */
86 v4l2_std_id detected_norm;
87 u32 input;
88 u32 output;
89 u32 oe;
90 int enable;
91 bool lock;
92
93 u16 dev_id;
94 u16 rom_ver;
95
96 enum v4l2_mbus_type mbus_type;
97 };
98
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
[experimental:tvp5150-5 135/138] drivers/media/i2c/tvp5150.c:1018:10: error: implicit declaration of function 'v4l2_subdev_get_try_crop'
tree: git://linuxtv.org/mchehab/experimental tvp5150-5
head: c223c451df23ac71a844d05aab65ede057b70eb0
commit: bc93ce496fa909d8fa9496c93d36e9ea413a9065 [135/138] tvp5150: add
FORMAT_TRY support for get/set selection handlers
config: i386-randconfig-s0-09171149 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
git checkout bc93ce496fa909d8fa9496c93d36e9ea413a9065
# save the attached .config to linux build tree
make ARCH=i386
All error/warnings (new ones prefixed by >>):
drivers/media/i2c/tvp5150.c:72:32: error: 'TVP5150_NUM_PADS' undeclared here
(not in a function)
struct device_node *endpoints[TVP5150_NUM_PADS + 1];
^~~~
drivers/media/i2c/tvp5150.c: In function '__tvp5150_get_pad_crop':
>> drivers/media/i2c/tvp5150.c:1018:10: error: implicit declaration of function
>> 'v4l2_subdev_get_try_crop' [-Werror=implicit-function-declaration]
return v4l2_subdev_get_try_crop(&decoder->sd, cfg, pad);
^~~~
>> drivers/media/i2c/tvp5150.c:1018:10: warning: return makes pointer from
>> integer without a cast [-Wint-conversion]
return v4l2_subdev_get_try_crop(&decoder->sd, cfg, pad);
^~~~
drivers/media/i2c/tvp5150.c: In function 'tvp5150_fill_fmt':
drivers/media/i2c/tvp5150.c:1034:33: error: 'TVP5150_PAD_VID_OUT' undeclared
(first use in this function)
if (!format || (format->pad != TVP5150_PAD_VID_OUT))
^~~
drivers/media/i2c/tvp5150.c:1034:33: note: each undeclared identifier is
reported only once for each function it appears in
drivers/media/i2c/tvp5150.c: In function 'tvp5150_mc_init':
drivers/media/i2c/tvp5150.c:1881:9: error: 'ret' undeclared (first use in
this function)
return ret;
^~~
drivers/media/i2c/tvp5150.c:1880:1: warning: label 'out' defined but not
used [-Wunused-label]
out:
^~~
drivers/media/i2c/tvp5150.c: In function 'tvp5150_of_valid_input':
drivers/media/i2c/tvp5150.c:1893:7: error: 'TVP5150_PAD_AIP1A' undeclared
(first use in this function)
case TVP5150_PAD_AIP1A:
^
drivers/media/i2c/tvp5150.c:1901:7: error: 'TVP5150_PAD_AIP1B' undeclared
(first use in this function)
case TVP5150_PAD_AIP1B:
^
drivers/media/i2c/tvp5150.c: In function 'tvp5150_parse_dt':
drivers/media/i2c/tvp5150.c:1945:8: error: 'TVP5150_PAD_AIP1A' undeclared
(first use in this function)
case TVP5150_PAD_AIP1A:
^
drivers/media/i2c/tvp5150.c:1946:8: error: 'TVP5150_PAD_AIP1B' undeclared
(first use in this function)
case TVP5150_PAD_AIP1B:
^
drivers/media/i2c/tvp5150.c:1956:8: error: 'TVP5150_PAD_VID_OUT' undeclared
(first use in this function)
case TVP5150_PAD_VID_OUT:
^~~
drivers/media/i2c/tvp5150.c:1988:9: error: 'struct tvp5150' has no member
named 'connectors_num'
decoder->connectors_num = in;
^~
drivers/media/i2c/tvp5150.c: In function 'tvp5150_mc_init':
drivers/media/i2c/tvp5150.c:1882:1: warning: control reaches end of non-void
function [-Wreturn-type]
}
^
cc1: some warnings being treated as errors
vim +/v4l2_subdev_get_try_crop +1018 drivers/media/i2c/tvp5150.c
1010
1011 static struct v4l2_rect *
1012 __tvp5150_get_pad_crop(struct tvp5150 *decoder,
1013 struct v4l2_subdev_pad_config *cfg, unsigned int
pad,
1014 enum v4l2_subdev_format_whence which)
1015 {
1016 switch (which) {
1017 case V4L2_SUBDEV_FORMAT_TRY:
> 1018 return v4l2_subdev_get_try_crop(&decoder->sd, cfg, pad);
1019 case V4L2_SUBDEV_FORMAT_ACTIVE:
1020 return &decoder->rect;
1021 default:
1022 return NULL;
1023 }
1024 }
1025
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
[experimental:tvp5150-5 131/138] drivers/media//i2c/tvp5150.c:71:32: error: 'TVP5150_NUM_PADS' undeclared here (not in a function); did you mean 'TVP5150_H_MAX'?
tree: git://linuxtv.org/mchehab/experimental tvp5150-5
head: c223c451df23ac71a844d05aab65ede057b70eb0
commit: 71c04fa3b90605e64a5bf2ea9b686c2d64f0066b [131/138] tvp5150: add input
source selection of_graph support
config: x86_64-randconfig-s5-09181631 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
git checkout 71c04fa3b90605e64a5bf2ea9b686c2d64f0066b
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
>> drivers/media//i2c/tvp5150.c:71:32: error: 'TVP5150_NUM_PADS' undeclared
>> here (not in a function); did you mean 'TVP5150_H_MAX'?
struct device_node *endpoints[TVP5150_NUM_PADS + 1];
^~~~
TVP5150_H_MAX
drivers/media//i2c/tvp5150.c: In function 'tvp5150_fill_fmt':
>> drivers/media//i2c/tvp5150.c:1017:33: error: 'TVP5150_PAD_VID_OUT'
>> undeclared (first use in this function); did you mean 'TVP5150_SVIDEO'?
if (!format || (format->pad != TVP5150_PAD_VID_OUT))
^~~
TVP5150_SVIDEO
drivers/media//i2c/tvp5150.c:1017:33: note: each undeclared identifier is
reported only once for each function it appears in
drivers/media//i2c/tvp5150.c: In function 'tvp5150_mc_init':
>> drivers/media//i2c/tvp5150.c:1840:9: error: 'ret' undeclared (first use in
>> this function); did you mean 'net'?
return ret;
^~~
net
drivers/media//i2c/tvp5150.c:1839:1: warning: label 'out' defined but not
used [-Wunused-label]
out:
^~~
drivers/media//i2c/tvp5150.c: In function 'tvp5150_of_valid_input':
>> drivers/media//i2c/tvp5150.c:1852:7: error: 'TVP5150_PAD_AIP1A' undeclared
>> (first use in this function); did you mean 'TVP5150_VDPOE'?
case TVP5150_PAD_AIP1A:
^
TVP5150_VDPOE
>> drivers/media//i2c/tvp5150.c:1860:7: error: 'TVP5150_PAD_AIP1B' undeclared
>> (first use in this function); did you mean 'TVP5150_PAD_AIP1A'?
case TVP5150_PAD_AIP1B:
^
TVP5150_PAD_AIP1A
drivers/media//i2c/tvp5150.c: In function 'tvp5150_parse_dt':
drivers/media//i2c/tvp5150.c:1904:8: error: 'TVP5150_PAD_AIP1A' undeclared
(first use in this function); did you mean 'TVP5150_VDPOE'?
case TVP5150_PAD_AIP1A:
^
TVP5150_VDPOE
drivers/media//i2c/tvp5150.c:1905:8: error: 'TVP5150_PAD_AIP1B' undeclared
(first use in this function); did you mean 'TVP5150_PAD_AIP1A'?
case TVP5150_PAD_AIP1B:
^
TVP5150_PAD_AIP1A
>> drivers/media//i2c/tvp5150.c:1915:8: error: 'TVP5150_PAD_VID_OUT' undeclared
>> (first use in this function); did you mean 'TVP5150_PAD_AIP1B'?
case TVP5150_PAD_VID_OUT:
^~~
TVP5150_PAD_AIP1B
drivers/media//i2c/tvp5150.c:1947:9: error: 'struct tvp5150' has no member
named 'connectors_num'
decoder->connectors_num = in;
^~
drivers/media//i2c/tvp5150.c: In function 'tvp5150_mc_init':
drivers/media//i2c/tvp5150.c:1841:1: warning: control reaches end of
non-void function [-Wreturn-type]
}
^
vim +71 drivers/media//i2c/tvp5150.c
67
68 struct tvp5150 {
69 struct v4l2_subdev sd;
70 /* additional additional endpoint for the svideo connector */
> 71 struct device_node *endpoints[TVP5150_NUM_PADS + 1];
72 unsigned int endpoints_num;
73 #if defined(CONFIG_MEDIA_CONTROLLER)
74 struct media_pad pads[TVP5150_NUM_PADS];
75 int pads_state[TVP5150_NUM_PADS];
76 struct tvp5150_connector *connectors;
77 int connectors_num;
78 bool modify_second_link;
79 #endif
80 struct v4l2_ctrl_handler hdl;
81 struct v4l2_rect rect;
82 struct regmap *regmap;
83 int irq;
84
85 v4l2_std_id norm; /* Current set standard */
86 v4l2_std_id detected_norm;
87 u32 input;
88 u32 output;
89 u32 oe;
90 int enable;
91 bool lock;
92
93 u16 dev_id;
94 u16 rom_ver;
95
96 enum v4l2_mbus_type mbus_type;
97 };
98
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
[experimental:tvp5150-5 135/138] drivers/media/i2c/tvp5150.c:1018:10: error: implicit declaration of function 'v4l2_subdev_get_try_crop'; did you mean 'v4l2_subdev_has_op'?
tree: git://linuxtv.org/mchehab/experimental tvp5150-5
head: c223c451df23ac71a844d05aab65ede057b70eb0
commit: bc93ce496fa909d8fa9496c93d36e9ea413a9065 [135/138] tvp5150: add
FORMAT_TRY support for get/set selection handlers
config: x86_64-randconfig-s5-09181631 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
git checkout bc93ce496fa909d8fa9496c93d36e9ea413a9065
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
drivers/media/i2c/tvp5150.c:72:32: error: 'TVP5150_NUM_PADS' undeclared here
(not in a function); did you mean 'TVP5150_H_MAX'?
struct device_node *endpoints[TVP5150_NUM_PADS + 1];
^~~~
TVP5150_H_MAX
drivers/media/i2c/tvp5150.c: In function '__tvp5150_get_pad_crop':
>> drivers/media/i2c/tvp5150.c:1018:10: error: implicit declaration of function
>> 'v4l2_subdev_get_try_crop'; did you mean 'v4l2_subdev_has_op'?
>> [-Werror=implicit-function-declaration]
return v4l2_subdev_get_try_crop(&decoder->sd, cfg, pad);
^~~~
v4l2_subdev_has_op
drivers/media/i2c/tvp5150.c:1018:10: warning: return makes pointer from
integer without a cast [-Wint-conversion]
return v4l2_subdev_get_try_crop(&decoder->sd, cfg, pad);
^~~~
drivers/media/i2c/tvp5150.c: In function 'tvp5150_fill_fmt':
drivers/media/i2c/tvp5150.c:1034:33: error: 'TVP5150_PAD_VID_OUT' undeclared
(first use in this function); did you mean 'TVP5150_SVIDEO'?
if (!format || (format->pad != TVP5150_PAD_VID_OUT))
^~~
TVP5150_SVIDEO
drivers/media/i2c/tvp5150.c:1034:33: note: each undeclared identifier is
reported only once for each function it appears in
drivers/media/i2c/tvp5150.c: In function 'tvp5150_mc_init':
drivers/media/i2c/tvp5150.c:1881:9: error: 'ret' undeclared (first use in
this function); did you mean 'net'?
return ret;
^~~
net
drivers/media/i2c/tvp5150.c:1880:1: warning: label 'out' defined but not
used [-Wunused-label]
out:
^~~
drivers/media/i2c/tvp5150.c: In function 'tvp5150_of_valid_input':
drivers/media/i2c/tvp5150.c:1893:7: error: 'TVP5150_PAD_AIP1A' undeclared
(first use in this function); did you mean 'TVP5150_VDPOE'?
case TVP5150_PAD_AIP1A:
^
TVP5150_VDPOE
drivers/media/i2c/tvp5150.c:1901:7: error: 'TVP5150_PAD_AIP1B' undeclared
(first use in this function); did you mean 'TVP5150_PAD_AIP1A'?
case TVP5150_PAD_AIP1B:
^
TVP5150_PAD_AIP1A
drivers/media/i2c/tvp5150.c: In function 'tvp5150_parse_dt':
drivers/media/i2c/tvp5150.c:1945:8: error: 'TVP5150_PAD_AIP1A' undeclared
(first use in this function); did you mean 'TVP5150_VDPOE'?
case TVP5150_PAD_AIP1A:
^
TVP5150_VDPOE
drivers/media/i2c/tvp5150.c:1946:8: error: 'TVP5150_PAD_AIP1B' undeclared
(first use in this function); did you mean 'TVP5150_PAD_AIP1A'?
case TVP5150_PAD_AIP1B:
^
TVP5150_PAD_AIP1A
drivers/media/i2c/tvp5150.c:1956:8: error: 'TVP5150_PAD_VID_OUT' undeclared
(first use in this function); did you mean 'TVP5150_PAD_AIP1B'?
case TVP5150_PAD_VID_OUT:
^~~
TVP5150_PAD_AIP1B
drivers/media/i2c/tvp5150.c:1988:9: error: 'struct tvp5150' has no member
named 'connectors_num'
decoder->connectors_num = in;
^~
drivers/media/i2c/tvp5150.c: In function 'tvp5150_mc_init':
drivers/media/i2c/tvp5150.c:1882:1: warning: control reaches end of non-void
function [-Wreturn-type]
}
^
cc1: some warnings being treated as errors
vim +1018 drivers/media/i2c/tvp5150.c
1010
1011 static struct v4l2_rect *
1012 __tvp5150_get_pad_crop(struct tvp5150 *decoder,
1013 struct v4l2_subdev_pad_config *cfg, unsigned int
pad,
1014 enum v4l2_subdev_format_whence which)
1015 {
1016 switch (which) {
1017 case V4L2_SUBDEV_FORMAT_TRY:
> 1018 return v4l2_subdev_get_try_crop(&decoder->sd, cfg, pad);
1019 case V4L2_SUBDEV_FORMAT_ACTIVE:
1020 return &decoder->rect;
1021 default:
1022 return NULL;
1023 }
1024 }
1025
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH v6] media: add imx319 camera sensor driver
Hi Bingbu,
I love your patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.19-rc4 next-20180921]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/bingbu-cao-intel-com/media-add-imx319-camera-sensor-driver/20180922-115504
base: git://linuxtv.org/media_tree.git master
config: openrisc-allmodconfig (attached as .config)
compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental)
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=openrisc
All errors (new ones prefixed by >>):
drivers/media//i2c/imx319.c: In function 'imx319_set_stream':
>> drivers/media//i2c/imx319.c:2153:2: error: implicit declaration of function
>> '__v4l2_ctrl_grab' [-Werror=implicit-function-declaration]
__v4l2_ctrl_grab(imx319->vflip, enable);
^~~~
cc1: some warnings being treated as errors
vim +/__v4l2_ctrl_grab +2153 drivers/media//i2c/imx319.c
2118
2119 static int imx319_set_stream(struct v4l2_subdev *sd, int enable)
2120 {
2121 struct imx319 *imx319 = to_imx319(sd);
2122 struct i2c_client *client = v4l2_get_subdevdata(sd);
2123 int ret = 0;
2124
2125 mutex_lock(&imx319->mutex);
2126 if (imx319->streaming == enable) {
2127 mutex_unlock(&imx319->mutex);
2128 return 0;
2129 }
2130
2131 if (enable) {
2132 ret = pm_runtime_get_sync(&client->dev);
2133 if (ret < 0) {
2134 pm_runtime_put_noidle(&client->dev);
2135 goto err_unlock;
2136 }
2137
2138 /*
2139 * Apply default & customized values
2140 * and then start streaming.
2141 */
2142 ret = imx319_start_streaming(imx319);
2143 if (ret)
2144 goto err_rpm_put;
2145 } else {
2146 imx319_stop_streaming(imx319);
2147 pm_runtime_put(&client->dev);
2148 }
2149
2150 imx319->streaming = enable;
2151
2152 /* vflip and hflip cannot change during streaming */
> 2153 __v4l2_ctrl_grab(imx319->vflip, enable);
2154 __v4l2_ctrl_grab(imx319->hflip, enable);
2155
2156 mutex_unlock(&imx319->mutex);
2157
2158 return ret;
2159
2160 err_rpm_put:
2161 pm_runtime_put(&client->dev);
2162 err_unlock:
2163 mutex_unlock(&imx319->mutex);
2164
2165 return ret;
2166 }
2167
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
[ragnatech:media-tree] BUILD SUCCESS 4158757395b300b6eb308fc20b96d1d231484413
tree/branch: git://git.ragnatech.se/linux media-tree branch HEAD: 4158757395b300b6eb308fc20b96d1d231484413 media: davinci: Fix implicit enum conversion warning elapsed time: 228m configs tested: 87 The following configs have been built successfully. More configs may be tested in the coming days. x86_64 acpi-redef x86_64 allyesdebian x86_64nfsroot i386 randconfig-x010-201838 i386 randconfig-x011-201838 i386 randconfig-x012-201838 i386 randconfig-x013-201838 i386 randconfig-x014-201838 i386 randconfig-x015-201838 i386 randconfig-x016-201838 i386 randconfig-x017-201838 i386 randconfig-x018-201838 i386 randconfig-x019-201838 microblaze mmu_defconfig microblazenommu_defconfig x86_64 randconfig-x000-201838 x86_64 randconfig-x001-201838 x86_64 randconfig-x002-201838 x86_64 randconfig-x003-201838 x86_64 randconfig-x004-201838 x86_64 randconfig-x005-201838 x86_64 randconfig-x006-201838 x86_64 randconfig-x007-201838 x86_64 randconfig-x008-201838 x86_64 randconfig-x009-201838 i386 allmodconfig i386 randconfig-x000-201838 i386 randconfig-x001-201838 i386 randconfig-x002-201838 i386 randconfig-x003-201838 i386 randconfig-x004-201838 i386 randconfig-x005-201838 i386 randconfig-x006-201838 i386 randconfig-x007-201838 i386 randconfig-x008-201838 i386 randconfig-x009-201838 x86_64 randconfig-x010-201838 x86_64 randconfig-x011-201838 x86_64 randconfig-x012-201838 x86_64 randconfig-x013-201838 x86_64 randconfig-x014-201838 x86_64 randconfig-x015-201838 x86_64 randconfig-x016-201838 x86_64 randconfig-x017-201838 x86_64 randconfig-x018-201838 x86_64 randconfig-x019-201838 ia64 alldefconfig ia64 allnoconfig ia64defconfig shallnoconfig sh rsk7269_defconfig sh sh7785lcr_32bit_defconfig shtitan_defconfig openriscor1ksim_defconfig um i386_defconfig um x86_64_defconfig c6xevmc6678_defconfig h8300h8300h-sim_defconfig nios2 10m50_defconfig xtensa common_defconfig xtensa iss_defconfig arm nuc960_defconfig powerpc eiger_defconfig powerpc sbc8548_defconfig sh sh7724_generic_defconfig m68k m5475evb_defconfig m68k multi_defconfig m68k sun3_defconfig i386 randconfig-s0-201838 i386 randconfig-s1-201838 i386 randconfig-s2-201838 i386 randconfig-s3-201838 x86_64 randconfig-s3-09251250 x86_64 randconfig-s4-09251250 x86_64 randconfig-s5-09251250 sparc defconfig sparc64 allnoconfig sparc64 defconfig powerpc ebony_defconfig x86_64 randconfig-h0-09251147 mips 32r2_defconfig mips 64r6el_defconfig mips allnoconfig mips fuloong2e_defconfig mips jz4740 mips malta_kvm_defconfig mips txx9 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
[linuxtv-media:request_api 77/77] ERROR: "sunxi_sram_release" [drivers/staging/media/sunxi/cedrus/sunxi-cedrus.ko] undefined!
tree: git://linuxtv.org/media_tree.git request_api head: 50e761516f2b8c0cdeb31a8c6ca1b4ef98cd13f1 commit: 50e761516f2b8c0cdeb31a8c6ca1b4ef98cd13f1 [77/77] media: platform: Add Cedrus VPU decoder driver config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: git checkout 50e761516f2b8c0cdeb31a8c6ca1b4ef98cd13f1 # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): >> ERROR: "sunxi_sram_release" >> [drivers/staging/media/sunxi/cedrus/sunxi-cedrus.ko] undefined! --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH 4/5] v4l: controls: QUERY_EXT_CTRL support for base, prefix and unit
Hi Sakari, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.19-rc5 next-20180926] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Sakari-Ailus/Add-units-to-controls/20180925-183703 base: git://linuxtv.org/media_tree.git master reproduce: make htmldocs All warnings (new ones prefixed by >>): include/net/mac80211.h:977: warning: Function parameter or member 'status.ampdu_ack_len' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.ampdu_len' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.antenna' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.tx_time' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.is_valid_ack_signal' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.status_driver_data' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'driver_rates' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'pad' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'rate_driver_data' not described in 'ieee80211_tx_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'rx_stats_avg' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'rx_stats_avg.signal' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'rx_stats_avg.chain_signal' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.filtered' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.retry_failed' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.retry_count' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.lost_packets' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.last_tdls_pkt_time' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.msdu_retries' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.msdu_failed' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.last_ack' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.last_ack_signal' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.ack_signal_filled' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.avg_ack_signal' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'tx_stats.packets' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'tx_stats.bytes' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'tx_stats.last_rate' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'tx_stats.msdu' not described in 'sta_info' include/linux/mod_devicetable.h:763: warning: Function parameter or member 'driver_data' not described in 'typec_device_id' kernel/sched/fair.c:3371: warning: Function parameter or member 'flags' not described in 'attach_entity_load_avg' arch/x86/include/asm/atomic.h:84: warning: Excess function parameter 'i' description in 'arch_atomic_sub_and_test' arch/x86/include/asm/atomic.h:84: warning: Excess function parameter 'v' description in 'arch_atomic_sub_and_test' arch/x86/include/asm/atomic.h:96: warning: Excess function parameter 'v' description in 'arch_atomic_inc' arch/x86/include/asm/atomic.h:109: warning: Excess function parameter 'v' description in 'arch_atomic_dec' arch/x86/include/asm/atomic.h:124: warning: Excess function parameter 'v' description in 'arch_atomic_dec_and_test' arch/x86/include/asm/atomic.h:138: warning: Excess function parameter 'v' description in 'arch_atomic_inc_and_test' arch/x86/include/asm/atomic.h:153: warning: Excess function parameter 'i' description in 'arch_atomic_add_negative' arch/x86/include/asm/atomic.h:153: warning: Excess function parameter 'v' desc
[linuxtv-media:request_api 77/77] drivers/staging/media/sunxi/cedrus/cedrus.c:93 cedrus_init_ctrls() error: potential null dereference 'ctx->ctrls'. (kzalloc returns null)
tree: git://linuxtv.org/media_tree.git request_api
head: 50e761516f2b8c0cdeb31a8c6ca1b4ef98cd13f1
commit: 50e761516f2b8c0cdeb31a8c6ca1b4ef98cd13f1 [77/77] media: platform: Add
Cedrus VPU decoder driver
smatch warnings:
drivers/staging/media/sunxi/cedrus/cedrus.c:93 cedrus_init_ctrls() error:
potential null dereference 'ctx->ctrls'. (kzalloc returns null)
vim +93 drivers/staging/media/sunxi/cedrus/cedrus.c
57
58 static int cedrus_init_ctrls(struct cedrus_dev *dev, struct cedrus_ctx
*ctx)
59 {
60 struct v4l2_ctrl_handler *hdl = &ctx->hdl;
61 struct v4l2_ctrl *ctrl;
62 unsigned int ctrl_size;
63 unsigned int i;
64
65 v4l2_ctrl_handler_init(hdl, CEDRUS_CONTROLS_COUNT);
66 if (hdl->error) {
67 v4l2_err(&dev->v4l2_dev,
68 "Failed to initialize control handler\n");
69 return hdl->error;
70 }
71
72 ctrl_size = sizeof(ctrl) * CEDRUS_CONTROLS_COUNT + 1;
73
74 ctx->ctrls = kzalloc(ctrl_size, GFP_KERNEL);
75 memset(ctx->ctrls, 0, ctrl_size);
76
77 for (i = 0; i < CEDRUS_CONTROLS_COUNT; i++) {
78 struct v4l2_ctrl_config cfg = { 0 };
79
80 cfg.elem_size = cedrus_controls[i].elem_size;
81 cfg.id = cedrus_controls[i].id;
82
83 ctrl = v4l2_ctrl_new_custom(hdl, &cfg, NULL);
84 if (hdl->error) {
85 v4l2_err(&dev->v4l2_dev,
86 "Failed to create new custom
control\n");
87
88 v4l2_ctrl_handler_free(hdl);
89 kfree(ctx->ctrls);
90 return hdl->error;
91 }
92
> 93 ctx->ctrls[i] = ctrl;
94 }
95
96 ctx->fh.ctrl_handler = hdl;
97 v4l2_ctrl_handler_setup(hdl);
98
99 return 0;
100 }
101
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[linuxtv-media:request_api 77/78] cedrus_hw.c:undefined reference to `sunxi_sram_release'
tree: git://linuxtv.org/media_tree.git request_api head: e4183d3256e3cd668e899d06af66da5aac3a51af commit: 50e761516f2b8c0cdeb31a8c6ca1b4ef98cd13f1 [77/78] media: platform: Add Cedrus VPU decoder driver config: i386-allyesconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: git checkout 50e761516f2b8c0cdeb31a8c6ca1b4ef98cd13f1 # save the attached .config to linux build tree make ARCH=i386 Note: the linuxtv-media/request_api HEAD e4183d3256e3cd668e899d06af66da5aac3a51af builds fine. It only hurts bisectibility. All errors (new ones prefixed by >>): drivers/staging/media/sunxi/cedrus/cedrus_hw.o: In function `cedrus_hw_remove': >> cedrus_hw.c:(.text+0x39a): undefined reference to `sunxi_sram_release' --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
[ragnatech:media-tree] BUILD SUCCESS 490d84f6d73c12f4204241cff8651eed60aae914
tree/branch: git://git.ragnatech.se/linux media-tree branch HEAD: 490d84f6d73c12f4204241cff8651eed60aae914 media: cec: forgot to cancel delayed work elapsed time: 1093m configs tested: 210 The following configs have been built successfully. More configs may be tested in the coming days. alpha defconfig pariscallnoconfig parisc b180_defconfig pariscc3000_defconfig parisc defconfig m68k apollo_defconfig mips lemote2f_defconfig x86_64 randconfig-a0-10161216 x86_64 acpi-redef x86_64 allyesdebian x86_64nfsroot shtitan_defconfig sh rsk7269_defconfig sh sh7785lcr_32bit_defconfig shallnoconfig i386 randconfig-c0-10161145 arm s3c6400_defconfig mips loongson1c_defconfig i386 randconfig-x019-201841 i386 randconfig-x016-201841 i386 randconfig-x018-201841 i386 randconfig-x014-201841 i386 randconfig-x015-201841 i386 randconfig-x011-201841 i386 randconfig-x012-201841 i386 randconfig-x017-201841 i386 randconfig-x010-201841 i386 randconfig-x013-201841 microblaze mmu_defconfig microblazenommu_defconfig i386 randconfig-n0-201841 i386 randconfig-n1-201841 i386 randconfig-n2-201841 i386 randconfig-n3-201841 x86_64 randconfig-x000-201841 x86_64 randconfig-x005-201841 x86_64 randconfig-x002-201841 x86_64 randconfig-x001-201841 x86_64 randconfig-x008-201841 x86_64 randconfig-x007-201841 x86_64 randconfig-x009-201841 x86_64 randconfig-x003-201841 x86_64 randconfig-x006-201841 x86_64 randconfig-x004-201841 ia64 allnoconfig ia64defconfig ia64 alldefconfig powerpc allnoconfig powerpc defconfig powerpc ppc64_defconfig s390default_defconfig i386 randconfig-i0-201841 i386 randconfig-i1-201841 i386 randconfig-i2-201841 i386 randconfig-i3-201841 arm allnoconfig arm at91_dt_defconfig arm efm32_defconfig arm exynos_defconfig armmulti_v5_defconfig armmulti_v7_defconfig armshmobile_defconfig arm sunxi_defconfig arm64 allnoconfig arm64 defconfig mipsnlm_xlr_defconfig sh se7343_defconfig x86_64 randconfig-g0-10161105 openriscor1ksim_defconfig um i386_defconfig um x86_64_defconfig c6xevmc6678_defconfig h8300h8300h-sim_defconfig nios2 10m50_defconfig xtensa common_defconfig xtensa iss_defconfig i386 allmodconfig i386 randconfig-x002-201841 i386 randconfig-x006-201841 i386 randconfig-x005-201841 i386 randconfig-x000-201841 i386 randconfig-x007-201841 i386 randconfig-x004-201841 i386 randconfig-x001-201841 i386 randconfig-x009-201841 i386 randconfig-x008-201841 i386 randconfig-x003-201841 arm allmodconfig arm arm5 arm arm67 arm imx_v6_v7_defconfig arm ixp4xx_defconfig armmvebu_v7_defconfig arm omap2plus_defconfig armsa1100 arm samsung armsh arm tegra_defconfig arm64alldefconfig arm64allmodconfig x86_64 randconfig-s0-10161132 x86_64 randconfig-s1-10161132 x86_64
Re: [PATCH 4/4] media: mt9m111: allow to setup pixclk polarity
Hi Enrico,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.19-rc8 next-20181019]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Marco-Felsch/media-mt9m111-features/20181020-022716
base: git://linuxtv.org/media_tree.git master
config: x86_64-randconfig-x000-201841 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
drivers/media//i2c/mt9m111.c: In function 'mt9m111_probe':
>> drivers/media//i2c/mt9m111.c:1185:9: error: implicit declaration of function
>> 'mt9m111_probe_of'; did you mean 'mt9m111_probe'?
>> [-Werror=implicit-function-declaration]
ret = mt9m111_probe_of(client, mt9m111);
^~~~
mt9m111_probe
cc1: some warnings being treated as errors
vim +1185 drivers/media//i2c/mt9m111.c
1159
1160 static int mt9m111_probe(struct i2c_client *client,
1161 const struct i2c_device_id *did)
1162 {
1163 struct mt9m111 *mt9m111;
1164 struct i2c_adapter *adapter =
to_i2c_adapter(client->dev.parent);
1165 int ret;
1166
1167 if (!i2c_check_functionality(adapter,
I2C_FUNC_SMBUS_WORD_DATA)) {
1168 dev_warn(&adapter->dev,
1169 "I2C-Adapter doesn't support
I2C_FUNC_SMBUS_WORD\n");
1170 return -EIO;
1171 }
1172
1173 mt9m111 = devm_kzalloc(&client->dev, sizeof(struct mt9m111),
GFP_KERNEL);
1174 if (!mt9m111)
1175 return -ENOMEM;
1176
1177 mt9m111->clk = v4l2_clk_get(&client->dev, "mclk");
1178 if (IS_ERR(mt9m111->clk))
1179 return PTR_ERR(mt9m111->clk);
1180
1181 /* Default HIGHPOWER context */
1182 mt9m111->ctx = &context_b;
1183
1184 if (IS_ENABLED(CONFIG_OF)) {
> 1185 ret = mt9m111_probe_of(client, mt9m111);
1186 if (ret)
1187 return ret;
1188 } else {
1189 /* use default chip hardware values */
1190 mt9m111->pclk_sample = 1;
1191 }
1192
1193 v4l2_i2c_subdev_init(&mt9m111->subdev, client,
&mt9m111_subdev_ops);
1194 mt9m111->subdev.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
1195
1196 v4l2_ctrl_handler_init(&mt9m111->hdl, 5);
1197 v4l2_ctrl_new_std(&mt9m111->hdl, &mt9m111_ctrl_ops,
1198 V4L2_CID_VFLIP, 0, 1, 1, 0);
1199 v4l2_ctrl_new_std(&mt9m111->hdl, &mt9m111_ctrl_ops,
1200 V4L2_CID_HFLIP, 0, 1, 1, 0);
1201 v4l2_ctrl_new_std(&mt9m111->hdl, &mt9m111_ctrl_ops,
1202 V4L2_CID_AUTO_WHITE_BALANCE, 0, 1, 1, 1);
1203 mt9m111->gain = v4l2_ctrl_new_std(&mt9m111->hdl,
&mt9m111_ctrl_ops,
1204 V4L2_CID_GAIN, 0, 63 * 2 * 2, 1, 32);
1205 v4l2_ctrl_new_std_menu(&mt9m111->hdl,
1206 &mt9m111_ctrl_ops, V4L2_CID_EXPOSURE_AUTO, 1, 0,
1207 V4L2_EXPOSURE_AUTO);
1208 v4l2_ctrl_new_std_menu_items(&mt9m111->hdl,
1209 &mt9m111_ctrl_ops, V4L2_CID_TEST_PATTERN,
1210 ARRAY_SIZE(mt9m111_test_pattern_menu) - 1, 0, 0,
1211 mt9m111_test_pattern_menu);
1212 mt9m111->subdev.ctrl_handler = &mt9m111->hdl;
1213 if (mt9m111->hdl.error) {
1214 ret = mt9m111->hdl.error;
1215 goto out_clkput;
1216 }
1217
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH] Input: Add missing event codes for common IR remote buttons
Hi Derek, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on input/next] [also build test WARNING on v4.19 next-20181102] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Derek-Kelly/Input-Add-missing-event-codes-for-common-IR-remote-buttons/20181103-135217 base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next config: powerpc-defconfig (attached as .config) compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=powerpc All warnings (new ones prefixed by >>): In file included from sound/ppc/pmac.h:39:0, from sound/ppc/beep.c:30: >> arch/powerpc/include/asm/dbdma.h:70:0: warning: "KEY_SYSTEM" redefined #define KEY_SYSTEM 0x600 /* system memory-mapped space */ In file included from include/uapi/linux/input.h:20:0, from include/linux/input.h:13, from sound/ppc/beep.c:25: include/uapi/linux/input-event-codes.h:698:0: note: this is the location of the previous definition #define KEY_SYSTEM 0x2ed /* Open systems menu/display */ vim +/KEY_SYSTEM +70 arch/powerpc/include/asm/dbdma.h ^1da177e include/asm-ppc/dbdma.h Linus Torvalds 2005-04-16 63 ^1da177e include/asm-ppc/dbdma.h Linus Torvalds 2005-04-16 64 /* Key values in command field */ ^1da177e include/asm-ppc/dbdma.h Linus Torvalds 2005-04-16 65 #define KEY_STREAM0 0 /* usual data stream */ ^1da177e include/asm-ppc/dbdma.h Linus Torvalds 2005-04-16 66 #define KEY_STREAM1 0x100 /* control/status stream */ ^1da177e include/asm-ppc/dbdma.h Linus Torvalds 2005-04-16 67 #define KEY_STREAM2 0x200 /* device-dependent stream */ ^1da177e include/asm-ppc/dbdma.h Linus Torvalds 2005-04-16 68 #define KEY_STREAM3 0x300 /* device-dependent stream */ ^1da177e include/asm-ppc/dbdma.h Linus Torvalds 2005-04-16 69 #define KEY_REGS0x500 /* device register space */ ^1da177e include/asm-ppc/dbdma.h Linus Torvalds 2005-04-16 @70 #define KEY_SYSTEM 0x600 /* system memory-mapped space */ ^1da177e include/asm-ppc/dbdma.h Linus Torvalds 2005-04-16 71 #define KEY_DEVICE 0x700 /* device memory-mapped space */ ^1da177e include/asm-ppc/dbdma.h Linus Torvalds 2005-04-16 72 :: The code at line 70 was first introduced by commit :: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2 :: TO: Linus Torvalds :: CC: Linus Torvalds --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH] videodev2.h: add V4L2_BUF_CAP_SUPPORTS_PREPARE_BUF/CREATE_BUFS
Hi Hans,
I love your patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.20-rc3 next-20181120]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Hans-Verkuil/videodev2-h-add-V4L2_BUF_CAP_SUPPORTS_PREPARE_BUF-CREATE_BUFS/20181120-190153
base: git://linuxtv.org/media_tree.git master
config: i386-randconfig-x077-201846 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
drivers/media/common/videobuf2/videobuf2-v4l2.c: In function
'fill_buf_caps_vdev':
>> drivers/media/common/videobuf2/videobuf2-v4l2.c:878:21: error: dereferencing
>> pointer to incomplete type 'const struct v4l2_ioctl_ops'
if (vdev->ioctl_ops->vidioc_prepare_buf)
^~
vim +878 drivers/media/common/videobuf2/videobuf2-v4l2.c
873
874 static void fill_buf_caps_vdev(struct video_device *vdev, u32 *caps)
875 {
876 *caps = 0;
877 fill_buf_caps(vdev->queue, caps);
> 878 if (vdev->ioctl_ops->vidioc_prepare_buf)
879 *caps |= V4L2_BUF_CAP_SUPPORTS_PREPARE_BUF;
880 if (vdev->ioctl_ops->vidioc_create_bufs)
881 *caps |= V4L2_BUF_CAP_SUPPORTS_CREATE_BUFS;
882 }
883
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH] videodev2.h: add V4L2_BUF_CAP_SUPPORTS_PREPARE_BUF/CREATE_BUFS
Hi Hans,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v4.20-rc3 next-20181120]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Hans-Verkuil/videodev2-h-add-V4L2_BUF_CAP_SUPPORTS_PREPARE_BUF-CREATE_BUFS/20181120-190153
base: git://linuxtv.org/media_tree.git master
config: i386-randconfig-x070-201846 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All warnings (new ones prefixed by >>):
In file included from include/linux/err.h:5:0,
from drivers/media/common/videobuf2/videobuf2-v4l2.c:17:
drivers/media/common/videobuf2/videobuf2-v4l2.c: In function
'fill_buf_caps_vdev':
drivers/media/common/videobuf2/videobuf2-v4l2.c:878:21: error: dereferencing
pointer to incomplete type 'const struct v4l2_ioctl_ops'
if (vdev->ioctl_ops->vidioc_prepare_buf)
^
include/linux/compiler.h:58:30: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^~~~
>> drivers/media/common/videobuf2/videobuf2-v4l2.c:878:2: note: in expansion of
>> macro 'if'
if (vdev->ioctl_ops->vidioc_prepare_buf)
^~
vim +/if +878 drivers/media/common/videobuf2/videobuf2-v4l2.c
873
874 static void fill_buf_caps_vdev(struct video_device *vdev, u32 *caps)
875 {
876 *caps = 0;
877 fill_buf_caps(vdev->queue, caps);
> 878 if (vdev->ioctl_ops->vidioc_prepare_buf)
879 *caps |= V4L2_BUF_CAP_SUPPORTS_PREPARE_BUF;
880 if (vdev->ioctl_ops->vidioc_create_bufs)
881 *caps |= V4L2_BUF_CAP_SUPPORTS_CREATE_BUFS;
882 }
883
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH v8 01/12] media: staging/imx: refactor imx media device probe
Hi Rui, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.20-rc3 next-20181121] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Rui-Miguel-Silva/media-staging-imx7-add-i-MX7-media-driver/20181122-024200 base: git://linuxtv.org/media_tree.git master config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): >> make[5]: *** No rule to make target >> 'drivers/staging/media/imx/imx-media-dev-common.o', needed by >> 'drivers/staging/media/imx/imx-media.o'. make[5]: Target '__build' not remade because of errors. --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH v8 04/12] media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7
Hi Rui, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.20-rc3 next-20181121] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Rui-Miguel-Silva/media-staging-imx7-add-i-MX7-media-driver/20181122-024200 base: git://linuxtv.org/media_tree.git master coccinelle warnings: (new ones prefixed by >>) >> drivers/staging/media/imx/imx7-mipi-csis.c:1125:3-8: No need to set .owner >> here. The core will do it. Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
[PATCH] media: staging/imx7: fix platform_no_drv_owner.cocci warnings
From: kbuild test robot
drivers/staging/media/imx/imx7-mipi-csis.c:1125:3-8: No need to set .owner
here. The core will do it.
Remove .owner field if calls are used which set it automatically
Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
Fixes: 181331ab8acb ("media: staging/imx7: add MIPI CSI-2 receiver subdev for
i.MX7")
CC: Rui Miguel Silva
Signed-off-by: kbuild test robot
---
url:
https://github.com/0day-ci/linux/commits/Rui-Miguel-Silva/media-staging-imx7-add-i-MX7-media-driver/20181122-024200
base: git://linuxtv.org/media_tree.git master
imx7-mipi-csis.c |1 -
1 file changed, 1 deletion(-)
--- a/drivers/staging/media/imx/imx7-mipi-csis.c
+++ b/drivers/staging/media/imx/imx7-mipi-csis.c
@@ -1122,7 +1122,6 @@ static struct platform_driver mipi_csis_
.driver = {
.of_match_table = mipi_csis_of_match,
.name = CSIS_DRIVER_NAME,
- .owner = THIS_MODULE,
.pm = &mipi_csis_pm_ops,
},
};
[ragnatech:media-tree 32/140] drivers/media/platform/seco-cec/seco-cec.c:237:4: error: implicit declaration of function 'cec_transmit_attempt_done'
tree: git://git.ragnatech.se/linux media-tree
head: 708d75fe1c7c6e9abc5381b6fcc32b49830383d0
commit: b03c2fb97adcc65d3c4098c4aa41fbaa6623ebf2 [32/140] media: add SECO cec
driver
config: i386-randconfig-x006-201847 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
git checkout b03c2fb97adcc65d3c4098c4aa41fbaa6623ebf2
# save the attached .config to linux build tree
make ARCH=i386
Note: the ragnatech/media-tree HEAD 708d75fe1c7c6e9abc5381b6fcc32b49830383d0
builds fine.
It only hurts bisectibility.
All error/warnings (new ones prefixed by >>):
drivers/media/platform/seco-cec/seco-cec.c: In function 'secocec_tx_done':
>> drivers/media/platform/seco-cec/seco-cec.c:237:4: error: implicit
>> declaration of function 'cec_transmit_attempt_done'
>> [-Werror=implicit-function-declaration]
cec_transmit_attempt_done(adap, CEC_TX_STATUS_NACK);
^
drivers/media/platform/seco-cec/seco-cec.c: In function 'secocec_rx_done':
>> drivers/media/platform/seco-cec/seco-cec.c:316:2: error: implicit
>> declaration of function 'cec_received_msg'; did you mean
>> 'free_reserved_page'? [-Werror=implicit-function-declaration]
cec_received_msg(cec->cec_adap, &msg);
^~~~
free_reserved_page
drivers/media/platform/seco-cec/seco-cec.c: In function 'secocec_probe':
>> drivers/media/platform/seco-cec/seco-cec.c:527:22: error: implicit
>> declaration of function 'cec_allocate_adapter'; did you mean
>> 'cec_delete_adapter'? [-Werror=implicit-function-declaration]
secocec->cec_adap = cec_allocate_adapter(&secocec_cec_adap_ops,
^~~~
cec_delete_adapter
>> drivers/media/platform/seco-cec/seco-cec.c:527:20: warning: assignment makes
>> pointer from integer without a cast [-Wint-conversion]
secocec->cec_adap = cec_allocate_adapter(&secocec_cec_adap_ops,
^
cc1: some warnings being treated as errors
vim +/cec_transmit_attempt_done +237 drivers/media/platform/seco-cec/seco-cec.c
232
233 static void secocec_tx_done(struct cec_adapter *adap, u16 status_val)
234 {
235 if (status_val & SECOCEC_STATUS_TX_ERROR_MASK) {
236 if (status_val & SECOCEC_STATUS_TX_NACK_ERROR)
> 237 cec_transmit_attempt_done(adap,
> CEC_TX_STATUS_NACK);
238 else
239 cec_transmit_attempt_done(adap,
CEC_TX_STATUS_ERROR);
240 } else {
241 cec_transmit_attempt_done(adap, CEC_TX_STATUS_OK);
242 }
243
244 /* Reset status reg */
245 status_val = SECOCEC_STATUS_TX_ERROR_MASK |
246 SECOCEC_STATUS_MSG_SENT_MASK |
247 SECOCEC_STATUS_TX_NACK_ERROR;
248 smb_wr16(SECOCEC_STATUS, status_val);
249 }
250
251 static void secocec_rx_done(struct cec_adapter *adap, u16 status_val)
252 {
253 struct secocec_data *cec = cec_get_drvdata(adap);
254 struct device *dev = cec->dev;
255 struct cec_msg msg = { };
256 bool flag_overflow = false;
257 u8 payload_len, i = 0;
258 u8 *payload_msg;
259 u16 val = 0;
260 int status;
261
262 if (status_val & SECOCEC_STATUS_RX_OVERFLOW_MASK) {
263 /* NOTE: Untested, it also might not be necessary */
264 dev_warn(dev, "Received more than 16 bytes.
Discarding");
265 flag_overflow = true;
266 }
267
268 if (status_val & SECOCEC_STATUS_RX_ERROR_MASK) {
269 dev_warn(dev, "Message received with errors.
Discarding");
270 status = -EIO;
271 goto rxerr;
272 }
273
274 /* Read message length */
275 status = smb_rd16(SECOCEC_READ_DATA_LENGTH, &val);
276 if (status)
277 return;
278
279 /* Device msg len already accounts for the header */
280 msg.len = min(val + 1, CEC_MAX_MSG_SIZE);
281
282 /* Read logical address */
283 status = smb_rd16(SECOCEC_READ_BYTE0, &val);
284 if (status)
285 return;
286
287 /* device stores source LA and destination */
288 msg.msg[0] = val;
289
290 /* Read operation ID */
291 status = smb_rd16(SECOCEC_READ_OPERATION_ID, &val);
292 if (status)
293 return;
294
295 msg.msg[1] = val;
296
297 /* Read data if present */
298 if (msg.len > 1) {
299 payload_len = msg.len - 2;
300 payload_msg = &msg.msg[2];
301
302 /* device stores 2 bytes in every 16-bit v
[ragnatech:media-tree] BUILD INCOMPLETE 9b90dc85c718443a3e573a0ccf55900ff4fa73ae
tree/branch: git://git.ragnatech.se/linux media-tree branch HEAD: 9b90dc85c718443a3e573a0ccf55900ff4fa73ae media: seco-cec: add missing header file to fix build TIMEOUT after 1554m Sorry we cannot finish the testset for your branch within a reasonable time. It's our fault -- either some build server is down or some build worker is busy doing bisects for _other_ trees. The branch will get more complete coverage and possible error reports when our build infrastructure is restored or catches up. There will be no more build success notification for this branch head, but you can expect reasonably good test coverage after waiting for 1 day. configs timed out: 151 alphaallmodconfig alphaallyesconfig alpha defconfig arm allnoconfig arm at91_dt_defconfig arm efm32_defconfig arm exynos_defconfig armmulti_v5_defconfig armmulti_v7_defconfig armshmobile_defconfig arm sunxi_defconfig arm64 allnoconfig arm64 defconfig i386 allmodconfig i386randconfig-a0 i386randconfig-a1 i386randconfig-a2 i386randconfig-a3 i386randconfig-f0 i386randconfig-f1 i386randconfig-f2 i386randconfig-f3 i386randconfig-i0 i386randconfig-i1 i386randconfig-i2 i386randconfig-i3 i386randconfig-j0 i386randconfig-j1 i386randconfig-j2 i386randconfig-j3 i386randconfig-k0 i386randconfig-k1 i386randconfig-k2 i386randconfig-k3 i386randconfig-n0 i386randconfig-n1 i386randconfig-n2 i386randconfig-n3 i386randconfig-s0 i386randconfig-s1 i386randconfig-s2 i386randconfig-s3 i386 randconfig-x010 i386 randconfig-x011 i386 randconfig-x012 i386 randconfig-x013 i386 randconfig-x014 i386 randconfig-x015 i386 randconfig-x016 i386 randconfig-x017 i386 randconfig-x018 i386 randconfig-x019 i386 tinyconfig ia64 allmodconfig ia64 allyesconfig m68k allmodconfig m68k allyesconfig m68k m5475evb_defconfig m68k multi_defconfig m68k sun3_defconfig microblaze mmu_defconfig microblazenommu_defconfig mips 32r2_defconfig mips 64r6el_defconfig mips allmodconfig mips allyesconfig mips jz4740 mips txx9 nds32allmodconfig nds32allyesconfig openriscor1ksim_defconfig parisc allmodconfig pariscallnoconfig parisc allyesconfig parisc b180_defconfig pariscc3000_defconfig parisc defconfig powerpc allmodconfig powerpc allnoconfig powerpc allyesconfig powerpc defconfig powerpc ppc64_defconfig riscvallmodconfig riscvallyesconfig riscv tinyconfig s390 allmodconfig s390 allyesconfig s390default_defconfig sh allmodconfig shallnoconfig sh allyesconfig sh rsk7269_defconfig sh sh7785lcr_32bit_defconfig shtitan_defconfig s
[ragnatech:media-tree 198/228] arch/arm/include/asm/irq.h:35:50: error: unknown type name 'cpumask_t'
tree: git://git.ragnatech.se/linux media-tree head: da2c94c8f9739e4099ea3cfefc208fc721b22a9c commit: b6973637c4cc842c1aa7d6c848781b4bdeb4415b [198/228] media: ddbridge: remove another duplicate of io.h and sort includes config: arm-allmodconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout b6973637c4cc842c1aa7d6c848781b4bdeb4415b # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=arm All errors (new ones prefixed by >>): In file included from drivers/media/pci/ddbridge/ddbridge.h:22:0, from drivers/media/pci/ddbridge/ddbridge-hw.c:19: >> arch/arm/include/asm/irq.h:35:50: error: unknown type name 'cpumask_t' extern void arch_trigger_cpumask_backtrace(const cpumask_t *mask, ^ >> arch/arm/include/asm/irq.h:36:9: error: unknown type name 'bool'; did you >> mean '_Bool'? bool exclude_self); ^~~~ _Bool vim +/cpumask_t +35 arch/arm/include/asm/irq.h 446616db Russell King 2008-09-06 33 96f0e003 Russell King 2014-09-03 34 #ifdef CONFIG_SMP 9a01c3ed Chris Metcalf 2016-10-07 @35 extern void arch_trigger_cpumask_backtrace(const cpumask_t *mask, 9a01c3ed Chris Metcalf 2016-10-07 @36 bool exclude_self); 9a01c3ed Chris Metcalf 2016-10-07 37 #define arch_trigger_cpumask_backtrace arch_trigger_cpumask_backtrace 96f0e003 Russell King 2014-09-03 38 #endif 96f0e003 Russell King 2014-09-03 39 :: The code at line 35 was first introduced by commit :: 9a01c3ed5cdb35d9004eb92510ee6ea11b4a5f16 nmi_backtrace: add more trigger_*_cpu_backtrace() methods :: TO: Chris Metcalf :: CC: Linus Torvalds --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCHv3 1/1] Add ir-rcmm-driver
Hi Patrick, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.20-rc5 next-20181207] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Patrick-LERDA/Add-ir-rcmm-driver/20181208-02 base: git://linuxtv.org/media_tree.git master reproduce: make htmldocs All warnings (new ones prefixed by >>): include/net/mac80211.h:477: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:477: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:477: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:477: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:477: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:477: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:477: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:477: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:477: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' net/mac80211/sta_info.h:588: warning: Function parameter or member 'rx_stats_avg' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'rx_stats_avg.signal' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'rx_stats_avg.chain_signal' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.filtered' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.retry_failed' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.retry_count' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.lost_packets' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.last_tdls_pkt_time' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.msdu_retries' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.msdu_failed' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.last_ack' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.last_ack_signal' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.ack_signal_filled' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.avg_ack_signal' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'tx_stats.packets' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'tx_stats.bytes' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'tx_stats.last_rate' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'tx_stats.msdu' not described in 'sta_info' kernel/rcu/tree.c:685: warning: Excess function parameter 'irq' description in 'rcu_nmi_exit' include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_excl.cb' not described in 'dma_buf' include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_excl.poll' not described in 'dma_buf' include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_excl.active' not described in 'dma_buf' include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_shared.cb' not described in 'dma_buf' include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_shared.poll' not described in 'dma_buf' include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_shared.active' not described in 'dma_buf' include/linux/dma-fence-array.h:54: warning: Function parameter or member 'work' not described in 'dma_fence_array' include/linux/gpio/driver.h:375: warning: Function parameter or member 'init_valid_mask' not described in 'gpio_chip' include/linux/iio/hw-consumer.h:1: warning: no structured comments found include/linux/input/sparse-keymap.h:46: warning: Function parameter or member 'sw' not describ
Re: [PATCH 2/3] media: ov2640: make VIDIOC_SUBDEV_G_FMT ioctl work with V4L2_SUBDEV_FORMAT_TRY
Hi Akinobu,
I love your patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.20-rc5 next-20181207]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Akinobu-Mita/media-ov2640-fix-two-problems/20181208-165345
base: git://linuxtv.org/media_tree.git master
config: x86_64-randconfig-x011-201848 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All error/warnings (new ones prefixed by >>):
drivers/media//i2c/ov2640.c: In function 'ov2640_get_fmt':
>> drivers/media//i2c/ov2640.c:930:8: error: implicit declaration of function
>> 'v4l2_subdev_get_try_format'; did you mean 'v4l2_subdev_notify_event'?
>> [-Werror=implicit-function-declaration]
mf = v4l2_subdev_get_try_format(sd, cfg, 0);
^~
v4l2_subdev_notify_event
>> drivers/media//i2c/ov2640.c:930:6: warning: assignment makes pointer from
>> integer without a cast [-Wint-conversion]
mf = v4l2_subdev_get_try_format(sd, cfg, 0);
^
drivers/media//i2c/ov2640.c: In function 'ov2640_init_cfg':
>> drivers/media//i2c/ov2640.c:1007:3: warning: initialization makes pointer
>> from integer without a cast [-Wint-conversion]
v4l2_subdev_get_try_format(sd, cfg, 0);
^~
cc1: some warnings being treated as errors
vim +930 drivers/media//i2c/ov2640.c
917
918 static int ov2640_get_fmt(struct v4l2_subdev *sd,
919 struct v4l2_subdev_pad_config *cfg,
920 struct v4l2_subdev_format *format)
921 {
922 struct v4l2_mbus_framefmt *mf = &format->format;
923 struct i2c_client *client = v4l2_get_subdevdata(sd);
924 struct ov2640_priv *priv = to_ov2640(client);
925
926 if (format->pad)
927 return -EINVAL;
928
929 if (format->which == V4L2_SUBDEV_FORMAT_TRY) {
> 930 mf = v4l2_subdev_get_try_format(sd, cfg, 0);
931 format->format = *mf;
932
933 return 0;
934 }
935
936 mf->width = priv->win->width;
937 mf->height = priv->win->height;
938 mf->code= priv->cfmt_code;
939 mf->colorspace = V4L2_COLORSPACE_SRGB;
940 mf->field = V4L2_FIELD_NONE;
941
942 return 0;
943 }
944
945 static int ov2640_set_fmt(struct v4l2_subdev *sd,
946 struct v4l2_subdev_pad_config *cfg,
947 struct v4l2_subdev_format *format)
948 {
949 struct v4l2_mbus_framefmt *mf = &format->format;
950 struct i2c_client *client = v4l2_get_subdevdata(sd);
951 struct ov2640_priv *priv = to_ov2640(client);
952 const struct ov2640_win_size *win;
953 int ret = 0;
954
955 if (format->pad)
956 return -EINVAL;
957
958 mutex_lock(&priv->lock);
959
960 /* select suitable win */
961 win = ov2640_select_win(mf->width, mf->height);
962 mf->width = win->width;
963 mf->height = win->height;
964
965 mf->field = V4L2_FIELD_NONE;
966 mf->colorspace = V4L2_COLORSPACE_SRGB;
967
968 switch (mf->code) {
969 case MEDIA_BUS_FMT_RGB565_2X8_BE:
970 case MEDIA_BUS_FMT_RGB565_2X8_LE:
971 case MEDIA_BUS_FMT_YUYV8_2X8:
972 case MEDIA_BUS_FMT_UYVY8_2X8:
973 case MEDIA_BUS_FMT_YVYU8_2X8:
974 case MEDIA_BUS_FMT_VYUY8_2X8:
975 break;
976 default:
977 mf->code = MEDIA_BUS_FMT_UYVY8_2X8;
978 break;
979 }
980
981 if (format->which == V4L2_SUBDEV_FORMAT_ACTIVE) {
982 struct ov2640_priv *priv = to_ov2640(client);
983
984 if (priv->streaming) {
985 ret = -EBUSY;
986 goto out;
987 }
988 /* select win */
989 priv->win = win;
990 /* select format */
991 priv->cfmt_code = mf->code;
992 } else {
993 cfg->try_fmt = *mf;
994 }
995 out:
996 mutex_unlock(&priv->lock);
997
998 return ret;
999 }
1000
1001 static int ov2640_init_cfg(struct v4l2_subdev *sd,
1002 struct v4l2_subdev_pad_config *cfg)
1003 {
1004 struct i2c_client *client = v4l2_get_subdevdata(sd);
1005 struct ov2640_priv *priv = to_ov2640(cli
Re: [PATCH 4/7] mfd: ds90ux9xx: add TI DS90Ux9xx de-/serializer MFD driver
Hi Vladimir,
I love your patch! Perhaps something to improve:
[auto build test WARNING on ljones-mfd/for-mfd-next]
[also build test WARNING on v4.19-rc7 next-20181008]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Vladimir-Zapolskiy/mfd-pinctrl-add-initial-support-of-TI-DS90Ux9xx-ICs/20181009-090135
base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings
All warnings (new ones prefixed by >>):
drivers/mfd/ds90ux9xx-core.c: In function 'ds90ux9xx_probe':
>> drivers/mfd/ds90ux9xx-core.c:789:4: warning: 'id_code' may be used
>> uninitialized in this function [-Wmaybe-uninitialized]
dev_err(ds90ux9xx->dev,
^~~
drivers/mfd/ds90ux9xx-core.c:755:14: note: 'id_code' was declared here
const char *id_code;
^~~
vim +/id_code +789 drivers/mfd/ds90ux9xx-core.c
749
750 static int ds90ux9xx_read_ic_type(struct i2c_client *client,
751struct ds90ux9xx *ds90ux9xx)
752 {
753 u8 device_id[DEVICE_ID_LEN + 1] = { 0 };
754 const struct i2c_device_id *id;
755 const char *id_code;
756 unsigned int i;
757 int ret;
758
759 ret = regmap_raw_read(ds90ux9xx->regmap, SER_DES_DEVICE_ID_REG,
760device_id, DEVICE_ID_LEN);
761 if (ret < 0) {
762 dev_err(ds90ux9xx->dev, "Failed to read device id:
%d\n", ret);
763 return ret;
764 }
765
766 id = i2c_match_id(ds90ux9xx_ids, client);
767 if (id) {
768 id_code = ds90ux9xx_devices[id->driver_data].id;
769 if (!strncmp(device_id, id_code, DEVICE_ID_LEN)) {
770 ds90ux9xx->dev_id = id->driver_data;
771 return 0;
772 }
773 }
774
775 /* DS90UH925 device quirk */
776 if (!memcmp(device_id, "\0\0\0\0\0\0", DEVICE_ID_LEN)) {
777 if (id && id->driver_data != TI_DS90UH925)
778 dev_err(ds90ux9xx->dev,
779 "Device ID returned all zeroes,
assuming device is DS90UH925\n");
780 ds90ux9xx->dev_id = TI_DS90UH925;
781 return 0;
782 }
783
784 for (i = 0; i < ARRAY_SIZE(ds90ux9xx_devices); i++) {
785 if (strncmp(device_id, ds90ux9xx_devices[i].id,
DEVICE_ID_LEN))
786 continue;
787
788 if (id)
> 789 dev_err(ds90ux9xx->dev,
790 "Mismatch between probed device ID [%s]
and HW device ID [%s]\n",
791 id_code, device_id);
792
793 ds90ux9xx->dev_id = i;
794 return 0;
795 }
796
797 dev_err(ds90ux9xx->dev, "Device ID [%s] is not supported\n",
device_id);
798
799 return -ENODEV;
800 }
801
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH] media: venus: add support for key frame
Hi Malathi,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v4.19-rc7 next-20181009]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Malathi-Gottam/media-venus-add-support-for-key-frame/20181009-214918
base: git://linuxtv.org/media_tree.git master
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=arm
Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings
All warnings (new ones prefixed by >>):
drivers/media//platform/qcom/venus/venc_ctrls.c: In function
'venc_op_s_ctrl':
>> drivers/media//platform/qcom/venus/venc_ctrls.c:180:7: warning: 'ptr' may be
>> used uninitialized in this function [-Wmaybe-uninitialized]
ret = hfi_session_set_property(inst, ptype, ptr);
^~~~
vim +/ptr +180 drivers/media//platform/qcom/venus/venc_ctrls.c
77
78 static int venc_op_s_ctrl(struct v4l2_ctrl *ctrl)
79 {
80 struct venus_inst *inst = ctrl_to_inst(ctrl);
81 struct venc_controls *ctr = &inst->controls.enc;
82 u32 bframes;
83 int ret;
84 void *ptr;
85 u32 ptype;
86
87 switch (ctrl->id) {
88 case V4L2_CID_MPEG_VIDEO_BITRATE_MODE:
89 ctr->bitrate_mode = ctrl->val;
90 break;
91 case V4L2_CID_MPEG_VIDEO_BITRATE:
92 ctr->bitrate = ctrl->val;
93 break;
94 case V4L2_CID_MPEG_VIDEO_BITRATE_PEAK:
95 ctr->bitrate_peak = ctrl->val;
96 break;
97 case V4L2_CID_MPEG_VIDEO_H264_ENTROPY_MODE:
98 ctr->h264_entropy_mode = ctrl->val;
99 break;
100 case V4L2_CID_MPEG_VIDEO_MPEG4_PROFILE:
101 ctr->profile.mpeg4 = ctrl->val;
102 break;
103 case V4L2_CID_MPEG_VIDEO_H264_PROFILE:
104 ctr->profile.h264 = ctrl->val;
105 break;
106 case V4L2_CID_MPEG_VIDEO_VP8_PROFILE:
107 ctr->profile.vpx = ctrl->val;
108 break;
109 case V4L2_CID_MPEG_VIDEO_MPEG4_LEVEL:
110 ctr->level.mpeg4 = ctrl->val;
111 break;
112 case V4L2_CID_MPEG_VIDEO_H264_LEVEL:
113 ctr->level.h264 = ctrl->val;
114 break;
115 case V4L2_CID_MPEG_VIDEO_H264_I_FRAME_QP:
116 ctr->h264_i_qp = ctrl->val;
117 break;
118 case V4L2_CID_MPEG_VIDEO_H264_P_FRAME_QP:
119 ctr->h264_p_qp = ctrl->val;
120 break;
121 case V4L2_CID_MPEG_VIDEO_H264_B_FRAME_QP:
122 ctr->h264_b_qp = ctrl->val;
123 break;
124 case V4L2_CID_MPEG_VIDEO_H264_MIN_QP:
125 ctr->h264_min_qp = ctrl->val;
126 break;
127 case V4L2_CID_MPEG_VIDEO_H264_MAX_QP:
128 ctr->h264_max_qp = ctrl->val;
129 break;
130 case V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MODE:
131 ctr->multi_slice_mode = ctrl->val;
132 break;
133 case V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MAX_BYTES:
134 ctr->multi_slice_max_bytes = ctrl->val;
135 break;
136 case V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MAX_MB:
137 ctr->multi_slice_max_mb = ctrl->val;
138 break;
139 case V4L2_CID_MPEG_VIDEO_H264_LOOP_FILTER_ALPHA:
140 ctr->h264_loop_filter_alpha = ctrl->val;
141 break;
142 case V4L2_CID_MPEG_VIDEO_H264_LOOP_FILTER_BETA:
143 ctr->h264_loop_filter_beta = ctrl->val;
144 break;
145 case V4L2_CID_MPEG_VIDEO_H264_LOOP_FILTER_MODE:
146 ctr->h264_loop_filter_mode = ctrl->val;
147 break;
148 case V4L2_CID_MPEG_VIDEO_HEADER_MODE:
149 ctr->header_mode = ctrl->val;
150 break;
151 case V4L2_CID_MPEG_VIDEO_CYCLIC_INTRA_REFRESH_MB:
152 break;
153 case V4L2_CID_MPEG_VIDEO_GOP_SIZE:
154 ret = venc_calc_bpframes(ctrl->val, ctr->num_b_fram
Re: [PATCH] media: venus: queue initial buffers
Hi Malathi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.19-rc7 next-20181009]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Malathi-Gottam/media-venus-queue-initial-buffers/20181009-221017
base: git://linuxtv.org/media_tree.git master
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=m68k
All error/warnings (new ones prefixed by >>):
drivers/media//platform/qcom/venus/venc.c: In function
'venc_start_streaming':
>> drivers/media//platform/qcom/venus/venc.c:994:3: error: label 'deinit_sess'
>> used but not defined
goto deinit_sess;
^~~~
>> drivers/media//platform/qcom/venus/venc.c:973:3: error: label 'bufs_done'
>> used but not defined
goto bufs_done;
^~~~
drivers/media//platform/qcom/venus/venc.c: At top level:
>> drivers/media//platform/qcom/venus/venc.c:997:15: error: expected
>> declaration specifiers or '...' before '&' token
mutex_unlock(&inst->lock);
^
>> drivers/media//platform/qcom/venus/venc.c:999:2: error: expected identifier
>> or '(' before 'return'
return 0;
^~
>> drivers/media//platform/qcom/venus/venc.c:1001:12: error: expected '=', ',',
>> ';', 'asm' or '__attribute__' before ':' token
deinit_sess:
^
drivers/media//platform/qcom/venus/venc.c:1003:10: error: expected '=', ',',
';', 'asm' or '__attribute__' before ':' token
bufs_done:
^
>> drivers/media//platform/qcom/venus/venc.c:1005:2: error: expected identifier
>> or '(' before 'if'
if (q->type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE)
^~
>> drivers/media//platform/qcom/venus/venc.c:1007:2: error: expected identifier
>> or '(' before 'else'
else
^~~~
drivers/media//platform/qcom/venus/venc.c:1009:15: error: expected
declaration specifiers or '...' before '&' token
mutex_unlock(&inst->lock);
^
drivers/media//platform/qcom/venus/venc.c:1010:2: error: expected identifier
or '(' before 'return'
return ret;
^~
>> drivers/media//platform/qcom/venus/venc.c:1011:1: error: expected identifier
>> or '(' before '}' token
}
^
drivers/media//platform/qcom/venus/venc.c: In function
'venc_start_streaming':
>> drivers/media//platform/qcom/venus/venc.c:995:2: warning: control reaches
>> end of non-void function [-Wreturn-type]
}
^
vim +/deinit_sess +994 drivers/media//platform/qcom/venus/venc.c
948
949 static int venc_start_streaming(struct vb2_queue *q, unsigned int count)
950 {
951 struct venus_inst *inst = vb2_get_drv_priv(q);
952 int ret;
953
954 mutex_lock(&inst->lock);
955
956 if (q->type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE)
957 inst->streamon_out = 1;
958 else
959 inst->streamon_cap = 1;
960
961 if (!(inst->streamon_out & inst->streamon_cap)) {
962 mutex_unlock(&inst->lock);
963 return 0;
964 }
965
966 venus_helper_init_instance(inst);
967
968 inst->sequence_cap = 0;
969 inst->sequence_out = 0;
970
971 ret = venc_init_session(inst);
972 if (ret)
> 973 goto bufs_done;
974
975 ret = venc_set_properties(inst);
976 if (ret)
977 goto deinit_sess;
978
979 ret = venc_verify_conf(inst);
980 if (ret)
981 goto deinit_sess;
982
983 ret = venus_helper_set_num_bufs(inst, inst->num_input_bufs,
984 inst->num_output_bufs, 0);
985 if (ret)
986 goto deinit_sess;
987
988 ret = venus_helper_vb2_start_streaming(inst);
989 if (ret)
990 goto deinit_sess;
991
992 ret = venus_helper_queue_initial_bufs(inst);
993 if (ret)
> 994 goto deinit_sess;
> 995 }
996
> 997 mutex_unlock(&inst->lock);
998
> 999 return 0;
1000
> 1001 deinit_sess:
1002 hfi_session_deinit(inst);
1003 bufs_done:
1004 venus_helper_buffers_done(inst, VB2_BUF_STATE_QUEUED);
> 1005 if (q->type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE)
1006 inst->streamon_out = 0;
> 1007 else
1008 inst->streamon_cap = 0;
1009 mutex_unlock(&inst->lock
Re: [PATCH 11/11] [media] marvell-ccic: provide a clock for the sensor
Hi Lubomir,
I love your patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.20-rc1 next-20181105]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Lubomir-Rintel/media-ov7670-hook-s_power-onto-v4l2-core/20181105-163336
base: git://linuxtv.org/media_tree.git master
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 8.1.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=8.1.0 make.cross ARCH=ia64
All error/warnings (new ones prefixed by >>):
In file included from drivers/media/platform/marvell-ccic/cafe-driver.c:38:
>> drivers/media/platform/marvell-ccic/mcam-core.h:129:16: error: field
>> 'mclk_hw' has incomplete type
struct clk_hw mclk_hw;
^~~
--
In file included from drivers/media/platform/marvell-ccic/mmp-driver.c:30:
>> drivers/media/platform/marvell-ccic/mcam-core.h:129:16: error: field
>> 'mclk_hw' has incomplete type
struct clk_hw mclk_hw;
^~~
drivers/media/platform/marvell-ccic/mmp-driver.c: In function 'mmpcam_probe':
>> drivers/media/platform/marvell-ccic/mmp-driver.c:302:8: error: implicit
>> declaration of function 'of_clk_add_provider'; did you mean
>> 'of_clk_get_from_provider'? [-Werror=implicit-function-declaration]
ret = of_clk_add_provider(pdev->dev.of_node, of_clk_src_simple_get,
^~~
of_clk_get_from_provider
>> drivers/media/platform/marvell-ccic/mmp-driver.c:302:47: error:
>> 'of_clk_src_simple_get' undeclared (first use in this function); did you
>> mean 'ida_simple_get'?
ret = of_clk_add_provider(pdev->dev.of_node, of_clk_src_simple_get,
^
ida_simple_get
drivers/media/platform/marvell-ccic/mmp-driver.c:302:47: note: each
undeclared identifier is reported only once for each function it appears in
cc1: some warnings being treated as errors
--
In file included from drivers/media/platform/marvell-ccic/mcam-core.c:35:
>> drivers/media/platform/marvell-ccic/mcam-core.h:129:16: error: field
>> 'mclk_hw' has incomplete type
struct clk_hw mclk_hw;
^~~
In file included from include/linux/kernel.h:10,
from drivers/media/platform/marvell-ccic/mcam-core.c:9:
drivers/media/platform/marvell-ccic/mcam-core.c: In function 'mclk_prepare':
include/linux/kernel.h:997:32: error: dereferencing pointer to incomplete
type 'struct clk_hw'
BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
^~
include/linux/compiler.h:353:9: note: in definition of macro
'__compiletime_assert'
if (!(condition)) \
^
include/linux/compiler.h:373:2: note: in expansion of macro
'_compiletime_assert'
_compiletime_assert(condition, msg, __compiletime_assert_, __LINE__)
^~~
include/linux/build_bug.h:45:37: note: in expansion of macro
'compiletime_assert'
#define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
^~
include/linux/kernel.h:997:2: note: in expansion of macro 'BUILD_BUG_ON_MSG'
BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
^~~~
include/linux/kernel.h:997:20: note: in expansion of macro '__same_type'
BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
^~~
drivers/media/platform/marvell-ccic/mcam-core.c:952:28: note: in expansion
of macro 'container_of'
struct mcam_camera *cam = container_of(hw, struct mcam_camera, mclk_hw);
^~~~
drivers/media/platform/marvell-ccic/mcam-core.c: At top level:
>> drivers/media/platform/marvell-ccic/mcam-core.c:1004:21: error: variable
>> 'mclk_ops' has initializer but incomplete type
static const struct clk_ops mclk_ops = {
^~~
>> drivers/media/platform/marvell-ccic/mcam-core.c:1005:3: error: 'const struct
>> clk_ops' has no member named 'prepare'
.prepare = mclk_prepare,
^~~
>> drivers/media/platform/marvell-ccic/mcam-core.c:1005:13: warning: excess
>> elements in struct initializer
.prepare = mclk_prepare,
^~~~
drivers/media/platform/marvell-ccic/mcam-core.c:1005:13: note: (near
initialization for 'mclk_ops')
>> drivers/media/platform/marvell-ccic/mcam-core.c:1006:3: error: 'const struct
>> clk_ops' has no member named 'unprepare'
.unprepare = mclk_unprepare,
^
drivers/media/platform/m
Re: [PATCH v4 2/3] media: meson: add v4l2 m2m video decoder driver
Hi Maxime, Thank you for the patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.20-rc1 next-20181106] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Maxime-Jourdan/dt-bindings-media-add-Amlogic-Video-Decoder-Bindings/20181106-162646 base: git://linuxtv.org/media_tree.git master config: ia64-allmodconfig (attached as .config) compiler: ia64-linux-gcc (GCC) 8.1.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=8.1.0 make.cross ARCH=ia64 All errors (new ones prefixed by >>): ERROR: "ia64_delay_loop" [drivers/spi/spi-thunderx.ko] undefined! ERROR: "numa_slit" [drivers/nvme/host/nvme-core.ko] undefined! ERROR: "__sw_hweight8" [drivers/net/wireless/mediatek/mt76/mt76.ko] undefined! ERROR: "ia64_delay_loop" [drivers/net/phy/mdio-cavium.ko] undefined! >> ERROR: "meson_canvas_get" [drivers/media/platform/meson/vdec/meson-vdec.ko] >> undefined! >> ERROR: "meson_canvas_alloc" >> [drivers/media/platform/meson/vdec/meson-vdec.ko] undefined! >> ERROR: "meson_canvas_config" >> [drivers/media/platform/meson/vdec/meson-vdec.ko] undefined! >> ERROR: "meson_canvas_free" [drivers/media/platform/meson/vdec/meson-vdec.ko] >> undefined! --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
[PATCH] media: platform: fix platform_no_drv_owner.cocci warnings
From: kbuild test robot
drivers/staging/media/sunxi/cedrus/cedrus.c:421:3-8: No need to set .owner
here. The core will do it.
Remove .owner field if calls are used which set it automatically
Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
Fixes: 50e761516f2b ("media: platform: Add Cedrus VPU decoder driver")
CC: Paul Kocialkowski
Signed-off-by: kbuild test robot
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 163c8d54a997153ee1a1e07fcac087492ad85b37
commit: 50e761516f2b8c0cdeb31a8c6ca1b4ef98cd13f1 media: platform: Add Cedrus
VPU decoder driver
cedrus.c |1 -
1 file changed, 1 deletion(-)
--- a/drivers/staging/media/sunxi/cedrus/cedrus.c
+++ b/drivers/staging/media/sunxi/cedrus/cedrus.c
@@ -418,7 +418,6 @@ static struct platform_driver cedrus_dri
.remove = cedrus_remove,
.driver = {
.name = CEDRUS_NAME,
- .owner = THIS_MODULE,
.of_match_table = of_match_ptr(cedrus_dt_match),
},
};
drivers/staging/media/sunxi/cedrus/cedrus.c:421:3-8: No need to set .owner here. The core will do it.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 163c8d54a997153ee1a1e07fcac087492ad85b37 commit: 50e761516f2b8c0cdeb31a8c6ca1b4ef98cd13f1 media: platform: Add Cedrus VPU decoder driver date: 6 weeks ago coccinelle warnings: (new ones prefixed by >>) >> drivers/staging/media/sunxi/cedrus/cedrus.c:421:3-8: No need to set .owner >> here. The core will do it. Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
[PATCH] media: meson: fix zalloc-simple.cocci warnings
From: kbuild test robot
drivers/media/platform/meson/vdec/esparser.c:148:13-31: WARNING:
dma_zalloc_coherent should be used for eos_vaddr, instead of
dma_alloc_coherent/memset
Use zeroing allocator rather than allocator followed by memset with 0
This considers some simple cases that are common and easy to validate
Note in particular that there are no ...s in the rule, so all of the
matched code has to be contiguous
Generated by: scripts/coccinelle/api/alloc/zalloc-simple.cocci
Fixes: 3ab8ea56b2f6 ("media: meson: add v4l2 m2m video decoder driver")
CC: Maxime Jourdan
Signed-off-by: kbuild test robot
---
url:
https://github.com/0day-ci/linux/commits/Maxime-Jourdan/dt-bindings-media-add-Amlogic-Video-Decoder-Bindings/20181106-162646
base: git://linuxtv.org/media_tree.git master
Please take the patch only if it's a positive warning. Thanks!
esparser.c |6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
--- a/drivers/media/platform/meson/vdec/esparser.c
+++ b/drivers/media/platform/meson/vdec/esparser.c
@@ -145,13 +145,11 @@ int esparser_queue_eos(struct amvdec_cor
dma_addr_t eos_paddr;
int ret;
- eos_vaddr = dma_alloc_coherent(dev,
- len + SEARCH_PATTERN_LEN,
- &eos_paddr, GFP_KERNEL);
+ eos_vaddr = dma_zalloc_coherent(dev, len + SEARCH_PATTERN_LEN,
+ &eos_paddr, GFP_KERNEL);
if (!eos_vaddr)
return -ENOMEM;
- memset(eos_vaddr, 0, len + SEARCH_PATTERN_LEN);
memcpy(eos_vaddr, data, len);
ret = esparser_write_data(core, eos_paddr, len);
dma_free_coherent(dev, len + SEARCH_PATTERN_LEN,
Re: [PATCH v4 2/3] media: meson: add v4l2 m2m video decoder driver
Hi Maxime, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.20-rc1 next-20181106] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Maxime-Jourdan/dt-bindings-media-add-Amlogic-Video-Decoder-Bindings/20181106-162646 base: git://linuxtv.org/media_tree.git master coccinelle warnings: (new ones prefixed by >>) >> drivers/media/platform/meson/vdec/codec_mpeg12.c:149:2-3: Unneeded semicolon -- >> drivers/media/platform/meson/vdec/vdec_helpers.c:187:3-4: Unneeded semicolon -- >> drivers/media/platform/meson/vdec/esparser.c:148:13-31: WARNING: >> dma_zalloc_coherent should be used for eos_vaddr, instead of >> dma_alloc_coherent/memset Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
[PATCH] media: meson: fix semicolon.cocci warnings
From: kbuild test robot
drivers/media/platform/meson/vdec/codec_mpeg12.c:149:2-3: Unneeded semicolon
Remove unneeded semicolon.
Generated by: scripts/coccinelle/misc/semicolon.cocci
Fixes: 3ab8ea56b2f6 ("media: meson: add v4l2 m2m video decoder driver")
CC: Maxime Jourdan
Signed-off-by: kbuild test robot
---
url:
https://github.com/0day-ci/linux/commits/Maxime-Jourdan/dt-bindings-media-add-Amlogic-Video-Decoder-Bindings/20181106-162646
base: git://linuxtv.org/media_tree.git master
codec_mpeg12.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/media/platform/meson/vdec/codec_mpeg12.c
+++ b/drivers/media/platform/meson/vdec/codec_mpeg12.c
@@ -146,7 +146,7 @@ static void codec_mpeg12_update_dar(stru
sess->pixelaspect.numerator = 1;
sess->pixelaspect.denominator = 1;
break;
- };
+ }
}
static irqreturn_t codec_mpeg12_threaded_isr(struct amvdec_session *sess)
[PATCH] media: meson: fix semicolon.cocci warnings
From: kbuild test robot
drivers/media/platform/meson/vdec/vdec_helpers.c:187:3-4: Unneeded semicolon
Remove unneeded semicolon.
Generated by: scripts/coccinelle/misc/semicolon.cocci
Fixes: 3ab8ea56b2f6 ("media: meson: add v4l2 m2m video decoder driver")
CC: Maxime Jourdan
Signed-off-by: kbuild test robot
---
url:
https://github.com/0day-ci/linux/commits/Maxime-Jourdan/dt-bindings-media-add-Amlogic-Video-Decoder-Bindings/20181106-162646
base: git://linuxtv.org/media_tree.git master
vdec_helpers.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/media/platform/meson/vdec/vdec_helpers.c
+++ b/drivers/media/platform/meson/vdec/vdec_helpers.c
@@ -184,7 +184,7 @@ int amvdec_set_canvases(struct amvdec_se
dev_err(sess->core->dev, "Unsupported pixfmt %08X\n",
pixfmt);
return -EINVAL;
- };
+ }
reg_num_cur++;
if (reg_num_cur >= reg_num[reg_base_cur]) {
Re: [PATCH v2 10/11] [media] marvell-ccic: use async notifier to get the sensor
Hi Lubomir,
I love your patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.20-rc1 next-20181112]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Lubomir-Rintel/media-make-Marvell-camera-work-on-DT-based-OLPC-XO-1-75/20181112-163212
base: git://linuxtv.org/media_tree.git master
config: x86_64-randconfig-x003-11121005 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
Note: the
linux-review/Lubomir-Rintel/media-make-Marvell-camera-work-on-DT-based-OLPC-XO-1-75/20181112-163212
HEAD e78fa6428e22bbc61543f031695ad6f204f32344 builds fine.
It only hurts bisectibility.
All error/warnings (new ones prefixed by >>):
drivers/media/platform/marvell-ccic/cafe-driver.c: In function
'cafe_pci_probe':
>> drivers/media/platform/marvell-ccic/cafe-driver.c:563:2: error: implicit
>> declaration of function 'cafe_shutdown'; did you mean 'mccic_shutdown'?
>> [-Werror=implicit-function-declaration]
cafe_shutdown(cam);
^
mccic_shutdown
drivers/media/platform/marvell-ccic/cafe-driver.c: At top level:
>> drivers/media/platform/marvell-ccic/cafe-driver.c:583:13: warning:
>> conflicting types for 'cafe_shutdown'
static void cafe_shutdown(struct cafe_camera *cam)
^
>> drivers/media/platform/marvell-ccic/cafe-driver.c:583:13: error: static
>> declaration of 'cafe_shutdown' follows non-static declaration
drivers/media/platform/marvell-ccic/cafe-driver.c:563:2: note: previous
implicit declaration of 'cafe_shutdown' was here
cafe_shutdown(cam);
^
cc1: some warnings being treated as errors
vim +563 drivers/media/platform/marvell-ccic/cafe-driver.c
481
482 /*
-- */
483 /*
484 * PCI interface stuff.
485 */
486
487 static int cafe_pci_probe(struct pci_dev *pdev,
488 const struct pci_device_id *id)
489 {
490 int ret;
491 struct cafe_camera *cam;
492 struct mcam_camera *mcam;
493
494 /*
495 * Start putting together one of our big camera structures.
496 */
497 ret = -ENOMEM;
498 cam = kzalloc(sizeof(struct cafe_camera), GFP_KERNEL);
499 if (cam == NULL)
500 goto out;
501 cam->pdev = pdev;
502 mcam = &cam->mcam;
503 mcam->chip_id = MCAM_CAFE;
504 spin_lock_init(&mcam->dev_lock);
505 init_waitqueue_head(&cam->smbus_wait);
506 mcam->plat_power_up = cafe_ctlr_power_up;
507 mcam->plat_power_down = cafe_ctlr_power_down;
508 mcam->dev = &pdev->dev;
509 snprintf(mcam->bus_info, sizeof(mcam->bus_info), "PCI:%s",
pci_name(pdev));
510 /*
511 * Vmalloc mode for buffers is traditional with this driver.
512 * We *might* be able to run DMA_contig, especially on a system
513 * with CMA in it.
514 */
515 mcam->buffer_mode = B_vmalloc;
516 /*
517 * Get set up on the PCI bus.
518 */
519 ret = pci_enable_device(pdev);
520 if (ret)
521 goto out_free;
522 pci_set_master(pdev);
523
524 ret = -EIO;
525 mcam->regs = pci_iomap(pdev, 0, 0);
526 if (!mcam->regs) {
527 printk(KERN_ERR "Unable to ioremap cafe-ccic regs\n");
528 goto out_disable;
529 }
530 mcam->regs_size = pci_resource_len(pdev, 0);
531 ret = request_irq(pdev->irq, cafe_irq, IRQF_SHARED,
"cafe-ccic", cam);
532 if (ret)
533 goto out_iounmap;
534
535 /*
536 * Initialize the controller and leave it powered up. It will
537 * stay that way until the sensor driver shows up.
538 */
539 cafe_ctlr_init(mcam);
540 cafe_ctlr_power_up(mcam);
541 /*
542 * Set up I2C/SMBUS communications. We have to drop the mutex
here
543 * because the sensor could attach in this call chain, leading
to
544 * unsightly deadlocks.
545 */
546 ret = cafe_smbus_setup(cam);
547 if (ret)
548 goto out_pdown;
549
550 mcam->asd.match_type = V4L2_ASYNC_MATCH_I2C;
551 mcam->asd.match.i2c.adapter_id =
i2c_adapter_id(cam->i2c_adapter);
552 mcam->asd.match.i2c.address = ov7670_info.addr;
553
554 ret = mccic_register(mcam);
555 if (ret)
556
Re: [PATCH] media: remove bdisp_dbg_declare() and hva_dbg_declare()
Hi Yangtao,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.20-rc4 next-20181130]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Yangtao-Li/media-remove-bdisp_dbg_declare-and-hva_dbg_declare/20181202-033340
base: git://linuxtv.org/media_tree.git master
config: nds32-allyesconfig (attached as .config)
compiler: nds32le-linux-gcc (GCC) 6.4.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=6.4.0 make.cross ARCH=nds32
All errors (new ones prefixed by >>):
drivers/media/platform/exynos4-is/fimc-is.c: In function
'fimc_is_debugfs_open':
>> drivers/media/platform/exynos4-is/fimc-is.c:757:27: error:
>> 'fimc_is_log_show' undeclared (first use in this function)
return single_open(file, fimc_is_log_show, inode->i_private);
^~~~
drivers/media/platform/exynos4-is/fimc-is.c:757:27: note: each undeclared
identifier is reported only once for each function it appears in
At top level:
drivers/media/platform/exynos4-is/fimc-is.c:755:12: warning:
'fimc_is_debugfs_open' defined but not used [-Wunused-function]
static int fimc_is_debugfs_open(struct inode *inode, struct file *file)
^~~~
vim +/fimc_is_log_show +757 drivers/media/platform/exynos4-is/fimc-is.c
9a761e43 Sylwester Nawrocki 2013-03-11 754
9a761e43 Sylwester Nawrocki 2013-03-11 755 static int
fimc_is_debugfs_open(struct inode *inode, struct file *file)
9a761e43 Sylwester Nawrocki 2013-03-11 756 {
9a761e43 Sylwester Nawrocki 2013-03-11 @757 return single_open(file,
fimc_is_log_show, inode->i_private);
9a761e43 Sylwester Nawrocki 2013-03-11 758 }
9a761e43 Sylwester Nawrocki 2013-03-11 759
:: The code at line 757 was first introduced by commit
:: 9a761e436843f228eaa2decda6d2c6dbd5ef1480 [media] exynos4-is: Add
Exynos4x12 FIMC-IS driver
:: TO: Sylwester Nawrocki
:: CC: Mauro Carvalho Chehab
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
