-archive.com/linux-media%40vger.kernel.org/msg89493.html
Shuah Khan (19):
Revert [media] media: media controller entity framework enhancements
for ALSA
media: Media Controller register/unregister entity_notify API
media: Add ALSA Media Controller devnodes
media: au8522 change to create
This reverts commit ed64cf1e182fb30fe67652386c0880fcf3302f97.
This patch is no longer necessary as the entity register
callback is implemented at media_device level.
Signed-off-by: Shuah Khan shua...@osg.samsung.com
---
drivers/media/media-device.c | 7 ---
include/media/media-entity.h | 4
-by: Shuah Khan shua...@osg.samsung.com
---
drivers/media/media-device.c | 45
include/media/media-device.h | 23 ++
2 files changed, 68 insertions(+)
diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c
index
-by: Shuah Khan shua...@osg.samsung.com
---
sound/usb/Makefile | 15 +++-
sound/usb/card.c | 5 ++
sound/usb/card.h | 1 +
sound/usb/media.c| 227 +++
sound/usb/media.h| 52 +++
sound/usb/pcm.c | 15
() prior to changing tuner
settings. If tuner isn't free, return busy condition.
Signed-off-by: Shuah Khan shua...@osg.samsung.com
---
drivers/media/usb/au0828/au0828-core.c | 184 +++-
drivers/media/usb/au0828/au0828-video.c | 72 -
drivers/media/usb
Update graph_mutex to graph_lock spinlock to be in sync with
the Media Conttroller change for the same.
Signed-off-by: Shuah Khan shua...@osg.samsung.com
---
drivers/media/platform/s3c-camif/camif-core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media
Add irq safe Media Controller start/stop pipeline API
media_entity_pipeline_start_irq()
media_entity_pipeline_stop_irq()
to be used from inside interrupt context.
Signed-off-by: Shuah Khan shua...@osg.samsung.com
---
drivers/media/media-entity.c | 80
Change s_input, s_fmt, s_tuner, s_frequency, querystd,
s_hw_freq_seek, and vb2_streamon interfaces that alter
the tuner configuration to check for tuner availability
by calling v4l_enable_media_tuner(). If tuner isn't free,
return -EBUSY.
Signed-off-by: Shuah Khan shua...@osg.samsung.com
Update graph_mutex to graph_lock spinlock to be in sync with
the Media Conttroller change for the same.
Signed-off-by: Shuah Khan shua...@osg.samsung.com
---
drivers/media/platform/exynos4-is/fimc-isp-video.c | 8
drivers/media/platform/exynos4-is/fimc-lite.c | 8
Add ALSA Media Controller capture, playback, and mixer
devnode defines.
Signed-off-by: Shuah Khan shua...@osg.samsung.com
---
include/uapi/linux/media.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h
index 4e816be..4a30ea3 100644
Update graph_mutex to graph_lock spinlock to be in sync with
the Media Conttroller change for the same.
Signed-off-by: Shuah Khan shua...@osg.samsung.com
---
drivers/staging/media/davinci_vpfe/vpfe_video.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers
Update graph_mutex to graph_lock spinlock to be in sync with
the Media Conttroller change for the same.
Signed-off-by: Shuah Khan shua...@osg.samsung.com
---
drivers/media/platform/omap3isp/isp.c | 4 ++--
drivers/media/platform/omap3isp/ispvideo.c | 4 ++--
2 files changed, 4 insertions
drivers such as ALSA that control the media device.
Signed-off-by: Shuah Khan shua...@osg.samsung.com
---
include/media/media-device.h | 12
1 file changed, 12 insertions(+)
diff --git a/include/media/media-device.h b/include/media/media-device.h
index e73642c..377102b 100644
Update graph_mutex to graph_lock spinlock to be in sync with
the Media Conttroller change for the same.
Signed-off-by: Shuah Khan shua...@osg.samsung.com
---
drivers/staging/media/omap4iss/iss.c | 4 ++--
drivers/staging/media/omap4iss/iss_video.c | 4 ++--
2 files changed, 4 insertions
Add new pad for ALSA Audio Out to au8522_media_pads. Move the
au8522_media_pads enum to au8522.h from au8522_priv.h. This will
allow au0828-core to use these defines instead of hard-coding the
pad values when it creates media graph linking decode pads to other
entities.
Signed-off-by: Shuah Khan
.
Signed-off-by: Shuah Khan shua...@osg.samsung.com
---
drivers/media/media-device.c | 14 +++---
drivers/media/media-entity.c | 18 +-
include/media/media-device.h | 4 ++--
3 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/drivers/media/media-device.c b/drivers
Update graph_mutex to graph_lock spinlock to be in sync with
the Media Conttroller change for the same.
Signed-off-by: Shuah Khan shua...@osg.samsung.com
---
drivers/media/platform/vsp1/vsp1_video.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform
Checking for tuner availability from frontend thread start
disrupts video stream. Change to check for tuner and start
pipeline from frontend open instead and stop pipeline from
frontend release.
Signed-off-by: Shuah Khan shua...@osg.samsung.com
---
drivers/media/dvb-core/dvb_frontend.c | 43
Add a new interface to be used by v4l-core to invoke enable_source
handler in the media_device to find tuner entity connected to the
decoder and check is it is available. enable_source handler will
activate the link if tuner is available.
Signed-off-by: Shuah Khan shua...@osg.samsung.com
On 07/22/2015 04:42 PM, Shuah Khan wrote:
This patch series updates ALSA driver, and au0828 core driver to
use Managed Media controller API to share tuner. Please note that
Managed Media Controller API and DVB and V4L2 drivers updates to
use Media Controller API have been added in a prior
On 07/14/2015 08:06 AM, Sakari Ailus wrote:
Hi Shuah,
Shuah Khan wrote:
All,
ALSA has to make media_entity_pipeline_start() call in irq
path. I am seeing warnings that the graph_mutex is unsafe irq
lock as expected. We have to update MC start/stop pipeline
to be irq safe for ALSA. Maybe
Add ALSA Media Controller capture, playback, and mixer
devnode defines.
Signed-off-by: Shuah Khan shua...@osg.samsung.com
---
include/uapi/linux/media.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h
index 4e816be..4a30ea3 100644
Add new pad for ALSA Audio Out to au8522_media_pads. Move the
au8522_media_pads enum to au8522.h from au8522_priv.h. This will
allow au0828-core to use these defines instead of hard-coding the
pad values when it creates media graph linking decode pads to other
entities.
Signed-off-by: Shuah Khan
could be called in irq path. This issue needs to be resolved
before this patch can go in.
Signed-off-by: Shuah Khan shua...@osg.samsung.com
---
sound/usb/Makefile | 15 ++-
sound/usb/card.c | 5 +
sound/usb/card.h | 1 +
sound/usb/media.c| 260
Add support to recognize ALSA media nodes and generate
media graph that includes ALSA pcm and mixer devices.
This patch depends on kernel Media Controller changes
to support ALSA.
Signed-off-by: Shuah Khan shua...@osg.samsung.com
---
utils/media-ctl/libmediactl.c | 18 --
utils
functionality. Entity ops for entity_notify
doesn't handle and cover entity create ordering variations that
could occur during boot. entity_notify list has been moved to media
device level which makes the entity_notify calls to work correctly.
Shuah Khan (7):
Revert [media] media: media controller
-by: Shuah Khan shua...@osg.samsung.com
---
drivers/media/media-device.c | 45
include/media/media-device.h | 23 ++
2 files changed, 68 insertions(+)
diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c
index
Change dvb_frontend_thread() to honor MC tuner enable error and
return as opposed to ignoring the error and continuing to use it.
Signed-off-by: Shuah Khan shua...@osg.samsung.com
---
drivers/media/dvb-core/dvb_frontend.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git
This reverts commit ed64cf1e182fb30fe67652386c0880fcf3302f97.
This patch is no longer necessary as the entity register
callback is implemented at media_device level.
Signed-off-by: Shuah Khan shua...@osg.samsung.com
---
drivers/media/media-device.c | 7 ---
include/media/media-entity.h | 4
On 06/23/2015 09:05 PM, Shuah Khan wrote:
Hi Mauro,
I am seeing the following warning from au0828 - linux_media
media_controller branch:
drivers/media/usb/au0828/au0828-video.c: In function ‘queue_setup’:
drivers/media/usb/au0828/au0828-video.c:679:6: warning: ‘entity’ may be
used
.
In addition, au0828 registers entity_notify hook to create media
graph for the device. It creates necessary links from video, vbi,
and ALSA entities to decoder and links tuner and decoder entities.
Signed-off-by: Shuah Khan shua...@osg.samsung.com
---
drivers/media/usb/au0828/au0828-core.c | 132
On 07/20/2015 03:00 AM, Takashi Iwai wrote:
On Mon, 20 Jul 2015 10:47:46 +0200,
Dan Carpenter wrote:
On Tue, Jul 14, 2015 at 06:34:06PM -0600, Shuah Khan wrote:
+ ret = media_entity_setup_link(link, flags);
+ if (ret) {
+ dev_err(mctl-media_dev-dev
.
e.g: drivers/media/platform/exynos4-is/fimc-isp-video.c
Changes aren't complex, just that the scope isn't limited
to MC API.
Other ideas??
thanks,
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shua...@osg.samsung.com
On 07/20/2015 02:42 AM, Dan Carpenter wrote:
Sorry for this nit-pick and some time after you sent this patch. It's
not a redo the patch complaint, it's something that could be fixed
later.
On Tue, Jul 14, 2015 at 06:34:05PM -0600, Shuah Khan wrote:
@@ -131,10 +132,12 @@ static void
On 07/20/2015 01:01 PM, Dan Carpenter wrote:
On Mon, Jul 20, 2015 at 09:55:50AM -0600, Shuah Khan wrote:
#ifdef CONFIG_MEDIA_CONTROLLER
- if (dev-media_dev) {
- media_device_unregister(dev-media_dev);
- kfree(dev-media_dev);
- dev-media_dev = NULL;
+ if (dev
will see defined, but not used warning when DEBUG
and CONFIG_DYNAMIC_DEBUG are undefined.
Kind of related, maybe we should be looking into adding trace event
support for media as opposed to dynamic and debug.
thanks,
-- Shuah
+static void dev_dbg_obj(const char *event_name, struct media_gobj *gobj
)
+{
+ /* For now, nothing to do */
+}
+
This patch is mainly adding skeleton framework. Does this patch series
implement the media_gobj_init() and media_gobj_remove()?
If so, would it make sense to combine the implementation and the stubs?
thanks,
-- Shuah
+/**
+ * media_gobj_remove
,
-- Shuah
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
at the new link */
+ media_gobj_init(source-parent, MEDIA_GRAPH_LINK, link-graph_obj);
So far calls to media_gobj_init() are made holding mdev-lock. This
is the first
case without mdev-lock hold. This could lead race conditions as this routine
is changes fields in mdev.
thanks,
-- Shuah
On 10/22/2015 01:16 AM, Takashi Iwai wrote:
On Wed, 21 Oct 2015 01:25:15 +0200,
Shuah Khan wrote:
Add support for creating MEDIA_ENT_F_AUDIO_MIXER entity for
each mixer and a MEDIA_INTF_T_ALSA_CONTROL control interface
entity that links to mixer entities. MEDIA_INTF_T_ALSA_CONTROL
entity
Hi Mauro,
Could you please pull these 23 patches into the
mchehab_experimental/mc_next_gen.v8.4 to enable
easier reviews and tests on this work.
thanks,
-- Shuah
The following changes since commit 3e78030c0f16918bd095d550ecad6d06884b00dc:
[media] media-entity.c: get rid of var length arrays
media_stream_delete() doesn't remove intf_devnode. Fix it to
call media_devnode_remove() to remove the intf_devnode.
Signed-off-by: Shuah Khan <shua...@osg.samsung.com>
---
sound/usb/media.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/usb/media.c b/sound/usb/media.c
index 9
Change au0828_create_media_graph() to create pad link
between MEDIA_ENT_F_AUDIO_MIXER entity and decoder's
AU8522_PAD_AUDIO_OUT. With mixer entity now linked to
decoder, change to link MEDIA_ENT_F_AUDIO_CAPTURE to
mixer's source pad.
Signed-off-by: Shuah Khan <shua...@osg.samsung.
Fix media_stream_init() to free memory in error paths. Fix
media_stream_delete() to remove unnecessary set media_dev
pointer to null before free mctl.
Signed-off-by: Shuah Khan <shua...@osg.samsung.com>
---
sound/usb/media.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
?id=0B0NIL0BQg-AlLWE3SzAxazBJWm8=sharing
v4l2-utils patch adds mixer node support mc_next_gen_test tool:
https://www.mail-archive.com/linux-media@vger.kernel.org/msg93086.html
Shuah Khan (6):
sound/usb: Fix media_stream_delete() to remove intf devnode
sound/usb: Create media mixer function
Fix the following compile warning when CONFIG_MEDIA_CONTROLLER_DVB
is disabled:
drivers/media/dvb-core/dvb_frontend.c: In function 'dvb_frontend_open':
drivers/media/dvb-core/dvb_frontend.c:2526:1: warning: label 'err2'
defined but not used [-Wunused-label] err2:
Signed-off-by: Shuah Khan <s
Add support for creating MEDIA_ENT_F_AUDIO_MIXER entity for
each mixer and a MEDIA_INTF_T_ALSA_CONTROL control interface
entity that links to mixer entities. MEDIA_INTF_T_ALSA_CONTROL
entity corresponds to the control device for the card.
Signed-off-by: Shuah Khan <shua...@osg.samsung.
: ignoring
return value of 'media_device_register_entity_notify', declared
with attribute warn_unused_result [-Wunused-result]
Signed-off-by: Shuah Khan <shua...@osg.samsung.com>
---
drivers/media/usb/au0828/au0828-core.c | 21 -
1 file changed, 16 insertions(+), 5 del
On 11/11/2015 08:36 AM, Mauro Carvalho Chehab wrote:
> Em Wed, 11 Nov 2015 07:22:47 -0700
> Shuah Khan <shua...@osg.samsung.com> escreveu:
>
>> On 11/11/2015 05:30 AM, Mauro Carvalho Chehab wrote:
>>> Em Mon, 09 Nov 2015 08:55:06 -0700
>>> Shuah
On 11/11/2015 05:30 AM, Mauro Carvalho Chehab wrote:
> Em Mon, 09 Nov 2015 08:55:06 -0700
> Shuah Khan <shua...@osg.samsung.com> escreveu:
>
>> On 11/09/2015 08:51 AM, Shuah Khan wrote:
>>> As I mentioned on the IRC, here is the log for the problems I am seeing.
>
On 11/11/2015 05:25 PM, Shuah Khan wrote:
> On 11/11/2015 08:49 AM, Shuah Khan wrote:
>> On 11/11/2015 08:36 AM, Mauro Carvalho Chehab wrote:
>>> Em Wed, 11 Nov 2015 07:22:47 -0700
>>> Shuah Khan <shua...@osg.samsung.com> escreveu:
>>>
>>>&g
On 11/11/2015 08:49 AM, Shuah Khan wrote:
> On 11/11/2015 08:36 AM, Mauro Carvalho Chehab wrote:
>> Em Wed, 11 Nov 2015 07:22:47 -0700
>> Shuah Khan <shua...@osg.samsung.com> escreveu:
>>
>>> On 11/11/2015 05:30 AM, Mauro Carvalho Chehab wrote:
>>>&g
all media_device_unregister_entity()
for each entity. With this fix there is no kernel hang after
a sequence of device insertions followed by removal.
Signed-off-by: Shuah Khan <shua...@osg.samsung.com>
---
drivers/media/media-device.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/driv
On 11/16/2015 11:36 AM, Mauro Carvalho Chehab wrote:
> Em Mon, 16 Nov 2015 01:02:56 +0200
> Sakari Ailus <sakari.ai...@iki.fi> escreveu:
>
>> Hi Shuah,
>>
>> On Thu, Nov 12, 2015 at 07:41:47AM -0700, Shuah Khan wrote:
>>> Media core drivers (dvb, v4l2, br
On 11/12/2015 07:41 AM, Shuah Khan wrote:
> Media core drivers (dvb, v4l2, bridge driver) unregister
> their entities calling media_device_unregister_entity()
> during device removal from their unregister paths. In
> addition media_device_unregister() tries to unregister
>
On 11/17/2015 01:27 AM, Mauro Carvalho Chehab wrote:
> Em Mon, 16 Nov 2015 12:54:28 -0700
> Shuah Khan <shua...@osg.samsung.com> escreveu:
>
>> On 11/16/2015 11:36 AM, Mauro Carvalho Chehab wrote:
>>> Em Mon, 16 Nov 2015 01:02:56 +0200
>>> Sakari Ailus <
On 10/25/2015 03:37 PM, Shuah Khan wrote:
> On 10/22/2015 01:16 AM, Takashi Iwai wrote:
>> On Wed, 21 Oct 2015 01:25:15 +0200,
>> Shuah Khan wrote:
>>>
>>> Add support for creating MEDIA_ENT_F_AUDIO_MIXER entity for
>>> each mixer and a MEDIA_INTF_T
On 11/03/2015 09:23 AM, Takashi Iwai wrote:
> On Tue, 03 Nov 2015 17:06:45 +0100,
> Shuah Khan wrote:
>>
>> On 10/25/2015 03:37 PM, Shuah Khan wrote:
>>> On 10/22/2015 01:16 AM, Takashi Iwai wrote:
>>>> On Wed, 21 Oct 2015 01:25:15 +0200,
>>>> Shu
f0
0f 31 <48> c1 e2 20 89 c0 48 09 c2 89 d0 29 ca 39 fa 73 1c f3 90 65 8b
[ 1323.553480] device: '0:40': device_add
[ 1323.553532] PM: Adding info for No Bus:0:40
--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shua...@osg.samsu
Change au0828_create_media_graph() to create pad link
between MEDIA_ENT_F_AUDIO_MIXER entity and decoder's
AU8522_PAD_AUDIO_OUT.
Signed-off-by: Shuah Khan <shua...@osg.samsung.com>
---
drivers/media/usb/au0828/au0828-core.c | 12
drivers/media/usb/au0828/au0828.h |
/msg92752.html
Please find the media graph with mixer and control interface nodes:
https://drive.google.com/folderview?id=0B0NIL0BQg-Alb3JFb2diMXRoQlU=sharing
New file:
graph_mixer.png
Shuah Khan (2):
sound/usb: Create media mixer function and control interface entities
media: au0828 create link
Add support for creating MEDIA_ENT_F_AUDIO_MIXER entity for
each mixer and a MEDIA_INTF_T_ALSA_CONTROL control interface
entity that links to mixer entities. MEDIA_INTF_T_ALSA_CONTROL
entity corresponds to the control device for the card.
Signed-off-by: Shuah Khan <shua...@osg.samsung.
Add support for ALSA capture, playback, and mixer entity functions.
Signed-off-by: Shuah Khan <shua...@osg.samsung.com>
---
contrib/test/mc_nextgen_test.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/contrib/test/mc_nextgen_test.c b/contrib/test/mc_nextgen_test.c
index e
Add support for creating MEDIA_ENT_F_AUDIO_MIXER entity for
each mixer and a MEDIA_INTF_T_ALSA_CONTROL control interface
entity that links to mixer entities. MEDIA_INTF_T_ALSA_CONTROL
entity corresponds to the control device for the card.
Signed-off-by: Shuah Khan <shua...@osg.samsung.
Change au0828_create_media_graph() to create pad link
between MEDIA_ENT_F_AUDIO_MIXER entity and decoder's
AU8522_PAD_AUDIO_OUT. With mixer entity now linked to
decoder, change to link MEDIA_ENT_F_AUDIO_CAPTURE to
mixer's source pad.
Signed-off-by: Shuah Khan <shua...@osg.samsung.
, and au0828 drivers to use Managed Media Controller API:
https://www.mail-archive.com/linux-media@vger.kernel.org/msg92752.html
Please find the media graphs for ALSA work with mixer and control
interface nodes:
https://drive.google.com/folderview?id=0B0NIL0BQg-AlLWE3SzAxazBJWm8=sharing
Shuah Khan (3
media_stream_delete() doesn't remove intf_devnode. Fix it to
call media_devnode_remove() to remove the intf_devnode.
Signed-off-by: Shuah Khan <shua...@osg.samsung.com>
---
sound/usb/media.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/usb/media.c b/sound/usb/media.c
index 9
media-ctl.
thanks,
-- Shuah
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
...@osg.samsung.com
Changes look good to me. After fixing the commit log:
Acked-by: Shuah Khan shua...@osg.samsung.com
thanks,
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shua...@osg.samsung.com | (970) 217-8978
DVB and V4L modules and creates entities during
probe and maybe even links during probe with no specific probe ordering between
individual module probes. This way we are sure we need this code and know that
it is correct.
thanks,
-- Shuah
--
To unsubscribe from this list: send the line unsubscribe
sprintf(pcm->name, "USB Audio #%d", chip->pcm_devs);
else
The device Bus 003 Device 002: ID 2040:7200 Hauppauge
Please let me know if you need more information and any ideas on
how to fix this problem.
thanks,
-- Shuah
[ 120.283960] =
On 09/01/2015 02:42 AM, Clemens Ladisch wrote:
> Shuah Khan wrote:
>> +++ b/sound/usb/stream.c
>> pcm->private_data = as;
>> pcm->private_free = snd_usb_audio_pcm_free;
>> pcm->info_flags = 0;
>> + pcm->nonatomic = true;
>
> Why do you th
>> If you're interested in participate and wants to be invited for the event,
>> please put your data at this document:
>> https://docs.google.com/spreadsheets/d/1YecCAUo0L1R_i3jPg3S->
>> A5iqX7BYAd2c_VfJctQmr88/edit?usp=sharing
>
> The document can be edited withou
On 09/01/2015 11:53 AM, Clemens Ladisch wrote:
> Shuah Khan wrote:> On 09/01/2015 02:42 AM, Clemens Ladisch wrote:
>>> Shuah Khan wrote:
>>>> +++ b/sound/usb/stream.c
>>>> pcm->private_data = as;
>>>> pcm->private_free = snd_usb_audio_
Acked-by: Hans Verkuil hans.verk...@cisco.com
The change looks good to me. I would really like to see a before and after
media graph with these changes, this patch and series in general.
thanks,
-- Shuah
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message
MEDIA_INTF_T_ALSA_RAWMIDI (MEDIA_INTF_T_ALSA_BASE + 4)
+#define MEDIA_INTF_T_ALSA_HWDEP (MEDIA_INTF_T_ALSA_BASE + 5)
Is it necessary to add ALSA types at this time without ALSA media
controller work?
Can these be added later when ALSA work is done.
thanks,
-- Shuah
--
To unsubscribe from
remove support in phase2 after the
patches 1-15 in this
series that add the graph object and the API changes that go with it
through some
use-cases before adding support for remove.
That way we have confidence in the patch set 1-15 and then we can
build on top with
solid foundation.
thanks,
-- Shuah
there is always a need to cleanup and tweak with
this type of support added in anticipation future work without having a
reference implementation to support it.
This is the same comment I made on
13/44] [media] uapi/media.h: Declare interface types
thanks,
Shuah
--
To unsubscribe from this list: send
ine interface.
Signed-off-by: Shuah Khan <shua...@osg.samsung.com>
---
drivers/media/media-entity.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c
index eaeda25..797b7b3 100644
--- a/drivers/me
au0828_enable_analog_tuner() is no longer needed with
v4l2-core and au0828-video invoking enable_source and
disable_source handlers. In addition, it is unnecessary
to check for tuner availability in queue_setup() as
v4l2-core handles the tuner availability checks.
Signed-off-by: Shuah Khan <s
Implements enable_source and disable_source handlers for other
drivers (v4l2-core, dvb-core, and ALSA) to use to check for
tuner connected to the decoder and activate the link if tuner
is free, and deactivate and free the tuner when it is no longer
needed.
Signed-off-by: Shuah Khan <s
-by: Shuah Khan <shua...@osg.samsung.com>
---
drivers/media/media-device.c | 43 +++
include/media/media-device.h | 25 +
2 files changed, 68 insertions(+)
diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c
Add ALSA Media Controller capture, playback, and mixer
function entity defines.
Signed-off-by: Shuah Khan <shua...@osg.samsung.com>
---
include/uapi/linux/media.h | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/include/uapi/linux/media.h b/include/uapi/linux/m
is activated
and pipeline is started. The disable_source helper function
invokes the disable_source handler to deactivate and stop the
pipeline.
Signed-off-by: Shuah Khan <shua...@osg.samsung.com>
---
drivers/media/v4l2-core/v4l2-dev.c | 27 +++
include/media/v4l2
.
Signed-off-by: Shuah Khan <shua...@osg.samsung.com>
---
drivers/media/usb/au0828/au0828-core.c | 45 +-
1 file changed, 22 insertions(+), 23 deletions(-)
diff --git a/drivers/media/usb/au0828/au0828-core.c
b/drivers/media/usb/au0828/au0828-core.c
index 4
Add new pad for ALSA Audio Out to au8522_media_pads.
Signed-off-by: Shuah Khan <shua...@osg.samsung.com>
---
drivers/media/dvb-frontends/au8522.h | 1 +
drivers/media/dvb-frontends/au8522_decoder.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/media/dvb-frontends/au
__media_entity_pipeline_stop() holding the graph_lock.
Signed-off-by: Shuah Khan <shua...@osg.samsung.com>
---
drivers/media/media-entity.c | 45 +---
include/media/media-entity.h | 3 +++
2 files changed, 33 insertions(+), 15 deletions(-)
diff --git a/drivers/media/media-en
as it is no
longer necessary with dvb invoking enable_source and
disable_source handlers. pipe_start_entity field is removed
and pipe field is moved to dvb_frontend from dvb_frontend_private.
Signed-off-by: Shuah Khan <shua...@osg.samsung.com>
---
drivers/media/dvb-core/dvb_frontend.c
added, it has to maintain
state on the links it already created. New fields are added to
au0828_dev to keep this state information. entity_notify gets
unregistered before media_device unregister.
Signed-off-by: Shuah Khan <shua...@osg.samsung.com>
---
drivers/media/usb/au0828/au0828-core.c
v4l2_fh_exit() to release the tuner.
Signed-off-by: Shuah Khan <shua...@osg.samsung.com>
---
drivers/media/v4l2-core/v4l2-fh.c| 1 +
drivers/media/v4l2-core/v4l2-ioctl.c | 29 +
drivers/media/v4l2-core/videobuf2-core.c | 3 +++
3 files changed, 33 inse
Export __media_entity_setup_link() to be used from code paths that hold
the graph_mutex.
Signed-off-by: Shuah Khan <shua...@osg.samsung.com>
---
drivers/media/media-entity.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c
Move the au8522_media_pads enum to au8522.h from au8522_priv.h.
This will allow au0828-core to use these defines instead of
hard-coding the pad values when it creates media graph linking
decode pads to other entities.
Signed-off-by: Shuah Khan <shua...@osg.samsung.com>
---
drivers/med
field before creating
pad links.
Signed-off-by: Shuah Khan <shua...@osg.samsung.com>
---
drivers/media/usb/au0828/au0828-core.c | 28 ++--
1 file changed, 18 insertions(+), 10 deletions(-)
diff --git a/drivers/media/usb/au0828/au0828-core.c
b/drivers/media/usb/
down to save energy.
Signed-off-by: Shuah Khan <shua...@osg.samsung.com>
---
drivers/media/usb/au0828/au0828-video.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/media/usb/au0828/au0828-video.c
b/drivers/media/usb/au0828/au0828-video.c
index 0
if one is
provided by the bridge driver prior to starting Media
pipeline from snd_usb_hw_params(). If enable_source returns
with tuner busy condition, then snd_usb_hw_params() will fail
with -EBUSY. Media pipeline is stopped from snd_usb_hw_free().
Signed-off-by: Shuah Khan <shua...@osg.samsung.
@vger.kernel.org/msg89492.html
https://www.mail-archive.com/linux-media%40vger.kernel.org/msg89493.html
Shuah Khan (20):
media: Media Controller register/unregister entity_notify API
media: Add ALSA Media Controller function entities
media: Media Controller enable/disable source handler API
Change au0828-core to use au8522_media_pads enum defines
instead of hard-coding the pad values when it creates
media graph linking decode pads to other entities.
Signed-off-by: Shuah Khan <shua...@osg.samsung.com>
---
drivers/media/usb/au0828/au0828-core.c | 7 +--
1 file chan
device.
Signed-off-by: Shuah Khan <shua...@osg.samsung.com>
---
include/media/media-device.h | 19 +++
1 file changed, 19 insertions(+)
diff --git a/include/media/media-device.h b/include/media/media-device.h
index bc53f4f..9a53b19 100644
--- a/include/media/media-device.h
Create tuner to demod pad link in disabled state to help avoid
disable step when tuner resource is requested by video or audio.
Signed-off-by: Shuah Khan <shua...@osg.samsung.com>
---
drivers/media/dvb-core/dvbdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/d
mc_nextgen_test -d option doesn't work due to a missing break.
Fix the bug so -d, --device=DEVICE option can accept a device
name. Without this fix, mc_nextgen_test assumes default device
name.
Signed-off-by: Shuah Khan <shua...@osg.samsung.com>
---
contrib/test/mc_nextgen_test.c | 1 +
201 - 300 of 661 matches
Mail list logo
