Re: Kworld 340U (1b80:a340) kernel 4.8.0 ERROR: i2c_transfer returned: -6

Hi Kumar, I don't have time for the em28xx driver at the moment (and I also do not have access to a device with tda18271 tuner). But... Am 08.07.2017 um 22:29 schrieb Kumar Vivek: > New subscriber and first time poster. I have tried to read most of the > instructions and etiquettes regarding

Re: [PATCH v3 1/2] em28xx: Ignore errors while reading from eeprom

ruct em28xx *dev, unsigned bus, > dev_err(>intf->dev, > "%s: em28xx_i2_eeprom failed! retval [%d]\n", > __func__, retval); > - > - return retval; > } > } > Makes sense. Acked-by: Frank Schäfer <fschaefer@googlemail.com>

Re: [PATCH v3 2/2] em28xx: add support for new of Terratec H6

Am 03.05.2017 um 04:12 schrieb Mauro Carvalho Chehab: > There's a new version of Terratec H6 with uses USB ID > 0ccd:10b2. This version is similar to the old one (with is > supported via the HTC entry), except that this one has the > eeprom on the second bus. Last half of the sentence isn't true

Re: [PATCH 1/2] em28xx: allow setting the eeprom bus at cards struct

Am 01.05.2017 um 19:54 schrieb Mauro Carvalho Chehab: > Hi Frank, > > Em Mon, 1 May 2017 16:11:51 +0200 > Frank Schäfer <fschaefer@googlemail.com> escreveu: > >> Am 01.05.2017 um 13:38 schrieb Mauro Carvalho Chehab: >>> Right now, all devices use bus 0 for

Re: [PATCH 1/2] em28xx: allow setting the eeprom bus at cards struct

Am 01.05.2017 um 13:38 schrieb Mauro Carvalho Chehab: > Right now, all devices use bus 0 for eeprom. However, newer > versions of Terratec H6 use a different buffer for eeprom. > > So, add support to use a different I2C address for eeprom. Has this been tested ? Did you read my reply to the

Re: em28xx module: misidentified card

Am 28.04.2017 um 13:22 schrieb Giuseppe Toscano: > I am trying to use eMPIA Technology, Inc. GrabBeeX+ Video Encoder > (card=21) but the em28xx driver erroneously identifies it as > EM2860/SAA711X Reference Design (card = 19). > Attached the output of lsusb and dmesg. > Card 21 is an em2800

em28xx debug module parameters

Hi Mauro, is there a chance that we can clean up the em28xx debug module parameter mess ? There are currently 8 (!) of them. Do we have to maintain them all forever as "stable userspace interface" ? For example: - "reg_debug" is actually used for usb control message debugging - "core_debug" is

[PATCH] em28xx: fix+improve the register (usb control message) debugging

- avoid duplicate debugging messages in em28xx_read_reg_req_len() - do not describe successful usb transfers in em28xx_read_reg_len() as "failed" - report errors in em28xx_write_regs_req(), too - print the usb error numbers, too Signed-off-by: Frank Schäfer <fschaefer@g

Re: [PATCH] [RFC] em28xx: allow setting the eeprom bus at cards struct

Am 25.04.2017 um 12:06 schrieb Mauro Carvalho Chehab: > Right now, all devices use bus 0 for eeprom. However, > it seems that newer versions of Terratec H6 uses a different > buffer for eeprom. > > So, add support to use a different I2C address for eeprom and > add a new card ID for the board

Re: em28xx i2c writing error

Am 15.04.2017 um 20:28 schrieb Anders Eriksson: > Hi Mauro, > > I've two devices using this driver, and whenever I have them both in > use I eventually (between 10K and 100K secs uptime) i2c write errors > such as in the log below. If only have one of the devices in use, the > machine is stable.

[PATCH v2] em28xx: simplify ID-reading from Micron sensors

es the ID as if they were read in big-endian. So, we need to change the byte order in order to match the ID number as described on their datasheets. Signed-off-by: Frank Schäfer <fschaefer@googlemail.com> Acked-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/me

[PATCH 5/7] ov2640: fix duplicate width+height returning from ov2640_select_win()

ov2640_select_win() returns height and width values as part of struct ov2640_win_size, so there is no point in modifying the passed height and width parameters, too. Signed-off-by: Frank Schäfer <fschaefer@googlemail.com> --- drivers/media/i2c/ov2640.c | 18 +++--- 1 file c

[PATCH 7/7] ov2640: add support for MEDIA_BUS_FMT_YVYU8_2X8 and MEDIA_BUS_FMT_VYUY8_2X8

Signed-off-by: Frank Schäfer <fschaefer@googlemail.com> --- drivers/media/i2c/ov2640.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/media/i2c/ov2640.c b/drivers/media/i2c/ov2640.c index 6aba0ffe486d..618230e782e7 100644 --- a/drivers/media/i2c/ov2640.c

[PATCH 6/7] ov2640: fix vflip control

is that the current documentation of sensor register 0x04 is wrong (has changed after preliminary datasheet version 2.2). I'm pretty sure that automatic vertical line shift/switch can be enabled, too, but until anyone finds ot how this works, we have to stick with manual switching. Signed-off-by: Frank Schäfer

[PATCH 4/7] ov2640: add missing write to size change preamble

HSIZE and VSIZE bits 0 to 2 and HSIZE bit 11 are encoded in DSP register SIZEL. Signed-off-by: Frank Schäfer <fschaefer@googlemail.com> --- drivers/media/i2c/ov2640.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/i2c/ov2640.c b/drivers/media/i2c/ov2640.c

[PATCH 3/7] ov2640: add information about DSP register 0xc7

. large blue background) 2) Advanced AWB: uses color temperature information + more accurate, works with all image contents - lens specific, requires calibration Signed-off-by: Frank Schäfer <fschaefer@googlemail.com> --- drivers/media/i2c/ov2640.c | 6 +- 1 file changed, 5 inse

[PATCH 2/7] ov2640: improve banding filter register definitions/documentation

- add missing initialisation of sensor register COM25 (2 MSBs of banding filter AEC values) - add macros for setting the banding filter AEC values - add definitions for sensor register 0x5a, which is documented in Omnivisions software application notes Signed-off-by: Frank Schäfer <fschae

[PATCH 0/7] ov2640 fixes and improvements

First 5 patches are minor fixes/cleanups/improvements which I came across while testing Hans Verkuils patches and trying to figure out what's going wrong with vflip control. Patch 6 finally fixes the vflip bug. Patch 7 adds support for 2 new pixel formats. Frank Schäfer (7): ov2640: fix init

[PATCH 1/7] ov2640: fix init sequence alignment

While we are at it, remove a misleading comment (copy/paste mistake) Signed-off-by: Frank Schäfer <fschaefer@googlemail.com> --- drivers/media/i2c/ov2640.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/media/i2c/ov2640.c b/d

[PATCH 2/5] em28xx: add missing auto-selections for build

With MEDIA_SUBDRV_AUTOSELECT enabled in the kernel config, the em28xx driver currently does't select some used subdrivers. Fix this by adding the missing auto-selections to the Kconfig file. Signed-off-by: Frank Schäfer <fschaefer@googlemail.com> --- drivers/media/usb/em28xx/Kconf

[PATCH 1/5] em28xx: get rid of the dummy clock source

The v4l2 dummy clock has been added with commit fc5d0f8a8878 ("V4L2: em28xx: register a V4L2 clock source") to be able to use the ov2640 soc_camera driver. Since commit 46796cfcd346 ("ov2640: use standard clk and enable it") it is no longer required. Signed-off-by: Fran

[PATCH 4/5] em28xx: shed some light on video input formats

with these two camera devices and 0x08-0x0b are at least 16 bits per pixel formats on em2710/em2820, too, and 0x0c-0x0f are at least 8 bits per pixel formats on em2765, too. Signed-off-by: Frank Schäfer <fschaefer@googlemail.com> --- drivers/media/usb/em28xx/em28xx-camera.c | 10 -- drivers

[PATCH 3/5] em28xx: don't treat device as webcam if an unknown sensor is detected

is very low and therefore not worth the efforts. Instead, just don't treat the device as camera. A message will then be printed to the log that the device isn't supported. Signed-off-by: Frank Schäfer <fschaefer@googlemail.com> --- drivers/media/usb/em28xx/em28xx-cards.c | 10 +++---

[PATCH 5/5] em28xx: add support for V4L2_PIX_FMT_SRGGB8

Signed-off-by: Frank Schäfer <fschaefer@googlemail.com> --- drivers/media/usb/em28xx/em28xx-video.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/media/usb/em28xx/em28xx-video.c b/drivers/media/usb/em28xx/em28xx-video.c index aaa83f9e5c1a..8d253a5df0a9 100644 --- a/d

Re: [PATCH 2/2] em28xx: simplify ID-reading from Micron sensors

Am 26.03.2017 um 16:24 schrieb Frank Schäfer: > > > Am 24.03.2017 um 20:16 schrieb Mauro Carvalho Chehab: >> Em Thu, 23 Mar 2017 19:03:20 +0100 >> Frank Schäfer <fschaefer@googlemail.com> escreveu: >> >>> Am 23.03.2017 um 13:56 schrieb Mauro Carvalho

Re: [PATCH 2/2] em28xx: simplify ID-reading from Micron sensors

Am 24.03.2017 um 20:16 schrieb Mauro Carvalho Chehab: Em Thu, 23 Mar 2017 19:03:20 +0100 Frank Schäfer <fschaefer@googlemail.com> escreveu: Am 23.03.2017 um 13:56 schrieb Mauro Carvalho Chehab: Em Thu, 23 Mar 2017 13:01:32 +0100 Frank Schäfer <fschaefer@googlemail.com&

Re: [PATCH 2/2] em28xx: simplify ID-reading from Micron sensors

Am 23.03.2017 um 13:56 schrieb Mauro Carvalho Chehab: Em Thu, 23 Mar 2017 13:01:32 +0100 Frank Schäfer <fschaefer@googlemail.com> escreveu: Am 22.03.2017 um 15:46 schrieb Mauro Carvalho Chehab: Em Sun, 19 Feb 2017 19:29:18 +0100 Frank Schäfer <fschaefer@googlemail.com&

Re: [PATCH 2/2] em28xx: simplify ID-reading from Micron sensors

Am 22.03.2017 um 15:46 schrieb Mauro Carvalho Chehab: Em Sun, 19 Feb 2017 19:29:18 +0100 Frank Schäfer <fschaefer@googlemail.com> escreveu: Use i2c_smbus_read_word_data() instead of i2c_master_send() and i2c_master_recv() for reading the ID of Micorn sensors. Bytes need to be s

Re: [PATCHv3 10/15] ov2640: convert from soc-camera to a standard subdev sensor driver.

Am 06.03.2017 um 15:56 schrieb Hans Verkuil: From: Hans Verkuil Convert ov2640 to a standard subdev driver. The soc-camera driver no longer uses this driver, so it can safely be converted. Note: the s_power op has been dropped: this never worked. When the last open()

Re: em28xx: new board id [1d19:6901]

Am 27.02.2017 um 21:21 schrieb Łukasz Strzeszkowski: Hi, I’ve found a new device which is not listed model: LogiLink VG0011 vendor/product: [1d19:6901] Dexatek Technology Ltd. mode: analog I am unable to load a driver, because there is no such vendor in driver list. dmesg output: [

[PATCH 2/2] em28xx: simplify ID-reading from Micron sensors

with 16 bit register width use big endian byte order. Signed-off-by: Frank Schäfer <fschaefer@googlemail.com> --- drivers/media/usb/em28xx/em28xx-camera.c | 28 1 file changed, 4 insertions(+), 24 deletions(-) diff --git a/drivers/media/usb/em28xx/em28xx-ca

[PATCH 1/2] em28xx: reduce stack usage in sensor probing functions

.de> Signed-off-by: Frank Schäfer <fschaefer@googlemail.com> --- drivers/media/usb/em28xx/em28xx-camera.c | 42 +++- 1 file changed, 20 insertions(+), 22 deletions(-) diff --git a/drivers/media/usb/em28xx/em28xx-camera.c b/drivers/media/usb/em28xx/em28xx-ca

Re: [PATCH 2/4] [media] em28xx: reduce stack usage in probe functions

Hi Arnd, Am 13.02.2017 um 15:00 schrieb Hans Verkuil: Hi Arnd, I'll take the others of this patch series, but will postpone this one until it has been tested. I've asked Frank to see if he can test it, if not, then it will have to wait until March when I have access to an omnivision-em28xx

Re: [PATCH 1/8] [media] em28xx: fix em28xx-input removal

Am 20.12.2014 um 15:51 schrieb Russell King - ARM Linux: On Sat, Dec 20, 2014 at 03:11:54PM +0100, Frank Schäfer wrote: Hi Russel, I guess you won't mind if I mis-spell your name too... Wow... it seems to be very easy to offend you... Sorry, that was definitely not my intention. I did not do

Re: [PATCH 0/8] Fix issues in em28xx

/usb/em28xx/em28xx-dvb.c | 14 +++--- drivers/media/usb/em28xx/em28xx-input.c | 9 - drivers/media/usb/em28xx/em28xx-video.c | 6 +++--- 5 files changed, 20 insertions(+), 21 deletions(-) Reviewed-by: Frank Schäfer fschaefer@googlemail.com -- To unsubscribe from this list

Re: [PATCH 0/8] Fix issues in em28xx

Am 20.12.2014 um 13:44 schrieb Russell King - ARM Linux: It isn't clear who is the maintainer for this driver; there is no MAINTAINERS entry. If there is a maintainer, please ensure that they add themselves to this critical file. Thanks. (line 3598) EM28XX VIDEO4LINUX DRIVER M:Mauro

[PATCH] dvb_usb_af9005: fix kernel panic on init if the driver is compiled in without IR symbols

that it fixes the reported bug. Reported-by: Fengguag Wu fengguang...@intel.com Signed-off-by: Frank Schäfer fschaefer@googlemail.com Cc: sta...@vger.kernel.org --- drivers/media/usb/dvb-usb/af9005.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/usb/dvb-usb/af9005.c b

Re: [media/dvb_usb_af9005] BUG: unable to handle kernel paging request (WAS: [media/em28xx] BUG: unable to handle kernel)

Am 23.09.2014 um 23:03 schrieb Luca Olivetti: El 23/09/14 20:52, Frank Schäfer ha escrit: This seems to be an ancient bug, which is known at least since 5 1/2 years: https://lkml.org/lkml/2009/2/4/350 [...] #if defined(CONFIG_MODULE) || defined(CONFIG_DVB_USB_AF9005_REMOTE) What happens

Re: [PATCH 2/2] em28xx: fix VBI handling logic

Am 24.09.2014 um 01:18 schrieb Mauro Carvalho Chehab: Em Tue, 23 Sep 2014 21:32:02 +0200 Frank Schäfer fschaefer@googlemail.com escreveu: Am 19.09.2014 um 18:02 schrieb Mauro Carvalho Chehab: When both VBI and video are streaming, and video stream is stopped, a subsequent trial

Re: [patch] [media] em28xx-input: NULL dereference on error

Hi Dan, Am 25.09.2014 um 13:39 schrieb Dan Carpenter: We call kfree(ir-i2c_client); in the error handling and that doesn't work if ir is NULL. Fixes: 78e719a5f30b ('[media] em28xx-input: i2c IR decoders: improve i2c_client handling') Signed-off-by: Dan Carpenter dan.carpen...@oracle.com

Re: [PATCH 2/2] em28xx: fix VBI handling logic

(Resending because my crappy modem crashed while sending) Am 25.09.2014 um 16:07 schrieb Mauro Carvalho Chehab: Em Thu, 25 Sep 2014 15:59:12 +0200 Frank Schäfer fschaefer@googlemail.com escreveu: Am 24.09.2014 um 01:18 schrieb Mauro Carvalho Chehab: Em Tue, 23 Sep 2014 21:32:02 +0200

Re: [patch] [media] em28xx-input: NULL dereference on error

Am 25.09.2014 um 16:49 schrieb Dan Carpenter: On Thu, Sep 25, 2014 at 04:08:31PM +0200, Frank Schäfer wrote: ir = kzalloc(sizeof(*ir), GFP_KERNEL); + if (!ir) + return -ENOMEM; rc = rc_allocate_device(); - if (!ir || !rc) + if (!rc) goto error

Re: [PATCH 4/4] em28xx: get rid of structs em28xx_ac97_mode and em28xx_audio_mode

Am 23.09.2014 um 02:02 schrieb Mauro Carvalho Chehab: Em Sat, 13 Sep 2014 10:52:22 +0200 Frank Schäfer fschaefer@googlemail.com escreveu: Now that we have enum em28xx_int_audio (none/i2s/ac97), it is no longer necessary to check dev-audio_mode.ac97 to determine the type of internal

Re: [linuxtv-media:devel-3.17-rc6 491/499] drivers/media/usb/em28xx/em28xx.h:787:2: warning: 'vid' may be used uninitialized in this function

Am 23.09.2014 um 04:27 schrieb kbuild test robot: tree: git://linuxtv.org/media_tree.git devel-3.17-rc6 head: 7f8de65b0dc84c19e79d7a642a5655524c57035c commit: f5ac7a471e156f997833f94bad2228e57122c227 [491/499] [media] em28xx: remove some unnecessary fields from struct em28xx_audio_mode

Re: [media/dvb_usb_af9005] BUG: unable to handle kernel paging request (WAS: [media/em28xx] BUG: unable to handle kernel)

Am 19.09.2014 um 21:55 schrieb Luca Olivetti: El 19/09/14 21:22, Frank Schäfer ha escrit: So symbol_request() returns pointers.!= NULL A closer look at the definition of symbol_request() shows, that it does nothing if CONFIG_MODULES is disabled (it just returns its argument). One

Re: [PATCH 2/2] em28xx: fix VBI handling logic

Am 19.09.2014 um 18:02 schrieb Mauro Carvalho Chehab: When both VBI and video are streaming, and video stream is stopped, a subsequent trial to restart it will fail, because S_FMT will return -EBUSY. That prevents applications like zvbi to work properly. Please notice that, while this fix

Re: [media/em28xx] BUG: unable to handle kernel

to struct em28xx_audio Both wq_trigger and stream_started are used only to control the em28xx alsa streaming. They don't belong to em28xx common struct. Signed-off-by: Frank Schäfer fschaefer@googlemail.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com

[media/dvb_usb_af9005] BUG: unable to handle kernel paging request (WAS: [media/em28xx] BUG: unable to handle kernel)

(adjusting the title and adding Luca Olivetti (dvb_usb_af9005 author) and Antti Palosaari) Am 19.09.2014 um 21:01 schrieb Frank Schäfer: Hi Fengguang, thank you for reporting this issue. Am 19.09.2014 um 03:41 schrieb Fengguang Wu: [...] [8.528015] usbcore: registered new interface

Re: [PATCH 4/4] em28xx-v4l: get rid of field users in struct em28xx_v4l2

Hi Hans, Am 18.09.2014 um 21:13 schrieb Hans Verkuil: Hi Frank, On 07/25/2014 07:48 PM, Frank Schäfer wrote: Instead of counting the number of opened file handles, use function v4l2_fh_is_singular_file() in em28xx_v4l2_open() and em28xx_v4l2_close() to determine if the file handle

[PATCH for 3.17] Revert [media] em28xx-v4l: get rid of field users in struct em28xx_v4l2

node is open and a second device node is opened (closed), the device is reinitialized (streaming is stopped). Reported-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-video.c | 23 ++- drivers

[PATCH 0/4] em28xx: clean up the audio variable mess

. This simplifies the audio code a lot, making it much more self-explaining and easier to understand. It will hopefully reduce the risk of audio regression in the future. Frank Schäfer (4): em28xx: remove some unnecessary fields from struct em28xx_audio_mode em28xx: simplify usb audio class handling

[PATCH 3/4] em28xx: get rid of field has_audio in struct em28xx_audio_mode

which describes the internal audio type (none, ac97, i2s) and is hooked directly to the device struct. Then get rid of field has_audio in struct em28xx_audio_mode. A follow-up patch will then remove struct em28xx_ac97_mode and finally the whole struct em28xx_audio_mode. Signed-off-by: Frank Schäfer

[PATCH 1/4] em28xx: remove some unnecessary fields from struct em28xx_audio_mode

Fields ac97_feat, ac97_vendor_id and i2s_samplerates of struct em28xx_audio_mode are used nowhere, except in function em28xx_audio_setup(). So get rid of them and use local variables instead. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-core.c

[PATCH 2/4] em28xx: simplify usb audio class handling

by replacing fields has_audio_class (device has usb audio class compliant interface) and has_alsa_audio (device has vendor audio interface) in struct em28xx with a single enum em28xx_usb_audio_type. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx

[PATCH] em28xx: remove dead code line from em28xx_audio_setup()

Setting the value of the chip config register to EM28XX_CHIPCFG_AC97 in case of a read error is a leftover from the past which is no longer needed. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-core.c | 5 ++--- 1 file changed, 2 insertions(+), 3

Re: strange empia device

Am 02.09.2014 um 08:28 schrieb Lorenzo Marcantonio: On Mon, Sep 01, 2014 at 07:58:52PM -0400, Andy Walls wrote: A Merlin firmware of 16 kB strongly suggests that this chip has an integarted Conexant CX25843 (Merlin Audio + Thresher Video = Mako) Broadtcast A/V decoder core. The chip might

Re: strange empia device

Am 31.08.2014 um 17:41 schrieb Lorenzo Marcantonio: On Sun, Aug 31, 2014 at 04:50:08PM +0200, Frank Schäfer wrote: Hmm... could you send us the output of lsusb -v -d 1b80:e31d ? Sure, here is it. However it seems that roxio violated the most sacred USB rule (i.e. they use that vid/pid for two

Re: HVR 900 (USB ID 2040:6500) no analogue sound reloaded

Am 01.09.2014 um 09:31 schrieb Oravecz Csaba: Sun Aug 31 17:07:00 2014 =?windows-1252?Q?Frank_Sch=E4fer?= kirjutas: Am 22.08.2014 um 21:03 schrieb Oravecz Csaba: I reported this issue earlier but for some reason it went pretty much unnoticed. The essence is that with the newest em28xx

[PATCH for 3.17] Revert [media] em28xx: check if a device has audio earlier

Tested-by: Oravecz Csaba orav...@nytud.mta.hu Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-cards.c | 11 --- drivers/media/usb/em28xx/em28xx-core.c | 12 +++- 2 files changed, 11 insertions(+), 12 deletions(-) diff --git a/drivers

Re: strange empia device

Am 01.09.2014 um 21:03 schrieb Lorenzo Marcantonio: On Mon, Sep 01, 2014 at 08:14:25PM +0200, Frank Schäfer wrote: What's the other device using this vid:pid and which hardware does it use ? The previous generation of the tool: http://www.linuxtv.org/wiki/index.php/RoxioEasyVHStoDVD

Re: strange empia device

Hi Lorenzo, Am 25.08.2014 um 21:01 schrieb Lorenzo Marcantonio: Just bought a roxio video capture dongle. Read around that it was an easycap clone (supported, then); it seems it's not so anymore :( It identifies as 1b80:e31d Roxio Video Capture USB (it also uses audio class for audio) Now

Re: strange empia device

Am 31.08.2014 um 16:47 schrieb Frank Schäfer: Hi Lorenzo, Am 25.08.2014 um 21:01 schrieb Lorenzo Marcantonio: Just bought a roxio video capture dongle. Read around that it was an easycap clone (supported, then); it seems it's not so anymore :( It identifies as 1b80:e31d Roxio Video Capture

Re: HVR 900 (USB ID 2040:6500) no analogue sound reloaded

Am 22.08.2014 um 21:03 schrieb Oravecz Csaba: I reported this issue earlier but for some reason it went pretty much unnoticed. The essence is that with the newest em28xx drivers now present in 3.14 kernels (i'm on stock fedora 3.14.15-100.fc19.i686.PAE) I can't get analogue sound from this

Re: [PATCH] em28xx: fix compiler warnings

Am 09.08.2014 um 11:58 schrieb Hans Verkuil: On 08/07/2014 06:36 PM, Frank Schäfer wrote: Am 07.08.2014 um 08:45 schrieb Hans Verkuil: On 08/05/2014 05:18 PM, Frank Schäfer wrote: Hi Hans, Am 05.08.2014 um 09:00 schrieb Hans Verkuil: Fix three compiler warnings: drivers/media/usb/em28xx

[PATCH] em28xx-input: i2c IR decoders: improve i2c_client handling

a bit. Also make sure that all fields of struct i2c_client are initialized properly. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-input.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/drivers/media/usb

[PATCH 2/2] em28xx-v4l: fix video buffer field order reporting in progressive mode

The correct field order in progressive mode is V4L2_FIELD_NONE, not V4L2_FIELD_INTERLACED. Cc: sta...@vger.kernel.org Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-video.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH 1/2] em28xx-v4l: give back all active video buffers to the vb2 core properly on streaming stop

recently added check in the vb2 core unveiled this long standing issue and who has investigated it further. Cc: sta...@vger.kernel.org Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-video.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions

Re: [PATCH] em28xx: fix compiler warnings

Am 07.08.2014 um 08:45 schrieb Hans Verkuil: On 08/05/2014 05:18 PM, Frank Schäfer wrote: Hi Hans, Am 05.08.2014 um 09:00 schrieb Hans Verkuil: Fix three compiler warnings: drivers/media/usb/em28xx/em28xx-input.c: In function ‘em28xx_i2c_ir_handle_key’: drivers/media/usb/em28xx/em28xx

Re: [PATCH] em28xx: fix compiler warnings

Hi Hans, Am 05.08.2014 um 09:00 schrieb Hans Verkuil: Fix three compiler warnings: drivers/media/usb/em28xx/em28xx-input.c: In function ‘em28xx_i2c_ir_handle_key’: drivers/media/usb/em28xx/em28xx-input.c:318:1: warning: the frame size of 1096 bytes is larger than 1024 bytes

Re: em28xx vb2 warnings

Am 28.07.2014 um 17:27 schrieb Hans Verkuil: ... OK, I looked at it: the problem is in get_next_buf() and finish_field_prepare_next(). In get_next_buf() the driver gets a buffer from the active list and deletes it from that list. In finish_field_prepare_next() that buffer is given back to

Re: em28xx vb2 warnings

Am 25.07.2014 21:07, schrieb Hans Verkuil: On 07/25/2014 06:20 PM, Frank Schäfer wrote: Hi Hans, I'm getting the following warnings with the em28xx driver on streaming stop: [ 7597.346168] WARNING: CPU: 1 PID: 3730 at drivers/media/v4l2-core/videobuf2-core.c:2126 __vb2_queue_cancel+0xf5

Re: [PATCH for v3.17] v4l2-ctrls: fix rounding calculation

offset and step are unsigned, so casting to signed makes no sense there. You do need a cast to u32 there, because otherwise architectures that have no 64-bit division start complaining (step is a u64). Signed-off-by: Hans Verkuil hans.verk...@cisco.com Reported-by: Frank Schäfer fschaefer

em28xx vb2 warnings

Hi Hans, I'm getting the following warnings with the em28xx driver on streaming stop: [ 7597.346168] WARNING: CPU: 1 PID: 3730 at drivers/media/v4l2-core/videobuf2-core.c:2126 __vb2_queue_cancel+0xf5/0x150 [videobuf2_core]() [ 7597.346171] Modules linked in: em28xx_rc snd_usb_audio ov2640

[PATCH 4/4] em28xx-v4l: get rid of field users in struct em28xx_v4l2

Instead of counting the number of opened file handles, use function v4l2_fh_is_singular_file() in em28xx_v4l2_open() and em28xx_v4l2_close() to determine if the file handle is the first/last opened one. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx

[PATCH 3/4] em28xx-v4l: simplify em28xx_v4l2_open() by using v4l2_fh_open()

Instead of calling ... struct v4l2_fh *fh = kzalloc(sizeof(*fh), GFP_KERNEL); filp-private_data = fh; v4l2_fh_init(fh, vdev); v4l2_fh_add(fh); ... simply use function v4l2_fh_open() which does all of these calls for us. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers

[PATCH 0/4] some em28xx-v4l cleanup patches

This patch series consists of 4 cleanup patches for the em28xx-v4l module. Frank Schäfer (4): em28xx-v4l: simplify some pointers in em28xx_init_camera() em28xx-v4l: get rid of struct em28xx_fh em28xx-v4l: simplify em28xx_v4l2_open() by using v4l2_fh_open() em28xx-v4l: get rid of field

[PATCH 1/4] em28xx-v4l: simplify some pointers in em28xx_init_camera()

Pointer v4l2 can be used instead of dev-v4l2, which saves some characters. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-camera.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/usb/em28xx/em28xx-camera.c b

[PATCH 2/4] em28xx-v4l: get rid of struct em28xx_fh

struct em28xx_fh isn't needed anymore because the only used field which is left is struct v4l2_fh fh. Use struct v4l2_fh directly and remvove struct em28xx_fh. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-video.c | 83

[PATCH] em28xx-v4l: fix disabling ioctl VIDIOC_S_PARM for vbi devices

Fixes an old copy+paste bug that has survived all recent code changes in this code area. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/em28xx/em28xx

v4l2-ctrls: negative integer control values broken

Hans, sorry for bothering you with another issue on friday evening. :-/ But it seems that commit 958c7c7e65 ([media] v4l2-ctrls: fix corner case in round-to-range code) introduced a regression for controls which are using a negative integer value range. All negative values are mapped to the

Re: New v4l2 driver does not allow brightness/contrast control

are provided by the subdevice drivers. With kernel 3.10 I have introduced bridge level image controls, but they are currently only used/activated if the subdevice doesn't already provide them (as suggested by Mauro). Hth, Frank Schäfer -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH 2/5] em28xx: fix i2c_set_adapdata() call in em28xx_i2c_register()

Hi Hans, Am 09.05.2014 10:40, schrieb Hans Verkuil: Hi Frank, I've got a comment about this patch: On 03/22/2014 02:01 PM, Frank Schäfer wrote: Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-i2c.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] em28xx: remove the i2c_set_adapdata() call in em28xx_i2c_register()

It is no longer needed since nobody is calling i2c_get_adapdata() anymore. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/em28xx/em28xx-i2c.c b/drivers

Re: [PATCH 03/19] em28xx: start moving em28xx-v4l specific data to its own struct

Am 09.05.2014 11:17, schrieb Hans Verkuil: Some comments for future improvements: On 03/24/2014 08:33 PM, Frank Schäfer wrote: Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-camera.c | 4 +- drivers/media/usb/em28xx/em28xx-video.c | 160

Re: [PATCH 06/19] em28xx: move video_device structs from struct em28xx to struct v4l2

Am 09.05.2014 11:19, schrieb Hans Verkuil: On 03/24/2014 08:33 PM, Frank Schäfer wrote: Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-video.c | 120 ++-- drivers/media/usb/em28xx/em28xx.h | 7 +- 2 files

[PATCH 15/19, REBASED] em28xx: move v4l2 user counting fields from struct em28xx to struct v4l2

Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-video.c | 27 +++ drivers/media/usb/em28xx/em28xx.h | 5 +++-- 2 files changed, 18 insertions(+), 14 deletions(-) diff --git a/drivers/media/usb/em28xx/em28xx-video.c b

Re: [PATCH 00/19] em28xx: clean up the main device struct and move sub-module specific data to its own data structs

for reviewing the patches and your comments ! Regards, Frank Regards, Hans On 03/24/2014 08:33 PM, Frank Schäfer wrote: This patch series cleans up the main device struct of the em28xx driver. Most of the patches (patches 3-16) are about moving the em28xx-v4l specific data to it's

Re: em2750 usb camera log as mentioned in dmesg

, no sensor is found. Does this also happen with the working kernel ? Regards, Frank Schäfer [12699.583014] em2750 #0: found i2c device @ 0xba on bus 0 [webcam sensor or tvp5150a] [12699.595736] em2750 #0: Your board has no unique USB ID and thus need a hint to be detected. [12699.595742] em2750

Re: [PATCH 4/5] em28xx: remove function em28xx_compression_disable() and its call

Am 22.03.2014 14:01, schrieb Frank Schäfer: em28xx_compression_disable() is a single line function which is called only one time and this call also isn't needed. Register 0x26 is always configured as part of the scaler configuration, which in turn is always done when the resolution changes

[PATCH v2 4/5] em28xx: remove function em28xx_compression_disable() and its call

at first device open. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-video.c | 5 ++--- drivers/media/usb/em28xx/em28xx.h | 6 -- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/media/usb/em28xx/em28xx-video.c b/drivers

[PATCH 00/19] em28xx: clean up the main device struct and move sub-module specific data to its own data structs

remove two fields which aren't needed. Frank Schäfer (19): em28xx: move sub-module data structs to a common place in the main struct em28xx-video: simplify usage of the pointer to struct v4l2_ctrl_handler in em28xx_v4l2_init() em28xx: start moving em28xx-v4l specific data to its own

[PATCH 02/19] em28xx-video: simplify usage of the pointer to struct v4l2_ctrl_handler in em28xx_v4l2_init()

Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-video.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/media/usb/em28xx/em28xx-video.c b/drivers/media/usb/em28xx/em28xx-video.c index 9df1826

[PATCH 01/19] em28xx: move sub-module data structs to a common place in the main struct

Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx.h | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/media/usb/em28xx/em28xx.h b/drivers/media/usb/em28xx/em28xx.h index 4beb1fa..9a3c496 100644 --- a/drivers/media

[PATCH 04/19] em28xx: move struct v4l2_ctrl_handler ctrl_handler from struct em28xx to struct v4l2

Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-video.c | 13 + drivers/media/usb/em28xx/em28xx.h | 3 ++- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/media/usb/em28xx/em28xx-video.c b/drivers/media/usb

[PATCH 07/19] em28xx: move videobuf2 related data from struct em28xx to struct v4l2

Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-cards.c | 2 -- drivers/media/usb/em28xx/em28xx-video.c | 15 +-- drivers/media/usb/em28xx/em28xx.h | 12 ++-- 3 files changed, 15 insertions(+), 14 deletions(-) diff --git

[PATCH 06/19] em28xx: move video_device structs from struct em28xx to struct v4l2

Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-video.c | 120 ++-- drivers/media/usb/em28xx/em28xx.h | 7 +- 2 files changed, 56 insertions(+), 71 deletions(-) diff --git a/drivers/media/usb/em28xx/em28xx-video.c

[PATCH 15/19] em28xx: move v4l2 user counting fields from struct em28xx to struct v4l2

Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-video.c | 27 +++ drivers/media/usb/em28xx/em28xx.h | 5 +++-- 2 files changed, 18 insertions(+), 14 deletions(-) diff --git a/drivers/media/usb/em28xx/em28xx-video.c b

[PATCH 12/19] em28xx: move progressive/interlaced fields from struct em28xx to struct v4l2

Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-cards.c | 2 -- drivers/media/usb/em28xx/em28xx-video.c | 27 +-- drivers/media/usb/em28xx/em28xx.h | 10 +- 3 files changed, 22 insertions(+), 17 deletions

[PATCH 19/19] em28xx: move fields wq_trigger and streaming_started from struct em28xx to struct em28xx_audio

Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-audio.c | 39 ++--- drivers/media/usb/em28xx/em28xx.h | 8 +++ 2 files changed, 25 insertions(+), 22 deletions(-) diff --git a/drivers/media/usb/em28xx/em28xx

[PATCH 11/19] em28xx: move struct em28xx_fmt *format from struct em28xx to struct v4l2

Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-video.c | 14 +++--- drivers/media/usb/em28xx/em28xx.h | 3 +-- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/media/usb/em28xx/em28xx-video.c b/drivers/media/usb

  1   2   3   4   5   6   7   8   9   >