Hi Niklas, Laurent,
On Tue, Oct 15, 2019 at 01:11:07AM +0300, Laurent Pinchart wrote:
> Hi Niklas,
>
> Thank you for the patch.
>
> On Mon, Oct 14, 2019 at 02:16:15AM +0200, Niklas Söderlund wrote:
> > Most Gen3 boards can output frames in NV12 format, add support for this
> > with a runtime check
On Tue, Oct 08, 2019 at 10:06:34AM +0200, Pavel Machek wrote:
> On Tue 2019-10-08 09:58:28, Jacopo Mondi wrote:
> > Pavel,
> >
> > On Tue, Oct 08, 2019 at 09:40:52AM +0200, Pavel Machek wrote:
> > > On Mon 2019-10-07 18:29:03, Jacopo Mondi wrote:
> > > > A
Pavel,
On Tue, Oct 08, 2019 at 09:40:52AM +0200, Pavel Machek wrote:
> On Mon 2019-10-07 18:29:03, Jacopo Mondi wrote:
> > Add the 'location' device property, used to specify a device mounting
> > position. The property is particularly meaningful for mobile devices
>
Parse device properties and register controls for them using the newly
introduced helpers.
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/ov13858.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/drivers/media/i2c/ov13858.c b/drivers/media/i2c/ov13858.c
index aac6f77afa0f
Before adding a new forward declaration to the v4l2-ctrls.h header file,
sort the existing ones alphabetically.
Signed-off-by: Jacopo Mondi
---
include/media/v4l2-ctrls.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2
Add an helper function to v4l2-ctrls to register controls associated
with a device property.
Signed-off-by: Jacopo Mondi
---
drivers/media/v4l2-core/v4l2-ctrls.c | 40
include/media/v4l2-ctrls.h | 26 ++
2 files changed, 66 insertions
lper to register properties
- Drop the example coreboot patch that add properties to the Soraka device
ACPI tables
I know there are still doubts the two properties might well apply to
modern devices with movable cameras, but I still think they cover 99% of devices
out there at the moment.
Thanks
Add an helper function to parse common device properties in the same
way as v4l2_fwnode_endpoint_parse() parses common endpoint properties.
Parse the 'rotation' and 'location' properties from the firmware
interface.
Signed-off-by: Jacopo Mondi
---
drivers/media/v4l2-cor
Add support for the newly defined V4L2_CID_CAMERA_SENSOR_LOCATION
and V4L2_CID_CAMERA_SENSOR_ROTATION read-only controls used to report
the camera device mounting position and orientation respectively.
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers/media/v4l2-core/v4l2
Before adding a new include directive, sort the existing ones in
alphabetical order.
Signed-off-by: Jacopo Mondi
---
drivers/media/v4l2-core/v4l2-ctrls.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c
b/drivers/media/v4l2-core
Parse device properties and register controls for them using the newly
introduced helpers.
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/ov5670.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/media/i2c/ov5670.c b/drivers/media/i2c/ov5670.c
index 041fcbb4eebd
Add the 'location' device property, used to specify a device mounting
position. The property is particularly meaningful for mobile devices
with a well defined usage orientation.
Signed-off-by: Jacopo Mondi
---
.../devicetree/bindings/media/video-interfaces.txt| 11 +
Add documentation for the V4L2_CID_CAMERA_SENSOR_LOCATION camera
control. The newly added read-only control reports the camera device
mounting position.
Signed-off-by: Jacopo Mondi
---
.../media/uapi/v4l/ext-ctrls-camera.rst | 32 +++
1 file changed, 32 insertions(+)
diff
Expand the 'rotation' property description to define the direction and
orientation of the axis around which the device mounting rotation is
expressed.
Signed-off-by: Jacopo Mondi
---
.../devicetree/bindings/media/video-interfaces.txt| 8 +---
1 file changed, 5 insert
Add documentation for the V4L2_CID_CAMERA_SENSOR_ROTATION camera
control. The newly added read-only control reports the camera device
mounting rotation.
Signed-off-by: Jacopo Mondi
---
.../media/uapi/v4l/ext-ctrls-camera.rst | 116 ++
1 file changed, 116 insertions
h a well defined usage orientation.
> >
> > Signed-off-by: Jacopo Mondi
> > ---
> > .../devicetree/bindings/media/video-interfaces.txt| 11 +++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/med
Hi Hans, thanks for the lenghty reply
On Thu, Sep 26, 2019 at 10:11:51AM +0200, Hans Verkuil wrote:
> On 9/3/19 6:49 PM, Jacopo Mondi wrote:
> > Hi Sakari, Hans,
> >
> > On Tue, Sep 03, 2019 at 04:06:26PM +0300, Sakari Ailus wrote:
> >> Hi Hans, Jacopo,
> >
Hello,
sorry for having missed this
On Wed, Sep 25, 2019 at 04:41:13PM +0300, Laurent Pinchart wrote:
> Hi Philipp,
>
> (CC'ing Sakari, Jacopo, Kieran and Niklas)
>
> Thank you for the patch.
>
> On Tue, Sep 24, 2019 at 01:49:53PM +0200, Philipp Zabel wrote:
> > Add a subdevice video operation
Hi Hans,
On Fri, Sep 13, 2019 at 08:49:06PM +0200, Jacopo Mondi wrote:
> Hi Hans,
>
> On Fri, Sep 13, 2019 at 04:02:45PM +0200, Hans Verkuil wrote:
> > On 9/12/19 10:10 PM, Jacopo Mondi wrote:
> > > Add documentation for the V4L2_CID_CAMERA_SENSOR_ROTATION camera
> &
rmed attendees for this session:
>
> Boris Brezillon
> Alexandre Courbot
> Nicolas Dufresne
> Tomasz Figa
> Ezequiel Garcia
> Daniel Gomez
> Dafna Hirschfeld
> Eugen Hristev
> Paul Kocialkowski
> Helen Koike
> Michael Tretter
> Hans Verkuil
>
> Ten
Hi Hans,
On Fri, Sep 13, 2019 at 04:08:10PM +0200, Hans Verkuil wrote:
> On 9/12/19 10:10 PM, Jacopo Mondi wrote:
> > Add an helper function to parse common device properties in the same
> > way as v4l2_fwnode_endpoint_parse() parses common endpoint properties.
> >
&g
Hi Hans,
On Fri, Sep 13, 2019 at 04:02:45PM +0200, Hans Verkuil wrote:
> On 9/12/19 10:10 PM, Jacopo Mondi wrote:
> > Add documentation for the V4L2_CID_CAMERA_SENSOR_ROTATION camera
> > control. The newly added read-only control reports the camera device
> > mounting rotatio
Add an helper function to v4l2-ctrls to register controls associated
with a device property. Add an UNSET flag to the device properties to
distinguish uninitialized properties from properties with an actual
value at control registration time.
Signed-off-by: Jacopo Mondi
---
drivers/media/v4l2
Parse device properties and register controls for them using the newly
introduced helpers.
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/ov13858.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/drivers/media/i2c/ov13858.c b/drivers/media/i2c/ov13858.c
index aac6f77afa0f
Parse device properties and register controls for them using the newly
introduced helpers.
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/ov5670.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/media/i2c/ov5670.c b/drivers/media/i2c/ov5670.c
index 041fcbb4eebd
Add support for the newly defined V4L2_CID_CAMERA_SENSOR_LOCATION
and V4L2_CID_CAMERA_SENSOR_ROTATION read-only controls used to report
the camera device mounting position and orientation respectively.
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers/media/v4l2-core/v4l2
Before adding a new include directive, sort the existing ones in
alphabetical order.
Signed-off-by: Jacopo Mondi
---
drivers/media/v4l2-core/v4l2-ctrls.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c
b/drivers/media/v4l2-core
Add documentation for the V4L2_CID_CAMERA_SENSOR_ROTATION camera
control. The newly added read-only control reports the camera device
mounting rotation.
Signed-off-by: Jacopo Mondi
---
.../media/uapi/v4l/ext-ctrls-camera.rst | 117 ++
1 file changed, 117 insertions
Add documentation for the V4L2_CID_CAMERA_SENSOR_LOCATION camera
control. The newly added read-only control reports the camera device
mounting position.
Signed-off-by: Jacopo Mondi
---
.../media/uapi/v4l/ext-ctrls-camera.rst | 32 +++
1 file changed, 32 insertions(+)
diff
Expand the 'rotation' property description to define the direction and
orientation of the axis around which the device mounting rotation is
expressed.
Signed-off-by: Jacopo Mondi
---
.../devicetree/bindings/media/video-interfaces.txt| 8 +---
1 file changed, 5 insert
Add the 'location' device property, used to specify a device mounting
position. The property is particularly meaningful for mobile devices
with a well defined usage orientation.
Signed-off-by: Jacopo Mondi
---
.../devicetree/bindings/media/video-interfaces.txt| 11 +
rse properties and helper to register properties
- Drop the example coreboot patch that add properties to the Soraka device
ACPI tables
I know there are still doubts the two properties might well apply to
modern devices with movable cameras, but I still think they cover 99% of devices
out there at the
Before adding a new forward declaration to the v4l2-ctrls.h header file,
sort the existing ones alphabetically.
Signed-off-by: Jacopo Mondi
---
include/media/v4l2-ctrls.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2
Add an helper function to parse common device properties in the same
way as v4l2_fwnode_endpoint_parse() parses common endpoint properties.
Initially parse the 'rotation' and 'location' properties from the
firmware interface.
Signed-off-by: Jacopo Mondi
---
drivers/
Hi Mauro,
On Thu, Sep 12, 2019 at 09:51:47AM -0300, Mauro Carvalho Chehab wrote:
> Em Tue, 27 Aug 2019 15:21:26 +0300
> Laurent Pinchart escreveu:
>
> > Hi Jacopo,
> >
> > Thank you for the patch.
> >
> > On Tue, Aug 27, 2019 at 11:23:27AM +0200, Jaco
Hi Sakari, Hans,
On Tue, Sep 03, 2019 at 04:06:26PM +0300, Sakari Ailus wrote:
> Hi Hans, Jacopo,
>
> On Thu, Aug 29, 2019 at 02:55:30PM +0200, Hans Verkuil wrote:
> > On 8/29/19 2:40 PM, Jacopo Mondi wrote:
> > > HI Hans,
> > >
> > > On Thu, Aug 29, 20
Hi Tomasz, Laurent
On Tue, Sep 03, 2019 at 01:16:21PM +0900, Tomasz Figa wrote:
> On Tue, Sep 3, 2019 at 1:43 AM Laurent Pinchart
> wrote:
> >
> > Hi Jacopo,
> >
> > On Mon, Sep 02, 2019 at 01:20:49PM +0200, Jacopo Mondi wrote:
> > > On Tue, Aug 27, 201
Hi again,
On Mon, Sep 02, 2019 at 07:49:37PM +0300, Laurent Pinchart wrote:
> Hi Jacopo,
>
> On Mon, Sep 02, 2019 at 06:40:31PM +0200, Jacopo Mondi wrote:
> > On Mon, Sep 02, 2019 at 02:38:40PM +0100, Rob Herring wrote:
> > > On Thu, Aug 29, 2019 at 02:46:40PM +0200, Jacop
Hi Rob,
On Mon, Sep 02, 2019 at 02:38:40PM +0100, Rob Herring wrote:
> On Thu, Aug 29, 2019 at 02:46:40PM +0200, Jacopo Mondi wrote:
> > Hi Laurent,
> >
> > On Tue, Aug 27, 2019 at 03:21:26PM +0300, Laurent Pinchart wrote:
> > > Hi Jacopo,
> > >
> >
HI Laurent,
On Tue, Aug 27, 2019 at 03:51:32PM +0300, Laurent Pinchart wrote:
> Hi Jacopo,
>
> Thank you for the patch.
>
> On Tue, Aug 27, 2019 at 11:23:29AM +0200, Jacopo Mondi wrote:
> > Add documentation for the V4L2_CID_CAMERA_SENSOR_ROTATION camera
> > control
Hi Hans, Laurent,
On Thu, Aug 29, 2019 at 05:32:52PM +0200, Hans Verkuil wrote:
> On 8/29/19 5:05 PM, Laurent Pinchart wrote:
> > Hi Hans,
> >
> > On Thu, Aug 29, 2019 at 03:04:42PM +0200, Hans Verkuil wrote:
> >> On 8/29/19 2:45 PM, Jacopo Mondi wrote:
> >&
Hi Hans,
On Thu, Aug 29, 2019 at 03:39:43PM +0200, Hans Verkuil wrote:
> On 8/29/19 3:18 PM, Jacopo Mondi wrote:
> > Hi Hans
> >
> > On Thu, Aug 29, 2019 at 02:55:30PM +0200, Hans Verkuil wrote:
> >> On 8/29/19 2:40 PM, Jacopo Mondi wrote:
> >>> HI Hans,
Hi Hans
On Thu, Aug 29, 2019 at 02:55:30PM +0200, Hans Verkuil wrote:
> On 8/29/19 2:40 PM, Jacopo Mondi wrote:
> > HI Hans,
> >
> > On Thu, Aug 29, 2019 at 12:20:18PM +0200, Hans Verkuil wrote:
> >> On 8/27/19 11:23 AM, Jacopo Mondi wrote:
> >>> Repor
Hi Laurent,
On Tue, Aug 27, 2019 at 04:16:20PM +0300, Laurent Pinchart wrote:
> Hi Jacopo,
>
> Thank you for the patch.
>
> On Tue, Aug 27, 2019 at 11:23:34AM +0200, Jacopo Mondi wrote:
> > Add the 'v4l2_fwnode_register_controls()' helper to v4l2-fwnode. The
>
Hi Laurent,
On Tue, Aug 27, 2019 at 03:50:08PM +0300, Laurent Pinchart wrote:
> Hi Jacopo,
>
> Thank you for the patch.
>
> On Tue, Aug 27, 2019 at 11:23:28AM +0200, Jacopo Mondi wrote:
> > Add documentation for the V4L2_CID_CAMERA_SENSOR_LOCATION camera
> > control
Hi Laurent,
On Tue, Aug 27, 2019 at 03:21:26PM +0300, Laurent Pinchart wrote:
> Hi Jacopo,
>
> Thank you for the patch.
>
> On Tue, Aug 27, 2019 at 11:23:27AM +0200, Jacopo Mondi wrote:
> > Add the 'location' device property, used to specify the camera device
>
Hi Hans,
On Thu, Aug 29, 2019 at 12:31:37PM +0200, Hans Verkuil wrote:
> On 8/27/19 11:23 AM, Jacopo Mondi wrote:
> > Add the 'v4l2_fwnode_register_controls()' helper to v4l2-fwnode. The
> > function parses the device node and endpoint firmware properties to
> > whi
HI Hans,
On Thu, Aug 29, 2019 at 12:20:18PM +0200, Hans Verkuil wrote:
> On 8/27/19 11:23 AM, Jacopo Mondi wrote:
> > Report the native pixel array size and the crop bounds for the ov5670
> > sensor driver.
> >
> > Signed-off-by: Jacopo Mondi
> > ---
>
Ups, please ignore this, I changed the commit message and forgot to
wipe the directory where I have formatted out the patches..
On Tue, Aug 27, 2019 at 11:23:33AM +0200, Jacopo Mondi wrote:
> Add support for the newly defined V4L2_CID_CAMERA_SENSOR_ROTATION
> read-only control used to repo
Ups, please ignore this, I changed the commit message and forgot to
wipe the directory where I have formatted out the patches..
On Tue, Aug 27, 2019 at 11:23:31AM +0200, Jacopo Mondi wrote:
> Add support for the newly defined V4L2_CID_CAMERA_SENSOR_LOCATION
> read-only control used to repo
Add support for the newly defined V4L2_CID_CAMERA_SENSOR_ROTATION
read-only control used to report the camera device mounting rotation.
Signed-off-by: Jacopo Mondi
---
drivers/media/v4l2-core/v4l2-ctrls.c | 2 ++
include/uapi/linux/v4l2-controls.h | 2 ++
2 files changed, 4 insertions
Add the 'v4l2_fwnode_register_controls()' helper to v4l2-fwnode. The
function parses the device node and endpoint firmware properties to
which a v4l2 control is associated to and registers the control with the
provided handler.
Signed-off-by: Jacopo Mondi
---
drivers/media/v4l2
Use the newly introduced helper to parse properties from firmware and
register the associated v4l2 control.
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/ov5670.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/media/i2c/ov5670.c b/drivers/media/i2c/ov5670.c
index
Add the 'rotation' and 'location' properties to the cameras .asl files.
Signed-off-by: Jacopo Mondi
---
.../poppy/variants/baseboard/include/baseboard/acpi/cam0.asl| 2 ++
.../poppy/variants/baseboard/include/baseboard/acpi/cam1.asl| 2 ++
2 files changed, 4 insertio
Use the newly introduced helper to parse properties from firmware and
register the associated v4l2 control.
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/ov13858.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/media/i2c/ov13858.c b/drivers/media/i2c/ov13858.c
index
Report the native pixel array size and the crop bounds for the ov5670
sensor driver.
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/ov5670.c | 20
1 file changed, 20 insertions(+)
diff --git a/drivers/media/i2c/ov5670.c b/drivers/media/i2c/ov5670.c
index 2bc57e85f721
Report the native pixel array size and the crop bounds for the ov13858
sensor driver.
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/ov13858.c | 25 +
1 file changed, 25 insertions(+)
diff --git a/drivers/media/i2c/ov13858.c b/drivers/media/i2c/ov13858.c
index
Add support for the newly defined V4L2_CID_CAMERA_SENSOR_ROTATION
read-only control used to report the camera device mounting rotation.
Signed-off-by: Jacopo Mondi
---
drivers/media/v4l2-core/v4l2-ctrls.c | 2 ++
include/uapi/linux/v4l2-controls.h | 2 ++
2 files changed, 4 insertions
Add documentation for the V4L2_CID_CAMERA_SENSOR_ROTATION camera
control. The newly added read-only control reports the camera device
mounting rotation.
Signed-off-by: Jacopo Mondi
---
Documentation/media/uapi/v4l/ext-ctrls-camera.rst | 9 +
1 file changed, 9 insertions(+)
diff --git a
not-to-merge patch to the coreboot ACPI tables
for the Soraka device used for development is provided as a simple usage
example of the 'rotation' and 'location' properties.
The patch is against the https://review.coreboot.org/coreboot.git master branch.
Thanks
j
Jacopo Mondi
Add support for the newly defined V4L2_CID_CAMERA_SENSOR_LOCATION
read-only control used to report the camera device mounting position.
Signed-off-by: Jacopo Mondi
---
drivers/media/v4l2-core/v4l2-ctrls.c | 2 ++
include/uapi/linux/v4l2-controls.h | 5 +
2 files changed, 7 insertions
Add the 'location' device property, used to specify the camera device
mounting position. The property is particularly meaningful for mobile
devices with a well defined usage orientation.
Signed-off-by: Jacopo Mondi
---
.../devicetree/bindings/media/video-interfaces.txt | 10 +++
Add documentation for the V4L2_CID_CAMERA_SENSOR_LOCATION camera
control. The newly added read-only control reports the camera device
mounting position.
Signed-off-by: Jacopo Mondi
---
.../media/uapi/v4l/ext-ctrls-camera.rst | 34 +++
1 file changed, 34 insertions(+)
diff
Add support for the newly defined V4L2_CID_CAMERA_SENSOR_LOCATION
read-only control used to report the camera device mounting position.
Signed-off-by: Jacopo Mondi
---
drivers/media/v4l2-core/v4l2-ctrls.c | 2 ++
include/uapi/linux/v4l2-controls.h | 5 +
2 files changed, 7 insertions
Hi Niklas,
On Fri, Aug 23, 2019 at 05:51:17PM +0200, Niklas Soderlund wrote:
> Hi Jacopo,
>
> Thanks for your patch.
>
> On 2019-08-22 23:04:33 +0200, Jacopo Mondi wrote:
> > The example provided by the video-interface.txt file uses compatible
> > values for drivers wh
The example provided by the video-interface.txt file uses compatible
values for drivers which are have been removed a long time ago. To avoid
generating confusion, replace the existing example with a new one using
upstream maintained and more modern devices.
Signed-off-by: Jacopo Mondi
---
This
Hello,
+laura who has been working on supporting RAW capture for this
driver.
On Tue, Aug 20, 2019 at 12:13:12PM +0300, Sakari Ailus wrote:
> Hi Hugues,
>
> On Tue, Jul 02, 2019 at 04:05:46PM +, Hugues FRUCHET wrote:
> > Hi Sakari,
> >
> > On 6/27/19 6:05 PM, Sakari Ailus wrote:
> > > Hi
Hi Simon,
On Wed, Aug 21, 2019 at 10:17:48AM +0200, Simon Horman wrote:
> On Tue, Aug 20, 2019 at 05:19:30PM +0200, Simon Horman wrote:
> > On Tue, Aug 20, 2019 at 11:52:05AM +0200, Jacopo Mondi wrote:
> > > Hi Simon,
> > >
> > > On Mon, Aug 19, 2019 at
Hi Simon,
On Mon, Aug 19, 2019 at 04:05:44PM +0200, Simon Horman wrote:
> Renesas media binding documentation files uses a naming schema of
> 'renesas,.txt'. Rename the SH Mobile CEU file to match this pattern.
>
The old soc-camera based sh-mobile-ceu driver has been removed one
year ago and repl
Report the native pixel array size and the crop bounds for the ov13858
sensor driver.
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/ov13858.c | 25 +
1 file changed, 25 insertions(+)
diff --git a/drivers/media/i2c/ov13858.c b/drivers/media/i2c/ov13858.c
index
Report the native pixel array size and the crop bounds for the ov5670
sensor driver.
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/ov5670.c | 20
1 file changed, 20 insertions(+)
diff --git a/drivers/media/i2c/ov5670.c b/drivers/media/i2c/ov5670.c
index 2bc57e85f721
Hi Alexandre,
On Fri, Aug 16, 2019 at 02:52:13PM +0900, Alexandre Courbot wrote:
> On Wed, Aug 14, 2019 at 6:40 PM Laurent Pinchart
> wrote:
> >
> > On Wed, Aug 14, 2019 at 05:35:48PM +0900, Alexandre Courbot wrote:
> > > That could be nice. Of course something more informal is also fine.
> > > A
Hi
On Tue, Aug 06, 2019 at 04:03:56PM +0200, Marek Vasut wrote:
> On 7/1/19 9:58 AM, Jacopo Mondi wrote:
>
> [...]
>
> >> +#define ISL7998x_REG_P5_H_LINE_CNT_1 ISL7998x_REG(5, 0x3a)
> >> +#define ISL7998x_REG_P5_H_LINE_CNT_2 ISL79
Hi Ezequiel,
On Wed, Jul 10, 2019 at 03:40:00PM -0300, Ezequiel Garcia wrote:
> This is mostly a port of Jacopo's fix:
>
> commit aa4bb8b8838ffcc776a79f49a4d7476b82405349
> Author: Jacopo Mondi
> Date: Fri Jul 6 05:51:52 2018 -0400
>
> media: ov5640: Re-
Hi Laura,
I went through your changes and tried to make a sense out of them. Good job
finding them out!
On Mon, Jul 22, 2019 at 05:50:35PM +0200, Laura Nao wrote:
> Thanks Fabio!
>
> I tried tweaking the PLL configuration in the driver and did some further
> tests on 5.2 kernel.
>
> I was finall
Hi Laura,
thanks for addressing this issue.
On Mon, Jul 22, 2019 at 05:50:35PM +0200, Laura Nao wrote:
> Thanks Fabio!
>
> I tried tweaking the PLL configuration in the driver and did some further
> tests on 5.2 kernel.
>
> I was finally able to capture RAW frames that match the test pattern fo
road with my
comments on v1 :)
Reviewed-by: Jacopo Mondi
Thanks
j
> ---
> Hi Rob,
>
> I droped your reviewed-by tag since there where several changes.
>
> Changes
> v2:
> - use the Documentation/devicetree/bindings/media/ti,omap3isp.txt
>formatting scheme
>
> was cleaned up if the parallel notifier registration failed. Fix this by
> cleaning up the correct one.
>
> Fixes: 9863bc8695bc36e3 ("media: rcar-vin: Cleanup notifier in error path")
> Signed-off-by: Niklas Söderlund
The patch itself is good! Nice catch!
Reviewed-by: J
Hello Marek,
long time due review, sorry about this.
On Mon, May 20, 2019 at 10:18:12PM +0200, Marek Vasut wrote:
> Add driver for the Intersil ISL7998x BT656-to-MIPI-CSI2 video decoder.
analog to CSI-2 or analog to BT.656 if you want to support both chip
versions.
> This chip supports 1/2/4
Hi Ezequiel,
On Tue, Jun 25, 2019 at 05:39:45PM -0300, Ezequiel Garcia wrote:
> Not all sensors will be able to guarantee a proper initial state.
> This may be either because the driver is not properly written,
> or (probably unlikely) because the hardware won't support it.
>
> While the right sol
t;
> Signed-off-by: Hans Verkuil
> Cc: Jacopo Mondi
Thanks for doing this.
Reviewed-by: Jacopo Mondi
Thanks
j
> ---
> drivers/media/platform/sh_veu.c | 4 +---
> drivers/media/platform/sh_vou.c | 5 ++---
> 2 files changed, 3 insertions(+), 6 deletions(-)
>
> diff
Hi Niklas,
On Fri, Jun 14, 2019 at 11:21:05PM +0200, Niklas Söderlund wrote:
> Hi Sakari,
>
> Thanks for your work and sorry that I missed this and replied to v1 the
> other day. I have tested v2 now and unfortunately it still breaks
> rcar-vin, see bellow :-(
>
> On 2019-06-06 16:02:18 +0300, Sak
Hi Laurent,
thanks for your reply.
On Sun, Jun 16, 2019 at 08:38:20PM +0300, Laurent Pinchart wrote:
> Hi Jacopo,
>
> On Wed, May 22, 2019 at 06:33:49PM +0200, Jacopo Mondi wrote:
> > Hi Sakari,
> > +cc Niklas, Laurent and Kieran, as I'm testing on a Renesas board
s_asd->csi2.port = vep.base.port;
> + s_asd->csi2.lanes = vep.bus.mipi_csi2.num_data_lanes;
> +
> + ret = v4l2_async_notifier_add_fwnode_remote_subdev(
> + &cio2->notifier, ep, &s_asd->asd);
> +
Hi Sakari,
On Thu, Jun 06, 2019 at 04:02:20PM +0300, Sakari Ailus wrote:
> v4l2_async_notifier_add_fwnode_remote_subdev is a convenience function for
> parsing information on V4L2 fwnode subdevs.
>
> Signed-off-by: Sakari Ailus
> ---
> drivers/media/v4l2-core/v4l2-async.c | 23 ++
gt; int v4l2_async_notifier_parse_fwnode_sensor_common(struct device *dev,
> diff --git a/include/media/v4l2-async.h b/include/media/v4l2-async.h
> index 1497bda66c3b..b9141ffa188a 100644
> --- a/include/media/v4l2-async.h
> +++ b/include/media/v4l2-async.h
> @@ -17
Hi Sakari,
I'll soon test on my platforms as well. Here you have a few comments
from just reading the patch.
On Thu, Jun 06, 2019 at 04:02:18PM +0300, Sakari Ailus wrote:
> V4L2 async framework can use both device's fwnode and endpoints's fwnode
> for matching the async sub-device with the
HI Marek,
On Wed, May 29, 2019 at 01:09:47PM +0200, Marek Vasut wrote:
> On 5/29/19 1:04 PM, Ian Arkver wrote:
> > Hi,
> >
> > On 29/05/2019 11:41, Marek Vasut wrote:
> >> On 5/29/19 8:28 AM, Jacopo Mondi wrote:
> >>
> >> [...]
> >>
>
Hi Marek,
On Tue, May 28, 2019 at 07:49:57PM +0200, Marek Vasut wrote:
> On 5/28/19 5:10 PM, Jacopo Mondi wrote:
> [...]
>
> >>> From my understanding of the product page, both the ISL79987 and
> >>> ILS79988 devices support up to 4 analog inputs, and provide
Hi Marek,
On Tue, May 28, 2019 at 04:36:27PM +0200, Marek Vasut wrote:
> On 5/28/19 1:47 PM, Jacopo Mondi wrote:
> > Hi Marek,
> >thanks for the patch
>
> Hi,
>
> > On Mon, May 20, 2019 at 10:18:11PM +0200, Marek Vasut wrote:
> >> Add bindings for t
Hi Marek,
thanks for the patch
On Mon, May 20, 2019 at 10:18:11PM +0200, Marek Vasut wrote:
> Add bindings for the Intersil ISL7998x BT656-to-MIPI-CSI2 decoder.
>
> Signed-off-by: Marek Vasut
> Cc: Sakari Ailus
> Cc: Mauro Carvalho Chehab
> Cc: Rob Herring
> Cc: devicet...@vger.kernel.org
>
Hi Sakari,
On Fri, Mar 01, 2019 at 01:23:57PM +0200, Sakari Ailus wrote:
> Address a compiler warnings on alignment of struct ipu3_uapi_awb_fr_config_s
> by adding __attribute__((aligned(32))) to a struct member of that type as
> well.
>
Sorry, just noticed there was a v2.
This is how we momenta
pply here? Can we
safely drop the __aligned attribute?
I tend to think so, as all other members of 'struct
ipu3_uapi_acc_param' are not aligned.
With this confirmed:
Reviewed-by: Jacopo Mondi
Thanks
j
>
> Signed-off-by: Sakari Ailus
> ---
> drivers/staging/media/ipu3/inc
ice layout model in the documentation,
and I wrote this hoping a good part could serve for that purpose.
On Tue, Apr 23, 2019 at 04:28:40PM +0300, Sakari Ailus wrote:
> Hi Jacopo,
>
> On Tue, Apr 23, 2019 at 12:19:32PM +0200, Jacopo Mondi wrote:
> > Hi Sakari,
> >
> > On
Hi Marco,
thanks
Reviewed-by: Jacopo Mondi
On Mon, Apr 15, 2019 at 02:44:13PM +0200, Marco Felsch wrote:
> The debug output for tvp5150_selmux() isn't really intuitive. Register
> values are printed decimal formatted and the input/output driver states
> are printed as enum.
Hi Marco,
On Mon, Apr 15, 2019 at 02:44:07PM +0200, Marco Felsch wrote:
> Since commit 10d5509c8d50 ("[media] v4l2: remove g/s_crop from video ops")
> the 'which' field for set/get_selection must be FORMAT_ACTIVE. There is
> no way to try different selections. The patch adds a helper function to
>
\n");
> ret = -EINVAL;
> goto err;
> }
>
> - decoder->mbus_type = bus_cfg.bus_type;
> + for_each_endpoint_of_node(np, ep_np) {
> + struct v4l2_fwnode_endpoint bus_cfg = {
> +
HI Sakari,
On Fri, May 03, 2019 at 12:32:02AM +0300, Sakari Ailus wrote:
> Hi Jacopo,
>
> On Sat, Apr 27, 2019 at 01:00:42AM +0200, Jacopo Mondi wrote:
> > HI Sakari,
> >
> > On Tue, Apr 23, 2019 at 04:28:40PM +0300, Sakari Ailus wrote:
> > > Hi Jacopo,
>
HI Sakari,
On Tue, Apr 23, 2019 at 04:28:40PM +0300, Sakari Ailus wrote:
> Hi Jacopo,
>
> On Tue, Apr 23, 2019 at 12:19:32PM +0200, Jacopo Mondi wrote:
> > Hi Sakari,
> >
> > On Wed, Apr 17, 2019 at 01:41:48PM +0300, Sakari Ailus wrote:
> > > Hi Jacopo,
> &g
Hi Sakari,
On Wed, Apr 17, 2019 at 01:41:48PM +0300, Sakari Ailus wrote:
> Hi Jacopo,
>
> I promised to write a bit about the routing problem I attempted to write on
> #v4l. It's a bit late, but here it is. Let me know if you share my
> understanding (and especially do so if you don't :)).
Thanks
1 - 100 of 803 matches
Mail list logo
