On 11/20/2018 10:20 PM, Ezequiel Garcia wrote:
> Add a mem2mem driver for the VPU available on Rockchip SoCs.
> Currently only JPEG encoding is supported, for RK3399 and RK3288
> platforms.
>
> Signed-off-by: Ezequiel Garcia
> ---
> MAINTAINERS | 7 +
>
On 11/21/2018 12:15 PM, Rui Miguel Silva wrote:
> Hi,
> This series introduces the Media driver to work with the i.MX7 SoC. it uses
> the
> already existing imx media core drivers but since the i.MX7, contrary to
> i.MX5/6, do not have an IPU and because of that some changes in the imx media
>
Add non vendor bayer formats to the allowed format array.
Signed-off-by: Rui Miguel Silva
---
drivers/media/platform/video-mux.c | 20
1 file changed, 20 insertions(+)
diff --git a/drivers/media/platform/video-mux.c
b/drivers/media/platform/video-mux.c
index
The IOMUXC General Purpose Register has bitfield to control video bus
multiplexer to control the CSI input between the MIPI-CSI2 and parallel
interface. Add that register and mask.
Signed-off-by: Rui Miguel Silva
Reviewed-by: Philipp Zabel
---
arch/arm/boot/dts/imx7s.dtsi | 8 +++-
1 file
Hi,
This series introduces the Media driver to work with the i.MX7 SoC. it uses the
already existing imx media core drivers but since the i.MX7, contrary to
i.MX5/6, do not have an IPU and because of that some changes in the imx media
core are made along this series to make it support that case.
Add power domain index 0 related with mipi-phy to imx7s.
While at it rename pcie power-domain node to remove pgc prefix.
Signed-off-by: Rui Miguel Silva
---
arch/arm/boot/dts/imx7s.dtsi | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx7s.dtsi
This add the media entity subdevice and control driver for the i.MX7
CMOS Sensor Interface.
Signed-off-by: Rui Miguel Silva
---
drivers/staging/media/imx/Kconfig |9 +-
drivers/staging/media/imx/Makefile |2 +
drivers/staging/media/imx/imx7-media-csi.c | 1352
Adds MIPI CSI-2 subdev for i.MX7 to connect with sensors with a MIPI CSI-2
interface.
Signed-off-by: Rui Miguel Silva
---
drivers/staging/media/imx/Makefile |1 +
drivers/staging/media/imx/imx7-mipi-csis.c | 1134
2 files changed, 1135 insertions(+)
create mode
Add bindings documentation for i.MX7 media drivers.
The imx7 MIPI CSI2 and imx7 CMOS Sensor Interface.
Signed-off-by: Rui Miguel Silva
Reviewed-by: Rob Herring
Acked-by: Sakari Ailus
---
.../devicetree/bindings/media/imx7-csi.txt| 45 ++
.../bindings/media/imx7-mipi-csi2.txt
Warp7 comes with a Omnivision OV2680 sensor, add the node here to make complete
the camera data path for this system. Add the needed regulator to the analog
voltage supply, the port and endpoints in mipi_csi node and the pinctrl for the
reset gpio.
Signed-off-by: Rui Miguel Silva
---
Some imx system do not have IPU, so prepare the imx media drivers to support
this kind of devices. Rename the group ids to include an _IPU_ prefix, add a new
group id to support systems with only a CSI without IPU, and also
rename the create internal links to make it clear that only systems with
Add some i.MX7 related entries to TODO file.
Signed-off-by: Rui Miguel Silva
---
drivers/staging/media/imx/TODO | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/staging/media/imx/TODO b/drivers/staging/media/imx/TODO
index aeeb15494a49..6f29b5ca5324 100644
---
This patch adds the device tree nodes for csi, video multiplexer and mipi-csi
besides the graph connecting the necessary endpoints to make the media capture
entities to work in imx7 Warp board.
Signed-off-by: Rui Miguel Silva
---
arch/arm/boot/dts/imx7s-warp.dts | 51
Add rst document to describe the i.MX7 media driver and also a working
example from the Warp7 board usage with a OV2680 sensor.
Signed-off-by: Rui Miguel Silva
---
Documentation/media/v4l-drivers/imx7.rst | 157 ++
Documentation/media/v4l-drivers/index.rst | 1 +
2 files
Refactor and move media device initialization code to a new common module, so it
can be used by other devices, this will allow for example a near to introduce
imx7 CSI driver, to use this media device.
Signed-off-by: Rui Miguel Silva
---
drivers/staging/media/imx/Makefile| 1 +
Swapping the order between v4l2 subdevice registration and checking chip id in
b7a417628abf ("media: ov2680: don't register the v4l2 subdevice before checking
chip ID")
makes the mode restore to use the sensor controls before they are set, so move
the mode restore call to s_power after the
Note: this supersedes https://patchwork.linuxtv.org/patch/53017/. The only
change
is an updated device_caps patch: https://patchwork.linuxtv.org/patch/53057/
Regards,
Hans
The following changes since commit 5200ab6a32d6055428896a49ec9e3b1652c1a100:
media: vidioc_cropcap ->
Instead of setting device_caps/capabilities in the querycap ioctl, set
it in struct video_device instead.
Signed-off-by: Hans Verkuil
---
Changes in v2: vfd->device_caps was only set for the first of the two video
devices. Set it for the second video_device as well.
---
On 20.11.2018 22:43, Ken Sloat wrote:
> From: Ken Sloat
>
> In some usages isc->raw_fmt will not be initialized. If this
> is the case, it is very possible that a NULL struct de-reference
> will occur, as this member is referenced many times.
Hello Ken,
Do you have any confidence that just
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Wed Nov 21 05:00:13 CET 2018
media-tree git hash:5200ab6a32d6055428896a49ec9e3b1652c1a100
media_build
Add a mem2mem driver for the VPU available on Rockchip SoCs.
Currently only JPEG encoding is supported, for RK3399 and RK3288
platforms.
Signed-off-by: Ezequiel Garcia
---
MAINTAINERS | 7 +
drivers/staging/media/Kconfig | 2 +
Add the Video Processing Unit node for the RK3399 SoC.
Also, fix the VPU IOMMU node, which was disabled and lacking
its power domain property.
Signed-off-by: Ezequiel Garcia
---
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff
Add the Video Processing Unit node for RK3288 SoC.
Fix the VPU IOMMU node, which was disabled and lacking
its power domain property.
Signed-off-by: Ezequiel Garcia
---
arch/arm/boot/dts/rk3288.dtsi | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git
Hi everyone,
This is a quick respin addressing Hans' feedback
on the v8 version (see previous series for more details [1]).
Long story short:
This new version supports V4L2_PIX_FMT_JPEG capture format,
which means standard userspace can be used, such as gstreamer:
gst-launch-1.0 videotestsrc
From: Ken Sloat
In some usages isc->raw_fmt will not be initialized. If this
is the case, it is very possible that a NULL struct de-reference
will occur, as this member is referenced many times.
To prevent this, add safety checks for this member and handle
situations accordingly.
On Tue, 2018-11-20 at 14:52 +0100, Hans Verkuil wrote:
> On 11/19/2018 04:29 PM, Ezequiel Garcia wrote:
> > Add a mem2mem driver for the VPU available on Rockchip SoCs.
> > Currently only JPEG encoding is supported, for RK3399 and RK3288
> > platforms.
> >
> > Signed-off-by: Ezequiel Garcia
> >
Hi Maxime,
On Tue, Nov 20, 2018 at 10:48:39AM +0100, Maxime Ripard wrote:
> Hi Jacopo,
>
> On Wed, Nov 14, 2018 at 08:48:47PM +0100, jacopo mondi wrote:
> > On Tue, Nov 13, 2018 at 02:03:15PM +0100, Maxime Ripard wrote:
> > > The clock structure for the PCLK is quite obscure in the documentation,
On Wed, Nov 21, 2018 at 12:27:40AM +0900, Akinobu Mita wrote:
> Documentation/timers/timers-howto.txt says:
>
> "msleep(1~20) may not do what the caller intends, and will often sleep
> longer (~20 ms actual sleep for any value given in the 1~20ms range)."
>
> So replace msleep(2) by
Documentation/timers/timers-howto.txt says:
"msleep(1~20) may not do what the caller intends, and will often sleep
longer (~20 ms actual sleep for any value given in the 1~20ms range)."
So replace msleep(2) by usleep_range(2000, 3000).
Reported-by: Hans Verkuil
Cc: Matt Ranostay
Cc: Sakari
> Hello Ken,
>
> Indeed this is a bug, I saw it before as well, but so far, this has not
> appeared with the sensors we have connected. I have been trying to get around
> to fix it, but it's not a simple fix, much rather a rework of the driver part
> that handles the raw > formats.
>
> Feel
On 11/19/2018 04:29 PM, Ezequiel Garcia wrote:
> Add a mem2mem driver for the VPU available on Rockchip SoCs.
> Currently only JPEG encoding is supported, for RK3399 and RK3288
> platforms.
>
> Signed-off-by: Ezequiel Garcia
> ---
> MAINTAINERS | 7 +
>
Hi Sakari,
On Tue, Nov 20, 2018 at 10:15 AM Sakari Ailus
wrote:
> Where's the DT source for the board?
Board dts is arch/arm/boot/dts/imx6qdl-wandboard.dtsi
SoC dtsi is arch/arm/boot/dts/imx6q.dtsi
Also, since 4.20-rc the following errors are seen:
[3.449564] imx-ipuv3 240.ipu:
On Tue, Nov 20, 2018 at 10:10:57AM -0200, Fabio Estevam wrote:
> Hi,
>
> On a imx6q-wandboard running linux-next 20181120 there the following warnings:
>
> [4.327794] video-mux 20e.iomuxc-gpr:ipu1_csi0_mux: bad remote
> port parent
> [4.336118] video-mux
Hi,
On a imx6q-wandboard running linux-next 20181120 there the following warnings:
[4.327794] video-mux 20e.iomuxc-gpr:ipu1_csi0_mux: bad remote
port parent
[4.336118] video-mux 20e.iomuxc-gpr:ipu2_csi1_mux: bad remote
port parent
Is there anything we should do to prevent this
Hi Hans,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v4.20-rc3 next-20181120]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
Hi Hans,
I love your patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.20-rc3 next-20181120]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
Em Tue, 20 Nov 2018 12:49:46 +0200
Sakari Ailus escreveu:
> Hi Greg,
>
> On Mon, Nov 19, 2018 at 06:46:21PM +0100, Greg Kroah-Hartman wrote:
> > On Mon, Nov 19, 2018 at 07:03:54PM +0200, Sakari Ailus wrote:
> > > Hi Greg,
> > >
> > > On Mon, Nov 19, 2018 at 04:14:00PM +0100, Greg
Hi Greg,
On Mon, Nov 19, 2018 at 06:46:21PM +0100, Greg Kroah-Hartman wrote:
> On Mon, Nov 19, 2018 at 07:03:54PM +0200, Sakari Ailus wrote:
> > Hi Greg,
> >
> > On Mon, Nov 19, 2018 at 04:14:00PM +0100, Greg Kroah-Hartman wrote:
> > > On Wed, Nov 14, 2018 at 11:37:46AM +0200, Sakari Ailus
Hi Mauro,
Here are a bunch of sensor driver improvements as well as a driver for the
Allwinner CSI parallel bridge. Finally, a small uAPI documentation fix to
better document the metadata capture buffers.
Please pull.
The following changes since commit fbe57dde7126d1b2712ab5ea93fb9d15f89de708:
The dvb_frontend dprintk() macro already prints __func__. So,
we don't need to add it again at the printed message.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/dvb-core/dvb_frontend.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
As we did an internal change inside the subsystem to always
represent min/max frequencies in Hz, add a debug message, as this
would help to discover bugs on drivers, if any.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/dvb-core/dvb_frontend.c | 3 +++
1 file changed, 3 insertions(+)
Tuners should report frequencies in Hz. That works fine on most
drivers, but, in the case of dvb-pll, some settings are for
satellite tuners, while others are for terrestrial/cable ones.
The code was trying to solve it at probing time, but that doesn't
work, as, when _attach is called, the
When converting gspca to vb2 I missed that fact that the buffer sizes
were rounded up to the next page size. As a result some gspca drivers
(spca561 being one of them) reported frame overflows.
Modify the code to align the buffer sizes to the next page size, just
as the original code did.
Fixes:
On Tue, Nov 20, 2018 at 10:41:42AM +0100, Hans Verkuil wrote:
> On 11/20/2018 10:27 AM, Sakari Ailus wrote:
> > Hi Hans,
> >
> > On Tue, Nov 20, 2018 at 09:58:43AM +0100, Hans Verkuil wrote:
> >> Add new buffer capability flags to indicate if the VIDIOC_PREPARE_BUF or
> >> VIDIOC_CREATE_BUFS
Hi Jacopo,
On Wed, Nov 14, 2018 at 08:48:47PM +0100, jacopo mondi wrote:
> On Tue, Nov 13, 2018 at 02:03:15PM +0100, Maxime Ripard wrote:
> > The clock structure for the PCLK is quite obscure in the documentation, and
> > was hardcoded through the bytes array of each and every mode.
> >
> > This
On 11/20/2018 10:27 AM, Sakari Ailus wrote:
> Hi Hans,
>
> On Tue, Nov 20, 2018 at 09:58:43AM +0100, Hans Verkuil wrote:
>> Add new buffer capability flags to indicate if the VIDIOC_PREPARE_BUF or
>> VIDIOC_CREATE_BUFS ioctls are supported.
>
> Are there practical benefits from the change for
Hi Hans,
On Tue, Nov 20, 2018 at 09:58:43AM +0100, Hans Verkuil wrote:
> Add new buffer capability flags to indicate if the VIDIOC_PREPARE_BUF or
> VIDIOC_CREATE_BUFS ioctls are supported.
Are there practical benefits from the change for the user space?
>
> Signed-off-by: Hans Verkuil
> ---
>
Good Day Dear,
I'm Ms Amelia and am new here looking for a serious relationship with someone i
can spend the rest of my life with, someone who is loving, caring, honest and
faithful to spend the rest of my life with, i came across your profile and its
very interesting to me and i would like
The following changes since commit fbe57dde7126d1b2712ab5ea93fb9d15f89de708:
media: ov7740: constify structures stored in fields of v4l2_subdev_ops
structure (2018-11-06 07:17:02 -0500)
are available in the Git repository at:
git://linuxtv.org/hverkuil/media_tree.git tags/br-v4.21e
for
Add new buffer capability flags to indicate if the VIDIOC_PREPARE_BUF or
VIDIOC_CREATE_BUFS ioctls are supported.
Signed-off-by: Hans Verkuil
---
Note: the flag bits will change since there are two other patches that add
flags, so the numbering will change.
---
diff --git
On 11/19/2018 09:54 PM, Matt Ranostay wrote:
> On Mon, Nov 19, 2018 at 6:26 AM Hans Verkuil wrote:
>>
>> On 11/01/2018 05:15 AM, Matt Ranostay wrote:
>>> Add initial support for MLX90640 thermal cameras which output an 32x24
>>> greyscale pixel image along with 2 rows of coefficent data.
>>>
>>>
On 20.11.2018 01:06, Ken Sloat wrote:
> Hello,
>
> I have discovered a bug in the Atmel/Microchip ISC driver while developing a
> i2c v4l2 sub-device driver. This bug did not previously occur for me on an
> older version of the driver (more details below), but I have confirmed this
> bug on
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Tue Nov 20 05:00:12 CET 2018
media-tree git hash:fbe57dde7126d1b2712ab5ea93fb9d15f89de708
media_build
Hi Sakari,
> Hi Ben,
>
> On Thu, Nov 08, 2018 at 11:41:46AM +0800, Ben Kao wrote:
> > This patch adds driver for Omnivision's ov8856 sensor, the driver
> > supports following features:
> >
> > - manual exposure/gain(analog and digital) control support
> > - two link frequencies
> > -
Do you need urgent funding? Either business or personal? We can arrange quick
guaranteed loans. Contact us today via email: yourfunding...@gmail.com
Hello,
I have discovered a bug in the Atmel/Microchip ISC driver while developing a
i2c v4l2 sub-device driver. This bug did not previously occur for me on an
older version of the driver (more details below), but I have confirmed this bug
on a platform based on the SAMA5D2 running a newer
On Mon, Nov 19, 2018 at 6:26 AM Hans Verkuil wrote:
>
> On 11/01/2018 05:15 AM, Matt Ranostay wrote:
> > Add initial support for MLX90640 thermal cameras which output an 32x24
> > greyscale pixel image along with 2 rows of coefficent data.
> >
> > Because of this the data outputed is really 32x26
On Mon, Nov 19, 2018 at 07:03:54PM +0200, Sakari Ailus wrote:
> Hi Greg,
>
> On Mon, Nov 19, 2018 at 04:14:00PM +0100, Greg Kroah-Hartman wrote:
> > On Wed, Nov 14, 2018 at 11:37:46AM +0200, Sakari Ailus wrote:
> > > [ upstream commit 92539d3eda2c090b382699bbb896d4b54e9bdece ]
> >
> > There is
Hi Greg,
On Mon, Nov 19, 2018 at 04:14:00PM +0100, Greg Kroah-Hartman wrote:
> On Wed, Nov 14, 2018 at 11:37:46AM +0200, Sakari Ailus wrote:
> > [ upstream commit 92539d3eda2c090b382699bbb896d4b54e9bdece ]
>
> There is no such git commit id in Linus's tree :(
Right. At the moment it's in the
Hello everyone,
And thanks for the detailed report!
On Mon, 2018-11-19 at 13:09 +0900, Tomasz Figa wrote:
> On Sun, Nov 18, 2018 at 7:45 AM Sakari Ailus wrote:
> > Hello everyone,
> >
> >
> > Here's the report on the Media Summit held on 25th October in Edinburgh.
> > The report is followed
On Mon, 2018-11-19 at 16:33 +0100, Hans Verkuil wrote:
> Userspace shouldn't set bytesused to 0 for output buffers.
> vb2_warn_zero_bytesused() warns about this (only once!), but it also
> calls WARN_ON(1), which is confusing since it is not immediately clear
> that it warns about a 0 value for
Userspace shouldn't set bytesused to 0 for output buffers.
vb2_warn_zero_bytesused() warns about this (only once!), but it also
calls WARN_ON(1), which is confusing since it is not immediately clear
that it warns about a 0 value for bytesused.
Just drop the WARN_ON as it serves no purpose.
Add a mem2mem driver for the VPU available on Rockchip SoCs.
Currently only JPEG encoding is supported, for RK3399 and RK3288
platforms.
Signed-off-by: Ezequiel Garcia
---
MAINTAINERS | 7 +
drivers/staging/media/Kconfig | 2 +
Add the Video Processing Unit node for the RK3399 SoC.
Also, fix the VPU IOMMU node, which was disabled and lacking
its power domain property.
Signed-off-by: Ezequiel Garcia
---
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff
Add the Video Processing Unit node for RK3288 SoC.
Fix the VPU IOMMU node, which was disabled and lacking
its power domain property.
Signed-off-by: Ezequiel Garcia
---
arch/arm/boot/dts/rk3288.dtsi | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git
Here's a new version of the Rockchip VPU JPEG encoder driver,
for the RK3288 and RK3399 SoCs.
This new version supports V4L2_PIX_FMT_JPEG capture format,
which means standard userspace can be used, such as gstreamer:
gst-launch-1.0 videotestsrc ! v4l2jpegenc
Get rid of a couple confusing error messages, namely:
test VIDIOC_G_FMT: OK
fail: v4l2-test-formats.cpp(464): pix_mp.plane_fmt[0].reserved
not zeroed
fail: v4l2-test-formats.cpp(752): Video Output Multiplanar is
valid, but TRY_FMT failed to return a
Hi,
we've got a regression report on openSUSE Bugzilla regarding DVB-S PCI
card:
https://bugzilla.opensuse.org/show_bug.cgi?id=1116374
According to the reporter (Stakanov, Cc'ed), the card worked fine on
4.18.15, but since 4.19, it doesn't give any channels, sound nor
picture, but only EPG is
On Wed, Nov 14, 2018 at 11:37:46AM +0200, Sakari Ailus wrote:
> [ upstream commit 92539d3eda2c090b382699bbb896d4b54e9bdece ]
There is no such git commit id in Linus's tree :(
Hi Mike,
On Sat, Nov 17, 2018 at 8:07 PM Matthew Wilcox wrote:
>
> On Sat, Nov 17, 2018 at 12:26:38PM +0530, Souptick Joarder wrote:
> > On Fri, Nov 16, 2018 at 11:59 PM Mike Rapoport wrote:
> > > > + * vm_insert_range - insert range of kernel pages into user vma
> > > > + * @vma: user vma to
On Wed, Nov 14, 2018 at 7:20 AM Adam Ford wrote:
>
> On Tue, Nov 13, 2018 at 7:04 AM Maxime Ripard
> wrote:
> >
> > The clock structure for the PCLK is quite obscure in the documentation, and
> > was hardcoded through the bytes array of each and every mode.
> >
> > This is troublesome, since we
On 11/19/2018 03:26 PM, Hans Verkuil wrote:
> On 10/20/2018 04:26 PM, Akinobu Mita wrote:
>> AMG88xx has a register for setting operating mode. This adds support
>> runtime PM by changing the operating mode.
>>
>> The instruction for changing sleep mode to normal mode is from the
>> reference
The following changes since commit fbe57dde7126d1b2712ab5ea93fb9d15f89de708:
media: ov7740: constify structures stored in fields of v4l2_subdev_ops
structure (2018-11-06 07:17:02 -0500)
are available in the Git repository at:
git://linuxtv.org/hverkuil/media_tree.git tags/br-v4.21d
for
On 11/01/2018 05:15 AM, Matt Ranostay wrote:
> Add initial support for MLX90640 thermal cameras which output an 32x24
> greyscale pixel image along with 2 rows of coefficent data.
>
> Because of this the data outputed is really 32x26 and needs the two rows
> removed after using the coefficent
On 10/20/2018 04:26 PM, Akinobu Mita wrote:
> AMG88xx has a register for setting operating mode. This adds support
> runtime PM by changing the operating mode.
>
> The instruction for changing sleep mode to normal mode is from the
> reference specifications.
>
>
Hi Tomasz,
On Fri, Nov 16, 2018 at 04:04:40PM +0900, Tomasz Figa wrote:
> > I've been using the controls currently integrated into ChromeOS that
> > have a working version of this particular setup. However, these
> > controls have a number of shortcomings and inconsistencies with other
> >
On 11/19/2018 02:53 PM, Paul Kocialkowski wrote:
> Hi,
>
> On Mon, 2018-11-19 at 12:18 +0100, Hans Verkuil wrote:
>> On 11/14/2018 02:47 PM, Hans Verkuil wrote:
>>> From: Hans Verkuil
>>>
>>> As was discussed here (among other places):
>>>
>>> https://lkml.org/lkml/2018/10/19/440
>>>
>>> using
Hi Maxime,
On Tue, Nov 06, 2018 at 03:54:15PM +0100, Maxime Ripard wrote:
> Now that we have some infrastructure for it, allow the MIPI D-PHY phy's to
> be configured through the generic functions through a custom structure
> added to the generic union.
>
> The parameters added here are the ones
Hi,
On Mon, 2018-11-19 at 12:18 +0100, Hans Verkuil wrote:
> On 11/14/2018 02:47 PM, Hans Verkuil wrote:
> > From: Hans Verkuil
> >
> > As was discussed here (among other places):
> >
> > https://lkml.org/lkml/2018/10/19/440
> >
> > using capture queue buffer indices to refer to reference
Hi Maxime,
Apologies for the delayed review. Please see my comments below.
On Tue, Nov 06, 2018 at 03:54:16PM +0100, Maxime Ripard wrote:
> The MIPI D-PHY spec defines default values and boundaries for most of the
> parameters it defines. Introduce helpers to help drivers get meaningful
> values
On 11/19/2018 01:22 PM, Hans Verkuil wrote:
> From d15ccd98e557a8cef1362cb591eb3011a6d8e1fd Mon Sep 17 00:00:00 2001
> From: Hans Verkuil
> Date: Fri, 16 Nov 2018 12:14:31 +0100
> Subject: [PATCH 2/4] vivid: use per-queue mutexes instead of one global mutex.
Oops, forgot to delete these four
>From d15ccd98e557a8cef1362cb591eb3011a6d8e1fd Mon Sep 17 00:00:00 2001
From: Hans Verkuil
Date: Fri, 16 Nov 2018 12:14:31 +0100
Subject: [PATCH 2/4] vivid: use per-queue mutexes instead of one global mutex.
This avoids having to unlock the queue lock in stop_streaming.
Signed-off-by: Hans
On Tue, Oct 30, 2018 at 1:49 PM Yong Deng wrote:
>
> Allwinner V3s SoC features a CSI module with parallel interface.
>
> This patch implement a v4l2 framework driver for it.
>
> Reviewed-by: Hans Verkuil
> Reviewed-by: Maxime Ripard
> Tested-by: Maxime Ripard
> Signed-off-by: Yong Deng
> ---
Hi Hans,
On Mon, Nov 19, 2018 at 12:09:01PM +0100, Hans Verkuil wrote:
> This avoids having to unlock the queue lock in stop_streaming.
>
> Signed-off-by: Hans Verkuil
> Reported-by: syzbot+736c3aae4af7b50d9...@syzkaller.appspotmail.com
> ---
> drivers/media/platform/vivid/vivid-core.c
The new cedrus driver was missing an important action item in the TODO.
Fix a nasty buffer overrun in vicodec.
Regards,
Hans
The following changes since commit fbe57dde7126d1b2712ab5ea93fb9d15f89de708:
media: ov7740: constify structures stored in fields of v4l2_subdev_ops
structure
Trace points are much more efficient than debug messages for intensive
tracing and could be conveniently enabled / disabled dynamically, hence
let's replace debug messages with the trace points. This also makes
code a bit cleaner.
Signed-off-by: Dmitry Osipenko
---
Changelog:
v3: -
On 11/14/2018 02:47 PM, Hans Verkuil wrote:
> From: Hans Verkuil
>
> As was discussed here (among other places):
>
> https://lkml.org/lkml/2018/10/19/440
>
> using capture queue buffer indices to refer to reference frames is
> not a good idea. A better idea is to use a 'tag' where the
>
Calling VIDIOC_DQBUF can release the core serialization lock pointed to
by vb2_queue->lock if it has to wait for a new buffer to arrive.
However, if userspace dup()ped the video device filehandle, then it is
possible to read or call DQBUF from two filehandles at the same time.
It is also
If queue->lock is different from the video_device lock, then
you need to serialize queue_setup with VIDIOC_S_FMT, and this
should be done by the driver.
Signed-off-by: Hans Verkuil
---
.../media/common/videobuf2/videobuf2-core.c | 51 +--
include/media/videobuf2-core.h
These four patches fix syzkaller race conditions. The first patch
fixes the case where VIDIOC_DQBUF (and indirectly via read()/write())
can release the core serialization mutex, thus allowing another thread
to access the same vb2 queue through a dup()ped filehandle.
If no new buffer is available
Add these ops to serialize queue_setup with VIDIOC_S_FMT.
Signed-off-by: Hans Verkuil
---
drivers/media/platform/vivid/vivid-core.c| 14 ++
drivers/media/platform/vivid/vivid-core.h| 3 +++
drivers/media/platform/vivid/vivid-sdr-cap.c | 2 ++
This avoids having to unlock the queue lock in stop_streaming.
Signed-off-by: Hans Verkuil
Reported-by: syzbot+736c3aae4af7b50d9...@syzkaller.appspotmail.com
---
drivers/media/platform/vivid/vivid-core.c| 15 ++-
drivers/media/platform/vivid/vivid-core.h| 5 +
Hi Shuah, Mauro,
I noticed that the function vb2_core_streamon() in videobuf2-core.c calls
v4l_vb2q_enable_media_source(q).
That function in turn assumes that q->owner is a v4l2_fh struct. But I
don't think that is true for DVB devices.
And since videobuf2-core.c is expected to be DVB/V4L
On 11/19/2018 11:32 AM, Tomasz Figa wrote:
> On Mon, Nov 19, 2018 at 6:54 PM Hans Verkuil wrote:
>>
>> On 11/19/2018 09:44 AM, Hans Verkuil wrote:
>>> On 11/19/2018 06:27 AM, Tomasz Figa wrote:
On Fri, Nov 16, 2018 at 6:45 PM Hans Verkuil wrote:
>
> On 11/16/2018 09:43 AM, Tomasz
On Mon, Nov 19, 2018 at 6:54 PM Hans Verkuil wrote:
>
> On 11/19/2018 09:44 AM, Hans Verkuil wrote:
> > On 11/19/2018 06:27 AM, Tomasz Figa wrote:
> >> On Fri, Nov 16, 2018 at 6:45 PM Hans Verkuil wrote:
> >>>
> >>> On 11/16/2018 09:43 AM, Tomasz Figa wrote:
> Hi Hans,
>
> On Wed,
On 11/19/2018 09:44 AM, Hans Verkuil wrote:
> On 11/19/2018 06:27 AM, Tomasz Figa wrote:
>> On Fri, Nov 16, 2018 at 6:45 PM Hans Verkuil wrote:
>>>
>>> On 11/16/2018 09:43 AM, Tomasz Figa wrote:
Hi Hans,
On Wed, Nov 14, 2018 at 12:08 AM Hans Verkuil wrote:
>
> Calling
On Thu 2018-11-01 18:31:30, sh...@kernel.org wrote:
> From: Shuah Khan
>
> Media Device Allocator API to allows multiple drivers share a media device.
> Using this API, drivers can allocate a media device with the shared struct
> device as the key. Once the media device is allocated by a driver,
On 11/19/2018 06:27 AM, Tomasz Figa wrote:
> On Fri, Nov 16, 2018 at 6:45 PM Hans Verkuil wrote:
>>
>> On 11/16/2018 09:43 AM, Tomasz Figa wrote:
>>> Hi Hans,
>>>
>>> On Wed, Nov 14, 2018 at 12:08 AM Hans Verkuil wrote:
Calling VIDIOC_DQBUF can release the core serialization lock
On Mon, Nov 19, 2018 at 08:17:32AM +0100, Luc Verhaegen wrote:
> Hi,
>
> At FOSDEM on saturday the 3rd of february 2018, there will be another
> graphics DevRoom. URL: https://fosdem.org/2018/
That should of course read:
At FOSDEM on saturday the 2nd of february 2019, there will be another
Hi,
At FOSDEM on saturday the 3rd of february 2018, there will be another
graphics DevRoom. URL: https://fosdem.org/2018/
The focus of this DevRoom is of course the same as the previous
editions, namely:
* Graphics drivers: from display to media to 3d drivers, both in kernel
or userspace.
501 - 600 of 130834 matches
Mail list logo
