subject:"\\\\\\\[PULL\\\\\\\] http\\\\\\\:\\\\\\\/\\\\\\\/kernellabs.com\\\\\\\/hg\\\\\\\/\\\\\\\~stoth\\\\\\\/saa7164\\\\\\\-v4l"

Re: Re: [PULL] http://kernellabs.com/hg/~stoth/saa7164-v4l

2010-10-15 Thread Steven Toth

Sorry, SOB

On Thu, Oct 14, 2010 at 12:36 PM, Mauro Carvalho Chehab
mche...@redhat.com wrote:
 Hi Steven,

 I'm still missing your SOB for the three patches from Gavin.

 Please reply to this thread publicly with your SOB, and I'll add both SOB's 
 on my tree.

 Thanks,
 Mauro

Sorry, a mix of travel and time away from email.

For all three patches by Gavin:

Signed-off-by: Steven Toth st...@kernellabs.com

Regards,

- Steve

-- 
Steven Toth - Kernel Labs
http://www.kernellabs.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PULL] http://kernellabs.com/hg/~stoth/saa7164-v4l

2010-10-11 Thread Mauro Carvalho Chehab

Hi stoth,

Em 31-07-2010 17:42, Steven Toth escreveu:
 Mauro,
 
 Analog Encoder and VBI support in the SAA7164 tree, for the HVR2200
 and HVR2250 cards.
 
 Please pull from http://www.kernellabs.com/hg/~stoth/saa7164-v4l
 

As requested on irc, I've pulled from your tree again, and fixed a few things
on your patch series (a warning and _lots_ of checkpatch issues).

There are still some compilation breakages in the middle of your patch series.
So, I'll fold some patches, in order to avoid the issues.

There are still a few checkpatch issues (I removed all 80-columns warning 
noise).
Could you please double check them?

To make life easier for you, I've created a temp git tree at:
http://git.linuxtv.org/mchehab/stoth.git

The checkpatch.pl errors/warnings are enclosed bellow.

Thanks,
Mauro

---

WARNING: braces {} are not necessary for single statement blocks
#47: FILE: drivers/media/video/saa7164/saa7164-api.c:43:
+   if (ret != SAA_OK) {
+   printk(KERN_ERR %s() error, ret = 0x%x\n, __func__, ret);
+   }

WARNING: braces {} are not necessary for single statement blocks
#70: FILE: drivers/media/video/saa7164/saa7164-api.c:66:
+   if (ret != SAA_OK) {
+   printk(KERN_ERR %s() error, ret = 0x%x\n, __func__, 
ret);
+   }

WARNING: braces {} are not necessary for single statement blocks
#93: FILE: drivers/media/video/saa7164/saa7164-api.c:89:
+   if (ret != SAA_OK) {
+   printk(KERN_ERR %s() error, ret = 0x%x\n, __func__, ret);
+   }

WARNING: braces {} are not necessary for single statement blocks
#103: FILE: drivers/media/video/saa7164/saa7164-api.c:99:
+   if (ret != SAA_OK) {
+   printk(KERN_ERR %s() error, ret = 0x%x\n, __func__, ret);
+   }

ERROR: do not use C99 // comments
#654: FILE: drivers/media/video/saa7164/saa7164-api.c:650:
+   //saa7164_dumphex16(dev, buf, 16);

WARNING: kfree(NULL) is safe this check is probably not required
#1381: FILE: drivers/media/video/saa7164/saa7164-buffer.c:317:
+   if (buf-data) {
+   kfree(buf-data);

WARNING: kfree(NULL) is safe this check is probably not required
#1386: FILE: drivers/media/video/saa7164/saa7164-buffer.c:322:
+   if (buf)
+   kfree(buf);

ERROR: do not use C99 // comments
#1962: FILE: drivers/media/video/saa7164/saa7164-core.c:126:
+// saa7164_dumphex16FF(buf-port-dev, (p + i), 32);

WARNING: braces {} are not necessary for single statement blocks
#2038: FILE: drivers/media/video/saa7164/saa7164-core.c:202:
+   for (i = 0; i  30; i++) {
+   hg-counter1[0 + i].val = i;
+   }

WARNING: braces {} are not necessary for single statement blocks
#2043: FILE: drivers/media/video/saa7164/saa7164-core.c:207:
+   for (i = 0; i  18; i++) {
+   hg-counter1[30 + i].val = 30 + (i * 10);
+   }

WARNING: braces {} are not necessary for single statement blocks
#2048: FILE: drivers/media/video/saa7164/saa7164-core.c:212:
+   for (i = 0; i  15; i++) {
+   hg-counter1[48 + i].val = 200 + (i * 200);
+   }

WARNING: %Ld/%Lu are not-standard C, use %lld/%llu
#2103: FILE: drivers/media/video/saa7164/saa7164-core.c:267:
+   printk(KERN_ERR  %4d %12d %Ld\n,

ERROR: do not use C99 // comments
#2154: FILE: drivers/media/video/saa7164/saa7164-core.c:318:
+// saa7164_dumphex16FF(dev, (p + 
buf-actual_size) - 32 , 64);

WARNING: %Ld/%Lu are not-standard C, use %lld/%llu
#2239: FILE: drivers/media/video/saa7164/saa7164-core.c:403:
+   %s() %Ldms elapsed irq-deferred %Ldms wp: %d rp: %d\n,

WARNING: %Ld/%Lu are not-standard C, use %lld/%llu
#2315: FILE: drivers/media/video/saa7164/saa7164-core.c:479:
+   %s() %Ldms elapsed irq-deferred %Ldms wp: %d rp: %d\n,

WARNING: %Ld/%Lu are not-standard C, use %lld/%llu
#2402: FILE: drivers/media/video/saa7164/saa7164-core.c:567:
+   dprintk(DBGLVL_IRQ, %s() %Ldms elapsed\n, __func__,

WARNING: %Ld/%Lu are not-standard C, use %lld/%llu
#2427: FILE: drivers/media/video/saa7164/saa7164-core.c:592:
+   dprintk(DBGLVL_IRQ, %s() %Ldms elapsed\n, __func__,

ERROR: else should follow close brace '}'
#2606: FILE: drivers/media/video/saa7164/saa7164-core.c:965:
+   }
+   else

WARNING: struct file_operations should normally be const
#2747: FILE: drivers/media/video/saa7164/saa7164-core.c:1172:
+static struct file_operations saa7164_proc_fops = {

WARNING: braces {} are not necessary for single statement blocks
#4427: FILE: drivers/media/video/saa7164/saa7164-encoder.c:1236:
+   if (ubuf-pos  ubuf-actual_size) {
+   printk(KERN_ERR read() pos  actual, huh?\n);
+   }

WARNING: braces {} are not necessary for single statement blocks
#4453: FILE: drivers/media/video/saa7164/saa7164-encoder.c:1262:
+   if (!ret  !ubuf) {
+   ret = -EAGAIN;
+   }

WARNING: braces {} are not

Re: [PULL] http://kernellabs.com/hg/~stoth/saa7164-v4l

2010-10-11 Thread Mauro Carvalho Chehab

Em 11-10-2010 18:03, Mauro Carvalho Chehab escreveu:
 Hi stoth,
 
 Em 31-07-2010 17:42, Steven Toth escreveu:
 Mauro,

 Analog Encoder and VBI support in the SAA7164 tree, for the HVR2200
 and HVR2250 cards.

 Please pull from http://www.kernellabs.com/hg/~stoth/saa7164-v4l

 
 As requested on irc, I've pulled from your tree again, and fixed a few things
 on your patch series (a warning and _lots_ of checkpatch issues).
 
 There are still some compilation breakages in the middle of your patch series.
 So, I'll fold some patches, in order to avoid the issues.
 
 There are still a few checkpatch issues (I removed all 80-columns warning 
 noise).
 Could you please double check them?
 
 To make life easier for you, I've created a temp git tree at:
   http://git.linuxtv.org/mchehab/stoth.git

Stoth,

I realized that I missed a few patches on my queue. I've applied them also at 
the
git tree. There are a few issues on some of them:

commit a5209649cb5aa8a706e6ed5ab74378f2f95c64bf
Author: Steven Toth st...@kernellabs.com
Date:   Wed Oct 6 21:52:22 2010 -0300

V4L/DVB: saa7164: Removed use of the BKL

Remove usage of the BKL and instead used video_set_drvdata() during
   open fops.

Signed-off-by: Steven Toth st...@kernellabs.com
Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com

There were some conflicts on this patch. Please verify that the conflict solve
went ok.

commit 86ae40b5f3da13c5fd0c70731aac6447c6af4cd8
Author: Gavin Hurlbut gjhur...@gmail.com
Date:   Thu Sep 30 18:21:20 2010 -0300

V4L/DVB: Fix the -E{*} returns in the VBI device as well

commit f92f45822ce73cfc4bde8d61a75598fb9db35d6b
Author: Gavin Hurlbut gjhur...@gmail.com
Date:   Wed Sep 29 15:18:20 2010 -0300

V4L/DVB: Fix the negative -E{BLAH} returns from fops_read

commit 25b5ab78a5240c82baa78167e55c8d74a6e0a276
Author: Gavin Hurlbut gjhur...@gmail.com
Date:   Mon Sep 27 23:50:43 2010 -0300

V4L/DVB: Change the second input names to include  2 to distinguish them

Those three patches are missing your Signed-off-by: and Gavin's Signed-off-by:

Could you please provide it?

Thanks,
Mauro
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PULL] http://kernellabs.com/hg/~stoth/saa7164-v4l

2010-10-11 Thread Gavin Hurlbut

I replied earlier, but due to gmail wanting to send HTML mail by
default (grr), it bounced when sending to the list   Original
reply (slightly reformatted) follows:

commit 86ae40b5f3da13c5fd0c70731aac6447c6af4cd8
Author: Gavin Hurlbut gjhur...@gmail.com
Date:   Thu Sep 30 18:21:20 2010 -0300

V4L/DVB: Fix the -E{*} returns in the VBI device as well

commit f92f45822ce73cfc4bde8d61a75598fb9db35d6b
Author: Gavin Hurlbut gjhur...@gmail.com
Date:   Wed Sep 29 15:18:20 2010 -0300

V4L/DVB: Fix the negative -E{BLAH} returns from fops_read

commit 25b5ab78a5240c82baa78167e55c8d74a6e0a276
Author: Gavin Hurlbut gjhur...@gmail.com
Date:   Mon Sep 27 23:50:43 2010 -0300

V4L/DVB: Change the second input names to include  2 to distinguish them

 Those three patches are missing your Signed-off-by: and Gavin's Signed-off-by:

 Could you please provide it?

Chock those up to me missing putting the Signed-off-by: lines in the
patches I sent to Steven due to me being new to mercurial.  Is there a
way for me to add it posthumously, as it were?  I'll be sure to add
that in any future patches, and I apologize for the oversight.  It
would be (for all three patches):

Signed-off-by: Gavin Hurlbut gjhur...@gmail.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PULL] http://kernellabs.com/hg/~stoth/saa7164-v4l

2010-07-31 Thread Steven Toth

Mauro,

Analog Encoder and VBI support in the SAA7164 tree, for the HVR2200
and HVR2250 cards.

Please pull from http://www.kernellabs.com/hg/~stoth/saa7164-v4l

   -  saa7164: basic definitions for -encoder.c
   -  saa7164: Add some encoder firmwares message types and structs
   -  saa7164: convert buffering structs to be more generic
   -  saa7164: add various encoder message functions
   -  saa7164: Implement encoder irq handling in a deferred work queue.
   -  saa7164: command dequeue fixup to clean the bus after error.
   -  saa7164: allow the encoder GOP structure to be configured
   -  saa7164: generate a fixed kernel warning if the irq is 'late'
   -  saa7164: add support for encoder CBR and VBR optionally.
   -  saa7164: allow the IBP reference distance to be configurable
   -  saa7164: implement encoder peak bitrate feature
   -  saa7164: allow encoder output format to be user configurable
   -  saa7164: allow variable length GOP sizes and switch encoder default to CBR
   -  saa7164: patches to monitor TS payload for inconsistencies
   -  saa7164: allow the number of encoder buffers to be user configurable
   -  saa7164: measure via histograms various irq and queue latencies
   -  saa7164: add guard bytes around critical buffers to detect failure.
   -  saa7164: buffer crc checks and ensure we use the correct PCIe IO
memcpy func
   -  saa7164: adjust the PS pack size handling to fill buffers 100%
   -  saa7164: Implement resolution control firmware command
   -  saa7164: mundane buffer debugging changes to track issues
   -  saa7164: irqhandler cleanup and helper function added
   -  saa7164: code cleanup
   -  saa7164: allow DMA engin buffers to vary in size between analog
and digital
   -  saa7164: New firmware changes, new size, new filename
   -  saa7164: Avoid spurious error after firmware starts
   -  saa7164: rename a structure for readability
   -  saa7164: add NTSC VBI support
   -  saa7164: add firmware debug message collection and procfs changes
   -  saa7164: VBI irq cleanup and V4L VBI raw pitch adjustments
   -  saa7164: Monitor the command bus and check for inconsistencies
   -  saa7164: enforce the march 10th firmware is used.
   -  saa7164: collect/show the firmware debugging via a thread
   -  saa7164: monitor the RISC cpu load via a thread
   -  saa7164: video_is_registered() func change
   -  saa7164: change debug to saa_debug
   -  saa7164: Add missing saa7164-vbi.c file.
   -  saa7164: fix vbi compiler warnings
   -  saa7164: if 0/1 cleanups

 b/linux/drivers/media/video/saa7164/saa7164-encoder.c |   23
 b/linux/drivers/media/video/saa7164/saa7164-vbi.c | 1459 ++
 linux/drivers/media/video/saa7164/Makefile|4
 linux/drivers/media/video/saa7164/saa7164-api.c   | 1143 -
 linux/drivers/media/video/saa7164/saa7164-buffer.c|  204
 linux/drivers/media/video/saa7164/saa7164-bus.c   |  231 -
 linux/drivers/media/video/saa7164/saa7164-cards.c |   56
 linux/drivers/media/video/saa7164/saa7164-cmd.c   |   21
 linux/drivers/media/video/saa7164/saa7164-core.c  | 2103 ++
 linux/drivers/media/video/saa7164/saa7164-dvb.c   |  109
 linux/drivers/media/video/saa7164/saa7164-encoder.c   | 1872 
 linux/drivers/media/video/saa7164/saa7164-fw.c|   35
 linux/drivers/media/video/saa7164/saa7164-i2c.c   |2
 linux/drivers/media/video/saa7164/saa7164-reg.h   |   70
 linux/drivers/media/video/saa7164/saa7164-types.h |  183
 linux/drivers/media/video/saa7164/saa7164-vbi.c   |   53
 linux/drivers/media/video/saa7164/saa7164.h   |  328 +
 17 files changed, 6421 insertions(+), 1475 deletions(-)

Regards,

-- 
Steven Toth - Kernel Labs
http://www.kernellabs.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Re: [PULL] http://kernellabs.com/hg/~stoth/saa7164-v4l

Re: [PULL] http://kernellabs.com/hg/~stoth/saa7164-v4l

Re: [PULL] http://kernellabs.com/hg/~stoth/saa7164-v4l

Re: [PULL] http://kernellabs.com/hg/~stoth/saa7164-v4l

[PULL] http://kernellabs.com/hg/~stoth/saa7164-v4l

5 matches

Site Navigation

Mail list logo

Footer information