Re: [PATCH] media: Add support for arbitrary resolution for the ov5642 camera driver

2011-08-31 Thread Bastian Hecht
Hello Laurent, 2011/8/28 Laurent Pinchart laurent.pinch...@ideasonboard.com: Hi Bastian, Thanks for the patch. [snip] +#define REG_RED_GAIN_HIGH            0x3400 +#define REG_RED_GAIN_LOW             0x3401 +#define REG_BLUE_GAIN_HIGH           0x3404 +#define REG_BLUE_GAIN_LOW        

Re: [PATCH] media: Add support for arbitrary resolution for the ov5642 camera driver

2011-08-30 Thread Guennadi Liakhovetski
On Mon, 29 Aug 2011, Laurent Pinchart wrote: Hi Guennadi, On Monday 29 August 2011 14:34:53 Guennadi Liakhovetski wrote: On Mon, 29 Aug 2011, Laurent Pinchart wrote: On Monday 29 August 2011 14:18:50 Guennadi Liakhovetski wrote: On Sun, 28 Aug 2011, Laurent Pinchart wrote:

Re: [PATCH] media: Add support for arbitrary resolution for the ov5642 camera driver

2011-08-30 Thread Sakari Ailus
On Mon, Aug 29, 2011 at 02:18:50PM +0200, Guennadi Liakhovetski wrote: Hi Laurent On Sun, 28 Aug 2011, Laurent Pinchart wrote: [snip] @@ -593,8 +639,7 @@ static struct ov5642 *to_ov5642(const struct i2c_client *client) } /* Find a data format by a pixel code in an array

Re: [PATCH] media: Add support for arbitrary resolution for the ov5642 camera driver

2011-08-30 Thread Laurent Pinchart
Hi Guennadi, On Tuesday 30 August 2011 10:55:08 Guennadi Liakhovetski wrote: On Mon, 29 Aug 2011, Laurent Pinchart wrote: On Monday 29 August 2011 14:34:53 Guennadi Liakhovetski wrote: On Mon, 29 Aug 2011, Laurent Pinchart wrote: On Monday 29 August 2011 14:18:50 Guennadi Liakhovetski

Re: [PATCH] media: Add support for arbitrary resolution for the ov5642 camera driver

2011-08-30 Thread Guennadi Liakhovetski
(also replying to a similar comment by Sakari) On Tue, 30 Aug 2011, Laurent Pinchart wrote: Hi Guennadi, On Tuesday 30 August 2011 10:55:08 Guennadi Liakhovetski wrote: On Mon, 29 Aug 2011, Laurent Pinchart wrote: On Monday 29 August 2011 14:34:53 Guennadi Liakhovetski wrote: On

Re: [PATCH] media: Add support for arbitrary resolution for the ov5642 camera driver

2011-08-30 Thread Laurent Pinchart
Hi Mauro, Could you please comment on this ? In a nutshell (and from my biased point of view), the question is can cropping be configured using S_FMT instead of S_CROP ?. The answer is of course no :-) On Tuesday 30 August 2011 15:13:25 Guennadi Liakhovetski wrote: On Tue, 30 Aug 2011,

Re: [PATCH] media: Add support for arbitrary resolution for the ov5642 camera driver

2011-08-30 Thread Laurent Pinchart
Hi Guennadi, On Tuesday 30 August 2011 15:13:25 Guennadi Liakhovetski wrote: On Tue, 30 Aug 2011, Laurent Pinchart wrote: On Tuesday 30 August 2011 10:55:08 Guennadi Liakhovetski wrote: On Mon, 29 Aug 2011, Laurent Pinchart wrote: On Monday 29 August 2011 14:34:53 Guennadi Liakhovetski

Re: [PATCH] media: Add support for arbitrary resolution for the ov5642 camera driver

2011-08-30 Thread Guennadi Liakhovetski
On Tue, 30 Aug 2011, Laurent Pinchart wrote: Hi Guennadi, On Tuesday 30 August 2011 15:13:25 Guennadi Liakhovetski wrote: On Tue, 30 Aug 2011, Laurent Pinchart wrote: On Tuesday 30 August 2011 10:55:08 Guennadi Liakhovetski wrote: On Mon, 29 Aug 2011, Laurent Pinchart wrote: On

Re: [PATCH] media: Add support for arbitrary resolution for the ov5642 camera driver

2011-08-30 Thread Bastian Hecht
Hello Laurent and others, 2011/8/30 Laurent Pinchart laurent.pinch...@ideasonboard.com: Hi Guennadi, On Tuesday 30 August 2011 15:13:25 Guennadi Liakhovetski wrote: On Tue, 30 Aug 2011, Laurent Pinchart wrote: On Tuesday 30 August 2011 10:55:08 Guennadi Liakhovetski wrote: On Mon, 29 Aug

Re: [PATCH] media: Add support for arbitrary resolution for the ov5642 camera driver

2011-08-30 Thread Hans Verkuil
On Tuesday, August 30, 2011 15:13:25 Guennadi Liakhovetski wrote: (also replying to a similar comment by Sakari) On Tue, 30 Aug 2011, Laurent Pinchart wrote: Hi Guennadi, On Tuesday 30 August 2011 10:55:08 Guennadi Liakhovetski wrote: On Mon, 29 Aug 2011, Laurent Pinchart wrote:

Re: [PATCH] media: Add support for arbitrary resolution for the ov5642 camera driver

2011-08-30 Thread Guennadi Liakhovetski
Hi Hans On Tue, 30 Aug 2011, Hans Verkuil wrote: On Tuesday, August 30, 2011 15:13:25 Guennadi Liakhovetski wrote: (also replying to a similar comment by Sakari) On Tue, 30 Aug 2011, Laurent Pinchart wrote: Hi Guennadi, On Tuesday 30 August 2011 10:55:08 Guennadi

Re: [PATCH] media: Add support for arbitrary resolution for the ov5642 camera driver

2011-08-30 Thread Hans Verkuil
On Tuesday, August 30, 2011 16:24:55 Guennadi Liakhovetski wrote: Hi Hans On Tue, 30 Aug 2011, Hans Verkuil wrote: On Tuesday, August 30, 2011 15:13:25 Guennadi Liakhovetski wrote: (also replying to a similar comment by Sakari) On Tue, 30 Aug 2011, Laurent Pinchart wrote:

Re: [PATCH] media: Add support for arbitrary resolution for the ov5642 camera driver

2011-08-30 Thread Guennadi Liakhovetski
On Tue, 30 Aug 2011, Hans Verkuil wrote: On Tuesday, August 30, 2011 16:24:55 Guennadi Liakhovetski wrote: Hi Hans On Tue, 30 Aug 2011, Hans Verkuil wrote: [snip] The problem with S_FMT changing the crop rectangle (and I assume we are not talking about small pixel tweaks to

Re: [PATCH] media: Add support for arbitrary resolution for the ov5642 camera driver

2011-08-30 Thread Bastian Hecht
2011/8/30 Guennadi Liakhovetski g.liakhovet...@gmx.de: On Tue, 30 Aug 2011, Hans Verkuil wrote: On Tuesday, August 30, 2011 16:24:55 Guennadi Liakhovetski wrote: Hi Hans On Tue, 30 Aug 2011, Hans Verkuil wrote: [snip] The problem with S_FMT changing the crop rectangle (and I assume

Re: [PATCH] media: Add support for arbitrary resolution for the ov5642 camera driver

2011-08-30 Thread Guennadi Liakhovetski
On Tue, 30 Aug 2011, Bastian Hecht wrote: 2011/8/30 Guennadi Liakhovetski g.liakhovet...@gmx.de: On Tue, 30 Aug 2011, Hans Verkuil wrote: On Tuesday, August 30, 2011 16:24:55 Guennadi Liakhovetski wrote: Hi Hans On Tue, 30 Aug 2011, Hans Verkuil wrote: [snip] The problem

Re: [PATCH] media: Add support for arbitrary resolution for the ov5642 camera driver

2011-08-30 Thread Laurent Pinchart
Hi Guennadi, On Tuesday 30 August 2011 17:34:05 Guennadi Liakhovetski wrote: On Tue, 30 Aug 2011, Bastian Hecht wrote: 2011/8/30 Guennadi Liakhovetski g.liakhovet...@gmx.de: On Tue, 30 Aug 2011, Hans Verkuil wrote: On Tuesday, August 30, 2011 16:24:55 Guennadi Liakhovetski wrote: Hi

Re: [PATCH] media: Add support for arbitrary resolution for the ov5642 camera driver

2011-08-29 Thread Guennadi Liakhovetski
Hi Laurent On Sun, 28 Aug 2011, Laurent Pinchart wrote: [snip] @@ -593,8 +639,7 @@ static struct ov5642 *to_ov5642(const struct i2c_client *client) } /* Find a data format by a pixel code in an array */ -static const struct ov5642_datafmt -

Re: [PATCH] media: Add support for arbitrary resolution for the ov5642 camera driver

2011-08-29 Thread Laurent Pinchart
Hi Guennadi, On Monday 29 August 2011 14:18:50 Guennadi Liakhovetski wrote: On Sun, 28 Aug 2011, Laurent Pinchart wrote: [snip] @@ -593,8 +639,7 @@ static struct ov5642 *to_ov5642(const struct i2c_client *client) } /* Find a data format by a pixel code in an array */

Re: [PATCH] media: Add support for arbitrary resolution for the ov5642 camera driver

2011-08-29 Thread Guennadi Liakhovetski
On Mon, 29 Aug 2011, Laurent Pinchart wrote: Hi Guennadi, On Monday 29 August 2011 14:18:50 Guennadi Liakhovetski wrote: On Sun, 28 Aug 2011, Laurent Pinchart wrote: [snip] @@ -593,8 +639,7 @@ static struct ov5642 *to_ov5642(const struct i2c_client *client) } /*

Re: [PATCH] media: Add support for arbitrary resolution for the ov5642 camera driver

2011-08-29 Thread Laurent Pinchart
Hi Guennadi, On Monday 29 August 2011 14:34:53 Guennadi Liakhovetski wrote: On Mon, 29 Aug 2011, Laurent Pinchart wrote: On Monday 29 August 2011 14:18:50 Guennadi Liakhovetski wrote: On Sun, 28 Aug 2011, Laurent Pinchart wrote: [snip] @@ -593,8 +639,7 @@ static struct

Re: [PATCH] media: Add support for arbitrary resolution for the ov5642 camera driver

2011-08-28 Thread Laurent Pinchart
Hi Bastian, Thanks for the patch. On Wednesday 17 August 2011 17:53:42 Bastian Hecht wrote: This patch adds the ability to get arbitrary resolutions with a width up to 2592 and a height up to 720 pixels instead of the standard 1280x720 only. Signed-off-by: Bastian Hecht hec...@gmail.com

[PATCH] media: Add support for arbitrary resolution for the ov5642 camera driver

2011-08-17 Thread Bastian Hecht
This patch adds the ability to get arbitrary resolutions with a width up to 2592 and a height up to 720 pixels instead of the standard 1280x720 only. Signed-off-by: Bastian Hecht hec...@gmail.com --- diff --git a/drivers/media/video/ov5642.c b/drivers/media/video/ov5642.c index 6410bda..1b40d90