RE: [PATCH 1/7] v4l: add videobuf2 Video for Linux 2 driver framework

2010-11-28 Thread Marek Szyprowski
Hello, On Friday, November 26, 2010 7:00 PM Laurent Pinchart wrote: > On Friday 26 November 2010 17:49:02 Pawel Osciak wrote: > > On Thu, Nov 25, 2010 at 01:48, Marek Szyprowski wrote: > > > Hello, > > > > > > On Thursday, November 25, 2010 2:17 AM Laurent Pinchart wrote: > > >> On Friday 19 Nove

Re: [PATCH 1/7] v4l: add videobuf2 Video for Linux 2 driver framework

2010-11-26 Thread Laurent Pinchart
Hi Pawel, On Friday 26 November 2010 17:49:02 Pawel Osciak wrote: > On Thu, Nov 25, 2010 at 01:48, Marek Szyprowski wrote: > > Hello, > > > > On Thursday, November 25, 2010 2:17 AM Laurent Pinchart wrote: > >> On Friday 19 November 2010 16:55:38 Marek Szyprowski wrote: > >> > From: Pawel Osciak

Re: [PATCH 1/7] v4l: add videobuf2 Video for Linux 2 driver framework

2010-11-26 Thread Laurent Pinchart
Hi Hans, On Thursday 25 November 2010 12:23:18 Hans Verkuil wrote: > On Thursday, November 25, 2010 10:48:39 Marek Szyprowski wrote: > > On Thursday, November 25, 2010 2:17 AM Laurent Pinchart wrote: > > > On Friday 19 November 2010 16:55:38 Marek Szyprowski wrote: > > > > From: Pawel Osciak [sn

Re: [PATCH 1/7] v4l: add videobuf2 Video for Linux 2 driver framework

2010-11-26 Thread Laurent Pinchart
Hi Marek, On Thursday 25 November 2010 10:48:39 Marek Szyprowski wrote: > On Thursday, November 25, 2010 2:17 AM Laurent Pinchart wrote: > > On Friday 19 November 2010 16:55:38 Marek Szyprowski wrote: > > > From: Pawel Osciak > > > > > > Videobuf2 is a Video for Linux 2 API-compatible driver fra

Re: [PATCH 1/7] v4l: add videobuf2 Video for Linux 2 driver framework

2010-11-26 Thread Pawel Osciak
Hi, On Thu, Nov 25, 2010 at 03:23, Hans Verkuil wrote: > On Thursday, November 25, 2010 10:48:39 Marek Szyprowski wrote: >> Hello, >> >> On Thursday, November 25, 2010 2:17 AM Laurent Pinchart wrote: >> >> > On Friday 19 November 2010 16:55:38 Marek Szyprowski wrote: >> > > From: Pawel Osciak >>

Re: [PATCH 1/7] v4l: add videobuf2 Video for Linux 2 driver framework

2010-11-26 Thread Pawel Osciak
Hi all, Marek has already answered most of the comments, some of mine below. On Thu, Nov 25, 2010 at 01:48, Marek Szyprowski wrote: > Hello, > > On Thursday, November 25, 2010 2:17 AM Laurent Pinchart wrote: > >> On Friday 19 November 2010 16:55:38 Marek Szyprowski wrote: >> > From: Pawel Osciak

RE: [PATCH 1/7] v4l: add videobuf2 Video for Linux 2 driver framework

2010-11-25 Thread Marek Szyprowski
Hello, On Thursday, November 25, 2010 12:23 PM Hans Verkuil wrote: > On Thursday, November 25, 2010 10:48:39 Marek Szyprowski wrote: > > Hello, > > > > On Thursday, November 25, 2010 2:17 AM Laurent Pinchart wrote: > > > > > On Friday 19 November 2010 16:55:38 Marek Szyprowski wrote: > > > > From

Re: [PATCH 1/7] v4l: add videobuf2 Video for Linux 2 driver framework

2010-11-25 Thread Hans Verkuil
On Thursday, November 25, 2010 10:48:39 Marek Szyprowski wrote: > Hello, > > On Thursday, November 25, 2010 2:17 AM Laurent Pinchart wrote: > > > On Friday 19 November 2010 16:55:38 Marek Szyprowski wrote: > > > From: Pawel Osciak > > > > > > Videobuf2 is a Video for Linux 2 API-compatible drive

RE: [PATCH 1/7] v4l: add videobuf2 Video for Linux 2 driver framework

2010-11-25 Thread Marek Szyprowski
Hello, On Thursday, November 25, 2010 2:17 AM Laurent Pinchart wrote: > On Friday 19 November 2010 16:55:38 Marek Szyprowski wrote: > > From: Pawel Osciak > > > > Videobuf2 is a Video for Linux 2 API-compatible driver framework for > > multimedia devices. It acts as an intermediate layer between

RE: [PATCH 1/7] v4l: add videobuf2 Video for Linux 2 driver framework

2010-11-22 Thread Marek Szyprowski
@samsung.com > > Subject: [PATCH 1/7] v4l: add videobuf2 Video for Linux 2 driver framework > > > > From: Pawel Osciak > > > > Videobuf2 is a Video for Linux 2 API-compatible driver framework for > > multimedia devices. It acts as an intermediate layer between use

RE: [PATCH 1/7] v4l: add videobuf2 Video for Linux 2 driver framework

2010-11-22 Thread Sewoon Park
Hi~ Marek. Some comments in here. Saturday, November 20, 2010 12:56 AM Marek Szyprowski wrote : > To: linux-media@vger.kernel.org > Cc: m.szyprow...@samsung.com; pa...@osciak.com; kyungmin.p...@samsung.com > Subject: [PATCH 1/7] v4l: add videobuf2 Video for Linux 2 driver framework

[PATCH 1/7] v4l: add videobuf2 Video for Linux 2 driver framework

2010-11-19 Thread Marek Szyprowski
From: Pawel Osciak Videobuf2 is a Video for Linux 2 API-compatible driver framework for multimedia devices. It acts as an intermediate layer between userspace applications and device drivers. It also provides low-level, modular memory management functions for drivers. Videobuf2 eases driver deve

RE: [PATCH 1/7] v4l: add videobuf2 Video for Linux 2 driver framework

2010-11-18 Thread Marek Szyprowski
Hello, On Thursday, November 18, 2010 1:27 PM Andy Walls wrote: > Hi Hans and Marek, > > Some meta-comments below... ;) > > On Thu, 2010-11-18 at 10:17 +0100, Hans Verkuil wrote: > > Hi Marek! > > > > Some comments below... > > > > On Wednesday, November 17, 2010 09:39:28 Marek Szyprowski wrote

Re: [PATCH 1/7] v4l: add videobuf2 Video for Linux 2 driver framework

2010-11-18 Thread Pawel Osciak
Hi Hans, On Thu, Nov 18, 2010 at 01:17, Hans Verkuil wrote: > Hi Marek! > > Some comments below... > > On Wednesday, November 17, 2010 09:39:28 Marek Szyprowski wrote: >> From: Pawel Osciak >> +/** >> + * struct vb2_mem_ops - memory handling/memory allocator operations >> + * @alloc:   allocate

Re: [PATCH 1/7] v4l: add videobuf2 Video for Linux 2 driver framework

2010-11-18 Thread Hans Verkuil
> Hi Hans and Marek, > > Some meta-comments below... ;) > > On Thu, 2010-11-18 at 10:17 +0100, Hans Verkuil wrote: >> > +#define mem_ops(q, plane) ((q)->alloc_ctx[plane]->mem_ops) >> > + >> > +#define call_memop(q, plane, op, args...) \ >> > + (((q)->alloc_ctx[plane]->mem_

[PATCH 1/7] v4l: add videobuf2 Video for Linux 2 driver framework

2010-11-17 Thread Marek Szyprowski
From: Pawel Osciak Videobuf2 is a Video for Linux 2 API-compatible driver framework for multimedia devices. It acts as an intermediate layer between userspace applications and device drivers. It also provides low-level, modular memory management functions for drivers. Videobuf2 eases driver deve

RE: [PATCH 1/7] v4l: add videobuf2 Video for Linux 2 driver framework

2010-10-25 Thread Marek Szyprowski
Hello, On Monday, October 25, 2010 2:17 AM Pawel Osciak wrote: > On Tue, Oct 19, 2010 at 23:41, Marek Szyprowski > wrote: > > From: Pawel Osciak > > > +/** > > + * __vb2_queue_cancel() - cancel and stop (pause) streaming > > + * > > + * Removes all queued buffers from driver's queue and all bu

Re: [PATCH 1/7] v4l: add videobuf2 Video for Linux 2 driver framework

2010-10-24 Thread Pawel Osciak
Hi Marek, Thanks for your patches, I went through your changes. Minor comments below. On Tue, Oct 19, 2010 at 23:41, Marek Szyprowski wrote: > From: Pawel Osciak > +/** > + * __vb2_queue_cancel() - cancel and stop (pause) streaming > + * > + * Removes all queued buffers from driver's queue and

[PATCH 1/7] v4l: add videobuf2 Video for Linux 2 driver framework

2010-10-19 Thread Marek Szyprowski
From: Pawel Osciak Videobuf2 is a Video for Linux 2 API-compatible driver framework for multimedia devices. It acts as an intermediate layer between userspace applications and device drivers. It also provides low-level, modular memory management functions for drivers. Videobuf2 eases driver deve