Re: [PATCH v1] media: rc: Add driver for tango IR decoder

2017-09-21 Thread Sean Young
On Tue, Sep 19, 2017 at 02:43:17PM +0200, Marc Gonzalez wrote: > + Rob & Mark for the DT bindings question. > > On 19/09/2017 14:21, Måns Rullgård wrote: > > > Marc Gonzalez writes: > > > >> On 18/09/2017 17:33, Måns Rullgård wrote: > >> > >>> What have you changed compared to my original code?

Re: [PATCH v1] media: rc: Add driver for tango IR decoder

2017-09-19 Thread Måns Rullgård
Marc Gonzalez writes: > + Rob & Mark for the DT bindings question. > > On 19/09/2017 14:21, Måns Rullgård wrote: > >> Marc Gonzalez writes: >> >>> On 18/09/2017 17:33, Måns Rullgård wrote: >>> What have you changed compared to my original code? >>> >>> I

Re: [PATCH v1] media: rc: Add driver for tango IR decoder

2017-09-19 Thread Marc Gonzalez
+ Rob & Mark for the DT bindings question. On 19/09/2017 14:21, Måns Rullgård wrote: > Marc Gonzalez writes: > >> On 18/09/2017 17:33, Måns Rullgård wrote: >> >>> What have you changed compared to my original code? >> >> I forgot to mention one change you may not approve of, so we should >>

Re: [PATCH v1] media: rc: Add driver for tango IR decoder

2017-09-19 Thread Måns Rullgård
Marc Gonzalez writes: > On 18/09/2017 17:33, Måns Rullgård wrote: > >> What have you changed compared to my original code? > > I forgot to mention one change you may not approve of, so we should > probably discuss it. > > Your driver supported an optional DT

Re: [PATCH v1] media: rc: Add driver for tango IR decoder

2017-09-19 Thread Måns Rullgård
Marc Gonzalez writes: > On 19/09/2017 11:48, Måns Rullgård wrote: > >> Did you test the NEC32 variant? I don't have anything that produces >> such codes. > > I don't have a NEC32 IR remote control either. > > IIUC, NEC32 means 16-bit address and 16-bit command. >

Re: [PATCH v1] media: rc: Add driver for tango IR decoder

2017-09-19 Thread Marc Gonzalez
On 18/09/2017 17:33, Måns Rullgård wrote: > What have you changed compared to my original code? I forgot to mention one change you may not approve of, so we should probably discuss it. Your driver supported an optional DT property "linux,rc-map-name" to override the RC_MAP_EMPTY map. Since the

Re: [PATCH v1] media: rc: Add driver for tango IR decoder

2017-09-19 Thread Marc Gonzalez
On 19/09/2017 11:48, Måns Rullgård wrote: > Did you test the NEC32 variant? I don't have anything that produces > such codes. I don't have a NEC32 IR remote control either. IIUC, NEC32 means 16-bit address and 16-bit command. I checked the RTL with a HW engineer. The HW block translates the

Re: [PATCH v1] media: rc: Add driver for tango IR decoder

2017-09-19 Thread Måns Rullgård
Marc Gonzalez writes: > On 18/09/2017 17:33, Måns Rullgård wrote: > >> Marc Gonzalez writes: >> >>> diff --git a/drivers/media/rc/Kconfig b/drivers/media/rc/Kconfig >>> index d9ce8ff55d0c..f84923289964 100644 >>> --- a/drivers/media/rc/Kconfig >>> +++

Re: [PATCH v1] media: rc: Add driver for tango IR decoder

2017-09-19 Thread Marc Gonzalez
On 18/09/2017 17:33, Måns Rullgård wrote: > Marc Gonzalez writes: > >> diff --git a/drivers/media/rc/Kconfig b/drivers/media/rc/Kconfig >> index d9ce8ff55d0c..f84923289964 100644 >> --- a/drivers/media/rc/Kconfig >> +++ b/drivers/media/rc/Kconfig >> @@ -469,6 +469,11 @@ config IR_SIR >>

Re: [PATCH v1] media: rc: Add driver for tango IR decoder

2017-09-18 Thread Måns Rullgård
Marc Gonzalez writes: > The tango IR decoder supports NEC, RC-5, RC-6 protocols. > NB: Only the NEC decoder was tested. > > Signed-off-by: Marc Gonzalez > --- > drivers/media/rc/Kconfig| 5 + > drivers/media/rc/Makefile |

[PATCH v1] media: rc: Add driver for tango IR decoder

2017-09-18 Thread Marc Gonzalez
The tango IR decoder supports NEC, RC-5, RC-6 protocols. NB: Only the NEC decoder was tested. Signed-off-by: Marc Gonzalez --- drivers/media/rc/Kconfig| 5 + drivers/media/rc/Makefile | 1 + drivers/media/rc/tango-ir.c | 263