Re: [PATCH v7 13/13] V4L: Add driver for s5k4e5 image sensor
Hi Arun, On 09/11/2013 07:10 AM, Arun Kumar K wrote: > If I name it to reset-gpios, the function of_get_gpio_flags() in the driver > fails. This function searches for the entry with name "gpios". Is it still > recommended to use a custom name and parse it explicitly? I guess so, you could just use of_get_named_gpio_flags(). Regards, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7 13/13] V4L: Add driver for s5k4e5 image sensor
Hi Sylwester, On Fri, Sep 6, 2013 at 1:32 AM, Sylwester Nawrocki wrote: > On 08/21/2013 08:34 AM, Arun Kumar K wrote: >> >> This patch adds subdev driver for Samsung S5K4E5 raw image sensor. >> Like s5k6a3, it is also another fimc-is firmware controlled >> sensor. This minimal sensor driver doesn't do any I2C communications >> as its done by ISP firmware. It can be updated if needed to a >> regular sensor driver by adding the I2C communication. >> >> Signed-off-by: Arun Kumar K >> Reviewed-by: Sylwester Nawrocki >> --- >> .../devicetree/bindings/media/i2c/s5k4e5.txt | 43 +++ >> drivers/media/i2c/Kconfig |8 + >> drivers/media/i2c/Makefile |1 + >> drivers/media/i2c/s5k4e5.c | 361 >> >> 4 files changed, 413 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/media/i2c/s5k4e5.txt >> create mode 100644 drivers/media/i2c/s5k4e5.c >> >> diff --git a/Documentation/devicetree/bindings/media/i2c/s5k4e5.txt >> b/Documentation/devicetree/bindings/media/i2c/s5k4e5.txt >> new file mode 100644 >> index 000..5af462c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/i2c/s5k4e5.txt >> @@ -0,0 +1,43 @@ >> +* Samsung S5K4E5 Raw Image Sensor >> + >> +S5K4E5 is a raw image sensor with maximum resolution of 2560x1920 >> +pixels. Data transfer is carried out via MIPI CSI-2 port and controls >> +via I2C bus. >> + >> +Required Properties: >> +- compatible : must be "samsung,s5k4e5" >> +- reg : I2C device address >> +- gpios: reset gpio pin > > > I guess this should be "reset-gpios". How about changing description to: > > - reset-gpios : specifier of a GPIO connected to the RESET pin; > > > ? If I name it to reset-gpios, the function of_get_gpio_flags() in the driver fails. This function searches for the entry with name "gpios". Is it still recommended to use a custom name and parse it explicitly? Regards Arun -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7 13/13] V4L: Add driver for s5k4e5 image sensor
Hi Sylwester,
Will make the changes you suggested.
Will re-spin this entire series with some more minor fixes after more
rigorous testing.
Regards
Arun
On Fri, Sep 6, 2013 at 1:32 AM, Sylwester Nawrocki
wrote:
> On 08/21/2013 08:34 AM, Arun Kumar K wrote:
>>
>> This patch adds subdev driver for Samsung S5K4E5 raw image sensor.
>> Like s5k6a3, it is also another fimc-is firmware controlled
>> sensor. This minimal sensor driver doesn't do any I2C communications
>> as its done by ISP firmware. It can be updated if needed to a
>> regular sensor driver by adding the I2C communication.
>>
>> Signed-off-by: Arun Kumar K
>> Reviewed-by: Sylwester Nawrocki
>> ---
>> .../devicetree/bindings/media/i2c/s5k4e5.txt | 43 +++
>> drivers/media/i2c/Kconfig |8 +
>> drivers/media/i2c/Makefile |1 +
>> drivers/media/i2c/s5k4e5.c | 361
>>
>> 4 files changed, 413 insertions(+)
>> create mode 100644
>> Documentation/devicetree/bindings/media/i2c/s5k4e5.txt
>> create mode 100644 drivers/media/i2c/s5k4e5.c
>>
>> diff --git a/Documentation/devicetree/bindings/media/i2c/s5k4e5.txt
>> b/Documentation/devicetree/bindings/media/i2c/s5k4e5.txt
>> new file mode 100644
>> index 000..5af462c
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/media/i2c/s5k4e5.txt
>> @@ -0,0 +1,43 @@
>> +* Samsung S5K4E5 Raw Image Sensor
>> +
>> +S5K4E5 is a raw image sensor with maximum resolution of 2560x1920
>> +pixels. Data transfer is carried out via MIPI CSI-2 port and controls
>> +via I2C bus.
>> +
>> +Required Properties:
>> +- compatible : must be "samsung,s5k4e5"
>> +- reg : I2C device address
>> +- gpios: reset gpio pin
>
>
> I guess this should be "reset-gpios". How about changing description to:
>
> - reset-gpios : specifier of a GPIO connected to the RESET pin;
>
>
> ?
>>
>> +- clocks : clock specifier for the clock-names property
>
>
> Perhaps something along the lines of:
>
> - clocks : "should contain the sensor's MCLK clock specifier, from
> the common clock bindings"
>
> ?
>>
>> +- clock-names : must contain "mclk" entry
>
>
> Is name of the clock input pin really MCLK ?
>
>
>> +- svdda-supply : core voltage supply
>> +- svddio-supply: I/O voltage supply
>> +
>> +Optional Properties:
>> +- clock-frequency : operating frequency for the sensor
>> +default value will be taken if not provided.
>
>
> How about clarifying it a bit, as Stephen suggested, e.g.:
>
> - clock-frequency : the frequency at which the "mclk" clock should be
> configured to operate, in Hz; if this property is not
> specified default 24 MHz value will be used.
>
>
>> +The device node should be added to respective control bus controller
>> +(e.g. I2C0) nodes and linked to the csis port node, using the common
>> +video interfaces bindings, defined in video-interfaces.txt.
>
>
> This seems misplaced, S5K4E5 image sensor has nothingto do with csis nodes.
> How about something like this instead:
>
> "The common video interfaces bindings (see video-interfaces.txt) should be
> used to specify link to the image data receiver. The S5K6A3(YX) device
> node should contain one 'port' child node with an 'endpoint' subnode.
>
> Following properties are valid for the endpoint node:
> ..."
>
>
>> +Example:
>> +
>> + i2c-isp@1313 {
>> + s5k4e5@20 {
>> + compatible = "samsung,s5k4e5";
>> + reg =<0x20>;
>> + gpios =<&gpx1 2 1>;
>> + clock-frequency =<2400>;
>> + clocks =<&clock 129>;
>> + clock-names = "mclk";
>> + svdda-supply =<...>;
>> + svddio-supply =<...>;
>> + port {
>> + is_s5k4e5_ep: endpoint {
>> + data-lanes =<1 2 3 4>;
>> + remote-endpoint =<&csis0_ep>;
>> + };
>> + };
>> + };
>> + };
>
>
> --
> Thanks,
> Sylwester
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7 13/13] V4L: Add driver for s5k4e5 image sensor
On 08/21/2013 08:34 AM, Arun Kumar K wrote:
This patch adds subdev driver for Samsung S5K4E5 raw image sensor.
Like s5k6a3, it is also another fimc-is firmware controlled
sensor. This minimal sensor driver doesn't do any I2C communications
as its done by ISP firmware. It can be updated if needed to a
regular sensor driver by adding the I2C communication.
Signed-off-by: Arun Kumar K
Reviewed-by: Sylwester Nawrocki
---
.../devicetree/bindings/media/i2c/s5k4e5.txt | 43 +++
drivers/media/i2c/Kconfig |8 +
drivers/media/i2c/Makefile |1 +
drivers/media/i2c/s5k4e5.c | 361
4 files changed, 413 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/i2c/s5k4e5.txt
create mode 100644 drivers/media/i2c/s5k4e5.c
diff --git a/Documentation/devicetree/bindings/media/i2c/s5k4e5.txt
b/Documentation/devicetree/bindings/media/i2c/s5k4e5.txt
new file mode 100644
index 000..5af462c
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/s5k4e5.txt
@@ -0,0 +1,43 @@
+* Samsung S5K4E5 Raw Image Sensor
+
+S5K4E5 is a raw image sensor with maximum resolution of 2560x1920
+pixels. Data transfer is carried out via MIPI CSI-2 port and controls
+via I2C bus.
+
+Required Properties:
+- compatible : must be "samsung,s5k4e5"
+- reg : I2C device address
+- gpios: reset gpio pin
I guess this should be "reset-gpios". How about changing description to:
- reset-gpios : specifier of a GPIO connected to the RESET pin;
?
+- clocks : clock specifier for the clock-names property
Perhaps something along the lines of:
- clocks : "should contain the sensor's MCLK clock specifier, from
the common clock bindings"
?
+- clock-names : must contain "mclk" entry
Is name of the clock input pin really MCLK ?
+- svdda-supply : core voltage supply
+- svddio-supply: I/O voltage supply
+
+Optional Properties:
+- clock-frequency : operating frequency for the sensor
+default value will be taken if not provided.
How about clarifying it a bit, as Stephen suggested, e.g.:
- clock-frequency : the frequency at which the "mclk" clock should be
configured to operate, in Hz; if this property is not
specified default 24 MHz value will be used.
+The device node should be added to respective control bus controller
+(e.g. I2C0) nodes and linked to the csis port node, using the common
+video interfaces bindings, defined in video-interfaces.txt.
This seems misplaced, S5K4E5 image sensor has nothingto do with csis nodes.
How about something like this instead:
"The common video interfaces bindings (see video-interfaces.txt) should be
used to specify link to the image data receiver. The S5K6A3(YX) device
node should contain one 'port' child node with an 'endpoint' subnode.
Following properties are valid for the endpoint node:
..."
+Example:
+
+ i2c-isp@1313 {
+ s5k4e5@20 {
+ compatible = "samsung,s5k4e5";
+ reg =<0x20>;
+ gpios =<&gpx1 2 1>;
+ clock-frequency =<2400>;
+ clocks =<&clock 129>;
+ clock-names = "mclk";
+ svdda-supply =<...>;
+ svddio-supply =<...>;
+ port {
+ is_s5k4e5_ep: endpoint {
+ data-lanes =<1 2 3 4>;
+ remote-endpoint =<&csis0_ep>;
+ };
+ };
+ };
+ };
--
Thanks,
Sylwester
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7 13/13] V4L: Add driver for s5k4e5 image sensor
On 08/21/2013 11:13 AM, Sylwester Nawrocki wrote:
> On 08/21/2013 10:24 AM, Hans Verkuil wrote:
> +static const char * const s5k4e5_supply_names[] = {
> + "svdda",
> + "svddio"
> +};
I'm no regulator expert, but shouldn't this list come from the DT or
platform_data? Or are these names specific to this sensor?
>>>
>>> This is a list of regulator input (aka supply) names. In other words those
>>> are usually names of pins of the consumer device (s5k4e5 chip in this
>>> case) to which the regulators are connected. They are used as lookup keys
>>> when looking up regulators, either from device tree or lookup tables.
>>
>> How does that work if you have two of these sensors? E.g. in a stereo-camera?
>> Can the regulator subsystem map those pins to the correct regulators?
>>
>> Again, sorry for my ignorance in this area as I've never used it. I just
>> want to make sure this information is stored in the right place.
>
> The _voltage regulator supply names_ are fixed but _voltage regulator_
> is matched with a consumer device based on the supply name and name of
> the consumer device. See usage of struct regulator_consumer_supply, e.g.
> in arch/arm/mach-s5pv210/mach-goni.c board file. This is an example of
> non-dt system, and something that would presumably be created by a driver
> like em28xx if it wanted to use that sensor. I.e. em28xx would first
> need to create a voltage regulator device and then pass in a
> struct regulator_init_data the list of voltage supply definitions for
> the consumers to be able to use this regulator.
>
>
> In case of device tree the voltage supplies are specified in
> a DT node, which can be referenced by subsystems/drivers through
> struct device::of_node.
>
> reg_a: voltage-regulator-a {
> compatible = "regulator-fixed";
> regulator-name = "REG_5V_A";
> regulator-min-microvolt = <500>;
> regulator-max-microvolt = <500>;
> gpio = <...>;
> ...
> };
>
> reg_b: voltage-regulator-b {
> compatible = "regulator-fixed";
> regulator-name = "REG_3.3V_B";
> regulator-min-microvolt = <330>;
> regulator-max-microvolt = <330>;
> gpio = <...>;
> ...
> };
>
> s5k4e5@20 {
> compatible = "samsung,s5k4e5";
> reg = <0x20>;
> ...
> svdda-supply = <®_a>;
> svddio-supply = <®_b>;
> ...
> };
I forgot to mention that each of the two sensors would of course have
its corresponding DT node, but since they both have same slave address
would likely be attached to separate I2C bus controllers, e.g.
/* I2C bus controller node */
i2c-gpio-0 {
compatible = "i2c-gpio";
gpios = <...>;
...
s5k4e5@20 {
compatible = "samsung,s5k4e5";
reg = <0x20>;
...
svdda-supply = <®_a>;
svddio-supply = <®_b>;
...
};
};
i2c-gpio-1 {
compatible = "i2c-gpio";
gpios = <...>;
...
s5k4e5@20 {
compatible = "samsung,s5k4e5";
reg = <0x20>;
...
svdda-supply = <®_a>;
svddio-supply = <®_b>;
...
};
};
So these sensors have same regulator supply names but different i2c_client
(device) names, since they are children of different I2C bus adapters.
> The regulator supply names are part of name of the property defining
> a voltage regulator for a device. Properties in form of
> [supply_name]-supply are parsed by the regulator core when consumer
> device driver calls regulator_get(). This way drivers don't need to
> care whether the system is booted from Device Tree or not. They just
> keep using the regulator API and the regulator supply lookup is done
> the the core based on data in a board file or in device tree blob.
>
> This is similar to the clock API operation, except that clkdev entries
> are usually defined per SOC/MCU rather than per board.
>
> I hope it helps. I looked yesterday at the em28xx driver. Do you happen
> to know if there is a schematic for one of devices this driver supports ?
> Sorry, I didn't dig to hard yet.
> At first sight I thought it may look a bit problematic and require
> significant amount of code to define regulators for the all supported
> sensors by this driver, should it be made to work with sensors that
> are currently known to be used only in embedded systems and use the
> regulators API. However it should be as simple as defining at least one
> regulator device and attaching regulator supply list definition for all
> supported sensors. Thus not that scary at all. And the subdev drivers
> can continue to use regulator API, without a need for any hacks making
> it optional through e.g. pla
Re: [PATCH v7 13/13] V4L: Add driver for s5k4e5 image sensor
On 08/21/2013 10:24 AM, Hans Verkuil wrote:
+static const char * const s5k4e5_supply_names[] = {
+ "svdda",
+ "svddio"
+};
>>>
>>> I'm no regulator expert, but shouldn't this list come from the DT or
>>> platform_data? Or are these names specific to this sensor?
>>
>> This is a list of regulator input (aka supply) names. In other words those
>> are usually names of pins of the consumer device (s5k4e5 chip in this
>> case) to which the regulators are connected. They are used as lookup keys
>> when looking up regulators, either from device tree or lookup tables.
>
> How does that work if you have two of these sensors? E.g. in a stereo-camera?
> Can the regulator subsystem map those pins to the correct regulators?
>
> Again, sorry for my ignorance in this area as I've never used it. I just
> want to make sure this information is stored in the right place.
The _voltage regulator supply names_ are fixed but _voltage regulator_
is matched with a consumer device based on the supply name and name of
the consumer device. See usage of struct regulator_consumer_supply, e.g.
in arch/arm/mach-s5pv210/mach-goni.c board file. This is an example of
non-dt system, and something that would presumably be created by a driver
like em28xx if it wanted to use that sensor. I.e. em28xx would first
need to create a voltage regulator device and then pass in a
struct regulator_init_data the list of voltage supply definitions for
the consumers to be able to use this regulator.
In case of device tree the voltage supplies are specified in
a DT node, which can be referenced by subsystems/drivers through
struct device::of_node.
reg_a: voltage-regulator-a {
compatible = "regulator-fixed";
regulator-name = "REG_5V_A";
regulator-min-microvolt = <500>;
regulator-max-microvolt = <500>;
gpio = <...>;
...
};
reg_b: voltage-regulator-b {
compatible = "regulator-fixed";
regulator-name = "REG_3.3V_B";
regulator-min-microvolt = <330>;
regulator-max-microvolt = <330>;
gpio = <...>;
...
};
s5k4e5@20 {
compatible = "samsung,s5k4e5";
reg = <0x20>;
...
svdda-supply = <®_a>;
svddio-supply = <®_b>;
...
};
The regulator supply names are part of name of the property defining
a voltage regulator for a device. Properties in form of
[supply_name]-supply are parsed by the regulator core when consumer
device driver calls regulator_get(). This way drivers don't need to
care whether the system is booted from Device Tree or not. They just
keep using the regulator API and the regulator supply lookup is done
the the core based on data in a board file or in device tree blob.
This is similar to the clock API operation, except that clkdev entries
are usually defined per SOC/MCU rather than per board.
I hope it helps. I looked yesterday at the em28xx driver. Do you happen
to know if there is a schematic for one of devices this driver supports ?
Sorry, I didn't dig to hard yet.
At first sight I thought it may look a bit problematic and require
significant amount of code to define regulators for the all supported
sensors by this driver, should it be made to work with sensors that
are currently known to be used only in embedded systems and use the
regulators API. However it should be as simple as defining at least one
regulator device and attaching regulator supply list definition for all
supported sensors. Thus not that scary at all. And the subdev drivers
can continue to use regulator API, without a need for any hacks making
it optional through e.g. platform_data flag. And IMO if the regulator
API is disabled currently by some x86 distros it should be enabled,
as long as some drivers need it.
--
Regards,
Sylwester
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7 13/13] V4L: Add driver for s5k4e5 image sensor
Hi Hans,
On Wed, Aug 21, 2013 at 1:54 PM, Hans Verkuil wrote:
> On Wed 21 August 2013 09:58:28 Tomasz Figa wrote:
>> Hi Hans,
>>
>> On Wednesday 21 of August 2013 08:53:55 Hans Verkuil wrote:
>> > On 08/21/2013 08:34 AM, Arun Kumar K wrote:
>> > > This patch adds subdev driver for Samsung S5K4E5 raw image sensor.
>> > > Like s5k6a3, it is also another fimc-is firmware controlled
>> > > sensor. This minimal sensor driver doesn't do any I2C communications
>> > > as its done by ISP firmware. It can be updated if needed to a
>> > > regular sensor driver by adding the I2C communication.
>> > >
>> > > Signed-off-by: Arun Kumar K
>> > > Reviewed-by: Sylwester Nawrocki
>> > > ---
>> > >
>> > > .../devicetree/bindings/media/i2c/s5k4e5.txt | 43 +++
>> > > drivers/media/i2c/Kconfig |8 +
>> > > drivers/media/i2c/Makefile |1 +
>> > > drivers/media/i2c/s5k4e5.c | 361
>> > > 4 files changed, 413 insertions(+)
>> > > create mode 100644
>> > > Documentation/devicetree/bindings/media/i2c/s5k4e5.txt create mode
>> > > 100644 drivers/media/i2c/s5k4e5.c
>> >
>> > ...
>> >
>> > > diff --git a/drivers/media/i2c/s5k4e5.c b/drivers/media/i2c/s5k4e5.c
>> > > new file mode 100644
>> > > index 000..0a6ece6
>> > > --- /dev/null
>> > > +++ b/drivers/media/i2c/s5k4e5.c
>> > > @@ -0,0 +1,361 @@
>> > > +/*
>> > > + * Samsung S5K4E5 image sensor driver
>> > > + *
>> > > + * Copyright (C) 2013 Samsung Electronics Co., Ltd.
>> > > + * Author: Arun Kumar K
>> > > + *
>> > > + * This program is free software; you can redistribute it and/or
>> > > modify + * it under the terms of the GNU General Public License
>> > > version 2 as + * published by the Free Software Foundation.
>> > > + */
>> > > +
>> > > +#include
>> > > +#include
>> > > +#include
>> > > +#include
>> > > +#include
>> > > +#include
>> > > +#include
>> > > +#include
>> > > +#include
>> > > +#include
>> > > +#include
>> > > +#include
>> > > +#include
>> > > +#include
>> > > +#include
>> > > +
>> > > +#define S5K4E5_SENSOR_MAX_WIDTH 2576
>> > > +#define S5K4E5_SENSOR_MAX_HEIGHT 1930
>> > > +
>> > > +#define S5K4E5_SENSOR_ACTIVE_WIDTH 2560
>> > > +#define S5K4E5_SENSOR_ACTIVE_HEIGHT 1920
>> > > +
>> > > +#define S5K4E5_SENSOR_MIN_WIDTH (32 + 16)
>> > > +#define S5K4E5_SENSOR_MIN_HEIGHT (32 + 10)
>> > > +
>> > > +#define S5K4E5_DEF_WIDTH 1296
>> > > +#define S5K4E5_DEF_HEIGHT732
>> > > +
>> > > +#define S5K4E5_DRV_NAME "S5K4E5"
>> > > +#define S5K4E5_CLK_NAME "mclk"
>> > > +
>> > > +#define S5K4E5_NUM_SUPPLIES 2
>> > > +
>> > > +#define S5K4E5_DEF_CLK_FREQ 2400
>> > > +
>> > > +/**
>> > > + * struct s5k4e5 - s5k4e5 sensor data structure
>> > > + * @dev: pointer to this I2C client device structure
>> > > + * @subdev: the image sensor's v4l2 subdev
>> > > + * @pad: subdev media source pad
>> > > + * @supplies: image sensor's voltage regulator supplies
>> > > + * @gpio_reset: GPIO connected to the sensor's reset pin
>> > > + * @lock: mutex protecting the structure's members below
>> > > + * @format: media bus format at the sensor's source pad
>> > > + */
>> > > +struct s5k4e5 {
>> > > + struct device *dev;
>> > > + struct v4l2_subdev subdev;
>> > > + struct media_pad pad;
>> > > + struct regulator_bulk_data supplies[S5K4E5_NUM_SUPPLIES];
>> > > + int gpio_reset;
>> > > + struct mutex lock;
>> > > + struct v4l2_mbus_framefmt format;
>> > > + struct clk *clock;
>> > > + u32 clock_frequency;
>> > > +};
>> > > +
>> > > +static const char * const s5k4e5_supply_names[] = {
>> > > + "svdda",
>> > > + "svddio"
>> > > +};
>> >
>> > I'm no regulator expert, but shouldn't this list come from the DT or
>> > platform_data? Or are these names specific to this sensor?
>>
>> This is a list of regulator input (aka supply) names. In other words those
>> are usually names of pins of the consumer device (s5k4e5 chip in this
>> case) to which the regulators are connected. They are used as lookup keys
>> when looking up regulators, either from device tree or lookup tables.
>
> How does that work if you have two of these sensors? E.g. in a stereo-camera?
> Can the regulator subsystem map those pins to the correct regulators?
>
> Again, sorry for my ignorance in this area as I've never used it. I just
> want to make sure this information is stored in the right place.
>
There are two regulator supplies needed for this sensor, and these pin names
are just used in the driver to differentiate them.
>From the DT, we pass regulator node phandles with these properties
(supply names) which the driver uses.
Regards
Arun
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7 13/13] V4L: Add driver for s5k4e5 image sensor
On Wed 21 August 2013 09:58:28 Tomasz Figa wrote:
> Hi Hans,
>
> On Wednesday 21 of August 2013 08:53:55 Hans Verkuil wrote:
> > On 08/21/2013 08:34 AM, Arun Kumar K wrote:
> > > This patch adds subdev driver for Samsung S5K4E5 raw image sensor.
> > > Like s5k6a3, it is also another fimc-is firmware controlled
> > > sensor. This minimal sensor driver doesn't do any I2C communications
> > > as its done by ISP firmware. It can be updated if needed to a
> > > regular sensor driver by adding the I2C communication.
> > >
> > > Signed-off-by: Arun Kumar K
> > > Reviewed-by: Sylwester Nawrocki
> > > ---
> > >
> > > .../devicetree/bindings/media/i2c/s5k4e5.txt | 43 +++
> > > drivers/media/i2c/Kconfig |8 +
> > > drivers/media/i2c/Makefile |1 +
> > > drivers/media/i2c/s5k4e5.c | 361
> > > 4 files changed, 413 insertions(+)
> > > create mode 100644
> > > Documentation/devicetree/bindings/media/i2c/s5k4e5.txt create mode
> > > 100644 drivers/media/i2c/s5k4e5.c
> >
> > ...
> >
> > > diff --git a/drivers/media/i2c/s5k4e5.c b/drivers/media/i2c/s5k4e5.c
> > > new file mode 100644
> > > index 000..0a6ece6
> > > --- /dev/null
> > > +++ b/drivers/media/i2c/s5k4e5.c
> > > @@ -0,0 +1,361 @@
> > > +/*
> > > + * Samsung S5K4E5 image sensor driver
> > > + *
> > > + * Copyright (C) 2013 Samsung Electronics Co., Ltd.
> > > + * Author: Arun Kumar K
> > > + *
> > > + * This program is free software; you can redistribute it and/or
> > > modify + * it under the terms of the GNU General Public License
> > > version 2 as + * published by the Free Software Foundation.
> > > + */
> > > +
> > > +#include
> > > +#include
> > > +#include
> > > +#include
> > > +#include
> > > +#include
> > > +#include
> > > +#include
> > > +#include
> > > +#include
> > > +#include
> > > +#include
> > > +#include
> > > +#include
> > > +#include
> > > +
> > > +#define S5K4E5_SENSOR_MAX_WIDTH 2576
> > > +#define S5K4E5_SENSOR_MAX_HEIGHT 1930
> > > +
> > > +#define S5K4E5_SENSOR_ACTIVE_WIDTH 2560
> > > +#define S5K4E5_SENSOR_ACTIVE_HEIGHT 1920
> > > +
> > > +#define S5K4E5_SENSOR_MIN_WIDTH (32 + 16)
> > > +#define S5K4E5_SENSOR_MIN_HEIGHT (32 + 10)
> > > +
> > > +#define S5K4E5_DEF_WIDTH 1296
> > > +#define S5K4E5_DEF_HEIGHT732
> > > +
> > > +#define S5K4E5_DRV_NAME "S5K4E5"
> > > +#define S5K4E5_CLK_NAME "mclk"
> > > +
> > > +#define S5K4E5_NUM_SUPPLIES 2
> > > +
> > > +#define S5K4E5_DEF_CLK_FREQ 2400
> > > +
> > > +/**
> > > + * struct s5k4e5 - s5k4e5 sensor data structure
> > > + * @dev: pointer to this I2C client device structure
> > > + * @subdev: the image sensor's v4l2 subdev
> > > + * @pad: subdev media source pad
> > > + * @supplies: image sensor's voltage regulator supplies
> > > + * @gpio_reset: GPIO connected to the sensor's reset pin
> > > + * @lock: mutex protecting the structure's members below
> > > + * @format: media bus format at the sensor's source pad
> > > + */
> > > +struct s5k4e5 {
> > > + struct device *dev;
> > > + struct v4l2_subdev subdev;
> > > + struct media_pad pad;
> > > + struct regulator_bulk_data supplies[S5K4E5_NUM_SUPPLIES];
> > > + int gpio_reset;
> > > + struct mutex lock;
> > > + struct v4l2_mbus_framefmt format;
> > > + struct clk *clock;
> > > + u32 clock_frequency;
> > > +};
> > > +
> > > +static const char * const s5k4e5_supply_names[] = {
> > > + "svdda",
> > > + "svddio"
> > > +};
> >
> > I'm no regulator expert, but shouldn't this list come from the DT or
> > platform_data? Or are these names specific to this sensor?
>
> This is a list of regulator input (aka supply) names. In other words those
> are usually names of pins of the consumer device (s5k4e5 chip in this
> case) to which the regulators are connected. They are used as lookup keys
> when looking up regulators, either from device tree or lookup tables.
How does that work if you have two of these sensors? E.g. in a stereo-camera?
Can the regulator subsystem map those pins to the correct regulators?
Again, sorry for my ignorance in this area as I've never used it. I just
want to make sure this information is stored in the right place.
Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7 13/13] V4L: Add driver for s5k4e5 image sensor
Hi Hans,
On Wednesday 21 of August 2013 08:53:55 Hans Verkuil wrote:
> On 08/21/2013 08:34 AM, Arun Kumar K wrote:
> > This patch adds subdev driver for Samsung S5K4E5 raw image sensor.
> > Like s5k6a3, it is also another fimc-is firmware controlled
> > sensor. This minimal sensor driver doesn't do any I2C communications
> > as its done by ISP firmware. It can be updated if needed to a
> > regular sensor driver by adding the I2C communication.
> >
> > Signed-off-by: Arun Kumar K
> > Reviewed-by: Sylwester Nawrocki
> > ---
> >
> > .../devicetree/bindings/media/i2c/s5k4e5.txt | 43 +++
> > drivers/media/i2c/Kconfig |8 +
> > drivers/media/i2c/Makefile |1 +
> > drivers/media/i2c/s5k4e5.c | 361
> > 4 files changed, 413 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/media/i2c/s5k4e5.txt create mode
> > 100644 drivers/media/i2c/s5k4e5.c
>
> ...
>
> > diff --git a/drivers/media/i2c/s5k4e5.c b/drivers/media/i2c/s5k4e5.c
> > new file mode 100644
> > index 000..0a6ece6
> > --- /dev/null
> > +++ b/drivers/media/i2c/s5k4e5.c
> > @@ -0,0 +1,361 @@
> > +/*
> > + * Samsung S5K4E5 image sensor driver
> > + *
> > + * Copyright (C) 2013 Samsung Electronics Co., Ltd.
> > + * Author: Arun Kumar K
> > + *
> > + * This program is free software; you can redistribute it and/or
> > modify + * it under the terms of the GNU General Public License
> > version 2 as + * published by the Free Software Foundation.
> > + */
> > +
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +
> > +#define S5K4E5_SENSOR_MAX_WIDTH2576
> > +#define S5K4E5_SENSOR_MAX_HEIGHT 1930
> > +
> > +#define S5K4E5_SENSOR_ACTIVE_WIDTH 2560
> > +#define S5K4E5_SENSOR_ACTIVE_HEIGHT1920
> > +
> > +#define S5K4E5_SENSOR_MIN_WIDTH(32 + 16)
> > +#define S5K4E5_SENSOR_MIN_HEIGHT (32 + 10)
> > +
> > +#define S5K4E5_DEF_WIDTH 1296
> > +#define S5K4E5_DEF_HEIGHT 732
> > +
> > +#define S5K4E5_DRV_NAME"S5K4E5"
> > +#define S5K4E5_CLK_NAME"mclk"
> > +
> > +#define S5K4E5_NUM_SUPPLIES2
> > +
> > +#define S5K4E5_DEF_CLK_FREQ2400
> > +
> > +/**
> > + * struct s5k4e5 - s5k4e5 sensor data structure
> > + * @dev: pointer to this I2C client device structure
> > + * @subdev: the image sensor's v4l2 subdev
> > + * @pad: subdev media source pad
> > + * @supplies: image sensor's voltage regulator supplies
> > + * @gpio_reset: GPIO connected to the sensor's reset pin
> > + * @lock: mutex protecting the structure's members below
> > + * @format: media bus format at the sensor's source pad
> > + */
> > +struct s5k4e5 {
> > + struct device *dev;
> > + struct v4l2_subdev subdev;
> > + struct media_pad pad;
> > + struct regulator_bulk_data supplies[S5K4E5_NUM_SUPPLIES];
> > + int gpio_reset;
> > + struct mutex lock;
> > + struct v4l2_mbus_framefmt format;
> > + struct clk *clock;
> > + u32 clock_frequency;
> > +};
> > +
> > +static const char * const s5k4e5_supply_names[] = {
> > + "svdda",
> > + "svddio"
> > +};
>
> I'm no regulator expert, but shouldn't this list come from the DT or
> platform_data? Or are these names specific to this sensor?
This is a list of regulator input (aka supply) names. In other words those
are usually names of pins of the consumer device (s5k4e5 chip in this
case) to which the regulators are connected. They are used as lookup keys
when looking up regulators, either from device tree or lookup tables.
Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7 13/13] V4L: Add driver for s5k4e5 image sensor
On 08/21/2013 08:34 AM, Arun Kumar K wrote:
> This patch adds subdev driver for Samsung S5K4E5 raw image sensor.
> Like s5k6a3, it is also another fimc-is firmware controlled
> sensor. This minimal sensor driver doesn't do any I2C communications
> as its done by ISP firmware. It can be updated if needed to a
> regular sensor driver by adding the I2C communication.
>
> Signed-off-by: Arun Kumar K
> Reviewed-by: Sylwester Nawrocki
> ---
> .../devicetree/bindings/media/i2c/s5k4e5.txt | 43 +++
> drivers/media/i2c/Kconfig |8 +
> drivers/media/i2c/Makefile |1 +
> drivers/media/i2c/s5k4e5.c | 361
>
> 4 files changed, 413 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/i2c/s5k4e5.txt
> create mode 100644 drivers/media/i2c/s5k4e5.c
>
...
> diff --git a/drivers/media/i2c/s5k4e5.c b/drivers/media/i2c/s5k4e5.c
> new file mode 100644
> index 000..0a6ece6
> --- /dev/null
> +++ b/drivers/media/i2c/s5k4e5.c
> @@ -0,0 +1,361 @@
> +/*
> + * Samsung S5K4E5 image sensor driver
> + *
> + * Copyright (C) 2013 Samsung Electronics Co., Ltd.
> + * Author: Arun Kumar K
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +
> +#define S5K4E5_SENSOR_MAX_WIDTH 2576
> +#define S5K4E5_SENSOR_MAX_HEIGHT 1930
> +
> +#define S5K4E5_SENSOR_ACTIVE_WIDTH 2560
> +#define S5K4E5_SENSOR_ACTIVE_HEIGHT 1920
> +
> +#define S5K4E5_SENSOR_MIN_WIDTH (32 + 16)
> +#define S5K4E5_SENSOR_MIN_HEIGHT (32 + 10)
> +
> +#define S5K4E5_DEF_WIDTH 1296
> +#define S5K4E5_DEF_HEIGHT732
> +
> +#define S5K4E5_DRV_NAME "S5K4E5"
> +#define S5K4E5_CLK_NAME "mclk"
> +
> +#define S5K4E5_NUM_SUPPLIES 2
> +
> +#define S5K4E5_DEF_CLK_FREQ 2400
> +
> +/**
> + * struct s5k4e5 - s5k4e5 sensor data structure
> + * @dev: pointer to this I2C client device structure
> + * @subdev: the image sensor's v4l2 subdev
> + * @pad: subdev media source pad
> + * @supplies: image sensor's voltage regulator supplies
> + * @gpio_reset: GPIO connected to the sensor's reset pin
> + * @lock: mutex protecting the structure's members below
> + * @format: media bus format at the sensor's source pad
> + */
> +struct s5k4e5 {
> + struct device *dev;
> + struct v4l2_subdev subdev;
> + struct media_pad pad;
> + struct regulator_bulk_data supplies[S5K4E5_NUM_SUPPLIES];
> + int gpio_reset;
> + struct mutex lock;
> + struct v4l2_mbus_framefmt format;
> + struct clk *clock;
> + u32 clock_frequency;
> +};
> +
> +static const char * const s5k4e5_supply_names[] = {
> + "svdda",
> + "svddio"
> +};
I'm no regulator expert, but shouldn't this list come from the DT or
platform_data?
Or are these names specific to this sensor?
Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v7 13/13] V4L: Add driver for s5k4e5 image sensor
This patch adds subdev driver for Samsung S5K4E5 raw image sensor.
Like s5k6a3, it is also another fimc-is firmware controlled
sensor. This minimal sensor driver doesn't do any I2C communications
as its done by ISP firmware. It can be updated if needed to a
regular sensor driver by adding the I2C communication.
Signed-off-by: Arun Kumar K
Reviewed-by: Sylwester Nawrocki
---
.../devicetree/bindings/media/i2c/s5k4e5.txt | 43 +++
drivers/media/i2c/Kconfig |8 +
drivers/media/i2c/Makefile |1 +
drivers/media/i2c/s5k4e5.c | 361
4 files changed, 413 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/i2c/s5k4e5.txt
create mode 100644 drivers/media/i2c/s5k4e5.c
diff --git a/Documentation/devicetree/bindings/media/i2c/s5k4e5.txt
b/Documentation/devicetree/bindings/media/i2c/s5k4e5.txt
new file mode 100644
index 000..5af462c
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/s5k4e5.txt
@@ -0,0 +1,43 @@
+* Samsung S5K4E5 Raw Image Sensor
+
+S5K4E5 is a raw image sensor with maximum resolution of 2560x1920
+pixels. Data transfer is carried out via MIPI CSI-2 port and controls
+via I2C bus.
+
+Required Properties:
+- compatible : must be "samsung,s5k4e5"
+- reg : I2C device address
+- gpios: reset gpio pin
+- clocks : clock specifier for the clock-names property
+- clock-names : must contain "mclk" entry
+- svdda-supply : core voltage supply
+- svddio-supply: I/O voltage supply
+
+Optional Properties:
+- clock-frequency : operating frequency for the sensor
+default value will be taken if not provided.
+
+The device node should be added to respective control bus controller
+(e.g. I2C0) nodes and linked to the csis port node, using the common
+video interfaces bindings, defined in video-interfaces.txt.
+
+Example:
+
+ i2c-isp@1313 {
+ s5k4e5@20 {
+ compatible = "samsung,s5k4e5";
+ reg = <0x20>;
+ gpios = <&gpx1 2 1>;
+ clock-frequency = <2400>;
+ clocks = <&clock 129>;
+ clock-names = "mclk";
+ svdda-supply = <...>;
+ svddio-supply = <...>;
+ port {
+ is_s5k4e5_ep: endpoint {
+ data-lanes = <1 2 3 4>;
+ remote-endpoint = <&csis0_ep>;
+ };
+ };
+ };
+ };
diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index f7e9147..271028b 100644
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig
@@ -572,6 +572,14 @@ config VIDEO_S5K6A3
This is a V4L2 sensor-level driver for Samsung S5K6A3 raw
camera sensor.
+config VIDEO_S5K4E5
+ tristate "Samsung S5K4E5 sensor support"
+ depends on MEDIA_CAMERA_SUPPORT
+ depends on I2C && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API && OF
+ ---help---
+ This is a V4L2 sensor-level driver for Samsung S5K4E5 raw
+ camera sensor.
+
config VIDEO_S5K4ECGX
tristate "Samsung S5K4ECGX sensor support"
depends on I2C && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API
diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile
index cf3cf03..0aeed8e 100644
--- a/drivers/media/i2c/Makefile
+++ b/drivers/media/i2c/Makefile
@@ -65,6 +65,7 @@ obj-$(CONFIG_VIDEO_SR030PC30) += sr030pc30.o
obj-$(CONFIG_VIDEO_NOON010PC30)+= noon010pc30.o
obj-$(CONFIG_VIDEO_S5K6AA) += s5k6aa.o
obj-$(CONFIG_VIDEO_S5K6A3) += s5k6a3.o
+obj-$(CONFIG_VIDEO_S5K4E5) += s5k4e5.o
obj-$(CONFIG_VIDEO_S5K4ECGX) += s5k4ecgx.o
obj-$(CONFIG_VIDEO_S5C73M3)+= s5c73m3/
obj-$(CONFIG_VIDEO_ADP1653)+= adp1653.o
diff --git a/drivers/media/i2c/s5k4e5.c b/drivers/media/i2c/s5k4e5.c
new file mode 100644
index 000..0a6ece6
--- /dev/null
+++ b/drivers/media/i2c/s5k4e5.c
@@ -0,0 +1,361 @@
+/*
+ * Samsung S5K4E5 image sensor driver
+ *
+ * Copyright (C) 2013 Samsung Electronics Co., Ltd.
+ * Author: Arun Kumar K
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+#define S5K4E5_SENSOR_MAX_WIDTH2576
+#define S5K4E5_SENSOR_MAX_HEIGHT 1930
+
+#define S5K4E5_SENSOR_ACTIVE_WIDTH 2560
+#define S5K4E5_SENSOR_ACTIVE_HEIGHT1920
+
+#define S5K4E5_SENSOR_MIN_WIDTH(32 + 16)
+#define S5K4E5_SENSOR_MIN_HEIGHT (32 + 10)
+
+#define S5K4E5_DEF_WIDTH 1296
