Re: Magic in videobuf

2010-03-17 Thread Hans Verkuil
On Wednesday 17 March 2010 07:50:27 Pawel Osciak wrote: >>That is my opinion, yes. However, there is one case where this is actually >>useful. Take for example the function videobuf_to_dma in >>videobuf-dma-sg.c. This is called by drivers and it makes sense that that >>function should double-check

RE: Magic in videobuf

2010-03-16 Thread Pawel Osciak
>Hans Verkuil wrote: >>>Andy Walls wrote: >>>On Mon, 2010-03-15 at 14:26 -0300, Mauro Carvalho Chehab wrote: Hans Verkuil wrote: >> Hans Verkuil wrote: Pawel Osciak wrote: >>> > is anyone aware of any other uses for MAGIC_CHECK()s in videobuf code > beside

Re: Magic in videobuf

2010-03-16 Thread Devin Heitmueller
On Tue, Mar 16, 2010 at 12:35 PM, Hans Verkuil wrote: > That is my opinion, yes. However, there is one case where this is actually > useful. Take for example the function videobuf_to_dma in > videobuf-dma-sg.c. This is called by drivers and it makes sense that that > function should double-check t

RE: Magic in videobuf

2010-03-16 Thread Hans Verkuil
>>Andy Walls wrote: >>On Mon, 2010-03-15 at 14:26 -0300, Mauro Carvalho Chehab wrote: >>> Hans Verkuil wrote: >>> >> Hans Verkuil wrote: >>> Pawel Osciak wrote: >> >>> > is anyone aware of any other uses for MAGIC_CHECK()s in videobuf >>> code >>> > besides driver debugging? I intend

RE: Magic in videobuf

2010-03-16 Thread Pawel Osciak
>Mauro Carvalho Chehab wrote: >> is anyone aware of any other uses for MAGIC_CHECK()s in videobuf code >> besides driver debugging? I intend to remove them, as we weren't able >> to find any particular use for them when we were discussing this at >> the memory handling meeting in No

RE: Magic in videobuf

2010-03-16 Thread Pawel Osciak
>Andy Walls wrote: >On Mon, 2010-03-15 at 14:26 -0300, Mauro Carvalho Chehab wrote: >> Hans Verkuil wrote: >> >> Hans Verkuil wrote: >> Pawel Osciak wrote: > >> > is anyone aware of any other uses for MAGIC_CHECK()s in videobuf code >> > besides driver debugging? I intend to remove the

Re: Magic in videobuf

2010-03-15 Thread Andy Walls
On Mon, 2010-03-15 at 14:26 -0300, Mauro Carvalho Chehab wrote: > Hans Verkuil wrote: > >> Hans Verkuil wrote: > Pawel Osciak wrote: > > is anyone aware of any other uses for MAGIC_CHECK()s in videobuf code > > besides driver debugging? I intend to remove them, as we weren't able > >>

Re: Magic in videobuf

2010-03-15 Thread Mauro Carvalho Chehab
Hans Verkuil wrote: >> Hans Verkuil wrote: Hi Pawel, Pawel Osciak wrote: > Hello, > > is anyone aware of any other uses for MAGIC_CHECK()s in videobuf code > besides driver debugging? I intend to remove them, as we weren't able > to find any particular use for the

Re: Magic in videobuf

2010-03-15 Thread Hans Verkuil
> Hans Verkuil wrote: >>> Hi Pawel, >>> >>> Pawel Osciak wrote: Hello, is anyone aware of any other uses for MAGIC_CHECK()s in videobuf code besides driver debugging? I intend to remove them, as we weren't able to find any particular use for them when we were discussing th

Re: Magic in videobuf

2010-03-15 Thread Mauro Carvalho Chehab
Hans Verkuil wrote: >> Hi Pawel, >> >> Pawel Osciak wrote: >>> Hello, >>> >>> is anyone aware of any other uses for MAGIC_CHECK()s in videobuf code >>> besides driver debugging? I intend to remove them, as we weren't able >>> to find any particular use for them when we were discussing this at >>> t

Re: Magic in videobuf

2010-03-15 Thread Hans Verkuil
> Hi Pawel, > > Pawel Osciak wrote: >> Hello, >> >> is anyone aware of any other uses for MAGIC_CHECK()s in videobuf code >> besides driver debugging? I intend to remove them, as we weren't able >> to find any particular use for them when we were discussing this at >> the memory handling meeting i

Re: Magic in videobuf

2010-03-15 Thread Mauro Carvalho Chehab
Hi Pawel, Pawel Osciak wrote: > Hello, > > is anyone aware of any other uses for MAGIC_CHECK()s in videobuf code > besides driver debugging? I intend to remove them, as we weren't able > to find any particular use for them when we were discussing this at > the memory handling meeting in Norway...

Magic in videobuf

2010-03-15 Thread Pawel Osciak
Hello, is anyone aware of any other uses for MAGIC_CHECK()s in videobuf code besides driver debugging? I intend to remove them, as we weren't able to find any particular use for them when we were discussing this at the memory handling meeting in Norway... Best regards -- Pawel Osciak Linux Platf