Re: ext_lock (was viafb camera controller driver)

2010-10-21 Thread Hans Verkuil
On Wednesday, October 20, 2010 21:23:42 Jonathan Corbet wrote: On Tue, 19 Oct 2010 08:54:40 +0200 Hans Verkuil hverk...@xs4all.nl wrote: We are working on removing the BKL. As part of that effort it is now possible for drivers to pass a serialization mutex to the v4l core (a mutex

[GIT PATCHES FOR 2.6.36] gspca for_2.6.36

2010-10-21 Thread Jean-Francois Moine
Hi Mauro, I added two fixes of an other regression. They should go to 2.6.36. The following changes since commit d65728875a85ac7c8b7d6eb8d51425bacc188980: V4L/DVB: v4l: radio: si470x: fix unneeded free_irq() call (2010-09-30 07:35:12 -0300) are available in the git repository at:

[PATCH] v4l-utils: Add support for new RDS CAP bits.

2010-10-21 Thread Matti J. Aaltonen
Add support for V4L2_TUNER_CAP_RDS_BLOCK_IO and V4L2_TUNER_CAP_RDS_CONTROLS tuner/modulator capability bits. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- utils/v4l2-ctl/v4l2-ctl.cpp |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git

RE: [PATCH 5/6 v5] V4L/DVB: s5p-fimc: Add camera capture support

2010-10-21 Thread Sewoon Park
Latest your reply is easy to understand. And I send you another parts review comments. Tuesday, October 12, 2010 2:27, Sylwester Nawrocki wrote : Add a video device driver per each FIMC entity to support the camera capture input mode. Video capture node is registered only if CCD sensor data

Re: [PATCH] v4l-utils: Add support for new RDS CAP bits.

2010-10-21 Thread Hans Verkuil
Hi Matti, Looks good. I'll merge it in v4l-utils once the driver is merged in v4l-dvb. Regards, Hans Add support for V4L2_TUNER_CAP_RDS_BLOCK_IO and V4L2_TUNER_CAP_RDS_CONTROLS tuner/modulator capability bits. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com ---

RE: [PATCH 3/4] MFC: Add MFC 5.1 V4L2 driver

2010-10-21 Thread Jaeryul Oh
I have some opinion about the usage of wait_event_interruptible_timeout() k.deb...@samsung.com wrote: [snip] + diff --git a/drivers/media/video/s5p-mfc/s5p_mfc_intr.c b/drivers/media/video/s5p-mfc/s5p_mfc_intr.c new file mode 100644 index 000..543f3fb --- /dev/null +++

Re: Old patches sent via the Mailing list

2010-10-21 Thread Mauro Carvalho Chehab
Em 20-10-2010 16:01, Sven Barth escreveu: On 20.10.2010 14:00, Andy Walls wrote: On Wed, 2010-10-20 at 07:19 +0200, Sven Barth wrote: Am 18.10.2010 08:15, schrieb Mauro Carvalho Chehab: Em 17-10-2010 21:36, Andy Walls escreveu: The last time I sent this list, I was about to travel, and I may

RE: [PATCH 3/4] MFC: Add MFC 5.1 V4L2 driver

2010-10-21 Thread Kamil Debski
Hi, I commented as belows, And you missed one important things 'cause there were my comments in the very long email which is strongly fixed in the reset seq. Yes, thanks for your suggestion. [] +#define READL(offset) readl(dev-regs_base + (offset)) +#define

RE: [PATCH 3/4] MFC: Add MFC 5.1 V4L2 driver

2010-10-21 Thread Kamil Debski
Hello, I have some opinion about the usage of wait_event_interruptible_timeout() k.deb...@samsung.com wrote: [snip] + diff --git a/drivers/media/video/s5p-mfc/s5p_mfc_intr.c b/drivers/media/video/s5p-mfc/s5p_mfc_intr.c new file mode 100644 index 000..543f3fb ---

Re: [PATCH 1/3] mceusb: add support for cx231xx-based IR (e. g. Polaris)

2010-10-21 Thread Mauro Carvalho Chehab
Em 19-10-2010 15:50, Jarod Wilson escreveu: On Mon, Oct 18, 2010 at 08:52:57PM -0200, Mauro Carvalho Chehab wrote: For now, it adds support for Conexant EVK and for Pixelview. We should probably find a better way to specify all Conexant Polaris devices, to avoid needing to repeat this setup on

Re: [PATCH RFC] ir-rc5-decoder: don't wait for the end space to produce a code

2010-10-21 Thread Jarod Wilson
On Oct 20, 2010, at 1:18 PM, Mauro Carvalho Chehab wrote: The RC5 decoding is complete at a BIT_END state. there's no reason to wait for the next space to produce a code. Well, if I'm reading things correctly here, I think the only true functional difference made to the decoder here was to

USB DVBT af9015: tuner id:177 not supported, please report!

2010-10-21 Thread Felix Droste
I could not get this DVBT-Stick (USB) to work: auvisio USB-DVB-T-Receiver -Recorder DR-340 h t t p : / / w w w .pearl.de/product.jsp?pdid=HPM1520catid=8909vid=922curr=DEM dmesg: [25239.410175] usb 2-1: new high speed USB device using ehci_hcd and address 6 [25239.569729] Afatech DVB-T 2:

Re: [PATCH RFC] ir-rc5-decoder: don't wait for the end space to produce a code

2010-10-21 Thread Mauro Carvalho Chehab
Em 21-10-2010 11:46, Jarod Wilson escreveu: On Oct 20, 2010, at 1:18 PM, Mauro Carvalho Chehab wrote: The RC5 decoding is complete at a BIT_END state. there's no reason to wait for the next space to produce a code. Well, if I'm reading things correctly here, I think the only true

[PATCH 3/4] [media] mceusb: Improve parser to get codes sent together with IR RX data

2010-10-21 Thread Mauro Carvalho Chehab
On cx231xx, sometimes, several control messages are sent together with data. Improves the parser to also handle those cases. For example: [38777.211690] mceusb 7-6:1.0: rx data: 9f 14 01 9f 15 00 00 80 (length=8) [38777.211696] mceusb 7-6:1.0: Got long-range receive sensor in use [38777.211700]

[PATCH 4/4] [media] mceusb: Fix parser for Polaris

2010-10-21 Thread Mauro Carvalho Chehab
Add a parser for polaris mce. On this device, sometimes, a control data appears together with the IR data, causing problems at the parser. Also, it signalizes the end of a data with a 0x80 value. The normal parser would believe that this is a time with 0x1f size, but cx231xx provides just one byte

[PATCH 0/4] Some cx231xx IR fixes

2010-10-21 Thread Mauro Carvalho Chehab
This patch series fix the remaining issues with IR for Polaris (cx231xx). Basically, it adds another parser at mceusb, that works better with Polaris. I think that the same parser may also work well for other devices. Mauro Carvalho Chehab (4): [media] cx231xx: Fix compilation breakage if DVB

[PATCH 1/4] [media] cx231xx: Fix compilation breakage if DVB is not selected

2010-10-21 Thread Mauro Carvalho Chehab
In file included from drivers/media/video/cx231xx/cx231xx-audio.c:40: drivers/media/video/cx231xx/cx231xx.h:559: error: field ‘frontends’ has incomplete type make[4]: ** [drivers/media/video/cx231xx/cx231xx-audio.o] Erro 1 make[3]: ** [drivers/media/video/cx231xx] Erro 2 make[2]: **

[PATCH 2/4] [media] ir-raw-event: Fix a stupid error at a printk

2010-10-21 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com diff --git a/drivers/media/IR/ir-raw-event.c b/drivers/media/IR/ir-raw-event.c index 0d59ef7..a06a07e 100644 --- a/drivers/media/IR/ir-raw-event.c +++ b/drivers/media/IR/ir-raw-event.c @@ -89,7 +89,7 @@ int ir_raw_event_store(struct

Re: [PATCH 2/4] [media] ir-raw-event: Fix a stupid error at a printk

2010-10-21 Thread Jarod Wilson
On Thu, Oct 21, 2010 at 10:07 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com diff --git a/drivers/media/IR/ir-raw-event.c b/drivers/media/IR/ir-raw-event.c index 0d59ef7..a06a07e 100644 --- a/drivers/media/IR/ir-raw-event.c +++

Re: [PATCH 1/4] [media] cx231xx: Fix compilation breakage if DVB is not selected

2010-10-21 Thread Jarod Wilson
On Thu, Oct 21, 2010 at 10:07 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: In file included from drivers/media/video/cx231xx/cx231xx-audio.c:40: drivers/media/video/cx231xx/cx231xx.h:559: error: field ‘frontends’ has incomplete type make[4]: **

Technisat CableStar HD2 some issues/questions

2010-10-21 Thread Christian Ruppert
Hey guys, I recently bought a Technisat CableStar HD2: lspci -s 04:05.0 -vv -n 04:05.0 0480: 1822:4e35 (rev 01) Subsystem: 1ae4:0002 Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B- DisINTx- Status: Cap- 66MHz- UDF- FastB2B-

Re: [PATCH 1/2] ov7670: allow configuration of image size, clock speed, and I/O method

2010-10-21 Thread Jonathan Corbet
On Tue, 19 Oct 2010 22:24:05 +0100 (BST) Daniel Drake d...@laptop.org wrote: These parameters need to be configurable based on the host system. They can now be communicated through the s_config call. The old CONFIG_OLPC_XO_1 selector was not correct; this kind of arrangement wouldn't allow

Re: [PATCH 3/4] [media] mceusb: Improve parser to get codes sent together with IR RX data

2010-10-21 Thread Jarod Wilson
On Oct 21, 2010, at 10:07 AM, Mauro Carvalho Chehab wrote: On cx231xx, sometimes, several control messages are sent together with data. Improves the parser to also handle those cases. For example: [38777.211690] mceusb 7-6:1.0: rx data: 9f 14 01 9f 15 00 00 80 (length=8) [38777.211696]

[cron job] v4l-dvb daily build 2.6.26 and up: ERRORS

2010-10-21 Thread Hans Verkuil
This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below. Results of the daily build of v4l-dvb: date:Thu Oct 21 19:00:22 CEST 2010 path:http://www.linuxtv.org/hg/v4l-dvb changeset: 15167:abd3aac6644e git master:

[patch] V4L/DVB: cx231xx: fix double lock typo

2010-10-21 Thread Dan Carpenter
This was supposed to be an unlock on the error path. Signed-off-by: Dan Carpenter erro...@gmail.com diff --git a/drivers/media/video/cx231xx/cx231xx-i2c.c b/drivers/media/video/cx231xx/cx231xx-i2c.c index cce74e5..8356706 100644 --- a/drivers/media/video/cx231xx/cx231xx-i2c.c +++

[patch 1/3] V4L/DVB: s5p-fimc: add unlock on error path

2010-10-21 Thread Dan Carpenter
There was an unlock missing if kzalloc() failed. Signed-off-by: Dan Carpenter erro...@gmail.com diff --git a/drivers/media/video/s5p-fimc/fimc-core.c b/drivers/media/video/s5p-fimc/fimc-core.c index 1802701..8335045 100644 --- a/drivers/media/video/s5p-fimc/fimc-core.c +++

[patch 3/3] V4L/DVB: s5p-fimc: dubious one-bit signed bitfields

2010-10-21 Thread Dan Carpenter
These are signed so instead of being 1 and 0 as intended they are -1 and 0. It doesn't cause a bug in the current code but Sparse warns about it: drivers/media/video/s5p-fimc/fimc-core.h:226:28: error: dubious one-bit signed bitfield Signed-off-by: Dan Carpenter erro...@gmail.com diff

[patch 2/3] V4L/DVB: s5p-fimc: make it compile

2010-10-21 Thread Dan Carpenter
The work_queue was partially removed in f93000ac11: [media] s5p-fimc: mem2mem driver refactoring and cleanup but this bit was missed. Also we need to include sched.h otherwise the compile fails with: drivers/media/video/s5p-fimc/fimc-core.c: In function ‘fimc_capture_handler’:

Re: [PATCH 4/4] [media] mceusb: Fix parser for Polaris

2010-10-21 Thread Jarod Wilson
On Oct 21, 2010, at 10:07 AM, Mauro Carvalho Chehab wrote: Add a parser for polaris mce. On this device, sometimes, a control data appears together with the IR data, causing problems at the parser. Also, it signalizes the end of a data with a 0x80 value. The normal parser would believe that

Re: [PATCH 4/4] [media] mceusb: Fix parser for Polaris

2010-10-21 Thread Mauro Carvalho Chehab
Em 21-10-2010 18:06, Jarod Wilson escreveu: On Oct 21, 2010, at 10:07 AM, Mauro Carvalho Chehab wrote: Add a parser for polaris mce. On this device, sometimes, a control data appears together with the IR data, causing problems at the parser. Also, it signalizes the end of a data with a 0x80

Re: [PATCH 4/4] [media] mceusb: Fix parser for Polaris

2010-10-21 Thread Jarod Wilson
On Oct 21, 2010, at 4:38 PM, Mauro Carvalho Chehab wrote: Em 21-10-2010 18:06, Jarod Wilson escreveu: On Oct 21, 2010, at 10:07 AM, Mauro Carvalho Chehab wrote: Add a parser for polaris mce. On this device, sometimes, a control data appears together with the IR data, causing problems at the

Re: [PATCH 4/4] [media] mceusb: Fix parser for Polaris

2010-10-21 Thread Mauro Carvalho Chehab
Em 21-10-2010 19:06, Jarod Wilson escreveu: On Oct 21, 2010, at 4:38 PM, Mauro Carvalho Chehab wrote: Em 21-10-2010 18:06, Jarod Wilson escreveu: @@ -265,6 +265,7 @@ struct mceusb_dev { u32 connected:1; u32 tx_mask_inverted:1; u32 microsoft_gen1:1; +

Wintv-HVR-1120 woes

2010-10-21 Thread Sasha Sirotkin
I'm having all sorts of troubles with Wintv-HVR-1120 on Ubuntu 10.10 (kernel 2.6.35-22). Judging from what I've seen on the net, including this mailing list, I'm not the only one not being able to use this card and no solution seem to exist. Problems: 1. The driver yells various cryptic error

Wintv-HVR-1120 woes

2010-10-21 Thread Sasha Sirotkin
I'm having all sorts of troubles with Wintv-HVR-1120 on Ubuntu 10.10 (kernel 2.6.35-22). Judging from what I've seen on the net, including this mailing list, I'm not the only one not being able to use this card and no solution seem to exist. Problems: 1. The driver yells various cryptic error

Re: [PATCH 0/3] Remaining patches in my queue for IR

2010-10-21 Thread Maxim Levitsky
On Wed, 2010-10-20 at 14:40 -0400, Jarod Wilson wrote: On Sun, Oct 17, 2010 at 12:56:27AM +0200, Maxim Levitsky wrote: Hi, This series is rebased on top of media_tree/staging/v2.6.37 only. Really this time, sorry for cheating, last time :-) The first patch like we agreed extends the