Re: [PATCH v16 1/2] MFD: WL1273 FM Radio: MFD driver for the FM radio.

2010-11-22 Thread Matti J. Aaltonen
Hello Samuel, On Wed, 2010-11-17 at 15:42 +0200, Matti J. Aaltonen wrote: This is the core of the WL1273 FM radio driver, it connects the two child modules. This is a parent for two child drivers: drivers/media/radio/radio-wl1273.c and sound/soc/codecs/wl1273.c Radio-wl1273 implements

Re: [RFC/PATCH v5 01/12] media: Media device node support

2010-11-22 Thread Hans Verkuil
On Monday, November 22, 2010 00:35:54 Laurent Pinchart wrote: Hi Jonathan, I forgot to answer one of your comments. On Wednesday 17 November 2010 01:31:15 Jonathan Corbet wrote: [snip] +static unsigned int media_poll(struct file *filp, +struct

Re: [PATCH 1/5] uvcvideo: Lock controls mutex when querying menus

2010-11-22 Thread Hans Verkuil
On Sunday, November 21, 2010 22:45:48 Laurent Pinchart wrote: Hi Hans, Thanks for the comment. On Sunday 21 November 2010 22:18:41 Hans Verkuil wrote: On Sunday, November 21, 2010 21:32:49 Laurent Pinchart wrote: uvc_find_control() must be called with the controls mutex locked. Fix

Re: Race condition between v4l2_open() and video_unregister_device()

2010-11-22 Thread Hans Verkuil
On Monday, November 22, 2010 01:23:39 Laurent Pinchart wrote: Hi Hans, I believe you've introduced a race condition in commit dd0daf2a6fb6bec436a3ef68bd585ea09a2a54b7 v4l2-dev: remove unnecessary lock around atomic clear_bit By removing the mutex_lock/unlock around clear_bit, you're

[PATCH FOR 2.6.37] Revert V4L/DVB: v4l2-dev: remove unnecessary lock around atomic clear_bit

2010-11-22 Thread Laurent Pinchart
Removing the mutex_lock/unlock around clear_bit allowed device_unregister() to race with v4l2_open(). The device can be unregistered between the video_devdata() and video_get() calls. Revert the patch to fix the problem. This reverts commit dd0daf2a6fb6bec436a3ef68bd585ea09a2a54b7.

What should poll() return when a device is unregistered ? (was media: Media device node support)

2010-11-22 Thread Laurent Pinchart
Hi Hans, On Monday 22 November 2010 10:08:06 Hans Verkuil wrote: On Monday, November 22, 2010 00:35:54 Laurent Pinchart wrote: Hi Jonathan, I forgot to answer one of your comments. On Wednesday 17 November 2010 01:31:15 Jonathan Corbet wrote: [snip] +static unsigned int

Re: Zooming with V4L2

2010-11-22 Thread Laurent Pinchart
Hi Shuzhen, On Sunday 21 November 2010 00:50:59 Shuzhen Wang wrote: Hello, Laurent, Thank you for the reply. In our case, most of the time the sensor outputs bigger image size than the output size, so the ISP hardware does downscaling. When zooming in, we can do cropping, and less

Re: [PATCH FOR 2.6.37] Revert V4L/DVB: v4l2-dev: remove unnecessary lock around atomic clear_bit

2010-11-22 Thread Hans Verkuil
On Monday, November 22, 2010 11:21:27 Laurent Pinchart wrote: Removing the mutex_lock/unlock around clear_bit allowed device_unregister() to race with v4l2_open(). The device can be unregistered between the video_devdata() and video_get() calls. Revert the patch to fix the problem. This

Re: Zooming with V4L2

2010-11-22 Thread Hans de Goede
Hi, On 11/22/2010 11:59 AM, Laurent Pinchart wrote: Hi Shuzhen, On Sunday 21 November 2010 00:50:59 Shuzhen Wang wrote: Hello, Laurent, Thank you for the reply. In our case, most of the time the sensor outputs bigger image size than the output size, so the ISP hardware does downscaling.

Re: tvp5150 extension to tvp5151

2010-11-22 Thread Mauro Carvalho Chehab
Hi Raffaele, Em 19-11-2010 16:26, Raffaele Recalcati escreveu: I need to support fully tvp5151. So I'm trying to understand your driver, that is ready for VBI and not for video acquisition. I also take sometimes a look at tvp514x.c, for instance trying to add VIDIOC_ENUM_FMT and other

Re: Zooming with V4L2

2010-11-22 Thread Laurent Pinchart
Hi Hans, On Monday 22 November 2010 12:23:49 Hans de Goede wrote: On 11/22/2010 11:59 AM, Laurent Pinchart wrote: On Sunday 21 November 2010 00:50:59 Shuzhen Wang wrote: Hello, Laurent, Thank you for the reply. In our case, most of the time the sensor outputs bigger image size than

Re: Zooming with V4L2

2010-11-22 Thread Laurent Pinchart
On Monday 22 November 2010 12:34:04 Laurent Pinchart wrote: On Monday 22 November 2010 12:23:49 Hans de Goede wrote: On 11/22/2010 11:59 AM, Laurent Pinchart wrote: On Sunday 21 November 2010 00:50:59 Shuzhen Wang wrote: Hello, Laurent, Thank you for the reply. In our case,

Re: [PATCH] [media] gspca - main: Fix a regression with the PS3 Eye webcam

2010-11-22 Thread Antonio Ospite
On Fri, 5 Nov 2010 23:08:12 +0100 Antonio Ospite osp...@studenti.unina.it wrote: From: =?UTF-8?q?Jean-Fran=C3=A7ois=20Moine?= moin...@free.fr commit f43402fa55bf5e7e190c176343015122f694857c upstream. When audio is present, some alternate settings were skipped. This prevented some webcams

Re: What should poll() return when a device is unregistered ? (was media: Media device node support)

2010-11-22 Thread Hans Verkuil
On Monday, November 22, 2010 11:41:27 Laurent Pinchart wrote: Hi Hans, On Monday 22 November 2010 10:08:06 Hans Verkuil wrote: On Monday, November 22, 2010 00:35:54 Laurent Pinchart wrote: Hi Jonathan, I forgot to answer one of your comments. On Wednesday 17 November 2010

RE: [PATCH 1/7] v4l: add videobuf2 Video for Linux 2 driver framework

2010-11-22 Thread Sewoon Park
Hi~ Marek. Some comments in here. Saturday, November 20, 2010 12:56 AM Marek Szyprowski wrote : To: linux-media@vger.kernel.org Cc: m.szyprow...@samsung.com; pa...@osciak.com; kyungmin.p...@samsung.com Subject: [PATCH 1/7] v4l: add videobuf2 Video for Linux 2 driver framework From: Pawel

Re: Zooming with V4L2

2010-11-22 Thread Hans Verkuil
On Monday, November 22, 2010 12:34:50 Laurent Pinchart wrote: On Monday 22 November 2010 12:34:04 Laurent Pinchart wrote: On Monday 22 November 2010 12:23:49 Hans de Goede wrote: On 11/22/2010 11:59 AM, Laurent Pinchart wrote: On Sunday 21 November 2010 00:50:59 Shuzhen Wang wrote:

Re: gspca_ov534: Changing framerates, different behaviour in 2.6.36

2010-11-22 Thread Antonio Ospite
On Sat, 13 Nov 2010 16:45:37 +0100 Antonio Ospite osp...@studenti.unina.it wrote: On Sat, 13 Nov 2010 16:12:05 +0100 Antonio Ospite osp...@studenti.unina.it wrote: guvcview: If I: 1. Go to the Video Files Tab 2. Change the Frame Rate value from the drop down menu [...]

Re: radio-timb: proposed patch to convert to unlocked_ioctl

2010-11-22 Thread Richard Röjfors
Hi Hans, On 11/14/2010 02:56 PM, Hans Verkuil wrote: Hi Richard, Can you check if this patch is OK? It's against the v2.6.38 media_tree branch. Sorry for a late response, I will look at this now. Thanks for the patch work! --Richard -- To unsubscribe from this list: send the line

Re: What should poll() return when a device is unregistered ? (was media: Media device node support)

2010-11-22 Thread Andy Walls
On Mon, 2010-11-22 at 12:36 +0100, Hans Verkuil wrote: On Monday, November 22, 2010 11:41:27 Laurent Pinchart wrote: Hi Hans, On Monday 22 November 2010 10:08:06 Hans Verkuil wrote: On Monday, November 22, 2010 00:35:54 Laurent Pinchart wrote: Hi Jonathan, This doesn't really

Re: Zooming with V4L2

2010-11-22 Thread Sylwester Nawrocki
Hello, On 11/22/2010 12:53 PM, Hans Verkuil wrote: On Monday, November 22, 2010 12:34:50 Laurent Pinchart wrote: On Monday 22 November 2010 12:34:04 Laurent Pinchart wrote: On Monday 22 November 2010 12:23:49 Hans de Goede wrote: On 11/22/2010 11:59 AM, Laurent Pinchart wrote: On Sunday 21

RE: [PATCH 1/7] v4l: add videobuf2 Video for Linux 2 driver framework

2010-11-22 Thread Marek Szyprowski
Hello, On Monday, November 22, 2010 12:41 PM Sewoon Park wrote: Hi~ Marek. Some comments in here. Saturday, November 20, 2010 12:56 AM Marek Szyprowski wrote : To: linux-media@vger.kernel.org Cc: m.szyprow...@samsung.com; pa...@osciak.com; kyungmin.p...@samsung.com Subject: [PATCH

Re: tvp5150 extension to tvp5151

2010-11-22 Thread Raffaele Recalcati
On Mon, Nov 22, 2010 at 12:32 PM, Mauro Carvalho Chehab mche...@infradead.org wrote: Hi Raffaele, Em 19-11-2010 16:26, Raffaele Recalcati escreveu: I need to support fully tvp5151. So I'm trying to understand your driver, that is ready for VBI and not for video acquisition. I also take

Re: [PATCH 1/5] uvcvideo: Lock controls mutex when querying menus

2010-11-22 Thread Laurent Pinchart
Hi Hans, On Monday 22 November 2010 10:21:41 Hans Verkuil wrote: On Sunday, November 21, 2010 22:45:48 Laurent Pinchart wrote: On Sunday 21 November 2010 22:18:41 Hans Verkuil wrote: On Sunday, November 21, 2010 21:32:49 Laurent Pinchart wrote: uvc_find_control() must be called with the

Re: Problem with Compro T200 (TDA1004x) and tuning Hi

2010-11-22 Thread Mike Martin
On 22 November 2010 06:08, hermann pitton hermann-pit...@arcor.de wrote: Hi Mike, Am Sonntag, den 21.11.2010, 17:58 + schrieb Mike Martin: I am trying to tune channels with this card (which seems to be installed OK). However the output is Using DVB card Philips TDA10046H DVB-T tuning

RE: [omap3isp][PATCH v2 8/9] omap3isp: ccp2: Make SYSCONFIG fields consistent

2010-11-22 Thread Aguirre, Sergio
Hi, -Original Message- From: David Cohen [mailto:david.co...@nokia.com] Sent: Saturday, November 20, 2010 4:49 AM To: ext Laurent Pinchart Cc: Aguirre, Sergio; linux-media@vger.kernel.org Subject: Re: [omap3isp][PATCH v2 8/9] omap3isp: ccp2: Make SYSCONFIG fields consistent On

RE: [omap3isp RFC][PATCH 1/4] omap3isp: Abstract isp subdevs clock control

2010-11-22 Thread Aguirre, Sergio
-Original Message- From: David Cohen [mailto:david.co...@nokia.com] Sent: Saturday, November 20, 2010 5:27 AM To: Aguirre, Sergio Cc: Laurent Pinchart; linux-media@vger.kernel.org Subject: Re: [omap3isp RFC][PATCH 1/4] omap3isp: Abstract isp subdevs clock control Hi Sergio, Hi

RE: [omap3isp RFC][PATCH 2/4] omap3isp: Move CCDC LSC prefetch wait to main isp code

2010-11-22 Thread Aguirre, Sergio
Hi David and Laurent, -Original Message- From: Laurent Pinchart [mailto:laurent.pinch...@ideasonboard.com] Sent: Saturday, November 20, 2010 11:29 AM To: David Cohen Cc: Aguirre, Sergio; linux-media@vger.kernel.org Subject: Re: [omap3isp RFC][PATCH 2/4] omap3isp: Move CCDC LSC

RE: [omap3isp RFC][PATCH 0/4] Improve inter subdev interaction

2010-11-22 Thread Aguirre, Sergio
-Original Message- From: Laurent Pinchart [mailto:laurent.pinch...@ideasonboard.com] Sent: Saturday, November 20, 2010 11:31 AM To: David Cohen Cc: Aguirre, Sergio; linux-media@vger.kernel.org Subject: Re: [omap3isp RFC][PATCH 0/4] Improve inter subdev interaction Hi David,

Re: [omap3isp RFC][PATCH 2/4] omap3isp: Move CCDC LSC prefetch wait to main isp code

2010-11-22 Thread Laurent Pinchart
Hi Sergio, On Monday 22 November 2010 16:29:46 Aguirre, Sergio wrote: On Saturday, November 20, 2010 11:29 AM Aguirre, Sergio wrote: On Saturday 20 November 2010 12:39:56 David Cohen wrote: On Sat, Nov 20, 2010 at 12:23:49AM +0100, ext Sergio Aguirre wrote: Since this sequence strictly

RE: [omap3isp RFC][PATCH 2/4] omap3isp: Move CCDC LSC prefetch wait to main isp code

2010-11-22 Thread Aguirre, Sergio
Hi Laurent, -Original Message- From: Laurent Pinchart [mailto:laurent.pinch...@ideasonboard.com] Sent: Monday, November 22, 2010 9:35 AM To: Aguirre, Sergio Cc: David Cohen; linux-media@vger.kernel.org Subject: Re: [omap3isp RFC][PATCH 2/4] omap3isp: Move CCDC LSC prefetch wait to

Re: [omap3isp][PATCH v2 8/9] omap3isp: ccp2: Make SYSCONFIG fields consistent

2010-11-22 Thread David Cohen
On Mon, Nov 22, 2010 at 04:19:42PM +0100, ext Aguirre, Sergio wrote: Hi, -Original Message- From: David Cohen [mailto:david.co...@nokia.com] Sent: Saturday, November 20, 2010 4:49 AM To: ext Laurent Pinchart Cc: Aguirre, Sergio; linux-media@vger.kernel.org Subject: Re:

Re: [omap3isp RFC][PATCH 0/4] Improve inter subdev interaction

2010-11-22 Thread David Cohen
Hi Laurent and Sergio, On Mon, Nov 22, 2010 at 04:31:09PM +0100, ext Aguirre, Sergio wrote: -Original Message- From: Laurent Pinchart [mailto:laurent.pinch...@ideasonboard.com] Sent: Saturday, November 20, 2010 11:31 AM To: David Cohen Cc: Aguirre, Sergio;

Re: hg pull http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/

2010-11-22 Thread Mauro Carvalho Chehab
Em 17-11-2010 10:28, Manu Abraham escreveu: On Wed, Nov 17, 2010 at 7:48 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: Em 14-11-2010 18:48, Manu Abraham escreveu: Mauro, Please pull from http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/ for the following changes. changeset

Re: [PATCH 05/10] saa7134: protect the ir user count

2010-11-22 Thread Mauro Carvalho Chehab
Em 19-11-2010 21:43, David Härdeman escreveu: The use of the saa7134_card_ir-users seems racy, so protect the count with a spinlock. Also use proper data types as arguments to __saa7134_ir_start() and __saa7134_ir_stop() to remove some unnecessary casts. Hmm... instead of using a spinlock,

Re: gspca_ov534: Changing framerates, different behaviour in 2.6.36

2010-11-22 Thread Jean-Francois Moine
On Mon, 22 Nov 2010 13:11:11 +0100 Antonio Ospite osp...@studenti.unina.it wrote: since 2.6.36 + the regression fix in [1] (please apply it): 3a. dmesg shows the message: ov534: frame_rate: xx 3b. guvcviews gives some errors and the preview image halts: VIDIOC_QBUF - Unable

Re: hg pull http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/

2010-11-22 Thread Manu Abraham
On Mon, Nov 22, 2010 at 9:55 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: Em 17-11-2010 10:28, Manu Abraham escreveu: On Wed, Nov 17, 2010 at 7:48 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: Em 14-11-2010 18:48, Manu Abraham escreveu: Mauro, Please pull from

Re: [PATCH 06/10] saa7134: make module parameters boolean

2010-11-22 Thread Mauro Carvalho Chehab
Em 19-11-2010 21:43, David Härdeman escreveu: int to bool conversion for module parameters which are truely boolean. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/video/saa7134/saa7134-input.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff

Re: [PATCH 09/10] mceusb: int to bool conversion

2010-11-22 Thread Mauro Carvalho Chehab
Em 19-11-2010 21:43, David Härdeman escreveu: Convert boolean variables to use the corresponding data type. Signed-off-by: David Härdeman da...@hardeman.nu Waiting for Jarod's comments, but the same comment I made on the previous patch applies to this one. --- drivers/media/rc/mceusb.c |

Re: [stable] [PATCH] [media] gspca - main: Fix a regression with the PS3 Eye webcam

2010-11-22 Thread Greg KH
On Mon, Nov 22, 2010 at 12:34:18PM +0100, Antonio Ospite wrote: On Fri, 5 Nov 2010 23:08:12 +0100 Antonio Ospite osp...@studenti.unina.it wrote: From: =?UTF-8?q?Jean-Fran=C3=A7ois=20Moine?= moin...@free.fr commit f43402fa55bf5e7e190c176343015122f694857c upstream. When audio is

[cron job] v4l-dvb daily build: WARNINGS

2010-11-22 Thread Hans Verkuil
This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below. Results of the daily build of v4l-dvb: date:Mon Nov 22 19:00:29 CET 2010 git master: 59365d136d205cc20fe666ca7f89b1c5001b0d5a git media-master: gcc version:

Re: media_tree.git weirdness

2010-11-22 Thread Mauro Carvalho Chehab
Em 16-11-2010 21:31, David Härdeman escreveu: Mauro, the current state of the staging/for_v2.6.38 branch seems a bit weird with regard to the three patches to use raw decoding for the Encore FM 5.3, resulting cleanups to saa7134 and removal of ir-common. I still see

Re: [PATCH 09/10] mceusb: int to bool conversion

2010-11-22 Thread Jarod Wilson
On Nov 22, 2010, at 12:42 PM, Mauro Carvalho Chehab wrote: Em 19-11-2010 21:43, David Härdeman escreveu: Convert boolean variables to use the corresponding data type. Signed-off-by: David Härdeman da...@hardeman.nu Waiting for Jarod's comments, but the same comment I made on the previous

Max DVB-T tuners per USB 2.0 BUS?

2010-11-22 Thread Karl Hiramoto
Does anyone have experience with the max number of tuners you can use with the available bandwidth of USB 2.0? Assuming I'm using Avermedia with Afatech AF9015 devices on USB. How many of theses tuner devices put on the USB bus and watch standard TV? How many and watch HD 1080 resolution? I

Re: [PATCH 05/10] saa7134: protect the ir user count

2010-11-22 Thread David Härdeman
On Mon, Nov 22, 2010 at 02:55:42PM -0200, Mauro Carvalho Chehab wrote: Em 19-11-2010 21:43, David Härdeman escreveu: The use of the saa7134_card_ir-users seems racy, so protect the count with a spinlock. Also use proper data types as arguments to __saa7134_ir_start() and __saa7134_ir_stop() to

Re: [PATCH 06/10] saa7134: make module parameters boolean

2010-11-22 Thread David Härdeman
On Mon, Nov 22, 2010 at 03:40:13PM -0200, Mauro Carvalho Chehab wrote: Em 19-11-2010 21:43, David Härdeman escreveu: int to bool conversion for module parameters which are truely boolean. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/video/saa7134/saa7134-input.c |8

Re: [PATCH 09/10] mceusb: int to bool conversion

2010-11-22 Thread David Härdeman
On Mon, Nov 22, 2010 at 01:40:28PM -0500, Jarod Wilson wrote: On Nov 22, 2010, at 12:42 PM, Mauro Carvalho Chehab wrote: Em 19-11-2010 21:43, David Härdeman escreveu: Convert boolean variables to use the corresponding data type. Signed-off-by: David Härdeman da...@hardeman.nu Waiting for

[omap3isp RFC][PATCH v2 2/4] omap3isp: Move CCDC LSC prefetch wait to main isp code

2010-11-22 Thread Sergio Aguirre
Since this sequence strictly touches ISP global registers, it's not really part of the same register address space than the CCDC. Do this check in main isp code instead. Signed-off-by: Sergio Aguirre saagui...@ti.com --- drivers/media/video/isp/isp.c | 24

[omap3isp RFC][PATCH v2 3/4] omap3isp: sbl: Abstract SBL busy check

2010-11-22 Thread Sergio Aguirre
Make a nicer interface that can be used by anyone accessing the isp. Signed-off-by: Sergio Aguirre saagui...@ti.com --- drivers/media/video/isp/isp.c | 17 + drivers/media/video/isp/isp.h |2 ++ drivers/media/video/isp/ispccdc.c | 10 +- 3 files changed,

[omap3isp RFC][PATCH v2 0/4] Improve inter subdev interaction

2010-11-22 Thread Sergio Aguirre
Hi, These are some patches to make these operations more generic: - Clock control is being controlled in a very crude manner by subdevices, it should be centralized in isp.c. - LSC prefetch wait check is reading a main ISP register, so move it to isp.c - Abstract SBL busy check: we don't want

[omap3isp RFC][PATCH v2 1/4] omap3isp: Abstract isp subdevs clock control

2010-11-22 Thread Sergio Aguirre
Submodules shouldn't be aware of global register bit structure, specially if the submodules are shared in the future with other TI architectures (Davinci, future OMAPs, etc) Signed-off-by: Sergio Aguirre saagui...@ti.com --- drivers/media/video/isp/isp.c| 54

[omap3isp RFC][PATCH v2 4/4] omap3isp: csi2: Don't dump ISP main registers

2010-11-22 Thread Sergio Aguirre
This keeps the driver focused only on accessing CSI2 registers only. if the same info is needed, isp_print_status should be called instead. Signed-off-by: Sergio Aguirre saagui...@ti.com --- drivers/media/video/isp/ispcsi2.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff

Re: Problem with Compro T200 (TDA1004x) and tuning Hi

2010-11-22 Thread hermann pitton
Am Montag, den 22.11.2010, 15:08 + schrieb Mike Martin: On 22 November 2010 06:08, hermann pitton hermann-pit...@arcor.de wrote: Hi Mike, Am Sonntag, den 21.11.2010, 17:58 + schrieb Mike Martin: I am trying to tune channels with this card (which seems to be installed OK).

Please ignore... (RE: [omap3isp RFC][PATCH v2 0/4] Improve inter subdev interaction)

2010-11-22 Thread Aguirre, Sergio
-Original Message- From: Aguirre, Sergio Sent: Monday, November 22, 2010 1:48 PM To: Laurent Pinchart Cc: linux-media@vger.kernel.org; David Cohen; Aguirre, Sergio Subject: [omap3isp RFC][PATCH v2 0/4] Improve inter subdev interaction Hi, These are some patches to make these

[omap3isp RFC][RESEND PATCH v2 0/4] Improve inter subdev interaction

2010-11-22 Thread Sergio Aguirre
(Resending...) Hi, These are some patches to make these operations more generic: - Clock control is being controlled in a very crude manner by subdevices, it should be centralized in isp.c. - LSC prefetch wait check is reading a main ISP register, so move it to isp.c - Abstract SBL busy

[omap3isp RFC][RESEND PATCH v2 3/4] omap3isp: sbl: Abstract SBL busy check

2010-11-22 Thread Sergio Aguirre
Make a nicer interface that can be used by anyone accessing the isp. Signed-off-by: Sergio Aguirre saagui...@ti.com --- drivers/media/video/isp/isp.c | 17 + drivers/media/video/isp/isp.h |2 ++ drivers/media/video/isp/ispccdc.c | 10 +- 3 files changed,

[omap3isp RFC][RESEND PATCH v2 2/4] omap3isp: Move CCDC LSC prefetch wait to main isp code

2010-11-22 Thread Sergio Aguirre
Since this sequence strictly touches ISP global registers, it's not really part of the same register address space than the CCDC. Do this check in main isp code instead. Also, rename function from ispccdc_lsc_* to isp_ccdc_lsc_*. Signed-off-by: Sergio Aguirre saagui...@ti.com ---

[omap3isp RFC][RESEND PATCH v2 4/4] omap3isp: csi2: Don't dump ISP main registers

2010-11-22 Thread Sergio Aguirre
This keeps the driver focused only on accessing CSI2 registers only. if the same info is needed, isp_print_status should be called instead. Signed-off-by: Sergio Aguirre saagui...@ti.com --- drivers/media/video/isp/ispcsi2.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff

[omap3isp RFC][RESEND PATCH v2 1/4] omap3isp: Abstract isp subdevs clock control

2010-11-22 Thread Sergio Aguirre
Submodules shouldn't be aware of global register bit structure, specially if the submodules are shared in the future with other TI architectures (Davinci, future OMAPs, etc) Signed-off-by: Sergio Aguirre saagui...@ti.com --- drivers/media/video/isp/isp.c| 46

Re: [PATCH 1/5] uvcvideo: Lock controls mutex when querying menus

2010-11-22 Thread Hans Verkuil
On Monday, November 22, 2010 15:57:38 Laurent Pinchart wrote: Hi Hans, On Monday 22 November 2010 10:21:41 Hans Verkuil wrote: On Sunday, November 21, 2010 22:45:48 Laurent Pinchart wrote: On Sunday 21 November 2010 22:18:41 Hans Verkuil wrote: On Sunday, November 21, 2010 21:32:49

RE: Zooming with V4L2

2010-11-22 Thread Shuzhen Wang
Hello, Laurent, I Get the logic you have behind using cropping/scaling. The reason I wanted to use V4L2_CID_ZOOM_ABSOLUTE are that the application will have a simpler interface to control zoom level supported by the hardware (yet may be less flexible). In other words, the driver gives out the

Re: What should poll() return when a device is unregistered ? (was media: Media device node support)

2010-11-22 Thread Andy Walls
On Mon, 2010-11-22 at 17:19 +0100, Laurent Pinchart wrote: Hi Andy, On Monday 22 November 2010 13:51:37 Andy Walls wrote: On Mon, 2010-11-22 at 12:36 +0100, Hans Verkuil wrote: On Monday, November 22, 2010 11:41:27 Laurent Pinchart wrote: Hi Hans, On Monday 22 November 2010

Re: [PATCH/RFC] v4l: Add subdev sensor g_skip_frames operation

2010-11-22 Thread Eino-Ville Talvala
On 11/19/2010 6:22 AM, Laurent Pinchart wrote: Hi Guennadi, On Friday 19 November 2010 15:15:11 Guennadi Liakhovetski wrote: On Fri, 19 Nov 2010, Laurent Pinchart wrote: On Friday 19 November 2010 14:42:31 Hans Verkuil wrote: On Friday 19 November 2010 14:26:42 Laurent Pinchart wrote: Some

Re: [PATCH FOR 2.6.37] Revert V4L/DVB: v4l2-dev: remove unnecessary lock around atomic clear_bit

2010-11-22 Thread Hans Verkuil
On Monday, November 22, 2010 12:20:25 Hans Verkuil wrote: On Monday, November 22, 2010 11:21:27 Laurent Pinchart wrote: Removing the mutex_lock/unlock around clear_bit allowed device_unregister() to race with v4l2_open(). The device can be unregistered between the video_devdata() and

Re: [PATCH FOR 2.6.37] Revert V4L/DVB: v4l2-dev: remove unnecessary lock around atomic clear_bit

2010-11-22 Thread Laurent Pinchart
Hi Hans, On Tuesday 23 November 2010 01:14:28 Hans Verkuil wrote: On Monday, November 22, 2010 12:20:25 Hans Verkuil wrote: On Monday, November 22, 2010 11:21:27 Laurent Pinchart wrote: Removing the mutex_lock/unlock around clear_bit allowed device_unregister() to race with v4l2_open().