Re: [PATCH 04/12] v4l: vb2-dma-contig: add setup of sglist for MMAP buffers

2012-06-11 Thread Laurent Pinchart
Hi Tomasz, On Friday 08 June 2012 16:31:31 Tomasz Stanislawski wrote: Hi Laurent and Subash, I confirm the issue found by Subash. The function vb2_dc_kaddr_to_pages does fail for some occasions. The failures are rather strange like 'got 95 of 150 pages'. It took me some time to find the

Fwd: [Bug 871427] Re: 1164:7efd YUANRD STK7700D DVB TV card

2012-06-11 Thread Gregor Jasny
Hello, this bug is lingering in the Ubuntu bugtracker since over half a year. Does anyone know if this dongle just lacks an usb id entry in some driver, a completely new driver or will never be supported due to the lack of specs? Thanks, Gregor Original Message Subject:

Re: [PATCH 3/5] usb: gadget/uvc: Add super-speed support to UVC webcam gadget

2012-06-11 Thread Laurent Pinchart
Hi Bhupesh, (Dropping Greg from the CC list, I think he gets enough e-mails already without our help :-)) On Saturday 09 June 2012 13:39:34 Bhupesh SHARMA wrote: Hi Laurent, Thanks for your review comments. Please find my comments inline: As Felipe has already applied the patch to his

Re: [PATCH 1/1] v4l: Remove __user from interface structure definitions

2012-06-11 Thread Laurent Pinchart
Hi Sakari, On Saturday 26 May 2012 23:07:49 Sakari Ailus wrote: The __user macro is not strictly needed in videodev2.h, and it also prevents using the header file as such in the user space. __user is already not used in many of the interface structs containing pointers. Stop using __user in

Re: [GIT PULL FOR 3.6] V4L2 API cleanups

2012-06-11 Thread Laurent Pinchart
Hi Sakari, On Sunday 10 June 2012 23:22:59 Sakari Ailus wrote: Hi Mauro, Here are two V4L2 API cleanup patches; the first removes __user from videodev2.h from a few places, making it possible to use the header file as such in user space, while the second one changes the v4l2_buffer.input

Re: [PATCH] media: videobuf2: fix kernel panic due to missing assign NULL to alloc_ctx

2012-06-11 Thread Laurent Pinchart
Hi Albert, On Friday 08 June 2012 19:55:11 Albert Wang wrote: In function vb2_dma_contig_cleanup_ctx(), we only kfree the alloc_ctx If we didn't assign NULL to this point after kfree it, we may encounter the following kernel panic: kernel BUG at kernel/cred.c:98! Unable to handle

Re: [Q] Why is it needed to add an alsa module to v4l audio capture devices?

2012-06-11 Thread Laurent Pinchart
Hi Ezequiel, On Thursday 07 June 2012 15:26:04 Ezequiel Garcia wrote: Hi all, (I hope this is a genuine question, and I'm not avoiding my own homework here.) I'm trying to support the audio part of the stk1160 usb bridge (similar to em28xx). Currently, the snd-usb-audio module is being

Re: [PATCH 1/1] v4l: Remove __user from interface structure definitions

2012-06-11 Thread Sakari Ailus
On Mon, Jun 11, 2012 at 09:49:25AM +0200, Laurent Pinchart wrote: Hi Sakari, Hi Laurent, On Saturday 26 May 2012 23:07:49 Sakari Ailus wrote: The __user macro is not strictly needed in videodev2.h, and it also prevents using the header file as such in the user space. __user is already not

stv0297 signal issues on QAM256

2012-06-11 Thread Fontana
typo in subject -Ursprungligt meddelande- Från: linux-media-ow...@vger.kernel.org [mailto:linux-media-ow...@vger.kernel.org]För Fredrik Skickat: den 10 juni 2012 14:25 Till: linux-media@vger.kernel.org Ämne: stv0298 signal issues on QAM256 Hi. Unfortunatly my cable provider Comhem

[no subject]

2012-06-11 Thread Su Jiaquan
Hi Guennadi, I found in soc_camera when video device is opened, default format is applied sensor. I think this is the right thing to do, be it also means a lot of i2c transactions. I think in case of app wants to query drivers capability, it do a quick open-query-close, expecting only

extend v4l2_mbus_framefmt

2012-06-11 Thread Scott Jiang
Hi Guennadi and Hans, We use v4l2_mbus_framefmt to get frame format on the media bus in bridge driver. It only contains width and height. It's not a big problem in SD. But we need more info like front porch, sync width and back porch (similar to disp_format_s in v4l2_formats.h) in HD. I want to

[media] soc_camera: suggest to postpone applying default format

2012-06-11 Thread Su Jiaquan
Hi Guennadi, I found in soc_camera when video device is opened, default format is applied sensor. I think this is the right thing to do, be it also means a lot of i2c transactions. I think in case of app wants to query drivers capability, it do a quick “open-query-close”, expecting only

Re: [PATCH 1/1] v4l: Remove __user from interface structure definitions

2012-06-11 Thread Hans Verkuil
On Mon 11 June 2012 10:12:11 Sakari Ailus wrote: On Mon, Jun 11, 2012 at 09:49:25AM +0200, Laurent Pinchart wrote: Hi Sakari, Hi Laurent, On Saturday 26 May 2012 23:07:49 Sakari Ailus wrote: The __user macro is not strictly needed in videodev2.h, and it also prevents using the

Re: extend v4l2_mbus_framefmt

2012-06-11 Thread Hans Verkuil
On Mon 11 June 2012 10:18:06 Scott Jiang wrote: Hi Guennadi and Hans, We use v4l2_mbus_framefmt to get frame format on the media bus in bridge driver. It only contains width and height. It's not a big problem in SD. But we need more info like front porch, sync width and back porch (similar

RE: [PATCH] media: videobuf2: fix kernel panic due to missing assign NULL to alloc_ctx

2012-06-11 Thread Albert Wang
Hi, Laurent Thanks for your reply! We allocated the context when init_videobuf2() which will be called in soc_camera_open(), so if we get exit with exception in soc_camera_set_fmt() Actually we will double call vb2_dma_contig_cleanup_ctx(). ret = soc_camera_set_fmt(icd, f); if

RE: [PATCH] media: videobuf2: fix kernel panic due to missing assign NULL to alloc_ctx

2012-06-11 Thread Guennadi Liakhovetski
Hi Albert On Mon, 11 Jun 2012, Albert Wang wrote: Hi, Laurent Thanks for your reply! We allocated the context when init_videobuf2() which will be called in soc_camera_open(), so if we get exit with exception in soc_camera_set_fmt() Actually we will double call

Re: [GIT PULL FOR 3.6] V4L2 API cleanups

2012-06-11 Thread Sakari Ailus
On Mon, Jun 11, 2012 at 09:50:54AM +0200, Laurent Pinchart wrote: Hi Sakari, On Sunday 10 June 2012 23:22:59 Sakari Ailus wrote: Hi Mauro, Here are two V4L2 API cleanup patches; the first removes __user from videodev2.h from a few places, making it possible to use the header file as

RE: [PATCH] media: videobuf2: fix kernel panic due to missing assign NULL to alloc_ctx

2012-06-11 Thread Albert Wang
Hi, Guennadi Sorry, I made a mistake, and I found marvell-ccic used vb2_dma_contig_init_ctx() when open, but it didn't use the soc_camera. So for the driver which had used soc_camera, you are right. Our driver should update the usage. So the kernel panic due to our driver misunderstand the

RE: [PATCH] media: videobuf2: fix kernel panic due to missing assign NULL to alloc_ctx

2012-06-11 Thread Guennadi Liakhovetski
On Mon, 11 Jun 2012, Albert Wang wrote: Hi, Guennadi Sorry, I made a mistake, and I found marvell-ccic used vb2_dma_contig_init_ctx() when open, but it didn't use the soc_camera. So for the driver which had used soc_camera, you are right. Our driver should update the usage. So the

[PATCH 1/3] [media] s5p-tv: Replace printk with pr_* functions

2012-06-11 Thread Sachin Kamat
Replace printk with pr_* functions to silence checkpatch warnings. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/media/video/s5p-tv/hdmi_drv.c|6 -- drivers/media/video/s5p-tv/mixer_drv.c |6 +++--- drivers/media/video/s5p-tv/mixer_video.c |4 +++- 3 files

[PATCH 2/3] [media] s5p-mfc: Replace printk with pr_* functions

2012-06-11 Thread Sachin Kamat
Replace printk with pr_* functions to silence checkpatch warnings. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/media/video/s5p-mfc/s5p_mfc_debug.h |6 +++--- drivers/media/video/s5p-mfc/s5p_mfc_opr.c |5 +++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff

[PATCH 3/3] [media] s5p-fimc: Replace printk with pr_* functions

2012-06-11 Thread Sachin Kamat
Replace printk with pr_* functions to silence checkpatch warnings. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/media/video/s5p-fimc/fimc-core.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/s5p-fimc/fimc-core.h

[PATCH] [media] s5p-mfc: Fix checkpatch error in s5p_mfc_shm.h file

2012-06-11 Thread Sachin Kamat
Fixes the following error: ERROR: open brace '{' following enum go on the same line +enum MFC_SHM_OFS +{ Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/media/video/s5p-mfc/s5p_mfc_shm.h |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 1/4] V4L: Rename V4L2_SEL_TGT_[CROP/COMPOSE]_ACTIVE to V4L2_SEL_TGT_[CROP/COMPOSE]

2012-06-11 Thread Sylwester Nawrocki
Hi Sakari, thanks for working on this. On 06/10/2012 09:34 PM, Sakari Ailus wrote: From: Sylwester Nawrockis.nawro...@samsung.com This patch drops the _ACTIVE part from the selection target names as a prerequisite to unify the selection target names on subdevs and regular video nodes.

Re: [PATCH 1/4] V4L: Rename V4L2_SEL_TGT_[CROP/COMPOSE]_ACTIVE to V4L2_SEL_TGT_[CROP/COMPOSE]

2012-06-11 Thread Sakari Ailus
Sylwester Nawrocki wrote: Hi Sakari, thanks for working on this. On 06/10/2012 09:34 PM, Sakari Ailus wrote: From: Sylwester Nawrockis.nawro...@samsung.com This patch drops the _ACTIVE part from the selection target names as a prerequisite to unify the selection target names on subdevs

Re: [PATCH 3/3] [media] s5p-fimc: Replace printk with pr_* functions

2012-06-11 Thread Sylwester Nawrocki
Hi Sachin, On 06/11/2012 12:13 PM, Sachin Kamat wrote: Replace printk with pr_* functions to silence checkpatch warnings. Signed-off-by: Sachin Kamatsachin.ka...@linaro.org --- drivers/media/video/s5p-fimc/fimc-core.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff

Re: [Q] Why is it needed to add an alsa module to v4l audio capture devices?

2012-06-11 Thread Mauro Carvalho Chehab
Em 07-06-2012 15:26, Ezequiel Garcia escreveu: Hi all, (I hope this is a genuine question, and I'm not avoiding my own homework here.) I'm trying to support the audio part of the stk1160 usb bridge (similar to em28xx). Currently, the snd-usb-audio module is being loaded when I

Re: PWC ioctl inappropriate for device (Regression)

2012-06-11 Thread Bernard GODARD
Hi Hans, Thank you for your reply. I will try to do the fix in qastrocam-g2 myself as this program does not currently have a maintainer. Regards, On Sat, Jun 9, 2012 at 9:08 PM, Hans de Goede hdego...@redhat.com wrote: Hi, On 06/09/2012 07:06 PM, Bernard GODARD wrote: Dear all, I am

Re: [Q] Why is it needed to add an alsa module to v4l audio capture devices?

2012-06-11 Thread Ezequiel Garcia
Hi Laurent and Mauro, On Mon, Jun 11, 2012 at 10:30 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: Em 07-06-2012 15:26, Ezequiel Garcia escreveu: Hi all, (I hope this is a genuine question, and I'm not avoiding my own homework here.) I'm trying to support the audio part of the

cron job: media_tree daily build: WARNINGS

2012-06-11 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Mon Jun 11 19:00:18 CEST 2012 git hash:5472d3f17845c4398c6a510b46855820920c2181 gcc version: i686-linux-gcc

Re: PWC ioctl inappropriate for device (Regression)

2012-06-11 Thread Hans de Goede
Hi, On 06/11/2012 04:34 PM, Bernard GODARD wrote: Hi Hans, Thank you for your reply. I will try to do the fix in qastrocam-g2 myself as this program does not currently have a maintainer. Thanks! Please let me know if you need any help. If programs like qastrocam-g2 are going to depend on

[PATCH 1/3] em28xx: Fix wrong AC97 mic register usage

2012-06-11 Thread Ezequiel Garcia
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- drivers/media/video/em28xx/em28xx-audio.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/em28xx/em28xx-audio.c b/drivers/media/video/em28xx/em28xx-audio.c index d7e2a3d..e2a7a00 100644 ---

[PATCH 2/3] em28xx: Rename AC97 registers to use sound/ac97_codec.h definitions

2012-06-11 Thread Ezequiel Garcia
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- drivers/media/video/em28xx/em28xx-audio.c | 27 --- drivers/media/video/em28xx/em28xx-core.c | 33 +++-- 2 files changed, 31 insertions(+), 29 deletions(-) diff --git

[PATCH 3/3] em28xx: Remove unused AC97 register definitions

2012-06-11 Thread Ezequiel Garcia
There is a specific header sound/ac97_codec.h that defines these. All drivers should use it instead of rolling its own set of macros. Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- drivers/media/video/em28xx/em28xx-reg.h | 51 +-- 1 files changed, 1

Re: [media] soc_camera: suggest to postpone applying default format

2012-06-11 Thread Guennadi Liakhovetski
Hi Jiaquan On Mon, 11 Jun 2012, Su Jiaquan wrote: Hi Guennadi, I found in soc_camera when video device is opened, default format is applied sensor. I think this is the right thing to do, be it also means a lot of i2c transactions. It doesn't have to actually. It is up to the

Troubleshooting inputlirc and TeVii s480

2012-06-11 Thread Glenn Ramsey
I need some advice regarding setting up a remote on a DVB card. I apologise if this is not the correct list, but I couldn't find an lirc specific one. I have a TeVii s480 installed in a Mythbuntu 12.04 machine, which apart from the remote seems to be working fine. I have set up inputlirc using:

Re: [PATCH] Add quirk for camera of Lenovo Thinkpad X220 Tablet

2012-06-11 Thread Jakob Haufe
For the sake of completeness, I'll answer here as well. On Thu, 10 May 2012 08:45:45 +0200 Gregor Jasny gja...@googlemail.com wrote: Without this patch, is the image flipped in both: laptop and normal mode? Yes, it's flipped in both modes. My girlfriend actually used that as a workaround: Flip

Re: [PATCH 04/12] v4l: vb2-dma-contig: add setup of sglist for MMAP buffers

2012-06-11 Thread Subash Patel
Hi Laurent, Tomasz, On 06/10/2012 11:28 PM, Laurent Pinchart wrote: Hi Tomasz, On Friday 08 June 2012 16:31:31 Tomasz Stanislawski wrote: Hi Laurent and Subash, I confirm the issue found by Subash. The function vb2_dc_kaddr_to_pages does fail for some occasions. The failures are rather

Re: [PATCH v3 1/9] string: introduce memweight

2012-06-11 Thread Andrew Morton
On Sat, 9 Jun 2012 09:50:30 +0900 Akinobu Mita akinobu.m...@gmail.com wrote: memweight() is the function that counts the total number of bits set in memory area. Unlike bitmap_weight(), memweight() takes pointer and size in bytes to specify a memory area which does not need to be aligned to

Re: extend v4l2_mbus_framefmt

2012-06-11 Thread Scott Jiang
Hi Hans, I would expect that the combination of v4l2_mbus_framefmt + v4l2_dv_timings gives you the information you need. About v4l2_mbus_framefmt, you use V4L2_MBUS_FMT_FIXED. I guess you can't find any yuv 24 or rgb 16/24bit format in current v4l2_mbus_framefmt. But a bridge driver working