Re: [PATCH 00/11] drm/sun4i: add CEC support

2017-09-21 Thread Maxime Ripard
Hi Hans, On Fri, Sep 08, 2017 at 10:59:44AM +, Hans Verkuil wrote: > Hi Maxime, > > On 07/18/17 18:29, Maxime Ripard wrote: > > Hi, > > > > On Tue, Jul 11, 2017 at 11:06:52PM +0200, Hans Verkuil wrote: > >> On 11/07/17 22:39, Maxime Ripard wrote: > >>> On Tue, Jul 11, 2017 at 08:30:33AM

[PATCH] media: bt8xx: Fix err 'bt878_probe()'

2017-09-21 Thread Christophe JAILLET
This is odd to call 'pci_disable_device()' in an error path before a coresponding successful 'pci_enable_device()'. Return directly instead. Fixes: 77e0be12100a ("V4L/DVB (4176): Bug-fix: Fix memory overflow") Signed-off-by: Christophe JAILLET ---

Re: [PATCH 00/11] drm/sun4i: add CEC support

2017-09-21 Thread Hans Verkuil
On 21/09/17 22:37, Maxime Ripard wrote: > Hi Hans, > > On Fri, Sep 08, 2017 at 10:59:44AM +, Hans Verkuil wrote: >> Hi Maxime, >> >> On 07/18/17 18:29, Maxime Ripard wrote: >>> Hi, >>> >>> On Tue, Jul 11, 2017 at 11:06:52PM +0200, Hans Verkuil wrote: On 11/07/17 22:39, Maxime Ripard

Re: [media] s2255drv: Adjust 13 checks for null pointers

2017-09-21 Thread SF Markus Elfring
>> Would you like to clarify corresponding concerns any more? >> > > Look at the `git log` I did this also for a moment. > and it just copies those lines: The Git software preserves these three message fields (when special characters were used in the commit message). Can you accept such

Re: [PATCH] scripts: kernel-doc: fix nexted handling

2017-09-21 Thread Markus Heiser
> Jon, > > While documenting some DVB demux headers, I noticed the above bug. > > scripts/kernel-doc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/kernel-doc b/scripts/kernel-doc > index 9d3eafea58f0..15f934a23d1d 100755 > --- a/scripts/kernel-doc > +++

Re: [PATCH 03/25] media: dvbdev: convert DVB device types into an enum

2017-09-21 Thread Michael Ira Krufky
On Wed, Sep 20, 2017 at 3:11 PM, Mauro Carvalho Chehab wrote: > Enums can be documented via kernel-doc. So, convert the > DVB_DEVICE_* macros to an enum. > > Signed-off-by: Mauro Carvalho Chehab > --- > drivers/media/dvb-core/dvbdev.c | 34

Re: [PATCH] tc358743: fix connected/active CSI-2 lane reporting

2017-09-21 Thread Ian Arkver
On 21/09/17 12:04, Ian Arkver wrote: Hi Philipp On 21/09/17 11:24, Philipp Zabel wrote: g_mbus_config was supposed to indicate all supported lane numbers, not only the number of those currently in active use. Since the tc358743 can dynamically reduce the number of active lanes if the required

Re: [PATCH] tc358743: fix connected/active CSI-2 lane reporting

2017-09-21 Thread Philipp Zabel
On Thu, 2017-09-21 at 12:41 +0100, Dave Stevenson wrote: > Hi Philipp > > On 21 September 2017 at 11:24, Philipp Zabel > wrote: [...] > > +   if (state->csi_lanes_in_use > 4) > > One could suggest > if (state->csi_lanes_in_use > state->bus.num_data_lanes) > here.

Re: [RFC PATCH v5 2/6] i2c: add helpers to ease DMA handling

2017-09-21 Thread Jonathan Cameron
On Wed, 20 Sep 2017 20:59:52 +0200 Wolfram Sang wrote: > One helper checks if DMA is suitable and optionally creates a bounce > buffer, if not. The other function returns the bounce buffer and makes > sure the data is properly copied back to the message. > >

Re: [PATCH] [media] cx231xx-cards: fix NULL-deref on missing association descriptor

2017-09-21 Thread Andrey Konovalov
On Thu, Sep 21, 2017 at 10:40 AM, Johan Hovold wrote: > Make sure to check that we actually have an Interface Association > Descriptor before dereferencing it during probe to avoid dereferencing a > NULL-pointer. > > Fixes: e0d3bafd0258 ("V4L/DVB (10954): Add cx231xx USB

Re: [RFC PATCH v5 3/6] i2c: add docs to clarify DMA handling

2017-09-21 Thread Jonathan Cameron
On Wed, 20 Sep 2017 16:56:48 -0300 Mauro Carvalho Chehab wrote: > Em Wed, 20 Sep 2017 20:59:53 +0200 > Wolfram Sang escreveu: > > > Signed-off-by: Wolfram Sang > > Documentation looks OK on my

Re: [PATCH 02/25] media: dvb_frontend: fix return values for FE_SET_PROPERTY

2017-09-21 Thread Shuah Khan
On 09/20/2017 01:11 PM, Mauro Carvalho Chehab wrote: > There are several problems with regards to the return of > FE_SET_PROPERTY. The original idea were to return per-property > return codes via tvp->result field, and to return an updated > set of values. > > However, that never worked. What's

Re: [RFC PATCH v5 6/6] i2c: dev: mark RDWR buffers as DMA_SAFE

2017-09-21 Thread Wolfram Sang
On Thu, Sep 21, 2017 at 03:17:44PM +0100, Jonathan Cameron wrote: > On Wed, 20 Sep 2017 20:59:56 +0200 > Wolfram Sang wrote: > > > Signed-off-by: Wolfram Sang > > Makes sense as do the other drivers. > > Feel free to add > >

Re: [RFC PATCH v5 2/6] i2c: add helpers to ease DMA handling

2017-09-21 Thread Jonathan Cameron
On Thu, 21 Sep 2017 16:15:28 +0200 Wolfram Sang wrote: > > > > +/** > > > > + * i2c_release_dma_safe_msg_buf - release DMA safe buffer and sync > > > > with i2c_msg > > > > + * @msg: the message to be synced with > > > > + * @buf: the buffer obtained from

Re: [PATCH] ov9655: fix potential integer overflow

2017-09-21 Thread kbuild test robot
Hi Gustavo, [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.14-rc1 next-20170921] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Gustavo-A-R-Silva/ov9655-fix

Re: [PATCH] tc358743: fix connected/active CSI-2 lane reporting

2017-09-21 Thread Hans Verkuil
On 09/21/17 14:35, Philipp Zabel wrote: > Hi Ian, > > On Thu, 2017-09-21 at 12:06 +0100, Ian Arkver wrote: > [...] >>> My understanding of Hans' comment: >>> "I'd also add a comment that all other flags must be 0 if the device >>> tree is used. This to avoid mixing the two." >>> >>> is that all

Re: [RFC PATCH v5 2/6] i2c: add helpers to ease DMA handling

2017-09-21 Thread Jonathan Cameron
On Thu, 21 Sep 2017 14:59:22 +0100 Jonathan Cameron wrote: > On Wed, 20 Sep 2017 20:59:52 +0200 > Wolfram Sang wrote: > > > One helper checks if DMA is suitable and optionally creates a bounce > > buffer, if not. The other function

Re: [RFC PATCH v5 2/6] i2c: add helpers to ease DMA handling

2017-09-21 Thread Wolfram Sang
> > > +/** > > > + * i2c_release_dma_safe_msg_buf - release DMA safe buffer and sync with > > > i2c_msg > > > + * @msg: the message to be synced with > > > + * @buf: the buffer obtained from i2c_get_dma_safe_msg_buf(). May be > > > NULL. > > > + */ > > > +void

Re: [RFC PATCH v5 6/6] i2c: dev: mark RDWR buffers as DMA_SAFE

2017-09-21 Thread Jonathan Cameron
On Wed, 20 Sep 2017 20:59:56 +0200 Wolfram Sang wrote: > Signed-off-by: Wolfram Sang Makes sense as do the other drivers. Feel free to add Reviewed-by: Jonathan Cameron to all of them (though

Re: [PATCH 17/25] media: dvb_frontend: dtv_property_process_set() cleanups

2017-09-21 Thread Shuah Khan
On 09/20/2017 01:11 PM, Mauro Carvalho Chehab wrote: > From: Satendra Singh Thakur > > Since all properties in the func dtv_property_process_set() use > at most 4 bytes arguments, change the code to pass > u32 cmd and u32 data as function arguments, instead of passing a >

[PATCH 3/4] [media] usbvision-core: Delete unnecessary braces in 11 functions

2017-09-21 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 21 Sep 2017 16:24:20 +0200 Do not use curly brackets at some source code places where a single statement should be sufficient. Signed-off-by: Markus Elfring ---

Re: [PATCH 03/25] media: dvbdev: convert DVB device types into an enum

2017-09-21 Thread Mauro Carvalho Chehab
Em Thu, 21 Sep 2017 09:06:54 -0400 Michael Ira Krufky escreveu: > On Wed, Sep 20, 2017 at 3:11 PM, Mauro Carvalho Chehab > wrote: > > +enum dvb_device_type { > > + DVB_DEVICE_SEC, > > + DVB_DEVICE_FRONTEND, > > +

Re: [PATCH 17/25] media: dvb_frontend: dtv_property_process_set() cleanups

2017-09-21 Thread Mauro Carvalho Chehab
Em Thu, 21 Sep 2017 08:32:25 -0600 Shuah Khan escreveu: > On 09/20/2017 01:11 PM, Mauro Carvalho Chehab wrote: > > From: Satendra Singh Thakur > > > > Since all properties in the func dtv_property_process_set() use > > at most 4 bytes arguments, change

[PATCH v3 2/2] media: rc: Add driver for tango HW IR decoder

2017-09-21 Thread Marc Gonzalez
From: Mans Rullgard The tango HW IR decoder supports NEC, RC-5, RC-6 protocols. Signed-off-by: Marc Gonzalez --- drivers/media/rc/Kconfig| 9 ++ drivers/media/rc/Makefile | 1 + drivers/media/rc/tango-ir.c | 265

[PATCH 1/4] [media] usbvision-core: Use common error handling code in usbvision_set_input()

2017-09-21 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 21 Sep 2017 11:50:54 +0200 * Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. * Replace the local variable "proc"

[PATCH 0/4] [media] usbvision-core: Fine-tuning for some function implementations

2017-09-21 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 21 Sep 2017 17:00:17 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (4): Use common error handling code in usbvision_set_input() Use common error handling code in

[PATCH 4/4] [media] usbvision-core: Replace four printk() calls by dev_err()

2017-09-21 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 21 Sep 2017 16:47:28 +0200 * Replace the local variable "proc" by the identifier "__func__". * Use the interface "dev_err" instead of "printk" in these functions. Signed-off-by: Markus Elfring ---

usb/media/smsusb: use-after-free in worker_thread

2017-09-21 Thread Andrey Konovalov
Hi! I've got the following report while fuzzing the kernel with syzkaller. On commit ebb2c2437d8008d46796902ff390653822af6cc4 (Sep 18). smsusb:smsusb_probe: board id=1, interface number 0 smsusb:siano_media_device_register: media controller created smsusb:smsusb1_detectmode: product string not

Re: [PATCH v3 2/2] media: rc: Add driver for tango HW IR decoder

2017-09-21 Thread Marc Gonzalez
On 21/09/2017 17:46, Måns Rullgård wrote: > Marc Gonzalez writes: > >> From: Mans Rullgard >> >> The tango HW IR decoder supports NEC, RC-5, RC-6 protocols. >> >> Signed-off-by: Marc Gonzalez > > Have you been able to test all the protocols?

Re: [PATCH 18/25] media: dvb_frontend: get rid of dtv_get_property_dump()

2017-09-21 Thread Shuah Khan
On 09/20/2017 01:11 PM, Mauro Carvalho Chehab wrote: > Simplify the get property handling and move it to the existing > code at dtv_property_process_get() directly. > > Signed-off-by: Mauro Carvalho Chehab > --- > drivers/media/dvb-core/dvb_frontend.c | 43 >

[PATCH v2 2/2] [media] imx: ask source subdevice for number of active data lanes

2017-09-21 Thread Philipp Zabel
Temporarily use g_mbus_config() to determine the number of active data lanes used by the transmitter. If g_mbus_config is not supported or does not return the number of active lines, default to using all connected data lines. Signed-off-by: Philipp Zabel --- New in v2: -

[PATCH v2 1/2] [media] tc358743: fix connected/active CSI-2 lane reporting

2017-09-21 Thread Philipp Zabel
g_mbus_config was supposed to indicate all supported lane numbers, not only the number of those currently in active use. Since the TC358743 can dynamically reduce the number of active lanes if the required bandwidth allows for it, report all lane numbers up to the connected number of lanes as

usb/media/hdpvr: trying to register non-static key in hdpvr_probe

2017-09-21 Thread Andrey Konovalov
Hi! I've got the following report while fuzzing the kernel with syzkaller. On commit ebb2c2437d8008d46796902ff390653822af6cc4 (Sep 18). INFO: trying to register non-static key. the code is fine but needs lockdep annotation. turning off the locking correctness validator. CPU: 0 PID: 24 Comm:

Re: [PATCH v3 2/2] media: rc: Add driver for tango HW IR decoder

2017-09-21 Thread Måns Rullgård
Marc Gonzalez writes: > From: Mans Rullgard > > The tango HW IR decoder supports NEC, RC-5, RC-6 protocols. > > Signed-off-by: Marc Gonzalez Have you been able to test all the protocols? Universal remotes usually

Re: [PATCH v3 2/2] media: rc: Add driver for tango HW IR decoder

2017-09-21 Thread Sean Young
On Thu, Sep 21, 2017 at 04:49:53PM +0200, Marc Gonzalez wrote: > From: Mans Rullgard > > The tango HW IR decoder supports NEC, RC-5, RC-6 protocols. > > Signed-off-by: Marc Gonzalez Missing signed-off-by. Your patch still gives numerous

Re: [PATCH 1/2] dt: bindings: media: Document port and endpoint numbering

2017-09-21 Thread Rob Herring
On Thu, Sep 21, 2017 at 4:25 AM, Sakari Ailus wrote: > Hi Rob, > > Thanks for the reply. > > On Wed, Sep 20, 2017 at 03:53:13PM -0500, Rob Herring wrote: >> On Mon, Sep 18, 2017 at 11:25:04AM +0300, Sakari Ailus wrote: >> > A lot of devices do not need and do not

Re: [PATCH v3 2/2] media: rc: Add driver for tango HW IR decoder

2017-09-21 Thread Marc Gonzalez
On 21/09/2017 17:57, Sean Young wrote: > On Thu, Sep 21, 2017 at 04:49:53PM +0200, Marc Gonzalez wrote: > >> The tango HW IR decoder supports NEC, RC-5, RC-6 protocols. >> >> Signed-off-by: Marc Gonzalez > > Missing signed-off-by. I am aware of that. Hopefully,

[PATCH] [media] tc358743: set entity function to video interface bridge

2017-09-21 Thread Philipp Zabel
The TC358743 is an HDMI to MIPI CSI2-2 bridge. Signed-off-by: Philipp Zabel --- drivers/media/i2c/tc358743.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c index b7285e45b908a..82927ef0cd913 100644 ---

[PATCH] [media] tc358743: validate lane count and order

2017-09-21 Thread Philipp Zabel
The TC358743 does not support reordering lanes, or more than 4 data lanes. Signed-off-by: Philipp Zabel --- drivers/media/i2c/tc358743.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c

[PATCH v3 1/2] media: dt: bindings: Add binding for tango HW IR decoder

2017-09-21 Thread Marc Gonzalez
Add DT binding for the HW IR decoder embedded in SMP86xx/SMP87xx. Signed-off-by: Marc Gonzalez --- .../devicetree/bindings/media/tango-ir.txt | 21 + 1 file changed, 21 insertions(+) create mode 100644

[PATCH 1/1] ov13858: Use do_div() for dividing a 64-bit number

2017-09-21 Thread Sakari Ailus
ov13858 contained a 64-bit division. Use do_div() for calculating it. Signed-off-by: Sakari Ailus --- drivers/media/i2c/ov13858.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov13858.c b/drivers/media/i2c/ov13858.c

[PATCH 2/4] [media] usbvision-core: Use common error handling code in usbvision_set_compress_params()

2017-09-21 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 21 Sep 2017 12:45:49 +0200 * Add a jump target so that a bit of exception handling can be better reused at the end of this function. * Replace the local variable "proc" by the identifier "__func__". * Use the interface "dev_err"

Re: [PATCH v1] media: rc: Add driver for tango IR decoder

2017-09-21 Thread Sean Young
On Tue, Sep 19, 2017 at 02:43:17PM +0200, Marc Gonzalez wrote: > + Rob & Mark for the DT bindings question. > > On 19/09/2017 14:21, Måns Rullgård wrote: > > > Marc Gonzalez writes: > > > >> On 18/09/2017 17:33, Måns Rullgård wrote: > >> > >>> What have you changed compared to my original code?

Re: [PATCH] tc358743: fix connected/active CSI-2 lane reporting

2017-09-21 Thread Philipp Zabel
Hi Ian, On Thu, 2017-09-21 at 12:06 +0100, Ian Arkver wrote: [...] > > My understanding of Hans' comment: > > "I'd also add a comment that all other flags must be 0 if the device  > > tree is used. This to avoid mixing the two." > > > > is that all the above should only happen if

Re: [PATCH v2] media: rc: Add driver for tango IR decoder

2017-09-21 Thread Marc Gonzalez
On 21/09/2017 13:25, Sean Young wrote: > On Wed, Sep 20, 2017 at 10:39:11AM +0200, Marc Gonzalez wrote: > >> From: Mans Rullgard >> >> The tango IR decoder supports NEC, RC-5, RC-6 protocols. >> >> Signed-off-by: Marc Gonzalez > > This needs a

Re: [PATCH] tc358743: fix connected/active CSI-2 lane reporting

2017-09-21 Thread Ian Arkver
Hi Philipp On 21/09/17 11:24, Philipp Zabel wrote: g_mbus_config was supposed to indicate all supported lane numbers, not only the number of those currently in active use. Since the tc358743 can dynamically reduce the number of active lanes if the required bandwidth allows for it, report all

Re: [PATCH v2] media: rc: Add driver for tango IR decoder

2017-09-21 Thread Sean Young
On Wed, Sep 20, 2017 at 10:39:11AM +0200, Marc Gonzalez wrote: > From: Mans Rullgard > > The tango IR decoder supports NEC, RC-5, RC-6 protocols. > > Signed-off-by: Marc Gonzalez This needs a signed-off-by from all the authors. > --- > Changes

Re: [PATCH] tc358743: fix connected/active CSI-2 lane reporting

2017-09-21 Thread Dave Stevenson
Hi Philipp On 21 September 2017 at 11:24, Philipp Zabel wrote: > g_mbus_config was supposed to indicate all supported lane numbers, not > only the number of those currently in active use. Since the tc358743 > can dynamically reduce the number of active lanes if the

Re: [PATCH v4] drm/bridge/sii8620: add remote control support

2017-09-21 Thread Sean Young
On Mon, Sep 18, 2017 at 04:37:52PM +0200, Hans Verkuil wrote: > On 09/18/2017 04:15 PM, Maciej Purski wrote: > > Hi Hans, > > some time ago in reply to your email I described what messages does > > the MHL driver receive and at what time intervals. > > Regarding that information, do you think that

Re: [linux-sunxi] [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

2017-09-21 Thread Ondřej Jirman
Hello Yong, I noticed one issue in the register macros. See below. Yong Deng píše v Čt 27. 07. 2017 v 13:01 +0800: > Allwinner V3s SoC have two CSI module. CSI0 is used for MIPI interface > and CSI1 is used for parallel interface. This is not documented in > datasheet but by testing and guess. >

Re: [PATCH] dma-fence: fix dma_fence_get_rcu_safe v2

2017-09-21 Thread Maarten Lankhorst
Op 15-09-17 om 11:53 schreef Christian König: > From: Christian König > > When dma_fence_get_rcu() fails to acquire a reference it doesn't necessary > mean that there is no fence at all. > > It usually mean that the fence was replaced by a new one and in this situation >

Re: [PATCH] dma-fence: fix dma_fence_get_rcu_safe

2017-09-21 Thread Maarten Lankhorst
Op 21-09-17 om 09:00 schreef Christian König: > Am 20.09.2017 um 20:20 schrieb Daniel Vetter: >> On Mon, Sep 11, 2017 at 01:06:32PM +0200, Christian König wrote: >>> Am 11.09.2017 um 12:01 schrieb Chris Wilson: [SNIP] > Yeah, but that is illegal with a fence objects. > > When

Re: [PATCH 2/3] [media] tc358743: Increase FIFO level to 300.

2017-09-21 Thread Sakari Ailus
Hi Hans, On Wed, Sep 20, 2017 at 03:12:03PM +0200, Hans Verkuil wrote: > On 09/20/17 14:50, Sakari Ailus wrote: > > Hi Hans and others, > > > > On Wed, Sep 20, 2017 at 01:24:02PM +0200, Hans Verkuil wrote: > >> On 09/20/17 13:00, Dave Stevenson wrote: > >>> On 20 September 2017 at 11:23, Philipp

Re: [PATCH] dma-fence: fix dma_fence_get_rcu_safe

2017-09-21 Thread Christian König
Am 20.09.2017 um 20:20 schrieb Daniel Vetter: On Mon, Sep 11, 2017 at 01:06:32PM +0200, Christian König wrote: Am 11.09.2017 um 12:01 schrieb Chris Wilson: [SNIP] Yeah, but that is illegal with a fence objects. When anybody allocates fences this way it breaks at least

Re: [PATCH v3 2/2] media: rc: Add driver for tango HW IR decoder

2017-09-21 Thread Sean Young
On Thu, Sep 21, 2017 at 06:20:28PM +0200, Marc Gonzalez wrote: > On 21/09/2017 17:57, Sean Young wrote: > > > On Thu, Sep 21, 2017 at 04:49:53PM +0200, Marc Gonzalez wrote: > > > >> The tango HW IR decoder supports NEC, RC-5, RC-6 protocols. > >> > >> Signed-off-by: Marc Gonzalez

Re: [PATCH v3 2/2] media: rc: Add driver for tango HW IR decoder

2017-09-21 Thread Måns Rullgård
Marc Gonzalez writes: > On 21/09/2017 17:57, Sean Young wrote: > >> On Thu, Sep 21, 2017 at 04:49:53PM +0200, Marc Gonzalez wrote: >> >>> The tango HW IR decoder supports NEC, RC-5, RC-6 protocols. >>> >>> Signed-off-by: Marc Gonzalez

cron job: media_tree daily build: WARNINGS

2017-09-21 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri Sep 22 05:00:16 CEST 2017 media-tree git hash:1efdf1776e2253b77413c997bed862410e4b6aaf media_build

[PATCH 0/3] [media] uvcvideo: Fine-tuning for some function implementations

2017-09-21 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 21 Sep 2017 21:20:12 +0200 Three update suggestions were taken into account from static source code analysis. Markus Elfring (3): Use common error handling code in uvc_ioctl_g_ext_ctrls() Adjust 14 checks for null pointers Add

[PATCH 1/3] [media] uvcvideo: Use common error handling code in uvc_ioctl_g_ext_ctrls()

2017-09-21 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 21 Sep 2017 20:47:02 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH 2/3] [media] uvcvideo: Adjust 14 checks for null pointers

2017-09-21 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 21 Sep 2017 21:00:21 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written … Thus

[PATCH 3/3] [media] uvcvideo: Add some spaces for better code readability

2017-09-21 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 21 Sep 2017 21:12:29 +0200 Use space characters at some source code places according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/media/usb/uvc/uvc_v4l2.c | 13

Re: [PATCH] ov9655: fix potential integer overflow

2017-09-21 Thread kbuild test robot
Hi Gustavo, [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.14-rc1 next-20170921] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Gustavo-A-R-Silva/ov9655-fix

Re: [PATCH v3 2/2] media: rc: Add driver for tango HW IR decoder

2017-09-21 Thread Måns Rullgård
Marc Gonzalez writes: > On 21/09/2017 17:46, Måns Rullgård wrote: > >> Marc Gonzalez writes: >> >>> From: Mans Rullgard >>> >>> The tango HW IR decoder supports NEC, RC-5, RC-6 protocols. >>> >>> Signed-off-by: Marc Gonzalez

Re: [PATCH 1/3] [media] tc358743: Correct clock mode reported in g_mbus_config

2017-09-21 Thread Philipp Zabel
On Tue, 2017-09-19 at 14:08 +0100, Dave Stevenson wrote: > Support for non-continuous clock had previously been added via > device tree, but a comment and the value reported by g_mbus_config > still stated that it wasn't supported. > Remove the comment, and return the correct value in

Re: [media] s2255drv: Adjust 13 checks for null pointers

2017-09-21 Thread Dan Carpenter
On Thu, Sep 21, 2017 at 10:12:56AM +0200, SF Markus Elfring wrote: > >> MIME-Version: 1.0 > >> Content-Type: text/plain; charset=UTF-8 > >> Content-Transfer-Encoding: 8bit > >> > > > > You've been told several times that this stuff doesn't work. > > This functionality might not exactly work in

Re: [PATCH 1/2] dt: bindings: media: Document port and endpoint numbering

2017-09-21 Thread Sakari Ailus
Hi Rob, Thanks for the reply. On Wed, Sep 20, 2017 at 03:53:13PM -0500, Rob Herring wrote: > On Mon, Sep 18, 2017 at 11:25:04AM +0300, Sakari Ailus wrote: > > A lot of devices do not need and do not document port or endpoint > > numbering at all, e.g. in case where there's just a single port and

Re: [RESEND RFC PATCH 0/7] sun8i H3 HDMI glue driver for DW HDMI

2017-09-21 Thread Jose Abreu
Hi Jernej, On 20-09-2017 21:01, Jernej Skrabec wrote: > [added media mailing list due to CEC question] > > This patch series adds a HDMI glue driver for Allwinner H3 SoC. For now, only > video and CEC functionality is supported. Audio needs more tweaks. > > Series is based on the H3 DE2 patch

Re: [PATCH 2/3] [media] tc358743: Increase FIFO level to 300.

2017-09-21 Thread Philipp Zabel
Hi Hans, On Wed, 2017-09-20 at 15:12 +0200, Hans Verkuil wrote: [...] > I don't like it :-) > > Currently g_mbus_config returns (and I quote from v4l2-mediabus.h): "How > many lanes the client can use". I.e. the capabilities of the HW. > > If we are going to use this to communicate how many

Hauppauge Nova-TD Stick fails on f26

2017-09-21 Thread Eyal Lebedinsky
I have an unusual problem with this tuner. On my workstation (f26) it works fine and I can watch TV using vlc or tune with tzap. On my mythtv server (which was recently upgraded to f26) the card does not work. An adapter is not created in /dev/dvb. The server has a few other tuners and it may

Re: [media] s2255drv: Adjust 13 checks for null pointers

2017-09-21 Thread SF Markus Elfring
>> MIME-Version: 1.0 >> Content-Type: text/plain; charset=UTF-8 >> Content-Transfer-Encoding: 8bit >> > > You've been told several times that this stuff doesn't work. This functionality might not exactly work in the way that you expect so far. > Try applying this patch with `git am` and you'll

Re: usb/media/cx231xx: null-ptr-deref in cx231xx_usb_probe

2017-09-21 Thread Johan Hovold
On Wed, Sep 20, 2017 at 08:54:08PM +0200, Andrey Konovalov wrote: > Hi! > > I've got the following report while fuzzing the kernel with syzkaller. > > On commit ebb2c2437d8008d46796902ff390653822af6cc4 (Sep 18). > > The null-ptr-deref happens on assoc_desc->bFirstInterface, where > assoc_desc =

[PATCH] [media] cx231xx-cards: fix NULL-deref on missing association descriptor

2017-09-21 Thread Johan Hovold
Make sure to check that we actually have an Interface Association Descriptor before dereferencing it during probe to avoid dereferencing a NULL-pointer. Fixes: e0d3bafd0258 ("V4L/DVB (10954): Add cx231xx USB driver") Cc: stable # 2.6.30 Cc: Sri Deevi

Re: [PATCH v13 06/25] omap3isp: Use generic parser for parsing fwnode endpoints

2017-09-21 Thread Sakari Ailus
Hi Laurent, On Tue, Sep 19, 2017 at 07:12:14PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > On Tuesday, 19 September 2017 17:47:22 EEST Sakari Ailus wrote: > > On Tue, Sep 19, 2017 at 03:46:18PM +0300, Laurent Pinchart wrote: > > > On Tuesday, 19 September 2017 15:43:26 EEST Sakari Ailus

Re: [RESEND RFC PATCH 0/7] sun8i H3 HDMI glue driver for DW HDMI

2017-09-21 Thread Hans Verkuil
On 09/21/17 11:39, Jose Abreu wrote: > Hi Jernej, > > On 20-09-2017 21:01, Jernej Skrabec wrote: >> [added media mailing list due to CEC question] >> >> This patch series adds a HDMI glue driver for Allwinner H3 SoC. For now, only >> video and CEC functionality is supported. Audio needs more

[PATCH] tc358743: fix connected/active CSI-2 lane reporting

2017-09-21 Thread Philipp Zabel
g_mbus_config was supposed to indicate all supported lane numbers, not only the number of those currently in active use. Since the tc358743 can dynamically reduce the number of active lanes if the required bandwidth allows for it, report all lane numbers up to the connected number of lanes as