Hi Arnd,
Thank you for the patch.
On Tuesday, 16 January 2018 18:47:24 EET Arnd Bergmann wrote:
> While experimenting with older compiler versions, I ran
> into a warning that no longer shows up on gcc-4.8 or newer:
>
> drivers/media/platform/s3c-camif/camif-capture.c: In function
>
On 2018-01-16 14:38, Antti Palosaari wrote:
> On 01/16/2018 10:14 PM, Brad Love wrote:
>>
>> On 2018-01-16 13:32, Antti Palosaari wrote:
>>> On 01/16/2018 07:31 PM, Brad Love wrote:
On 2018-01-15 23:07, Antti Palosaari wrote:
> Hello
> And what is rationale here, is there some
Hi Kieran,
Thank you for the patch.
On Friday, 12 January 2018 11:19:26 EET Kieran Bingham wrote:
> The buffer queue interface currently operates sequentially, processing
> buffers after they have fully completed.
>
> In preparation for supporting parallel tasks operating on the buffers,
> we
The extern keyword isn't needed to declare functions in header files.
Drop it.
Signed-off-by: Laurent Pinchart
---
drivers/media/usb/uvc/uvcvideo.h | 145 +++
1 file changed, 71 insertions(+), 74 deletions(-)
diff --git
While the sizeof is an operator and not a function, the preferred coding
style in the kernel is to enclose its operand in parentheses. To avoid
mixing multiple coding styles in the driver, use parentheses around all
sizeof operands.
While at it replace a kmalloc() with a kmalloc_array() to
Hello,
I was growing tired of explaining during review that, while the uvcvideo.h
header used the extern keyword in front of function declarations, the same
style mistake didn't have to be copied in all patches. I thus decided to write
patch 1/4, and while at it I fixed similar style issues in
Add driver for Renesas Capture Engine Unit (CEU).
The CEU interface supports capturing 'data' (YUV422) and 'images'
(NV[12|21|16|61]).
This driver aims to replace the soc_camera-based sh_mobile_ceu one.
Tested with ov7670 camera sensor, providing YUYV_2X8 data on Renesas RZ
platform GR-Peach.
On Tue, Jan 16, 2018 at 9:17 PM, Laurent Pinchart
wrote:
> Hi Arnd,
>
> Thank you for the patch.
>
> On Tuesday, 16 January 2018 18:47:24 EET Arnd Bergmann wrote:
>> While experimenting with older compiler versions, I ran
>> into a warning that no longer shows
Remove soc_camera framework dependencies from ov772x sensor driver.
- Handle clock and gpios
- Register async subdevice
- Remove soc_camera specific g/s_mbus_config operations
- Change image format colorspace from JPEG to SRGB as the two use the
same colorspace information but JPEG makes
Add renesas-ceu header file.
Do not remove the existing sh_mobile_ceu.h one as long as the original
driver does not go away.
Signed-off-by: Jacopo Mondi
Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
Add bindings documentation for Renesas Capture Engine Unit (CEU).
Signed-off-by: Jacopo Mondi
Reviewed-by: Rob Herring
Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
---
Replace the __[su]{8,16,32} variant of integer types with the
non-underscored types as the code is internal to the driver, not exposed
to userspace.
Signed-off-by: Laurent Pinchart
---
drivers/media/usb/uvc/uvc_ctrl.c | 56 ++--
Replace the uint_{8,16,32} types with the corresponding native kernel
types u{8,16,32}.
Signed-off-by: Laurent Pinchart
---
drivers/media/usb/uvc/uvc_driver.c | 16
drivers/media/usb/uvc/uvc_v4l2.c | 2 +-
drivers/media/usb/uvc/uvcvideo.h
While experimenting with older compiler versions, I ran
into a warning that no longer shows up on gcc-4.8 or newer:
drivers/media/platform/s3c-camif/camif-capture.c: In function
'__camif_subdev_try_format':
drivers/media/platform/s3c-camif/camif-capture.c:1265:25: error: array
subscript is
Migo-R platform uses sh_mobile_ceu camera driver, which is now being
replaced by a proper V4L2 camera driver named 'renesas-ceu'.
Move Migo-R platform to use the v4l2 renesas-ceu camera driver
interface and get rid of soc_camera defined components used to register
sensor drivers and of platform
On Tue, Jan 16, 2018 at 10:52:15PM +0100, Arnd Bergmann wrote:
> While experimenting with older compiler versions, I ran
> into a warning that no longer shows up on gcc-4.8 or newer:
>
> drivers/media/platform/s3c-camif/camif-capture.c: In function
> '__camif_subdev_try_format':
>
Hi Kieran,
Thank you for the patch.
On Friday, 12 January 2018 11:19:27 EET Kieran Bingham wrote:
> Newer high definition cameras, and cameras with multiple lenses such as
> the range of stereo-vision cameras now available have ever increasing
> data rates.
>
> The inclusion of a variable
On 2018-01-15 23:05, Antti Palosaari wrote:
> Hello
> So the use case is to share single tuner with multiple demodulators?
> Why don't just register single tuner and pass that info to multiple
> demods?
>
> Antti
Hello Antti,
It was done this way because of lack of knowledge of other ways. The
Remove soc_camera framework dependencies from tw9910 sensor driver.
- Handle clock and gpios
- Register async subdevice
- Remove soc_camera specific g/s_mbus_config operations
- Add kernel doc to driver interface header file
- Adjust build system
This commit does not remove the original
Copy the soc_camera based driver in v4l2 sensor driver directory.
This commit just copies the original file without modifying it.
No modification to KConfig and Makefile as soc_camera framework
dependencies need to be removed first in next commit.
Signed-off-by: Jacopo Mondi
Copy the soc_camera based driver in v4l2 sensor driver directory.
This commit just copies the original file without modifying it.
No modification to KConfig and Makefile as soc_camera framework
dependencies need to be removed first in next commit.
Signed-off-by: Jacopo Mondi
Add Capture Engine Unit (CEU) node to device tree.
Signed-off-by: Jacopo Mondi
Reviewed-by: Geert Uytterhoeven
Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
---
Hi Arnd,
Thank you for the patch.
On Tuesday, 16 January 2018 23:52:15 EET Arnd Bergmann wrote:
> While experimenting with older compiler versions, I ran
> into a warning that no longer shows up on gcc-4.8 or newer:
>
> drivers/media/platform/s3c-camif/camif-capture.c: In function
>
Hello,
new version of CEU after Hans' review.
Added his Acked-by to most patches and closed review comments.
Running v4l2-compliance, I noticed a new failure introduced by the way I now
calculate the plane sizes in set/try_fmt.
This is the function used to update per-plane bytesperline and
From: Kieran Bingham
It can be easy to attempt to register the same notifier twice
in mis-handled error cases such as working with -EPROBE_DEFER.
This results in odd kernel crashes where the notifier_list becomes
corrupted due to adding the same entry
Hi Wolfgang,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: fdddade65d7b5f8779374eb73d09889185280f60
commit: 6cdeaed3b1420bd2569891be0c4123ff59628e9e [3773/9944] media:
dvb_usb_pctv452e: module refcount changes
Dear Friend,
I came across your e-mail contact prior a private search while in need
of your assistance. My name is Aisha Gaddafi a single Mother and a
Widow with three Children. I am the only biological Daughter of late
Libyan President (Late Colonel Muammar Gaddafi).
I have an investment funds
Szanowni Państwo,
Nazywamy się Karina i Jakub Bieckowie. Jesteśmy młodym małżeństwem oraz
rodzicami cudownych bliźniaczek – Zuzi i Zosi. Dziewczynki w grudniu skończyły
roczek. To niewątpliwie piękny czas, choć w naszym przypadku
zakłócił go wielki niepokój.
O ile Zuzia jest zdrowym szkrabem,
Hi Hans,
On Tuesday, 16 January 2018 11:46:42 EET Hans Verkuil wrote:
> Hi Jacopo,
>
> Sorry for the late review, but here is finally is.
>
> BTW, can you provide the v4l2-compliance output (ideally with the -f option)
> in the cover letter for v6?
>
> On 01/12/2018 03:04 PM, Jacopo Mondi
On 01/12/2018 03:04 PM, Jacopo Mondi wrote:
> Copy the soc_camera based driver in v4l2 sensor driver directory.
> This commit just copies the original file without modifying it.
> No modification to KConfig and Makefile as soc_camera framework
> dependencies need to be removed first in next
On 01/12/2018 03:04 PM, Jacopo Mondi wrote:
> Add renesas-ceu header file.
>
> Do not remove the existing sh_mobile_ceu.h one as long as the original
> driver does not go away.
>
> Signed-off-by: Jacopo Mondi
> Reviewed-by: Laurent Pinchart
From: Hans Verkuil
This driver is unused and depends on the deprecated soc-camera framework.
Move it to staging in preparation for being removed unless someone does
the work to convert it to a proper V4L2 subdev driver.
Signed-off-by: Hans Verkuil
From: Hans Verkuil
These two sensor drivers in drivers/media/i2c/soc_camera are not
used anymore. Move them to staging in preparation of being deleted
once the soc_camera framework is removed. Unless someone steps up
to do the conversion to a proper V4L2 subdev driver.
On 01/12/2018 03:04 PM, Jacopo Mondi wrote:
> Migo-R platform uses sh_mobile_ceu camera driver, which is now being
> replaced by a proper V4L2 camera driver named 'renesas-ceu'.
>
> Move Migo-R platform to use the v4l2 renesas-ceu camera driver
> interface and get rid of soc_camera defined
On 01/12/2018 03:04 PM, Jacopo Mondi wrote:
> Remove soc_camera framework dependencies from tw9910 sensor driver.
> - Handle clock and gpios
> - Register async subdevice
> - Remove soc_camera specific g/s_mbus_config operations
> - Add kernel doc to driver interface header file
> - Adjust build
From: Hans Verkuil
This driver is unused and depends on the deprecated soc-camera framework.
Move it to staging in preparation for being removed unless someone does
the work to convert it to a proper V4L2 subdev driver.
Signed-off-by: Hans Verkuil
This patch adds driver for Omnivision's ov5695 sensor,
the driver supports following features:
- supported resolutions
+ 2592x1944 at 30fps
+ 1920x1080 at 30fps
+ 1296x972 at 60fps
+ 1280x720 at 30fps
+ 640x480 at 120fps
- test patterns
- manual exposure/gain(analog and digital)
This patch adds driver for Omnivision's ov2685 sensor.
Though the ov2685 can output yuv data, this driver only
supports the raw bayer format, including the following features:
- output 1600x1200 at 30fps
- test patterns
- manual exposure/gain control
- vblank and hblank
- media
Add device tree binding documentation for the OV2685 sensor.
Signed-off-by: Shunqian Zheng
Reviewed-by: Jacopo Mondi
---
.../devicetree/bindings/media/i2c/ov2685.txt | 41 ++
1 file changed, 41 insertions(+)
create
On 01/12/2018 03:04 PM, Jacopo Mondi wrote:
> Add bindings documentation for Renesas Capture Engine Unit (CEU).
>
> Signed-off-by: Jacopo Mondi
> Reviewed-by: Rob Herring
> Reviewed-by: Laurent Pinchart
Acked-by:
On 01/12/2018 03:04 PM, Jacopo Mondi wrote:
> Add Capture Engine Unit (CEU) node to device tree.
>
> Signed-off-by: Jacopo Mondi
> Reviewed-by: Geert Uytterhoeven
> Reviewed-by: Laurent Pinchart
Acked-by:
Ping? Daniel you requested the patch with its user.
Would be nice when I can commit this cause we need it for debugging and
cleaning up a bunch of other things as well.
Regards,
Christian.
Am 12.01.2018 um 10:47 schrieb Christian König:
Change reservation_object_get_fences_rcu to make the
On 01/16/2018 10:39 AM, Alexandre Courbot wrote:
> On Mon, Jan 15, 2018 at 6:07 PM, Hans Verkuil wrote:
>> On 01/15/2018 09:24 AM, Alexandre Courbot wrote:
>>> On Fri, Jan 12, 2018 at 7:49 PM, Hans Verkuil wrote:
On 12/15/17 08:56, Alexandre Courbot
Hi Jacopo,
Sorry for the late review, but here is finally is.
BTW, can you provide the v4l2-compliance output (ideally with the -f option)
in the cover letter for v6?
On 01/12/2018 03:04 PM, Jacopo Mondi wrote:
> Add driver for Renesas Capture Engine Unit (CEU).
>
> The CEU interface supports
Hello everyone,
Here's the Prague Media summit report from 26th and 27th October 2017. It
took long but finally it's here!
If you feel something important is missing or incorrect, feel free to
reply.
First day
*
The first day was mostly concentrated on discussing the media development
This adds the OV2685 and OV5695 sensor supports.
Changes of v6 are mainly addressing comments from Jacopo@
- Fix the node/lable name inverted in Doc.
- Guard the source code with IS_ENABLED(CONFIG_OF)
- Move the __v4l2_ctrl_handler_setup() into ov2685_s_stream()
Changes of v5,
- Squash the
Add device tree binding documentation for the OV5695 sensor.
Signed-off-by: Shunqian Zheng
Reviewed-by: Jacopo Mondi
---
.../devicetree/bindings/media/i2c/ov5695.txt | 41 ++
1 file changed, 41 insertions(+)
create
On Mon, Jan 15, 2018 at 6:07 PM, Hans Verkuil wrote:
> On 01/15/2018 09:24 AM, Alexandre Courbot wrote:
>> On Fri, Jan 12, 2018 at 7:49 PM, Hans Verkuil wrote:
>>> On 12/15/17 08:56, Alexandre Courbot wrote:
Add throttling support for buffers when
On Mon, Jan 15, 2018 at 6:19 PM, Hans Verkuil wrote:
> On 01/15/2018 09:24 AM, Alexandre Courbot wrote:
>> On Fri, Jan 12, 2018 at 8:37 PM, Hans Verkuil wrote:
>>> On 12/15/17 08:56, Alexandre Courbot wrote:
Support the request argument of the QBUF
On 01/12/2018 03:04 PM, Jacopo Mondi wrote:
> Copy the soc_camera based driver in v4l2 sensor driver directory.
> This commit just copies the original file without modifying it.
> No modification to KConfig and Makefile as soc_camera framework
> dependencies need to be removed first in next
On 01/12/2018 03:04 PM, Jacopo Mondi wrote:
> Remove soc_camera framework dependencies from ov772x sensor driver.
> - Handle clock and gpios
> - Register async subdevice
> - Remove soc_camera specific g/s_mbus_config operations
> - Change image format colorspace from JPEG to SRGB as the two use
On Tue, Jan 16, 2018 at 12:02:43PM +0100, Hans Verkuil wrote:
> From: Hans Verkuil
>
> These two sensor drivers in drivers/media/i2c/soc_camera are not
> used anymore. Move them to staging in preparation of being deleted
> once the soc_camera framework is removed. Unless
Hi Hans,
On Tuesday, 16 January 2018 12:08:17 EET Hans Verkuil wrote:
> On 01/12/2018 03:04 PM, Jacopo Mondi wrote:
> > Remove soc_camera framework dependencies from ov772x sensor driver.
> > - Handle clock and gpios
> > - Register async subdevice
> > - Remove soc_camera specific g/s_mbus_config
On Tue, Jan 16, 2018 at 4:44 PM, Sakari Ailus
wrote:
>> if (camif_mbus_formats[i] == mf->code)
>> break;
>>
>> + if (i == ARRAY_SIZE(camif_mbus_formats))
>> + mf->code = camif_mbus_formats[0];
>> +
>
> Either else
While experimenting with older compiler versions, I ran
into a warning that no longer shows up on gcc-4.8 or newer:
drivers/media/platform/s3c-camif/camif-capture.c: In function
'__camif_subdev_try_format':
drivers/media/platform/s3c-camif/camif-capture.c:1265:25: error: array
subscript is
On Tue, Jan 16, 2018 at 05:47:24PM +0100, Arnd Bergmann wrote:
> While experimenting with older compiler versions, I ran
> into a warning that no longer shows up on gcc-4.8 or newer:
>
> drivers/media/platform/s3c-camif/camif-capture.c: In function
> '__camif_subdev_try_format':
>
On Tue, Dec 5, 2017 at 1:41 AM, Laurent Pinchart
wrote:
> Hi Arnd,
>
> Thank you for the patch.
>
> I'll try to review this without too much delay. In the meantime, I'm CC'ing
> Sakari Ailus who might be faster than me :-)
Hi Laurent and Sakari,
I stumbled
Hi Hans,
On Tue, Jan 16, 2018 at 10:46:42AM +0100, Hans Verkuil wrote:
> Hi Jacopo,
>
> Sorry for the late review, but here is finally is.
>
> BTW, can you provide the v4l2-compliance output (ideally with the -f option)
> in the cover letter for v6?
Sure, it was attacched to v3 I guess, since
From: Kieran Bingham
It can be easy to attempt to register the same notifier twice
in mis-handled error cases such as working with -EPROBE_DEFER.
This results in odd kernel crashes where the notifier_list becomes
corrupted due to adding the same entry
Hi Phillip
On 15/01/18 19:35, Philipp Zabel wrote:
> Hi Kieran,
>
> On Fri, Jan 12, 2018 at 10:19 AM, Kieran Bingham
> wrote:
>> This series has been tested on both the ZED and BRIO cameras on arm64
>> platforms, however due to the intrinsic changes in the
Hi Kieran,
On Tue, Jan 16, 2018 at 02:52:58PM +, Kieran Bingham wrote:
> From: Kieran Bingham
>
> It can be easy to attempt to register the same notifier twice
> in mis-handled error cases such as working with -EPROBE_DEFER.
>
> This results in odd
Hi Kieran,
Thank you for the patch.
On Friday, 12 January 2018 11:19:26 EET Kieran Bingham wrote:
> Both uvc_start_streaming(), and uvc_stop_streaming() are called from
> userspace context. As such, they do not need to save the IRQ state, and
> can use spin_lock_irq() and spin_unlock_irq()
On 2018-01-15 23:07, Antti Palosaari wrote:
> Hello
> And what is rationale here, is there some use case demod must be
> active and ts set to tristate (disabled)? Just put demod sleep when
> you don't use it.
>
> regards
> Antti
Hello Antti,
Perhaps the .ts_bus_ctrl callback does not need to be
Hi Arnd,
Thanks for the patch. Please see my comments below.
On Tue, Jan 16, 2018 at 04:30:46PM +0100, Arnd Bergmann wrote:
> While experimenting with older compiler versions, I ran
> into a warning that no longer shows up on gcc-4.8 or newer:
>
>
While experimenting with older compiler versions, I ran
into a warning that no longer shows up on gcc-4.8 or newer:
drivers/media/platform/s3c-camif/camif-capture.c: In function
'__camif_subdev_try_format':
drivers/media/platform/s3c-camif/camif-capture.c:1265:25: error: array
subscript is
On 01/16/2018 10:14 PM, Brad Love wrote:
On 2018-01-16 13:32, Antti Palosaari wrote:
On 01/16/2018 07:31 PM, Brad Love wrote:
On 2018-01-15 23:07, Antti Palosaari wrote:
Hello
And what is rationale here, is there some use case demod must be
active and ts set to tristate (disabled)? Just put
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Wed Jan 17 05:00:17 CET 2018
media-tree git hash:e3ee691dbf24096ea51b3200946b11d68ce75361
media_build
Hi Hans,
On Tue, Jan 16, 2018 at 11:08:17AM +0100, Hans Verkuil wrote:
> On 01/12/2018 03:04 PM, Jacopo Mondi wrote:
> > Remove soc_camera framework dependencies from ov772x sensor driver.
> > - Handle clock and gpios
> > - Register async subdevice
> > - Remove soc_camera specific g/s_mbus_config
On 01/16/2018 07:31 PM, Brad Love wrote:
On 2018-01-15 23:07, Antti Palosaari wrote:
Hello
And what is rationale here, is there some use case demod must be
active and ts set to tristate (disabled)? Just put demod sleep when
you don't use it.
regards
Antti
Hello Antti,
Perhaps the
On Sat, Jan 13, 2018 at 10:51 AM, Linus Torvalds
wrote:
> On Fri, Jan 12, 2018 at 4:15 PM, Tony Luck wrote:
> So your argument depends on "the uarch will actually run the code in
> order if there are no events that block the pipeline".
And
Hi Sakari,
Thanks for the quick review.
On 16/01/18 15:23, Sakari Ailus wrote:
> Hi Kieran,
>
> On Tue, Jan 16, 2018 at 02:52:58PM +, Kieran Bingham wrote:
>> From: Kieran Bingham
>>
>> It can be easy to attempt to register the same notifier twice
On 2018-01-16 13:32, Antti Palosaari wrote:
> On 01/16/2018 07:31 PM, Brad Love wrote:
>>
>> On 2018-01-15 23:07, Antti Palosaari wrote:
>>> Hello
>>> And what is rationale here, is there some use case demod must be
>>> active and ts set to tristate (disabled)? Just put demod sleep when
>>> you
72 matches
Mail list logo