Re: [PATCH] [v3] media: s3c-camif: fix out-of-bounds array access

2018-01-16 Thread Laurent Pinchart
Hi Arnd, Thank you for the patch. On Tuesday, 16 January 2018 18:47:24 EET Arnd Bergmann wrote: > While experimenting with older compiler versions, I ran > into a warning that no longer shows up on gcc-4.8 or newer: > > drivers/media/platform/s3c-camif/camif-capture.c: In function >

Re: [PATCH 4/7] si2168: Add ts bus coontrol, turn off bus on sleep

2018-01-16 Thread Brad Love
On 2018-01-16 14:38, Antti Palosaari wrote: > On 01/16/2018 10:14 PM, Brad Love wrote: >> >> On 2018-01-16 13:32, Antti Palosaari wrote: >>> On 01/16/2018 07:31 PM, Brad Love wrote: On 2018-01-15 23:07, Antti Palosaari wrote: > Hello > And what is rationale here, is there some

Re: [RFT PATCH v3 5/6] uvcvideo: queue: Support asynchronous buffer handling

2018-01-16 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Friday, 12 January 2018 11:19:26 EET Kieran Bingham wrote: > The buffer queue interface currently operates sequentially, processing > buffers after they have fully completed. > > In preparation for supporting parallel tasks operating on the buffers, > we

[PATCH 1/4] uvcvideo: Drop extern keyword in function declarations

2018-01-16 Thread Laurent Pinchart
The extern keyword isn't needed to declare functions in header files. Drop it. Signed-off-by: Laurent Pinchart --- drivers/media/usb/uvc/uvcvideo.h | 145 +++ 1 file changed, 71 insertions(+), 74 deletions(-) diff --git

[PATCH 4/4] uvcvideo: Use parentheses around sizeof operand

2018-01-16 Thread Laurent Pinchart
While the sizeof is an operator and not a function, the preferred coding style in the kernel is to enclose its operand in parentheses. To avoid mixing multiple coding styles in the driver, use parentheses around all sizeof operands. While at it replace a kmalloc() with a kmalloc_array() to

[PATCH 0/4] uvcvideo style cleanups

2018-01-16 Thread Laurent Pinchart
Hello, I was growing tired of explaining during review that, while the uvcvideo.h header used the extern keyword in front of function declarations, the same style mistake didn't have to be copied in all patches. I thus decided to write patch 1/4, and while at it I fixed similar style issues in

[PATCH v6 3/9] v4l: platform: Add Renesas CEU driver

2018-01-16 Thread Jacopo Mondi
Add driver for Renesas Capture Engine Unit (CEU). The CEU interface supports capturing 'data' (YUV422) and 'images' (NV[12|21|16|61]). This driver aims to replace the soc_camera-based sh_mobile_ceu one. Tested with ov7670 camera sensor, providing YUYV_2X8 data on Renesas RZ platform GR-Peach.

Re: [PATCH] [v3] media: s3c-camif: fix out-of-bounds array access

2018-01-16 Thread Arnd Bergmann
On Tue, Jan 16, 2018 at 9:17 PM, Laurent Pinchart wrote: > Hi Arnd, > > Thank you for the patch. > > On Tuesday, 16 January 2018 18:47:24 EET Arnd Bergmann wrote: >> While experimenting with older compiler versions, I ran >> into a warning that no longer shows

[PATCH v6 6/9] media: i2c: ov772x: Remove soc_camera dependencies

2018-01-16 Thread Jacopo Mondi
Remove soc_camera framework dependencies from ov772x sensor driver. - Handle clock and gpios - Register async subdevice - Remove soc_camera specific g/s_mbus_config operations - Change image format colorspace from JPEG to SRGB as the two use the same colorspace information but JPEG makes

[PATCH v6 2/9] include: media: Add Renesas CEU driver interface

2018-01-16 Thread Jacopo Mondi
Add renesas-ceu header file. Do not remove the existing sh_mobile_ceu.h one as long as the original driver does not go away. Signed-off-by: Jacopo Mondi Reviewed-by: Laurent Pinchart Acked-by: Hans Verkuil

[PATCH v6 1/9] dt-bindings: media: Add Renesas CEU bindings

2018-01-16 Thread Jacopo Mondi
Add bindings documentation for Renesas Capture Engine Unit (CEU). Signed-off-by: Jacopo Mondi Reviewed-by: Rob Herring Reviewed-by: Laurent Pinchart Acked-by: Hans Verkuil ---

[PATCH 3/4] uvcvideo: Use internal kernel integer types

2018-01-16 Thread Laurent Pinchart
Replace the __[su]{8,16,32} variant of integer types with the non-underscored types as the code is internal to the driver, not exposed to userspace. Signed-off-by: Laurent Pinchart --- drivers/media/usb/uvc/uvc_ctrl.c | 56 ++--

[PATCH 2/4] uvcvideo: Use kernel integer types

2018-01-16 Thread Laurent Pinchart
Replace the uint_{8,16,32} types with the corresponding native kernel types u{8,16,32}. Signed-off-by: Laurent Pinchart --- drivers/media/usb/uvc/uvc_driver.c | 16 drivers/media/usb/uvc/uvc_v4l2.c | 2 +- drivers/media/usb/uvc/uvcvideo.h

[PATCH] [v4] media: s3c-camif: fix out-of-bounds array access

2018-01-16 Thread Arnd Bergmann
While experimenting with older compiler versions, I ran into a warning that no longer shows up on gcc-4.8 or newer: drivers/media/platform/s3c-camif/camif-capture.c: In function '__camif_subdev_try_format': drivers/media/platform/s3c-camif/camif-capture.c:1265:25: error: array subscript is

[PATCH v6 9/9] arch: sh: migor: Use new renesas-ceu camera driver

2018-01-16 Thread Jacopo Mondi
Migo-R platform uses sh_mobile_ceu camera driver, which is now being replaced by a proper V4L2 camera driver named 'renesas-ceu'. Move Migo-R platform to use the v4l2 renesas-ceu camera driver interface and get rid of soc_camera defined components used to register sensor drivers and of platform

Re: [PATCH] [v4] media: s3c-camif: fix out-of-bounds array access

2018-01-16 Thread Sakari Ailus
On Tue, Jan 16, 2018 at 10:52:15PM +0100, Arnd Bergmann wrote: > While experimenting with older compiler versions, I ran > into a warning that no longer shows up on gcc-4.8 or newer: > > drivers/media/platform/s3c-camif/camif-capture.c: In function > '__camif_subdev_try_format': >

Re: [RFT PATCH v3 6/6] uvcvideo: Move decode processing to process context

2018-01-16 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Friday, 12 January 2018 11:19:27 EET Kieran Bingham wrote: > Newer high definition cameras, and cameras with multiple lenses such as > the range of stereo-vision cameras now available have ever increasing > data rates. > > The inclusion of a variable

Re: [PATCH 3/7] si2157: Add hybrid tuner support

2018-01-16 Thread Brad Love
On 2018-01-15 23:05, Antti Palosaari wrote: > Hello > So the use case is to share single tuner with multiple demodulators? > Why don't just register single tuner and pass that info to multiple > demods? > > Antti Hello Antti, It was done this way because of lack of knowledge of other ways. The

[PATCH v6 8/9] media: i2c: tw9910: Remove soc_camera dependencies

2018-01-16 Thread Jacopo Mondi
Remove soc_camera framework dependencies from tw9910 sensor driver. - Handle clock and gpios - Register async subdevice - Remove soc_camera specific g/s_mbus_config operations - Add kernel doc to driver interface header file - Adjust build system This commit does not remove the original

[PATCH v6 7/9] v4l: i2c: Copy tw9910 soc_camera sensor driver

2018-01-16 Thread Jacopo Mondi
Copy the soc_camera based driver in v4l2 sensor driver directory. This commit just copies the original file without modifying it. No modification to KConfig and Makefile as soc_camera framework dependencies need to be removed first in next commit. Signed-off-by: Jacopo Mondi

[PATCH v6 5/9] v4l: i2c: Copy ov772x soc_camera sensor driver

2018-01-16 Thread Jacopo Mondi
Copy the soc_camera based driver in v4l2 sensor driver directory. This commit just copies the original file without modifying it. No modification to KConfig and Makefile as soc_camera framework dependencies need to be removed first in next commit. Signed-off-by: Jacopo Mondi

[PATCH v6 4/9] ARM: dts: r7s72100: Add Capture Engine Unit (CEU)

2018-01-16 Thread Jacopo Mondi
Add Capture Engine Unit (CEU) node to device tree. Signed-off-by: Jacopo Mondi Reviewed-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart Acked-by: Hans Verkuil ---

Re: [PATCH] [v4] media: s3c-camif: fix out-of-bounds array access

2018-01-16 Thread Laurent Pinchart
Hi Arnd, Thank you for the patch. On Tuesday, 16 January 2018 23:52:15 EET Arnd Bergmann wrote: > While experimenting with older compiler versions, I ran > into a warning that no longer shows up on gcc-4.8 or newer: > > drivers/media/platform/s3c-camif/camif-capture.c: In function >

[PATCH v6 0/9] Renesas Capture Engine Unit (CEU) V4L2 driver

2018-01-16 Thread Jacopo Mondi
Hello, new version of CEU after Hans' review. Added his Acked-by to most patches and closed review comments. Running v4l2-compliance, I noticed a new failure introduced by the way I now calculate the plane sizes in set/try_fmt. This is the function used to update per-plane bytesperline and

[PATCH v2] v4l: async: Protect against double notifier registrations

2018-01-16 Thread Kieran Bingham
From: Kieran Bingham It can be easy to attempt to register the same notifier twice in mis-handled error cases such as working with -EPROBE_DEFER. This results in odd kernel crashes where the notifier_list becomes corrupted due to adding the same entry

[linux-next:master 3773/9944] drivers/media/dvb-frontends/stb0899_drv.h:151:36: error: weak declaration of 'stb0899_attach' being applied to a already existing, static definition

2018-01-16 Thread kbuild test robot
Hi Wolfgang, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: fdddade65d7b5f8779374eb73d09889185280f60 commit: 6cdeaed3b1420bd2569891be0c4123ff59628e9e [3773/9944] media: dvb_usb_pctv452e: module refcount changes

Dear Friend,

2018-01-16 Thread Mrs. Aisha Gaddafi
Dear Friend, I came across your e-mail contact prior a private search while in need of your assistance. My name is Aisha Gaddafi a single Mother and a Widow with three Children. I am the only biological Daughter of late Libyan President (Late Colonel Muammar Gaddafi). I have an investment funds

Pomoc dla Zosi

2018-01-16 Thread Karina i Jakub Bieckowie
Szanowni Państwo, Nazywamy się Karina i Jakub Bieckowie. Jesteśmy młodym małżeństwem oraz rodzicami cudownych bliźniaczek – Zuzi i Zosi. Dziewczynki w grudniu skończyły roczek. To niewątpliwie piękny czas, choć w naszym przypadku zakłócił go wielki niepokój. O ile Zuzia jest zdrowym szkrabem,

Re: [PATCH v5 3/9] v4l: platform: Add Renesas CEU driver

2018-01-16 Thread Laurent Pinchart
Hi Hans, On Tuesday, 16 January 2018 11:46:42 EET Hans Verkuil wrote: > Hi Jacopo, > > Sorry for the late review, but here is finally is. > > BTW, can you provide the v4l2-compliance output (ideally with the -f option) > in the cover letter for v6? > > On 01/12/2018 03:04 PM, Jacopo Mondi

Re: [PATCH v5 7/9] v4l: i2c: Copy tw9910 soc_camera sensor driver

2018-01-16 Thread Hans Verkuil
On 01/12/2018 03:04 PM, Jacopo Mondi wrote: > Copy the soc_camera based driver in v4l2 sensor driver directory. > This commit just copies the original file without modifying it. > No modification to KConfig and Makefile as soc_camera framework > dependencies need to be removed first in next

Re: [PATCH v5 2/9] include: media: Add Renesas CEU driver interface

2018-01-16 Thread Hans Verkuil
On 01/12/2018 03:04 PM, Jacopo Mondi wrote: > Add renesas-ceu header file. > > Do not remove the existing sh_mobile_ceu.h one as long as the original > driver does not go away. > > Signed-off-by: Jacopo Mondi > Reviewed-by: Laurent Pinchart

[PATCH 1/2] imx074: deprecate, move to staging

2018-01-16 Thread Hans Verkuil
From: Hans Verkuil This driver is unused and depends on the deprecated soc-camera framework. Move it to staging in preparation for being removed unless someone does the work to convert it to a proper V4L2 subdev driver. Signed-off-by: Hans Verkuil

[PATCH 0/2] imx074/mt9t031: deprecate soc_camera sensors

2018-01-16 Thread Hans Verkuil
From: Hans Verkuil These two sensor drivers in drivers/media/i2c/soc_camera are not used anymore. Move them to staging in preparation of being deleted once the soc_camera framework is removed. Unless someone steps up to do the conversion to a proper V4L2 subdev driver.

Re: [PATCH v5 9/9] arch: sh: migor: Use new renesas-ceu camera driver

2018-01-16 Thread Hans Verkuil
On 01/12/2018 03:04 PM, Jacopo Mondi wrote: > Migo-R platform uses sh_mobile_ceu camera driver, which is now being > replaced by a proper V4L2 camera driver named 'renesas-ceu'. > > Move Migo-R platform to use the v4l2 renesas-ceu camera driver > interface and get rid of soc_camera defined

Re: [PATCH v5 8/9] media: i2c: tw9910: Remove soc_camera dependencies

2018-01-16 Thread Hans Verkuil
On 01/12/2018 03:04 PM, Jacopo Mondi wrote: > Remove soc_camera framework dependencies from tw9910 sensor driver. > - Handle clock and gpios > - Register async subdevice > - Remove soc_camera specific g/s_mbus_config operations > - Add kernel doc to driver interface header file > - Adjust build

[PATCH 2/2] mt9t031: deprecate, move to staging

2018-01-16 Thread Hans Verkuil
From: Hans Verkuil This driver is unused and depends on the deprecated soc-camera framework. Move it to staging in preparation for being removed unless someone does the work to convert it to a proper V4L2 subdev driver. Signed-off-by: Hans Verkuil

[PATCH v6 2/4] media: ov5695: add support for OV5695 sensor

2018-01-16 Thread Shunqian Zheng
This patch adds driver for Omnivision's ov5695 sensor, the driver supports following features: - supported resolutions + 2592x1944 at 30fps + 1920x1080 at 30fps + 1296x972 at 60fps + 1280x720 at 30fps + 640x480 at 120fps - test patterns - manual exposure/gain(analog and digital)

[PATCH v6 4/4] media: ov2685: add support for OV2685 sensor

2018-01-16 Thread Shunqian Zheng
This patch adds driver for Omnivision's ov2685 sensor. Though the ov2685 can output yuv data, this driver only supports the raw bayer format, including the following features: - output 1600x1200 at 30fps - test patterns - manual exposure/gain control - vblank and hblank - media

[PATCH v6 3/4] dt-bindings: media: Add bindings for OV2685

2018-01-16 Thread Shunqian Zheng
Add device tree binding documentation for the OV2685 sensor. Signed-off-by: Shunqian Zheng Reviewed-by: Jacopo Mondi --- .../devicetree/bindings/media/i2c/ov2685.txt | 41 ++ 1 file changed, 41 insertions(+) create

Re: [PATCH v5 1/9] dt-bindings: media: Add Renesas CEU bindings

2018-01-16 Thread Hans Verkuil
On 01/12/2018 03:04 PM, Jacopo Mondi wrote: > Add bindings documentation for Renesas Capture Engine Unit (CEU). > > Signed-off-by: Jacopo Mondi > Reviewed-by: Rob Herring > Reviewed-by: Laurent Pinchart Acked-by:

Re: [PATCH v5 4/9] ARM: dts: r7s72100: Add Capture Engine Unit (CEU)

2018-01-16 Thread Hans Verkuil
On 01/12/2018 03:04 PM, Jacopo Mondi wrote: > Add Capture Engine Unit (CEU) node to device tree. > > Signed-off-by: Jacopo Mondi > Reviewed-by: Geert Uytterhoeven > Reviewed-by: Laurent Pinchart Acked-by:

Re: [PATCH 1/3] dma-buf: make returning the exclusive fence optional

2018-01-16 Thread Christian König
Ping? Daniel you requested the patch with its user. Would be nice when I can commit this cause we need it for debugging and cleaning up a bunch of other things as well. Regards, Christian. Am 12.01.2018 um 10:47 schrieb Christian König: Change reservation_object_get_fences_rcu to make the

Re: [RFC PATCH 5/9] media: vb2: add support for requests

2018-01-16 Thread Hans Verkuil
On 01/16/2018 10:39 AM, Alexandre Courbot wrote: > On Mon, Jan 15, 2018 at 6:07 PM, Hans Verkuil wrote: >> On 01/15/2018 09:24 AM, Alexandre Courbot wrote: >>> On Fri, Jan 12, 2018 at 7:49 PM, Hans Verkuil wrote: On 12/15/17 08:56, Alexandre Courbot

Re: [PATCH v5 3/9] v4l: platform: Add Renesas CEU driver

2018-01-16 Thread Hans Verkuil
Hi Jacopo, Sorry for the late review, but here is finally is. BTW, can you provide the v4l2-compliance output (ideally with the -f option) in the cover letter for v6? On 01/12/2018 03:04 PM, Jacopo Mondi wrote: > Add driver for Renesas Capture Engine Unit (CEU). > > The CEU interface supports

[ANN] Prague Media summit report October 2017

2018-01-16 Thread Sakari Ailus
Hello everyone, Here's the Prague Media summit report from 26th and 27th October 2017. It took long but finally it's here! If you feel something important is missing or incorrect, feel free to reply. First day * The first day was mostly concentrated on discussing the media development

[PATCH v6 0/4] Add supports for OV2685 and OV5695 sensors

2018-01-16 Thread Shunqian Zheng
This adds the OV2685 and OV5695 sensor supports. Changes of v6 are mainly addressing comments from Jacopo@ - Fix the node/lable name inverted in Doc. - Guard the source code with IS_ENABLED(CONFIG_OF) - Move the __v4l2_ctrl_handler_setup() into ov2685_s_stream() Changes of v5, - Squash the

[PATCH v6 1/4] dt-bindings: media: Add bindings for OV5695

2018-01-16 Thread Shunqian Zheng
Add device tree binding documentation for the OV5695 sensor. Signed-off-by: Shunqian Zheng Reviewed-by: Jacopo Mondi --- .../devicetree/bindings/media/i2c/ov5695.txt | 41 ++ 1 file changed, 41 insertions(+) create

Re: [RFC PATCH 5/9] media: vb2: add support for requests

2018-01-16 Thread Alexandre Courbot
On Mon, Jan 15, 2018 at 6:07 PM, Hans Verkuil wrote: > On 01/15/2018 09:24 AM, Alexandre Courbot wrote: >> On Fri, Jan 12, 2018 at 7:49 PM, Hans Verkuil wrote: >>> On 12/15/17 08:56, Alexandre Courbot wrote: Add throttling support for buffers when

Re: [RFC PATCH 6/9] media: vb2: add support for requests in QBUF ioctl

2018-01-16 Thread Alexandre Courbot
On Mon, Jan 15, 2018 at 6:19 PM, Hans Verkuil wrote: > On 01/15/2018 09:24 AM, Alexandre Courbot wrote: >> On Fri, Jan 12, 2018 at 8:37 PM, Hans Verkuil wrote: >>> On 12/15/17 08:56, Alexandre Courbot wrote: Support the request argument of the QBUF

Re: [PATCH v5 5/9] v4l: i2c: Copy ov772x soc_camera sensor driver

2018-01-16 Thread Hans Verkuil
On 01/12/2018 03:04 PM, Jacopo Mondi wrote: > Copy the soc_camera based driver in v4l2 sensor driver directory. > This commit just copies the original file without modifying it. > No modification to KConfig and Makefile as soc_camera framework > dependencies need to be removed first in next

Re: [PATCH v5 6/9] media: i2c: ov772x: Remove soc_camera dependencies

2018-01-16 Thread Hans Verkuil
On 01/12/2018 03:04 PM, Jacopo Mondi wrote: > Remove soc_camera framework dependencies from ov772x sensor driver. > - Handle clock and gpios > - Register async subdevice > - Remove soc_camera specific g/s_mbus_config operations > - Change image format colorspace from JPEG to SRGB as the two use

Re: [PATCH 0/2] imx074/mt9t031: deprecate soc_camera sensors

2018-01-16 Thread Sakari Ailus
On Tue, Jan 16, 2018 at 12:02:43PM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > These two sensor drivers in drivers/media/i2c/soc_camera are not > used anymore. Move them to staging in preparation of being deleted > once the soc_camera framework is removed. Unless

Re: [PATCH v5 6/9] media: i2c: ov772x: Remove soc_camera dependencies

2018-01-16 Thread Laurent Pinchart
Hi Hans, On Tuesday, 16 January 2018 12:08:17 EET Hans Verkuil wrote: > On 01/12/2018 03:04 PM, Jacopo Mondi wrote: > > Remove soc_camera framework dependencies from ov772x sensor driver. > > - Handle clock and gpios > > - Register async subdevice > > - Remove soc_camera specific g/s_mbus_config

Re: [PATCH] [v2] media: s3c-camif: fix out-of-bounds array access

2018-01-16 Thread Arnd Bergmann
On Tue, Jan 16, 2018 at 4:44 PM, Sakari Ailus wrote: >> if (camif_mbus_formats[i] == mf->code) >> break; >> >> + if (i == ARRAY_SIZE(camif_mbus_formats)) >> + mf->code = camif_mbus_formats[0]; >> + > > Either else

[PATCH] [v3] media: s3c-camif: fix out-of-bounds array access

2018-01-16 Thread Arnd Bergmann
While experimenting with older compiler versions, I ran into a warning that no longer shows up on gcc-4.8 or newer: drivers/media/platform/s3c-camif/camif-capture.c: In function '__camif_subdev_try_format': drivers/media/platform/s3c-camif/camif-capture.c:1265:25: error: array subscript is

Re: [PATCH] [v3] media: s3c-camif: fix out-of-bounds array access

2018-01-16 Thread Sakari Ailus
On Tue, Jan 16, 2018 at 05:47:24PM +0100, Arnd Bergmann wrote: > While experimenting with older compiler versions, I ran > into a warning that no longer shows up on gcc-4.8 or newer: > > drivers/media/platform/s3c-camif/camif-capture.c: In function > '__camif_subdev_try_format': >

Re: [PATCH 5/8] [media] omap3isp: support 64-bit version of omap3isp_stat_data

2018-01-16 Thread Arnd Bergmann
On Tue, Dec 5, 2017 at 1:41 AM, Laurent Pinchart wrote: > Hi Arnd, > > Thank you for the patch. > > I'll try to review this without too much delay. In the meantime, I'm CC'ing > Sakari Ailus who might be faster than me :-) Hi Laurent and Sakari, I stumbled

Re: [PATCH v5 3/9] v4l: platform: Add Renesas CEU driver

2018-01-16 Thread jacopo mondi
Hi Hans, On Tue, Jan 16, 2018 at 10:46:42AM +0100, Hans Verkuil wrote: > Hi Jacopo, > > Sorry for the late review, but here is finally is. > > BTW, can you provide the v4l2-compliance output (ideally with the -f option) > in the cover letter for v6? Sure, it was attacched to v3 I guess, since

[PATCH] v4l: async: Protect against double notifier regstrations

2018-01-16 Thread Kieran Bingham
From: Kieran Bingham It can be easy to attempt to register the same notifier twice in mis-handled error cases such as working with -EPROBE_DEFER. This results in odd kernel crashes where the notifier_list becomes corrupted due to adding the same entry

Re: [RFT PATCH v3 0/6] Asynchronous UVC

2018-01-16 Thread Kieran Bingham
Hi Phillip On 15/01/18 19:35, Philipp Zabel wrote: > Hi Kieran, > > On Fri, Jan 12, 2018 at 10:19 AM, Kieran Bingham > wrote: >> This series has been tested on both the ZED and BRIO cameras on arm64 >> platforms, however due to the intrinsic changes in the

Re: [PATCH] v4l: async: Protect against double notifier regstrations

2018-01-16 Thread Sakari Ailus
Hi Kieran, On Tue, Jan 16, 2018 at 02:52:58PM +, Kieran Bingham wrote: > From: Kieran Bingham > > It can be easy to attempt to register the same notifier twice > in mis-handled error cases such as working with -EPROBE_DEFER. > > This results in odd

Re: [RFT PATCH v3 4/6] uvcvideo: queue: Simplify spin-lock usage

2018-01-16 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Friday, 12 January 2018 11:19:26 EET Kieran Bingham wrote: > Both uvc_start_streaming(), and uvc_stop_streaming() are called from > userspace context. As such, they do not need to save the IRQ state, and > can use spin_lock_irq() and spin_unlock_irq()

Re: [PATCH 4/7] si2168: Add ts bus coontrol, turn off bus on sleep

2018-01-16 Thread Brad Love
On 2018-01-15 23:07, Antti Palosaari wrote: > Hello > And what is rationale here, is there some use case demod must be > active and ts set to tristate (disabled)? Just put demod sleep when > you don't use it. > > regards > Antti Hello Antti, Perhaps the .ts_bus_ctrl callback does not need to be

Re: [PATCH] [v2] media: s3c-camif: fix out-of-bounds array access

2018-01-16 Thread Sakari Ailus
Hi Arnd, Thanks for the patch. Please see my comments below. On Tue, Jan 16, 2018 at 04:30:46PM +0100, Arnd Bergmann wrote: > While experimenting with older compiler versions, I ran > into a warning that no longer shows up on gcc-4.8 or newer: > >

[PATCH] [v2] media: s3c-camif: fix out-of-bounds array access

2018-01-16 Thread Arnd Bergmann
While experimenting with older compiler versions, I ran into a warning that no longer shows up on gcc-4.8 or newer: drivers/media/platform/s3c-camif/camif-capture.c: In function '__camif_subdev_try_format': drivers/media/platform/s3c-camif/camif-capture.c:1265:25: error: array subscript is

Re: [PATCH 4/7] si2168: Add ts bus coontrol, turn off bus on sleep

2018-01-16 Thread Antti Palosaari
On 01/16/2018 10:14 PM, Brad Love wrote: On 2018-01-16 13:32, Antti Palosaari wrote: On 01/16/2018 07:31 PM, Brad Love wrote: On 2018-01-15 23:07, Antti Palosaari wrote: Hello And what is rationale here, is there some use case demod must be active and ts set to tristate (disabled)? Just put

cron job: media_tree daily build: ERRORS

2018-01-16 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Jan 17 05:00:17 CET 2018 media-tree git hash:e3ee691dbf24096ea51b3200946b11d68ce75361 media_build

Re: [PATCH v5 6/9] media: i2c: ov772x: Remove soc_camera dependencies

2018-01-16 Thread jacopo mondi
Hi Hans, On Tue, Jan 16, 2018 at 11:08:17AM +0100, Hans Verkuil wrote: > On 01/12/2018 03:04 PM, Jacopo Mondi wrote: > > Remove soc_camera framework dependencies from ov772x sensor driver. > > - Handle clock and gpios > > - Register async subdevice > > - Remove soc_camera specific g/s_mbus_config

Re: [PATCH 4/7] si2168: Add ts bus coontrol, turn off bus on sleep

2018-01-16 Thread Antti Palosaari
On 01/16/2018 07:31 PM, Brad Love wrote: On 2018-01-15 23:07, Antti Palosaari wrote: Hello And what is rationale here, is there some use case demod must be active and ts set to tristate (disabled)? Just put demod sleep when you don't use it. regards Antti Hello Antti, Perhaps the

Re: [PATCH v2 00/19] prevent bounds-check bypass via speculative execution

2018-01-16 Thread Tony Luck
On Sat, Jan 13, 2018 at 10:51 AM, Linus Torvalds wrote: > On Fri, Jan 12, 2018 at 4:15 PM, Tony Luck wrote: > So your argument depends on "the uarch will actually run the code in > order if there are no events that block the pipeline". And

Re: [PATCH] v4l: async: Protect against double notifier regstrations

2018-01-16 Thread Kieran Bingham
Hi Sakari, Thanks for the quick review. On 16/01/18 15:23, Sakari Ailus wrote: > Hi Kieran, > > On Tue, Jan 16, 2018 at 02:52:58PM +, Kieran Bingham wrote: >> From: Kieran Bingham >> >> It can be easy to attempt to register the same notifier twice

Re: [PATCH 4/7] si2168: Add ts bus coontrol, turn off bus on sleep

2018-01-16 Thread Brad Love
On 2018-01-16 13:32, Antti Palosaari wrote: > On 01/16/2018 07:31 PM, Brad Love wrote: >> >> On 2018-01-15 23:07, Antti Palosaari wrote: >>> Hello >>> And what is rationale here, is there some use case demod must be >>> active and ts set to tristate (disabled)? Just put demod sleep when >>> you