Re: [RFC PATCH V2 4/6] platform: mtk-isp: Add Mediatek DIP driver

2019-08-30 Thread Tomasz Figa
Hi Frederic, On Tue, Aug 27, 2019 at 12:16 PM Frederic Chen wrote: > > Dear Tomasz, > > I appreciate your comment. I will collaborate more closely with Jungo > to solve the common issues in DIP and Pass 1(CAM) drivers. > Thank you! Also thanks for replying to all the comments, it's very helpful

Re: [ANN] Topics for a media summit in Lyon in October

2019-08-30 Thread Tomasz Figa
On Wed, Aug 28, 2019 at 7:55 PM Hans Verkuil wrote: > > On 8/16/19 10:06 AM, Hans Verkuil wrote: > > Rather then discussing topics for a meeting under the subject 'Lisbon' > > let's start a new thread referring to the right place :-) > > > > I will try to organize a room, either during the ELCE or

Re: [RFC PATCH V2 4/4] platform: mtk-isp: Add Mediatek FD driver

2019-08-30 Thread Tomasz Figa
On Wed, Aug 28, 2019 at 11:00 AM Jerry-ch Chen wrote: > > Hi Tomasz, > > On Mon, 2019-08-26 at 14:36 +0800, Tomasz Figa wrote: > > Hi Jerry, > > > > On Sun, Aug 25, 2019 at 6:18 PM Jerry-ch Chen > > wrote: > > > > > > Hi Tomasz, > > > > > > On Fri, 2019-08-02 at 16:28 +0800, Tomasz Figa wrote: >

[PATCH 3/3] cedrus: fix various format-related compliance issues

2019-08-30 Thread Hans Verkuil
Initialize the context on open() with valid capture and output formats. It is good practice to always have valid formats internally. This solves one vb2 warning in the kernel log where the sizeimage value of the output format was 0 when requesting buffers, which is not allowed. It also simplifies

[PATCH 0/3] cedrus: v4l2-compliance fixes

2019-08-30 Thread Hans Verkuil
When testing the cedrus driver on my Cubieboard I noticed various v4l2-compliance failures. This series fixes them. Not tested with the -s option since v4l2-compliance doesn't yet support stateless MPEG-2/H.264 decoders. Regards, Hans Hans Verkuil (3): cedrus: fill in bus_info for med

[PATCH 1/3] cedrus: fill in bus_info for media device

2019-08-30 Thread Hans Verkuil
Fixes this compliance warning: $ v4l2-compliance -m0 v4l2-compliance SHA: b514d615166bdc0901a4c71261b87db31e89f464, 32 bits Compliance test for cedrus device /dev/media0: Media Driver Info: Driver name : cedrus Model: cedrus Serial : Bus

[PATCH 2/3] cedrus: choose default pixelformat in try_fmt

2019-08-30 Thread Hans Verkuil
If an unsupported pixelformat is passed to try_fmt, then pick the first valid pixelformat instead. This is more standard V4L2 behavior. Signed-off-by: Hans Verkuil --- .../staging/media/sunxi/cedrus/cedrus_video.c | 46 --- 1 file changed, 20 insertions(+), 26 deletions(-) diff

[PATCH v10 04/14] partial revert of "[media] tvp5150: add HW input connectors support"

2019-08-30 Thread Marco Felsch
From: Javier Martinez Canillas Commit f7b4b54e6364 ("[media] tvp5150: add HW input connectors support") added input signals support for the tvp5150, but the approach was found to be incorrect so the corresponding DT binding commit 82c2ffeb217a ("[media] tvp5150: document input connectors DT bindi

[PATCH v10 01/14] dt-bindings: connector: analog: add sdtv standards property

2019-08-30 Thread Marco Felsch
Some connectors no matter if in- or output supports only a limited range of sdtv standards. It doesn't matter if the hardware behind that connector supports more than the listed formats since the users are restriced by a label e.g. to plug only a camera into this connector which uses the PAL format

[PATCH v10 07/14] media: tvp5150: fix set_selection rectangle handling

2019-08-30 Thread Marco Felsch
Currently a local copy of sel->r is made and adapted to the hardware constraints. After the adaption the value is applied to the hardware but the driver forgot to reflect the adapted value to the user space. Drop the local copy and work directly on the requested rectangle instead to fix this. Sig

[PATCH v10 08/14] media: tvp5150: add FORMAT_TRY support for get/set selection handlers

2019-08-30 Thread Marco Felsch
Since commit 10d5509c8d50 ("[media] v4l2: remove g/s_crop from video ops") the 'which' field for set/get_selection must be FORMAT_ACTIVE. There is no way to try different selections. The patch adds a helper function to select the correct selection memory space (sub-device file handle or driver stat

[PATCH v10 11/14] media: dt-bindings: tvp5150: cleanup bindings stlye

2019-08-30 Thread Marco Felsch
Use underlines to highlight optional and required properties. This is quite common for all bindings. Align descriptions and start sentence with uppercase letter. Also reword the usage of the required endpoint properties for the output port in case BT.656 should be used. Signed-off-by: Marco Felsch

[PATCH v10 05/14] media: tvp5150: add input source selection of_graph support

2019-08-30 Thread Marco Felsch
This patch adds the of_graph support to describe the tvp input connections. Physical the TVP5150 has three ports: AIP1A, AIP1B and YOUT. As result of discussion [1],[2] the device-tree maps these ports 1:1. Look at the Documentation for more information. Since the TVP5150 is a converter/bridge the

[PATCH v10 06/14] media: dt-bindings: tvp5150: Add input port connectors DT bindings

2019-08-30 Thread Marco Felsch
The TVP5150/1 decoders support different video input sources to their AIP1A/B pins. Possible configurations are as follows: - Analog Composite signal connected to AIP1A. - Analog Composite signal connected to AIP1B. - Analog S-Video Y (luminance) and C (chrominance) signals connected to

[PATCH v10 02/14] media: v4l2-fwnode: add v4l2_fwnode_connector

2019-08-30 Thread Marco Felsch
Currently every driver needs to parse the connector endpoints by it self. This is the initial work to make this generic. A generic connector has common members and connector specific members. The common members are: - type - label (optional) - links - nr_of_links The specific members are s

[PATCH v10 12/14] media: dt-bindings: tvp5150: add optional sdtv standards documentation

2019-08-30 Thread Marco Felsch
Document the optional binding to limit the possible sdtv standards on the input connectors. Signed-off-by: Marco Felsch Reviewed-by: Rob Herring --- v8: - adapt to new sdtv-standards - adapt commit message - fix missing include within example code .../devicetree/bindings/media/i2c/tvp5150.txt

[PATCH v10 00/14] TVP5150 features and fixes

2019-08-30 Thread Marco Felsch
Hi, this v10 adresses Hans comments made on my v9 [1]. This series fixes minor typos and drops the initial hdmi-connector parsing support. It also address the set_selection handling if the format was FMT_TRY and the subdev-api isn't available. During work on this series I noticed a bug within the

[PATCH v10 13/14] media: tvp5150: add support to limit sdtv standards

2019-08-30 Thread Marco Felsch
The tvp5150 accepts NTSC(M,J,4.43), PAL (B,D,G,H,I,M,N) and SECAM video data and is able to auto-detect the input signal. The auto-detection does not work if the connector does not receive an input signal and the tvp5150 might not be configured correctly. This misconfiguration leads into wrong deco

[PATCH v10 14/14] media: tvp5150: make debug output more readable

2019-08-30 Thread Marco Felsch
The debug output for tvp5150_selmux() isn't really intuitive. Register values are printed decimal formatted and the input/output driver states are printed as enum. Even more the "normal" output enum mapps to zero so a active output will printing output=0 and a inactive output=1. Change this by bri

[PATCH v10 10/14] media: tvp5150: add s_power callback

2019-08-30 Thread Marco Felsch
Don't en-/disable the interrupts during s_stream because someone can disable the stream but wants to get informed if the stream is locked again. So keep the interrupts enabled the whole time the pipeline is opened. Signed-off-by: Marco Felsch --- drivers/media/i2c/tvp5150.c | 23

[PATCH v10 03/14] media: v4l2-fwnode: add initial connector parsing support

2019-08-30 Thread Marco Felsch
The patch adds the initial connector parsing code, so we can move from a driver specific parsing code to a generic one. Currently only the generic fields and the analog-connector specific fields are parsed. Parsing the other connector specific fields can be added by a simple callbacks. Signed-off-

[PATCH v10 09/14] media: tvp5150: initialize subdev before parsing device tree

2019-08-30 Thread Marco Felsch
From: Michael Tretter There are several debug prints in the tvp5150_parse_dt() function, which do not print the prefix, because the v4l2_subdev is not initialized, yet. Initialize the v4l2_subdev before parsing the device tree to fix the debug messages. Signed-off-by: Michael Tretter Signed-of

[GIT PULL for 5.4] sun4i csi driver sparse fix

2019-08-30 Thread Sakari Ailus
Hi Mauro, Here's a small sparse fix for the sun4i csi driver. Please pull. The following changes since commit 968bce2f59ce462d296af28610628fe7e03b120a: media: imx: remove unused including (2019-08-29 10:23:18 -0300) are available in the Git repository at: ssh://linuxtv.org/git/sailus/m

Re: [GIT PULL for 5.4] sun4i csi driver sparse fix

2019-08-30 Thread Jenkins
From: buil...@linuxtv.org Pull request: https://patchwork.linuxtv.org/patch/58505/ Build log: https://builder.linuxtv.org/job/patchwork/13930/ Build time: 00:00:00 Link: https://lore.kernel.org/linux-media/20190830120500.gb3...@valkosipuli.retiisi.org.uk Build aborted due to a fatal error: FAILE

Re: [PATCH] media: vimc: upon streaming, check that the pipeline starts with a source entity

2019-08-30 Thread Helen Koike
Hi Dafna, Thanks for the patch. Just small comments below. On 8/29/19 8:00 AM, Dafna Hirschfeld wrote: > Userspace can disable links and create pipelines that > do not start with a source entity. Trying to stream > from such a pipeline should fail with -EPIPE > currently this is not handled and c

[GIT PULL v2 for 5.4] sun4i csi driver sparse fix

2019-08-30 Thread Sakari Ailus
Hi Mauro, Here's a small sparse fix for the sun4i csi driver. This time with a git URL. Please pull. The following changes since commit 968bce2f59ce462d296af28610628fe7e03b120a: media: imx: remove unused including (2019-08-29 10:23:18 -0300) are available in the Git repository at: git

Re: [GIT PULL v2 for 5.4] sun4i csi driver sparse fix

2019-08-30 Thread Jenkins
From: buil...@linuxtv.org Pull request: https://patchwork.linuxtv.org/patch/58506/ Build log: https://builder.linuxtv.org/job/patchwork/13939/ Build time: 00:03:52 Link: https://lore.kernel.org/linux-media/20190830132929.gc3...@valkosipuli.retiisi.org.uk gpg: Signature made Fri 30 Aug 2019 12:01

[PATCH] media: i2c: Use div64_ul() for u64-by-unsigned-long divide

2019-08-30 Thread Geert Uytterhoeven
div_u64() does a 64-by-32 division, while the divisor max2175.xtal_freq is unsigned long, thus 64-bit on 64-bit platforms. Hence the proper function to call is div64_ul(). Note that this change does not have any functional impact, as the crystal frequency must be much lower than the 32-bit limit

[PATCH v2] media: vimc: upon streaming, check that the pipeline starts with a source entity

2019-08-30 Thread Dafna Hirschfeld
Userspace can disable links and create pipelines that do not start with a source entity. Trying to stream from such a pipeline should fail with -EPIPE currently this is not handled and cause kernel crash. Reported-by: kbuild test robot Signed-off-by: Dafna Hirschfeld --- Reproducing the crash: m

Re: [PATCH 00/22] media: imx: Create media links in bound notifiers

2019-08-30 Thread Steve Longerbeam
Hi Sakari, Hans, etc. Can you take a look at this series at some point? I think there's some good stuff in here. Thanks, Steve On 8/5/19 4:34 PM, Steve Longerbeam wrote: This series moves media link creation into the notifier bound callbacks in the subdevices required by imx. But to suppor

re: still waiting for your reply

2019-08-30 Thread Brian Chapman
still waiting for your reply Brian --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus

cron job: media_tree daily build: OK

2019-08-30 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Aug 31 05:00:11 CEST 2019 media-tree git hash:20a438d53fd9d12a894161bc56cbeab7a9993c39 media_build gi