Re: [PATCHv3 0/8] media: cedrus: h264: Support multi-slice frames

2019-10-11 Thread Jernej Škrabec
Dne četrtek, 10. oktober 2019 ob 15:11:44 CEST je Hans Verkuil napisal(a): > This series adds support for decoding multi-slice H264 frames along with > support for V4L2_DEC_CMD_FLUSH and V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF. > > This has only been compile-tested. Jernej, can you test with ffmpeg? S

Re: [PATCHv3 6/8] media: cedrus: Detect first slice of a frame

2019-10-11 Thread Jernej Škrabec
Dne četrtek, 10. oktober 2019 ob 15:11:50 CEST je Hans Verkuil napisal(a): > From: Jernej Skrabec > > When codec supports multiple slices in one frame, VPU has to know when > first slice of each frame is being processed, presumably to correctly > clear/set data in auxiliary buffers. > > Add firs

Re: [PATCHv3 6/8] media: cedrus: Detect first slice of a frame

2019-10-11 Thread Hans Verkuil
On 10/11/19 10:49 AM, Jernej Škrabec wrote: > Dne četrtek, 10. oktober 2019 ob 15:11:50 CEST je Hans Verkuil napisal(a): >> From: Jernej Skrabec >> >> When codec supports multiple slices in one frame, VPU has to know when >> first slice of each frame is being processed, presumably to correctly >>

Re: [virtio-dev] [PATCH] [RFC RESEND] vdec: Add virtio video decode device specification

2019-10-11 Thread Dmitry Morozov
Hi Tomasz, On Mittwoch, 9. Oktober 2019 05:55:45 CEST Tomasz Figa wrote: > On Tue, Oct 8, 2019 at 12:09 AM Dmitry Morozov > > wrote: > > Hi Tomasz, > > > > On Montag, 7. Oktober 2019 16:14:13 CEST Tomasz Figa wrote: > > > Hi Dmitry, > > > > > > On Mon, Oct 7, 2019 at 11:01 PM Dmitry Morozov >

[PATCH v2 1/4] media: vb2: Add a helper to get the vb2 buffer attached to a request

2019-10-11 Thread Boris Brezillon
vb2_request_get_buf() returns the N-th buffer attached to a media request. Signed-off-by: Boris Brezillon --- Changes in v2: * Adjust the kernel doc as suggested by Hans --- .../media/common/videobuf2/videobuf2-core.c | 23 +++ include/media/videobuf2-core.h| 11

[PATCH v2 0/4] media: rockchip: Add the rkvdec driver

2019-10-11 Thread Boris Brezillon
Hello, This is v2 of the rkvdec driver which was initially posted as part of my RFC adding codec helpers. For this version, I decided to get rid of the helper stuff which is likely to take some more time to settle. The patchset now contains a proper DT binding doc. Note that this implementation i

Re: [PATCHv3 7/8] media: cedrus: h264: Support multiple slices per frame

2019-10-11 Thread Jernej Škrabec
Dne četrtek, 10. oktober 2019 ob 15:11:51 CEST je Hans Verkuil napisal(a): > From: Jernej Skrabec > > With recent changes, support for decoding multi-slice frames can be > easily added now. > > Signal VPU if current slice is first in frame or not and add information > about first macroblock coor

Re: [PATCHv3 8/8] media: cedrus: Add support for holding capture buffer

2019-10-11 Thread Jernej Škrabec
Dne četrtek, 10. oktober 2019 ob 15:11:52 CEST je Hans Verkuil napisal(a): > From: Jernej Skrabec > > When frame contains multiple slices and driver works in slice mode, it's > more efficient to hold capture buffer in queue until all slices of a > same frame are decoded. > > Add support for that

[PATCH v2 4/4] arm64: dts: rockchip: rk3399: Define the rockchip Video Decoder node

2019-10-11 Thread Boris Brezillon
RK3399 has a Video decoder, define the node in the dtsi. We also add the missing power-domain in mmu node and enable the block. Signed-off-by: Boris Brezillon --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/arch/arm6

[PATCH v2 3/4] media: rockchip: Add the rkvdec driver

2019-10-11 Thread Boris Brezillon
The rockchip vdec block is a stateless decoder that's able to decode H264, HEVC and VP9 content. This patch only adds H264 support and is making use of the m2m codec helpers. Signed-off-by: Boris Brezillon --- drivers/staging/media/Kconfig |2 + drivers/staging/media/Makefile

[PATCH v2 2/4] media: dt-bindings: rockchip: Document RK3399 Video Decoder bindings

2019-10-11 Thread Boris Brezillon
Document the Rockchip RK3399 Video Decoder bindings. Signed-off-by: Boris Brezillon --- .../bindings/media/rockchip,vdec.yaml | 71 +++ 1 file changed, 71 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/rockchip,vdec.yaml diff --git a/Documentat

[PATCHv4 5/6] v4l2-mem2mem: add new_frame detection

2019-10-11 Thread Hans Verkuil
Drivers that support VB2_V4L2_FL_SUPPORTS_M2M_HOLD_CAPTURE_BUF typically want to know if a new frame is started (i.e. the first slice is about to be processed). Add a new_frame bool to v4l2_m2m_ctx and set it accordingly. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-mem2mem.c | 1

[PATCHv4 3/6] videodev2.h: add V4L2_DEC_CMD_FLUSH

2019-10-11 Thread Hans Verkuil
Add this new V4L2_DEC_CMD_FLUSH decoder command and document it. Reviewed-by: Boris Brezillon Reviewed-by: Alexandre Courbot Signed-off-by: Hans Verkuil [Adjusted description] Signed-off-by: Jernej Skrabec --- Documentation/media/uapi/v4l/vidioc-decoder-cmd.rst | 10 +- Documentation/

[PATCHv4 6/6] media: cedrus: h264: Support multiple slices per frame

2019-10-11 Thread Hans Verkuil
From: Jernej Skrabec With recent changes, support for decoding multi-slice frames can be easily added now. Signal VPU if current slice is first in frame or not and add information about first macroblock coordinates. When frame contains multiple slices and driver works in slice mode, it's more e

[PATCHv4 4/6] media: v4l2-mem2mem: add stateless_(try_)decoder_cmd ioctl helpers

2019-10-11 Thread Hans Verkuil
From: Jernej Skrabec These helpers are used by stateless codecs when they support multiple slices per frame and hold capture buffer flag is set. It's expected that all such codecs will use this code. Signed-off-by: Jernej Skrabec Co-developed-by: Hans Verkuil Signed-off-by: Hans Verkuil ---

[PATCHv4 1/6] vb2: add V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF

2019-10-11 Thread Hans Verkuil
This patch adds support for the V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF flag. It also adds a new V4L2_BUF_CAP_SUPPORTS_M2M_HOLD_CAPTURE_BUF capability. Drivers should set vb2_queue->subsystem_flags to VB2_V4L2_FL_SUPPORTS_M2M_HOLD_CAPTURE_BUF to indicate support for this flag. Signed-off-by: Hans Verk

[PATCHv4 0/6] media: cedrus: h264: Support multi-slice frames

2019-10-11 Thread Hans Verkuil
This series adds support for decoding multi-slice H264 frames along with support for V4L2_DEC_CMD_FLUSH and V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF. This has only been compile-tested. Jernej, can you test with ffmpeg? This series is based on https://www.spinics.net/lists/linux-media/msg158081.html plu

[PATCHv4 2/6] v4l2-mem2mem: support held capture buffers

2019-10-11 Thread Hans Verkuil
Check for held buffers that are ready to be returned to vb2 in __v4l2_m2m_try_queue(). This avoids drivers having to handle this case. Add v4l2_m2m_buf_done_and_job_finish() to correctly return source and destination buffers and mark the job as finished while taking a held destination buffer into

[RESEND PATCH v2 1/4] media: vb2: Add a helper to get the vb2 buffer attached to a request

2019-10-11 Thread Boris Brezillon
vb2_request_get_buf() returns the N-th buffer attached to a media request. Signed-off-by: Boris Brezillon --- Changes in v2: * Adjust the kernel doc as suggested by Hans --- .../media/common/videobuf2/videobuf2-core.c | 23 +++ include/media/videobuf2-core.h| 11

[RESEND PATCH v2 2/4] media: dt-bindings: rockchip: Document RK3399 Video Decoder bindings

2019-10-11 Thread Boris Brezillon
Document the Rockchip RK3399 Video Decoder bindings. Signed-off-by: Boris Brezillon --- .../bindings/media/rockchip,vdec.yaml | 71 +++ 1 file changed, 71 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/rockchip,vdec.yaml diff --git a/Documentat

[RESEND PATCH v2 0/4] media: rockchip: Add the rkvdec driver

2019-10-11 Thread Boris Brezillon
Hello, Sorry for the noise, I forgot to Cc the DT maintainers/ML on my last attempt. This is v2 of the rkvdec driver which was initially posted as part of my RFC adding codec helpers. For this version, I decided to get rid of the helper stuff which is likely to take some more time to settle. The

[RESEND PATCH v2 4/4] arm64: dts: rockchip: rk3399: Define the rockchip Video Decoder node

2019-10-11 Thread Boris Brezillon
RK3399 has a Video decoder, define the node in the dtsi. We also add the missing power-domain in mmu node and enable the block. Signed-off-by: Boris Brezillon --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/arch/arm6

[RESEND PATCH v2 3/4] media: rockchip: Add the rkvdec driver

2019-10-11 Thread Boris Brezillon
The rockchip vdec block is a stateless decoder that's able to decode H264, HEVC and VP9 content. This patch only adds H264 support and is making use of the m2m codec helpers. Signed-off-by: Boris Brezillon --- drivers/staging/media/Kconfig |2 + drivers/staging/media/Makefile

Re: [RESEND PATCH v2 0/4] media: rockchip: Add the rkvdec driver

2019-10-11 Thread Hans Verkuil
On 10/11/19 11:33 AM, Boris Brezillon wrote: > Hello, > > Sorry for the noise, I forgot to Cc the DT maintainers/ML on my last > attempt. > > This is v2 of the rkvdec driver which was initially posted as part of > my RFC adding codec helpers. > For this version, I decided to get rid of the helper

Re: [RESEND PATCH v2 0/4] media: rockchip: Add the rkvdec driver

2019-10-11 Thread Boris Brezillon
On Fri, 11 Oct 2019 11:43:20 +0200 Hans Verkuil wrote: > On 10/11/19 11:33 AM, Boris Brezillon wrote: > > Hello, > > > > Sorry for the noise, I forgot to Cc the DT maintainers/ML on my last > > attempt. > > > > This is v2 of the rkvdec driver which was initially posted as part of > > my RFC add

Re: [RESEND PATCH v2 3/4] media: rockchip: Add the rkvdec driver

2019-10-11 Thread Hans Verkuil
On 10/11/19 11:33 AM, Boris Brezillon wrote: > The rockchip vdec block is a stateless decoder that's able to decode > H264, HEVC and VP9 content. This patch only adds H264 support and is > making use of the m2m codec helpers. Thank you for working on this. Here is a quick review: > > Signed-off

[PATCH v3] media: adv7180: Only print 'chip found' message on successful probe

2019-10-11 Thread Fabio Estevam
Currently the "chip found" message is shown even in the case where the I2C address is wrongly passed in the device tree, or also in the case of probe failure, which is misleading. To avoid such problem, move this message after real I2C transactions have been successfully made and we are certain th

Re: [RESEND PATCH v2 3/4] media: rockchip: Add the rkvdec driver

2019-10-11 Thread Boris Brezillon
Hi Hans, On Fri, 11 Oct 2019 12:06:35 +0200 Hans Verkuil wrote: > > diff --git a/drivers/staging/media/rockchip/Kconfig > > b/drivers/staging/media/rockchip/Kconfig > > new file mode 100644 > > index ..8c617ae2c84f > > --- /dev/null > > +++ b/drivers/staging/media/rockchip/Kconfig >

Re: [RESEND PATCH v2 3/4] media: rockchip: Add the rkvdec driver

2019-10-11 Thread Hans Verkuil
On 10/11/19 1:15 PM, Boris Brezillon wrote: > Hi Hans, > > On Fri, 11 Oct 2019 12:06:35 +0200 > Hans Verkuil wrote: > >>> diff --git a/drivers/staging/media/rockchip/Kconfig >>> b/drivers/staging/media/rockchip/Kconfig >>> new file mode 100644 >>> index ..8c617ae2c84f >>> --- /dev/n

Re: [RESEND PATCH v2 2/4] media: dt-bindings: rockchip: Document RK3399 Video Decoder bindings

2019-10-11 Thread Rob Herring
On Fri, Oct 11, 2019 at 4:33 AM Boris Brezillon wrote: > > Document the Rockchip RK3399 Video Decoder bindings. You need some more headers for the example (or drop defines): Error: Documentation/devicetree/bindings/media/rockchip,vdec.example.dts:23.28-29 syntax error FATAL ERROR: Unable to par

Re: [RESEND PATCH v2 2/4] media: dt-bindings: rockchip: Document RK3399 Video Decoder bindings

2019-10-11 Thread Boris Brezillon
On Fri, 11 Oct 2019 07:50:16 -0500 Rob Herring wrote: > On Fri, Oct 11, 2019 at 4:33 AM Boris Brezillon > wrote: > > > > Document the Rockchip RK3399 Video Decoder bindings. > > You need some more headers for the example (or drop defines): > > Error: > Documentation/devicetree/bindings/medi

TRADING ACCOUNT

2019-10-11 Thread HUREL Vincent
Dear sir , I am M HUREL Vincent , purchasing and sales manager of ABB FRANCE . Our Company specialised in Supplying computer hardware and Electronic . We want to extend our supplier list because of concurrency in prices on the international market . We are seeking a supplier with whom we can t

Re: [RESEND PATCH v2 2/4] media: dt-bindings: rockchip: Document RK3399 Video Decoder bindings

2019-10-11 Thread Rob Herring
On Fri, Oct 11, 2019 at 7:56 AM Boris Brezillon wrote: > > On Fri, 11 Oct 2019 07:50:16 -0500 > Rob Herring wrote: > > > On Fri, Oct 11, 2019 at 4:33 AM Boris Brezillon > > wrote: > > > > > > Document the Rockchip RK3399 Video Decoder bindings. > > > > You need some more headers for the example