From: Jasmin Jessich
Due to recent changes the TDA18250 driver requires now regmap_write_bits,
which is available since Kernel 4.3 only.
Signed-off-by: Jasmin Jessich
---
v4l/versions.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/v4l/versions.txt b/v4l/versions.tx
Hi!
I could test only the compilation for Kernel 3.13 due to my laptop I am using
on vacation. It should compile now for all Kernels from 4.2 .. 3.13 also.
BR,
Jasmin
From: Jasmin Jessich
The previouse patch did enable the TDA18250 driver for Kernel 4.2.
Corrected this now.
Signed-off-by: Jasmin Jessich
---
v4l/versions.txt | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/v4l/versions.txt b/v4l/versions.txt
index 6885a05..ed1e056 10
From: Jasmin Jessich
The device created by device_create in dvb_register_device was not
available for DVB device drivers.
Added "struct device *dev" to "struct dvb_device" and store the created
device.
Signed-off-by: Jasmin Jessich
Acked-by: Ralph Metzler
---
drivers/media/dvb-core/dvbdev.c |
From: Jasmin Jessich
Some (older) CAMs are really slow in accepting data. The CI interface
specification doesn't define a handshake for accepted data. Thus, the
en50221 protocol driver can't control if a data byte has been correctly
written to the CAM.
The current implementation writes the lengt
From: Jasmin Jessich
Some (older) CAMs are really slow in accepting data. I got sometimes the
already known error "CAM tried to send a buffer larger than the ecount
size". I could track it down to the dvb_ca_en50221_write_data function not
waiting between sending the data length high/low and d
From: Jasmin Jessich
Added the documentation for the new ca? sysfs nodes in
/sys/class/dvb/dvb?/ca?/tim_wr_.
Signed-off-by: Jasmin Jessich
---
Documentation/ABI/testing/sysfs-class-ca| 63 ++
Documentation/media/uapi/dvb/ca-sysfs-nodes.rst | 85 +
From: Jasmin Jessich
Also fixed v4.8_user_pages_flag.patch.
Signed-off-by: Jasmin Jessich
---
backports/v4.8_user_pages_flag.patch | 5 +++--
v4l/compat.h | 13 +
v4l/scripts/make_config_compat.pl| 1 +
3 files changed, 17 insertions(+), 2 deletions(-)
Hi!
I tested this with Kernel 4.4 and Kernel 3.13. It should fix the build for
newer Kernels also (requires my other build patch "Disabled
MEDIA_TUNER_TDA18250 for Kernels older than 4.3" (newer version) to be
applied).
Merry Christmas,
Jasmin
Ping!
Missing to compile Kernel 4.2:
https://patchwork.linuxtv.org/patch/46153/
BR,
Jasmin
From: Jasmin Jessich
Commit 03fbdb2f moved videobuf2 to drivers/media/common. Modified the
backport patches to patch the files on the new location.
Signed-off-by: Jasmin Jessich
---
backports/v4.0_dma_buf_export.patch | 18 +-
backports/v4.0_drop_trace.patch | 6 +++---
Hi!
THX Mauro for only moving and not changing the videobuf2 files, so it was easy
to fix.
I tested the build with Kernel 4.4 and 3.13.
BR,
Jasmin
Hi!
Maybe someone can apply:
https://patchwork.linuxtv.org/patch/46252/
BR,
Jasmin
From: Jasmin Jessich
Commit 828ee8c71950 ("media: uvcvideo: Use ktime_t for timestamps")
changed to use ktime_t for timestamps. Older Kernels use a struct for
ktime_t, which requires the conversion function ktime_to_ns to be used on
some places. With this patch it will compile now also for older
Hi!
I tested this patch (compile only) on Kernel 4.4.
For 3.13 there is something else not working, so I (or Hans) needs to have a
look on that.
BR,
Jasmin
From: Jasmin Jessich
Signed-off-by: Jasmin Jessich
---
v4l/versions.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/v4l/versions.txt b/v4l/versions.txt
index ed1e056..945e1c3 100644
--- a/v4l/versions.txt
+++ b/v4l/versions.txt
@@ -35,6 +35,8 @@ VIDEO_SOLO6X10
[4.3.0]
# needs regmap
From: Jasmin Jessich
The driver requires linux/property.h, which is available since Kernel
3.18.17 only.
Signed-off-by: Jasmin Jessich
---
v4l/versions.txt | 4
1 file changed, 4 insertions(+)
diff --git a/v4l/versions.txt b/v4l/versions.txt
index 945e1c3..bf19bb1 100644
--- a/v4l/versio
Hi!
With that it compiles again for Kernel 3.13.
Please note, that
https://patchwork.linuxtv.org/patch/46464/
needs to be applied to compile for Kernels older 4.10.
BR,
Jasmin
Ping!
It is required to compile for Kernels older 4.10.
Hello Mauro!
> Ping!
> It is required to compile for Kernels older 4.10.
It would be nice to get this merged, so that we can see if older Kernels
will compile again.
BR,
Jasmin
the wrong place, but then Hans would have merged it already and I could look
into the other build problems.
BR,
Jasmin
*
On 02/02/2018 12:32 PM, Laurent Pinchart wrote:
> Hi Jasmin,
>
> Thank you for the patch.
&
From: Jasmin Jessich
Due the delay with merging patches to media_tree, add the mentioned
patch temporarily to backports. Once this patch is merged to media_tree,
revert this patch.
Signed-off-by: Jasmin Jessich
---
backports/backports.txt| 1 +
backports/v4.9_uvcvideo_
Hi!
I tested to build with Kernel 4.14.17 and 4.4 and this worked.
Kernel 3.17 is currently not working, but I would like to wait with fixes
for Kernel 3.x after this patch has been applied to media_build.
BR,
Jasmin
Hi!
> We're waiting for the end of the 4.16 merge window.
Ahh, this is the reason for the delay.
> For me that meant that I simply did (and still don't) have time to look at
> fixing the media_build.
No problem, I do it when I have time ;)
> The media_build is also broken worse than usual AFAIK,
Hi!
> Strictly speaking, building the media subsystem on older kernels is a job of
> the media build system.
Yes I agree.
> In general I would thus ask for the fix to be merged in media-build.git.
Which I do mostly, but in this case it is a coding error in mainline.
> In this specific case, as
Will look into this during the next days.
BR,
Jasmin
From: Jasmin Jessich
This fixes the "'idx' may be used uninitialized in this function"
warning.
Cc: Jacopo Mondi
Signed-off-by: Jasmin Jessich
---
drivers/media/i2c/mt9v111.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/mt9v111.c b/drivers/media/i2c/m
Hi!
This was really hard to fix and I am still not ready.
But it should now compile for 4.19, 4.18 and 4.17.
Compiling is one thing, but functional is another. I added some inline
functions to compat.h (ida_alloc_min, ...) in 7283154cd56d to support them for
older Kernels. If someone is using an
Hello Hans!
> I'm inclined to drop support for 2.6 altogether.
RHEL 6 is on kernel 2.6.32, which we do not support since long time.
Most other distributions switched to 3.x also years in the past.
So lets drop 2.6.x then!
As you know I maintain a media-tree DKMS package and this should work for o
From: Jasmin Jessich
The portable type for a wait queue is wait_queue_head_t.
Signed-off-by: Jasmin Jessich
---
include/media/media-request.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/media/media-request.h b/include/media/media-request.h
index 0ce75c35131f..bd
Hi!
Temporary add this patch to media-build until it is integrated in mainline.
This should fix the build errors for Kernels older than 4.12.
BR,
Jasmin
From: Jasmin Jessich
On older Kernels (prior to 4.15) irqreturn_t and devm_request_threaded_irq
is not defined when compiling adv7604.c. It seems more recent Kernels
include it via another header which is included by adv7604.c.
Now we include linux/interrupt.h explicitly to get the type also defi
Hello Brad!
> and which the media_build system does not pick up on for whatever
> reason.
Maybe it would be better to analyse why "make_config_compat.pl" selects
wrongly the compatibility code.
> It seems there is quite often at least one backport I must disable,
> and some target kernels require
Hello Brad!
THX for this clarification!
So you tried already to fix the config_compat script and I agree with you that
it is difficult for you because of the various Kernels and distributions you
have to maintain.
Then your workaround is indeed a possibility to use media-build to build your
modu
Hello Brad!
Tonight build broke due to patch 95ee4c285022!
You enabled VIDEO_OV2685 for 3.13., which doesn't
compile for Kernels older than 3.17. When you look
to the Kernel 3.17 section a lot of the drivers you
enabled for 3.13 with your patch should be enabled
for 3.17 only.
So please test this
Hello Brad!
THX for the quick fix!
Hans did already apply it and Kernel 3.16 builds now.
I hope we will see a complete build tomorrow.
BR,
Jasmin
Hello Brad!
This patch added the inclusion of "linux/of_i2c.h".
This gave the warnings in the last nightly build for Kernel
3.6 - 3.9.
I just pushed a fix for that, so we should have an OK build this
night.
BR,
Jasmin
Hello Brad!
> Are the build logs public?
Look for the eMail
cron job: media_tree daily build: ?
The ? is OK, WARNINGS or ERRORS
In this eMail there are links to the short and long logfile.
Hans uses a complete build system which can download the Kernel sources, build
media-build agai
Hi!
I can't test it currently, but I reviewed it and it looks good.
So you can add my Acked-by .
BR,
Jasmin
Hi!
I can't test it currently, but I reviewed it and it looks good.
So you can add my Acked-by .
BR,
Jasmin
Hi!
THX for the patch.
@Hans:
I applied the patch already, but I can't delete it from Patchwork.
Please remove it there.
BR,
Jasmin
Hello Hans!
> linux-4.9.91-x86_64: ERRORS
> /home/hans/work/build/media_build/v4l/dw9807.c:321:3: error
The build works in my tree ... ?!?
I can't find the file in media_tree:
find . -name "*9807*"
Can you please check if there is something wrong with your
media_tree version which is used for
You can add my Acked-by: Jasmin Jessich
On 06/19/2018 08:51 PM, Daniel Scheller wrote:
> From: Daniel Scheller
>
> As both the MODULE_LICENSE and the boilerplates are now in sync and clear
> that the driver is licensed under the terms of the GPLv2-only, add a
> matching SPDX license identifier
You can add my Acked-by: Jasmin Jessich
On 06/19/2018 08:51 PM, Daniel Scheller wrote:
> From: Daniel Scheller
>
> In commit 3db30defab4b ("use correct MODULE_LINCESE for GPL v2 only
> according to notice in header") in the upstream repository for the
> mentioned driver at https://github.com/Di
You can add my Acked-by: Jasmin Jessich
On 06/19/2018 08:51 PM, Daniel Scheller wrote:
> From: Daniel Scheller
>
> There's a superfluous whitespace in the boilerplate license text in both
> .c and .h files. Fix this.
>
> Cc: Ralph Metzler
> Cc: Manfred Voelkel
> Signed-off-by: Daniel Schelle
Hello Mauro!
I got a request from a user, that media_build does not compile for older
Kernels. I checked that and found that the downloaded linux-media.tar.bz2 does
not contain "include/linux/overflow.h". Please can you add this file, because
media-build needs that file now.
BR,
Jasmin
Hello Mauro!
> Patch looks ok, although it would be great to get some acks there.
I have no time to test this, but I know Daniel does all this tests and in fact
he is currently adapting changes done by DD in their repo, modifying them to
work in the current media-tree version and submits them to t
Hello Dan!
I checked this and this is in since ages. Good catch!
I did a quick look to the other places where this is checked also
and they seem all ok.
Acked-by: Jasmin Jessich
BR,
Jasmin
From: Jasmin Jessich
This reverts 8b0e195314fa, because this will not compile for Kernels
older than 4.10.
Cc: Thomas Gleixner
Signed-off-by: Jasmin Jessich
---
drivers/media/dvb-core/dmxdev.c | 2 +-
drivers/media/pci/cx88/cx88-input.c | 6 --
drivers/media/pci/pt3/pt3.c | 2
Hello Mauro/Hans!
> There is already an upstream patch for hidding it:
The patch from https://patchwork.kernel.org/patch/10334353 will not
apply at the smatch tree.
Attached is an updated version for smatch.
Even with the patched tools, sparse still complains:
CC drivers/media/cec/cec-core
Hello Mauro/Hans!
> Then you're probably not using the right version
Might be ...
The build script from Hans uses the Versions from here:
git://repo.or.cz/smatch.git
git://git.kernel.org/pub/scm/devel/sparse/sparse.git
> Yesterday, I added both trees I'm using here at:
> https://git.l
Hello Mauro!
> This patch looks fine, but not for the above-mentioned.
So I shall reword the commit message?
> The thing is that it is not consistent to have some places with
> things like:
> timeout = ktime_set(1, ir->polling * 100);
>
> and others with:
> timeout = ir->polling
From: Jasmin Jessich
This reverts 8b0e195314fa, because media-tree drivers should use the
API functions to initialize variables of type ktime_t.
Cc: Thomas Gleixner
Signed-off-by: Jasmin Jessich
---
drivers/media/dvb-core/dmxdev.c | 2 +-
drivers/media/pci/cx88/cx88-input.c | 6 --
dr
Hello!
I just pushed a fix to media-build.
But I had to disable the driver for Kernels older than 4.16.
-> VIDEO_I2C requires device_get_match_data which requires
the function pointer device_get_match_data in fwnode_operations.
The latter has been added first in Kernel 4.16.
If someone wants t
From: Jasmin Jessich
In commit 20a63349b142 a new variable ktime_t delay has been added.
We decided to use the API functions to initialize ktime_t variables
within media-tree. Thus variable delay needs to be initialized with
ktime_set() instead of setting it directly.
Signed-off-by: Jasmin Jessi
Hello Mauro!
THX for looking into this!
> Hmm... from what I understood, the original author for those patches
> is Ralph, right?
Yes. I re-formatted them into smaller pieces to be easier reviewed.
The goal of this series is to make the Kernel version equal to the official
DD version. But I wrot
Hello Mauro!
> If you want it applied, this is needed anyway, as the patch doesn't apply
> cleanly:
Because you didn't apply the first series!
In the first series
[PATCH 0/7] Add block read/write to en50221 CAM functions
I wrote:
There is another patch series coming soon "Fix coding style in
Hello Mauro!
> It should be, instead:
>From: Ralph Metzler
I thought it is enough to write him in the Signed-off-by as first.
This From line is automatically generated by Git with Format Patch
and then used by send. However I should change that and my mail program
still accepting it?
I will
Hello Mauro!
> The idea behind patch 04/11 makes sense to me. I'll review it carefully
> after having everything applied.
Please don't do that now!
The first series will then not be easily changed, because it changes the state
machine. I will provide the first series and when it is applied the se
Hi!
After the recent changes, I can no longer compile for Kernel 3.13
BR,
Jasmin
Here the build Log:
Kernel build directory is /lib/modules/3.13.0-117-generic/build
make -C ../linux apply_patches
make[2]: Entering directory
'/mnt/home_hdd/jasmin/vdr/dd_driver/git/media_build/linux'
Patches
Hallo Hans!
> OK, so I felt a bit guilty and decided to take a quick look. I think it
> will now build again for 3.13.
Yes, It builds now perfectly.
Will test the driver tomorrow.
THANK YOU VERRY MUCH!
BR,
Jasmin
Hello !
On 06/19/2017 10:18 PM, Daniel Scheller wrote:
> Am Sun, 28 May 2017 23:45:37 +0200
> schrieb Daniel Scheller :
>
>> Am Sun, 7 May 2017 17:42:12 +0200
>> schrieb Daniel Scheller :
>>
>>> Am Wed, 12 Apr 2017 21:23:27 +0200
>>> schrieb Daniel Scheller :
>>>
Am Wed, 29 Mar 2017 18:43
Hello Mauro!
> Yeah, it would be great if Ralph would have some time to review
> them, or to submit a new series adding all pending features from
> DD drivers upstream.
I am pretty sure he will not do that.
> Both Jasmin and Thomas could have reviewed it, and replied
> if they tested it, and on w
Hello Mauro!
> Please check the patch with checkpatch.pl:
I am nearly finished with a V2 series of this set, where I partly changed
some of this issues.
We decided to split the monster thread function into a sub function to make it
more readable and also to overcome the 80 line length limit which
Hello Mauro!
> We decided to split the monster thread function into a sub function to make
> it more readable and also to overcome the 80 line length limit ...
Sorry I mixed the patches. I will cleanup this patch to make checkpatch silent.
BR,
Jasmin
From: Ralph Metzler
Some CAMs do a really slow initialization, which requires a longer timeout
for the first response.
Original code change by Ralph Metzler, modified by Jasmin Jessich to match
Kernel code style.
Signed-off-by: Ralph Metzler
Signed-off-by: Jasmin Jessich
---
drivers/media/dv
From: Jasmin Jessich
There were remaining debug prints which haven't been found earlier due to
the disabled buffer mode (see commit "Removed useless printing in cxd2099
driver" for the already removed printings.
Signed-off-by: Jasmin Jessich
---
drivers/staging/media/cxd2099/cxd2099.c | 3 ---
From: Jasmin Jessich
Activate the cxd2099 buffer mode.
Signed-off-by: Jasmin Jessich
---
drivers/staging/media/cxd2099/cxd2099.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/media/cxd2099/cxd2099.c
b/drivers/staging/media/cxd2099/cxd2099.c
index 3431cf
From: Ralph Metzler
The buffer mode was already implemented in this driver, but it did not work
as expected. This has been fixed now, but it is still deactivated and can
be activated by removing a comment at the begin of the file.
Original code change by Ralph Metzler, modified by Jasmin Jessich
From: Ralph Metzler
campoll and read_data are called very often and the printouts are very
annoying and make the driver unusable. They seem to be left over from
developing the buffer mode.
Original code change by Ralph Metzler, modified by Jasmin Jessich to
match current Kernel code.
Signed-off
From: Ralph Metzler
Some lower level drivers may work better when sending blocks of data
instead byte per byte. For this we need new function pointers in the
dvb_ca_en50221 protocol structure (read_data, write_data) and the protocol
needs to execute them, if they are defined.
Block data transmiss
From: Jasmin Jessich
This is now the V2 version of the patch series with preserved author and
little checkpatch fixes. I also combined some patches which needs to be
applied at once to.
Changes from v1 to v2:
- Preserved authorship of original author.
- All patches tested with checkpatch.pl (n
From: Ralph Metzler
In case of a linkinit failure change to state UNINITIALISED to re-init
the CAM.
Original code change by Ralph Metzler, modified by Jasmin Jessich to match
Kernel code style.
Signed-off-by: Ralph Metzler
Signed-off-by: Jasmin Jessich
---
drivers/media/dvb-core/dvb_ca_en502
Hello!
It is now 6,5 years since this eMail ir reply to and a lot of things changed
since then.
As there is currently a lot of effort done to get the newest version of the DD
(Digital Devices) drivers into the Kernel, I want to bring up this topic again.
Yes, this eMail is long but it is necessar
Hello!
> This series adds drivers for the ST STV0910 DVB-S/S2 demodulator ICs and
> the ST STV6111 DVB-S/S2 tuners, and utilises them to enable ddbridge to
> support the current line of Digital Devices DVB-S/S2 hardware (e.g. Cine
> S2 V7/V7A adapters, DuoFlex S2 V4 addon modules and maybe more, w
Hello!
I tried to compile the last media master for Kernel 3.13 (Ubuntu 14.04) and get
errors during the patch step:
tar xfj linux-media.tar.bz2
rm -f .patches_applied .linked_dir .git_log.md5
make -C /mnt/home_hdd/jasmin/vdr/dd_driver/git/media_build/v4l stagingconfig
make[1]: Entering directo
Hello Hans!
> It suggests you are using an old media_build.
No I am not, but I found another problem.
We have changed a driver and the patches needs to be adapted for that.
Sorry to bother you.
BR,
Jasmin
From: Jasmin Jessich
Fixed all:
ERROR: do not use assignment in if condition
Signed-off-by: Jasmin Jessich
---
drivers/media/dvb-core/dvb_ca_en50221.c | 97 ++---
1 file changed, 64 insertions(+), 33 deletions(-)
diff --git a/drivers/media/dvb-core/dvb_ca_en50221
From: Jasmin Jessich
Fixed most of:
WARNING: line over 80 characters
The remaining lines are printk strings, which should not be split and
lines where I thing they should stay as they are.
Signed-off-by: Jasmin Jessich
---
drivers/media/dvb-core/dvb_ca_en50221.c | 57 +---
From: Jasmin Jessich
Fixed all:
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Jasmin Jessich
---
drivers/media/dvb-core/dvb_ca_en50221.c | 30 --
1 file changed, 12 insertions(+), 18 deletions(-)
diff --git a/drivers/media/dvb-co
From: Jasmin Jessich
The CAM poll code for the budget-av is exactly the same on several
places. Extracting the code to a new function improves maintainability.
Signed-off-by: Jasmin Jessich
---
drivers/media/dvb-core/dvb_ca_en50221.c | 63 ++---
1 file changed, 34 i
From: Jasmin Jessich
Fixed all:
WARNING: Missing a blank line after declarations
Signed-off-by: Jasmin Jessich
---
drivers/media/dvb-core/dvb_ca_en50221.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/media/dvb-core/dvb_ca_en50221.c
b/drivers/media/dvb-
From: Jasmin Jessich
These patch series is the V2 version adapted to the already merged patches
from V1 and other merged patches. It does no longer rename constants, as
stated by Mauro as a no-go. It still fixed nearly all the style issues
reported by checkpatch.pl in dvb-core/dvb_ca_en50221.c,
From: Jasmin Jessich
Fixed all:
WARNING: Block comments use * on subsequent lines
Signed-off-by: Jasmin Jessich
---
drivers/media/dvb-core/dvb_ca_en50221.c | 21 +
1 file changed, 13 insertions(+), 8 deletions(-)
diff --git a/drivers/media/dvb-core/dvb_ca_en50221.c
b/dr
From: Jasmin Jessich
Fixed all:
WARNING: msleep < 20ms can sleep for up to 20ms
by using usleep_range.
Signed-off-by: Jasmin Jessich
---
drivers/media/dvb-core/dvb_ca_en50221.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/dvb-core/dvb_ca_en50221.c
b/
From: Jasmin Jessich
Used a helper variable "struct dvb_ca_slot *sl" instead of
"ca->slot_info[slot]". This reduces the line length and simplifies
code reading.
Signed-off-by: Jasmin Jessich
---
drivers/media/dvb-core/dvb_ca_en50221.c | 187 ++--
1 file changed, 106
From: Jasmin Jessich
Refactored "dvb_ca_en50221_thread" by moving the state machine into the
new function "dvb_ca_en50221_thread_state_machine". This reduces the
thread function size and reduces the structural complexity and of course
gives us more space to meet the line length goal in the new fu
Hello Antti!
> Quickly looking this patch serie I noticed few other coding style mistakes.
> You should read kernel coding style documentation first, and then make
> changes according to doc.
In fact I used checkpatch.pl to find the issues and fixed them. All the patches
are 100% checkpatch.pl tes
Hello Antti!
> Have you ever looked that coding style doc?
Yes I read it several times already and used it in my daily work in my
previous company.
Beside the Multi-line comment style, which I will fix in a follow up,
you mentioned other issues.
Please can you tell me which one you mean, so that
Hello Antti!
> actually it reports, when run --strict mode
I checked this once, but I thought this would be too aggressive changes.
>> * many cases where if (ret != 0), which generally should be written as if
>> (ret). If you expect it is just error ret value, then prefer if (ret), but
>> if> ret
From: Jasmin Jessich
- Running "checkpatch.pl -strict -f ..." complained
* Please don't use multiple blank lines
Signed-off-by: Jasmin Jessich
---
drivers/media/dvb-core/dvb_ca_en50221.c | 40 -
1 file changed, 40 deletions(-)
diff --git a/drivers/media/dvb-c
From: Jasmin Jessich
Fixed most of:
WARNING: line over 80 characters
The remaining lines are printk strings, which should not be split and
lines where I thing they should stay as they are.
Signed-off-by: Jasmin Jessich
---
drivers/media/dvb-core/dvb_ca_en50221.c | 57 +++-
From: Jasmin Jessich
Some EXPORT_SYMBOL() on this file don't match the name of functions
that precedes them.
Signed-off-by: Jasmin Jessich
---
drivers/media/dvb-core/dvb_ca_en50221.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/media/dvb-core/dvb_ca_en50221.
From: Jasmin Jessich
- "dont" -> "don't"
Signed-off-by: Jasmin Jessich
---
drivers/media/dvb-core/dvb_ca_en50221.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/dvb-core/dvb_ca_en50221.c
b/drivers/media/dvb-core/dvb_ca_en50221.c
index 8c0c730..aba80d8 1
From: Jasmin Jessich
- Changed all C++ style comments ("// ..") to C style ones ("/* .. */").
Signed-off-by: Jasmin Jessich
---
drivers/media/dvb-core/dvb_ca_en50221.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/media/dvb-core/dvb_ca_en5
From: Jasmin Jessich
- The STATUSREG_TXERR definition is not used and it has style
problems, too. Removing it seems to solve both issues.
Signed-off-by: Jasmin Jessich
---
drivers/media/dvb-core/dvb_ca_en50221.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/dvb-core/dvb
From: Jasmin Jessich
- Added the missing opening empty comment line.
Signed-off-by: Jasmin Jessich
---
drivers/media/dvb-core/dvb_ca_en50221.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media/dvb-core/dvb_ca_en50221.c
b/drivers/media/dvb-core/dvb_ca_en50221.
From: Jasmin Jessich
Fixed all:
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Jasmin Jessich
---
drivers/media/dvb-core/dvb_ca_en50221.c | 30 --
1 file changed, 12 insertions(+), 18 deletions(-)
diff --git a/drivers/media/dvb-co
From: Jasmin Jessich
Fixed all:
WARNING: Block comments use * on subsequent lines
Added also the missing opening empty comment line.
Signed-off-by: Jasmin Jessich
---
drivers/media/dvb-core/dvb_ca_en50221.c | 29 +++--
1 file changed, 19 insertions(+), 10 deletions(-)
From: Jasmin Jessich
Used a helper variable "struct dvb_ca_slot *sl" instead of
"ca->slot_info[slot]". This reduces the line length and simplifies
code reading.
Fixed also "-strict" checks in this patch:
- Comparison to NULL written as "!".
Signed-off-by: Jasmin Jessich
---
drivers/media/dvb-
1 - 100 of 214 matches
Mail list logo
