is not released until the register read is done.
Signed-off-by: Andy Walls awa...@md.metrocast.net
Good catch.
Acked-by: Jean Delvare kh...@linux-fr.org
Note that cx25840_and_or() still has a (smaller and less dangerous)
race window. If several calls to cx25840_and_or() happen in parallel
On Tue, 20 Jul 2010 08:35:26 -0400, Andy Walls wrote:
On Tue, 2010-07-20 at 08:42 +0200, Jean Delvare wrote:
Hi Andy,
On Mon, 19 Jul 2010 21:11:46 -0400, Andy Walls wrote:
There was a small window between writing the cx25840 register
address over the i2c bus and reading the register
-by: Kyungmin Park kyungmin.p...@samsung.com
CC: Tobias Lorenz tobias.lor...@gmx.net
CC: Joonyoung Shim jy0922.s...@samsung.com
CC: Douglas Schilling Landgraf dougsl...@redhat.com
CC: Jean Delvare kh...@linux-fr.org
---
drivers/media/radio/si470x/radio-si470x-i2c.c |2 +-
1 files changed, 1
These variables are either unconditionally set right afterward, or
already set to 0 by kzalloc.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Steven Toth st...@kernellabs.com
---
drivers/media/dvb/frontends/cx22702.c |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
--- linux
The init sequence never changes so it can be marked const. Likewise,
cx22702_ops is a template and can thus be made read-only.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Steven Toth st...@kernellabs.com
---
drivers/media/dvb/frontends/cx22702.c |6 +++---
1 file changed, 3 insertions
Hi Mauro,
On Fri, 10 Sep 2010 12:13:32 -0300, Mauro Carvalho Chehab wrote:
Em 10-09-2010 10:27, Jean Delvare escreveu:
* Avoid temporary variables.
* Optimize success paths.
* Make error messages consistently verbose.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Steven Toth st
subsystem.
Once we fixed these remaining users of the i2c-id.h defines, then Jean can
remove that header together with the adapter's 'id' field.
That would be very great. In all honesty I didn't expect it to happen
so fast, but if that happens, I'll be very happy! :) Thanks!
--
Jean Delvare
.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
. After that, I can kill the whole thing without a thinking and
without the need to explain why it is safe to do - because it will be
totally obvious then.
Thanks a lot for your work!
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message
Commit 8dc09004978538d211ccc36b5046919489e30a55 assumes that
dev-rc_input_dev is always set. It is, however, NULL if dvb-usb was
loaded with option disable_rc_polling=1.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Mauro Carvalho Chehab mche...@redhat.com
---
drivers/media/dvb/dvb-usb
more good reason to use module aliases where possible,
BTW... Respecting user-defined blacklisting is desirable.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
On Sun, 26 Sep 2010 16:25:53 +0200, Jean Delvare wrote:
Commit 8dc09004978538d211ccc36b5046919489e30a55 assumes that
dev-rc_input_dev is always set. It is, however, NULL if dvb-usb was
loaded with option disable_rc_polling=1.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Mauro Carvalho
Detection class I2C_CLASS_TV_ANALOG is set by a few adapters but no
I2C device driver is setting it anymore, which means it can be
dropped. I2C devices on analog TV adapters are instantiated
explicitly these days, which is much better.
Signed-off-by: Jean Delvare kh...@linux-fr.org
---
drivers
Detection class I2C_CLASS_TV_DIGITAL is set by many adapters but no
I2C device driver is setting it anymore, which means it can be
dropped. I2C devices on digital TV adapters are instantiated
explicitly these days, which is much better.
Signed-off-by: Jean Delvare kh...@linux-fr.org
---
drivers
Commit a90f933507859941c4a58028d7593a80f57895c4 accidentally removed
the piece of code setting the i2c algo pointer. Restore it.
That's what happens when you put two code statements on the same
line...
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Mauro Carvalho Chehab mche...@redhat.com
the code in question never
runs. As the code additionally expects that I2C_HW_B_HDPVR may not
be defined, we can delete it now and let the lirc_zilog driver
maintainer rewrite this piece of code.
Big thanks for Hans Verkuil for doing all the hard work :)
Signed-off-by: Jean Delvare kh...@linux
Drivers don't need to include linux/i2c-id.h, especially not when
they don't use anything that header file provides.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Michael Hunold mich...@mihu.de
Cc: Mauro Carvalho Chehab mche...@infradead.org
---
drivers/media/common/saa7146_i2c.c|1
It's about time to make it clear that i2c_adapter.id is deprecated.
Hopefully this will remind the last user to move over to a different
strategy.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Hans Verkuil hverk...@xs4all.nl
Cc: Jarod Wilson ja...@redhat.com
---
drivers/i2c/i2c-mux.c |1
) and properly return error on adapter registration failure.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Michel Ludwig michel.lud...@gmail.com
Cc: Stefan Ringel stefan.rin...@arcor.de
---
Untested, I don't have the hardware.
drivers/staging/tm6000/tm6000-i2c.c | 27
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Michel Ludwig michel.lud...@gmail.com
Cc: Stefan Ringel stefan.rin...@arcor.de
---
drivers/staging/tm6000/tm6000-i2c.c | 12
1 file changed, 12 deletions(-)
--- linux-2.6.36-rc7.orig/drivers/staging/tm6000/tm6000-i2c.c 2010-10
for this, as there are 5
other drivers doing the same.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, 13 Nov 2010 12:34:23 -0200, Mauro Carvalho Chehab wrote:
Em 05-11-2010 18:07, Jean Delvare escreveu:
Drivers don't need to include linux/i2c-id.h, especially not when
they don't use anything that header file provides.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Michael
Hi Wolfram,
Sorry for the late answer.
On Mon, 15 Nov 2010 23:28:15 +0100, Wolfram Sang wrote:
On Wed, Nov 10, 2010 at 03:14:13PM +0100, Wolfram Sang wrote:
The i2c-core does this already.
Reported-by: Jean Delvare kh...@linux-fr.org
Signed-off-by: Wolfram Sang w.s...@pengutronix.de
((.\n));
Looks correct.
Acked-by: Jean Delvare kh...@linux-fr.org
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
-driven system wakeups
Signed-off-by: Randy Dunlap rdun...@xenotime.net
Reported-by: Johannes Berg johan...@sipsolutions.net
Cc: Jean Delvare kh...@linux-fr.org
Cc: Tony Lindgren t...@atomide.com
Cc: Grant Likely grant.lik...@secretlab.ca
Signed-off-by: Luciano Coelho coe...@ti.com
---
I
Dunlap rdun...@xenotime.net
Reported-by: Johannes Berg johan...@sipsolutions.net
Cc: Jean Delvare kh...@linux-fr.org
Cc: Tony Lindgren t...@atomide.com
Cc: Grant Likely grant.lik...@secretlab.ca
Signed-off-by: Luciano Coelho coe...@ti.com
---
I guess this should fix the problem. I've
+ depends on INPUT
+ select INPUT_POLLDEV
+ default n
+
If you patch gets applied, then this one would better be moved to
drivers/misc/lis3lv02d/Kconfig.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord
to Samuel to decide which patch he wants to apply.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 5 Sep 2011 16:19:35 +0200, Arnd Bergmann wrote:
On Monday 05 September 2011, Jean Delvare wrote:
As said before, I'm not sure. Yes, it makes it easier to select misc
device drivers from Kconfig files. But it also makes it impossible to
deselect all misc device drivers at once
(client, reg);
+
Stray blank line.
}
(...)
Other than this, looks all OK:
Acked-by: Jean Delvare kh...@linux-fr.org
Obviously depends on the i2c patch, which will go upstream during the
next merge window.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media
...@ideasonboard.com
As far as I can tell, this fixes a bug too, the original code would not
work on big-endian machines.
Acked-by: Jean Delvare kh...@linux-fr.org
---
drivers/media/video/mt9p031.c |5 ++---
drivers/media/video/mt9t001.c |5 ++---
2 files changed, 4 insertions(+), 6
it looks strange to update code which is
apparently disabled for quite a while...)
Acked-by: Jean Delvare kh...@linux-fr.org
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
here */
{ ir_rx_z8f0811_haup, 0 },
+ { ir_rx_z8f0811_hdpvr, 0 },
{ }
};
Acked-by: Jean Delvare kh...@linux-fr.org
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info
-ir_lock);
mutex_init(ir-buf_lock);
ir-need_boot = 1;
+ ir-is_hdpvr = (id-driver_data ID_FLAG_HDPVR) ? true : false;
memcpy(ir-l, lirc_template, sizeof(struct lirc_driver));
ir-l.minor = -1;
--
Jean Delvare
--
To unsubscribe from this list: send the line
to show my support to Andy's
work, I don't care if I'm not counted as a reviewer for these small
patches.
Em 05-01-2011 12:45, Jean Delvare escreveu:
From a purely technical perspective, changing client-addr in the
probe() function is totally prohibited.
Agreed. Btw, there are some other hacks
the main address, and register the secondary addresses
in your probe() function using i2c_new_dummy(). See
drivers/misc/eeprom/at24.c for an example of how this is done.
I'm not sure I understand the problem at hand exactly though, so my
advice might be inappropriate.
--
Jean Delvare
--
To unsubscribe
for the lifetime of the
driver, as you prefer.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
will fail. The
failure documented for the HD PVR simply suggests that the wait loop
isn't long enough. It is 20 * 50 ms currently, i.e. 1 second total,
maybe this isn't sufficient. Have you ever tried a longer delay?
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe
On Wed, 05 Jan 2011 20:02:41 -0200, Mauro Carvalho Chehab wrote:
Em 05-01-2011 19:51, Jean Delvare escreveu:
If you have specific cases you don't know how to solve, please point me
to them and I'll take a look.
You can take a look at saa7134-cards.c, for example. saa7134_tuner_setup()
has
stretching by slaves. Apparently
it doesn't support repeated start conditions either, so it wouldn't
surprise me.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
On Thu, 13 Jan 2011 12:07:34 -0500, Devin Heitmueller wrote:
On Thu, Jan 13, 2011 at 11:48 AM, Jean Delvare kh...@linux-fr.org wrote:
On Thu, 13 Jan 2011 11:34:42 -0500, Andy Walls wrote:
How should clock stretches by slaves be handled using i2c-algo-bit?
It is already handled. But hdpvr
behavior
of IR receive with hdpvr hardware.
Maybe. But the fact that the Zilog is unresponsive during processing of
sent data certainly contributes to this feeling too.
Reported-by: Jean Delvare kh...@linux-fr.org
Signed-off-by: Jarod Wilson ja...@redhat.com
---
Nb: This patch was done
-i2c_buf)) [Jean Delvare]
Reported-by: Jean Delvare kh...@linux-fr.org
Signed-off-by: Jarod Wilson ja...@redhat.com
Acked-by: Jean Delvare kh...@linux-fr.org
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord
for probing purpose.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
and pvrusb2 currently do the former.
Yes, that's exactly how things are supposed to work now. And hopefully
it makes sense and helps you all write cleaner code (that was the
intent at least.)
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body
TX-oriented for a mutex that is supposed to synchronize TX and RX
access. It's particularly surprising for the ir-kbd-i2c driver, which
as far as I know only supports RX. The name xcvr_lock you used for
lirc_zilog seems more appropriate.
--
Jean Delvare
--
To unsubscribe from this list: send
On Wed, 19 Jan 2011 09:09:47 -0600 (CST), Mike Isely wrote:
On Wed, 19 Jan 2011, Jean Delvare wrote:
Hi Andy,
On Sun, 16 Jan 2011 14:20:49 -0500, Andy Walls wrote:
3. I hear from Jean, or whomever really cares about ir-kbd-i2c, if
adding some new fields for struct IR_i2c_init_data
On Wed, 19 Jan 2011 12:12:49 -0500, Jarod Wilson wrote:
On Jan 19, 2011, at 8:50 AM, Jean Delvare wrote:
Hi Andy,
On Wed, 19 Jan 2011 08:38:02 -0500, Andy Walls wrote:
As I understand it, the rules/guidelines for I2C probing are now
something like this:
1. I2C device driver
44835f197bf1e3f57464f23dfb239fef06cf89be
Author: Jean Delvare kh...@linux-fr.org
Date: Sun Jul 18 16:52:05 2010 -0300
V4L/DVB: cx23885: Check for slave nack on all transactions
Don't just check for nacks on zero-length transactions. Check on
other transactions too.
Signed-off-by: Jean Delvare kh
/cx25840/cx25840-core.c |3 ++-
2 files changed, 2 insertions(+), 11 deletions(-)
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
The ability to force the encoder or decoder chip was broken by commit
0ab6e1c38d80ab586e3a1ca9e71844131d9f51dc in February 2009. As nobody
complained for over 2 years, I take it that these parameters were no
longer used so we can simply drop them.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc
(i2c_adapter, msgs, num);
Note that you lose the automatic retry mechanism though. That being
said, I don't think this is the right approach in general, as explained
above.
Hope I helped a bit, if you have more questions, feel free!
--
Jean Delvare
--
To unsubscribe from this list: send the line
Hi Mauro,
Sorry for the late reply.
On Thu, 05 May 2011 13:18:04 -0300, Mauro Carvalho Chehab wrote:
Em 05-05-2011 12:09, Jean Delvare escreveu:
Hi Mauro, Steven,
On Thu, 05 May 2011 10:15:04 -0300, Mauro Carvalho Chehab wrote:
As you pointed, there are two ways of solving this issue
in
this driver.
Signed-off-by: Jean Delvare jdelv...@suse.de
Cc: Mauro Carvalho Chehab mche...@infradead.org
Cc: Fabio Belavenuto belaven...@gmail.com
---
drivers/media/radio/radio-tea5764.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-3.0-rc6.orig/drivers/media/radio/radio
Hi Andy,
On Friday 08 July 2011 12:34:38 pm Andy Walls wrote:
Jean Delvare jdelv...@suse.de wrote:
The third parameter of module_param is supposed to represent sysfs
file permissions. A value of 1 leads to the following:
$ ls -l /sys/module/radio_tea5764/parameters/
total 0
-x 1
on a system when you
try to identify it.
At this point, I see the work needed to review your patches, the risk
of regressions due to the large size of the patch set, but I don't see
any immediate benefit. Thus I am not going to look into it at all,
sorry.
--
Jean Delvare
--
To unsubscribe from this list
by Jean
Delvare before I post that one as well.
Testing complete, it seems to work just fine. Thanks!
- Added support for saa6588 to saa7134: needed to drop the legacy i2c API
from saa6588. This is in my pull request for my v4l-dvb tree.
- Douglas has almost finished the em28xx driver
the individual patches are much better.
Thanks,
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
* Return actual error values as returned by the i2c subsystem, rather
than 0 or 1.
* If the registration of the second bus fails, unregister the first one
before exiting, otherwise we are leaking resources.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Hans Verkuil hverk...@xs4all.nl
Cc
In the standard device driver binding model, the name field of
struct i2c_client is used to match devices to their drivers, so we
must stop using it for internal purposes. Define a separate field
in struct IR_i2c as a replacement, and use it.
Signed-off-by: Jean Delvare kh...@linux-fr.org
. This would be more efficient and less risky than always
probing extra addresses on all boards. I'll give it a try later.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Mauro Carvalho Chehab mche...@infradead.org
Cc: Hans Verkuil hverk...@xs4all.nl
Cc: Andy Walls awa...@radix.net
Cc: Mike Isely
For specific boards, pass initialization data to ir-kbd-i2c instead
of modifying the settings after the device is initialized. This is
more efficient and easier to read.
Signed-off-by: Jean Delvare kh...@linux-fr.org
---
linux/drivers/media/video/cx231xx/cx231xx-cards.c | 14 ---
linux/drivers
Now that we instantiate I2C IR devices explicitly, we can skip probing
altogether on boards where the I2C IR device address is known. The MSI
t...@nywhere Plus is one of these boards.
Signed-off-by: Jean Delvare kh...@linux-fr.org
---
linux/drivers/media/video/saa7134/saa7134-input.c | 27
Now that we instantiate I2C IR devices explicitly, we can skip probing
altogether on boards where the I2C IR device address is known. The
AVerMedia Cardbus are two of these boards.
Signed-off-by: Jean Delvare kh...@linux-fr.org
---
linux/drivers/media/video/saa7134/saa7134-input.c | 35
Hi Andy,
Thanks for the fast review.
On Sat, 04 Apr 2009 08:46:00 -0400, Andy Walls wrote:
On Sat, 2009-04-04 at 14:26 +0200, Jean Delvare wrote:
* Return actual error values as returned by the i2c subsystem, rather
than 0 or 1.
* If the registration of the second bus fails, unregister
The client_register and client_unregister methods are optional so
there is no point in defining stub ones. Especially when these methods
are likely to be removed soon.
Signed-off-by: Jean Delvare kh...@linux-fr.org
---
linux/drivers/media/video/pvrusb2/pvrusb2-i2c-core.c | 12
1
.
There are some other cleanups I could do, but all the important ones are
now
taken care of.
I would like to take the opportunity to thank Jean Delvare for his support
and his help in testing various drivers and working on ir-kbd-i2c, and
Mauro for processing and merging all my patches. I feel
Hi Andy,
On Sat, 04 Apr 2009 21:50:08 -0400, Andy Walls wrote:
On Sun, 2009-04-05 at 00:51 +0200, Jean Delvare wrote:
On Sat, 04 Apr 2009 09:42:09 -0400, Andy Walls wrote:
I think this is way out of date for cx18 based boards. The only IR chip
I know of so far is the Zilog Z8F0811
have it.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Mike,
Selected answers, as most points have already been discussed elsewhere
meanwhile...
On Sat, 4 Apr 2009 18:29:35 -0500 (CDT), Mike Isely wrote:
On Sun, 5 Apr 2009, Jean Delvare wrote:
This is excellent news. As I said in the header comment of the patch,
avoiding probing when we know
released, which they can use to fix anything that broke.
Thanks,
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
you're worried about, I'll let
you know what I think about it.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
and not others. And one i2c drivers can
cleanly support more than one device type.
What should be considered to decide whether two devices should be
supported by the same driver or not, is how much their supporting code
has in common.
--
Jean Delvare
--
To unsubscribe from this list: send
sense of this error. Help anyone?
Thanks,
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
need to probe for
the device, I thought it may be OK to remove the extra code. But
probably the removal of the extra code should be delayed until we find
one tester to confirm the exact behavior. Here, done.
Anyone out there with a MSI t...@nywhere Plus that could help with
testing?
--
Jean
is.
Thanks a lot for the testing!
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
saying that we added support for the PVR-150, and that it gets proper
testing. Hiding support addition in a larger patch would probably do
as much harm as good.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
alright. In this specific case I really don't care who gets the
fame and flames, as longs as things get done quickly. Thank you for
jumping in and helping me sorting it all out, this is very appreciated.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media
Hi Andy,
On Mon, 06 Apr 2009 07:56:22 -0400, Andy Walls wrote:
On Mon, 2009-04-06 at 10:54 +0200, Jean Delvare wrote:
Thanks a lot for the testing!
You're welcome.
Sorry for being such a pain to what I suspect you hoped was to be a
simple change.
You must be kidding. For one thing, I
On Mon, 6 Apr 2009 10:32:52 +0200, Jean Delvare wrote:
My latest pull of the v4l-dvb repository this morning broke the build:
make[3]: *** No rule to make target `/home/khali/src/v4l-dvb/v4l/cx88-dsp.o',
needed by `/home/khali/src/v4l-dvb/v4l/tda18271.o'. Stop.
I am building against kernel
just raised.
But all this can be done after the conversion work it finished.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Andy,
On Mon, 06 Apr 2009 21:20:37 -0400, Andy Walls wrote:
On Mon, 2009-04-06 at 17:44 +0200, Jean Delvare wrote:
The bottom line is that we have to instantiate I2C devices for IR
components regardless of the driver which will handle them (ir-kbd-i2c,
lirc_i2c or another one). I can
Hi Mike,
Glad to see we all mostly agree on what to do now. I'll still answer
some of your questions below, to clarify things even more.
On Tue, 7 Apr 2009 01:19:02 -0500 (CDT), Mike Isely wrote:
On Mon, 6 Apr 2009, Jean Delvare wrote:
The bottom line is that we have to instantiate I2C
Hi Mauro,
On Tue, 7 Apr 2009 07:50:29 -0300, Mauro Carvalho Chehab wrote:
On Tue, 7 Apr 2009 12:02:09 +0200
Jean Delvare kh...@linux-fr.org wrote:
Hi Mike,
Glad to see we all mostly agree on what to do now. I'll still answer
some of your questions below, to clarify things even more
On Sat, 04 Apr 2009 08:46:00 -0400, Andy Walls wrote:
On Sat, 2009-04-04 at 14:26 +0200, Jean Delvare wrote:
* Return actual error values as returned by the i2c subsystem, rather
than 0 or 1.
* If the registration of the second bus fails, unregister the first one
before exiting
On Mon, 06 Apr 2009 23:10:36 +0200, hermann pitton wrote:
Am Montag, den 06.04.2009, 10:40 +0200 schrieb Jean Delvare:
Anyone out there with a MSI t...@nywhere Plus that could help with
testing?
Here is a link to one of the initial reports by Henry, others are close
to it.
http
The history of changes does belong to git.
Signed-off-by: Jean Delvare kh...@linux-fr.org
---
In general I wouldn't care too much but it happens that this specific
comment triggers a false positive in one of my scripts, so I'd rather
get rid of it.
linux/drivers/media/video/tda7432.c | 14
On Tue, 7 Apr 2009 17:55:17 +0200, Jean Delvare wrote:
The history of changes does belong to git.
Signed-off-by: Jean Delvare kh...@linux-fr.org
---
In general I wouldn't care too much but it happens that this specific
comment triggers a false positive in one of my scripts, so I'd rather
changes.
The way I'm doing the IR reading is the same as the Windows driver does - I
got the information through the Qemu with pci-proxy patch applied.
Thanks,
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord
Hi Oldrich,
On Thu, 9 Apr 2009 23:12:51 +0200, Oldrich Jedlicka wrote:
On Saturday 04 of April 2009 at 14:31:37, Jean Delvare wrote:
Now that we instantiate I2C IR devices explicitly, we can skip probing
altogether on boards where the I2C IR device address is known. The
AVerMedia Cardbus
* Return actual error values as returned by the i2c subsystem, rather
than 0 or 1.
* If the registration of the second bus fails, unregister the first one
before exiting, otherwise we are leaking resources.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Hans Verkuil hverk...@xs4all.nl
On Fri, 17 Apr 2009 18:16:06 +0200, Oldrich Jedlicka wrote:
Hi Jean,
On Friday 17 of April 2009 at 15:45:20, Jean Delvare wrote:
Hi Oldrich,
On Thu, 9 Apr 2009 23:12:51 +0200, Oldrich Jedlicka wrote:
On Saturday 04 of April 2009 at 14:31:37, Jean Delvare wrote:
[sniff]
@@ -753,6
-IN-ONE.patch
But for review the individual patches are much better.
Thanks,
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
In the standard device driver binding model, the name field of
struct i2c_client is used to match devices to their drivers, so we
must stop using it for internal purposes. Define a separate field
in struct IR_i2c as a replacement, and use it.
Signed-off-by: Jean Delvare kh...@linux-fr.org
. This would be more efficient and less risky than always
probing extra addresses on all boards. I'll give it a try later.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Mauro Carvalho Chehab mche...@infradead.org
Cc: Hans Verkuil hverk...@xs4all.nl
Cc: Andy Walls awa...@radix.net
Cc: Mike Isely
crash on unsupported IR devices. Simply,
the driver will not bind to the unsupported devices.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Andy Walls awa...@radix.net
---
linux/drivers/media/video/ir-kbd-i2c.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
--- v4l
Now that we instantiate I2C IR devices explicitly, we can skip probing
altogether on boards where the I2C IR device address is known. The MSI
t...@nywhere Plus is one of these boards.
Signed-off-by: Jean Delvare kh...@linux-fr.org
---
linux/drivers/media/video/saa7134/saa7134-input.c | 28
Hi again Mike,
On Sat, 18 Apr 2009 11:25:19 +0200, Jean Delvare wrote:
On Fri, 17 Apr 2009 18:35:55 -0500 (CDT), Mike Isely wrote:
I thought we were going to leave the pvrusb2 driver out of this since
I've already got a change ready that also includes additional logic to
take
-by: Guennadi Liakhovetski g.liakhovet...@gmx.de
Looks good to me.
Acked-by: Jean Delvare kh...@linux-fr.org
---
The best way to trigger action is by submitting a patch:-) So, let's see
what comes out of it - on the one hand I don't see any reason why media
has to be linked this early
Hi Mike,
Sorry for the late answer.
On Sat, 18 Apr 2009 08:53:35 -0500 (CDT), Mike Isely wrote:
On Sat, 18 Apr 2009, Jean Delvare wrote:
On Sat, 18 Apr 2009 11:25:19 +0200, Jean Delvare wrote:
Hmm, I thought that our latest discussions had (at least partly)
obsoleted your patches
1 - 100 of 309 matches
Mail list logo
