On Sat, Aug 20, 2016 at 11:54 AM, Martin Blumenstingl
wrote:
> This adds the IR remote receiver to the AO domain devices.
>
> Signed-off-by: Martin Blumenstingl
> Reviewed-by: Kevin Hilman
Patch applied.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "
On Sat, Aug 20, 2016 at 11:54 AM, Martin Blumenstingl
wrote:
> Signed-off-by: Martin Blumenstingl
Acked-by: Linus Walleij
Merge this through the ARM SoC tree.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a mess
th the DT logic... so I guess since it's likely and odd one-off
and the driver is sufficiently weird anyways, it's fine to merge
this patch making it even weirder.
Maybe a sort of mock adapter type should actually be
created in the I2C core for these things so it can be handled
there but wh
ownership between device and CPU explicitly
with dma_map* or so. Did you check with
Documentation/DMA-API.txt?
Yours,
Linus Walleij
On Mon, Jan 29, 2018 at 9:25 AM, Maxime Ripard
wrote:
> On Sat, Jan 27, 2018 at 05:14:26PM +0100, Linus Walleij wrote:
>> > +void sun6i_csi_update_buf_addr(struct sun6i_csi *csi, dma_addr_t addr)
>> > +{
>> > + struct sun6i_csi_dev *sdev = sun6i_csi_to_dev(c
by hardware pin strapping.
Please use the existing binding in
Documentation/devicetree/bindings/display/panel/display-timing.txt
for this: pixelclk-active = [<0>|<1>];
Please reference the above document in your binding.
Yours,
Linus Walleij
deo bridge pins to RGB 18-bit mode.
> +
> +Available pins, groups and functions (reference to device datasheets):
Please reference the generic binding you're using here:
Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt
Apart from these small nitpicks it looks very standard and good.
Yours,
Linus Walleij
et_direction,
> + .direction_input= ds90ux9xx_gpio_direction_input,
> + .direction_output = ds90ux9xx_gpio_direction_output,
> + .base = -1,
> + .can_sleep = 1,
This is bool so set it = true;
Overall it's a very nice driver. It is pretty complex but pin control
is complex so that's a fact of life.
Yours,
Linus Walleij
This adds a pointer to the CEC GPIO driver from the GPIO list of
examples of drivers on top of GPIO.
Cc: Hans Verkuil
Cc: linux-media@vger.kernel.org
Signed-off-by: Linus Walleij
---
Documentation/driver-api/gpio/drivers-on-gpio.rst | 4
1 file changed, 4 insertions(+)
diff --git a
t; + int reset_gpio;
> + int reset_active;
> + int irq_gpio;
> + int irq;
> + int sleepst_gpio;
> + int sleepst_irq;
> + int wakeup_gpio;
> + int wakeup_active;
> + int powerdown_gpio;
> + int powerdown_active;
Anything that us a GPIO should be a struct gpio_desc *.
You do not need to keep track of if they are active I guess,
but I haven't looked close. They should probably be bool
rather than int if necessary.
But notice that we have
gpiod_get_optional() and if you use that you can
just check if the gpio_desc * is NULL like
if (!pdata->wakeup_gpio)
gpiod_set_value() ...
Yours,
Linus Walleij
eset pin;
Also get rid of the custom names here, either no lines should
have a "rockchip", prefix or all of them. Use the name of the
pin on the component, I suspect just
powerdown0-gpios
reset0-gpios
etc
By using the standard "*-gpios" suffix the kernel consumer API
will be much happier as well when you use gpiod_get() & friends.
Yours,
Linus Walleij
ack the video on your PC.
>
> mplayer ./stream.out -loop 0 -demuxer rawvideo -rawvideo
> w=640:h=480:size=$((640*480*3/2)):format=NV12
>
> Changes V3:
> - Instead use the new GPIO API.
This is looking really nice from a GPIO point of view!
Reviewed-by: Linus
On Thu, Dec 29, 2016 at 11:27 PM, Steve Longerbeam
wrote:
> Add optional reset-gpios pin control. If present, de-assert the
> specified reset gpio pin to bring the chip out of reset.
>
> Signed-off-by: Steve Longerbeam
> Cc: Linus Walleij
> Cc: Alexandre Cour
On Mon, Apr 3, 2017 at 10:38 AM, Peter Rosin wrote:
> i2c_mux_add_adapter already logs a message on failure.
>
> Signed-off-by: Peter Rosin
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
ive high is implicit.
Yours,
Linus Walleij
;;
> + hpd-gpio = <&gpio 17 GPIO_ACTIVE_HIGH>;
hpd-gpios = ..
With these fixups:
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
But of course it can also be used with any hardware project where the
> HDMI CEC line is hooked up to a pull-up gpio line.
>
> In addition this has (optional) support for tracing HPD changes if the
> HPD is connected to a GPIO.
>
> Signed-off-by: Hans Verkuil
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
ove IN flag.
But as said above, maybe you are looking for an open drain
output actually.
> + if (cec->hpd_gpio >= 0) {
> + cec->hpd_irq = gpio_to_irq(cec->hpd_gpio);
> + gpio_direction_input(cec->hpd_gpio);
Already done if you pass the right flag. This should be IN for sure.
Use gpiod_to_irq().
Please include me on subsequent posts, I want to try to use
descriptors as much as possible for new drivers.
Yours,
Linus Walleij
cec-gpio = <&gpio 7 GPIO_ACTIVE_HIGH>;
> + hpd-gpio = <&gpio 17 GPIO_ACTIVE_HIGH>;
> +};
So what I understood from the driver is that the cec-gpio is maybe actually
an open drain output line, so in that case it should be stated in the docs and
cec-gpio = <&gpio 7 GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN>
or GPIO_LINE_OPEN_DRAIN if it is not also single-ended.
Yours,
Linus Walleij
On Thu, Aug 31, 2017 at 1:01 PM, Hans Verkuil wrote:
> From: Hans Verkuil
>
> Document the bindings for the cec-gpio module for hardware where the
> CEC line and optionally the HPD line are connected to GPIO lines.
>
> Signed-off-by: Hans Verkuil
Reviewed-by: Linus Wall
But of course it can also be used with any hardware project where the
> HDMI CEC line is hooked up to a pull-up gpio line.
>
> In addition this has (optional) support for tracing HPD changes if the
> HPD is connected to a GPIO.
>
> Signed-off-by: Hans Verkuil
This looks nice!
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
into DSP accelerators and provide control/datapath for that, this can
in turn be used by some camera or codec which in turn presents a
V4L2 or ALSA interface.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to major
en you re-spin the HWMEM patchset, can you include
linaro-dev and linux-media in the CC? I think there is *much* interest
in this mechanism, people just don't know from the name what it
really does. Maybe it should be called mediamem or something
instead...
Yours,
Linus Walleij
--
To unsubscribe
Hi Mauro,
On Tue, Sep 10, 2013 at 2:31 PM, Linus Walleij wrote:
> The lirc serial module has special hooks to work with NSLU2,
> switch these over to use gpiolib, as that is available on the
> ixp4 platform.
>
> Not even compile tested as there is no way to select this
> driv
On Fri, Sep 13, 2013 at 9:14 AM, Linus Walleij wrote:
> Hi Mauro,
>
> On Tue, Sep 10, 2013 at 2:31 PM, Linus Walleij
> wrote:
>
>> The lirc serial module has special hooks to work with NSLU2,
>> switch these over to use gpiolib, as that is available on the
>&
On Sat, Sep 28, 2013 at 8:21 PM, Tomasz Figa wrote:
> Since CONFIG_PLAT_S3C64XX is going to be removed, this patch modifies
> the gpio-samsung driver to use the proper way of checking for S3C64xx
> support - CONFIG_ARCH_S3C64XX.
>
> Signed-off-by: Tomasz Figa
Acked-by: Linus Wal
of this driver
adapt to whatever platform data registration mechanism is
in place for the merge window. Else it needs fixing as part
of a bigger endavour to root out compile-time platform
configuration.
Yours
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe l
-off-by: Andrew F. Davis
Patch applied. Strange that this went unnoticed for years.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
lso necessary because the flag parameter will become mandatory
> soon.
>
> Signed-off-by: Uwe Kleine-König
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@
Signed-off-by: Uwe Kleine-König
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
This makes the driver use the data pointer added to the gpio_chip
to store a pointer to the state container instead of relying on
container_of().
Cc: Antti Palosaari
Cc: Mauro Carvalho Chehab
Cc: linux-media@vger.kernel.org
Signed-off-by: Linus Walleij
---
Mauro: please ACK this so I can merge
>
> WARNING: Symbol version dump /home/mcgrof/linux-next/Module.symvers
>is missing; modules will have no dependencies and modversions.
>
> LD drivers/crypto/ux500/built-in.o
> Building modules, stage 2.
> MODPOST 0 modules
>
> C
the I2C driver and replace all things
that look like this:
ret = wait_for_completion_interruptible_timeout(&dev->cmd_complete, HZ);
With this:
ret = wait_for_completion_timeout(&dev->cmd_complete, HZ);
(Non-interruptible.)
This is usually the problem.
Yours,
Linus Walleij
--
stub
clocks and stub regulators, are perfectly legal, just that they have
no effect.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ou as of commit
ab78029ecc347debbd737f06688d788bd9d60c1d
"drivers/pinctrl: grab default handles from device core"
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info a
On Wed, Nov 27, 2013 at 5:40 PM, Laurent Pinchart
wrote:
> (CC'ing Linus Walleij, Wolfram Sang and LAKML)
> On Wednesday 27 November 2013 16:32:01 Valentine wrote:
>> On 11/27/2013 04:14 PM, Hans Verkuil wrote:
>> > Yes, of course. Although the adv7604 has two
On Fri, Nov 29, 2013 at 11:45 AM, Lars-Peter Clausen wrote:
> On 11/29/2013 11:37 AM, Linus Walleij wrote:
(...)
>> Specifically you should be able to request an IRQ from the irq_chip
>> portions of the driver without first requesting the GPIO line.
>>
>> Some d
On Fri, Nov 29, 2013 at 1:14 PM, Valentine
wrote:
> On 11/29/2013 02:45 PM, Lars-Peter Clausen wrote:
>> On 11/29/2013 11:37 AM, Linus Walleij wrote:
>>> So I guess the answer to the question is something like, fix
>>> the GPIO driver to stop requiring the GPIO li
On Fri, Nov 29, 2013 at 2:48 PM, Lars-Peter Clausen wrote:
> On 11/29/2013 02:42 PM, Linus Walleij wrote:
>> On Fri, Nov 29, 2013 at 11:45 AM, Lars-Peter Clausen wrote:
>>>
>>> As far as I understand it this already works more or less with the driver.
>>> The
On Fri, Nov 29, 2013 at 9:05 PM, Lars-Peter Clausen wrote:
> On 11/29/2013 08:52 PM, Linus Walleij wrote:
>> I guess you may be referring to the problem of instatiating
>> a dynamic IRQ chip in *board code* and then passing the
>> obtained dynamic IRQ numbers as resources t
was based on
> "A31s Datasheet v1.40.pdf", but all other A31 related info puts them at the
> pins where we already have them, so leave this as is
Patch applied with Maxime's ACK.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe
dd some missing functions"
> -Add myself to the copyright header
Patch applied with Maxime's ACK.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
> sound/soc/codecs/wm5100.c | 5 +
> sound/soc/codecs/wm8903.c | 6 +-
> sound/soc/codecs/wm8962.c | 5 +
> sound/soc/codecs/wm8996.c | 6 +-
Liam || Mark can you ACK this?
Y
43 matches
Mail list logo
