Re: Can I expect in-kernel decoding to work out of box?

On Wed, 2010-07-28 at 10:13 -0300, Mauro Carvalho Chehab wrote: Em 28-07-2010 07:40, Jon Smirl escreveu: On Wed, Jul 28, 2010 at 2:30 AM, Maxim Levitsky maximlevit...@gmail.com wrote: On Tue, 2010-07-27 at 22:33 -0400, Jarod Wilson wrote: On Tue, Jul 27, 2010 at 9:29 PM, Jon Smirl jonsm

[PATCH 1/9] IR: Kconfig fixes

Move IR drives below separate menu. This allows to disable them. Also correct a typo. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/Kconfig | 14 +++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/media/IR/Kconfig b/drivers/media

[PATCH 2/9] IR: minor fixes:

* lirc: Don't propagate reset event to userspace * lirc: Remove strange logic from lirc that would make first sample always be pulse * Make TO_US macro actualy print what it should. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-core-priv.h |3 +-- drivers

[PATCH 3/9] IR: replace spinlock with mutex.

Some handlers (lirc for example) allocates memory on initialization, doing so in atomic context is cumbersome. Fixes warning about sleeping function in atomic context. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-raw-event.c | 28 ++-- 1

[PATCH 4/9] IR: add helper functions for ir input devices that send ir timing data in small chunks, and alternation between pulses and spaces isn't guaranteed.

Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-core-priv.h |1 + drivers/media/IR/ir-keytable.c |2 +- drivers/media/IR/ir-raw-event.c | 86 +++ include/media/ir-core.h | 24 +- 4 files changed, 109

[PATCH 5/9] IR: extend interfaces to support more device settings

Also reuse LIRC_SET_MEASURE_CARRIER_MODE as LIRC_SET_LEARN_MODE (LIRC_SET_LEARN_MODE will start carrier reports if possible, and tune receiver to wide band mode) This IOCTL isn't yet used by lirc, so this won't break userspace. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers

[PATCH 6/9] IR: actually allow not to compile keymaps in..

Currntly, ir device registration fails if keymap requested by driver is not found... Fix that by always compiling in the empty keymap, and using it as a failback Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-core-priv.h |3 +- drivers/media/IR/ir-sysfs.c

[PATCH 7/9] IR: actualy report unknown scancodes the in-kernel decoders found.

This way it is possible to use evtest to create keymap for unknown remote. (Providing that in-kernel decoding understands remote's protocol. Hint: it doesn't) Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-keytable.c |5 + 1 files changed, 5

[PATCH 8/9] IR: Add ENE input driver.

Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/Kconfig | 11 + drivers/media/IR/Makefile |1 + drivers/media/IR/ene_ir.c | 1019 + drivers/media/IR/ene_ir.h | 228 ++ 4 files changed, 1259 insertions(+), 0

Re: [PATCH 4/9] IR: add helper functions for ir input devices that send ir timing data in small chunks, and alternation between pulses and spaces isn't guaranteed.

On Wed, 2010-07-28 at 13:09 -0300, Mauro Carvalho Chehab wrote: Em 28-07-2010 12:14, Maxim Levitsky escreveu: Please provide a smaller subject. Feel free to add a more detailed description, but subjects longer then 74 bytes end by causing some troubles when using git commands. I didn't

Re: [PATCH 3/9] IR: replace spinlock with mutex.

On Wed, 2010-07-28 at 13:03 -0300, Mauro Carvalho Chehab wrote: Em 28-07-2010 12:14, Maxim Levitsky escreveu: Some handlers (lirc for example) allocates memory on initialization, doing so in atomic context is cumbersome. Fixes warning about sleeping function in atomic context. You should

Re: [PATCH 2/9] IR: minor fixes:

On Wed, 2010-07-28 at 13:01 -0300, Mauro Carvalho Chehab wrote: Em 28-07-2010 12:14, Maxim Levitsky escreveu: * lirc: Don't propagate reset event to userspace * lirc: Remove strange logic from lirc that would make first sample always be pulse * Make TO_US macro actualy print what

Re: [PATCH 8/9] IR: Add ENE input driver.

On Wed, 2010-07-28 at 14:10 -0300, Mauro Carvalho Chehab wrote: Em 28-07-2010 12:14, Maxim Levitsky escreveu: Signed-off-by: Maxim Levitsky maximlevit...@gmail.com Please, instead of patch 9/9, do a patch moving ENE driver from staging into drivers/media/IR, and then a patch porting

Re: Can I expect in-kernel decoding to work out of box?

On Wed, 2010-07-28 at 17:13 -0300, Mauro Carvalho Chehab wrote: Andy, Em 28-07-2010 15:18, Andy Walls escreveu: On Wed, 2010-07-28 at 13:35 -0400, Jon Smirl wrote: On Wed, Jul 28, 2010 at 1:02 PM, Andy Walls awa...@md.metrocast.net wrote: On Wed, 2010-07-28 at 12:42 -0300, Mauro

Re: [PATCH 1/9] IR: Kconfig fixes

On Wed, 2010-07-28 at 10:36 -0700, Randy Dunlap wrote: On Wed, 28 Jul 2010 18:14:03 +0300 Maxim Levitsky wrote: Move IR drives below separate menu. This allows to disable them. Also correct a typo. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR

Re: [PATCH 4/9] IR: add helper functions for ir input devices that send ir timing data in small chunks, and alternation between pulses and spaces isn't guaranteed.

On Wed, 2010-07-28 at 16:57 -0400, Jarod Wilson wrote: On Wed, Jul 28, 2010 at 01:46:27PM -0400, Jarod Wilson wrote: On Wed, Jul 28, 2010 at 06:14:06PM +0300, Maxim Levitsky wrote: Signed-off-by: Maxim Levitsky maximlevit...@gmail.com With the caveat of requiring an improved changelog

[no subject]

Subject: [PATCH 0/9 v2] IR: few fixes, additions and ENE driver Hi, This is second version of the patchset. Hopefully, I didn't forget to address all comments. In addition to comments, I changed helper function that processes samples so it sends last space as soon as timeout is reached. This

[PATCH 1/9] IR: Kconfig fixes

Move IR drives below separate menu. This allows to disable them. Also correct a typo. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/Kconfig | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/media/IR/Kconfig b/drivers/media/IR

[PATCH 2/9] IR: minor fixes:

* lirc: Don't propagate reset event to userspace * lirc: Remove strange logic from lirc that would make first sample always be pulse * Make TO_US macro actualy print what it should. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-core-priv.h |4 +--- drivers

[PATCH 3/9] IR: replace spinlock with mutex.

Some handlers (lirc for example) allocates memory on initialization, doing so in atomic context is cumbersome. Fixes warning about sleeping function in atomic context. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-raw-event.c | 28 ++-- 1

[PATCH 5/9] IR: extend interfaces to support more device settings

doesn't have space to indicate that. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-core-priv.h |2 + drivers/media/IR/ir-lirc-codec.c | 119 +++--- drivers/media/IR/ir-raw-event.c | 13 ++--- include/media/ir-core.h

[PATCH 6/9] IR: Allow not to compile keymaps in.

Currently, ir device registration fails if keymap requested by driver is not found. Fix that by always compiling in the empty keymap, and using it as a failback. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-core-priv.h |3 +- drivers/media/IR/ir-sysfs.c

[PATCH 4/9] IR: add helper function for hardware with small o/b buffer.

(a byte for example). Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-core-priv.h |1 + drivers/media/IR/ir-keytable.c |2 +- drivers/media/IR/ir-raw-event.c | 86 +++ include/media/ir-core.h | 24

[PATCH 7/9] IR: report unknown scancodes the in-kernel decoders found.

This way it is possible to use evtest to create keymap for unknown remote. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-keytable.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/drivers/media/IR/ir-keytable.c b/drivers/media/IR/ir

[PATCH 9/9] IR: Port ene driver to new IR subsystem and enable it.

it is accurate already. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/Kconfig | 14 + drivers/media/IR/Makefile |1 + drivers/media/IR/ene_ir.c | 589 + drivers/media/IR/ene_ir.h | 32 +-- 4 files changed, 241

[PATCH 0/9 v2] IR: few fixes, additions and ENE driver

On Thu, 2010-07-29 at 09:23 +0200, Christoph Bartelmus wrote: Hi Maxim, on 29 Jul 10 at 02:40, Maxim Levitsky wrote: [...] In addition to comments, I changed helper function that processes samples so it sends last space as soon as timeout is reached. This breaks somewhat lirc, because

Re: [PATCH 5/9] IR: extend interfaces to support more device settings

On Thu, 2010-07-29 at 09:25 +0200, Christoph Bartelmus wrote: Hi! Maxim Levitsky maximlevit...@gmail.com wrote: Also reuse LIRC_SET_MEASURE_CARRIER_MODE as LIRC_SET_LEARN_MODE (LIRC_SET_LEARN_MODE will start carrier reports if possible, and tune receiver to wide band mode) I don't

Re: [PATCH 0/9 v2] IR: few fixes, additions and ENE driver

On Wed, 2010-07-28 at 23:52 -0400, Jarod Wilson wrote: On Thu, Jul 29, 2010 at 02:40:43AM +0300, Maxim Levitsky wrote: Hi, This is second version of the patchset. Hopefully, I didn't forget to address all comments. In addition to comments, I changed helper function that processes

Re: [PATCH 0/9 v2] IR: few fixes, additions and ENE driver

On Thu, 2010-07-29 at 11:38 -0400, Andy Walls wrote: On Thu, 2010-07-29 at 17:41 +0300, Maxim Levitsky wrote: On Thu, 2010-07-29 at 09:23 +0200, Christoph Bartelmus wrote: Hi Maxim, on 29 Jul 10 at 02:40, Maxim Levitsky wrote: [...] In addition to comments, I changed helper

Re: [PATCH 0/9 v2] IR: few fixes, additions and ENE driver

On Thu, 2010-07-29 at 19:15 +0200, Christoph Bartelmus wrote: Hi Maxim, on 29 Jul 10 at 19:26, Maxim Levitsky wrote: On Thu, 2010-07-29 at 11:38 -0400, Andy Walls wrote: On Thu, 2010-07-29 at 17:41 +0300, Maxim Levitsky wrote: On Thu, 2010-07-29 at 09:23 +0200, Christoph Bartelmus wrote

Re: [PATCH 0/9 v2] IR: few fixes, additions and ENE driver

On Thu, 2010-07-29 at 18:58 +0200, Christoph Bartelmus wrote: Hi Maxim, on 29 Jul 10 at 17:41, Maxim Levitsky wrote: [...] Note that I send timeout report with zero value. I don't think that this value is importaint. This does not sound good. Of course the value is important

Re: [PATCH 0/9 v2] IR: few fixes, additions and ENE driver

On Thu, 2010-07-29 at 21:42 +0200, Christoph Bartelmus wrote: Hi! Maxim Levitsky maximlevit...@gmail.com wrote: On Thu, 2010-07-29 at 18:58 +0200, Christoph Bartelmus wrote: Hi Maxim, on 29 Jul 10 at 17:41, Maxim Levitsky wrote: [...] Note that I send timeout report with zero

Re: [PATCH 0/9 v2] IR: few fixes, additions and ENE driver

On Thu, 2010-07-29 at 21:35 +0200, Christoph Bartelmus wrote: Hi! Maxim Levitsky maximlevit...@gmail.com wrote: [...] Could you explain exactly how timeout reports work? [...] So, timeout report is just another sample, with a mark attached, that this is last sample? right

Re: [PATCH 0/9 v2] IR: few fixes, additions and ENE driver

On Thu, 2010-07-29 at 17:57 -0400, Jarod Wilson wrote: On Thu, Jul 29, 2010 at 5:28 PM, Jarod Wilson ja...@redhat.com wrote: On Thu, Jul 29, 2010 at 11:04:47PM +0300, Maxim Levitsky wrote: On Thu, 2010-07-29 at 21:35 +0200, Christoph Bartelmus wrote: Hi! Maxim Levitsky maximlevit

Re: [PATCH 0/9 v2] IR: few fixes, additions and ENE driver

On Fri, 2010-07-30 at 01:07 +0300, Maxim Levitsky wrote: On Thu, 2010-07-29 at 17:57 -0400, Jarod Wilson wrote: On Thu, Jul 29, 2010 at 5:28 PM, Jarod Wilson ja...@redhat.com wrote: On Thu, Jul 29, 2010 at 11:04:47PM +0300, Maxim Levitsky wrote: On Thu, 2010-07-29 at 21:35 +0200

[PATCH 0/9 v2] IR: few fixes, additions and ENE driver

new ioctl for learning mode still need to add carrier detect, timeout reports, and rx filter * replaced int with bool in my driver, plus few cleanups. * added myself to maintainers of the ene driver * added another PNP ID to ene driver Best regards, Maxim Levitsky -- To unsubscribe

[PATCH 01/13] IR: Kconfig fixes

Move IR drives below separate menu. This allows to disable them. Also correct a typo. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/Kconfig | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/media/IR/Kconfig b/drivers/media/IR

[PATCH 02/13] IR: minor fixes:

* lirc: Don't propagate reset event to userspace * lirc: Remove strange logic from lirc that would make first sample always be pulse * Make TO_US macro actualy print what it should. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-core-priv.h |4 +--- drivers

[PATCH 03/13] IR: replace spinlock with mutex.

Some handlers (lirc for example) allocates memory on initialization, doing so in atomic context is cumbersome. Fixes warning about sleeping function in atomic context. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-raw-event.c | 28 ++-- 1

[PATCH 04/13] IR: fix locking in ir_raw_event_work

It is prefectly possible to have ir_raw_event_work running concurently on two cpus, thus we must protect it from that situation. Maybe better solution is to ditch the workqueue at all and use good 'ol thread per receiver, and just wake it up... Signed-off-by: Maxim Levitsky maximlevit

[PATCH 05/13] IR: JVC: make repeat work

Currently, jvc decoder will attempt misdetect next press as a repeat of last keypress, therefore second keypress isn't detected. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-jvc-decoder.c | 14 +- 1 files changed, 13 insertions(+), 1 deletions

[PATCH 06/13] IR: nec decoder: fix repeat.

Repeat space is 4 units, not 8. Current code would never trigger a repeat. However that isn't true for NECX, so repeat there must be handled differently. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-nec-decoder.c |2 +- 1 files changed, 1 insertions(+), 1

[PATCH 07/13] IR: NECX: support repeat

This adds support for repeat detecting for NECX variant Tested with uneversal remote Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-core-priv.h |1 + drivers/media/IR/ir-nec-decoder.c | 16 ++-- 2 files changed, 15 insertions(+), 2 deletions

[PATCH 08/13] IR: Allow not to compile keymaps in.

Currently, ir device registration fails if keymap requested by driver is not found. Fix that by always compiling in the empty keymap, and using it as a failback. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-core-priv.h |3 +- drivers/media/IR/ir-sysfs.c

[PATCH 09/13] IR: add helper function for hardware with small o/b buffer.

(a byte for example). Also remove constness from ir_dev_props, because it now contains timeout settings that driver might want to change Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-core-priv.h |1 + drivers/media/IR/ir-keytable.c |2 +- drivers/media/IR

[PATCH 10/13] IR: extend interfaces to support more device settings LIRC: add new IOCTL that enables learning mode (wide band receiver)

Still missing features: carrier report timeout reports. Will need to pack these into ir_raw_event Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-core-priv.h |1 + drivers/media/IR/ir-lirc-codec.c | 112 +++--- include/media

[PATCH 11/13] IR: report unknown scancodes the in-kernel decoders found.

This way it is possible to use evtest to create keymap for unknown remote. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-keytable.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/media/IR/ir-keytable.c b/drivers/media/IR/ir

Re: [PATCH 04/13] IR: fix locking in ir_raw_event_work

On Thu, 2010-07-29 at 22:42 -0400, Andy Walls wrote: On Fri, 2010-07-30 at 05:17 +0300, Maxim Levitsky wrote: It is prefectly possible to have ir_raw_event_work running concurently on two cpus, thus we must protect it from that situation. Yup, the work is marked as not pending

Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

On Thu, 2010-07-29 at 23:46 -0400, Andy Walls wrote: On Thu, 2010-07-29 at 22:39 -0400, Jon Smirl wrote: On Thu, Jul 29, 2010 at 10:17 PM, Maxim Levitsky maximlevit...@gmail.com wrote: note that error_adjustment module option is added. This allows to reduce input samples by a percent

[PATCH 0/9 v3] IR: few fixes, additions and ENE driver

Hi, This is mostly same patchset. I addressed the comments of Andy Walls. Now IR decoding is done by a separate thread, and this fixes the race, and unnesesary performance loss due to it. Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line unsubscribe linux

[PATCH 02/13] IR: minor fixes:

* lirc: Don't propagate reset event to userspace * lirc: Remove strange logic from lirc that would make first sample always be pulse * Make TO_US macro actualy print what it should. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-core-priv.h |4 +--- drivers

[PATCH 01/13] IR: Kconfig fixes

Move IR drives below separate menu. This allows to disable them. Also correct a typo. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/Kconfig | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/media/IR/Kconfig b/drivers/media/IR

[PATCH 03/13] IR: replace spinlock with mutex.

Some handlers (lirc for example) allocates memory on initialization, doing so in atomic context is cumbersome. Fixes warning about sleeping function in atomic context. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-raw-event.c | 28 ++-- 1

[PATCH 04/13] IR: fix locking in ir_raw_event_work

It is prefectly possible to have ir_raw_event_work running concurently on two cpus, thus we must protect it from that situation. Just switch to a thread that we wake up as soon as we have data. This also ensures that this thread doesn't run unnessesarly. Signed-off-by: Maxim Levitsky maximlevit

[PATCH 05/13] IR: JVC: make repeat work

Currently, jvc decoder will attempt misdetect next press as a repeat of last keypress, therefore second keypress isn't detected. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-jvc-decoder.c | 14 +- 1 files changed, 13 insertions(+), 1 deletions

[PATCH 06/13] IR: nec decoder: fix repeat.

Repeat space is 4 units, not 8. Current code would never trigger a repeat. However that isn't true for NECX, so repeat there must be handled differently. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-nec-decoder.c |2 +- 1 files changed, 1 insertions(+), 1

[PATCH 08/13] IR: Allow not to compile keymaps in.

Currently, ir device registration fails if keymap requested by driver is not found. Fix that by always compiling in the empty keymap, and using it as a failback. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-core-priv.h |3 +- drivers/media/IR/ir-sysfs.c

[PATCH 07/13] IR: NECX: support repeat

This adds support for repeat detecting for NECX variant Tested with uneversal remote Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-core-priv.h |1 + drivers/media/IR/ir-nec-decoder.c | 16 ++-- 2 files changed, 15 insertions(+), 2 deletions

[PATCH 09/13] IR: add helper function for hardware with small o/b buffer.

(a byte for example). Also remove constness from ir_dev_props, because it now contains timeout settings that driver might want to change Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-core-priv.h |1 + drivers/media/IR/ir-keytable.c |2 +- drivers/media/IR

[PATCH 11/13] IR: report unknown scancodes the in-kernel decoders found.

This way it is possible to use evtest to create keymap for unknown remote. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-keytable.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/media/IR/ir-keytable.c b/drivers/media/IR/ir

[PATCH 10/13] IR: extend interfaces to support more device settings LIRC: add new IOCTL that enables learning mode (wide band receiver)

Still missing features: carrier report timeout reports. Will need to pack these into ir_raw_event Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-core-priv.h |1 + drivers/media/IR/ir-lirc-codec.c | 112 +++--- include/media

[PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- MAINTAINERS |6 + drivers/media/IR/Kconfig | 14 + drivers/media/IR/Makefile |1 + drivers/media/IR/ene_ir.c | 595 + drivers/media/IR/ene_ir.h | 51 ++--- 5 files

Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

On Fri, 2010-07-30 at 07:51 -0400, Jon Smirl wrote: On Fri, Jul 30, 2010 at 7:36 AM, Maxim Levitsky maximlevit...@gmail.com wrote: On Thu, 2010-07-29 at 23:46 -0400, Andy Walls wrote: On Thu, 2010-07-29 at 22:39 -0400, Jon Smirl wrote: On Thu, Jul 29, 2010 at 10:17 PM, Maxim Levitsky

Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

On Fri, 2010-07-30 at 08:07 -0400, Jon Smirl wrote: On Fri, Jul 30, 2010 at 8:02 AM, Jon Smirl jonsm...@gmail.com wrote: On Fri, Jul 30, 2010 at 7:54 AM, Maxim Levitsky maximlevit...@gmail.com wrote: On Fri, 2010-07-30 at 07:51 -0400, Jon Smirl wrote: On Fri, Jul 30, 2010 at 7:36 AM

Re: [PATCH 0/9 v3] IR: few fixes, additions and ENE driver

On Fri, 2010-07-30 at 16:33 -0300, Mauro Carvalho Chehab wrote: Em 30-07-2010 08:38, Maxim Levitsky escreveu: Hi, This is mostly same patchset. I addressed the comments of Andy Walls. Now IR decoding is done by a separate thread, and this fixes the race, and unnesesary

Re: [PATCH 06/13] IR: nec decoder: fix repeat.

On Fri, 2010-07-30 at 16:36 -0300, Mauro Carvalho Chehab wrote: Em 30-07-2010 08:38, Maxim Levitsky escreveu: Repeat space is 4 units, not 8. Current code would never trigger a repeat. Yes, this fixed the issue: Jul 30 16:53:52 agua kernel: [24343.507577] ir_getkeycode: unknown key

Re: [PATCH 10/13] IR: extend interfaces to support more device settings LIRC: add new IOCTL that enables learning mode (wide band receiver)

On Fri, 2010-07-30 at 23:22 +0200, Christoph Bartelmus wrote: Hi! Maxim Levitsky maximlevit...@gmail.com wrote: Still missing features: carrier report timeout reports. Will need to pack these into ir_raw_event Hm, this patch changes the LIRC interface but I can't see the according

Re: [PATCH 10/13] IR: extend interfaces to support more device settings LIRC: add new IOCTL that enables learning mode (wide band receiver)

On Sat, 2010-07-31 at 10:10 +0200, Christoph Bartelmus wrote: Hi Maxim, on 31 Jul 10 at 01:01, Maxim Levitsky wrote: On Fri, 2010-07-30 at 23:22 +0200, Christoph Bartelmus wrote: [...] +#define LIRC_SET_WIDEBAND_RECEIVER _IOW('i', 0x0023, __u32) If you really want this new

Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

On Sat, 2010-07-31 at 09:55 -0400, Andy Walls wrote: On Fri, 2010-07-30 at 15:45 +0300, Maxim Levitsky wrote: On Fri, 2010-07-30 at 08:07 -0400, Jon Smirl wrote: On Fri, Jul 30, 2010 at 8:02 AM, Jon Smirl jonsm...@gmail.com wrote: On Fri, Jul 30, 2010 at 7:54 AM, Maxim Levitsky

Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

On Sat, 2010-07-31 at 10:37 -0400, Jon Smirl wrote: On Sat, Jul 31, 2010 at 10:28 AM, Maxim Levitsky maximlevit...@gmail.com wrote: On Sat, 2010-07-31 at 09:55 -0400, Andy Walls wrote: On Fri, 2010-07-30 at 15:45 +0300, Maxim Levitsky wrote: On Fri, 2010-07-30 at 08:07 -0400, Jon Smirl

[PATCH 0/9 v4] IR: few fixes, additions and ENE driver

Hi, 4th revision of my patches below: Changes: * more carefull repeat support in NECX protocol * added documentation for wide band mode ioctl * fix for 64 bit divide * updated summary of patches, and preserved few * Acked/Reviewed by tags you gave me. Best regards, Maxim Levitsky

[PATCH 01/13] IR: Kconfig fixes

Move IR drives below separate menu. This allows to disable them. Also correct a typo. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/Kconfig | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/media/IR/Kconfig b/drivers/media/IR

[PATCH 05/13] IR: JVC: make repeat work

Currently, jvc decoder will attempt misdetect next press as a repeat of last keypress, therefore second keypress isn't detected. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-jvc-decoder.c | 14 +- 1 files changed, 13 insertions(+), 1 deletions

[PATCH 06/13] IR: nec decoder: fix repeat.

Repeat space is 4 units, not 8. Current code would never trigger a repeat. However that isn't true for NECX, so repeat there must be handled differently. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com Reviewed-by: Andy Walls awa...@md.metrocast.net --- drivers/media/IR/ir-nec-decoder.c

[PATCH 07/13] IR: NECX: support repeat

This adds support for repeat detecting for NECX variant Tested with uneversal remote Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-core-priv.h |2 ++ drivers/media/IR/ir-nec-decoder.c | 23 +-- 2 files changed, 23 insertions(+), 2

[PATCH 11/13] IR: report unknown scancodes the in-kernel decoders found.

This way it is possible to use evtest to create keymap for unknown remote. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-keytable.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/media/IR/ir-keytable.c b/drivers/media/IR/ir

[PATCH 10/13] IR: extend interfaces to support more device settings

LIRC: add new IOCTL that enables learning mode (wide band receiver) Still missing features: carrier report timeout reports. Will need to pack these into ir_raw_event Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- .../DocBook/v4l/lirc_device_interface.xml | 16 +++ drivers

[PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- MAINTAINERS |6 + drivers/media/IR/Kconfig | 14 + drivers/media/IR/Makefile |1 + drivers/media/IR/ene_ir.c | 595 + drivers/media/IR/ene_ir.h | 51 ++--- 5 files

[PATCH 09/13] IR: add helper function for hardware with small o/b buffer.

(a byte for example). Also remove constness from ir_dev_props, because it now contains timeout settings that driver might want to change Signed-off-by: Maxim Levitsky maximlevit...@gmail.com Acked-by: Jarod Wilson ja...@redhat.com --- drivers/media/IR/ir-core-priv.h |1 + drivers/media/IR/ir

Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

the input. A expiration of sample period might just cause a IRQ inside that microprocessor, and it can't process it instantly. That is probably the source of the delay. Or something like that. Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line unsubscribe linux-media

Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

. Instead of doing the math in calculator and plugging in 32. Use #defines and do the math in the There is no reason to worry about rounding here. hw_sample is maximum of 127 * 50, so when I muliply by 100 I get exact result. Then I do one divide. Best regards, Maxim Levitsky -- To unsubscribe

Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

On Sat, 2010-07-31 at 17:53 -0400, Jon Smirl wrote: On Sat, Jul 31, 2010 at 2:51 PM, Andy Walls awa...@md.metrocast.net wrote: On Sat, 2010-07-31 at 14:14 -0400, Jon Smirl wrote: On Sat, Jul 31, 2010 at 1:47 PM, Christoph Bartelmus l...@bartelmus.de wrote: Hi Jon, on 31 Jul 10 at

Re: [PATCH 09/13] IR: add helper function for hardware with small o/b buffer.

On Sun, 2010-08-01 at 22:11 -0400, Andy Walls wrote: On Sat, 2010-07-31 at 17:59 +0300, Maxim Levitsky wrote: Some ir input devices have small buffer, and interrupt the host each time it is full (or half full) Add a helper that automaticly handles timeouts, and also automaticly merges

Re: [patch] IR: ene_ir: problems in unwinding on probe

regards, Maxim Levitsky diff --git a/drivers/media/IR/ene_ir.c b/drivers/media/IR/ene_ir.c index 5447750..8e5e964 100644 --- a/drivers/media/IR/ene_ir.c +++ b/drivers/media/IR/ene_ir.c @@ -781,21 +781,24 @@ static int ene_probe(struct pnp_dev *pnp_dev, const struct pnp_device_id *id

Re: [patch] IR: ene_ir: problems in unwinding on probe

On Thu, 2010-08-12 at 18:19 +0200, Dan Carpenter wrote: On Thu, Aug 12, 2010 at 05:35:04PM +0300, Maxim Levitsky wrote: On Thu, 2010-08-12 at 09:46 +0200, Dan Carpenter wrote: There were a couple issues here. If the allocation failed for dev then it would lead to a NULL dereference

Re: Remote that breaks current system

thinking that I like the approach of only explicitly loading it from the streamzap driver though. Just one minor nitpick. You could 'use' the original RC5 decoder, but add a knob to it to make it accept 15 bits instead of 14. However, this will require some interface changes. Best regards, Maxim

Many fixes for in-kernel decoding + ENE driver

regards, Maxim Levitsky -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/7] IR: plug races in handling threads.

Unfortunelly (my fault) the kernel thread that now handles IR processing has classical races in regard to wakeup and stop. This patch hopefully closes them all. Tested with module reload running in a loop, while receiver is blasted with IR data for 10 minutes. Signed-off-by: Maxim Levitsky

[PATCH 2/7] IR: make sure we register input device when it safe to do so.

decides to send and interrupt right at the moment it is enabled. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-core-priv.h |1 + drivers/media/IR/ir-keytable.c |2 ++ drivers/media/IR/ir-sysfs.c | 27 +-- 3 files changed, 20

[PATCH 3/7] IR: fix duty cycle capability

Due to typo lirc bridge enabled wrong capability. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-lirc-codec.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/IR/ir-lirc-codec.c b/drivers/media/IR/ir-lirc-codec.c index 77b5946

[PATCH 4/7] IR: fix keys beeing stuck down forever.

to avoid (that the timeout is in the future) Confusing Eh? Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-keytable.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/IR/ir-keytable.c b/drivers/media/IR/ir-keytable.c index 3f0dd80

[PATCH 5/7] ene_ir: updates

* Add support for newer firmware versions with different buffer format. Makes hardware work for many users * Register name updates + refactoring * Lots of fixes as a result of full testing Every feature of the driver is now well tested. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com

[PATCH 6/7] IR: extend ir_raw_event and do refactoring

be initialized like that: struct ir_raw_event ev = ir_new_event; Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ene_ir.c |2 +- drivers/media/IR/ene_ir.h |2 +- drivers/media/IR/ir-core-priv.h| 11 +- drivers/media/IR/ir-jvc-decoder.c

[PATCH 7/7] ENE: add support for carrier reports

Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ene_ir.c | 47 +++- 1 files changed, 37 insertions(+), 10 deletions(-) diff --git a/drivers/media/IR/ene_ir.c b/drivers/media/IR/ene_ir.c index c7bbbca..dfb822b 100644

Re: [PATCH 6/7] IR: extend ir_raw_event and do refactoring

On Thu, 2010-09-02 at 22:56 +0200, David Härdeman wrote: On Mon, Aug 30, 2010 at 11:52:26AM +0300, Maxim Levitsky wrote: Add new event types for timeout carrier report Move timeout handling from ir_raw_event_store_with_filter to ir-lirc-codec, where it is really needed. Yes

Re: [PATCH 0/8 V3] Many fixes for in-kernel decoding and for the ENE driver

On Sun, 2010-09-05 at 23:06 +0200, David Härdeman wrote: On Sun, Sep 05, 2010 at 02:22:55AM +0300, Maxim Levitsky wrote: Hi, This is next version of my patchset. I addressed the comments from David Härdeman, And in addition to that did a lot of cleanups in the ENE

Re: [PATCH 7/8] IR: extend ir_raw_event and do refactoring

On Sun, 2010-09-05 at 23:23 +0200, David Härdeman wrote: Comments inline... On Sun, Sep 05, 2010 at 02:23:02AM +0300, Maxim Levitsky wrote: Add new event types for timeout carrier report Move timeout handling from ir_raw_event_store_with_filter to ir-lirc-codec, where it is really

[PATCH 0/8 V5] Many fixes for in-kernel decoding and for the ENE driver

on top of patch #7 and adds carrier reports to ene driver. Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/8] IR: plug races in IR raw thread.

Unfortunelly (my fault) the kernel thread that now handles IR processing has classical races in regard to wakeup and stop. This patch hopefully closes them all. Tested with module reload running in a loop, while receiver is blasted with IR data for 10 minutes. Signed-off-by: Maxim Levitsky

[PATCH 2/8] IR: make sure we register the input device when it is safe to do so.

where hardware decides to send an interrupt right at the moment it is enabled. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-core-priv.h |1 + drivers/media/IR/ir-keytable.c |2 ++ drivers/media/IR/ir-sysfs.c | 27 +-- 3 files

  1   2   >